(tinkerpop) 01/02: Re-enable and fix shouldBlowTheWorkQueueSize test CTR.
This is an automated email from the ASF dual-hosted git repository.
kenhuuu pushed a commit to branch http-initial-error-fix
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit 0bc007e3cb57045fd61fdcbd4f3918622f8796c3
Author: Ken Hu <106191785+kenh...@users.noreply.github.com>
AuthorDate: Sat Jun 8 10:53:04 2024 -0700
Re-enable and fix shouldBlowTheWorkQueueSize test CTR.
Server error handling was incorrect in some cases as the initial
HttpResponse is never sent if the failure happened before the task is
submitted. The driver didn't properly handle errors that were
serialized in GraphBinary.
---
.../handler/HttpGremlinResponseStreamDecoder.java | 15 +++--
.../server/handler/HttpGremlinEndpointHandler.java | 2 +
.../gremlin/server/handler/HttpHandlerUtil.java| 15 +
.../tinkerpop/gremlin/server/handler/StateKey.java | 5 ++
.../gremlin/server/GremlinServerIntegrateTest.java | 69 +++---
5 files changed, 65 insertions(+), 41 deletions(-)
diff --git
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinResponseStreamDecoder.java
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinResponseStreamDecoder.java
index d38220a4ca..d271e0dc0d 100644
---
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinResponseStreamDecoder.java
+++
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinResponseStreamDecoder.java
@@ -24,6 +24,7 @@ import io.netty.handler.codec.MessageToMessageDecoder;
import io.netty.handler.codec.TooLongFrameException;
import io.netty.handler.codec.http.DefaultHttpObject;
import io.netty.handler.codec.http.HttpContent;
+import io.netty.handler.codec.http.HttpHeaderNames;
import io.netty.handler.codec.http.HttpHeaders;
import io.netty.handler.codec.http.HttpResponse;
import io.netty.handler.codec.http.HttpResponseStatus;
@@ -34,7 +35,9 @@ import io.netty.util.AttributeMap;
import io.netty.util.CharsetUtil;
import org.apache.tinkerpop.gremlin.util.MessageSerializerV4;
import org.apache.tinkerpop.gremlin.util.message.ResponseMessageV4;
+import org.apache.tinkerpop.gremlin.util.ser.SerTokensV4;
import org.apache.tinkerpop.gremlin.util.ser.SerializationException;
+import org.apache.tinkerpop.gremlin.util.ser.SerializersV4;
import org.apache.tinkerpop.shaded.jackson.databind.JsonNode;
import org.apache.tinkerpop.shaded.jackson.databind.ObjectMapper;
@@ -45,6 +48,7 @@ public class HttpGremlinResponseStreamDecoder extends
MessageToMessageDecoder IS_FIRST_CHUNK =
AttributeKey.valueOf("isFirstChunk");
private static final AttributeKey RESPONSE_STATUS =
AttributeKey.valueOf("responseStatus");
+private static final AttributeKey RESPONSE_ENCODING =
AttributeKey.valueOf("responseSerializer");
private static final AttributeKey BYTES_READ =
AttributeKey.valueOf("bytesRead");
private final MessageSerializerV4 serializer;
@@ -60,14 +64,14 @@ public class HttpGremlinResponseStreamDecoder extends
MessageToMessageDecoder out) throws Exception {
final Attribute isFirstChunk = ((AttributeMap)
ctx).attr(IS_FIRST_CHUNK);
final Attribute responseStatus = ((AttributeMap)
ctx).attr(RESPONSE_STATUS);
+final Attribute responseEncoding = ((AttributeMap)
ctx).attr(RESPONSE_ENCODING);
if (msg instanceof HttpResponse) {
ctx.channel().attr(BYTES_READ).set(0);
-responseStatus.set(((HttpResponse) msg).status());
-if (isError(((HttpResponse) msg).status())) {
-return;
-}
+final HttpResponse resp = (HttpResponse) msg;
+responseStatus.set(resp.status());
+
responseEncoding.set(resp.headers().get(HttpHeaderNames.CONTENT_TYPE));
isFirstChunk.set(true);
}
@@ -88,9 +92,8 @@ public class HttpGremlinResponseStreamDecoder extends
MessageToMessageDecoder> serializer =
ctx.channel().attr(StateKey.SERIALIZER).get();
final Context requestCtx = new Context(requestMessage, ctx, settings,
graphManager, gremlinExecutor,
@@ -200,6 +201,7 @@ public class HttpGremlinEndpointHandler extends
SimpleChannelInboundHandler REQUEST_ID =
AttributeKey.valueOf("requestId");
+/**
+ * The key for whether a {@link io.netty.handler.codec.http.HttpResponse}
has been sent for the current response.
+ */
+public static final AttributeKey HTTP_RESPONSE_SENT =
AttributeKey.valueOf("responseSent");
+
/**
* The key for the current {@link AuthenticatedUser}.
*/
diff --git
a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java
b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java
index 75dcf666c7..ac153b4dc0 100644
---
a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java
+++
(tinkerpop) 02/02: Update timing of returning connection and server pipelining CTR.
This is an automated email from the ASF dual-hosted git repository.
kenhuuu pushed a commit to branch http-initial-error-fix
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit cb1d34caeb7ac2cd8c7335766cdf9229fc02b5de
Author: Ken Hu <106191785+kenh...@users.noreply.github.com>
AuthorDate: Tue Jun 11 18:42:16 2024 -0700
Update timing of returning connection and server pipelining CTR.
The connection was being returned back to the pool too early as
sometimes the LastHttpContent had not yet been received. Changing it to
only release after the LastHttpContent has been received will prevent
accidentally using the same channel for multiple requests.
The server will now ignore incoming requests if it is already handling a
request which stops pipelining from working altogether. This prevents
accidentally using the same channel for multiple requests on the server
side which caused errors due to concurrent modification of channel
state.
---
.../tinkerpop/gremlin/driver/Channelizer.java | 3 ++-
.../driver/handler/GremlinResponseHandler.java | 9
.../handler/HttpGremlinResponseStreamDecoder.java | 24 +++--
.../server/handler/HttpRequestIdHandler.java | 25 +-
4 files changed, 49 insertions(+), 12 deletions(-)
diff --git
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java
index d2e393f100..41f3f5eb13 100644
---
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java
+++
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java
@@ -28,6 +28,7 @@ import io.netty.channel.socket.SocketChannel;
import io.netty.handler.codec.http.HttpClientCodec;
import io.netty.handler.ssl.SslContext;
import io.netty.handler.ssl.SslHandler;
+import io.netty.util.AttributeKey;
import org.apache.tinkerpop.gremlin.driver.handler.GremlinResponseHandler;
import org.apache.tinkerpop.gremlin.driver.handler.HttpGremlinRequestEncoder;
import
org.apache.tinkerpop.gremlin.driver.handler.HttpGremlinResponseStreamDecoder;
@@ -155,7 +156,7 @@ public interface Channelizer extends ChannelHandler {
* channelizer. Only sessionless requests are possible.
*/
final class HttpChannelizer extends AbstractChannelizer {
-
+public static final AttributeKey LAST_CONTENT_READ =
AttributeKey.valueOf("lastContentRead");
private HttpGremlinRequestEncoder gremlinRequestEncoder;
private HttpGremlinResponseStreamDecoder gremlinResponseDecoder;
diff --git
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/GremlinResponseHandler.java
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/GremlinResponseHandler.java
index 88e8a740e6..8b550c86d2 100644
---
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/GremlinResponseHandler.java
+++
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/GremlinResponseHandler.java
@@ -34,6 +34,8 @@ import org.slf4j.LoggerFactory;
import java.util.List;
import java.util.concurrent.atomic.AtomicReference;
+import static
org.apache.tinkerpop.gremlin.driver.Channelizer.HttpChannelizer.LAST_CONTENT_READ;
+
/**
* Takes a map of requests pending responses and writes responses to the
{@link ResultQueue} of a request
* as the {@link ResponseMessageV4} objects are deserialized.
@@ -60,10 +62,10 @@ public class GremlinResponseHandler extends
SimpleChannelInboundHandler data = response.getResult().getData();
// unrolls the collection into individual results to be handled by
the queue.
data.forEach(item -> queue.add(new Result(item)));
@@ -75,8 +77,7 @@ public class GremlinResponseHandler extends
SimpleChannelInboundHandler {
+import static
org.apache.tinkerpop.gremlin.driver.Channelizer.HttpChannelizer.LAST_CONTENT_READ;
+public class HttpGremlinResponseStreamDecoder extends
MessageToMessageDecoder {
private static final AttributeKey IS_FIRST_CHUNK =
AttributeKey.valueOf("isFirstChunk");
private static final AttributeKey RESPONSE_STATUS =
AttributeKey.valueOf("responseStatus");
private static final AttributeKey RESPONSE_ENCODING =
AttributeKey.valueOf("responseSerializer");
private static final AttributeKey BYTES_READ =
AttributeKey.valueOf("bytesRead");
+private static final ResponseMessageV4 EMPTY_RESPONSE =
+
ResponseMessageV4.build().code(HttpResponseStatus.OK).result(Collections.emptyList()).create();
+
private final MessageSerializerV4 serializer;
private final int maxContentLength;
private final ObjectMapper mapper = new ObjectMapper();
@@ -68,6 +73,7 @@ public class HttpGremlinResponseStreamDecoder extends
MessageToMessageDecoder IN_USE =
AttributeKey.valueOf("inUse");
+
public static
(tinkerpop) branch http-initial-error-fix updated (dcd0c96d63 -> cb1d34caeb)
This is an automated email from the ASF dual-hosted git repository. kenhuuu pushed a change to branch http-initial-error-fix in repository https://gitbox.apache.org/repos/asf/tinkerpop.git discard dcd0c96d63 Re-enable and fix shouldBlowTheWorkQueueSize test. new 0bc007e3cb Re-enable and fix shouldBlowTheWorkQueueSize test CTR. new cb1d34caeb Update timing of returning connection and server pipelining CTR. This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (dcd0c96d63) \ N -- N -- N refs/heads/http-initial-error-fix (cb1d34caeb) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../tinkerpop/gremlin/driver/Channelizer.java | 3 ++- .../driver/handler/GremlinResponseHandler.java | 9 .../handler/HttpGremlinResponseStreamDecoder.java | 24 +++-- .../server/handler/HttpRequestIdHandler.java | 25 +- 4 files changed, 49 insertions(+), 12 deletions(-)
Re: [PR] Release msg in finally block on HttpGremlinEndpointHandler [tinkerpop]
rdtr closed pull request #1727: Release msg in finally block on HttpGremlinEndpointHandler URL: https://github.com/apache/tinkerpop/pull/1727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch valentyn/bytecode-poc updated (c62202e7fc -> 9d5bf7be89)
This is an automated email from the ASF dual-hosted git repository. valentyn pushed a change to branch valentyn/bytecode-poc in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from c62202e7fc added test for Bindings add 9d5bf7be89 variable renaming No new revisions were added by this update. Summary of changes: .../tinkerpop/gremlin/jsr223/GremlinLangScriptEngine.java | 8 .../apache/tinkerpop/gremlin/jsr223/JavaTranslator.java| 8 .../gremlin/language/grammar/NoOpTerminalVisitor.java | 2 +- .../tinkerpop/gremlin/process/traversal/GraphOp.java | 4 ++-- .../tinkerpop/gremlin/process/traversal/GremlinLang.java | 10 +- .../tinkerpop/gremlin/process/traversal/Translator.java| 4 ++-- .../traversal/lambda/CardinalityValueTraversal.java| 6 +++--- .../tinkerpop/gremlin/groovy/engine/GremlinExecutor.java | 14 +++--- .../gremlin/driver/GraphBinaryReaderWriterBenchmark.java | 12 ++-- .../tinkerpop/gremlin/driver/SerializationBenchmark.java | 12 ++-- 10 files changed, 40 insertions(+), 40 deletions(-)
Re: [PR] Bytecode removal from Java GLV [tinkerpop]
vkagamlyk commented on code in PR #2648:
URL: https://github.com/apache/tinkerpop/pull/2648#discussion_r1635554947
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/GremlinLangScriptEngine.java:
##
@@ -79,7 +79,7 @@ public GremlinScriptEngineFactory getFactory() {
* Bytecode is evaluated by the {@link JavaTranslator}.
*/
@Override
-public Traversal.Admin eval(final Bytecode bytecode, final Bindings
bindings, final String traversalSource) throws ScriptException {
+public Traversal.Admin eval(final GremlinLang bytecode, final Bindings
bindings, final String traversalSource) throws ScriptException {
Review Comment:
I hope to remove this altogether in one of the next PRs,
'GremlinScriptEngineFactory' will handle only gremlin scripts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(tinkerpop) 01/01: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit ae9a5c42df7618c700d684386bb7ed57436e8a8d
Merge: 580cfa146e 7584e69f73
Author: Cole-Greer
AuthorDate: Tue Jun 11 13:22:20 2024 -0700
Merge branch '3.7-dev'
.../process/traversal/step/filter/SampleGlobalStep.java | 4
.../gremlin/process/traversal/step/map/SampleLocalStep.java | 4
gremlin-go/go.mod| 4 ++--
gremlin-go/go.sum| 8
.../src/main/javascript/gremlin-javascript/package-lock.json | 12 ++--
5 files changed, 20 insertions(+), 12 deletions(-)
diff --cc gremlin-go/go.mod
index d073088c4d,3659929472..a1b8cfb5be
--- a/gremlin-go/go.mod
+++ b/gremlin-go/go.mod
@@@ -40,5 -40,6 +40,5 @@@ require
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/spf13/pflag v1.0.5 // indirect
github.com/stretchr/objx v0.5.2 // indirect
- golang.org/x/net v0.17.0 // indirect
+ golang.org/x/net v0.23.0 // indirect
- gopkg.in/yaml.v3 v3.0.1 // indirect
)
diff --cc
gremlin-javascript/src/main/javascript/gremlin-javascript/package-lock.json
index 8d31d2e0d2,345382c6e7..b5abbdde6c
---
a/gremlin-javascript/src/main/javascript/gremlin-javascript/package-lock.json
+++
b/gremlin-javascript/src/main/javascript/gremlin-javascript/package-lock.json
@@@ -3982,2176 -3908,65 +3982,2176 @@@
"node": ">=10"
},
"funding": {
-"url": "https://github.com/chalk/wrap-ansi?sponsor=1;
+"url": "https://github.com/sponsors/sindresorhus;
}
},
-"node_modules/wrap-ansi/node_modules/ansi-styles": {
- "version": "4.3.0",
- "resolved":
"https://registry.npmjs.org/ansi-styles/-/ansi-styles-4.3.0.tgz;,
- "integrity":
"sha512-zbB9rCJAT1rbjiVDb2hqKFHNYLxgtk8NURxZ3IZwD3F6NtxbXZQCnnSi1Lkx+IDohdPlFp222wVALIheZJQSEg==",
+"node_modules/mocha/node_modules/glob": {
+ "version": "8.1.0",
+ "resolved": "https://registry.npmjs.org/glob/-/glob-8.1.0.tgz;,
+ "integrity":
"sha512-r8hpEjiQEYlF2QU0df3dS+nxxSIreXQS1qRhMJM0Q5NDdR386C7jb7Hwwod8Fgiuex+k0GFjgft18yvxm5XoCQ==",
"dev": true,
"dependencies": {
-"color-convert": "^2.0.1"
+"fs.realpath": "^1.0.0",
+"inflight": "^1.0.4",
+"inherits": "2",
+"minimatch": "^5.0.1",
+"once": "^1.3.0"
},
"engines": {
-"node": ">=8"
+"node": ">=12"
},
"funding": {
-"url": "https://github.com/chalk/ansi-styles?sponsor=1;
+"url": "https://github.com/sponsors/isaacs;
+ }
+},
+"node_modules/mocha/node_modules/js-yaml": {
+ "version": "4.1.0",
+ "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.0.tgz;,
+ "integrity":
"sha512-wpxZs9NoxZaJESJGIZTyDEaYpl0FKSA+FB9aJiyemKhMwkxQg63h4T1KJgUGHpTqPDNRcmmYLugrRjJlBtWvRA==",
+ "dev": true,
+ "dependencies": {
+"argparse": "^2.0.1"
+ },
+ "bin": {
+"js-yaml": "bin/js-yaml.js"
+ }
+},
+"node_modules/mocha/node_modules/minimatch": {
+ "version": "5.0.1",
+ "resolved":
"https://registry.npmjs.org/minimatch/-/minimatch-5.0.1.tgz;,
+ "integrity":
"sha512-nLDxIFRyhDblz3qMuq+SoRZED4+miJ/G+tdDrjkkkRnjAsBexeGpgjLEQ0blJy7rHhR2b93rhQY4SvyWu9v03g==",
+ "dev": true,
+ "dependencies": {
+"brace-expansion": "^2.0.1"
+ },
+ "engines": {
+"node": ">=10"
+ }
+},
+"node_modules/mocha/node_modules/minimatch/node_modules/brace-expansion":
{
+ "version": "2.0.1",
+ "resolved":
"https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.1.tgz;,
+ "integrity":
"sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==",
+ "dev": true,
+ "dependencies": {
+"balanced-match": "^1.0.0"
+ }
+},
+"node_modules/mocha/node_modules/ms": {
+ "version": "2.1.3",
+ "resolved": "https://registry.npmjs.org/ms/-/ms-2.1.3.tgz;,
+ "integrity":
"sha512-6FlzubTLZG3J2a/NVCAleEhjzq5oxgHyaCU9yYXvcLsvoVaHJq/s5xXI6/XXP6tz7R9xAOtHnSO/tXtF3WRTlA==",
+ "dev": true
+},
+"node_modules/mocha/node_modules/supports-color": {
+ "version": "8.1.1",
+ "resolved":
"https://registry.npmjs.org/supports-color/-/supports-color-8.1.1.tgz;,
+ "integrity":
"sha512-MpUEN2OodtUzxvKQl72cUF7RQ5EiHsGvSsVG0ia9c5RbWGL2CI4C7EpPS8UTBIplnlzZiNuV56w+FuNxy3ty2Q==",
+ "dev": true,
+ "dependencies": {
+"has-flag": "^4.0.0"
+ },
+ "engines": {
+"node": ">=10"
+ },
+ "funding": {
+"url": "https://github.com/chalk/supports-color?sponsor=1;
+ }
+},
+"node_modules/ms": {
+
(tinkerpop) branch master updated (580cfa146e -> ae9a5c42df)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 580cfa146e CTR Squashed docs/gremlint dependabots add 8623b2e05a adding getters for internal fields inside sample step. (#2649) add 16b871959d Bump github.com/gorilla/websocket from 1.5.1 to 1.5.2 in /gremlin-go (#2647) add 08dea3489a Bump ws in /gremlin-javascript/src/main/javascript/gremlin-javascript (#2577) add 7584e69f73 Merge branch '3.6-dev' into 3.7-dev new ae9a5c42df Merge branch '3.7-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../process/traversal/step/filter/SampleGlobalStep.java | 4 .../gremlin/process/traversal/step/map/SampleLocalStep.java | 4 gremlin-go/go.mod| 4 ++-- gremlin-go/go.sum| 8 .../src/main/javascript/gremlin-javascript/package-lock.json | 12 ++-- 5 files changed, 20 insertions(+), 12 deletions(-)
(tinkerpop) branch 3.7-dev updated (8623b2e05a -> 7584e69f73)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 8623b2e05a adding getters for internal fields inside sample step. (#2649) add 16b871959d Bump github.com/gorilla/websocket from 1.5.1 to 1.5.2 in /gremlin-go (#2647) add 08dea3489a Bump ws in /gremlin-javascript/src/main/javascript/gremlin-javascript (#2577) new 7584e69f73 Merge branch '3.6-dev' into 3.7-dev The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: gremlin-go/go.mod| 4 ++-- gremlin-go/go.sum| 8 .../src/main/javascript/gremlin-javascript/package-lock.json | 12 ++-- 3 files changed, 12 insertions(+), 12 deletions(-)
(tinkerpop) 01/01: Merge branch '3.6-dev' into 3.7-dev
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 7584e69f73b8bf156af292f75834386103d9393e Merge: 8623b2e05a 08dea3489a Author: Cole-Greer AuthorDate: Tue Jun 11 13:13:15 2024 -0700 Merge branch '3.6-dev' into 3.7-dev gremlin-go/go.mod| 4 ++-- gremlin-go/go.sum| 8 .../src/main/javascript/gremlin-javascript/package-lock.json | 12 ++-- 3 files changed, 12 insertions(+), 12 deletions(-)
Re: [PR] Bytecode removal from Java GLV [tinkerpop]
xiazcy commented on code in PR #2648:
URL: https://github.com/apache/tinkerpop/pull/2648#discussion_r1635171704
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/GremlinLangScriptEngine.java:
##
@@ -79,7 +79,7 @@ public GremlinScriptEngineFactory getFactory() {
* Bytecode is evaluated by the {@link JavaTranslator}.
*/
@Override
-public Traversal.Admin eval(final Bytecode bytecode, final Bindings
bindings, final String traversalSource) throws ScriptException {
+public Traversal.Admin eval(final GremlinLang bytecode, final Bindings
bindings, final String traversalSource) throws ScriptException {
Review Comment:
nit: rename variable as well to avoid confusion. I see this throughout all
files, so prob need a search and update all references at some point.
```suggestion
public Traversal.Admin eval(final GremlinLang gremlinLang, final
Bindings bindings, final String traversalSource) throws ScriptException {
```
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/BytecodeHelper.java:
##
@@ -177,7 +175,7 @@
import java.util.stream.Stream;
/**
- * Utility class for parsing {@link Bytecode}.
+ * Utility class for parsing {@link GremlinLang}.
Review Comment:
nit: don't forget classname update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(tinkerpop) branch 3.6-dev updated: Bump ws in /gremlin-javascript/src/main/javascript/gremlin-javascript (#2577)
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch 3.6-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/3.6-dev by this push:
new 08dea3489a Bump ws in
/gremlin-javascript/src/main/javascript/gremlin-javascript (#2577)
08dea3489a is described below
commit 08dea3489aeb697f470f1c9093f8b719271849a9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AuthorDate: Tue Jun 11 13:12:29 2024 -0700
Bump ws in /gremlin-javascript/src/main/javascript/gremlin-javascript
(#2577)
Bumps [ws](https://github.com/websockets/ws) from 8.16.0 to 8.17.0.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/compare/8.16.0...8.17.0)
---
updated-dependencies:
- dependency-name: ws
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot]
Co-authored-by: dependabot[bot]
<49699333+dependabot[bot]@users.noreply.github.com>
---
.../src/main/javascript/gremlin-javascript/package-lock.json | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
a/gremlin-javascript/src/main/javascript/gremlin-javascript/package-lock.json
b/gremlin-javascript/src/main/javascript/gremlin-javascript/package-lock.json
index 1f1dc77a8e..20f9151e51 100644
---
a/gremlin-javascript/src/main/javascript/gremlin-javascript/package-lock.json
+++
b/gremlin-javascript/src/main/javascript/gremlin-javascript/package-lock.json
@@ -3812,9 +3812,9 @@
"dev": true
},
"node_modules/ws": {
- "version": "8.16.0",
- "resolved": "https://registry.npmjs.org/ws/-/ws-8.16.0.tgz;,
- "integrity":
"sha512-HS0c//TP7Ina87TfiPUz1rQzMhHrl/SG2guqRcTOIUYD2q8uhUdNHZYJUaQ8aTGPzCh+c6oawMKW35nFl1dxyQ==",
+ "version": "8.17.0",
+ "resolved": "https://registry.npmjs.org/ws/-/ws-8.17.0.tgz;,
+ "integrity":
"sha512-uJq6108EgZMAl20KagGkzCKfMEjxmKvZHG7Tlq0Z6nOky7YF7aq4mOx6xK8TJ/i1LeK4Qus7INktacctDgY8Ow==",
"engines": {
"node": ">=10.0.0"
},
@@ -6762,9 +6762,9 @@
"dev": true
},
"ws": {
- "version": "8.16.0",
- "resolved": "https://registry.npmjs.org/ws/-/ws-8.16.0.tgz;,
- "integrity":
"sha512-HS0c//TP7Ina87TfiPUz1rQzMhHrl/SG2guqRcTOIUYD2q8uhUdNHZYJUaQ8aTGPzCh+c6oawMKW35nFl1dxyQ==",
+ "version": "8.17.0",
+ "resolved": "https://registry.npmjs.org/ws/-/ws-8.17.0.tgz;,
+ "integrity":
"sha512-uJq6108EgZMAl20KagGkzCKfMEjxmKvZHG7Tlq0Z6nOky7YF7aq4mOx6xK8TJ/i1LeK4Qus7INktacctDgY8Ow==",
"requires": {}
},
"xregexp": {
(tinkerpop) branch dependabot/npm_and_yarn/gremlin-javascript/src/main/javascript/gremlin-javascript/3.6-dev/ws-8.17.0 deleted (was 938abe8739)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch dependabot/npm_and_yarn/gremlin-javascript/src/main/javascript/gremlin-javascript/3.6-dev/ws-8.17.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 938abe8739 Bump ws in /gremlin-javascript/src/main/javascript/gremlin-javascript The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump ws from 8.16.0 to 8.17.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript [tinkerpop]
Cole-Greer merged PR #2577: URL: https://github.com/apache/tinkerpop/pull/2577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/go_modules/gremlin-go/3.6-dev/github.com/gorilla/websocket-1.5.2 deleted (was ac2b05864d)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch dependabot/go_modules/gremlin-go/3.6-dev/github.com/gorilla/websocket-1.5.2 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was ac2b05864d Bump github.com/gorilla/websocket from 1.5.1 to 1.5.2 in /gremlin-go The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump github.com/gorilla/websocket from 1.5.1 to 1.5.2 in /gremlin-go [tinkerpop]
Cole-Greer merged PR #2647: URL: https://github.com/apache/tinkerpop/pull/2647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch 3.6-dev updated (b43c90962a -> 16b871959d)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from b43c90962a CTR minor docs update add 16b871959d Bump github.com/gorilla/websocket from 1.5.1 to 1.5.2 in /gremlin-go (#2647) No new revisions were added by this update. Summary of changes: gremlin-go/go.mod | 4 ++-- gremlin-go/go.sum | 8 2 files changed, 6 insertions(+), 6 deletions(-)
(tinkerpop) branch 3.7-dev updated: adding getters for internal fields inside sample step. (#2649)
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch 3.7-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/3.7-dev by this push:
new 8623b2e05a adding getters for internal fields inside sample step.
(#2649)
8623b2e05a is described below
commit 8623b2e05a483eb5a49fbb6a878ad8cfcf1a313c
Author: Prashant Upadhyay
AuthorDate: Tue Jun 11 13:10:37 2024 -0700
adding getters for internal fields inside sample step. (#2649)
---
.../gremlin/process/traversal/step/filter/SampleGlobalStep.java | 4
.../tinkerpop/gremlin/process/traversal/step/map/SampleLocalStep.java | 4
2 files changed, 8 insertions(+)
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/SampleGlobalStep.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/SampleGlobalStep.java
index 20c8396a6b..82d566f4b2 100644
---
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/SampleGlobalStep.java
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/SampleGlobalStep.java
@@ -52,6 +52,10 @@ public final class SampleGlobalStep extends
CollectingBarrierStep implemen
this.amountToSample = amountToSample;
}
+public int getAmountToSample() {
+return amountToSample;
+}
+
@Override
public void resetSeed(final long seed) {
random.setSeed(seed);
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/SampleLocalStep.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/SampleLocalStep.java
index 87a5ea4493..bce081d9ed 100644
---
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/SampleLocalStep.java
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/SampleLocalStep.java
@@ -49,6 +49,10 @@ public final class SampleLocalStep extends
ScalarMapStep implements See
this.amountToSample = amountToSample;
}
+public int getAmountToSample() {
+return amountToSample;
+}
+
@Override
public void resetSeed(final long seed) {
this.random.setSeed(seed);
Re: [PR] adding getters for internal fields inside sample step. [tinkerpop]
Cole-Greer merged PR #2649: URL: https://github.com/apache/tinkerpop/pull/2649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] adding getters for internal fields inside sample step. [tinkerpop]
Cole-Greer commented on PR #2649: URL: https://github.com/apache/tinkerpop/pull/2649#issuecomment-2161528196 Thanks for the submission Prashant! VOTE +1 Looks good to me and as it's a relatively minor change, I will merge it as a CTR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/prettier-3.3.2 deleted (was 62c7b6c39f)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/prettier-3.3.2 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 62c7b6c39f Bump prettier from 3.2.5 to 3.3.2 in /docs/gremlint The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.14.2 deleted (was bed3abfbf9)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.14.2 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was bed3abfbf9 Bump @types/node from 20.11.23 to 20.14.2 in /docs/gremlint The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump prettier from 3.2.5 to 3.3.2 in /docs/gremlint [tinkerpop]
dependabot[bot] closed pull request #2650: Bump prettier from 3.2.5 to 3.3.2 in /docs/gremlint URL: https://github.com/apache/tinkerpop/pull/2650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump prettier from 3.2.5 to 3.3.2 in /docs/gremlint [tinkerpop]
dependabot[bot] commented on PR #2650: URL: https://github.com/apache/tinkerpop/pull/2650#issuecomment-2161509616 Looks like prettier is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump @types/node from 20.11.23 to 20.14.2 in /docs/gremlint [tinkerpop]
dependabot[bot] closed pull request #2639: Bump @types/node from 20.11.23 to 20.14.2 in /docs/gremlint URL: https://github.com/apache/tinkerpop/pull/2639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump @types/node from 20.11.23 to 20.14.2 in /docs/gremlint [tinkerpop]
dependabot[bot] commented on PR #2639: URL: https://github.com/apache/tinkerpop/pull/2639#issuecomment-2161509572 Looks like @types/node is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch master updated: CTR Squashed docs/gremlint dependabots
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/master by this push:
new 580cfa146e CTR Squashed docs/gremlint dependabots
580cfa146e is described below
commit 580cfa146e438398262718a96aa4b90eaa4a2208
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AuthorDate: Tue Jun 11 14:38:26 2024 +
CTR Squashed docs/gremlint dependabots
Bump prettier from 3.2.5 to 3.3.2 in /docs/gremlint
Bumps [prettier](https://github.com/prettier/prettier) from 3.2.5 to 3.3.2.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/3.2.5...3.3.2)
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot]
Bump @types/node from 20.11.23 to 20.14.2 in /docs/gremlint
Bumps
[@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)
from 20.11.23 to 20.14.2.
- [Release
notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
-
[Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)
---
updated-dependencies:
- dependency-name: "@types/node"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot]
---
docs/gremlint/package-lock.json | 28 ++--
docs/gremlint/package.json | 4 ++--
2 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/docs/gremlint/package-lock.json b/docs/gremlint/package-lock.json
index 67f6ed5c3c..723c612217 100644
--- a/docs/gremlint/package-lock.json
+++ b/docs/gremlint/package-lock.json
@@ -25,12 +25,12 @@
"@testing-library/react": "^12.1.5",
"@testing-library/user-event": "^14.5.2",
"@types/jest": "^29.5.4",
-"@types/node": "^20.11.23",
+"@types/node": "^20.14.2",
"@types/react": "^17.0.38",
"@types/react-dom": "^17.0.11",
"@types/styled-components": "^5.1.26",
"gh-pages": "^6.1.1",
-"prettier": "^3.2.5",
+"prettier": "^3.3.2",
"tslint": "^6.1.3",
"tslint-config-prettier": "^1.18.0"
},
@@ -4544,9 +4544,9 @@
"integrity":
"sha512-YATxVxgRqNH6nHEIsvg6k2Boc1JHI9ZbH5iWFFv/MTkchz3b1ieGDa5T0a9RznNdI0KhVbdbWSN+KWWrQZRxTw=="
},
"node_modules/@types/node": {
- "version": "20.11.23",
- "resolved": "https://registry.npmjs.org/@types/node/-/node-20.11.23.tgz;,
- "integrity":
"sha512-ZUarKKfQuRILSNYt32FuPL20HS7XwNT7/uRwSV8tiHWfyyVwDLYZNF6DZKc2bove++pgfsXn9sUwII/OsQ82cQ==",
+ "version": "20.14.2",
+ "resolved": "https://registry.npmjs.org/@types/node/-/node-20.14.2.tgz;,
+ "integrity":
"sha512-xyu6WAMVwv6AKFLB+e/7ySZVr/0zLCzOa7rSpq6jNwpqOrUbcACDWC+53d4n2QHOnDou0fbIsg8wZu/sxrnI4Q==",
"dependencies": {
"undici-types": "~5.26.4"
}
@@ -15498,9 +15498,9 @@
}
},
"node_modules/prettier": {
- "version": "3.2.5",
- "resolved": "https://registry.npmjs.org/prettier/-/prettier-3.2.5.tgz;,
- "integrity":
"sha512-3/GWa9aOC0YeD7LUfvOG2NiDyhOWRvt1k+rcKhOuYnMY24iiCphgneUfJDyFXd6rZCAnuLBv6UeAULtrhT/F4A==",
+ "version": "3.3.2",
+ "resolved": "https://registry.npmjs.org/prettier/-/prettier-3.3.2.tgz;,
+ "integrity":
"sha512-rAVeHYMcv8ATV5d508CFdn+8/pHPpXeIid1DdrPwXnaAdH7cqjVbpJaT5eq4yRAFU/lsbwYwSF/n5iNrdJHPQA==",
"dev": true,
"bin": {
"prettier": "bin/prettier.cjs"
@@ -23357,9 +23357,9 @@
"integrity":
"sha512-YATxVxgRqNH6nHEIsvg6k2Boc1JHI9ZbH5iWFFv/MTkchz3b1ieGDa5T0a9RznNdI0KhVbdbWSN+KWWrQZRxTw=="
},
"@types/node": {
- "version": "20.11.23",
- "resolved": "https://registry.npmjs.org/@types/node/-/node-20.11.23.tgz;,
- "integrity":
"sha512-ZUarKKfQuRILSNYt32FuPL20HS7XwNT7/uRwSV8tiHWfyyVwDLYZNF6DZKc2bove++pgfsXn9sUwII/OsQ82cQ==",
+ "version": "20.14.2",
+ "resolved": "https://registry.npmjs.org/@types/node/-/node-20.14.2.tgz;,
+ "integrity":
"sha512-xyu6WAMVwv6AKFLB+e/7ySZVr/0zLCzOa7rSpq6jNwpqOrUbcACDWC+53d4n2QHOnDou0fbIsg8wZu/sxrnI4Q==",
"requires": {
"undici-types": "~5.26.4"
}
@@ -31384,9 +31384,9 @@
"integrity":
"sha512-vkcDPrRZo1QZLbn5RLGPpg/WmIQ65qoWWhcGKf/b5eplkkarX0m9z8ppCat4mlOqUsWpyNuYgO3VRyrYHSzX5g=="
},
"prettier": {
- "version": "3.2.5",
- "resolved": "https://registry.npmjs.org/prettier/-/prettier-3.2.5.tgz;,
- "integrity":
Re: [PR] Bump web-vitals from 3.5.1 to 4.1.1 in /docs/gremlint [tinkerpop]
Cole-Greer commented on PR #2651: URL: https://github.com/apache/tinkerpop/pull/2651#issuecomment-2161500044 It appears that as of 4.0.0, web-vitals no longer exports `ReportHandler` which we use to report web vitals. As it currently stands, the site cannot be built with this upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add type annotations and docstring to _make_packer function [tinkerpop]
Cole-Greer closed pull request #2606: Add type annotations and docstring to _make_packer function URL: https://github.com/apache/tinkerpop/pull/2606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add type annotations and docstring to _make_packer function [tinkerpop]
Cole-Greer commented on PR #2606: URL: https://github.com/apache/tinkerpop/pull/2606#issuecomment-2161484831 Hi @vatsalcode, Thanks again for the contribution, unfortunately as Ken mentioned our testing is still stuck on Python 3.8. I've opened up a JIRA for the necessary python upgrade (https://issues.apache.org/jira/browse/TINKERPOP-3086). I left a note in the JIRA to review this PR upon resolution. I am going to close this PR for now as it is blocked on TINKERPOP-3086 and there is no immediate timeline for resolution. This JIRA will need to be resolved by October 2024 at the latest (end of life for Python 3.8), at which point this PR will be reopened and re-evaluated. Thanks again for the submission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch valentyn/bytecode-poc updated (76bb90e084 -> c62202e7fc)
This is an automated email from the ASF dual-hosted git repository. valentyn pushed a change to branch valentyn/bytecode-poc in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 76bb90e084 remove BytecodeCommand from console add c62202e7fc added test for Bindings No new revisions were added by this update. Summary of changes: .../org/apache/tinkerpop/gremlin/process/traversal/GremlincodeTest.java | 1 + 1 file changed, 1 insertion(+)
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/typescript-5.4.5 deleted (was 9073b13491)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/typescript-5.4.5 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 9073b13491 Bump typescript from 4.9.5 to 5.4.5 in /docs/gremlint The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump typescript from 4.9.5 to 5.4.5 in /docs/gremlint [tinkerpop]
dependabot[bot] commented on PR #2559: URL: https://github.com/apache/tinkerpop/pull/2559#issuecomment-2161234761 OK, I won't notify you about version 5.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump typescript from 4.9.5 to 5.4.5 in /docs/gremlint [tinkerpop]
Cole-Greer commented on PR #2559: URL: https://github.com/apache/tinkerpop/pull/2559#issuecomment-2161234660 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump typescript from 4.9.5 to 5.4.5 in /docs/gremlint [tinkerpop]
dependabot[bot] closed pull request #2559: Bump typescript from 4.9.5 to 5.4.5 in /docs/gremlint URL: https://github.com/apache/tinkerpop/pull/2559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump typescript from 4.9.5 to 5.4.5 in /docs/gremlint [tinkerpop]
Cole-Greer commented on PR #2559: URL: https://github.com/apache/tinkerpop/pull/2559#issuecomment-2161234372 The upgrade to typescript 5 causes many build errors for the site. I am configuring dependabot to ignore TS5 for now as there currently appears to be no appetite to tackle this upgrade and resolve the build issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch master updated (75a32d6efd -> 89aa5dbbf1)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 75a32d6efd CTR minor docs update add b43c90962a CTR minor docs update add ba70d5dc2a Merge branch '3.6-dev' into 3.7-dev new 89aa5dbbf1 Merge branch '3.7-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docs/src/dev/developer/for-committers.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(tinkerpop) 01/01: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 89aa5dbbf1741a1992738717631e05a554b7c99a Merge: 75a32d6efd ba70d5dc2a Author: Cole-Greer AuthorDate: Tue Jun 11 10:00:15 2024 -0700 Merge branch '3.7-dev' docs/src/dev/developer/for-committers.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --cc docs/src/dev/developer/for-committers.asciidoc index 79825e1051,ac9281d0d5..aaf92442ca --- a/docs/src/dev/developer/for-committers.asciidoc +++ b/docs/src/dev/developer/for-committers.asciidoc @@@ -139,10 -139,10 +139,10 @@@ TinkerPop has several release branches * `3.2-dev` - 3.2.x (no longer maintained) * `3.3-dev` - 3.3.x (no longer maintained) * `3.4-dev` - 3.4.x (no longer maintained) - * `3.5-dev` - 3.5.x (non-breaking bug fixes and enhancements) + * `3.5-dev` - 3.5.x (no longer maintained) * `3.6-dev` - 3.6.x (non-breaking bug fixes and enhancements) * `3.7-dev` - 3.7.x (non-breaking bug fixes and enhancements) -* `master` - 4.x (current development) +* `master` - 4.x.x (current development) The branch description above that reads "non-breaking bug fixes and enhancements" simply means that within that release line (i.e. patch version) changes should not alter existing behavior, introduce new APIs, change serialization formats,
(tinkerpop) 01/01: Merge branch '3.6-dev' into 3.7-dev
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit ba70d5dc2ab09e20a2b4724ce718f9b78ac92fd5 Merge: 8d9f63ce4e b43c90962a Author: Cole-Greer AuthorDate: Tue Jun 11 09:57:51 2024 -0700 Merge branch '3.6-dev' into 3.7-dev docs/src/dev/developer/for-committers.asciidoc | 9 - 1 file changed, 4 insertions(+), 5 deletions(-)
(tinkerpop) branch 3.7-dev updated (8d9f63ce4e -> ba70d5dc2a)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 8d9f63ce4e Merge pull request #2634 add b43c90962a CTR minor docs update new ba70d5dc2a Merge branch '3.6-dev' into 3.7-dev The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docs/src/dev/developer/for-committers.asciidoc | 9 - 1 file changed, 4 insertions(+), 5 deletions(-)
(tinkerpop) branch 3.6-dev updated: CTR minor docs update
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/3.6-dev by this push: new b43c90962a CTR minor docs update b43c90962a is described below commit b43c90962a954ff607deb3d0057eaa911669f7e1 Author: Cole-Greer AuthorDate: Tue Jun 11 09:56:22 2024 -0700 CTR minor docs update --- docs/src/dev/developer/for-committers.asciidoc | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/docs/src/dev/developer/for-committers.asciidoc b/docs/src/dev/developer/for-committers.asciidoc index 12d2e3ea31..2b60ddd74e 100644 --- a/docs/src/dev/developer/for-committers.asciidoc +++ b/docs/src/dev/developer/for-committers.asciidoc @@ -139,10 +139,10 @@ TinkerPop has several release branches: * `3.2-dev` - 3.2.x (no longer maintained) * `3.3-dev` - 3.3.x (no longer maintained) * `3.4-dev` - 3.4.x (no longer maintained) -* `3.5-dev` - 3.5.x (non-breaking bug fixes and enhancements) +* `3.5-dev` - 3.5.x (no longer maintained) * `3.6-dev` - 3.6.x (non-breaking bug fixes and enhancements) -* `master` - 3.7.x (current development) -* `4.0-dev` - 4.0.x (future development) +* `3.7-dev` - 3.7.x (non-breaking bug fixes and enhancements) +* `master` - 4.x (current development) The branch description above that reads "non-breaking bug fixes and enhancements" simply means that within that release line (i.e. patch version) changes should not alter existing behavior, introduce new APIs, change serialization formats, @@ -152,8 +152,7 @@ client of one version within a release line can interact properly with a server it is likely an acceptable change within that branch. Changes to earlier branches should merge forward toward `master` (e.g. `3.6-dev` should merge to `master`). Please read -more about this process in the <> section. Note that `4.0-dev` is rebased on `master` -and currently behaves as a fresh repository as all 3.x content was removed. +more about this process in the <> section. As described in <>, it is possible to do a "partial" release which will utilize a four-digit version that starts with a "1" (e.g. `3.6.0.1`). The branching strategy for a partial release requires that a `-dev`
Re: [PR] Optimize `to_dict` Method in `GraphBinaryWriter` [tinkerpop]
Cole-Greer closed pull request #2607: Optimize `to_dict` Method in `GraphBinaryWriter` URL: https://github.com/apache/tinkerpop/pull/2607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Optimize `to_dict` Method in `GraphBinaryWriter` [tinkerpop]
Cole-Greer commented on PR #2607: URL: https://github.com/apache/tinkerpop/pull/2607#issuecomment-2161194961 I am going to close this PR for now as it's become inactive and I'm not currently understanding the value of this caching strategy. If you believe this to be a mistake, please update with an example case which would benefit from this cache and reopen the PR. I would be happy to reconsider. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/web-vitals-4.1.1 created (now 3372f5f8d4)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/web-vitals-4.1.1 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 3372f5f8d4 Bump web-vitals from 3.5.1 to 4.1.1 in /docs/gremlint No new revisions were added by this update.
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/prettier-3.3.1 deleted (was 3df1832c80)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/prettier-3.3.1 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 3df1832c80 Bump prettier from 3.2.5 to 3.3.1 in /docs/gremlint The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump prettier from 3.2.5 to 3.3.1 in /docs/gremlint [tinkerpop]
dependabot[bot] commented on PR #2638: URL: https://github.com/apache/tinkerpop/pull/2638#issuecomment-2160935230 Superseded by #2650. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump prettier from 3.2.5 to 3.3.2 in /docs/gremlint [tinkerpop]
dependabot[bot] opened a new pull request, #2650:
URL: https://github.com/apache/tinkerpop/pull/2650
Bumps [prettier](https://github.com/prettier/prettier) from 3.2.5 to 3.3.2.
Release notes
Sourced from https://github.com/prettier/prettier/releases;>prettier's
releases.
3.3.2
https://github.com/prettier/prettier/blob/main/CHANGELOG.md#332;>Changelog
3.3.1
https://github.com/prettier/prettier/blob/main/CHANGELOG.md#331;>Changelog
3.3.0
https://github.com/prettier/prettier/compare/3.2.5...3.3.0;>diff
https://prettier.io/blog/2024/06/01/3.3.0.html;>Release
note
Changelog
Sourced from https://github.com/prettier/prettier/blob/main/CHANGELOG.md;>prettier's
changelog.
3.3.2
https://github.com/prettier/prettier/compare/3.3.1...3.3.2;>diff
Fix handlebars path expressions starts with @ (https://redirect.github.com/prettier/prettier/pull/16358;>#16358 by
https://github.com/Princeyadav05;>@Princeyadav05)
{{! Input }}
div{{@x.y.z}}/div
{{! Prettier 3.3.1 }}
div{{https://github.com/x;>@x}}/div
{{! Prettier 3.3.2 }}
div{{https://github.com/x;>@x.y.z}}/div
3.3.1
https://github.com/prettier/prettier/compare/3.3.0...3.3.1;>diff
Preserve empty lines in front matter (https://redirect.github.com/prettier/prettier/pull/16347;>#16347 by
https://github.com/fisker;>@fisker)
!-- Input --
---
foo:
- bar1
bar2
bar3
Markdown
!-- Prettier 3.3.0 --
foo:
bar1
bar2
bar3
Markdown
!-- Prettier 3.3.1 --
/tr/table
... (truncated)
Commits
https://github.com/prettier/prettier/commit/1596a608dedac55c20bad3f1b5bfd47f961c696b;>1596a60
Release 3.3.2
https://github.com/prettier/prettier/commit/aebcee5ea49ff0ee934ce39d26edb09cbd3f17db;>aebcee5
chore(deps): update dependency esbuild to v0.21.5 (https://redirect.github.com/prettier/prettier/issues/16379;>#16379)
https://github.com/prettier/prettier/commit/57aa9287a078f0ed266e779bd00528fff2598bb2;>57aa928
chore(deps): update dependency c8 to v10 (https://redirect.github.com/prettier/prettier/issues/16380;>#16380)
https://github.com/prettier/prettier/commit/c3d0b7f419f6f51876bbb1fc36b9755b8c9dcb8e;>c3d0b7f
chore(deps): update typescript-eslint to v7.13.0 (https://redirect.github.com/prettier/prettier/issues/16376;>#16376)
https://github.com/prettier/prettier/commit/27c35db5e20a121aad0cc3fff7a80658b7503ea0;>27c35db
chore(deps): update dependency codemirror-graphql to v2.0.12 (https://redirect.github.com/prettier/prettier/issues/16369;>#16369)
https://github.com/prettier/prettier/commit/6de325866695e23269d0d217cf73c4cc0340226e;>6de3258
chore(deps): update dependency jest to v30.0.0-alpha.5 (https://redirect.github.com/prettier/prettier/issues/16371;>#16371)
https://github.com/prettier/prettier/commit/b5f983d2bb24ae78ba560c7d57c4b1753ea32cfa;>b5f983d
Upgrade yarn to v4.3.0 (https://redirect.github.com/prettier/prettier/issues/16377;>#16377)
https://github.com/prettier/prettier/commit/d6f37c4109e97fdfa054d7af147e82495a18d1c7;>d6f37c4
chore(deps): update dependency browserslist to v4.23.1 (https://redirect.github.com/prettier/prettier/issues/16368;>#16368)
https://github.com/prettier/prettier/commit/5055b7d39265fddae29917390c83ef28df497f23;>5055b7d
chore(deps): update dependency execa to v9.2.0 (https://redirect.github.com/prettier/prettier/issues/16372;>#16372)
https://github.com/prettier/prettier/commit/f4608cc76b097a03487f00132a904dea1312c56d;>f4608cc
chore(deps): update dependency cspell to v8.8.4 (https://redirect.github.com/prettier/prettier/issues/16370;>#16370)
Additional commits viewable in https://github.com/prettier/prettier/compare/3.2.5...3.3.2;>compare
view
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that
have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI
passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and
block automerging
- `@dependabot reopen` will reopen this PR if it is closed
-
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/web-vitals-4.1.0 deleted (was 2a10e22238)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/web-vitals-4.1.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 2a10e22238 Bump web-vitals from 3.5.1 to 4.1.0 in /docs/gremlint The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump web-vitals from 3.5.1 to 4.1.0 in /docs/gremlint [tinkerpop]
dependabot[bot] commented on PR #2646: URL: https://github.com/apache/tinkerpop/pull/2646#issuecomment-2160935894 Superseded by #2651. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump web-vitals from 3.5.1 to 4.1.0 in /docs/gremlint [tinkerpop]
dependabot[bot] closed pull request #2646: Bump web-vitals from 3.5.1 to 4.1.0 in /docs/gremlint URL: https://github.com/apache/tinkerpop/pull/2646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump web-vitals from 3.5.1 to 4.1.1 in /docs/gremlint [tinkerpop]
dependabot[bot] opened a new pull request, #2651: URL: https://github.com/apache/tinkerpop/pull/2651 Bumps [web-vitals](https://github.com/GoogleChrome/web-vitals) from 3.5.1 to 4.1.1. Changelog Sourced from https://github.com/GoogleChrome/web-vitals/blob/main/CHANGELOG.md;>web-vitals's changelog. v4.1.1 (2024-06-10) Fix pending LoAF cleanup logic (https://redirect.github.com/GoogleChrome/web-vitals/pull/493;>#493) v4.1.0 (2024-06-06) Move the support check to the top of the onINP() function (https://redirect.github.com/GoogleChrome/web-vitals/pull/490;>#490) Fix missing LoAF attribution when entries are dispatched before event entries (https://redirect.github.com/GoogleChrome/web-vitals/pull/487;>#487) v4.0.1 (2024-05-21) Add the ReportCallback type back but deprecate it (https://redirect.github.com/GoogleChrome/web-vitals/pull/483;>#483) v4.0.0 (2024-05-13) [BREAKING] Update types to support more generic usage (https://redirect.github.com/GoogleChrome/web-vitals/pull/471;>#471) [BREAKING] Split waitingDuration to make it easier to understand redirect delays (https://redirect.github.com/GoogleChrome/web-vitals/pull/458;>#458) [BREAKING] Rename TTFBAttribution fields from *Time to *Duration (https://redirect.github.com/GoogleChrome/web-vitals/pull/453;>#453) [BREAKING] Rename resourceLoadTime to resourceLoadDuration in LCP attribution (https://redirect.github.com/GoogleChrome/web-vitals/pull/450;>#450) [BREAKING] Add INP breakdown timings and LoAF attribution (https://redirect.github.com/GoogleChrome/web-vitals/pull/442;>#442) [BREAKING] Deprecate onFID() and remove previously deprecated APIs (https://redirect.github.com/GoogleChrome/web-vitals/pull/435;>#435) Expose the target element in INP attribution (https://redirect.github.com/GoogleChrome/web-vitals/pull/479;>#479) Save INP target after interactions to reduce null values when removed from the DOM (https://redirect.github.com/GoogleChrome/web-vitals/pull/477;>#477) Cap TTFB in attribution (https://redirect.github.com/GoogleChrome/web-vitals/pull/440;>#440) Fix reportAllChanges behavior for LCP when library is loaded late (https://redirect.github.com/GoogleChrome/web-vitals/pull/468;>#468) v3.5.2 (2024-01-25) Pick the first non-null target for INP attribution (https://redirect.github.com/GoogleChrome/web-vitals/pull/421;>#421) Commits https://github.com/GoogleChrome/web-vitals/commit/d2965ae2de759be00c24b011348434ff6db6321d;>d2965ae Release v4.1.1 https://github.com/GoogleChrome/web-vitals/commit/de1a98808fce13d5cf3f5aa74c7a2d6d431e59da;>de1a988 Update CHANGELOG https://github.com/GoogleChrome/web-vitals/commit/ecec8232ce937e9dcb745e8b88fdf04f53337850;>ecec823 fix cleanup loop over pending LoAFs (https://redirect.github.com/GoogleChrome/web-vitals/issues/493;>#493) https://github.com/GoogleChrome/web-vitals/commit/21c16dd3400c0f598d69af474234a5d025f6ee8f;>21c16dd Release v4.1.0 https://github.com/GoogleChrome/web-vitals/commit/b860828ed825efbda13423bce7f8b2729071fc1b;>b860828 Update CHANGELOG https://github.com/GoogleChrome/web-vitals/commit/d58dbab8b8a6315fec0f7eebadb22847bf5c205b;>d58dbab INP attribution: allow for LoAFs observed before interaction events (https://redirect.github.com/GoogleChrome/web-vitals/issues/487;>#487) https://github.com/GoogleChrome/web-vitals/commit/66f3938e8d5bb9391f72db3376d2f3de24040585;>66f3938 Move support check to beginning of onINP function (https://redirect.github.com/GoogleChrome/web-vitals/issues/490;>#490) https://github.com/GoogleChrome/web-vitals/commit/b32786bf6baa82593a4cae12226f8e81172b8407;>b32786b Release v4.0.1 https://github.com/GoogleChrome/web-vitals/commit/e47606dea9ceebcc46589ceb894fcfa46a7dd491;>e47606d Update CHANGELOG https://github.com/GoogleChrome/web-vitals/commit/cae70b105b8bba9c78c5ac40225f05a2b57f978a;>cae70b1 Add ReportCallback type back but deprecate it (https://redirect.github.com/GoogleChrome/web-vitals/issues/483;>#483) Additional commits viewable in https://github.com/GoogleChrome/web-vitals/compare/v3.5.1...v4.1.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/prettier-3.3.2 created (now 62c7b6c39f)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/prettier-3.3.2 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 62c7b6c39f Bump prettier from 3.2.5 to 3.3.2 in /docs/gremlint No new revisions were added by this update.
Re: [PR] Bump prettier from 3.2.5 to 3.3.1 in /docs/gremlint [tinkerpop]
dependabot[bot] closed pull request #2638: Bump prettier from 3.2.5 to 3.3.1 in /docs/gremlint URL: https://github.com/apache/tinkerpop/pull/2638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
