Re: [PR] improvement: optimization of readmap function [tinkerpop]
kenhuuu commented on PR #2673: URL: https://github.com/apache/tinkerpop/pull/2673#issuecomment-2211301014 VOTE +1. Please follow the instructions in the PR template next time for the CHANGELOG entry. I'll commit a follow-up change to make a minor adjustment so that this PR can be merged now. Thanks again for contributing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] improvement: optimization of readmap function [tinkerpop]
kenhuuu merged PR #2673: URL: https://github.com/apache/tinkerpop/pull/2673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch 3.7-dev updated (0ea5b14db1 -> 5afbd1a5fd)
This is an automated email from the ASF dual-hosted git repository. kenhuuu pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 0ea5b14db1 Remove unused imports from GremlinServerAuthzIntegrateTest CTR add dad8c0f4fd improvement: optimization of readmap function new 5afbd1a5fd Merge pull request #2673 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc| 4 ++ gremlin-go/driver/graphBinary.go | 6 +-- gremlin-go/driver/graphBinary_test.go | 70 +++ 3 files changed, 77 insertions(+), 3 deletions(-)
(tinkerpop) 01/01: Merge pull request #2673
This is an automated email from the ASF dual-hosted git repository. kenhuuu pushed a commit to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 5afbd1a5fd51550fe506ba60114018c0c258c8c7 Merge: 0ea5b14db1 dad8c0f4fd Author: kenhuuu <106191785+kenh...@users.noreply.github.com> AuthorDate: Fri Jul 5 12:05:02 2024 -0700 Merge pull request #2673 improvement: optimization of readmap function CHANGELOG.asciidoc| 4 ++ gremlin-go/driver/graphBinary.go | 6 +-- gremlin-go/driver/graphBinary_test.go | 70 +++ 3 files changed, 77 insertions(+), 3 deletions(-)
Re: [PR] Add support for HTTP content compression. [tinkerpop]
vkagamlyk commented on PR #2669: URL: https://github.com/apache/tinkerpop/pull/2669#issuecomment-2211314496 VOTE+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for HTTP content compression. [tinkerpop]
kenhuuu commented on PR #2669: URL: https://github.com/apache/tinkerpop/pull/2669#issuecomment-2211340839 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for HTTP content compression. [tinkerpop]
kenhuuu merged PR #2669: URL: https://github.com/apache/tinkerpop/pull/2669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) 01/01: Merge pull request #2669
This is an automated email from the ASF dual-hosted git repository. kenhuuu pushed a commit to branch master-http in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit e4fd11ffee5575adbbd09010924be44ddb042536 Merge: 13823c5090 c89a98f888 Author: kenhuuu <106191785+kenh...@users.noreply.github.com> AuthorDate: Fri Jul 5 12:44:30 2024 -0700 Merge pull request #2669 Add support for HTTP content compression. .../tinkerpop/gremlin/driver/Channelizer.java | 9 +- .../handler/HttpContentDecompressionHandler.java | 103 ++ .../driver/handler/HttpGremlinRequestEncoder.java | 2 + .../gremlin/driver/simple/SimpleHttpClient.java| 2 + .../HttpContentDecompressionHandlerTest.java | 222 + .../gremlin/server/channel/HttpChannelizer.java| 3 + .../handler/HttpContentCompressionHandler.java | 89 + .../server/handler/HttpGremlinEndpointHandler.java | 17 ++ .../server/handler/HttpRequestMessageDecoder.java | 2 + .../tinkerpop/gremlin/server/handler/StateKey.java | 6 + .../server/GremlinServerAuthIntegrateTest.java | 3 +- .../server/GremlinServerHttpIntegrateTest.java | 14 +- .../handler/HttpContentCompressionHandlerTest.java | 208 +++ 13 files changed, 673 insertions(+), 7 deletions(-)
(tinkerpop) branch master-http updated (13823c5090 -> e4fd11ffee)
This is an automated email from the ASF dual-hosted git repository. kenhuuu pushed a change to branch master-http in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 13823c5090 Bytecode removal from server (#2661) add c89a98f888 Add support for HTTP content compression. new e4fd11ffee Merge pull request #2669 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../tinkerpop/gremlin/driver/Channelizer.java | 9 +- .../handler/HttpContentDecompressionHandler.java | 103 ++ .../driver/handler/HttpGremlinRequestEncoder.java | 2 + .../gremlin/driver/simple/SimpleHttpClient.java| 2 + .../HttpContentDecompressionHandlerTest.java | 222 + .../gremlin/server/channel/HttpChannelizer.java| 3 + .../handler/HttpContentCompressionHandler.java | 89 + .../server/handler/HttpGremlinEndpointHandler.java | 17 ++ .../server/handler/HttpRequestMessageDecoder.java | 2 + .../tinkerpop/gremlin/server/handler/StateKey.java | 6 + .../server/GremlinServerAuthIntegrateTest.java | 3 +- .../server/GremlinServerHttpIntegrateTest.java | 14 +- .../handler/HttpContentCompressionHandlerTest.java | 208 +++ 13 files changed, 673 insertions(+), 7 deletions(-) create mode 100644 gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpContentDecompressionHandler.java create mode 100644 gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/handler/HttpContentDecompressionHandlerTest.java create mode 100644 gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpContentCompressionHandler.java create mode 100644 gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/handler/HttpContentCompressionHandlerTest.java
(tinkerpop) branch http-compression deleted (was c89a98f888)
This is an automated email from the ASF dual-hosted git repository. kenhuuu pushed a change to branch http-compression in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was c89a98f888 Add support for HTTP content compression. The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) 01/01: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. kenhuuu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 38c05d80b86822713c385cfd7ef25ae93cb86224 Merge: 0835701409 746222412a Author: Ken Hu <106191785+kenh...@users.noreply.github.com> AuthorDate: Fri Jul 5 13:27:11 2024 -0700 Merge branch '3.7-dev' CHANGELOG.asciidoc| 1 + gremlin-go/driver/graphBinary.go | 6 +-- gremlin-go/driver/graphBinary_test.go | 70 +++ 3 files changed, 74 insertions(+), 3 deletions(-)
(tinkerpop) branch 3.7-dev updated: Update CHANGELOG entry for PR#2673 CTR
This is an automated email from the ASF dual-hosted git repository. kenhuuu pushed a commit to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/3.7-dev by this push: new 746222412a Update CHANGELOG entry for PR#2673 CTR 746222412a is described below commit 746222412a071daa9c9b0adac7ee9f39d9b27ff5 Author: Ken Hu <106191785+kenh...@users.noreply.github.com> AuthorDate: Fri Jul 5 12:16:06 2024 -0700 Update CHANGELOG entry for PR#2673 CTR --- CHANGELOG.asciidoc | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc index b703c54eed..18820da91b 100644 --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@ -32,10 +32,7 @@ This release also includes changes from <>. * CoinStep has a getter method for its probability field * Fixed so that TrimGlobalStep and TrimLocalStep have the same character control handling as Ltrim and Rtrim * Fix a bug in MaxLocalStep, MinLocalStep, MeanLocalStep and SumLocalStep that it throws NoSuchElementException when encounters an empty iterator as input. - - Improvements - -* TINKERPOP-3093 optimization of readmap function +* Fix cases where Map keys of incomparable types could panic in `gremlin-go`. [[release-3-7-2]] === TinkerPop 3.7.2 (April 8, 2024)
(tinkerpop) branch master updated (0835701409 -> 38c05d80b8)
This is an automated email from the ASF dual-hosted git repository. kenhuuu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 0835701409 Merge branch '3.7-dev' add dad8c0f4fd improvement: optimization of readmap function add 5afbd1a5fd Merge pull request #2673 add 746222412a Update CHANGELOG entry for PR#2673 CTR new 38c05d80b8 Merge branch '3.7-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc| 1 + gremlin-go/driver/graphBinary.go | 6 +-- gremlin-go/driver/graphBinary_test.go | 70 +++ 3 files changed, 74 insertions(+), 3 deletions(-)
(tinkerpop) 01/01: buling with request parameter
This is an automated email from the ASF dual-hosted git repository.
valentyn pushed a commit to branch valentyn/http-bulking
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit 0b631db698ac39040f123e1db520c8b796f5c6ac
Author: Valentyn Kahamlyk
AuthorDate: Fri Jul 5 14:32:41 2024 -0700
buling with request parameter
---
.../org/apache/tinkerpop/gremlin/driver/Client.java| 1 +
.../tinkerpop/gremlin/driver/RequestOptions.java | 13 ++---
.../gremlin/driver/remote/DriverRemoteConnection.java | 4 ++--
.../gremlin/driver/remote/DriverRemoteTraversal.java | 6 ++
.../server/handler/HttpGremlinEndpointHandler.java | 18 +++---
.../gremlin/server/HttpDriverIntegrateTest.java| 4 ++--
.../org/apache/tinkerpop/gremlin/util/TokensV4.java| 5 +
.../gremlin/util/message/RequestMessageV4.java | 5 +
.../util/ser/binary/RequestMessageSerializerV4.java| 3 +++
9 files changed, 37 insertions(+), 22 deletions(-)
diff --git
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java
index 8b344600b6..da92212cb2 100644
---
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java
+++
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Client.java
@@ -238,6 +238,7 @@ public abstract class Client {
options.getG().ifPresent(g -> request.addG(g));
options.getLanguage().ifPresent(lang -> request.addLanguage(lang));
options.getMaterializeProperties().ifPresent(mp ->
request.addMaterializeProperties(mp));
+if (options.isBulking()) request.addBulking(true);
return submitAsync(request.create());
}
diff --git
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/RequestOptions.java
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/RequestOptions.java
index 95612570aa..b637dca4c5 100644
---
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/RequestOptions.java
+++
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/RequestOptions.java
@@ -18,15 +18,12 @@
*/
package org.apache.tinkerpop.gremlin.driver;
-import
org.apache.tinkerpop.gremlin.process.traversal.strategy.decoration.OptionsStrategy;
import org.apache.tinkerpop.gremlin.util.message.RequestMessageV4;
import java.util.HashMap;
-import java.util.Iterator;
import java.util.Map;
import java.util.Optional;
-import static org.apache.tinkerpop.gremlin.util.TokensV4.ARGS_EVAL_TIMEOUT;
import static org.apache.tinkerpop.gremlin.util.TokensV4.ARGS_G;
import static org.apache.tinkerpop.gremlin.util.TokensV4.ARGS_LANGUAGE;
@@ -45,6 +42,7 @@ public final class RequestOptions {
private final Long timeout;
private final String language;
private final String materializeProperties;
+private final boolean bulking;
private RequestOptions(final Builder builder) {
this.graphOrTraversalSource = builder.graphOrTraversalSource;
@@ -53,6 +51,7 @@ public final class RequestOptions {
this.timeout = builder.timeout;
this.language = builder.language;
this.materializeProperties = builder.materializeProperties;
+this.bulking = builder.bulking;
}
public Optional getG() {
@@ -77,6 +76,8 @@ public final class RequestOptions {
public Optional getMaterializeProperties() { return
Optional.ofNullable(materializeProperties); }
+public boolean isBulking() { return bulking; }
+
public static Builder build() {
return new Builder();
}
@@ -88,6 +89,7 @@ public final class RequestOptions {
private Long timeout = null;
private String materializeProperties = null;
private String language = null;
+private boolean bulking = false;
/**
* The aliases to set on the request.
@@ -126,6 +128,11 @@ public final class RequestOptions {
return this;
}
+public Builder withBulking(final boolean bulking) {
+this.bulking = bulking;
+return this;
+}
+
/**
* The per client request override in milliseconds for the server
configured {@code evaluationTimeout}.
* If this value is not set, then the configuration for the server is
used.
diff --git
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteConnection.java
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteConnection.java
index 9435251515..fc13b27326 100644
---
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteConnection.java
+++
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteConnection.java
@@ -226,7 +226,7 @@ public class DriverRemoteConnection implements
RemoteConnection {
try {
grem
(tinkerpop) branch valentyn/http-bulking created (now 0b631db698)
This is an automated email from the ASF dual-hosted git repository. valentyn pushed a change to branch valentyn/http-bulking in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 0b631db698 buling with request parameter This branch includes the following new commits: new 0b631db698 buling with request parameter The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[PR] enable bulking for HTTP requests [tinkerpop]
vkagamlyk opened a new pull request, #2677: URL: https://github.com/apache/tinkerpop/pull/2677 in TP3 bulking works only for Bytecode requests, implemented same functionality for `DriverRemoteConnection` queries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] remove traverser serialization [tinkerpop]
vkagamlyk commented on PR #2676: URL: https://github.com/apache/tinkerpop/pull/2676#issuecomment-2211439286 replaced with https://github.com/apache/tinkerpop/pull/2677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] remove traverser serialization [tinkerpop]
vkagamlyk closed pull request #2676: remove traverser serialization URL: https://github.com/apache/tinkerpop/pull/2676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch master-http-rebased created (now a677ee3ce0)
This is an automated email from the ASF dual-hosted git repository. kenhuuu pushed a change to branch master-http-rebased in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at a677ee3ce0 Add support for HTTP content compression. This branch includes the following new commits: new a505461227 Revert "Merge branch '3.7-dev'" new edfbc419aa Revert "Merge branch '3.7-dev'" new fd99363742 Revert "Merge branch '3.7-dev'" new 18041b8eff Revert "Parallel Authentication Fix (#2551)" new e982a0cd23 Add chunked transfer encoding to HTTP Channelizer. new bde11acfc6 Remove the UnifiedChannelizer/UnifiedHandler and associated classes. new d36eb4805e draft for GraphSON4 and GraphBinary streaming draft (#2531) new 592e9976e8 Add HTTP request checker and return error for non-POST requests new 1c1d95e156 requestmessage serde with graphson/graphbinary new 5a2897a917 Fixes for g when not present, test issues, incorrect streaming. new acbb44482d streaming untyped graphson (#2535) new f662ce9678 Remove the OpProcessors and related classes. new 01e6ca52e3 Remove WebSockets from the server. new 37f304fa9c HttpGremlinEndpointHandler cleanup (#2540) new be678a4fb4 Minimal changes to get gremlin-driver working with integration tests (#2543) new 9ab9d0093b Split HTTP endpoint into several handlers and update to use RequestMessageV4 (#2550) new 8aed25d497 draft java driver (#2557) new 78434b5fa0 update response format (#2564) new ac5aa4752d Introduce Netty handler for managing request IDs. new 87b4ba2a93 Add back evaluationTimeout and materializeProperties new 8525495a56 Remove RequestId from RequestMessageV4 CTR new 43518b9834 Renamed "evaluationTimeout" to "timeoutMs" in RequestMessageV4. new 88ceefe702 http error handling (#2570) new 5a952d390b ResponseStatusCode removal (#2572) new 75059960a9 fix some tests (#2574) new 4546bbc3c0 requestId removal (#2575) new 267c86b998 Create MessageSerializerV4s and remove MessageSerializer. (#2576) new 949aa7f950 Update IO tests to test MessageSerializerV4. (#2586) new 055faf7f7c Minor cleanup of items related to HTTP CTR. new 622b84b026 Remove user agent from HTTP request body. new d5d3dcd5e4 Replace message in trailers with exception CTR. new eb822a2344 Remove CHUNKING_NOT_SUPPORTED state CTR. new b7bf72e668 Revert GraphManager changes added in TINKERPOP-2806 CTR. new a0729fbf5b Change GraphSONv4 response to have message and exception for error responses only CTR new d6600b72a5 connection pooling (#2582) new a6af318ce9 driver error handling (#2594) new 8a454702ff Replace ResponseResult with ResponseResultV4. (#2595) new f0b26dada5 Remove RequestId from RequestMessageV4 CTR. new b50f2ba979 Fix incorrect ResponseMessage in TextPlainMessageSerializerV4Test CTR new e1ad488cfd sigv4 auth client implementation (#2601) new 9e2454b7c7 remove debugging info from client CTR new a847717725 cleanup new 0fcd1ed5f4 rename tokens CTR new 3c7f54994e rework remote console (#2611) new 3e126fe60d remove ConnectionHelper CTR new 84c3f2914c Re-enable certain tests and add fixes. (#2621) new 59ea8a3cbb Fix gremlin-util tests CTR. new f6ba4dc17a Re-enable and fix shouldBlowTheWorkQueueSize test CTR. new a2c4773f4c Check for server pipelining CTR. new 615f1362c1 Prevent Java driver channel from being reused too early CTR. new 49f1ed6063 Update console test to use line separator CTR new 6cf68f9afe Updated tests that depended on PARTIAL_CONTENT status CTR new 598aec48b7 Bytecode removal from Java GLV (#2648) new f836285c1b fix tests after merge CTR new a705a089e2 cleanup CTR new a8f37af6da Python driver basic connectivity to HTTP server (#2657) new 2de46aebf4 Bytecode removal from server (#2661) new a677ee3ce0 Add support for HTTP content compression. The 58 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
