Re: [PR] Bump aiohttp from 3.8.0 to 3.9.5 in /gremlin-python/src/main/python [tinkerpop]
dependabot[bot] commented on PR #2566: URL: https://github.com/apache/tinkerpop/pull/2566#issuecomment-2260703437 Superseded by #2699. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump aiohttp from 3.8.0 to 3.9.5 in /gremlin-python/src/main/python [tinkerpop]
dependabot[bot] closed pull request #2566: Bump aiohttp from 3.8.0 to 3.9.5 in /gremlin-python/src/main/python URL: https://github.com/apache/tinkerpop/pull/2566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump aiohttp from 3.8.0 to 3.10.0 in /gremlin-python/src/main/python [tinkerpop]
dependabot[bot] opened a new pull request, #2699: URL: https://github.com/apache/tinkerpop/pull/2699 Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.8.0 to 3.10.0. Release notes Sourced from https://github.com/aio-libs/aiohttp/releases;>aiohttp's releases. 3.10.0 Bug fixes Fixed server response headers for Content-Type and Content-Encoding for static compressed files -- by :user:steverep. Server will now respond with a Content-Type appropriate for the compressed file (e.g. application/gzip), and omit the Content-Encoding header. Users should expect that most clients will no longer decompress such responses by default. Related issues and pull requests on GitHub: https://redirect.github.com/aio-libs/aiohttp/issues/4462;>#4462. Fixed duplicate cookie expiration calls in the CookieJar implementation Related issues and pull requests on GitHub: https://redirect.github.com/aio-libs/aiohttp/issues/7784;>#7784. Adjusted FileResponse to check file existence and access when preparing the response -- by :user:steverep. The :py:class:~aiohttp.web.FileResponse class was modified to respond with 403 Forbidden or 404 Not Found as appropriate. Previously, it would cause a server error if the path did not exist or could not be accessed. Checks for existence, non-regular files, and permissions were expected to be done in the route handler. For static routes, this now permits a compressed file to exist without its uncompressed variant and still be served. In addition, this changes the response status for files without read permission to 403, and for non-regular files from 404 to 403 for consistency. Related issues and pull requests on GitHub: https://redirect.github.com/aio-libs/aiohttp/issues/8182;>#8182. Fixed AsyncResolver to match ThreadedResolver behavior -- by :user:bdraco. On system with IPv6 support, the :py:class:~aiohttp.resolver.AsyncResolver would not fallback to providing A records when records were not available. Additionally, unlike the :py:class:~aiohttp.resolver.ThreadedResolver, the :py:class:~aiohttp.resolver.AsyncResolver did not handle link-local addresses correctly. ... (truncated) Changelog Sourced from https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst;>aiohttp's changelog. 3.10.0 (2024-07-30) Bug fixes Fixed server response headers for Content-Type and Content-Encoding for static compressed files -- by :user:steverep. Server will now respond with a Content-Type appropriate for the compressed file (e.g. application/gzip), and omit the Content-Encoding header. Users should expect that most clients will no longer decompress such responses by default. Related issues and pull requests on GitHub: :issue:4462. Fixed duplicate cookie expiration calls in the CookieJar implementation Related issues and pull requests on GitHub: :issue:7784. Adjusted FileResponse to check file existence and access when preparing the response -- by :user:steverep. The :py:class:~aiohttp.web.FileResponse class was modified to respond with 403 Forbidden or 404 Not Found as appropriate. Previously, it would cause a server error if the path did not exist or could not be accessed. Checks for existence, non-regular files, and permissions were expected to be done in the route handler. For static routes, this now permits a compressed file to exist without its uncompressed variant and still be served. In addition, this changes the response status for files without read permission to 403, and for non-regular files from 404 to 403 for consistency. Related issues and pull requests on GitHub: :issue:8182. Fixed AsyncResolver to match ThreadedResolver behavior -- by :user:bdraco. On system with IPv6 support, the :py:class:~aiohttp.resolver.AsyncResolver would not fallback to providing A records when records were not available. ... (truncated) Commits https://github.com/aio-libs/aiohttp/commit/7f298511915205d86ac12c0e79bfeda138ffb451;>7f29851 Release 3.10.0 (attempt 2) (https://redirect.github.com/aio-libs/aiohttp/issues/8552;>#8552) https://github.com/aio-libs/aiohttp/commit/fc201e845dd5e98c6d96bc3bd3c9ea00e8035a29;>fc201e8 Release 3.10.0 (https://redirect.github.com/aio-libs/aiohttp/issues/8550;>#8550) https://github.com/aio-libs/aiohttp/commit/305f67a223ec69a2013ba2e887ca2d5f2c42df31;>305f67a Release 3.10.0rc0 (https://redirect.github.com/aio-libs/aiohttp/issues/8545;>#8545) https://github.com/aio-libs/aiohttp/commit/ed8de3ace43be5aca78800b6652ed63fdc75766d;>ed8de3a [PR https://redirect.github.com/aio-libs/aiohttp/issues/8541;>#8541/a561fa99 backport][3.10] Cleanup for https://redirect.github.com/aio-libs/aiohttp/issues/8495;>#8495
Re: [PR] cleanup for ResponseMessageV4 [tinkerpop]
kenhuuu commented on PR #2698: URL: https://github.com/apache/tinkerpop/pull/2698#issuecomment-2258846454 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump @types/node from 20.14.2 to 22.0.0 in /docs/gremlint [tinkerpop]
dependabot[bot] opened a new pull request, #2697: URL: https://github.com/apache/tinkerpop/pull/2697 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.14.2 to 22.0.0. Commits See full diff in https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump @types/node from 20.14.2 to 22.0.0 in /gremlint [tinkerpop]
dependabot[bot] opened a new pull request, #2696: URL: https://github.com/apache/tinkerpop/pull/2696 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.14.2 to 22.0.0. Commits See full diff in https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump eslint from 8.57.0 to 9.6.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript [tinkerpop]
dependabot[bot] closed pull request #2670: Bump eslint from 8.57.0 to 9.6.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript URL: https://github.com/apache/tinkerpop/pull/2670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump eslint from 8.57.0 to 9.5.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript [tinkerpop]
dependabot[bot] closed pull request #2656: Bump eslint from 8.57.0 to 9.5.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript URL: https://github.com/apache/tinkerpop/pull/2656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump eslint from 8.57.0 to 9.7.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript [tinkerpop]
dependabot[bot] closed pull request #2685: Bump eslint from 8.57.0 to 9.7.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript URL: https://github.com/apache/tinkerpop/pull/2685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump eslint from 8.57.0 to 9.6.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript [tinkerpop]
dependabot[bot] commented on PR #2670: URL: https://github.com/apache/tinkerpop/pull/2670#issuecomment-2256163554 Superseded by #2695. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump eslint from 8.57.0 to 9.5.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript [tinkerpop]
dependabot[bot] commented on PR #2656: URL: https://github.com/apache/tinkerpop/pull/2656#issuecomment-2256163406 Superseded by #2695. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump eslint from 8.57.0 to 9.8.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript [tinkerpop]
dependabot[bot] opened a new pull request, #2695: URL: https://github.com/apache/tinkerpop/pull/2695 Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 9.8.0. Release notes Sourced from https://github.com/eslint/eslint/releases;>eslint's releases. v9.8.0 Features https://github.com/eslint/eslint/commit/13d0bd371eb8eb4aa1601c8727212a62ab923d0e;>13d0bd3 feat: Add and use SourceCode#getLoc/getRange (https://redirect.github.com/eslint/eslint/issues/18703;>#18703) (Nicholas C. Zakas) Bug Fixes https://github.com/eslint/eslint/commit/ab0ff2755d6950d7e7fb92944771c1c30f933e02;>ab0ff27 fix: Throw error when invalid flags passed (https://redirect.github.com/eslint/eslint/issues/18705;>#18705) (Nicholas C. Zakas) https://github.com/eslint/eslint/commit/70dc80337328338f3811040e3f1a1bd5674ecbd2;>70dc803 fix: basePath directory can never be ignored (https://redirect.github.com/eslint/eslint/issues/18711;>#18711) (Milos Djermanovic) Documentation https://github.com/eslint/eslint/commit/282df1aef3c3e62f2617c6c2944944510f287a07;>282df1a docs: Add system theme option (https://redirect.github.com/eslint/eslint/issues/18617;>#18617) (Amaresh S M) https://github.com/eslint/eslint/commit/53b1ff047948e36682fade502c949f4e371e53cd;>53b1ff0 docs: Debug config docs (https://redirect.github.com/eslint/eslint/issues/18698;>#18698) (Nicholas C. Zakas) https://github.com/eslint/eslint/commit/a7016a50d88011f279d52b9355a5662e561c414c;>a7016a5 docs: fix search input stylings (https://redirect.github.com/eslint/eslint/issues/18682;>#18682) (Amaresh S M) Build Related https://github.com/eslint/eslint/commit/45144243f3b5762bd8e19e41749a7d330a723ada;>4514424 build: Enable JSON linting (https://redirect.github.com/eslint/eslint/issues/18681;>#18681) (Nicholas C. Zakas) Chores https://github.com/eslint/eslint/commit/deee4480def929cfa7f5b75f315d84f23eaba592;>deee448 chore: upgrade to @eslint/js@9.8.0 (https://redirect.github.com/eslint/eslint/issues/18720;>#18720) (Francesco Trotta) https://github.com/eslint/eslint/commit/4aaf2b39ba3659aff0c769de4ccefa3d5379ff93;>4aaf2b3 chore: package.json update for @eslint/js release (Jenkins) https://github.com/eslint/eslint/commit/8e1a627a6784380ca7e7670e336bbe9630da2da1;>8e1a627 chore: update dependency @eslint/core to ^0.2.0 (https://redirect.github.com/eslint/eslint/issues/18700;>#18700) (renovate[bot]) v9.7.0 Features https://github.com/eslint/eslint/commit/7bd98398f112da020eddcda2c26cf4cc563af004;>7bd9839 feat: add support for es2025 duplicate named capturing groups (https://redirect.github.com/eslint/eslint/issues/18630;>#18630) (Yosuke Ota) https://github.com/eslint/eslint/commit/1381394a75b5902ce588455765a3919e2f138a7a;>1381394 feat: add regex option in no-restricted-imports (https://redirect.github.com/eslint/eslint/issues/18622;>#18622) (Nitin Kumar) Bug Fixes https://github.com/eslint/eslint/commit/14e9f81ccdb51d2b915b68f442d48ced0a691646;>14e9f81 fix: destructuring in catch clause in no-unused-vars (https://redirect.github.com/eslint/eslint/issues/18636;>#18636) (Francesco Trotta) Documentation https://github.com/eslint/eslint/commit/9f416db680ad01716a769296085bf3eb93f76424;>9f416db docs: Add Powered by Algolia label to the search. (https://redirect.github.com/eslint/eslint/issues/18633;>#18633) (Amaresh S M) https://github.com/eslint/eslint/commit/c8d26cb4a2f9d89bfc1914167d3e9f1d3314ffe7;>c8d26cb docs: Open JS Foundation - OpenJS Foundation (https://redirect.github.com/eslint/eslint/issues/18649;>#18649) (Milos Djermanovic) https://github.com/eslint/eslint/commit/6e79ac76f44b34c24a3e92c20713fbafe1dcbae2;>6e79ac7 docs: loadESLint does not support option cwd (https://redirect.github.com/eslint/eslint/issues/18641;>#18641) (Francesco Trotta) Chores https://github.com/eslint/eslint/commit/793b7180119e7e440d685defb2ee01597574ef1e;>793b718 chore: upgrade @eslint/jshttps://github.com/9;>@9.7.0 (https://redirect.github.com/eslint/eslint/issues/18680;>#18680) (Francesco Trotta) https://github.com/eslint/eslint/commit/7ed6f9a4db702bbad941422f456451a8dba7a450;>7ed6f9a chore: package.json update for @eslint/js release (Jenkins) https://github.com/eslint/eslint/commit/7bcda760369c44d0f1131fccaaf1ccfed5af85f1;>7bcda76 refactor: Add type references (https://redirect.github.com/eslint/eslint/issues/18652;>#18652) (Nicholas C. Zakas) https://github.com/eslint/eslint/commit/51bf57c493a65baeee3a935f2d0e52e27271fb48;>51bf57c chore: add tech sponsors through actions (https://redirect.github.com/eslint/eslint/issues/18624;>#18624) (Strek) https://github.com/eslint/eslint/commit/6320732c3e2a52a220552e348108c53c60f9ef7a;>6320732 refactor: don't use parent property in NodeEventGenerator (https://redirect.github.com/eslint/eslint/issues/18653;>#18653) (Milos Djermanovic)
Re: [PR] Bump eslint from 8.57.0 to 9.7.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript [tinkerpop]
dependabot[bot] commented on PR #2685: URL: https://github.com/apache/tinkerpop/pull/2685#issuecomment-2256163735 Superseded by #2695. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove redundant six dependency [tinkerpop]
vkagamlyk merged PR #2692: URL: https://github.com/apache/tinkerpop/pull/2692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove redundant six dependency [tinkerpop]
vkagamlyk commented on PR #2692: URL: https://github.com/apache/tinkerpop/pull/2692#issuecomment-2253029189 VOTE+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove redundant six dependency [tinkerpop]
Cole-Greer commented on PR #2692: URL: https://github.com/apache/tinkerpop/pull/2692#issuecomment-2248671775 Thanks @hugovk, looks great! Just so you know, our process requires 3 approving votes and then we can merge the PR. My vote is VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove redundant six dependency [tinkerpop]
xiazcy commented on PR #2692: URL: https://github.com/apache/tinkerpop/pull/2692#issuecomment-2248671487 Thank you for the update! VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove redundant six dependency [tinkerpop]
hugovk commented on PR #2692: URL: https://github.com/apache/tinkerpop/pull/2692#issuecomment-2247213082 Updated! Also removed the mock backport dependency, we can use the stdlib version instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove redundant six dependency [tinkerpop]
hugovk commented on PR #2692: URL: https://github.com/apache/tinkerpop/pull/2692#issuecomment-2247145973 Sure, coming up! I didn't fully expect changing the base branch on the PR would work, but I'll rebase locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3098] added configuration for logging level for Gremlin Console in Windows [tinkerpop]
vkagamlyk merged PR #2694: URL: https://github.com/apache/tinkerpop/pull/2694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3098] added configuration for logging level for Gremlin Console in Windows [tinkerpop]
vkagamlyk commented on PR #2694: URL: https://github.com/apache/tinkerpop/pull/2694#issuecomment-2246442399 VOTE+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove redundant six dependency [tinkerpop]
Cole-Greer commented on PR #2692: URL: https://github.com/apache/tinkerpop/pull/2692#issuecomment-2246350761 Hi @hugovk, Thanks for submitting this PR. Due to our branching structure, it would be best for this change to go into `3.6-dev` in order for the change to be incorporated in the existing 3.6.x and 3.7.x release lines, as well as future major releases. Would you retargetting this PR to the `3.6-dev` branch? > Do you still support Python 3.4? I don't think so, but couldn't find the min version documented. Well, this can be also removed if not: Thanks for catching this. We do not support Python 3.4 anymore. Our current min version is python 3.8, however this will soon be raised to something more modern as 3.8 falls out of support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3098] added configuration for logging level for Gremlin Console in Windows [tinkerpop]
Cole-Greer commented on PR #2694: URL: https://github.com/apache/tinkerpop/pull/2694#issuecomment-2246334753 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for HTTP chunked transfer in gremlin-python [tinkerpop]
xiazcy merged PR #2686: URL: https://github.com/apache/tinkerpop/pull/2686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3098] added configuration for logging level for Gremlin Console in Windows [tinkerpop]
xiazcy commented on PR #2694: URL: https://github.com/apache/tinkerpop/pull/2694#issuecomment-2243817827 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for HTTP chunked transfer in gremlin-python [tinkerpop]
xiazcy commented on PR #2686: URL: https://github.com/apache/tinkerpop/pull/2686#issuecomment-2243801894 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for HTTP chunked transfer in gremlin-python [tinkerpop]
xiazcy commented on code in PR #2686:
URL: https://github.com/apache/tinkerpop/pull/2686#discussion_r1687132903
##
gremlin-python/src/main/python/gremlin_python/driver/protocol.py:
##
@@ -203,6 +60,12 @@ def __init__(self,
self._message_serializer = message_serializer
self._username = username
self._password = password
+self._response_msg = {'status': {'code': 0,
Review Comment:
I think I'll leave it for now, these values do get replaced in the chunking
methods as soon as we read the response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add support for HTTP chunked transfer in gremlin-python [tinkerpop]
kenhuuu commented on PR #2686: URL: https://github.com/apache/tinkerpop/pull/2686#issuecomment-2243710928 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for HTTP chunked transfer in gremlin-python [tinkerpop]
kenhuuu commented on code in PR #2686:
URL: https://github.com/apache/tinkerpop/pull/2686#discussion_r1687074864
##
gremlin-python/src/main/python/gremlin_python/driver/protocol.py:
##
@@ -203,6 +60,12 @@ def __init__(self,
self._message_serializer = message_serializer
self._username = username
self._password = password
+self._response_msg = {'status': {'code': 0,
Review Comment:
0 is probably not the right default for code unless you are explicitly
checking for 0 as a sentinel value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add support for HTTP chunked transfer in gremlin-python [tinkerpop]
vkagamlyk commented on PR #2686: URL: https://github.com/apache/tinkerpop/pull/2686#issuecomment-2243401339 VOTE+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump mocha from 10.4.0 to 10.7.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript [tinkerpop]
dependabot[bot] opened a new pull request, #2693: URL: https://github.com/apache/tinkerpop/pull/2693 Bumps [mocha](https://github.com/mochajs/mocha) from 10.4.0 to 10.7.0. Release notes Sourced from https://github.com/mochajs/mocha/releases;>mocha's releases. v10.7.0 What's Changed feat: add option to not fail on failing test suite by https://github.com/ilgonmic;>@ilgonmic in https://redirect.github.com/mochajs/mocha/pull/4771;>mochajs/mocha#4771 New Contributors https://github.com/ilgonmic;>@ilgonmic made their first contribution in https://redirect.github.com/mochajs/mocha/pull/4771;>mochajs/mocha#4771 Full Changelog: https://github.com/mochajs/mocha/compare/v10.6.1...v10.7.0;>https://github.com/mochajs/mocha/compare/v10.6.1...v10.7.0 v10.6.1 What's Changed fix: do not exit when only unref'd timer is present in test code by https://github.com/boneskull;>@boneskull in https://redirect.github.com/mochajs/mocha/pull/3825;>mochajs/mocha#3825 fix: support canonical module by https://github.com/JacobLey;>@JacobLey in https://redirect.github.com/mochajs/mocha/pull/5040;>mochajs/mocha#5040 Full Changelog: https://github.com/mochajs/mocha/compare/v10.6.0...v10.6.1;>https://github.com/mochajs/mocha/compare/v10.6.0...v10.6.1 v10.6.0 What's Changed feat: allow ^ versions for character encoding packages by https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg in https://redirect.github.com/mochajs/mocha/pull/5150;>mochajs/mocha#5150 feat: allow ^ versions for yargs packages by https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg in https://redirect.github.com/mochajs/mocha/pull/5152;>mochajs/mocha#5152 feat: allow ^ versions for file matching packages by https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg in https://redirect.github.com/mochajs/mocha/pull/5151;>mochajs/mocha#5151 feat: allow ^ versions for data serialization packages by https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg in https://redirect.github.com/mochajs/mocha/pull/5153;>mochajs/mocha#5153 feat: allow ^ versions for miscellaneous packages by https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg in https://redirect.github.com/mochajs/mocha/pull/5154;>mochajs/mocha#5154 Full Changelog: https://github.com/mochajs/mocha/compare/v10.5.2...v10.6.0;>https://github.com/mochajs/mocha/compare/v10.5.2...v10.6.0 v10.5.2 What's Changed fix: better tracking of seen objects in error serialization by https://github.com/sam-super;>@sam-super in https://redirect.github.com/mochajs/mocha/pull/5032;>mochajs/mocha#5032 New Contributors https://github.com/sam-super;>@sam-super made their first contribution in https://redirect.github.com/mochajs/mocha/pull/5032;>mochajs/mocha#5032 Full Changelog: https://github.com/mochajs/mocha/compare/v10.5.1...v10.5.2;>https://github.com/mochajs/mocha/compare/v10.5.1...v10.5.2 v10.5.1 What's Changed fix: Add error handling for nonexistent file case with --file option by https://github.com/khoaHyh;>@khoaHyh in https://redirect.github.com/mochajs/mocha/pull/5086;>mochajs/mocha#5086 New Contributors https://github.com/khoaHyh;>@khoaHyh made their first contribution in https://redirect.github.com/mochajs/mocha/pull/5086;>mochajs/mocha#5086 Full Changelog: https://github.com/mochajs/mocha/compare/v10.5.0...v10.5.1;>https://github.com/mochajs/mocha/compare/v10.5.0...v10.5.1 v10.5.0 :tada: Enhancements ... (truncated) Changelog Sourced from https://github.com/mochajs/mocha/blob/main/CHANGELOG.md;>mocha's changelog. 10.7.0 / 2024-07-20 :tada: Enhancements https://redirect.github.com/mochajs/mocha/pull/4771;>#4771 feat: add option to not fail on failing test suite (https://github.com/ilgonmic;>@ilgonmic) 10.6.1 / 2024-07-20 :bug: Fixes https://redirect.github.com/mochajs/mocha/pull/3825;>#3825 fix: do not exit when only unref'd timer is present in test code (https://github.com/boneskull;>@boneskull) https://redirect.github.com/mochajs/mocha/pull/5040;>#5040 fix: support canonical module (https://github.com/JacobLey;>@JacobLey) 10.6.0 / 2024-07-02 :tada: Enhancements https://redirect.github.com/mochajs/mocha/pull/5150;>#5150 feat: allow ^ versions for character encoding packages (https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg) https://redirect.github.com/mochajs/mocha/pull/5151;>#5151 feat: allow ^ versions for file matching packages (https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg) https://redirect.github.com/mochajs/mocha/pull/5152;>#5152 feat: allow ^ versions for yargs packages (https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg) https://redirect.github.com/mochajs/mocha/pull/5153;>#5153 feat: allow ^ versions for data serialization packages (https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg)
Re: [PR] Remove redundant six dependency [tinkerpop]
codecov-commenter commented on PR #2692: URL: https://github.com/apache/tinkerpop/pull/2692#issuecomment-2242682725 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2692?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 80.37%. Comparing base [(`2d32517`)](https://app.codecov.io/gh/apache/tinkerpop/commit/2d32517b3bca1b00d716b3205c2abdbcd6ed3352?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`34ca06d`)](https://app.codecov.io/gh/apache/tinkerpop/commit/34ca06dc8b3f3204c66ab31c38840e5799d3eabe?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 261 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master#2692 +/- ## + Coverage 76.16% 80.37% +4.21% Files 1085 27-1058 Lines 65189 5015 -60174 Branches 72890-7289 - Hits 49651 4031 -45620 + Misses12830 781 -12049 + Partials 2708 203-2505 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2692?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Remove redundant six dependency [tinkerpop]
hugovk opened a new pull request, #2692: URL: https://github.com/apache/tinkerpop/pull/2692 The Python package no longer uses the six library, but still installs it as a dependency. Let's remove it to make installs a bit quicker and smaller. Also universal wheels are for supporting both Python 2 and 3, so is no longer needed. Do you still support Python 3.4? I don't think so, but couldn't find the min version documented. Well, this can be also removed if not: ```python if sys.version_info < (3, 5): install_requires += ['pyparsing>=2.4.7,<3.0.0'] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for HTTP chunked transfer in gremlin-python [tinkerpop]
xiazcy commented on PR #2686: URL: https://github.com/apache/tinkerpop/pull/2686#issuecomment-2239907791 > is it possible to fix or turn off invalid tests? Yes, there is a flag to skip them. However, right now tests won't pass anyways because we are sending bytecode, and Docker isn't set up for it. I plan to remove bytecode next so we can re-enable all integration tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.29.1 [tinkerpop]
dependabot[bot] commented on PR #2690: URL: https://github.com/apache/tinkerpop/pull/2690#issuecomment-2239306705 Superseded by #2691. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.29.1 [tinkerpop]
dependabot[bot] closed pull request #2690: Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.29.1 URL: https://github.com/apache/tinkerpop/pull/2690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.29.2 [tinkerpop]
dependabot[bot] opened a new pull request, #2691: URL: https://github.com/apache/tinkerpop/pull/2691 Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.4.0 to 2.29.2. Release notes Sourced from https://github.com/google/error-prone/releases;>com.google.errorprone:error_prone_annotations's releases. Error Prone 2.29.2 This release contains all of the changes in https://github.com/google/error-prone/releases/tag/v2.29.0;>2.29.0 and https://github.com/google/error-prone/releases/tag/v2.29.1;>2.29.1, plus: a bug fix for a crash in TraditionalSwitchExpression (https://redirect.github.com/google/error-prone/issues/4479;>google/error-prone#4479) restores the module-info for the annotations jar, which was accidentally removed (https://redirect.github.com/google/error-prone/issues/4480;>google/error-prone#4480) Full Changelog: https://github.com/google/error-prone/compare/v2.29.1...v2.29.2;>https://github.com/google/error-prone/compare/v2.29.1...v2.29.2 Error Prone 2.29.1 This release contains all of the changes in https://github.com/google/error-prone/releases/tag/v2.29.0;>2.29.0, plus: a bug fix to UnusedVariable to handle unnamed _ variables (https://redirect.github.com/google/error-prone/issues/4451;>google/error-prone#4451) a bug fix for a crash in SetUnrecognized (https://redirect.github.com/google/error-prone/issues/4475;>google/error-prone#4475) Full Changelog: https://github.com/google/error-prone/compare/v2.29.0...v2.29.1;>https://github.com/google/error-prone/compare/v2.29.0...v2.29.1 Error Prone 2.29.0 New checks: https://errorprone.info/bugpattern/MissingRuntimeRetention;>MissingRuntimeRetention https://errorprone.info/bugpattern/SetUnrecognized;>SetUnrecognized https://errorprone.info/bugpattern/StatementSwitchToExpressionSwitch;>StatementSwitchToExpressionSwitch Closed issues: https://redirect.github.com/google/error-prone/issues/4318;>#4318, https://redirect.github.com/google/error-prone/issues/4429;>#4429, https://redirect.github.com/google/error-prone/issues/4467;>#4467 Full Changelog: https://github.com/google/error-prone/compare/v2.28.0...v2.29.0;>https://github.com/google/error-prone/compare/v2.28.0...v2.29.0 Error Prone 2.28.0 Error Prone nows supports the latest JDK 23 EA builds (https://redirect.github.com/google/error-prone/issues/4412;>#4412, https://redirect.github.com/google/error-prone/issues/4415;>#4415). Closed issues: Improved errors for invalid check severities (https://redirect.github.com/google/error-prone/issues/4306;>#4306). Fix a crash with nested instanceof patterns (https://redirect.github.com/google/error-prone/issues/4349;>#4349). Fix a crash in JUnitIncompatibleType (https://redirect.github.com/google/error-prone/issues/4377;>#4377). In ObjectEqualsForPrimitives, don't suggest replacing equal with == for floating-point values (https://redirect.github.com/google/error-prone/issues/4392;>#4392). New checks: https://errorprone.info/bugpattern/DeeplyNested;>DeeplyNested discourages very deeply nested code that can cause StackOverflowErrors during compilation. https://errorprone.info/bugpattern/GuiceNestedCombine;>GuiceNestedCombine discourages nesting of Modules.combine(), which is unnecessary. https://errorprone.info/bugpattern/PatternMatchingInstanceof;>PatternMatchingInstanceof migrates code to use https://openjdk.org/jeps/394;>pattern matching for instanceof https://errorprone.info/bugpattern/SunApi;>SunApi discourages use of internal proprietary JDK APIs which may be removed from future releases. Full Changelog: https://github.com/google/error-prone/compare/v2.27.1...v2.28.0;>https://github.com/google/error-prone/compare/v2.27.1...v2.28.0 Error Prone 2.27.1 This release contains all of the changes in https://github.com/google/error-prone/releases/tag/v2.27.0;>2.27.0, plus a bug fix to https://errorprone.info/bugpattern/ClassInitializationDeadlock;>ClassInitializationDeadlock (https://redirect.github.com/google/error-prone/issues/4378;>google/error-prone#4378) Full Changelog: https://github.com/google/error-prone/compare/v2.27.0...v2.27.1;>https://github.com/google/error-prone/compare/v2.27.0...v2.27.1 ... (truncated) Commits https://github.com/google/error-prone/commit/436f891d38b23e405214d7ada9d77f6ba6099ad2;>436f891 Release Error Prone 2.29.2 https://github.com/google/error-prone/commit/526aa72ce8c09d10129c4d51bda0decddd99d56a;>526aa72 Restore module-info. https://github.com/google/error-prone/commit/a19bcbc0a839f403b32ac01bd85f8cbe49a1403e;>a19bcbc StatementSwitchToExpressionSwitch: Enhance code comment handling for direct c... https://github.com/google/error-prone/commit/5c26d0df6ee6e98027c2d41375cd6961b6ec38f9;>5c26d0d Fix ASTHelpers#isRuleKind on JDK versions without CaseTree#getCaseKind
Re: [PR] Add support for HTTP chunked transfer in gremlin-python [tinkerpop]
vkagamlyk commented on code in PR #2686: URL: https://github.com/apache/tinkerpop/pull/2686#discussion_r1683625256 ## gremlin-python/src/main/python/gremlin_python/driver/serializer.py: ## @@ -386,10 +129,15 @@ def deserialize_message(self, message): def read_payload(self, buffer): results = [] -while buffer.readable(): +readable = True +while buffer.readable(): # find method or way to access readable bytes without using buffer.getvalue() +# print(buffer.tell()) Review Comment: nit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] enable bulking for HTTP requests [tinkerpop]
vkagamlyk commented on PR #2679: URL: https://github.com/apache/tinkerpop/pull/2679#issuecomment-2237733993 > is the bulking feature optional for the server? it feels like it should be an optimization that the server can choose to implement or not rather than something required since it is now being treated as a parameter. i also wonder if the driver should be required to get that setting right for it to work. it was different when there was bytecode. the user (and driver provider) had no control over these options, but this is different now under http. I changed implementation that the client can consume the server's results both in the form of `RemoteTraverser` and flat data. So server can return any result from now, providers may decide what is better is there use cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.29.0 [tinkerpop]
dependabot[bot] commented on PR #2688: URL: https://github.com/apache/tinkerpop/pull/2688#issuecomment-2236808991 Superseded by #2690. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.29.1 [tinkerpop]
dependabot[bot] opened a new pull request, #2690: URL: https://github.com/apache/tinkerpop/pull/2690 Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.4.0 to 2.29.1. Release notes Sourced from https://github.com/google/error-prone/releases;>com.google.errorprone:error_prone_annotations's releases. Error Prone 2.29.1 This release contains all of the changes in https://github.com/google/error-prone/releases/tag/v2.29.0;>2.29.0, plus: a bug fix to UnusedVariable to handle unnamed _ variables (https://redirect.github.com/google/error-prone/issues/4451;>google/error-prone#4451) a bug fix for a crash in SetUnrecognized (https://redirect.github.com/google/error-prone/issues/4475;>google/error-prone#4475) Full Changelog: https://github.com/google/error-prone/compare/v2.29.0...v2.29.1;>https://github.com/google/error-prone/compare/v2.29.0...v2.29.1 Error Prone 2.29.0 New checks: https://errorprone.info/bugpattern/MissingRuntimeRetention;>MissingRuntimeRetention https://errorprone.info/bugpattern/SetUnrecognized;>SetUnrecognized https://errorprone.info/bugpattern/StatementSwitchToExpressionSwitch;>StatementSwitchToExpressionSwitch Closed issues: https://redirect.github.com/google/error-prone/issues/4318;>#4318, https://redirect.github.com/google/error-prone/issues/4429;>#4429, https://redirect.github.com/google/error-prone/issues/4467;>#4467 Full Changelog: https://github.com/google/error-prone/compare/v2.28.0...v2.29.0;>https://github.com/google/error-prone/compare/v2.28.0...v2.29.0 Error Prone 2.28.0 Error Prone nows supports the latest JDK 23 EA builds (https://redirect.github.com/google/error-prone/issues/4412;>#4412, https://redirect.github.com/google/error-prone/issues/4415;>#4415). Closed issues: Improved errors for invalid check severities (https://redirect.github.com/google/error-prone/issues/4306;>#4306). Fix a crash with nested instanceof patterns (https://redirect.github.com/google/error-prone/issues/4349;>#4349). Fix a crash in JUnitIncompatibleType (https://redirect.github.com/google/error-prone/issues/4377;>#4377). In ObjectEqualsForPrimitives, don't suggest replacing equal with == for floating-point values (https://redirect.github.com/google/error-prone/issues/4392;>#4392). New checks: https://errorprone.info/bugpattern/DeeplyNested;>DeeplyNested discourages very deeply nested code that can cause StackOverflowErrors during compilation. https://errorprone.info/bugpattern/GuiceNestedCombine;>GuiceNestedCombine discourages nesting of Modules.combine(), which is unnecessary. https://errorprone.info/bugpattern/PatternMatchingInstanceof;>PatternMatchingInstanceof migrates code to use https://openjdk.org/jeps/394;>pattern matching for instanceof https://errorprone.info/bugpattern/SunApi;>SunApi discourages use of internal proprietary JDK APIs which may be removed from future releases. Full Changelog: https://github.com/google/error-prone/compare/v2.27.1...v2.28.0;>https://github.com/google/error-prone/compare/v2.27.1...v2.28.0 Error Prone 2.27.1 This release contains all of the changes in https://github.com/google/error-prone/releases/tag/v2.27.0;>2.27.0, plus a bug fix to https://errorprone.info/bugpattern/ClassInitializationDeadlock;>ClassInitializationDeadlock (https://redirect.github.com/google/error-prone/issues/4378;>google/error-prone#4378) Full Changelog: https://github.com/google/error-prone/compare/v2.27.0...v2.27.1;>https://github.com/google/error-prone/compare/v2.27.0...v2.27.1 Error Prone 2.27.0 New checks: https://errorprone.info/bugpattern/ClassInitializationDeadlock;>ClassInitializationDeadlock detects class initializers that reference subtypes of the current class, which can result in deadlocks. https://errorprone.info/bugpattern/MockitoDoSetup;>MockitoDoSetup suggests using when/thenReturn over doReturn/when for additional type safety. https://errorprone.info/bugpattern/VoidUsed;>VoidUsed suggests using a literal null instead of referring to a Void-typed variable. ... (truncated) Commits https://github.com/google/error-prone/commit/9aeb0e98498cf153cd0577041510bba5c999ff72;>9aeb0e9 Release Error Prone 2.29.1 https://github.com/google/error-prone/commit/81d31274cb5fa92093420d02d9aac991935547e8;>81d3127 Fix an NPE in SetUnrecognized https://github.com/google/error-prone/commit/bc33976002cb33e658fbe4d36ae03c9872a9eab4;>bc33976 Use JSpecify 1.0! https://github.com/google/error-prone/commit/385e43a6fa69536e10fe7360b88efe03358e6e34;>385e43a Disallow using traditional :-style switches as switch expressions https://github.com/google/error-prone/commit/2656f48902f6723f3147caa117372309dbc6c15f;>2656f48 Create ThreadSafeTypeParameter to replace ThreadSafe.TypeParameter.
Re: [PR] Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.29.0 [tinkerpop]
dependabot[bot] closed pull request #2688: Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.29.0 URL: https://github.com/apache/tinkerpop/pull/2688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump web-vitals from 3.5.1 to 4.2.2 in /docs/gremlint [tinkerpop]
dependabot[bot] opened a new pull request, #2689: URL: https://github.com/apache/tinkerpop/pull/2689 Bumps [web-vitals](https://github.com/GoogleChrome/web-vitals) from 3.5.1 to 4.2.2. Changelog Sourced from https://github.com/GoogleChrome/web-vitals/blob/main/CHANGELOG.md;>web-vitals's changelog. v4.2.2 (2024-07-17) Fix interaction count after bfcache restore (https://redirect.github.com/GoogleChrome/web-vitals/pull/505;>#505) v4.2.1 (2024-06-30) Fix compatibility issues with TypeScript v5.5 (https://redirect.github.com/GoogleChrome/web-vitals/pull/497;>#497) v4.2.0 (2024-06-20) Refactor INP attribution code to fix errors on Windows 10 (https://redirect.github.com/GoogleChrome/web-vitals/pull/495;>#495) v4.1.1 (2024-06-10) Fix pending LoAF cleanup logic (https://redirect.github.com/GoogleChrome/web-vitals/pull/493;>#493) v4.1.0 (2024-06-06) Move the support check to the top of the onINP() function (https://redirect.github.com/GoogleChrome/web-vitals/pull/490;>#490) Fix missing LoAF attribution when entries are dispatched before event entries (https://redirect.github.com/GoogleChrome/web-vitals/pull/487;>#487) v4.0.1 (2024-05-21) Add the ReportCallback type back but deprecate it (https://redirect.github.com/GoogleChrome/web-vitals/pull/483;>#483) v4.0.0 (2024-05-13) [BREAKING] Update types to support more generic usage (https://redirect.github.com/GoogleChrome/web-vitals/pull/471;>#471) [BREAKING] Split waitingDuration to make it easier to understand redirect delays (https://redirect.github.com/GoogleChrome/web-vitals/pull/458;>#458) [BREAKING] Rename TTFBAttribution fields from *Time to *Duration (https://redirect.github.com/GoogleChrome/web-vitals/pull/453;>#453) [BREAKING] Rename resourceLoadTime to resourceLoadDuration in LCP attribution (https://redirect.github.com/GoogleChrome/web-vitals/pull/450;>#450) [BREAKING] Add INP breakdown timings and LoAF attribution (https://redirect.github.com/GoogleChrome/web-vitals/pull/442;>#442) [BREAKING] Deprecate onFID() and remove previously deprecated APIs (https://redirect.github.com/GoogleChrome/web-vitals/pull/435;>#435) Expose the target element in INP attribution (https://redirect.github.com/GoogleChrome/web-vitals/pull/479;>#479) Save INP target after interactions to reduce null values when removed from the DOM (https://redirect.github.com/GoogleChrome/web-vitals/pull/477;>#477) Cap TTFB in attribution (https://redirect.github.com/GoogleChrome/web-vitals/pull/440;>#440) Fix reportAllChanges behavior for LCP when library is loaded late (https://redirect.github.com/GoogleChrome/web-vitals/pull/468;>#468) v3.5.2 (2024-01-25) Pick the first non-null target for INP attribution (https://redirect.github.com/GoogleChrome/web-vitals/pull/421;>#421) Commits https://github.com/GoogleChrome/web-vitals/commit/dc0ee2b1560533e4e2a38b270d316764fe0775de;>dc0ee2b Release v4.2.2 https://github.com/GoogleChrome/web-vitals/commit/8ed9f24f3b7a70456d2e6b5a191b1769d1a50fc2;>8ed9f24 Update CHANGELOG https://github.com/GoogleChrome/web-vitals/commit/2dad97beb52ac577bd5ee92cee243ac2f16d4e86;>2dad97b Fix interaction count after bfcache restore (https://redirect.github.com/GoogleChrome/web-vitals/issues/505;>#505) https://github.com/GoogleChrome/web-vitals/commit/9bce28af7f25a0734093626857daeaeae10f6f65;>9bce28a Use fancy md notes (https://redirect.github.com/GoogleChrome/web-vitals/issues/503;>#503) https://github.com/GoogleChrome/web-vitals/commit/4c95f67d4a2fe59d9e86832391c634054659150f;>4c95f67 Remove pagehide from the README examples (https://redirect.github.com/GoogleChrome/web-vitals/issues/501;>#501) https://github.com/GoogleChrome/web-vitals/commit/d6880fdaf669735716eaf3c163baf3f2c10fefaa;>d6880fd Release v4.2.1 https://github.com/GoogleChrome/web-vitals/commit/4cb75c1519cb0dd8931362fff3f7d7f3a3bc84d3;>4cb75c1 Update CHANGELOG https://github.com/GoogleChrome/web-vitals/commit/93bd2a0026bd69e79e5ce6506dc31710f76d2d3d;>93bd2a0 fix: sync types with TS v5.5 (https://redirect.github.com/GoogleChrome/web-vitals/issues/497;>#497) https://github.com/GoogleChrome/web-vitals/commit/ab43b1f30ca6e21616f0ff7e0792e7b1073c2994;>ab43b1f Release v4.2.0 https://github.com/GoogleChrome/web-vitals/commit/304cadbfe8e9407e6792a741d4e4847e88d6c8a2;>304cadb Update CHANGELOG Additional commits viewable in https://github.com/GoogleChrome/web-vitals/compare/v3.5.1...v4.2.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't
Re: [PR] TINKERPOP-3096: improvement: add necessary parameters for logging to fix '%!x(MISSING)' output issue in gremlin-go [tinkerpop]
xiazcy merged PR #2684: URL: https://github.com/apache/tinkerpop/pull/2684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-3096: improvement: add necessary parameters for logging to fix '%!x(MISSING)' output issue in gremlin-go [tinkerpop]
codecov-commenter commented on PR #2684: URL: https://github.com/apache/tinkerpop/pull/2684#issuecomment-2233900455 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2684?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 80.44%. Comparing base [(`9b46b67`)](https://app.codecov.io/gh/apache/tinkerpop/commit/9b46b6777d2fa250e41daacf2fa4554605aff53a?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`71207b6`)](https://app.codecov.io/gh/apache/tinkerpop/commit/71207b6833cf3eb0db99c6cec7af9fcc575e?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 174 commits behind head on 3.7-dev. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.7-dev#2684 +/- ## = + Coverage 76.14% 80.44% +4.29% = Files 1084 27-1057 Lines 65160 4985 -60175 Branches72850-7285 = - Hits 49616 4010 -45606 + Misses 12839 773 -12066 + Partials2705 202-2503 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2684?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-3096: improvement: add necessary parameters for logging to fix '%!x(MISSING)' output issue in gremlin-go [tinkerpop]
xiazcy commented on PR #2684: URL: https://github.com/apache/tinkerpop/pull/2684#issuecomment-2233868228 Given this is a small change, I'll be merging this as CTR after the actions pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add getter for private fields to Concat, Conjoin, SplitGlobal/Local Step [tinkerpop]
xiazcy merged PR #2687: URL: https://github.com/apache/tinkerpop/pull/2687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add getter for private fields to Concat, Conjoin, SplitGlobal/Local Step [tinkerpop]
kenhuuu commented on PR #2687: URL: https://github.com/apache/tinkerpop/pull/2687#issuecomment-2233784974 VOTE +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.28.0 [tinkerpop]
dependabot[bot] closed pull request #2626: Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.28.0 URL: https://github.com/apache/tinkerpop/pull/2626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.28.0 [tinkerpop]
dependabot[bot] commented on PR #2626: URL: https://github.com/apache/tinkerpop/pull/2626#issuecomment-2233458057 Superseded by #2688. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.google.errorprone:error_prone_annotations from 2.4.0 to 2.29.0 [tinkerpop]
dependabot[bot] opened a new pull request, #2688: URL: https://github.com/apache/tinkerpop/pull/2688 Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.4.0 to 2.29.0. Release notes Sourced from https://github.com/google/error-prone/releases;>com.google.errorprone:error_prone_annotations's releases. Error Prone 2.29.0 New checks: https://errorprone.info/bugpattern/MissingRuntimeRetention;>MissingRuntimeRetention https://errorprone.info/bugpattern/SetUnrecognized;>SetUnrecognized https://errorprone.info/bugpattern/StatementSwitchToExpressionSwitch;>StatementSwitchToExpressionSwitch Closed issues: https://redirect.github.com/google/error-prone/issues/4318;>#4318, https://redirect.github.com/google/error-prone/issues/4429;>#4429, https://redirect.github.com/google/error-prone/issues/4467;>#4467 Full Changelog: https://github.com/google/error-prone/compare/v2.28.0...v2.29.0;>https://github.com/google/error-prone/compare/v2.28.0...v2.29.0 Error Prone 2.28.0 Error Prone nows supports the latest JDK 23 EA builds (https://redirect.github.com/google/error-prone/issues/4412;>#4412, https://redirect.github.com/google/error-prone/issues/4415;>#4415). Closed issues: Improved errors for invalid check severities (https://redirect.github.com/google/error-prone/issues/4306;>#4306). Fix a crash with nested instanceof patterns (https://redirect.github.com/google/error-prone/issues/4349;>#4349). Fix a crash in JUnitIncompatibleType (https://redirect.github.com/google/error-prone/issues/4377;>#4377). In ObjectEqualsForPrimitives, don't suggest replacing equal with == for floating-point values (https://redirect.github.com/google/error-prone/issues/4392;>#4392). New checks: https://errorprone.info/bugpattern/DeeplyNested;>DeeplyNested discourages very deeply nested code that can cause StackOverflowErrors during compilation. https://errorprone.info/bugpattern/GuiceNestedCombine;>GuiceNestedCombine discourages nesting of Modules.combine(), which is unnecessary. https://errorprone.info/bugpattern/PatternMatchingInstanceof;>PatternMatchingInstanceof migrates code to use https://openjdk.org/jeps/394;>pattern matching for instanceof https://errorprone.info/bugpattern/SunApi;>SunApi discourages use of internal proprietary JDK APIs which may be removed from future releases. Full Changelog: https://github.com/google/error-prone/compare/v2.27.1...v2.28.0;>https://github.com/google/error-prone/compare/v2.27.1...v2.28.0 Error Prone 2.27.1 This release contains all of the changes in https://github.com/google/error-prone/releases/tag/v2.27.0;>2.27.0, plus a bug fix to https://errorprone.info/bugpattern/ClassInitializationDeadlock;>ClassInitializationDeadlock (https://redirect.github.com/google/error-prone/issues/4378;>google/error-prone#4378) Full Changelog: https://github.com/google/error-prone/compare/v2.27.0...v2.27.1;>https://github.com/google/error-prone/compare/v2.27.0...v2.27.1 Error Prone 2.27.0 New checks: https://errorprone.info/bugpattern/ClassInitializationDeadlock;>ClassInitializationDeadlock detects class initializers that reference subtypes of the current class, which can result in deadlocks. https://errorprone.info/bugpattern/MockitoDoSetup;>MockitoDoSetup suggests using when/thenReturn over doReturn/when for additional type safety. https://errorprone.info/bugpattern/VoidUsed;>VoidUsed suggests using a literal null instead of referring to a Void-typed variable. Modified checks: TruthSelfEquals has been renamed and generalized as https://errorprone.info/bugpattern/SelfAssertion;>SelfAssertion https://errorprone.info/bugpattern/RedundantSetterCall;>RedundantSetterCall has been improved, and enabled as an error oby default Closed issues: https://redirect.github.com/google/error-prone/issues/4291;>#4291. https://redirect.github.com/google/error-prone/issues/4308;>#4308, https://redirect.github.com/google/error-prone/issues/4343;>#4343, https://redirect.github.com/google/error-prone/issues/4320;>#4320 Full Changelog: https://github.com/google/error-prone/compare/v2.26.1...v2.27.0;>https://github.com/google/error-prone/compare/v2.26.1...v2.27.0 ... (truncated) Commits https://github.com/google/error-prone/commit/0f2d0373f3562b2535ed92609aae71bce51e1f02;>0f2d037 Release Error Prone 2.29.0 https://github.com/google/error-prone/commit/d3fc5f3d5fd4560874823a1ec4d65725acb478a5;>d3fc5f3 Add the interface types for mutable protos so the object hierarchy can diverg... https://github.com/google/error-prone/commit/96b4dfff376defed3fdf1eb6a9fe7ecd0122d007;>96b4dff Lazily load plugin checks when running auto-patching https://github.com/google/error-prone/commit/8f9e7da16b81b9fd65cca5fef9a79a4e6019eabd;>8f9e7da Make patching API public
Re: [PR] Bump xunit.runner.visualstudio from 2.8.1 to 2.8.2 in /gremlin-dotnet [tinkerpop]
FlorianHockmann merged PR #2682: URL: https://github.com/apache/tinkerpop/pull/2682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump xunit from 2.8.1 to 2.9.0 in /gremlin-dotnet [tinkerpop]
FlorianHockmann merged PR #2681: URL: https://github.com/apache/tinkerpop/pull/2681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump Polly from 8.4.0 to 8.4.1 in /gremlin-dotnet [tinkerpop]
FlorianHockmann merged PR #2668: URL: https://github.com/apache/tinkerpop/pull/2668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add getter for private fields to Concat, Conjoin, SplitGlobal/Local Step [tinkerpop]
rdtr commented on PR #2687: URL: https://github.com/apache/tinkerpop/pull/2687#issuecomment-2232647690 Please merge it if there is no concern. Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add getter for private fields to Concat, Conjoin, SplitGlobal/Local Step [tinkerpop]
xiazcy commented on PR #2687: URL: https://github.com/apache/tinkerpop/pull/2687#issuecomment-2231956418 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add getter for private fields to Concat, Conjoin, SplitGlobal/Local Step [tinkerpop]
codecov-commenter commented on PR #2687: URL: https://github.com/apache/tinkerpop/pull/2687#issuecomment-2231952289 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2687?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 80.44%. Comparing base [(`9b46b67`)](https://app.codecov.io/gh/apache/tinkerpop/commit/9b46b6777d2fa250e41daacf2fa4554605aff53a?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`f272b6f`)](https://app.codecov.io/gh/apache/tinkerpop/commit/f272b6fef78fb97af67300a90a45003fa0f66421?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 167 commits behind head on 3.7-dev. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.7-dev#2687 +/- ## = + Coverage 76.14% 80.44% +4.29% = Files 1084 27-1057 Lines 65160 4985 -60175 Branches72850-7285 = - Hits 49616 4010 -45606 + Misses 12839 773 -12066 + Partials2705 202-2503 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2687?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add getter for private fields to Concat, Conjoin, SplitGlobal/Local Step [tinkerpop]
Cole-Greer commented on PR #2687: URL: https://github.com/apache/tinkerpop/pull/2687#issuecomment-2231951795 Thanks Norio, LGTM, VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add getter for private fields to Concat, Conjoin, SplitGlobal/Local Step [tinkerpop]
rdtr opened a new pull request, #2687: URL: https://github.com/apache/tinkerpop/pull/2687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-3096: improvement: add necessary parameters for logging to fix '%!x(MISSING)' output issue in gremlin-go [tinkerpop]
xiazcy commented on PR #2684: URL: https://github.com/apache/tinkerpop/pull/2684#issuecomment-2231706679 VOTE +1, thanks for fixing the bug! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add support for HTTP chunked transfer in gremlin-python [tinkerpop]
xiazcy opened a new pull request, #2686: URL: https://github.com/apache/tinkerpop/pull/2686 Added support for http chunked transfer, removed websocket and replaced old serializers with graphbinaryv4. (draft pending rebase) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump eslint from 8.57.0 to 9.7.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript [tinkerpop]
dependabot[bot] opened a new pull request, #2685: URL: https://github.com/apache/tinkerpop/pull/2685 Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 9.7.0. Release notes Sourced from https://github.com/eslint/eslint/releases;>eslint's releases. v9.7.0 Features https://github.com/eslint/eslint/commit/7bd98398f112da020eddcda2c26cf4cc563af004;>7bd9839 feat: add support for es2025 duplicate named capturing groups (https://redirect.github.com/eslint/eslint/issues/18630;>#18630) (Yosuke Ota) https://github.com/eslint/eslint/commit/1381394a75b5902ce588455765a3919e2f138a7a;>1381394 feat: add regex option in no-restricted-imports (https://redirect.github.com/eslint/eslint/issues/18622;>#18622) (Nitin Kumar) Bug Fixes https://github.com/eslint/eslint/commit/14e9f81ccdb51d2b915b68f442d48ced0a691646;>14e9f81 fix: destructuring in catch clause in no-unused-vars (https://redirect.github.com/eslint/eslint/issues/18636;>#18636) (Francesco Trotta) Documentation https://github.com/eslint/eslint/commit/9f416db680ad01716a769296085bf3eb93f76424;>9f416db docs: Add Powered by Algolia label to the search. (https://redirect.github.com/eslint/eslint/issues/18633;>#18633) (Amaresh S M) https://github.com/eslint/eslint/commit/c8d26cb4a2f9d89bfc1914167d3e9f1d3314ffe7;>c8d26cb docs: Open JS Foundation - OpenJS Foundation (https://redirect.github.com/eslint/eslint/issues/18649;>#18649) (Milos Djermanovic) https://github.com/eslint/eslint/commit/6e79ac76f44b34c24a3e92c20713fbafe1dcbae2;>6e79ac7 docs: loadESLint does not support option cwd (https://redirect.github.com/eslint/eslint/issues/18641;>#18641) (Francesco Trotta) Chores https://github.com/eslint/eslint/commit/793b7180119e7e440d685defb2ee01597574ef1e;>793b718 chore: upgrade @eslint/jshttps://github.com/9;>@9.7.0 (https://redirect.github.com/eslint/eslint/issues/18680;>#18680) (Francesco Trotta) https://github.com/eslint/eslint/commit/7ed6f9a4db702bbad941422f456451a8dba7a450;>7ed6f9a chore: package.json update for @eslint/js release (Jenkins) https://github.com/eslint/eslint/commit/7bcda760369c44d0f1131fccaaf1ccfed5af85f1;>7bcda76 refactor: Add type references (https://redirect.github.com/eslint/eslint/issues/18652;>#18652) (Nicholas C. Zakas) https://github.com/eslint/eslint/commit/51bf57c493a65baeee3a935f2d0e52e27271fb48;>51bf57c chore: add tech sponsors through actions (https://redirect.github.com/eslint/eslint/issues/18624;>#18624) (Strek) https://github.com/eslint/eslint/commit/6320732c3e2a52a220552e348108c53c60f9ef7a;>6320732 refactor: don't use parent property in NodeEventGenerator (https://redirect.github.com/eslint/eslint/issues/18653;>#18653) (Milos Djermanovic) https://github.com/eslint/eslint/commit/9e6d6405c3ee774c2e716a3453ede9696ced1be7;>9e6d640 refactor: move Parsing error prefix adding to Linter (https://redirect.github.com/eslint/eslint/issues/18650;>#18650) (Milos Djermanovic) v9.6.0 Features https://github.com/eslint/eslint/commit/e2b16e2b72606162dce3d804bc80186b6c5ec0f9;>e2b16e2 feat: Implement feature flags (https://redirect.github.com/eslint/eslint/issues/18516;>#18516) (Nicholas C. Zakas) https://github.com/eslint/eslint/commit/8824aa1469ffc572c5e5c1765d1b6da113dfba19;>8824aa1 feat: add ecmaVersion: 2025, parsing duplicate named capturing groups (https://redirect.github.com/eslint/eslint/issues/18596;>#18596) (Milos Djermanovic) Bug Fixes https://github.com/eslint/eslint/commit/1613e2e586423ec7871617aec4dce5c433f0e9f0;>1613e2e fix: Allow escaping characters in config patterns on Windows (https://redirect.github.com/eslint/eslint/issues/18628;>#18628) (Milos Djermanovic) https://github.com/eslint/eslint/commit/21d3766c3f4efd981d3cc294c2c82c8014815e6e;>21d3766 fix: no-unused-vars include caught errors pattern in report message (https://redirect.github.com/eslint/eslint/issues/18609;>#18609) (Kirk Waiblinger) https://github.com/eslint/eslint/commit/d7a7736937981befc5dfd68ce512f1a6ebf93e68;>d7a7736 fix: improve no-unused-vars message on unused caught errors (https://redirect.github.com/eslint/eslint/issues/18608;>#18608) (Kirk Waiblinger) https://github.com/eslint/eslint/commit/f9e95d2d06c0a7017417a3de4929b14d1008c63c;>f9e95d2 fix: correct locations of invalid /* eslint */ comments (https://redirect.github.com/eslint/eslint/issues/18593;>#18593) (Milos Djermanovic) Documentation https://github.com/eslint/eslint/commit/13dbecdea749abf51951ce61662eec2621a4b9af;>13dbecd docs: Limit search to just docs (https://redirect.github.com/eslint/eslint/issues/18627;>#18627) (Nicholas C. Zakas) https://github.com/eslint/eslint/commit/375227f94da3c1c4ff6c61a29b272889fa48ca79;>375227f docs: Update getting-started.md - add pnpm to init eslint config (https://redirect.github.com/eslint/eslint/issues/18599;>#18599) (Kostiantyn Ochenash)
[PR] TINKERPOP-3096: improvement: add necessary parameters for logging to fix '%!x(MISSING)' output issue in gremlin-go [tinkerpop]
thomas-dg opened a new pull request, #2684: URL: https://github.com/apache/tinkerpop/pull/2684 https://issues.apache.org/jira/browse/TINKERPOP-3096 I encountered a log message missing necessary parameters while using the 'Containing' function. The detailed log information is as follows: `2024/07/14 16:27:28 Error occurred during operation gremlinServerWSProtocol.readLoop(): 'E0703: expected string Key for map, got type='0x%!x(MISSING)'' 2024/07/14 16:27:28 Read loop error 'E0703: expected string Key for map, got type='0x%!x(MISSING)'', closing read loop. 2024/07/14 16:27:28 Connection error callback invoked, closing protocol. ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump System.Text.Json from 8.0.3 to 8.0.4 in /gremlin-dotnet [tinkerpop]
spmallette merged PR #2683: URL: https://github.com/apache/tinkerpop/pull/2683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump System.Text.Json from 8.0.3 to 8.0.4 in /gremlin-dotnet [tinkerpop]
dependabot[bot] opened a new pull request, #2683: URL: https://github.com/apache/tinkerpop/pull/2683 Bumps System.Text.Json from 8.0.3 to 8.0.4. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump xunit.runner.visualstudio from 2.8.1 to 2.8.2 in /gremlin-dotnet [tinkerpop]
dependabot[bot] opened a new pull request, #2682: URL: https://github.com/apache/tinkerpop/pull/2682 Bumps xunit.runner.visualstudio from 2.8.1 to 2.8.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump xunit from 2.8.1 to 2.9.0 in /gremlin-dotnet [tinkerpop]
dependabot[bot] opened a new pull request, #2681: URL: https://github.com/apache/tinkerpop/pull/2681 Bumps xunit from 2.8.1 to 2.9.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] enable bulking for HTTP requests [tinkerpop]
spmallette commented on PR #2679: URL: https://github.com/apache/tinkerpop/pull/2679#issuecomment-2217333093 is the bulking feature optional for the server? it feels like it should be an optimization that the server can choose to implement or not rather than something required since it is now being treated as a parameter. i also wonder if the driver should be required to get that setting right for it to work. it was different when there was bytecode. the user (and driver provider) had no control over these options, but this is different now under http. also, needs changelog entry -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] enable bulking for HTTP requests [tinkerpop]
spmallette commented on code in PR #2679:
URL: https://github.com/apache/tinkerpop/pull/2679#discussion_r1670263659
##
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/RequestOptions.java:
##
@@ -152,6 +157,11 @@ public Builder batchSize(final int batchSize) {
return this;
}
+public Builder withBulking(final boolean bulking) {
Review Comment:
nit: javadoc please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Update ProfilingApplication default options to align with HTTP. [tinkerpop]
kenhuuu opened a new pull request, #2680: URL: https://github.com/apache/tinkerpop/pull/2680 Some performance numbers to compare the current master-http branch against 3.7-dev using ProfilingApplication. ## Performance Metrics ### Test System **Server** EC2 m7a.8xlarge US EAST 2 **Server Config** ``` maxWorkQueueSize: 65536 threadPoolWorker: 8 gremlinPool: 16 evaluationTimeout: 3000 ``` **Driver** EC2 m7a.4xlarge US WEST 2 | Branch | Test Type | Arguments | Query | Result | | :---: | :---: | :---: | :---: | :---: | | 3.7-dev | Latency | minConnectionPoolSize 1 | `g.V()` *6 vertices* | 0.05625982837 sec | | 3.7-dev | Latency | minConnectionPoolSize 1 | `g.V().repeat(both()).times(15)` *2 824 992 vertices* | 3.844317 sec | | 3.7-dev | Latency | minConnectionPoolSize 1 | `g.V().repeat(both()).times(18)` *39 750 654 vertices* | 53.4815487 sec | | master-http | Latency | minConnectionPoolSize 1 | `g.V()` *6 vertices* | 0.05744388 sec | | master-http | Latency | minConnectionPoolSize 1 | `g.V().repeat(both()).times(15)` *2 824 992 vertices* | 3.915586 sec | | master-http | Latency | minConnectionPoolSize 1 | `g.V().repeat(both()).times(18)` *39 750 654 vertices* | 54.892998565 sec | | 3.7-dev | Throughput | parallelism 16 requests 1000 | `1 + 1` | 35458 req/sec | | 3.7-dev | Throughput | parallelism 16 requests 1000 exercise true | `N/A` | 30159 req/sec | | 3.7-dev | Throughput | parallelism 16 requests 1 exercise true | `N/A` | 30488 req/sec | | master-http | Throughput | parallelism 16 requests 1000 | `1 + 1` | 19758 req/sec | | master-http | Throughput | parallelism 16 requests 1000 exercise true | `N/A` | 19690 req/sec | | master-http | Throughput | parallelism 16 requests 1000 minConnectionPoolSize 1500 maxConnectionPoolSize 5000 | `1 + 1` | 34450 req/sec | | master-http | Throughput | parallelism 16 requests 1000 minConnectionPoolSize 1500 maxConnectionPoolSize 5000 exercise true | `N/A` | 32138 req/sec | | master-http | Throughput | parallelism 16 requests 1 maxConnectionPoolSize 5000 exercise true | `N/A` | 30063 req/sec | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] enable bulking for HTTP requests [tinkerpop]
vkagamlyk opened a new pull request, #2679: URL: https://github.com/apache/tinkerpop/pull/2679 in TP3 bulking works only for Bytecode requests, implemented same functionality for DriverRemoteConnection queries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] enable bulking for HTTP requests [tinkerpop]
vkagamlyk closed pull request #2677: enable bulking for HTTP requests URL: https://github.com/apache/tinkerpop/pull/2677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.fasterxml.jackson.core:jackson-annotations from 2.12.7 to 2.17.1 [tinkerpop]
dependabot[bot] closed pull request #2588: Bump com.fasterxml.jackson.core:jackson-annotations from 2.12.7 to 2.17.1 URL: https://github.com/apache/tinkerpop/pull/2588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.fasterxml.jackson.core:jackson-annotations from 2.12.7 to 2.17.2 [tinkerpop]
dependabot[bot] opened a new pull request, #2678: URL: https://github.com/apache/tinkerpop/pull/2678 Bumps [com.fasterxml.jackson.core:jackson-annotations](https://github.com/FasterXML/jackson) from 2.12.7 to 2.17.2. Commits See full diff in https://github.com/FasterXML/jackson/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.fasterxml.jackson.core:jackson-annotations from 2.12.7 to 2.17.1 [tinkerpop]
dependabot[bot] commented on PR #2588: URL: https://github.com/apache/tinkerpop/pull/2588#issuecomment-2214269570 Superseded by #2678. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] remove traverser serialization [tinkerpop]
vkagamlyk closed pull request #2676: remove traverser serialization URL: https://github.com/apache/tinkerpop/pull/2676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] remove traverser serialization [tinkerpop]
vkagamlyk commented on PR #2676: URL: https://github.com/apache/tinkerpop/pull/2676#issuecomment-2211439286 replaced with https://github.com/apache/tinkerpop/pull/2677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] enable bulking for HTTP requests [tinkerpop]
vkagamlyk opened a new pull request, #2677: URL: https://github.com/apache/tinkerpop/pull/2677 in TP3 bulking works only for Bytecode requests, implemented same functionality for `DriverRemoteConnection` queries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for HTTP content compression. [tinkerpop]
kenhuuu merged PR #2669: URL: https://github.com/apache/tinkerpop/pull/2669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for HTTP content compression. [tinkerpop]
kenhuuu commented on PR #2669: URL: https://github.com/apache/tinkerpop/pull/2669#issuecomment-2211340839 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for HTTP content compression. [tinkerpop]
vkagamlyk commented on PR #2669: URL: https://github.com/apache/tinkerpop/pull/2669#issuecomment-2211314496 VOTE+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] improvement: optimization of readmap function [tinkerpop]
kenhuuu merged PR #2673: URL: https://github.com/apache/tinkerpop/pull/2673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] improvement: optimization of readmap function [tinkerpop]
kenhuuu commented on PR #2673: URL: https://github.com/apache/tinkerpop/pull/2673#issuecomment-2211301014 VOTE +1. Please follow the instructions in the PR template next time for the CHANGELOG entry. I'll commit a follow-up change to make a minor adjustment so that this PR can be merged now. Thanks again for contributing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for HTTP content compression. [tinkerpop]
Cole-Greer commented on PR #2669: URL: https://github.com/apache/tinkerpop/pull/2669#issuecomment-2209673011 LGTM VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] remove traverser serialization [tinkerpop]
vkagamlyk opened a new pull request, #2676: URL: https://github.com/apache/tinkerpop/pull/2676 traverser serialization previously used only with Bytecode, so now it can be removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] improvement: optimization of readmap function [tinkerpop]
xiazcy commented on PR #2673: URL: https://github.com/apache/tinkerpop/pull/2673#issuecomment-2209597341 Thank you for the improvement and added test cases, LGTM. VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] improvement: optimization of readmap function [tinkerpop]
vkagamlyk commented on PR #2673: URL: https://github.com/apache/tinkerpop/pull/2673#issuecomment-2209580786 VOTE+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-3081 Fix traversal argument propagation under authentication [tinkerpop]
kenhuuu merged PR #2622: URL: https://github.com/apache/tinkerpop/pull/2622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-3081 Fix traversal argument propagation under authentication [tinkerpop]
lyndonbauto commented on PR #2622: URL: https://github.com/apache/tinkerpop/pull/2622#issuecomment-2209416216 @kenhuuu go ahead and merge it, sorry I am caught up in some stuff right now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump ws from 8.17.0 to 8.18.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript [tinkerpop]
dependabot[bot] opened a new pull request, #2675:
URL: https://github.com/apache/tinkerpop/pull/2675
Bumps [ws](https://github.com/websockets/ws) from 8.17.0 to 8.18.0.
Release notes
Sourced from https://github.com/websockets/ws/releases;>ws's
releases.
8.18.0
Features
Added support for Blob (https://redirect.github.com/websockets/ws/issues/2229;>#2229).
8.17.1
Bug fixes
Fixed a DoS vulnerability (https://redirect.github.com/websockets/ws/issues/2231;>#2231).
A request with a number of headers exceeding
the[server.maxHeadersCount][]
threshold could be used to crash a ws server.
const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars =
!#$%'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~.split('');
const headers = {};
let count = 0;
for (let i = 0; i chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j lt; chars.length; j++) {
const key = chars[i] + chars[j];
headers[key] = 'x';
if (++count === 2000) break;
}
}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});
The vulnerability was reported by https://github.com/rrlapointe;>Ryan LaPointe in https://redirect.github.com/websockets/ws/issues/2230;>websockets/ws#2230.
... (truncated)
Commits
https://github.com/websockets/ws/commit/976c53c4065c49ede73bfba824caf5a6e0f290cb;>976c53c
[dist] 8.18.0
https://github.com/websockets/ws/commit/59b9629b78aa66bcf9acce20468004cd3751c136;>59b9629
[feature] Add support for Blob (https://redirect.github.com/websockets/ws/issues/2229;>#2229)
https://github.com/websockets/ws/commit/0d1b5e6c4acad16a6b1a1904426eb266a5ba2f72;>0d1b5e6
[security] Use more descriptive text for 2017 vulnerability link
https://github.com/websockets/ws/commit/15f11a052a231d1f819fffef53bf4b287646d1ca;>15f11a0
[security] Add new DoS vulnerability to SECURITY.md
https://github.com/websockets/ws/commit/3c56601092872f7d7566989f0e379271afd0e4a1;>3c56601
[dist] 8.17.1
https://github.com/websockets/ws/commit/e55e5106f10fcbaac37cfa89759e4cc0d073a52c;>e55e510
[security] Fix crash when the Upgrade header cannot be read (https://redirect.github.com/websockets/ws/issues/2231;>#2231)
https://github.com/websockets/ws/commit/6a00029edd924499f892aed8003cef1fa724cfe5;>6a00029
[test] Increase code coverage
https://github.com/websockets/ws/commit/ddfe4a804d79e7788ab136290e609f91cf68423f;>ddfe4a8
[perf] Reduce the amount of crypto.randomFillSync() calls
See full diff in https://github.com/websockets/ws/compare/8.17.0...8.18.0;>compare
view
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that
have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI
passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and
block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it.
You can achieve the same result by closing it manually
- `@dependabot show ignore conditions` will show all of
the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen the PR
or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen the PR
or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the PR or
upgrade to it yourself)
--
This is an automated message from the Apache Git Service.
To respond to the message,
Re: [PR] improvement: optimization of readmap function [tinkerpop]
thomas-dg commented on PR #2673:
URL: https://github.com/apache/tinkerpop/pull/2673#issuecomment-2207886950
> Thanks for contributing.
>
> Your PR seems to be causing a failure with the feature test
infrastructure. Check the Github Actions logs for more information but I've
copied the stack trace here for you.
>
> ```
> panic: reflect: call of reflect.Value.Elem on string Value [recovered]
> panic: reflect: call of reflect.Value.Elem on string Value
>
> goroutine 6 [running]:
> testing.tRunner.func1.2({0xe68d60, 0xc0005b1860})
>/usr/local/go/src/testing/testing.go:1545 +0x3f7
> testing.tRunner.func1()
>/usr/local/go/src/testing/testing.go:1548 +0x716
> panic({0xe68d60?, 0xc0005b1860?})
>/usr/local/go/src/runtime/panic.go:920 +0x270
> reflect.Value.Elem({0xe4dec0?, 0xc000917c70?, 0x2?})
>/usr/local/go/src/reflect/value.go:1271 +0x45f
>
github.com/apache/tinkerpop/gremlin-go/v3/driver/cucumber.getEdges(0xc32053?)
>/go_app/driver/cucumber/cucumberWorld.go:180 +0xe99
>
github.com/apache/tinkerpop/gremlin-go/v3/driver/cucumber.(*CucumberWorld).loadAllDataGraph(0xc0002bf4a0)
>/go_app/driver/cucumber/cucumberWorld.go:115 +0x3c9
>
github.com/apache/tinkerpop/gremlin-go/v3/driver/cucumber.InitializeTestSuite.func1()
>/go_app/driver/cucumber/cucumberSteps_test.go:878 +0x45
> github.com/cucumber/godog.(*runner).concurrent(0xc000300a80, 0x1)
>/go/pkg/mod/github.com/cucumber/godog@v0.14.1/run.go:82 +0x602
> github.com/cucumber/godog.runWithOptions({_, _}, {0x0, 0x0, 0x0, {0x0,
0x0}, 0x0, {0x0, 0x0, ...}, ...}, ...)
>/go/pkg/mod/github.com/cucumber/godog@v0.14.1/run.go:284 +0x13ea
> github.com/cucumber/godog.TestSuite.Run({{0x0, 0x0}, 0xf40478, 0xf40460,
0xc0002ca0b0})
>/go/pkg/mod/github.com/cucumber/godog@v0.14.1/run.go:348 +0x2d4
>
github.com/apache/tinkerpop/gremlin-go/v3/driver/cucumber.TestCucumberFeatures(0xc00015e9c0)
>/go_app/driver/cucumber/cucumberSteps_test.go:951 +0x347
> testing.tRunner(0xc00015e9c0, 0xf40300)
>/usr/local/go/src/testing/testing.go:1595 +0x262
> created by testing.(*T).Run in goroutine 1
>/usr/local/go/src/testing/testing.go:1648 +0x846
> ```
>
> Also, you should add an entry to the CHANGELOG.asciidoc.
>
> I'm not that familiar with Go, but I'll have another committer that is
review this PR as well.
Thank you for your feedback and guidance.
I have addressed the issue and implemented the necessary fixes. Please feel
free to run the Github Actions again to verify these changes.
Additionally, I have updated the CHANGELOG.asciidoc file with the relevant
details pertaining to the changes made in this PR.
I appreciate your time and effort in reviewing this PR. I look forward to
any further suggestions or feedback from the other committer who will review
this.
Best Regards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update log lever from error to warn when server closes connection [tinkerpop]
kenhuuu commented on PR #2658: URL: https://github.com/apache/tinkerpop/pull/2658#issuecomment-2207433746 I feel as though the solution you are suggesting here may affect others if they are depending on that information to be at the ERROR level. It could be considered breaking for some users. For this reason, I feel like a more complete change would be to update the behavior of how the driver responds to a close frame. I've suggested a way of doing this in [TINKERPOP-3094](https://issues.apache.org/jira/browse/TINKERPOP-3094). Would you be OK with closing this PR and waiting or working on a fix like the one suggested in TINKERPOP-3094? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump mocha from 10.4.0 to 10.6.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript [tinkerpop]
dependabot[bot] opened a new pull request, #2674: URL: https://github.com/apache/tinkerpop/pull/2674 Bumps [mocha](https://github.com/mochajs/mocha) from 10.4.0 to 10.6.0. Release notes Sourced from https://github.com/mochajs/mocha/releases;>mocha's releases. v10.6.0 What's Changed feat: allow ^ versions for character encoding packages by https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg in https://redirect.github.com/mochajs/mocha/pull/5150;>mochajs/mocha#5150 feat: allow ^ versions for yargs packages by https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg in https://redirect.github.com/mochajs/mocha/pull/5152;>mochajs/mocha#5152 feat: allow ^ versions for file matching packages by https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg in https://redirect.github.com/mochajs/mocha/pull/5151;>mochajs/mocha#5151 feat: allow ^ versions for data serialization packages by https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg in https://redirect.github.com/mochajs/mocha/pull/5153;>mochajs/mocha#5153 feat: allow ^ versions for miscellaneous packages by https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg in https://redirect.github.com/mochajs/mocha/pull/5154;>mochajs/mocha#5154 Full Changelog: https://github.com/mochajs/mocha/compare/v10.5.2...v10.6.0;>https://github.com/mochajs/mocha/compare/v10.5.2...v10.6.0 v10.5.2 What's Changed fix: better tracking of seen objects in error serialization by https://github.com/sam-super;>@sam-super in https://redirect.github.com/mochajs/mocha/pull/5032;>mochajs/mocha#5032 New Contributors https://github.com/sam-super;>@sam-super made their first contribution in https://redirect.github.com/mochajs/mocha/pull/5032;>mochajs/mocha#5032 Full Changelog: https://github.com/mochajs/mocha/compare/v10.5.1...v10.5.2;>https://github.com/mochajs/mocha/compare/v10.5.1...v10.5.2 v10.5.1 What's Changed fix: Add error handling for nonexistent file case with --file option by https://github.com/khoaHyh;>@khoaHyh in https://redirect.github.com/mochajs/mocha/pull/5086;>mochajs/mocha#5086 New Contributors https://github.com/khoaHyh;>@khoaHyh made their first contribution in https://redirect.github.com/mochajs/mocha/pull/5086;>mochajs/mocha#5086 Full Changelog: https://github.com/mochajs/mocha/compare/v10.5.0...v10.5.1;>https://github.com/mochajs/mocha/compare/v10.5.0...v10.5.1 v10.5.0 :tada: Enhancements https://redirect.github.com/mochajs/mocha/pull/5015;>#5015 feat: use progress and svg for browser progress indicator instead of canvas (https://github.com/yourWaifu;>@yourWaifu) https://redirect.github.com/mochajs/mocha/pull/5143;>#5143 feat: allow using any 3.x chokidar dependencies (https://github.com/simhnna;>@simhnna) https://redirect.github.com/mochajs/mocha/pull/4835;>#4835 feat: add MOCHA_OPTIONS env variable (https://github.com/icholy;>@icholy) :bug: Fixes https://redirect.github.com/mochajs/mocha/pull/5107;>#5107 fix: include stack in browser uncaught error reporting (https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg) :nut_and_bolt: Other https://redirect.github.com/mochajs/mocha/pull/5110;>#5110 chore: switch two-column list styles to be opt-in (https://github.com/marjys;>@marjys) https://redirect.github.com/mochajs/mocha/pull/5135;>#5135 chore: fix some typos in comments (https://github.com/StevenMia;>@StevenMia) https://redirect.github.com/mochajs/mocha/pull/5130;>#5130 chore: rename 'master' to 'main' in docs and tooling (https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg) Changelog Sourced from https://github.com/mochajs/mocha/blob/main/CHANGELOG.md;>mocha's changelog. 10.6.0 / 2024-07-02 :tada: Enhancements https://redirect.github.com/mochajs/mocha/pull/5150;>#5150 feat: allow ^ versions for character encoding packages (https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg) https://redirect.github.com/mochajs/mocha/pull/5151;>#5151 feat: allow ^ versions for file matching packages (https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg) https://redirect.github.com/mochajs/mocha/pull/5152;>#5152 feat: allow ^ versions for yargs packages (https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg) https://redirect.github.com/mochajs/mocha/pull/5153;>#5153 feat: allow ^ versions for data serialization packages (https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg) https://redirect.github.com/mochajs/mocha/pull/5154;>#5154 feat: allow ^ versions for miscellaneous packages (https://github.com/JoshuaKGoldberg;>@JoshuaKGoldberg) 10.5.2 / 2024-06-25 :bug: Fixes https://redirect.github.com/mochajs/mocha/pull/5032;>#5032 fix: better tracking of seen objects in error serialization (https://github.com/sam-super;>@sam-super) 10.5.1 / 2024-06-24 :bug: Fixes
Re: [PR] TINKERPOP-3081 Fix traversal argument propagation under authentication [tinkerpop]
kenhuuu commented on PR #2622: URL: https://github.com/apache/tinkerpop/pull/2622#issuecomment-2204636803 Hi Lyndon, were you planning on merging this? If not, I can help you merge it this week. I'd prefer not to leave this PR hanging around since it might cause conflicts with other PRs (the CHANGELOG, in particular, usually causes conflicts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] improvement: optimization of readmap function [tinkerpop]
kenhuuu commented on PR #2673:
URL: https://github.com/apache/tinkerpop/pull/2673#issuecomment-2204551406
Thanks for contributing.
Your PR seems to be causing a failure with the feature test infrastructure.
Check the Github Actions logs for more information but I've copied the stack
trace here for you.
```
panic: reflect: call of reflect.Value.Elem on string Value [recovered]
panic: reflect: call of reflect.Value.Elem on string Value
goroutine 6 [running]:
testing.tRunner.func1.2({0xe68d60, 0xc0005b1860})
/usr/local/go/src/testing/testing.go:1545 +0x3f7
testing.tRunner.func1()
/usr/local/go/src/testing/testing.go:1548 +0x716
panic({0xe68d60?, 0xc0005b1860?})
/usr/local/go/src/runtime/panic.go:920 +0x270
reflect.Value.Elem({0xe4dec0?, 0xc000917c70?, 0x2?})
/usr/local/go/src/reflect/value.go:1271 +0x45f
github.com/apache/tinkerpop/gremlin-go/v3/driver/cucumber.getEdges(0xc32053?)
/go_app/driver/cucumber/cucumberWorld.go:180 +0xe99
github.com/apache/tinkerpop/gremlin-go/v3/driver/cucumber.(*CucumberWorld).loadAllDataGraph(0xc0002bf4a0)
/go_app/driver/cucumber/cucumberWorld.go:115 +0x3c9
github.com/apache/tinkerpop/gremlin-go/v3/driver/cucumber.InitializeTestSuite.func1()
/go_app/driver/cucumber/cucumberSteps_test.go:878 +0x45
github.com/cucumber/godog.(*runner).concurrent(0xc000300a80, 0x1)
/go/pkg/mod/github.com/cucumber/godog@v0.14.1/run.go:82 +0x602
github.com/cucumber/godog.runWithOptions({_, _}, {0x0, 0x0, 0x0, {0x0, 0x0},
0x0, {0x0, 0x0, ...}, ...}, ...)
/go/pkg/mod/github.com/cucumber/godog@v0.14.1/run.go:284 +0x13ea
github.com/cucumber/godog.TestSuite.Run({{0x0, 0x0}, 0xf40478, 0xf40460,
0xc0002ca0b0})
/go/pkg/mod/github.com/cucumber/godog@v0.14.1/run.go:348 +0x2d4
github.com/apache/tinkerpop/gremlin-go/v3/driver/cucumber.TestCucumberFeatures(0xc00015e9c0)
/go_app/driver/cucumber/cucumberSteps_test.go:951 +0x347
testing.tRunner(0xc00015e9c0, 0xf40300)
/usr/local/go/src/testing/testing.go:1595 +0x262
created by testing.(*T).Run in goroutine 1
/usr/local/go/src/testing/testing.go:1648 +0x846
```
Also, you should add an entry to the CHANGELOG.asciidoc.
I'm not that familiar with Go, but I'll have another committer that is take
a look at this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bytecode removal from server [tinkerpop]
vkagamlyk commented on PR #2661: URL: https://github.com/apache/tinkerpop/pull/2661#issuecomment-2204424242 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bytecode removal from server [tinkerpop]
vkagamlyk merged PR #2661: URL: https://github.com/apache/tinkerpop/pull/2661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bytecode removal from server [tinkerpop]
xiazcy commented on PR #2661: URL: https://github.com/apache/tinkerpop/pull/2661#issuecomment-2204393808 VOTE +1. Thanks for this great body of work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bytecode removal from server [tinkerpop]
Cole-Greer commented on PR #2661: URL: https://github.com/apache/tinkerpop/pull/2661#issuecomment-2204317187 Thanks Valentyn, this is a huge piece of work and a massive step towards simplifying TinkerPop. LGTM VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] improvement: optimization of readmap function [tinkerpop]
codecov-commenter commented on PR #2673: URL: https://github.com/apache/tinkerpop/pull/2673#issuecomment-2203888327 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2673?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 76.41%. Comparing base [(`9b46b67`)](https://app.codecov.io/gh/apache/tinkerpop/commit/9b46b6777d2fa250e41daacf2fa4554605aff53a?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`67073b7`)](https://app.codecov.io/gh/apache/tinkerpop/commit/67073b733181d4e60b93a0dc78d4150ea477d3f6?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 149 commits behind head on 3.7-dev. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.7-dev#2673 +/- ## = + Coverage 76.14% 76.41% +0.27% - Complexity 1315213185 +33 = Files 1084 1060 -24 Lines 6516061394-3766 Branches7285 7300 +15 = - Hits 4961646917-2699 + Misses 1283911966 -873 + Partials2705 2511 -194 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2673?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
