[GitHub] [tinkerpop] aboudreault commented on a change in pull request #1212: TINKERPOP-2309 Bump to Tornado 5.x
aboudreault commented on a change in pull request #1212: TINKERPOP-2309 Bump to Tornado 5.x URL: https://github.com/apache/tinkerpop/pull/1212#discussion_r342575569 ## File path: gremlin-python/src/main/jython/setup.py ## @@ -46,7 +46,7 @@ install_requires = [ 'aenum>=1.4.5', -'tornado>=4.4.1,<5.0', +'tornado>=5.1.1,<6.0', Review comment: Does gremlinpython works with tornado 5.0 ? If you know that gremlinpython works well with tornado 4.4.1 to <6.0, use `'tornado>=4.4.1,<6.0',`. That way, pip will pick the best match based on the environment. In example, if an environment already has tornado 4.4.1 installed (for some reasons or another package dependency), this version will be picked and pip wont break the env. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] aboudreault commented on a change in pull request #1212: TINKERPOP-2309 Bump to Tornado 5.x
aboudreault commented on a change in pull request #1212: TINKERPOP-2309 Bump to Tornado 5.x URL: https://github.com/apache/tinkerpop/pull/1212#discussion_r342575569 ## File path: gremlin-python/src/main/jython/setup.py ## @@ -46,7 +46,7 @@ install_requires = [ 'aenum>=1.4.5', -'tornado>=4.4.1,<5.0', +'tornado>=5.1.1,<6.0', Review comment: Does gremlinpython work with tornado 5.0 ? If you know that gremlinpython works well with tornado 4.4.1 to <6.0, use `'tornado>=4.4.1,<6.0',`. That way, pip will pick the best match based on the environment. In example, if an environment already has tornado 4.4.1 installed (for some reasons or another package dependency), this version will be picked and pip wont break the env. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
