[GitHub] [tinkerpop] jorgebay commented on issue #1202: TINKERPOP-2290 Add a way to catch a connection error
jorgebay commented on issue #1202: TINKERPOP-2290 Add a way to catch a connection error URL: https://github.com/apache/tinkerpop/pull/1202#issuecomment-539951480 Landed in 78819c3 and updated changelog in 970441ad02af7cdb999524a29d496b86a52867df. Thanks @gion !! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] jorgebay commented on issue #1202: TINKERPOP-2290 Add a way to catch a connection error
jorgebay commented on issue #1202: TINKERPOP-2290 Add a way to catch a connection error URL: https://github.com/apache/tinkerpop/pull/1202#issuecomment-537945826 @gion Sorry I didn't reply to you before, I agree that is useful to expose the `Connection` events. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] jorgebay commented on issue #1202: TINKERPOP-2290 Add a way to catch a connection error
jorgebay commented on issue #1202: TINKERPOP-2290 Add a way to catch a connection error URL: https://github.com/apache/tinkerpop/pull/1202#issuecomment-536563171 Thanks @gion for looking into this! It's a good idea to expose a way to subscribe to connection events. In the case of errors, I think it would be best to avoid [emitting `'error'` events](https://github.com/apache/tinkerpop/blob/3.4.3/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js#L216) and instead use `'socketError'`, that way we don't default to an uncaught error when the user is not listening to the `'error'` event, wdyt? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
