[GitHub] jorgebay commented on issue #1056: fix: Path#toString() variable reference bug

2019-02-07 Thread GitBox
jorgebay commented on issue #1056: fix: Path#toString() variable reference bug
URL: https://github.com/apache/tinkerpop/pull/1056#issuecomment-461330180
 
 
   `toString()` was introduced as part of TK-1446, it didn't have a string 
representation on the js side prior to that.
   
   @thefliik sorry for the confusion, nvm.
   
   Fixing it on `master` makes sense, VOTE +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jorgebay commented on issue #1056: fix: Path#toString() variable reference bug

2019-02-06 Thread GitBox
jorgebay commented on issue #1056: fix: Path#toString() variable reference bug
URL: https://github.com/apache/tinkerpop/pull/1056#issuecomment-460958353
 
 
   Thanks @thefliik , I've filed a ticket to keep track of this: 
https://issues.apache.org/jira/browse/TINKERPOP-2152
   
   Can you target branch `tp33` for this to be applied to the 3.3 line?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services