spmallette commented on a change in pull request #1065: TINKERPOP-2161 - GraphBinary: use a single buffer instead of allocators URL: https://github.com/apache/tinkerpop/pull/1065#discussion_r259342375
########## File path: CHANGELOG.asciidoc ########## @@ -35,6 +35,10 @@ This release also includes changes from <<release-3-3-6, 3.3.6>>. * Added easier to understand exceptions for connection problems in the Gremlin.Net driver. * Support configuring the type registry builder for GraphBinary. * Release working buffers in case of failure for GraphBinary. +* GraphBinary: Use the same `ByteBuf` instance to write during serialization. Changed signature of write methods in type +serializers. Review comment: nit: no need to multi-line the changelog. it can just run on as needed on a single line. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
