Re: [PR] Bytecode removal from Java GLV [tinkerpop]
vkagamlyk commented on PR #2648: URL: https://github.com/apache/tinkerpop/pull/2648#issuecomment-2166598483 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bytecode removal from Java GLV [tinkerpop]
vkagamlyk merged PR #2648: URL: https://github.com/apache/tinkerpop/pull/2648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bytecode removal from Java GLV [tinkerpop]
Cole-Greer commented on PR #2648: URL: https://github.com/apache/tinkerpop/pull/2648#issuecomment-2166654918 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bytecode removal from Java GLV [tinkerpop]
vkagamlyk commented on code in PR #2648:
URL: https://github.com/apache/tinkerpop/pull/2648#discussion_r1638800470
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/BytecodeHelper.java:
##
@@ -177,7 +175,7 @@
import java.util.stream.Stream;
/**
- * Utility class for parsing {@link Bytecode}.
+ * Utility class for parsing {@link GremlinLang}.
*
Review Comment:
it should be removed later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bytecode removal from Java GLV [tinkerpop]
Cole-Greer commented on code in PR #2648:
URL: https://github.com/apache/tinkerpop/pull/2648#discussion_r1638798422
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/BytecodeHelper.java:
##
@@ -177,7 +175,7 @@
import java.util.stream.Stream;
/**
- * Utility class for parsing {@link Bytecode}.
+ * Utility class for parsing {@link GremlinLang}.
*
Review Comment:
Should this class be renamed to GremlinLangHelper?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bytecode removal from Java GLV [tinkerpop]
kenhuuu commented on PR #2648: URL: https://github.com/apache/tinkerpop/pull/2648#issuecomment-2166620519 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bytecode removal from Java GLV [tinkerpop]
xiazcy commented on PR #2648: URL: https://github.com/apache/tinkerpop/pull/2648#issuecomment-2166464087 VOTE +1 Thanks for putting together the work! Looking forward to the rest of the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bytecode removal from Java GLV [tinkerpop]
vkagamlyk commented on code in PR #2648:
URL: https://github.com/apache/tinkerpop/pull/2648#discussion_r1635554947
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/GremlinLangScriptEngine.java:
##
@@ -79,7 +79,7 @@ public GremlinScriptEngineFactory getFactory() {
* Bytecode is evaluated by the {@link JavaTranslator}.
*/
@Override
-public Traversal.Admin eval(final Bytecode bytecode, final Bindings
bindings, final String traversalSource) throws ScriptException {
+public Traversal.Admin eval(final GremlinLang bytecode, final Bindings
bindings, final String traversalSource) throws ScriptException {
Review Comment:
I hope to remove this altogether in one of the next PRs,
'GremlinScriptEngineFactory' will handle only gremlin scripts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bytecode removal from Java GLV [tinkerpop]
xiazcy commented on code in PR #2648:
URL: https://github.com/apache/tinkerpop/pull/2648#discussion_r1635171704
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/GremlinLangScriptEngine.java:
##
@@ -79,7 +79,7 @@ public GremlinScriptEngineFactory getFactory() {
* Bytecode is evaluated by the {@link JavaTranslator}.
*/
@Override
-public Traversal.Admin eval(final Bytecode bytecode, final Bindings
bindings, final String traversalSource) throws ScriptException {
+public Traversal.Admin eval(final GremlinLang bytecode, final Bindings
bindings, final String traversalSource) throws ScriptException {
Review Comment:
nit: rename variable as well to avoid confusion. I see this throughout all
files, so prob need a search and update all references at some point.
```suggestion
public Traversal.Admin eval(final GremlinLang gremlinLang, final
Bindings bindings, final String traversalSource) throws ScriptException {
```
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/BytecodeHelper.java:
##
@@ -177,7 +175,7 @@
import java.util.stream.Stream;
/**
- * Utility class for parsing {@link Bytecode}.
+ * Utility class for parsing {@link GremlinLang}.
Review Comment:
nit: don't forget classname update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
