Re: [PR] Release msg in finally block on HttpGremlinEndpointHandler [tinkerpop]

2024-06-11 Thread via GitHub


rdtr closed pull request #1727: Release msg in finally block on 
HttpGremlinEndpointHandler
URL: https://github.com/apache/tinkerpop/pull/1727


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Release msg in finally block on HttpGremlinEndpointHandler [tinkerpop]

2024-06-03 Thread via GitHub


kenhuuu commented on PR #1727:
URL: https://github.com/apache/tinkerpop/pull/1727#issuecomment-2146126016

   Hi @rdtr , were you planning on addressing the review comment from above 
about adding a unit test? Some of the changes you are requesting will be 
updated in master with the move to HTTP-only, but those changes won't exist in 
3.6.x/3.7.x. Is this change something you would like to see go into 3.6.x/3.7.x 
still?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org