Re: [PR] Temporary fix to failing JDK8 test [tinkerpop]
Cole-Greer merged PR #2529: URL: https://github.com/apache/tinkerpop/pull/2529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Temporary fix to failing JDK8 test [tinkerpop]
Cole-Greer commented on PR #2529: URL: https://github.com/apache/tinkerpop/pull/2529#issuecomment-2018786545 Thanks Ryan! LGTM VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Temporary fix to failing JDK8 test [tinkerpop]
codecov-commenter commented on PR #2529: URL: https://github.com/apache/tinkerpop/pull/2529#issuecomment-2018704719 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2529?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 75.42%. Comparing base [(`d9e34fb`)](https://app.codecov.io/gh/apache/tinkerpop/commit/d9e34fb4678c29ffa167066de45a9fa7329a319a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c373368`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2529?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 29 commits behind head on 3.6-dev. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.6-dev#2529 +/- ## = + Coverage 75.14% 75.42% +0.28% - Complexity 1234612372 +26 = Files 1058 1033 -25 Lines 6361059900-3710 Branches6962 6974 +12 = - Hits 4780145182-2619 + Misses 1322512325 -900 + Partials2584 2393 -191 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2529?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Temporary fix to failing JDK8 test [tinkerpop]
ryn5 opened a new pull request, #2529: URL: https://github.com/apache/tinkerpop/pull/2529 A new SelectStep test is failing in JDK8 tests due to a difference in hashing between Java 8 and 11. In Java 8, the hash used to identify the traverser to be removed from the no-op barrier is recomputed at removal, and can't find a match due to other traversal branches having added vertices to the bulkset, thus changing its potential hash value. Java 11 simply uses the hash field stored at creation instead of recomputing it which avoids this problem. This additional barrier step is a temporary fix that helps the query wait until all the vertices have been added to the bulkset before adding traversals to the no-op barrier so that hashing stays consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
