Re: [PR] Remove gremlin-archetypes [tinkerpop]
Cole-Greer commented on PR #2486: URL: https://github.com/apache/tinkerpop/pull/2486#issuecomment-1942123299 There's one reference to the archetypes in the reference docs that I see. I think we can simply delete it as it is followed by a section on the new examples. https://github.com/apache/tinkerpop/blob/master/docs/src/reference/gremlin-variants.asciidoc#gremlin-archetypes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove gremlin-archetypes [tinkerpop]
spmallette commented on PR #2486: URL: https://github.com/apache/tinkerpop/pull/2486#issuecomment-1941937424 maybe better targetted at `master` as opposed to `3.7-dev` given semver? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove gremlin-archetypes [tinkerpop]
codecov-commenter commented on PR #2486: URL: https://github.com/apache/tinkerpop/pull/2486#issuecomment-1940237659 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2486?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`d804e4a`)](https://app.codecov.io/gh/apache/tinkerpop/commit/d804e4a3b9d7d12c679e218abc24091453031467?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 76.14% compared to head [(`0c6f39d`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2486?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 71.05%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.7-dev#2486 +/- ## = - Coverage 76.14% 71.05% -5.09% = Files 1084 25-1059 Lines 65160 3942 -61218 Branches72850-7285 = - Hits 49613 2801 -46812 + Misses 12842 950 -11892 + Partials2705 191-2514 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2486?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
