[jira] [Commented] (TOMEE-1619) Add exception message to Alerts

2015-08-01 Thread Alex (JIRA)

[ 
https://issues.apache.org/jira/browse/TOMEE-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650497#comment-14650497
 ] 

Alex commented on TOMEE-1619:
-

Thanks for the update. I will check.

> Add exception message to Alerts
> ---
>
> Key: TOMEE-1619
> URL: https://issues.apache.org/jira/browse/TOMEE-1619
> Project: TomEE
>  Issue Type: Improvement
>  Components: TomEE Core Server
>Affects Versions: 7.0.0
>Reporter: Alex
>Priority: Trivial
>  Labels: newbie
> Fix For: 7.0.0
>
>
> The method org.apache.tomee.installer.Alerts.addError(String, Exception) only 
> logs the passed message, but not the exception message.
> This is tricky, because you don't know which exception in the chain actually 
> carries a useful message. I think just Exception.getMessage() is the best we 
> can do?
> Also I noticed this is only performing an stdout. Should we also write to the 
> container log?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


buildbot success in ASF Buildbot on tomee-trunk-ubuntu

2015-08-01 Thread buildbot
The Buildbot has detected a restored build on builder tomee-trunk-ubuntu while 
building tomee. Full details are available at:
http://ci.apache.org/builders/tomee-trunk-ubuntu/builds/12

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The SingleBranchScheduler scheduler named 
'on-tomee-trunk-ubuntu-commit' triggered this build
Build Source Stamp: [branch master] e362fde9bd4796ee9a27a21444df301f29efcdff
Blamelist: Romain Manni-Bucau 

Build succeeded!

Sincerely,
 -The Buildbot





tomee git commit: fixing datasource config for one arquillian test

2015-08-01 Thread rmannibucau
Repository: tomee
Updated Branches:
  refs/heads/master b42d60d3a -> e362fde9b


fixing datasource config for one arquillian test


Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/e362fde9
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/e362fde9
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/e362fde9

Branch: refs/heads/master
Commit: e362fde9bd4796ee9a27a21444df301f29efcdff
Parents: b42d60d
Author: Romain Manni-Bucau 
Authored: Sat Aug 1 14:39:20 2015 +0200
Committer: Romain Manni-Bucau 
Committed: Sat Aug 1 14:39:20 2015 +0200

--
 .../openejb/arquillian/tests/contextxml/datasource/context.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/tomee/blob/e362fde9/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/resources/org/apache/openejb/arquillian/tests/contextxml/datasource/context.xml
--
diff --git 
a/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/resources/org/apache/openejb/arquillian/tests/contextxml/datasource/context.xml
 
b/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/resources/org/apache/openejb/arquillian/tests/contextxml/datasource/context.xml
index 8559a72..748e6c8 100644
--- 
a/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/resources/org/apache/openejb/arquillian/tests/contextxml/datasource/context.xml
+++ 
b/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/resources/org/apache/openejb/arquillian/tests/contextxml/datasource/context.xml
@@ -21,6 +21,6 @@
 type="javax.sql.DataSource" username="sa" password=""
 driverClassName="org.hsqldb.jdbcDriver"
 url="jdbc:hsqldb:mem:foo:myDB"
-maxActive="8"
+maxActive="8" initialSize="3" minIdle="1" maxIdle="8"
   />
 



[jira] [Commented] (TOMEE-1619) Add exception message to Alerts

2015-08-01 Thread Romain Manni-Bucau (JIRA)

[ 
https://issues.apache.org/jira/browse/TOMEE-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650197#comment-14650197
 ] 

Romain Manni-Bucau commented on TOMEE-1619:
---

There are several cases of alerts but the most common is the webapp one so if 
it is not shown in the gui then the info is almost useless.

Side note: there is a thread speaking of removing drop in war so this would 
almost be useless to keep this class. Note sure the status anymore but surely 
something to check before working on it.

About container log: when running it no guarantee you have it - even a 
container - so stdout is an acceptable default.

> Add exception message to Alerts
> ---
>
> Key: TOMEE-1619
> URL: https://issues.apache.org/jira/browse/TOMEE-1619
> Project: TomEE
>  Issue Type: Improvement
>  Components: TomEE Core Server
>Affects Versions: 7.0.0
>Reporter: Alex
>Priority: Trivial
>  Labels: newbie
> Fix For: 7.0.0
>
>
> The method org.apache.tomee.installer.Alerts.addError(String, Exception) only 
> logs the passed message, but not the exception message.
> This is tricky, because you don't know which exception in the chain actually 
> carries a useful message. I think just Exception.getMessage() is the best we 
> can do?
> Also I noticed this is only performing an stdout. Should we also write to the 
> container log?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)