[jira] [Updated] (TOMEE-2143) AbstractOwbBean.destroy(..) hits NPE in MyFaces 2.2.12 when cleaning up a user's Session and related "ViewScopeBeanHolder"

2017-10-28 Thread Martin Wiesner (JIRA)

 [ 
https://issues.apache.org/jira/browse/TOMEE-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Wiesner updated TOMEE-2143:
--
Environment: 
TomEE 7.0.4 (plus)
MyFaces 2.2.12, Omnifaces 2.6.5
Shiro 1.3.2
Java 1.8.0-U151 (Oracle)
MacOS 10.13

  was:
TomEE 7.0.4 (plus)
MyFaces 2.2.12, Shiro 1.3.2
Java 1.8.0-U151 (Oracle)
MacOS 10.13


> AbstractOwbBean.destroy(..) hits NPE in MyFaces 2.2.12 when cleaning up a 
> user's Session and related  "ViewScopeBeanHolder"
> ---
>
> Key: TOMEE-2143
> URL: https://issues.apache.org/jira/browse/TOMEE-2143
> Project: TomEE
>  Issue Type: Bug
>  Components: TomEE Core Server
>Affects Versions: 7.0.3, 7.0.4
> Environment: TomEE 7.0.4 (plus)
> MyFaces 2.2.12, Omnifaces 2.6.5
> Shiro 1.3.2
> Java 1.8.0-U151 (Oracle)
> MacOS 10.13
>Reporter: Martin Wiesner
>
> In an *EAR*-bundled application with several EJB jars and two WAR files, when 
> I logout from my JSF-application via this piece of code here:
> {code:java}
> public void logout() throws IOException {
> SecurityUtils.getSubject().logout();
> Faces.invalidateSession();
> Faces.redirect("login.xhtml");
> }
> {code}
> The moment the user session is invalidated, the redirect to the login screen 
> is triggered sucessfully. However, I encounter the following stack trace 
> within my standalone installation of TomEE plus (taken from catalina.out):
> {code:java}
> [http-nio-8080-exec-8] org.apache.webbeans.component.AbstractOwbBean.destroy 
> Exception thrown while destroying bean instance : [ViewScopeBeanHolder, 
> WebBeansType:MANAGED, Name:null, API 
> Types:[org.apache.myfaces.cdi.view.ViewScopeBeanHolder,java.lang.Object,java.io.Serializable],
>  Qualifiers:[javax.enterprise.inject.Default,javax.enterprise.inject.Any]]
>  java.lang.NullPointerException
>   at 
> org.apache.myfaces.cdi.view.ViewScopeContextImpl.destroyAllActive(ViewScopeContextImpl.java:229)
>   at 
> org.apache.myfaces.cdi.view.ViewScopeContextImpl.destroyAllActive(ViewScopeContextImpl.java:223)
>   at 
> org.apache.myfaces.cdi.view.ViewScopeBeanHolder.destroyBeansOnPreDestroy(ViewScopeBeanHolder.java:221)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.apache.webbeans.intercept.LifecycleInterceptorInvocationContext.proceed(LifecycleInterceptorInvocationContext.java:103)
>   at 
> org.apache.webbeans.portable.InjectionTargetImpl.preDestroy(InjectionTargetImpl.java:352)
>   at 
> org.apache.webbeans.component.AbstractOwbBean.destroy(AbstractOwbBean.java:179)
>   at 
> org.apache.webbeans.context.AbstractContext.destroyInstance(AbstractContext.java:206)
>   at 
> org.apache.webbeans.context.AbstractContext.destroyInstance(AbstractContext.java:192)
>   at 
> org.apache.webbeans.context.AbstractContext.destroy(AbstractContext.java:218)
>   at 
> org.apache.webbeans.web.context.WebContextsService.destroyRequestContext(WebContextsService.java:408)
>   at 
> org.apache.openejb.cdi.CdiAppContextsService.destroyRequestContext(CdiAppContextsService.java:113)
>   at 
> org.apache.webbeans.web.context.WebContextsService.endContext(WebContextsService.java:223)
>   at 
> org.apache.openejb.server.httpd.BeginWebBeansListener.requestDestroyed(BeginWebBeansListener.java:99)
>   at 
> org.apache.catalina.core.StandardContext.fireRequestDestroyEvent(StandardContext.java:5974)
>   at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:182)
>   at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
>   at 
> org.apache.tomee.catalina.OpenEJBSecurityListener$RequestCapturer.invoke(OpenEJBSecurityListener.java:97)
>   at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:650)
>   at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
>   at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
>   at 
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
>   at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
>   at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
>   at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1457)
>   at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
>  

tomee git commit: pmd

2017-10-28 Thread tveronezi
Repository: tomee
Updated Branches:
  refs/heads/master 73d788ac3 -> 12e45af58


pmd


Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/12e45af5
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/12e45af5
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/12e45af5

Branch: refs/heads/master
Commit: 12e45af586d8138c6ca73bb3711a90f763cb16ae
Parents: 73d788a
Author: Thiago Veronezi 
Authored: Sat Oct 28 06:01:42 2017 -0400
Committer: Thiago Veronezi 
Committed: Sat Oct 28 06:01:42 2017 -0400

--
 .../org/apache/openejb/monitoring/StatsInterceptor.java | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/tomee/blob/12e45af5/container/openejb-core/src/main/java/org/apache/openejb/monitoring/StatsInterceptor.java
--
diff --git 
a/container/openejb-core/src/main/java/org/apache/openejb/monitoring/StatsInterceptor.java
 
b/container/openejb-core/src/main/java/org/apache/openejb/monitoring/StatsInterceptor.java
index cb5a890..5e93544 100644
--- 
a/container/openejb-core/src/main/java/org/apache/openejb/monitoring/StatsInterceptor.java
+++ 
b/container/openejb-core/src/main/java/org/apache/openejb/monitoring/StatsInterceptor.java
@@ -108,11 +108,11 @@ public class StatsInterceptor {
 
 @PostConstruct
 public void PostConstruct(final InvocationContext invocationContext) 
throws Exception {
-long start = System.nanoTime();
+final long start = System.nanoTime();
 record(invocationContext, PostConstruct());
-long end = System.nanoTime();
+final long end = System.nanoTime();
 Logger.getInstance(LogCategory.MONITORING, 
"org.apache.openejb.monitoring")
-.info("instance.created", 
invocationContext.getTarget().getClass().getName(), end - start);
+.debug("instance.created", 
invocationContext.getTarget().getClass().getName(), end - start);
 }
 
 public Method PreDestroy() throws NoSuchMethodException {
@@ -121,11 +121,11 @@ public class StatsInterceptor {
 
 @PreDestroy
 public void PreDestroy(final InvocationContext invocationContext) throws 
Exception {
-long start = System.nanoTime();
+final long start = System.nanoTime();
 record(invocationContext, PreDestroy());
-long end = System.nanoTime();
+final long end = System.nanoTime();
 Logger.getInstance(LogCategory.MONITORING, 
"org.apache.openejb.monitoring")
-.info("instance.discarded", 
invocationContext.getTarget().getClass().getName(), end - start);
+.debug("instance.discarded", 
invocationContext.getTarget().getClass().getName(), end - start);
 }
 
 public Method PostActivate() throws NoSuchMethodException {



tomee git commit: pmd

2017-10-28 Thread tveronezi
Repository: tomee
Updated Branches:
  refs/heads/tomee-1.7.x 81f49ec65 -> 4736446a3


pmd


Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/4736446a
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/4736446a
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/4736446a

Branch: refs/heads/tomee-1.7.x
Commit: 4736446a3c6130ae1c20862d3de91ced107bb404
Parents: 81f49ec
Author: Thiago Veronezi 
Authored: Sat Oct 28 06:01:04 2017 -0400
Committer: Thiago Veronezi 
Committed: Sat Oct 28 06:01:04 2017 -0400

--
 .../apache/openejb/monitoring/StatsInterceptor.java   | 14 ++
 1 file changed, 6 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/tomee/blob/4736446a/container/openejb-core/src/main/java/org/apache/openejb/monitoring/StatsInterceptor.java
--
diff --git 
a/container/openejb-core/src/main/java/org/apache/openejb/monitoring/StatsInterceptor.java
 
b/container/openejb-core/src/main/java/org/apache/openejb/monitoring/StatsInterceptor.java
index 7fe34ea..0fe90e7 100644
--- 
a/container/openejb-core/src/main/java/org/apache/openejb/monitoring/StatsInterceptor.java
+++ 
b/container/openejb-core/src/main/java/org/apache/openejb/monitoring/StatsInterceptor.java
@@ -108,11 +108,10 @@ public class StatsInterceptor {
 
 @PostConstruct
 public void PostConstruct(final InvocationContext invocationContext) 
throws Exception {
-long start = System.nanoTime();
+final long start = System.nanoTime();
 record(invocationContext, PostConstruct());
-long end = System.nanoTime();
-org.apache.openejb.util.Logger
-.getInstance(LogCategory.MONITORING, 
"org.apache.openejb.monitoring")
+final long end = System.nanoTime();
+Logger.getInstance(LogCategory.MONITORING, 
"org.apache.openejb.monitoring")
 .debug("instance.created", 
invocationContext.getTarget().getClass().getName(), end - start);
 }
 
@@ -122,11 +121,10 @@ public class StatsInterceptor {
 
 @PreDestroy
 public void PreDestroy(final InvocationContext invocationContext) throws 
Exception {
-long start = System.nanoTime();
+final long start = System.nanoTime();
 record(invocationContext, PreDestroy());
-long end = System.nanoTime();
-org.apache.openejb.util.Logger
-.getInstance(LogCategory.MONITORING, 
"org.apache.openejb.monitoring")
+final long end = System.nanoTime();
+Logger.getInstance(LogCategory.MONITORING, 
"org.apache.openejb.monitoring")
 .debug("instance.discarded", 
invocationContext.getTarget().getClass().getName(), end - start);
 }
 



[jira] [Updated] (TOMEE-2143) AbstractOwbBean.destroy(..) hits NPE in MyFaces 2.2.12 when cleaning up a user's Session and related "ViewScopeBeanHolder"

2017-10-28 Thread Martin Wiesner (JIRA)

 [ 
https://issues.apache.org/jira/browse/TOMEE-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Wiesner updated TOMEE-2143:
--
Environment: 
TomEE 7.0.4 (plus)
MyFaces 2.2.12, Shiro 1.3.2
Java 1.8.0-U151 (Oracle)
MacOS 10.13

  was:
TomEE 7.0.4 (plus)
MyFaces 2.2.12, Shiro 1.3.2
MacOS 10.13


> AbstractOwbBean.destroy(..) hits NPE in MyFaces 2.2.12 when cleaning up a 
> user's Session and related  "ViewScopeBeanHolder"
> ---
>
> Key: TOMEE-2143
> URL: https://issues.apache.org/jira/browse/TOMEE-2143
> Project: TomEE
>  Issue Type: Bug
>  Components: TomEE Core Server
>Affects Versions: 7.0.3, 7.0.4
> Environment: TomEE 7.0.4 (plus)
> MyFaces 2.2.12, Shiro 1.3.2
> Java 1.8.0-U151 (Oracle)
> MacOS 10.13
>Reporter: Martin Wiesner
>
> In an *EAR*-bundled application with several EJB jars and two WAR files, when 
> I logout from my JSF-application via this piece of code here:
> {code:java}
> public void logout() throws IOException {
> SecurityUtils.getSubject().logout();
> Faces.invalidateSession();
> Faces.redirect("login.xhtml");
> }
> {code}
> The moment the user session is invalidated, the redirect to the login screen 
> is triggered sucessfully. However, I encounter the following stack trace 
> within my standalone installation of TomEE plus (taken from catalina.out):
> {code:java}
> [http-nio-8080-exec-8] org.apache.webbeans.component.AbstractOwbBean.destroy 
> Exception thrown while destroying bean instance : [ViewScopeBeanHolder, 
> WebBeansType:MANAGED, Name:null, API 
> Types:[org.apache.myfaces.cdi.view.ViewScopeBeanHolder,java.lang.Object,java.io.Serializable],
>  Qualifiers:[javax.enterprise.inject.Default,javax.enterprise.inject.Any]]
>  java.lang.NullPointerException
>   at 
> org.apache.myfaces.cdi.view.ViewScopeContextImpl.destroyAllActive(ViewScopeContextImpl.java:229)
>   at 
> org.apache.myfaces.cdi.view.ViewScopeContextImpl.destroyAllActive(ViewScopeContextImpl.java:223)
>   at 
> org.apache.myfaces.cdi.view.ViewScopeBeanHolder.destroyBeansOnPreDestroy(ViewScopeBeanHolder.java:221)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.apache.webbeans.intercept.LifecycleInterceptorInvocationContext.proceed(LifecycleInterceptorInvocationContext.java:103)
>   at 
> org.apache.webbeans.portable.InjectionTargetImpl.preDestroy(InjectionTargetImpl.java:352)
>   at 
> org.apache.webbeans.component.AbstractOwbBean.destroy(AbstractOwbBean.java:179)
>   at 
> org.apache.webbeans.context.AbstractContext.destroyInstance(AbstractContext.java:206)
>   at 
> org.apache.webbeans.context.AbstractContext.destroyInstance(AbstractContext.java:192)
>   at 
> org.apache.webbeans.context.AbstractContext.destroy(AbstractContext.java:218)
>   at 
> org.apache.webbeans.web.context.WebContextsService.destroyRequestContext(WebContextsService.java:408)
>   at 
> org.apache.openejb.cdi.CdiAppContextsService.destroyRequestContext(CdiAppContextsService.java:113)
>   at 
> org.apache.webbeans.web.context.WebContextsService.endContext(WebContextsService.java:223)
>   at 
> org.apache.openejb.server.httpd.BeginWebBeansListener.requestDestroyed(BeginWebBeansListener.java:99)
>   at 
> org.apache.catalina.core.StandardContext.fireRequestDestroyEvent(StandardContext.java:5974)
>   at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:182)
>   at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
>   at 
> org.apache.tomee.catalina.OpenEJBSecurityListener$RequestCapturer.invoke(OpenEJBSecurityListener.java:97)
>   at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:650)
>   at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
>   at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
>   at 
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
>   at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
>   at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
>   at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1457)
>   at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(Th

[jira] [Created] (TOMEE-2144) Update TomEE 7.0.x to build upon Tomcat 8.5.23

2017-10-28 Thread Martin Wiesner (JIRA)
Martin Wiesner created TOMEE-2144:
-

 Summary: Update TomEE 7.0.x to build upon Tomcat 8.5.23
 Key: TOMEE-2144
 URL: https://issues.apache.org/jira/browse/TOMEE-2144
 Project: TomEE
  Issue Type: Task
Affects Versions: 7.0.4
Reporter: Martin Wiesner
Priority: Minor


With several security related fixes in Tomcat version 8.5.21, several 
connection pooling issues in 8.5.21/22 and a fix related to logging in a Java 9 
environment, TomEE should reflect these fixes and improvements in the next 
maintenance release 7.0.5.

For reference, see changelog here:
https://tomcat.apache.org/tomcat-8.5-doc/changelog.html#Tomcat_8.5.23_(markt)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)