[tomee] 01/02: closes apache/tomee#397 *Merged*

2019-02-15 Thread radcortez
This is an automated email from the ASF dual-hosted git repository.

radcortez pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomee.git

commit ea02bad6821caa8f0a516d267f58e9cdd83912fc
Author: Roberto Cortez 
AuthorDate: Fri Feb 15 12:49:14 2019 +

closes apache/tomee#397 *Merged*



[tomee] 02/02: closes apache/tomee#396 *Already Merged*

2019-02-15 Thread radcortez
This is an automated email from the ASF dual-hosted git repository.

radcortez pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomee.git

commit ccbd6dc5c9dee7ffa76a0fa932fca5677bd1e8d6
Author: Roberto Cortez 
AuthorDate: Fri Feb 15 12:49:31 2019 +

closes apache/tomee#396 *Already Merged*



[tomee] branch master updated (bb77a7b -> ccbd6dc)

2019-02-15 Thread radcortez
This is an automated email from the ASF dual-hosted git repository.

radcortez pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tomee.git.


from bb77a7b  Fixed test.
 new ea02bad  closes apache/tomee#397 *Merged*
 new ccbd6dc  closes apache/tomee#396 *Already Merged*

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:



[tomee] 03/08: A fix revert got missed, readding

2019-02-15 Thread radcortez
This is an automated email from the ASF dual-hosted git repository.

radcortez pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomee.git

commit 8b843c639b2b78df3a21223865bb357fc02fb3a7
Author: James Meen 
AuthorDate: Mon Feb 11 14:48:56 2019 +

A fix revert got missed, readding
---
 .../src/main/java/org/apache/tomee/webservices/CXFJAXRSFilter.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/tomee/tomee-jaxrs/src/main/java/org/apache/tomee/webservices/CXFJAXRSFilter.java
 
b/tomee/tomee-jaxrs/src/main/java/org/apache/tomee/webservices/CXFJAXRSFilter.java
index 7909459..9d0afca 100644
--- 
a/tomee/tomee-jaxrs/src/main/java/org/apache/tomee/webservices/CXFJAXRSFilter.java
+++ 
b/tomee/tomee-jaxrs/src/main/java/org/apache/tomee/webservices/CXFJAXRSFilter.java
@@ -126,7 +126,7 @@ public class CXFJAXRSFilter implements Filter {
 accept = false;
 if 
(!"org.apache.catalina.servlets.DefaultServlet".equals(wrapper.getServletClass()))
 {
 for (final String mapping : wrapper.findMappings()) {
-if (!mapping.isEmpty() && !"/*".equals(mapping) && 
!"/".equals(mapping) && !mapping.startsWith("*")
+if (!mapping.isEmpty() && !"/*".equals(mapping) && 
!"/".equals(mapping) && !mapping.equals("*")
 && mapping.startsWith(this.mapping)) {
 accept = true;
 break;



[tomee] 08/08: Fixed test.

2019-02-15 Thread radcortez
This is an automated email from the ASF dual-hosted git repository.

radcortez pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomee.git

commit bb77a7b6505ba2cda7468fc6d72acc344d0b0509
Author: Roberto Cortez 
AuthorDate: Fri Feb 15 12:42:49 2019 +

Fixed test.
---
 .../openejb/arquillian/tests/cmp/sample/CustomOrmXmlCastTest.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/sample/CustomOrmXmlCastTest.java
 
b/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/sample/CustomOrmXmlCastTest.java
index 3e852ea..af88bd9 100644
--- 
a/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/sample/CustomOrmXmlCastTest.java
+++ 
b/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/sample/CustomOrmXmlCastTest.java
@@ -44,7 +44,7 @@ public class CustomOrmXmlCastTest {
 final WebArchive archive = ShrinkWrap.create(WebArchive.class, 
CustomOrmXmlCastTest.class.getSimpleName() + ".war")
 .addClasses(ActorBean.class, ActorDetails.class, 
LocalActor.class, LocalActorHome.class,
 LocalMovie.class, LocalMovieHome.class, 
MovieBean.class, MovieDetails.class,
-MoviesBusiness.class, MoviesBusinessBean.class, 
MoviesBusinessHome.class,
+MoviesBusiness.class, MoviesBusinessBean.class, 
MoviesBusinessHome.class, MoviesServlet.class,
 MoviesServlet2.class)
 .addAsResource(new 
ClassLoaderAsset("org/apache/openejb/arquillian/tests/cmp/sample/custom-orm.xml"),
 "META-INF/custom-orm.xml")
 .addAsResource(new 
ClassLoaderAsset("org/apache/openejb/arquillian/tests/cmp/sample/persistence.xml"),
 "META-INF/persistence.xml")



[tomee] 06/08: Fixed exception handling for no CXF service to pass resteasy test case

2019-02-15 Thread radcortez
This is an automated email from the ASF dual-hosted git repository.

radcortez pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomee.git

commit ad4b76449d2977088c7e32ccd9704a93da3b14b3
Author: James Meen 
AuthorDate: Wed Feb 13 15:24:59 2019 +

Fixed exception handling for no CXF service to pass resteasy test case
---
 .../openejb/server/cxf/rs/CxfRsHttpListener.java   | 34 --
 1 file changed, 18 insertions(+), 16 deletions(-)

diff --git 
a/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
 
b/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
index d05d213..2300c33 100644
--- 
a/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
+++ 
b/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
@@ -333,26 +333,28 @@ public class CxfRsHttpListener implements RsHttpListener {
 }
 
 public boolean isCXFResource(final HttpServletRequest request) {
-final JAXRSServiceImpl service;
 try {
-service = (JAXRSServiceImpl)server.getEndpoint().getService();
-} finally { }
-if( service == null ) {
-return false;
-}
+JAXRSServiceImpl service = 
(JAXRSServiceImpl)server.getEndpoint().getService();
 
-String pathToMatch = 
HttpUtils.getPathToMatch(request.getServletPath(), pattern, true);
-
-final List resources = 
service.getClassResourceInfos();
-for (final ClassResourceInfo info : resources) {
-if (info.getResourceClass() == null || info.getURITemplate() == 
null) { // possible?
-continue;
+if( service == null ) {
+return false;
 }
-   
-final MultivaluedMap parameters = new 
MultivaluedHashMap<>();
-if (info.getURITemplate().match(pathToMatch, parameters)) {
-return true;
+
+String pathToMatch = 
HttpUtils.getPathToMatch(request.getServletPath(), pattern, true);
+
+final List resources = 
service.getClassResourceInfos();
+for (final ClassResourceInfo info : resources) {
+if (info.getResourceClass() == null || info.getURITemplate() 
== null) { // possible?
+continue;
+}
+   
+final MultivaluedMap parameters = new 
MultivaluedHashMap<>();
+if (info.getURITemplate().match(pathToMatch, parameters)) {
+return true;
+}
 }
+} catch (final Exception e) {
+LOGGER.error("No JAX-RS service", e);
 }
 return false;
 }



[tomee] 02/08: Corrected JAXRS assertStatusCode check and fixed CXFJAXRSFilter enhancement request matching

2019-02-15 Thread radcortez
This is an automated email from the ASF dual-hosted git repository.

radcortez pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomee.git

commit 5c53f5652909ace68af6b4b944237ea3cdf965c5
Author: James Meen 
AuthorDate: Mon Feb 11 14:40:12 2019 +

Corrected JAXRS assertStatusCode check and fixed CXFJAXRSFilter enhancement 
request matching
---
 .../java/org/apache/openejb/arquillian/tests/jaxrs/JaxrsTest.java | 4 ++--
 .../java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java  | 8 ++--
 .../org/apache/tomee/microprofile/config/TomEEConfigSource.java   | 2 ++
 3 files changed, 10 insertions(+), 4 deletions(-)

diff --git 
a/arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/JaxrsTest.java
 
b/arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/JaxrsTest.java
index 9a6c15c..ebe5acd 100644
--- 
a/arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/JaxrsTest.java
+++ 
b/arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/JaxrsTest.java
@@ -78,8 +78,8 @@ public class JaxrsTest {
 return URI.create(String.format("%s%s", url.toExternalForm(), path));
 }
 
-public static void assertStatusCode(int actual, HttpResponse response) {
-Assert.assertEquals(response.getStatusLine().getStatusCode(), actual);
+public static void assertStatusCode(int expected, HttpResponse response) {
+Assert.assertEquals(expected, 
response.getStatusLine().getStatusCode());
 }
 
 public static String asString(HttpResponse execute) throws IOException {
diff --git 
a/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
 
b/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
index b77b5b0..d05d213 100644
--- 
a/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
+++ 
b/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
@@ -39,6 +39,7 @@ import org.apache.cxf.jaxrs.model.URITemplate;
 import org.apache.cxf.jaxrs.provider.ProviderFactory;
 import org.apache.cxf.jaxrs.provider.ServerProviderFactory;
 import org.apache.cxf.jaxrs.utils.JAXRSUtils;
+import org.apache.cxf.jaxrs.utils.HttpUtils;
 import org.apache.cxf.jaxrs.validation.JAXRSBeanValidationInInterceptor;
 import org.apache.cxf.jaxrs.validation.JAXRSBeanValidationOutInterceptor;
 import org.apache.cxf.jaxrs.validation.ValidationExceptionMapper;
@@ -339,14 +340,17 @@ public class CxfRsHttpListener implements RsHttpListener {
 if( service == null ) {
 return false;
 }
+
+String pathToMatch = 
HttpUtils.getPathToMatch(request.getServletPath(), pattern, true);
+
 final List resources = 
service.getClassResourceInfos();
 for (final ClassResourceInfo info : resources) {
 if (info.getResourceClass() == null || info.getURITemplate() == 
null) { // possible?
 continue;
 }
-
+   
 final MultivaluedMap parameters = new 
MultivaluedHashMap<>();
-if (info.getURITemplate().match(request.getServletPath(), 
parameters)) {
+if (info.getURITemplate().match(pathToMatch, parameters)) {
 return true;
 }
 }
diff --git 
a/tomee/tomee-microprofile/mp-common/src/main/java/org/apache/tomee/microprofile/config/TomEEConfigSource.java
 
b/tomee/tomee-microprofile/mp-common/src/main/java/org/apache/tomee/microprofile/config/TomEEConfigSource.java
index 036b42b..6085de4 100644
--- 
a/tomee/tomee-microprofile/mp-common/src/main/java/org/apache/tomee/microprofile/config/TomEEConfigSource.java
+++ 
b/tomee/tomee-microprofile/mp-common/src/main/java/org/apache/tomee/microprofile/config/TomEEConfigSource.java
@@ -43,12 +43,14 @@ public class TomEEConfigSource implements ConfigSource {
 
 if (mpIgnoredApps.stream().anyMatch(s -> 
s.equalsIgnoreCase(appContextOrWeb.getId( {
 openTracingFilterActive(false);
+metricsJaxRsActive(false);
 }
 }
 
 final String mpScan = 
SystemInstance.get().getOptions().get("tomee.mp.scan", "none");
 if (mpScan.equals("none")) {
 openTracingFilterActive(false);
+metricsJaxRsActive(false);
 }
 }
 



[tomee] 01/08: TOMEE-2408 - When MP is enabled CXF JAX-RS filter is also enabled. The filter was treating ALL endpoint resources as CXF resources. This commit makes the filter only process it's own CX

2019-02-15 Thread radcortez
This is an automated email from the ASF dual-hosted git repository.

radcortez pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomee.git

commit 7914391ce8477e666d52ad79bfb949dcb49c3a69
Author: James Meen 
AuthorDate: Wed Feb 6 23:55:10 2019 +

TOMEE-2408 - When MP is enabled CXF JAX-RS filter is also enabled.  The 
filter was treating ALL endpoint resources as CXF resources.  This commit makes 
the filter only process it's own CXF resources and pass everything else down 
the chain.
---
 .../openejb/server/cxf/rs/CxfRsHttpListener.java   | 25 ++
 .../apache/tomee/webservices/CXFJAXRSFilter.java   |  7 +-
 2 files changed, 31 insertions(+), 1 deletion(-)

diff --git 
a/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
 
b/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
index 8c9203c..b77b5b0 100644
--- 
a/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
+++ 
b/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
@@ -35,6 +35,7 @@ import org.apache.cxf.jaxrs.model.ClassResourceInfo;
 import org.apache.cxf.jaxrs.model.MethodDispatcher;
 import org.apache.cxf.jaxrs.model.OperationResourceInfo;
 import org.apache.cxf.jaxrs.model.ProviderInfo;
+import org.apache.cxf.jaxrs.model.URITemplate;
 import org.apache.cxf.jaxrs.provider.ProviderFactory;
 import org.apache.cxf.jaxrs.provider.ServerProviderFactory;
 import org.apache.cxf.jaxrs.utils.JAXRSUtils;
@@ -106,6 +107,8 @@ import javax.ws.rs.RuntimeType;
 import javax.ws.rs.core.Application;
 import javax.ws.rs.core.Configuration;
 import javax.ws.rs.core.MediaType;
+import javax.ws.rs.core.MultivaluedMap;
+import javax.ws.rs.core.MultivaluedHashMap;
 import javax.ws.rs.core.Response;
 import javax.ws.rs.ext.ExceptionMapper;
 import javax.ws.rs.ext.MessageBodyReader;
@@ -327,6 +330,28 @@ public class CxfRsHttpListener implements RsHttpListener {
 }
 return true;
 }
+
+public boolean isCXFResource(final HttpServletRequest request) {
+final JAXRSServiceImpl service;
+try {
+service = (JAXRSServiceImpl)server.getEndpoint().getService();
+} finally { }
+if( service == null ) {
+return false;
+}
+final List resources = 
service.getClassResourceInfos();
+for (final ClassResourceInfo info : resources) {
+if (info.getResourceClass() == null || info.getURITemplate() == 
null) { // possible?
+continue;
+}
+
+final MultivaluedMap parameters = new 
MultivaluedHashMap<>();
+if (info.getURITemplate().match(request.getServletPath(), 
parameters)) {
+return true;
+}
+}
+return false;
+}
 
 @Override
 @Deprecated // we could drop it now I think
diff --git 
a/tomee/tomee-jaxrs/src/main/java/org/apache/tomee/webservices/CXFJAXRSFilter.java
 
b/tomee/tomee-jaxrs/src/main/java/org/apache/tomee/webservices/CXFJAXRSFilter.java
index 193ab47..7909459 100644
--- 
a/tomee/tomee-jaxrs/src/main/java/org/apache/tomee/webservices/CXFJAXRSFilter.java
+++ 
b/tomee/tomee-jaxrs/src/main/java/org/apache/tomee/webservices/CXFJAXRSFilter.java
@@ -78,6 +78,11 @@ public class CXFJAXRSFilter implements Filter {
 final HttpServletRequest httpServletRequest = 
HttpServletRequest.class.cast(request);
 final HttpServletResponse httpServletResponse = 
HttpServletResponse.class.cast(response);
 
+if (!this.delegate.isCXFResource(httpServletRequest)) {
+chain.doFilter(request, response);
+return;
+}
+
 if (CxfRsHttpListener.TRY_STATIC_RESOURCES) { // else 100% JAXRS
 if (servletMappingIsUnderRestPath(httpServletRequest)) {
 chain.doFilter(request, response);
@@ -121,7 +126,7 @@ public class CXFJAXRSFilter implements Filter {
 accept = false;
 if 
(!"org.apache.catalina.servlets.DefaultServlet".equals(wrapper.getServletClass()))
 {
 for (final String mapping : wrapper.findMappings()) {
-if (!mapping.isEmpty() && !"/*".equals(mapping) && 
!"/".equals(mapping) && !mapping.equals("*")
+if (!mapping.isEmpty() && !"/*".equals(mapping) && 
!"/".equals(mapping) && !mapping.startsWith("*")
 && mapping.startsWith(this.mapping)) {
 accept = true;
 break;



[tomee] 07/08: Changed error to info

2019-02-15 Thread radcortez
This is an automated email from the ASF dual-hosted git repository.

radcortez pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomee.git

commit c303dc28a32aae225f56d1f2a53789e54e7ebb9b
Author: James Meen 
AuthorDate: Wed Feb 13 16:14:49 2019 +

Changed error to info
---
 .../main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
 
b/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
index 2300c33..aef9a25 100644
--- 
a/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
+++ 
b/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java
@@ -354,7 +354,7 @@ public class CxfRsHttpListener implements RsHttpListener {
 }
 }
 } catch (final Exception e) {
-LOGGER.error("No JAX-RS service", e);
+LOGGER.info("No JAX-RS service");
 }
 return false;
 }



[tomee] 04/08: Revert "A fix revert got missed, readding"

2019-02-15 Thread radcortez
This is an automated email from the ASF dual-hosted git repository.

radcortez pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomee.git

commit 1df8039822ae7ec854729f4449a96bd018a21045
Author: j4fm 
AuthorDate: Tue Feb 12 21:54:01 2019 +

Revert "A fix revert got missed, readding"
---
 .../src/main/java/org/apache/tomee/webservices/CXFJAXRSFilter.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/tomee/tomee-jaxrs/src/main/java/org/apache/tomee/webservices/CXFJAXRSFilter.java
 
b/tomee/tomee-jaxrs/src/main/java/org/apache/tomee/webservices/CXFJAXRSFilter.java
index 9d0afca..7909459 100644
--- 
a/tomee/tomee-jaxrs/src/main/java/org/apache/tomee/webservices/CXFJAXRSFilter.java
+++ 
b/tomee/tomee-jaxrs/src/main/java/org/apache/tomee/webservices/CXFJAXRSFilter.java
@@ -126,7 +126,7 @@ public class CXFJAXRSFilter implements Filter {
 accept = false;
 if 
(!"org.apache.catalina.servlets.DefaultServlet".equals(wrapper.getServletClass()))
 {
 for (final String mapping : wrapper.findMappings()) {
-if (!mapping.isEmpty() && !"/*".equals(mapping) && 
!"/".equals(mapping) && !mapping.equals("*")
+if (!mapping.isEmpty() && !"/*".equals(mapping) && 
!"/".equals(mapping) && !mapping.startsWith("*")
 && mapping.startsWith(this.mapping)) {
 accept = true;
 break;



[tomee] branch master updated (9497f24 -> bb77a7b)

2019-02-15 Thread radcortez
This is an automated email from the ASF dual-hosted git repository.

radcortez pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tomee.git.


from 9497f24  Merge remote-tracking branch 'apache/master'
 new 7914391  TOMEE-2408 - When MP is enabled CXF JAX-RS filter is also 
enabled.  The filter was treating ALL endpoint resources as CXF resources.  
This commit makes the filter only process it's own CXF resources and pass 
everything else down the chain.
 new 5c53f56  Corrected JAXRS assertStatusCode check and fixed 
CXFJAXRSFilter enhancement request matching
 new 8b843c6  A fix revert got missed, readding
 new 1df8039  Revert "A fix revert got missed, readding"
 new a56aad6  Disabled CXF specific 404/custom handler test
 new ad4b764  Fixed exception handling for no CXF service to pass resteasy 
test case
 new c303dc2  Changed error to info
 new bb77a7b  Fixed test.

The 8 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../openejb/arquillian/tests/jaxrs/JaxrsTest.java  |  4 +--
 .../tests/jaxrs/notfound/NotFoundTest.java |  2 +-
 .../tests/cmp/sample/CustomOrmXmlCastTest.java |  2 +-
 .../openejb/server/cxf/rs/CxfRsHttpListener.java   | 31 ++
 .../apache/tomee/webservices/CXFJAXRSFilter.java   |  7 -
 .../microprofile/config/TomEEConfigSource.java |  2 ++
 6 files changed, 43 insertions(+), 5 deletions(-)



[tomee] 05/08: Disabled CXF specific 404/custom handler test

2019-02-15 Thread radcortez
This is an automated email from the ASF dual-hosted git repository.

radcortez pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomee.git

commit a56aad64094679a39b3357f58b4de6125fb7cb85
Author: James Meen 
AuthorDate: Wed Feb 13 11:17:55 2019 +

Disabled CXF specific 404/custom handler test
---
 .../apache/openejb/arquillian/tests/jaxrs/notfound/NotFoundTest.java| 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/notfound/NotFoundTest.java
 
b/arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/notfound/NotFoundTest.java
index 2dc0f28..05567ae 100644
--- 
a/arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/notfound/NotFoundTest.java
+++ 
b/arquillian/arquillian-tomee-tests/arquillian-tomee-jaxrs-tests/src/test/java/org/apache/openejb/arquillian/tests/jaxrs/notfound/NotFoundTest.java
@@ -52,7 +52,7 @@ public class NotFoundTest {
 
 @Test
 public void run() {
-assertEquals("failed", 
ClientBuilder.newClient().target(base.toExternalForm() + 
"api/missing").request().get().readEntity(String.class));
+//assertEquals("failed", 
ClientBuilder.newClient().target(base.toExternalForm() + 
"api/missing").request().get().readEntity(String.class));
 assertEquals("t", 
ClientBuilder.newClient().target(base.toExternalForm() + 
"api/there").request().get().readEntity(String.class));
 }
 }



[jira] [Created] (TOMEE-2468) Your project apache/tomee is using buggy third-party libraries [WARNING]

2019-02-15 Thread Kaifeng Huang (JIRA)
Kaifeng Huang created TOMEE-2468:


 Summary: Your project apache/tomee is using buggy third-party 
libraries [WARNING]
 Key: TOMEE-2468
 URL: https://issues.apache.org/jira/browse/TOMEE-2468
 Project: TomEE
  Issue Type: Bug
Reporter: Kaifeng Huang



Hi, there!

We are a research team working on third-party library analysis. We have 
found that some widely-used third-party libraries in your project have 
major/critical bugs, which will degrade the quality of your project. We highly 
recommend you to update those libraries to new versions.

We have attached the buggy third-party libraries and corresponding jira 
issue links below for you to have more detailed information.

1. org.apache.logging.log4j log4j-core
version: 2.0.1

Jira issues:
Change flow logging text from "entry' to "Enter" and "exit" to "Exit"
affectsVersions:2.0,2.0.1,2.0.2,2.1,2.2,2.3,2.4,2.4.1,2.5

https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-1289?filter=allopenissues
AsyncLogger should not call instanceof TimestampMessage in hot path
affectsVersions:2.0.1,2.0.2,2.1,2.2,2.3,2.4,2.4.1,2.5

https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-1339?filter=allopenissues
PatternLayout's default charset should not be UTF-8
affectsVersions:2.0.1,2.0.2

https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-783?filter=allopenissues


2. org.apache.httpcomponents httpclient
version: 4.2.2

Jira issues:
Flag issues in NTLM implementation prevent authentication on some 
servers
affectsVersions:4.2.2

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1266?filter=allopenissues
NTLM: Authenticating against some servers throws an exception
affectsVersions:4.2.2

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1268?filter=allopenissues
BrowserCompatSpec: cookies values containing spaces are forwarded 
without quotes
affectsVersions:4.2.2

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1269?filter=allopenissues
CachingHttpClient sends a 304 Not Modified to an unconditional request
affectsVersions:4.2.2

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1277?filter=allopenissues
NullPointerException (apparently) when authenticating
affectsVersions:4.2.2

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1279?filter=allopenissues
Use of toUpperCase() in NTLM engine may fail on non-US locales
affectsVersions:4.2.2

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1283?filter=allopenissues
HttpClient treats URI fragments in URIs inconsistently
affectsVersions:4.2.2

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1286?filter=allopenissues
The HttpGet() and likely other method objects should accept only 
absoluteURI with path specified 
affectsVersions:4.2.2

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1291?filter=allopenissues
proxy with kerberos auth is not woking
affectsVersions:4.2.2

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1293?filter=allopenissues
CircularRedirectException is falsely thrown on URI case mismatch
affectsVersions:4.1.3;4.2.2

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1294?filter=allopenissues
Null pointer exception when using default host and virtual host with 
port -1
affectsVersions:4.2.2

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1296?filter=allopenissues
SSLSocketFactory.createSystemSSLContext causes 
java.security.UnrecoverableKeyException: Password verification failed
affectsVersions:4.2.2;4.2.3;4.2.4;4.3 Alpha1;4.3 Beta1;4.3 Final

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1320?filter=allopenissues


3. org.apache.httpcomponents httpclient
version: 4.3.2

Jira issues:
AsynchronousValidationRequest and a connection pool leak
affectsVersions:4.3.1;4.3.2

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1441?filter=allopenissues
PoolingHttpClientConnectionManager thread safety
affectsVersions:4.3.2

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1453?filter=allopenissues
HttpClientBuilder.useSystemProperties() is incompatible with NTLM scheme
affectsVersions:4.3.2

https://issues.apache.org/jira/projects/HTTPCLIENT/issues/HTTPCLIENT-1457?filter=allopenissues