[trafficserver] 01/02: Server information should be cleared when following redirect...for 7.1.x branch

2017-05-31 Thread zwoop 
This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch 7.1.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

commit e0f4e5058edc4a59c1626e5b5d376d1864f94127
Author: vijayabhaskar 
AuthorDate: Wed May 31 21:55:46 2017 +

Server information should be cleared when following redirect...for 7.1.x 
branch
---
 proxy/http/HttpSM.cc  | 2 ++
 proxy/http/HttpTransact.h | 9 +++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/proxy/http/HttpSM.cc b/proxy/http/HttpSM.cc
index b5f3269..de96aa9 100644
--- a/proxy/http/HttpSM.cc
+++ b/proxy/http/HttpSM.cc
@@ -7859,6 +7859,8 @@ HttpSM::redirect_request(const char *redirect_url, const 
int redirect_len)
   // we have a new OS and need to have DNS lookup the new OS
   t_state.dns_info.lookup_success = false;
   t_state.force_dns   = false;
+  t_state.server_info.clear();
+  t_state.parent_info.clear();
 
   if (t_state.txn_conf->cache_http) {
 t_state.cache_info.object_read = nullptr;
diff --git a/proxy/http/HttpTransact.h b/proxy/http/HttpTransact.h
index 9049891..96fd9f5 100644
--- a/proxy/http/HttpTransact.h
+++ b/proxy/http/HttpTransact.h
@@ -702,8 +702,13 @@ public:
 port_attribute(HttpProxyPort::TRANSPORT_DEFAULT),
 is_transparent(false)
 {
-  memset(&src_addr, 0, sizeof(src_addr));
-  memset(&dst_addr, 0, sizeof(dst_addr));
+clear();
+}
+void clear()
+{
+ink_zero(src_addr);
+ink_zero(dst_addr);
+connect_result = 0;
 }
   };
 

-- 
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" .

[trafficserver] branch 7.1.x updated (edd3873 -> 2f5792b)

2017-05-31 Thread zwoop 
This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a change to branch 7.1.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git.

  from  edd3873   Use our ATS server to proxy for Bintray
   new  e0f4e50   Server information should be cleared when following 
redirect...for 7.1.x branch
   new  2f5792b   clang format

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 proxy/http/HttpSM.cc  |  2 ++
 proxy/http/HttpTransact.h | 10 --
 2 files changed, 10 insertions(+), 2 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] 02/02: clang format

2017-05-31 Thread zwoop 
This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch 7.1.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

commit 2f5792b9b149aa1dd11be83ad7d4f4f619b049b3
Author: Vijay Mamidi 
AuthorDate: Wed May 31 15:35:31 2017 -0700

clang format
---
 proxy/http/HttpTransact.h | 11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/proxy/http/HttpTransact.h b/proxy/http/HttpTransact.h
index 96fd9f5..33fa650 100644
--- a/proxy/http/HttpTransact.h
+++ b/proxy/http/HttpTransact.h
@@ -702,13 +702,14 @@ public:
 port_attribute(HttpProxyPort::TRANSPORT_DEFAULT),
 is_transparent(false)
 {
-clear();
+  clear();
 }
-void clear()
+void
+clear()
 {
-ink_zero(src_addr);
-ink_zero(dst_addr);
-connect_result = 0;
+  ink_zero(src_addr);
+  ink_zero(dst_addr);
+  connect_result = 0;
 }
   };
 

-- 
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" .

[trafficserver] branch master updated: Removes the cp of clang-format, our ATS can handle the load

2017-05-31 Thread zwoop 
This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
   new  4576555   Removes the cp of clang-format, our ATS can handle the 
load
4576555 is described below

commit 45765558208b3fb39c54d145a79b25f43c04160e
Author: Leif Hedstrom 
AuthorDate: Wed May 31 13:27:00 2017 -0600

Removes the cp of clang-format, our ATS can handle the load
---
 ci/jenkins/bin/clang-format.sh | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/ci/jenkins/bin/clang-format.sh b/ci/jenkins/bin/clang-format.sh
index 2d5fbc1..e6f79f5 100644
--- a/ci/jenkins/bin/clang-format.sh
+++ b/ci/jenkins/bin/clang-format.sh
@@ -19,17 +19,6 @@
 cd "${WORKSPACE}/src"
 autoreconf -if && ./configure
 
-# Test clang-format, copy our version of clang-format if needed
-if [ ! -d .git/fmt ]; then
-if [ -z "${ghprbTargetBranch}" ]; then
-   cp -rp /home/jenkins/clang-format/master .git/fmt
-else
-   # This is for Github PR's, to make sure we use the right clang-format 
for the branch.
-   # This is not an issue on normal branch builds, since they will have 
the right .git/fmt.
-   cp -rp /home/jenkins/clang-format/${ghprbTargetBranch} .git/fmt
-fi
-fi
-
 ${ATS_MAKE} -j clang-format
 git diff --exit-code
 [ "0" != "$?" ] && exit -1

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] branch master updated: Rename "ink_mutex_lock" to "ink_scoped_mutex_lock" for better consistency.

2017-05-31 Thread amc 
This is an automated email from the ASF dual-hosted git repository.

amc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
   new  6c67bf0   Rename "ink_mutex_lock" to "ink_scoped_mutex_lock" for 
better consistency.
6c67bf0 is described below

commit 6c67bf0ad50827dda2faa0fe8e7005229d063537
Author: Alan M. Carroll 
AuthorDate: Wed May 31 14:18:48 2017 -0500

Rename "ink_mutex_lock" to "ink_scoped_mutex_lock" for better consistency.
---
 lib/ts/ink_mutex.h | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/ts/ink_mutex.h b/lib/ts/ink_mutex.h
index d0cd7e9..a0c36c9 100644
--- a/lib/ts/ink_mutex.h
+++ b/lib/ts/ink_mutex.h
@@ -74,21 +74,21 @@ ink_mutex_try_acquire(ink_mutex *m)
 ink_mutex m;
 // ...
 {
-   ink_mutex_lock lock(m);
+   ink_mutex_scoped_lock lock(m);
// code under lock.
 }
 // code not under lock
 @endcode
  */
-class ink_mutex_lock
+class ink_scoped_mutex_lock
 {
 private:
   ink_mutex &_m;
 
 public:
-  ink_mutex_lock(ink_mutex *m) : _m(*m) { ink_mutex_acquire(&_m); }
-  ink_mutex_lock(ink_mutex &m) : _m(m) { ink_mutex_acquire(&_m); }
-  ~ink_mutex_lock() { ink_mutex_release(&_m); }
+  ink_scoped_mutex_lock(ink_mutex *m) : _m(*m) { ink_mutex_acquire(&_m); }
+  ink_scoped_mutex_lock(ink_mutex &m) : _m(m) { ink_mutex_acquire(&_m); }
+  ~ink_scoped_mutex_lock() { ink_mutex_release(&_m); }
 };
 
 #endif /* _ink_mutex_h_ */

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] branch master updated: Changes the default for proxy.config.ssl.server.multicert.exit_on_load_fail

2017-05-31 Thread zwoop 
This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
   new  4704525   Changes the default for 
proxy.config.ssl.server.multicert.exit_on_load_fail
4704525 is described below

commit 4704525a6f9b7ba4cc79b56fd58958dcb83f3225
Author: Leif Hedstrom 
AuthorDate: Thu May 25 10:14:41 2017 -0600

Changes the default for proxy.config.ssl.server.multicert.exit_on_load_fail

This restores the old (and IMO expected) behavior of how we don't allow
bad configurations to be reloaded / replaced. We've had a case where
all certificates were lost for a small period of time, and an unrelated
config reload happening at the same time caused us to lose all certificates.
---
 iocore/net/SSLConfig.cc | 2 +-
 mgmt/RecordsConfig.cc   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/iocore/net/SSLConfig.cc b/iocore/net/SSLConfig.cc
index 093ebe8..343b3d9 100644
--- a/iocore/net/SSLConfig.cc
+++ b/iocore/net/SSLConfig.cc
@@ -101,7 +101,7 @@ SSLConfigParams::reset()
   ssl_session_cache_skip_on_contention = 0;
   ssl_session_cache_timeout= 0;
   ssl_session_cache_auto_clear = 1;
-  configExitOnLoadError= 0;
+  configExitOnLoadError= 1;
 }
 
 void
diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
index cf36d02..8ecd3ee 100644
--- a/mgmt/RecordsConfig.cc
+++ b/mgmt/RecordsConfig.cc
@@ -1148,7 +1148,7 @@ static const RecordElement RecordsConfig[] =
   ,
   {RECT_CONFIG, "proxy.config.ssl.server.multicert.filename", RECD_STRING, 
"ssl_multicert.config", RECU_RESTART_TS, RR_NULL, RECC_NULL, nullptr, RECA_NULL}
   ,
-  {RECT_CONFIG, "proxy.config.ssl.server.multicert.exit_on_load_fail", 
RECD_INT, "0", RECU_RESTART_TS, RR_NULL, RECC_NULL, "[0-1]", RECA_NULL}
+  {RECT_CONFIG, "proxy.config.ssl.server.multicert.exit_on_load_fail", 
RECD_INT, "1", RECU_RESTART_TS, RR_NULL, RECC_NULL, "[0-1]", RECA_NULL}
   ,
   {RECT_CONFIG, "proxy.config.ssl.server.ticket_key.filename", RECD_STRING, 
nullptr, RECU_DYNAMIC, RR_NULL, RECC_NULL, nullptr, RECA_NULL}
   ,

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] branch master updated: Documented more detail about TS_HTTP_SEND_REQUEST_HDR_HOOK hook

2017-05-31 Thread zwoop 
This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
   new  adb998c   Documented more detail about 
TS_HTTP_SEND_REQUEST_HDR_HOOK hook
adb998c is described below

commit adb998cb0dc2032132edf74f89ffdd4c1aabeb43
Author: scw00 <616955...@qq.com>
AuthorDate: Wed May 31 10:59:26 2017 +0800

Documented more detail about TS_HTTP_SEND_REQUEST_HDR_HOOK hook
---
 .../plugins/continuations/writing-handler-functions.en.rst  | 6 ++
 .../plugins/hooks-and-transactions/adding-hooks.en.rst  | 6 ++
 2 files changed, 12 insertions(+)

diff --git 
a/doc/developer-guide/plugins/continuations/writing-handler-functions.en.rst 
b/doc/developer-guide/plugins/continuations/writing-handler-functions.en.rst
index 901e46a..5384fe8 100644
--- a/doc/developer-guide/plugins/continuations/writing-handler-functions.en.rst
+++ b/doc/developer-guide/plugins/continuations/writing-handler-functions.en.rst
@@ -67,6 +67,12 @@ it receives:
continuation before you make sure that all incoming events, such as
those sent because of :func:`TSHttpTxnHookAdd`, have been handled.
 
+.. caution::
+
+   TS_HTTP_SEND_REQUEST_HDR_HOOK may callback several times when the  
+   OS crashed. Be careful to use functions such as TSContDestroy in 
+   TS_HTTP_SEND_REQUEST_HDR_HOOK hook.
+
 The following table lists events and the corresponding type of
 `void* data` passed to handler functions:
 
diff --git 
a/doc/developer-guide/plugins/hooks-and-transactions/adding-hooks.en.rst 
b/doc/developer-guide/plugins/hooks-and-transactions/adding-hooks.en.rst
index 3b6e004..c1e0e1d 100644
--- a/doc/developer-guide/plugins/hooks-and-transactions/adding-hooks.en.rst
+++ b/doc/developer-guide/plugins/hooks-and-transactions/adding-hooks.en.rst
@@ -132,6 +132,12 @@ values for ``TSHttpHookID`` are:
 modifying the proxy's request header before it is sent to the origin
 server or parent proxy.
 
+.. caution::
+
+   TS_HTTP_SEND_REQUEST_HDR_HOOK may callback several times when the  
+   OS crashed. Be careful to use functions such as TSContDestroy in 
+   TS_HTTP_SEND_REQUEST_HDR_HOOK hook.
+
 ``TS_HTTP_SSN_CLOSE_HOOK``
 Called when an HTTP session ends. A session ends when the client
 connection is closed. You can only add this hook as a global hook

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] branch master updated: ProtocolStack - fix user agent side IPv6 detection.

2017-05-31 Thread amc 
This is an automated email from the ASF dual-hosted git repository.

amc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
   new  b339d53   ProtocolStack - fix user agent side IPv6 detection.
b339d53 is described below

commit b339d535d27d2667ed8dd7939aa4aca3aeaec98e
Author: Alan M. Carroll 
AuthorDate: Wed May 31 08:15:07 2017 -0500

ProtocolStack - fix user agent side IPv6 detection.
---
 iocore/net/UnixNetAccept.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/iocore/net/UnixNetAccept.cc b/iocore/net/UnixNetAccept.cc
index 63accc1..c47d640 100644
--- a/iocore/net/UnixNetAccept.cc
+++ b/iocore/net/UnixNetAccept.cc
@@ -288,6 +288,7 @@ NetAccept::do_blocking_accept(EThread *t)
 vc->set_is_transparent(opt.f_inbound_transparent);
 vc->options.packet_mark = opt.packet_mark;
 vc->options.packet_tos  = opt.packet_tos;
+vc->options.ip_family   = opt.ip_family;
 vc->apply_options();
 vc->set_context(NET_VCONNECTION_IN);
 vc->accept_object = this;
@@ -436,6 +437,7 @@ NetAccept::acceptFastEvent(int event, void *ep)
 vc->set_is_transparent(opt.f_inbound_transparent);
 vc->options.packet_mark = opt.packet_mark;
 vc->options.packet_tos  = opt.packet_tos;
+vc->options.ip_family   = opt.ip_family;
 vc->apply_options();
 vc->set_context(NET_VCONNECTION_IN);
 SET_CONTINUATION_HANDLER(vc, 
(NetVConnHandler)&UnixNetVConnection::mainEvent);

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] branch 6.2.x updated: Use our ATS server to proxy for Bintray

2017-05-31 Thread zwoop 
This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch 6.2.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/6.2.x by this push:
   new  3f429c0   Use our ATS server to proxy for Bintray
3f429c0 is described below

commit 3f429c06c9e538b272fb1e382dfb6239579f4559
Author: Leif Hedstrom 
AuthorDate: Wed May 31 09:37:30 2017 -0600

Use our ATS server to proxy for Bintray

(cherry picked from commit c05264fcf08cacfc5e58c0c4bebc2af959de7161)
---
 tools/clang-format.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/clang-format.sh b/tools/clang-format.sh
index f9b9544..ee3df3d 100755
--- a/tools/clang-format.sh
+++ b/tools/clang-format.sh
@@ -25,7 +25,7 @@ ROOT=${ROOT:-$(git rev-parse --show-toplevel)/.git/fmt}
 PACKAGE="clang-format-20160415.tar.bz2"
 VERSION="clang-format version 3.9.0 (trunk 265913)"
 
-URL=${URL:-https://bintray.com/artifact/download/apache/trafficserver/${PACKAGE}}
+URL=${URL:-https://ci.trafficserver.apache.org/bintray/${PACKAGE}}
 
 TAR=${TAR:-tar}
 CURL=${CURL:-curl}

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] branch 7.1.x updated: Use our ATS server to proxy for Bintray

2017-05-31 Thread zwoop 
This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch 7.1.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/7.1.x by this push:
   new  edd3873   Use our ATS server to proxy for Bintray
edd3873 is described below

commit edd38739f4ea6059fcb320eec22c29170e6f2d48
Author: Leif Hedstrom 
AuthorDate: Wed May 31 09:37:30 2017 -0600

Use our ATS server to proxy for Bintray

(cherry picked from commit c05264fcf08cacfc5e58c0c4bebc2af959de7161)
---
 tools/clang-format.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/clang-format.sh b/tools/clang-format.sh
index 1695140..5eba5ad 100755
--- a/tools/clang-format.sh
+++ b/tools/clang-format.sh
@@ -26,7 +26,7 @@ ROOT=${ROOT:-$(cd $(dirname $0) && git rev-parse 
--show-toplevel)/.git/fmt/${PKG
 PACKAGE="clang-format-${PKGDATE}.tar.bz2"
 VERSION="clang-format version 3.9.0 (trunk 265913)"
 
-URL=${URL:-https://bintray.com/artifact/download/apache/trafficserver/${PACKAGE}}
+URL=${URL:-https://ci.trafficserver.apache.org/bintray/${PACKAGE}}
 
 TAR=${TAR:-tar}
 CURL=${CURL:-curl}

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] branch master updated: Use our ATS server to proxy for Bintray

2017-05-31 Thread zwoop 
This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
   new  c05264f   Use our ATS server to proxy for Bintray
c05264f is described below

commit c05264fcf08cacfc5e58c0c4bebc2af959de7161
Author: Leif Hedstrom 
AuthorDate: Wed May 31 09:37:30 2017 -0600

Use our ATS server to proxy for Bintray
---
 tools/clang-format.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/clang-format.sh b/tools/clang-format.sh
index 2d2390b..6820394 100755
--- a/tools/clang-format.sh
+++ b/tools/clang-format.sh
@@ -27,7 +27,7 @@ ROOT=${ROOT:-$(cd $(dirname $0) && git rev-parse 
--show-toplevel)/.git/fmt/${PKG
 PACKAGE="clang-format-${PKGDATE}.tar.bz2"
 VERSION="clang-format version 4.0.1 (http://llvm.org/git/clang.git 
559aa046fe3260d8640791f2249d7b0d458b5700) (http://llvm.org/git/llvm.git 
08142cb734b8d2cefec8b1629f6bb170b3f94610)"
 
-URL=${URL:-https://bintray.com/artifact/download/apache/trafficserver/${PACKAGE}}
+URL=${URL:-https://ci.trafficserver.apache.org/bintray/${PACKAGE}}
 
 TAR=${TAR:-tar}
 CURL=${CURL:-curl}

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] branch 7.1.x updated: cid 1375841: Replace strncpy with memcpy

2017-05-31 Thread zwoop 
This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch 7.1.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/7.1.x by this push:
   new  5eb6e85   cid 1375841: Replace strncpy with memcpy
5eb6e85 is described below

commit 5eb6e85e0f54d95e46c16bcec1db2e3c92f289ad
Author: Gancho Tenev 
AuthorDate: Wed May 31 07:09:58 2017 -0700

cid 1375841: Replace strncpy with memcpy

Issue:
  CID 1375841 (#1 of 1): Buffer not null terminated (BUFFER_SIZE)
  1. buffer_size: Calling strncpy with a source string whose length
  (4 chars) is greater than or equal to the size argument (4) will
  fail to null-terminate key.

Fix:
  The code is correct. The buffer is not meant to be NULL-terminated.
  It seems Coverity thinks that since strncpy is used NULL-terminated
  buffer is expected.  Changing strncpy to memcpy.

Also removing unnecessary #undef

(cherry picked from commit 9a4aa33c713e68dc4c10d60f49f6a4e58d2c11f1)
---
 plugins/s3_auth/aws_auth_v4.cc | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/plugins/s3_auth/aws_auth_v4.cc b/plugins/s3_auth/aws_auth_v4.cc
index 65c65b9..386bf69 100644
--- a/plugins/s3_auth/aws_auth_v4.cc
+++ b/plugins/s3_auth/aws_auth_v4.cc
@@ -29,7 +29,6 @@
 #include   /* SHA(), sha256_Update(), SHA256_Final, etc. */
 #include  /* HMAC() */
 
-#undef AWS_AUTH_V4_DETAILED_DEBUG_OUTPUT
 #ifdef AWS_AUTH_V4_DETAILED_DEBUG_OUTPUT
 #include 
 #endif
@@ -565,8 +564,8 @@ getSignature(const char *awsSecret, size_t awsSecretLen, 
const char *awsRegion,
 
   size_t keyLen = 4 + awsSecretLen;
   char key[keyLen];
-  strncpy(key, "AWS4", 4);
-  strncpy(key + 4, awsSecret, awsSecretLen);
+  memcpy(key, "AWS4", 4);
+  memcpy(key + 4, awsSecret, awsSecretLen);
 
   unsigned int len = signatureLen;
   if (HMAC(EVP_sha256(), key, keyLen, (unsigned char *)dateTime, dateTimeLen, 
dateKey, &dateKeyLen) &&

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] branch master updated: proxy.config.ssl.number.threads does not exist

2017-05-31 Thread paziz 
This is an automated email from the ASF dual-hosted git repository.

paziz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
   new  5b94a62   proxy.config.ssl.number.threads does not exist
5b94a62 is described below

commit 5b94a62ed31827d90dcba024cbf2a72b133ff8b9
Author: Persia Aziz 
AuthorDate: Wed May 31 13:08:27 2017 -0500

proxy.config.ssl.number.threads does not exist
---
 tests/gold_tests/h2/http2.test.py  | 1 -
 tests/gold_tests/remap/remap_https.test.py | 1 -
 2 files changed, 2 deletions(-)

diff --git a/tests/gold_tests/h2/http2.test.py 
b/tests/gold_tests/h2/http2.test.py
index d3f6f4d..d71b6f8 100644
--- a/tests/gold_tests/h2/http2.test.py
+++ b/tests/gold_tests/h2/http2.test.py
@@ -65,7 +65,6 @@ ts.Disk.records_config.update({
 'proxy.config.diags.debug.tags': 'http|remap',
 'proxy.config.ssl.server.cert.path': 
'{0}'.format(ts.Variables.SSLDir), 
 'proxy.config.ssl.server.private_key.path': 
'{0}'.format(ts.Variables.SSLDir),
-'proxy.config.ssl.number.threads': 0,
 'proxy.config.http.server_ports': '{0} 
{1}:proto=http2;http:ssl'.format(ts.Variables.port,ts.Variables.ssl_port),  # 
enable ssl port
 'proxy.config.ssl.client.verify.server':  0,
 'proxy.config.ssl.server.cipher_suite' : 
'ECDHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:AES128-GCM-SHA256:AES256-GCM-SHA384:ECDHE-RSA-RC4-SHA:ECDHE-RSA-AES128-SHA:ECDHE-RSA-AES256-SHA:RC4-SHA:RC4-MD5:AES128-SHA:AES256-SHA:DES-CBC3-SHA!SRP:!DSS:!PSK:!aNULL:!eNULL:!SSLv2',
diff --git a/tests/gold_tests/remap/remap_https.test.py 
b/tests/gold_tests/remap/remap_https.test.py
index 84e6587..ae6981b 100644
--- a/tests/gold_tests/remap/remap_https.test.py
+++ b/tests/gold_tests/remap/remap_https.test.py
@@ -48,7 +48,6 @@ ts.Disk.records_config.update({
 'proxy.config.diags.debug.tags': 'lm|ssl',
 'proxy.config.ssl.server.cert.path': 
'{0}'.format(ts.Variables.SSLDir), 
 'proxy.config.ssl.server.private_key.path': 
'{0}'.format(ts.Variables.SSLDir),
-'proxy.config.ssl.number.threads': 0,
 'proxy.config.http.server_ports': '{0} 
{1}:proto=http2;http:ssl'.format(ts.Variables.port,ts.Variables.ssl_port),  # 
enable ssl port
 'proxy.config.ssl.client.verify.server':  0,
 'proxy.config.ssl.server.cipher_suite' : 
'ECDHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:AES128-GCM-SHA256:AES256-GCM-SHA384:ECDHE-RSA-RC4-SHA:ECDHE-RSA-AES128-SHA:ECDHE-RSA-AES256-SHA:RC4-SHA:RC4-MD5:AES128-SHA:AES256-SHA:DES-CBC3-SHA!SRP:!DSS:!PSK:!aNULL:!eNULL:!SSLv2',

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] branch 7.1.x updated: Issue #1605 AWS Signature Version 4

2017-05-31 Thread zwoop 
This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch 7.1.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/7.1.x by this push:
   new  024074b   Issue #1605 AWS Signature Version 4
024074b is described below

commit 024074be22dc35a399debe59353743dd90c33eba
Author: Gancho Tenev 
AuthorDate: Tue Apr 25 13:02:44 2017 -0700

Issue #1605 AWS Signature Version 4

Signature Calculations for the Authorization Header:
Transferring Payload in a Single Chunk (Unsigned payload option)

http://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-header-based-auth.html
(cherry picked from commit fa731369b474cb3c46b7b8ddf98490c198cd4605)

 Conflicts:
plugins/s3_auth/s3_auth.cc
---
 doc/admin-guide/plugins/s3_auth.en.rst | 114 --
 plugins/s3_auth/Makefile.inc   |   2 +-
 plugins/s3_auth/aws_auth_v4.cc | 691 +
 plugins/s3_auth/aws_auth_v4.h  | 207 ++
 plugins/s3_auth/s3_auth.cc | 273 -
 5 files changed, 1247 insertions(+), 40 deletions(-)

diff --git a/doc/admin-guide/plugins/s3_auth.en.rst 
b/doc/admin-guide/plugins/s3_auth.en.rst
index d6f5709..7293188 100644
--- a/doc/admin-guide/plugins/s3_auth.en.rst
+++ b/doc/admin-guide/plugins/s3_auth.en.rst
@@ -27,57 +27,119 @@ to use ``S3`` as your origin server, yet want to avoid 
direct user access to
 the content.
 
 Using the plugin
-
+
 
-There are three configuration options for this plugin::
-
---access_key
---secret_key
---virtual_host
---config
 
+Using the plugin in a remap rule would be e.g.::
 
-Using the first two in a remap rule would be e.g.::
+   # remap.config
 
...  @plugin=s3_auth @pparam=--access_key @pparam=my-key \
 @pparam=--secret_key @pparam=my-secret \
@pparam=--virtual_host
 
 
-Alternatively, you can store the access key and secret in an external
-configuration file, and point the remap rule(s) to it:
+Alternatively, you can store the access key and secret in an external 
configuration file, and point the remap rule(s) to it::
 
-   ...  @plugin=s3_auth @pparam=--config @pparam=s3.config
+   # remap.config
 
+   ...  @plugin=s3_auth @pparam=--config @pparam=s3_auth_v2.config
 
-Where s3.config would look like::
 
-# AWS S3 authentication
-access_key=my-key
-secret_key=my-secret
-virtual_host=yes
+Where ``s3.config`` could look like::
 
+# s3_auth_v2.config
 
-For more details on the S3 auth, see::
+access_key=my-key
+secret_key=my-secret
+version=2
+virtual_host=yes
 
-  http://docs.aws.amazon.com/AmazonS3/latest/dev/RESTAuthentication.html
+Both ways could be combined as well
 
 
-ToDo
-
+AWS Authentication version 4
+
 
-This is a pretty barebone start for the S3 services, it is missing a number of 
features:
+The s3_auth plugin fully implements: `AWS Signing Version 4 
`_
 / `Authorization Header 
`_
 / `Transferring Payload in a Single Chunk 
`_
 / Unsigned Payload Option
 
-- It does not do UTF8 encoding (as required)
+Configuration options::
 
-- It only implements the v2 authentication mechanism. For details on v4, see
+# Mandatory options
+--access_key=
+--secret_key=
+--version=4
 
-  
http://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-authenticating-requests.html
+# Optional
+--v4-include-headers=
+--v4-exclude-headers=
+--v4-region-map=region_map.config
 
-- It does not deal with canonicalization of AMZ headers.
 
-- It does not handle POST requests (but do we need to ?)
+If the following option is used then the options could be specified in a file::
+
+--config=s3_auth_v4.config
+
+
+The ``s3_auth_v4.config`` config file could look like this::
+
+# s3_auth_v4.config
+
+access_key=
+secret_key=
+version=4
+v4-include-headers=
+v4-exclude-headers=
+v4-region-map=region_map.config
+
+Where the ``region_map.config`` defines the entry-point hostname to region 
mapping i.e.::
+
+# region_map.config
+
+# "us-east-1"
+s3.amazonaws.com : us-east-1
+s3-external-1.amazonaws.com  : us-east-1
+s3.dualstack.us-east-1.amazonaws.com : us-east-1
+
+# us-west-1
+s3-us-west-1.amazonaws.com   : us-west-1
+s3.dualstack.us-west-1.amazonaws.com : us-west-1
+
+# Default region if no entry-point matches:
+: s3.amazonaws.com
+
+If ``--v4-region-map`` is not specified the plugin defaults to the mapping 
defined in `"Regions and Endpoints -

[trafficserver] branch master updated: Require at least one ET_TASK thread

2017-05-31 Thread zwoop 
This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
   new  bb71401   Require at least one ET_TASK thread
bb71401 is described below

commit bb71401079ab9df73affefb7db61e559adeab9c8
Author: Leif Hedstrom 
AuthorDate: Thu May 25 20:07:25 2017 -0600

Require at least one ET_TASK thread
---
 doc/admin-guide/files/records.config.en.rst | 3 ++-
 iocore/eventsystem/Tasks.cc | 4 +---
 mgmt/RecordsConfig.cc   | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/doc/admin-guide/files/records.config.en.rst 
b/doc/admin-guide/files/records.config.en.rst
index 706dc64..efb3492 100644
--- a/doc/admin-guide/files/records.config.en.rst
+++ b/doc/admin-guide/files/records.config.en.rst
@@ -3648,7 +3648,8 @@ Sockets
 .. ts:cv:: CONFIG proxy.config.task_threads INT 2
 
Specifies the number of task threads to run. These threads are used for
-   various tasks that should be off-loaded from the normal network threads.
+   various tasks that should be off-loaded from the normal network
+   threads. You must have at least one task thread available.
 
 .. ts:cv:: CONFIG proxy.config.allocator.thread_freelist_size INT 512
 
diff --git a/iocore/eventsystem/Tasks.cc b/iocore/eventsystem/Tasks.cc
index 58dc1ef..63ff8ff 100644
--- a/iocore/eventsystem/Tasks.cc
+++ b/iocore/eventsystem/Tasks.cc
@@ -32,8 +32,6 @@ TasksProcessor tasksProcessor;
 int
 TasksProcessor::start(int task_threads, size_t stacksize)
 {
-  if (task_threads > 0) {
-ET_TASK = eventProcessor.spawn_event_threads(task_threads, "ET_TASK", 
stacksize);
-  }
+  ET_TASK = eventProcessor.spawn_event_threads(task_threads > 0 ? task_threads 
: 1, "ET_TASK", stacksize);
   return 0;
 }
diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
index d1d9b36..cf36d02 100644
--- a/mgmt/RecordsConfig.cc
+++ b/mgmt/RecordsConfig.cc
@@ -132,7 +132,7 @@ static const RecordElement RecordsConfig[] =
   ,
   {RECT_CONFIG, "proxy.config.accept_threads", RECD_INT, "1", RECU_RESTART_TS, 
RR_NULL, RECC_INT, "[0-" TS_STR(TS_MAX_NUMBER_EVENT_THREADS) "]", 
RECA_READ_ONLY}
   ,
-  {RECT_CONFIG, "proxy.config.task_threads", RECD_INT, "2", RECU_RESTART_TS, 
RR_NULL, RECC_INT, "[0-" TS_STR(TS_MAX_NUMBER_EVENT_THREADS) "]", 
RECA_READ_ONLY}
+  {RECT_CONFIG, "proxy.config.task_threads", RECD_INT, "2", RECU_RESTART_TS, 
RR_NULL, RECC_INT, "[1-" TS_STR(TS_MAX_NUMBER_EVENT_THREADS) "]", 
RECA_READ_ONLY}
   ,
   {RECT_CONFIG, "proxy.config.thread.default.stacksize", RECD_INT, "1048576", 
RECU_RESTART_TS, RR_NULL, RECC_INT, "[131072-104857600]", RECA_READ_ONLY}
   ,

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] branch master updated: cid 1375841: Replace strncpy with memcpy

2017-05-31 Thread gancho 
This is an automated email from the ASF dual-hosted git repository.

gancho pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
   new  9a4aa33   cid 1375841: Replace strncpy with memcpy
9a4aa33 is described below

commit 9a4aa33c713e68dc4c10d60f49f6a4e58d2c11f1
Author: Gancho Tenev 
AuthorDate: Wed May 31 07:09:58 2017 -0700

cid 1375841: Replace strncpy with memcpy

Issue:
  CID 1375841 (#1 of 1): Buffer not null terminated (BUFFER_SIZE)
  1. buffer_size: Calling strncpy with a source string whose length
  (4 chars) is greater than or equal to the size argument (4) will
  fail to null-terminate key.

Fix:
  The code is correct. The buffer is not meant to be NULL-terminated.
  It seems Coverity thinks that since strncpy is used NULL-terminated
  buffer is expected.  Changing strncpy to memcpy.

Also removing unnecessary #undef
---
 plugins/s3_auth/aws_auth_v4.cc | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/plugins/s3_auth/aws_auth_v4.cc b/plugins/s3_auth/aws_auth_v4.cc
index 65c65b9..386bf69 100644
--- a/plugins/s3_auth/aws_auth_v4.cc
+++ b/plugins/s3_auth/aws_auth_v4.cc
@@ -29,7 +29,6 @@
 #include   /* SHA(), sha256_Update(), SHA256_Final, etc. */
 #include  /* HMAC() */
 
-#undef AWS_AUTH_V4_DETAILED_DEBUG_OUTPUT
 #ifdef AWS_AUTH_V4_DETAILED_DEBUG_OUTPUT
 #include 
 #endif
@@ -565,8 +564,8 @@ getSignature(const char *awsSecret, size_t awsSecretLen, 
const char *awsRegion,
 
   size_t keyLen = 4 + awsSecretLen;
   char key[keyLen];
-  strncpy(key, "AWS4", 4);
-  strncpy(key + 4, awsSecret, awsSecretLen);
+  memcpy(key, "AWS4", 4);
+  memcpy(key + 4, awsSecret, awsSecretLen);
 
   unsigned int len = signatureLen;
   if (HMAC(EVP_sha256(), key, keyLen, (unsigned char *)dateTime, dateTimeLen, 
dateKey, &dateKeyLen) &&

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] branch master updated: Add RAII support for ink_mutex.

2017-05-31 Thread amc 
This is an automated email from the ASF dual-hosted git repository.

amc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
   new  7dfa864   Add RAII support for ink_mutex.
7dfa864 is described below

commit 7dfa864ea7284826c345be007a8fc8ed278b9a2d
Author: Alan M. Carroll 
AuthorDate: Tue May 30 11:00:38 2017 -0500

Add RAII support for ink_mutex.
---
 lib/ts/ink_mutex.h | 23 +++
 1 file changed, 23 insertions(+)

diff --git a/lib/ts/ink_mutex.h b/lib/ts/ink_mutex.h
index d58722e..d0cd7e9 100644
--- a/lib/ts/ink_mutex.h
+++ b/lib/ts/ink_mutex.h
@@ -68,4 +68,27 @@ ink_mutex_try_acquire(ink_mutex *m)
   return pthread_mutex_trylock(m) == 0;
 }
 
+/** RAII class for locking a @c ink_mutex.
+
+@code
+ink_mutex m;
+// ...
+{
+   ink_mutex_lock lock(m);
+   // code under lock.
+}
+// code not under lock
+@endcode
+ */
+class ink_mutex_lock
+{
+private:
+  ink_mutex &_m;
+
+public:
+  ink_mutex_lock(ink_mutex *m) : _m(*m) { ink_mutex_acquire(&_m); }
+  ink_mutex_lock(ink_mutex &m) : _m(m) { ink_mutex_acquire(&_m); }
+  ~ink_mutex_lock() { ink_mutex_release(&_m); }
+};
+
 #endif /* _ink_mutex_h_ */

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] branch master updated: Clang-Tidy cleanup: Bad brace placement in ifdef'd code.

2017-05-31 Thread shinrich 
This is an automated email from the ASF dual-hosted git repository.

shinrich pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
   new  3a8a58c   Clang-Tidy cleanup: Bad brace placement in ifdef'd code.
3a8a58c is described below

commit 3a8a58c467e3b1993a64165e6fd4312b797be47d
Author: Alan M. Carroll 
AuthorDate: Wed May 31 10:16:46 2017 -0500

Clang-Tidy cleanup: Bad brace placement in ifdef'd code.
---
 lib/ts/Regex.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ts/Regex.cc b/lib/ts/Regex.cc
index 4aa3230..402aed2 100644
--- a/lib/ts/Regex.cc
+++ b/lib/ts/Regex.cc
@@ -127,10 +127,10 @@ Regex::~Regex()
   if (regex_extra) {
 #ifdef PCRE_CONFIG_JIT
 pcre_free_study(regex_extra);
-  }
 #else
 pcre_free(regex_extra);
 #endif
+  }
   if (regex) {
 pcre_free(regex);
   }

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" '].

[trafficserver] branch master updated: More NULL to nullptr conversion

2017-05-31 Thread bcall 
This is an automated email from the ASF dual-hosted git repository.

bcall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
   new  25b20bf   More NULL to nullptr conversion
25b20bf is described below

commit 25b20bfa3ce7ef914cebbd600dafe31f9d7cdb72
Author: Bryan Call 
AuthorDate: Tue May 30 21:15:09 2017 -0700

More NULL to nullptr conversion
---
 .../experimental/ats_pagespeed/ats_pagespeed.cc| 202 ++---
 proxy/http/HttpTransactCache.h |   6 +-
 proxy/logging/LogBuffer.h  |   6 +-
 proxy/logging/LogField.h   |   7 +-
 proxy/logging/LogFile.h|   4 +-
 proxy/logging/LogFormat.h  |   2 +-
 proxy/logging/LogObject.h  |   4 +-
 proxy/logging/LogUtils.h   |   8 +-
 proxy/logstats.cc  | 162 -
 9 files changed, 201 insertions(+), 200 deletions(-)

diff --git a/plugins/experimental/ats_pagespeed/ats_pagespeed.cc 
b/plugins/experimental/ats_pagespeed/ats_pagespeed.cc
index fe90fd1..25033b4 100644
--- a/plugins/experimental/ats_pagespeed/ats_pagespeed.cc
+++ b/plugins/experimental/ats_pagespeed/ats_pagespeed.cc
@@ -96,7 +96,7 @@ static int TXN_INDEX_OWNED_ARG;
 static int TXN_INDEX_OWNED_ARG_SET;
 static int TXN_INDEX_OWNED_ARG_UNSET;
 TSMutex config_mutex = TSMutexCreate();
-AtsConfig *config= NULL;
+AtsConfig *config= nullptr;
 TransformCtx *
 get_transaction_context(TSHttpTxn txnp)
 {
@@ -109,35 +109,35 @@ ats_ctx_alloc()
   TransformCtx *ctx;
 
   ctx= (TransformCtx *)TSmalloc(sizeof(TransformCtx));
-  ctx->downstream_vio= NULL;
-  ctx->downstream_buffer = NULL;
+  ctx->downstream_vio= nullptr;
+  ctx->downstream_buffer = nullptr;
   ctx->downstream_length = 0;
   ctx->state = transform_state_initialized;
 
-  ctx->base_fetch  = NULL;
-  ctx->proxy_fetch = NULL;
+  ctx->base_fetch  = nullptr;
+  ctx->proxy_fetch = nullptr;
 
-  ctx->inflater  = NULL;
-  ctx->url_string= NULL;
-  ctx->gurl  = NULL;
+  ctx->inflater  = nullptr;
+  ctx->url_string= nullptr;
+  ctx->gurl  = nullptr;
   ctx->write_pending = false;
   ctx->fetch_done= false;
   ctx->resource_request  = false;
   ctx->beacon_request= false;
   ctx->transform_added   = false;
   ctx->mps_user_agent= false;
-  ctx->user_agent= NULL;
-  ctx->server_context= NULL;
+  ctx->user_agent= nullptr;
+  ctx->server_context= nullptr;
   ctx->html_rewrite  = false;
-  ctx->request_method= NULL;
+  ctx->request_method= nullptr;
   ctx->alive = 0x;
-  ctx->options   = NULL;
-  ctx->to_host   = NULL;
+  ctx->options   = nullptr;
+  ctx->to_host   = nullptr;
   ctx->in_place  = false;
-  ctx->driver= NULL;
+  ctx->driver= nullptr;
   ctx->record_in_place   = false;
-  ctx->recorder  = NULL;
-  ctx->ipro_response_headers = NULL;
+  ctx->recorder  = nullptr;
+  ctx->ipro_response_headers = nullptr;
   ctx->serve_in_place= false;
   return ctx;
 }
@@ -149,59 +149,59 @@ ats_ctx_destroy(TransformCtx *ctx)
   CHECK(ctx->alive == 0x) << "Already dead!";
   ctx->alive = 0x;
 
-  if (ctx->base_fetch != NULL) {
+  if (ctx->base_fetch != nullptr) {
 ctx->base_fetch->Release();
-ctx->base_fetch = NULL;
+ctx->base_fetch = nullptr;
   }
 
-  if (ctx->proxy_fetch != NULL) {
+  if (ctx->proxy_fetch != nullptr) {
 ctx->proxy_fetch->Done(false /* failure */);
-ctx->proxy_fetch = NULL;
+ctx->proxy_fetch = nullptr;
   }
 
-  if (ctx->inflater != NULL) {
+  if (ctx->inflater != nullptr) {
 delete ctx->inflater;
-ctx->inflater = NULL;
+ctx->inflater = nullptr;
   }
 
   if (ctx->downstream_buffer) {
 TSIOBufferDestroy(ctx->downstream_buffer);
   }
 
-  if (ctx->url_string != NULL) {
+  if (ctx->url_string != nullptr) {
 delete ctx->url_string;
-ctx->url_string = NULL;
+ctx->url_string = nullptr;
   }
 
-  if (ctx->gurl != NULL) {
+  if (ctx->gurl != nullptr) {
 delete ctx->gurl;
-ctx->gurl = NULL;
+ctx->gurl = nullptr;
   }
-  if (ctx->user_agent != NULL) {
+  if (ctx->user_agent != nullptr) {
 delete ctx->user_agent;
-ctx->user_agent = NULL;
+ctx->user_agent = nullptr;
   }
-  ctx->request_method = NULL;
-  if (ctx->options != NULL) {
+  ctx->request_method = nullptr;
+  if (ctx->options != nullptr) {
 delete ctx->options;
-ctx->options = NULL;
+ctx->options = nullptr;
   }
-  if (ctx->to_host != NULL) {
+  if (ctx->to_host != nullptr) {
 delete ctx->to_h

[trafficserver] branch master updated: Remove useless name from ink_mutex_init.

2017-05-31 Thread amc 
This is an automated email from the ASF dual-hosted git repository.

amc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
   new  c6b7270   Remove useless name from ink_mutex_init.
c6b7270 is described below

commit c6b7270588687bcd2b2fa9c16c1a59d4bef1b15b
Author: Alan M. Carroll 
AuthorDate: Tue May 30 11:00:57 2017 -0500

Remove useless name from ink_mutex_init.
---
 iocore/aio/AIO.cc | 4 ++--
 iocore/eventsystem/I_Lock.h   | 2 +-
 iocore/eventsystem/P_ProtectedQueue.h | 2 +-
 iocore/eventsystem/P_UnixEventProcessor.h | 2 +-
 iocore/net/OCSPStapling.cc| 2 +-
 iocore/net/SSLConfig.cc   | 2 +-
 iocore/net/SSLDynlock.cc  | 2 +-
 iocore/net/SSLUtils.cc| 2 +-
 lib/records/RecConfigParse.cc | 2 +-
 lib/records/RecCore.cc| 2 +-
 lib/records/RecMutex.cc   | 4 ++--
 lib/records/RecProcess.cc | 2 +-
 lib/records/RecRawStats.cc| 2 +-
 lib/ts/Diags.cc   | 2 +-
 lib/ts/EventNotify.cc | 2 +-
 lib/ts/ink_mutex.cc   | 2 +-
 lib/ts/ink_mutex.h| 2 +-
 lib/ts/ink_rwlock.cc  | 2 +-
 lib/ts/llqueue.cc | 2 +-
 mgmt/Alarms.cc| 2 +-
 mgmt/FileManager.cc   | 4 ++--
 mgmt/Rollback.cc  | 2 +-
 mgmt/api/EventCallback.cc | 4 ++--
 mgmt/api/EventControlMain.cc  | 2 +-
 mgmt/utils/MgmtHashTable.h| 4 ++--
 proxy/InkIOCoreAPI.cc | 2 +-
 proxy/http/HttpBodyFactory.cc | 2 +-
 proxy/http/HttpConnectionCount.h  | 2 +-
 proxy/http/HttpProxyServerMain.cc | 4 ++--
 proxy/logging/LogBuffer.cc| 2 +-
 proxy/logging/LogObject.cc| 2 +-
 31 files changed, 37 insertions(+), 37 deletions(-)

diff --git a/iocore/aio/AIO.cc b/iocore/aio/AIO.cc
index cc084b5..13f22cf 100644
--- a/iocore/aio/AIO.cc
+++ b/iocore/aio/AIO.cc
@@ -158,7 +158,7 @@ ink_aio_init(ModuleVersion v)
  (int)AIO_STAT_KB_WRITE_PER_SEC, aio_stats_cb);
 #if AIO_MODE != AIO_MODE_NATIVE
   memset(&aio_reqs, 0, MAX_DISKS_POSSIBLE * sizeof(AIO_Reqs *));
-  ink_mutex_init(&insert_mutex, nullptr);
+  ink_mutex_init(&insert_mutex);
 #endif
   REC_ReadConfigInteger(cache_config_threads_per_disk, 
"proxy.config.cache.threads_per_disk");
 #if TS_USE_LINUX_NATIVE_AIO
@@ -228,7 +228,7 @@ aio_init_fildes(int fildes, int fromAPI = 0)
   INK_WRITE_MEMORY_BARRIER;
 
   ink_cond_init(&request->aio_cond);
-  ink_mutex_init(&request->aio_mutex, nullptr);
+  ink_mutex_init(&request->aio_mutex);
   ink_atomiclist_init(&request->aio_temp_list, "temp_list", (uintptr_t) & 
((AIOCallback *)nullptr)->link);
 
   RecInt thread_num;
diff --git a/iocore/eventsystem/I_Lock.h b/iocore/eventsystem/I_Lock.h
index 7291393..2e3c54c 100644
--- a/iocore/eventsystem/I_Lock.h
+++ b/iocore/eventsystem/I_Lock.h
@@ -270,7 +270,7 @@ public:
   void
   init(const char *name = "UnnamedMutex")
   {
-ink_mutex_init(&the_mutex, name);
+ink_mutex_init(&the_mutex);
   }
 };
 
diff --git a/iocore/eventsystem/P_ProtectedQueue.h 
b/iocore/eventsystem/P_ProtectedQueue.h
index a0b5fbc..af2d741 100644
--- a/iocore/eventsystem/P_ProtectedQueue.h
+++ b/iocore/eventsystem/P_ProtectedQueue.h
@@ -36,7 +36,7 @@ TS_INLINE
 ProtectedQueue::ProtectedQueue()
 {
   Event e;
-  ink_mutex_init(&lock, "ProtectedQueue");
+  ink_mutex_init(&lock);
   ink_atomiclist_init(&al, "ProtectedQueue", (char *)&e.link.next - (char 
*)&e);
   ink_cond_init(&might_have_data);
 }
diff --git a/iocore/eventsystem/P_UnixEventProcessor.h 
b/iocore/eventsystem/P_UnixEventProcessor.h
index 1f18ed7..b35938e 100644
--- a/iocore/eventsystem/P_UnixEventProcessor.h
+++ b/iocore/eventsystem/P_UnixEventProcessor.h
@@ -36,7 +36,7 @@ EventProcessor::EventProcessor() : n_ethreads(0), 
n_thread_groups(0), n_dthreads
   memset(all_dthreads, 0, sizeof(all_dthreads));
   memset(n_threads_for_type, 0, sizeof(n_threads_for_type));
   memset(next_thread_for_type, 0, sizeof(next_thread_for_type));
-  ink_mutex_init(&dedicated_spawn_thread_mutex, 
"EventProcessorDedicatedThreadSpawn");
+  ink_mutex_init(&dedicated_spawn_thread_mutex);
 }
 
 TS_INLINE off_t
diff --git a/iocore/net/OCSPStapling.cc b/iocore/net/OCSPStapling.cc
index a20d7af..0036e26 100644
--- a/iocore/net/OCSPStapling.cc
+++ b/iocore/net/OCSPStapling.cc
@@ -141,7 +141,7 @@ ssl_stapling_init_cert(SSL_CTX *ctx, X509 *cert, const char 
*certname)
   cinf->uri = nullptr;
   cinf->certname= ats_strdup(certname);
   cinf->resp_derlen = 0;
-  ink_mutex_init(&cinf->stapling_mutex, "stapling_mutex");
+  ink_mutex_init(&cinf->stapling_mutex);
   cinf->is_expire   = tr