[GitHub] [incubator-tvm] alexgl-github commented on issue #4775: conv3d_ndhwc schedule

2020-01-28 Thread GitBox
alexgl-github commented on issue #4775: conv3d_ndhwc schedule
URL: https://github.com/apache/incubator-tvm/pull/4775#issuecomment-579536676
 
 
   @apivovarov 
   @anijain2305 
   Could you please review again?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-tvm] alexgl-github commented on issue #4775: conv3d_ndhwc schedule

2020-01-29 Thread GitBox
alexgl-github commented on issue #4775: conv3d_ndhwc schedule
URL: https://github.com/apache/incubator-tvm/pull/4775#issuecomment-579823237
 
 
   > @alexgl-github Thanks for the contribution.
   > 
   > Almost every PR needs to have a test case in Apache TVM project. In this 
case, it can be a test case that uses this schedule and compares accuracy with 
some golden reference.
   
   There's already topi conv3d_ndhwc test using this schedule:
   
https://github.com/apache/incubator-tvm/blob/1b8522e475e9a889b80f069a83928cafa3502a74/topi/tests/python/test_topi_conv3d_ndhwc.py#L60


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services