[GitHub] [incubator-tvm] huajsj edited a comment on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack.
huajsj edited a comment on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack. URL: https://github.com/apache/incubator-tvm/pull/4703#issuecomment-574325187 Hi Liangfu, Thanks for the comments, the reason here to use operator name and indices is to first compatible with existing implementation like resnet18 example, secondly try to make the logic to be more readable for that from my point operator name is more friendly than indices only. please kindly let me know how you think. Regards Hua > This is a favorable feature, since there could be more than one operator with the given name. > > I wonder whether we can bring the unique name of the layer, instead of the name of the operator, to define the subgraph. I think using indices of the named operators are less intuitive, comparing to unique names of the layers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] huajsj edited a comment on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack.
huajsj edited a comment on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack. URL: https://github.com/apache/incubator-tvm/pull/4703#issuecomment-575405296 > I suggest we can follow a two-pass approach. For the first pass, get a list of named operator occurrence; then locate the subgraph by counting operator occurrence. Hi @liangfu , I try this feature couple times, and feel the way to count operator occurrence times is not very convenience, and using the index directly is more straight forward and efficiency, the two-pass way may work but that add additional logic and make the solution too heavy, I would recommend to keep current one pass logic. Regards Hua This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] huajsj edited a comment on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack.
huajsj edited a comment on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack. URL: https://github.com/apache/incubator-tvm/pull/4703#issuecomment-577340014 > Thank you @huajsj for addressing the comments. Is there a reason why we are defaulting to -1? Wouldn't that change the way we currently invoke graph_pack in our VTA examples? Hi @tmoreau89 , thanks for the reply, the new solution use operator index instead of name replicate time to determine where is start/stop, hence 0 is a meaning value and can not as default value anymore, and i use -1 as the default value means skip index check. this change no need any invoke/change for graph_pack in our VTA examples. Regards Hua This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
