[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5838: [Target] Introduce Target Id Registry
junrushao1994 commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646908749 Future work may include: 1) Refactor the object `TargetNode` 2) Allow `Target` to be a special type supported in schema validation, so that composite/recursive targets can be supported more naturally 3) Support constructing `TargetNode` from JSON This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5838: [Target] Introduce Target Id Registry
junrushao1994 commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646905854 @tqchen Just added support for `target_host`, and right now are can support validating the entire map directly via `TargetValidateSchema` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5838: [Target] Introduce Target Id Registry
junrushao1994 commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646887809 @tqchen As far as I could understand, we need validation twice, one for target, one for target_host. Therefore, the step-by-step procedure should be: 1) Let "target" map be the given map removing "target_host" entry 2) Figure out the "id" entry in "target" 3) Validate "target" using the TargetId indicated by "id" 4) Validate "target_host" in the same way. Is that correct? BTW, why the schema of cuda doesn't include "libs" and "tag"? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5838: [Target] Introduce Target Id Registry
junrushao1994 commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646870388 @tqchen could you take another look? Changes - Added schema validation - Added several tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5838: [Target] Introduce Target Id Registry
junrushao1994 commented on pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#issuecomment-646791046 Thank you @ANSHUMAN87 for the review! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
