[GitHub] [incubator-tvm] tqchen commented on issue #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

2020-01-14 Thread GitBox
tqchen commented on issue #4684: [Arith] add ShapeVar representing non-neg 
valued variable in a tensor shape
URL: https://github.com/apache/incubator-tvm/pull/4684#issuecomment-574380538
 
 
   We can ask other's thoughts about it(perhaps list a few candidates and send 
an rfc?). TIndex seems to be a reasonable name, although it is a bit ambiguous 
because people need to guess what does T mean). 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-tvm] tqchen commented on issue #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

2020-01-14 Thread GitBox
tqchen commented on issue #4684: [Arith] add ShapeVar representing non-neg 
valued variable in a tensor shape
URL: https://github.com/apache/incubator-tvm/pull/4684#issuecomment-574285396
 
 
   I don't have a better idea for name. Indeed shape could indicate a tuple 
rather than an integer. 
   
   We could potentially rename the relay's shape template variable for clarity 
as it is really type var. But we could think about a better name.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services