[GitHub] [incubator-tvm] tqchen edited a comment on issue #4769: [TOPI] Remove cpp upsampling and resize op
tqchen edited a comment on issue #4769: [TOPI] Remove cpp upsampling and resize op URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577874461 Hmm, i hear you. I think the nature of “need to adding new features” marks the op unstable, thus merit a python version as the primary one. On the other hand, for most of the numpy style ops, whose interface are stable, it makes sense to encourage c++ version and use that as default(while removing the python version) In both cases, for each op there is one primary language for the op, depending on the status. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #4769: [TOPI] Remove cpp upsampling and resize op
tqchen edited a comment on issue #4769: [TOPI] Remove cpp upsampling and resize op URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577874461 Hmm, i hear you. I think the nature of “need to adding new features” marks the op unstable, thus merit a python version as the primary one. On the other hand, for most of the numpy style ops, whose interface are stable, it makes sense to encourage c++ version and use that as default(while removing the python version) In both cases, for each op there is one primary language for the op, depending on the status. And we can remove the other one This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #4769: [TOPI] Remove cpp upsampling and resize op
tqchen edited a comment on issue #4769: [TOPI] Remove cpp upsampling and resize op URL: https://github.com/apache/incubator-tvm/pull/4769#issuecomment-577921569 We can have another discussion thread about the scope of ops that goes to cxx. My current take is that the decision will likely be made as per group basis, eg all numpy ops could goes to c++ as numpy interface is pretty stable. The same rule applies to schedule, so if a compute is stable but schedule is not, we can keep the schedule in py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
