[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD)
yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD) URL: https://github.com/apache/incubator-tvm/pull/4651#issuecomment-587540016 @tqchen, this PR has been clear for a week. It still needs uploading three static images for the tutorial. Can you help moving it forward? Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD)
yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD) URL: https://github.com/apache/incubator-tvm/pull/4651#issuecomment-584702130 The PR is clear from building/testing failures, after qualifying with @Hzfengsy's help on tutorial. I am attaching the three static images used by the tutorial. If there is no more comments for me to address, can someone help uploading them as: https://github.com/dmlc/web-data/raw/master/tvm/tutorial/tedd_itervar_rel.png, https://github.com/dmlc/web-data/raw/master/tvm/tutorial/tedd_dfg.png, and https://github.com/dmlc/web-data/raw/master/tvm/tutorial/tedd_st.png? Thanks    This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD)
yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD) URL: https://github.com/apache/incubator-tvm/pull/4651#issuecomment-584163670 @tqchen, @Hzfengsy I have updated this PR with changes listed in the forum: https://discuss.tvm.ai/t/visualize-tensor-expression/5174/12?u=maplegu Two questions about the tutorial: 1. As graphviz is not always available in CI. Shall I use static images in the tutorial? If so, my current submission uses image locations such as https://github.com/dmlc/web-data/raw/master/tvm/tutorial/tedd_st.png. I haven't committed any image yet. Is it a good location? 2. I would like to inspect the rendered tutorial. How to view it in my repo? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD)
yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD) URL: https://github.com/apache/incubator-tvm/pull/4651#issuecomment-578845333 > > Thanks @yongfeng-nv . One thing that I think worth considering, as in many viz tools, is the separation of visualization data source specification(in this case the perhaps a dom tree or similar kind) from the visualization(graphviz). > > We can have a tool that extracts the spec into json, then have a tool to take that spec and visualize it > > @tqchen, I see your point. Let me spec the data source spec. @tqchen, @Hzfengsy, I have posted proposal DOM tree in the RFC thread: https://discuss.tvm.ai/t/visualize-tensor-expression/5174/6. Please leave your comments and suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD)
yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD) URL: https://github.com/apache/incubator-tvm/pull/4651#issuecomment-574416251 > Thanks @yongfeng-nv . One thing that I think worth considering, as in many viz tools, is the separation of visualization data source specification(in this case the perhaps a dom tree or similar kind) from the visualization(graphviz). > > We can have a tool that extracts the spec into json, then have a tool to take that spec and visualize it @tqchen, I see your point. Let me spec the data source spec. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD)
yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD) URL: https://github.com/apache/incubator-tvm/pull/4651#issuecomment-572148284 One question about test failure: https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-4651/2/pipeline > E ModuleNotFoundError: No module named 'graphviz' It fails, because tedd depends on graphviz, but tvmai/ci-cpu:v0.54 doesn't have it. How to fix this issue? Let ci-cpu install graphviz as ci-gpu? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD)
yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD) URL: https://github.com/apache/incubator-tvm/pull/4651#issuecomment-571895493 @Hzfengsy, could you help reviewing this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
