[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4931: Tighten split's extent
yongfeng-nv commented on issue #4931: Tighten split's extent URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-596866979 > This PR is among one of the PRs affected by the github squash commit bug. We take every contribution serious in the TVM community. The community has decided to use revert/redo approach to amend the contributions as per #5015 > > @yongfeng-nv Please let us know if you would like us to revert the PR and resend the contribution. Thank you. cc @merrymercy @tqchen Sure. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4931: Tighten split's extent
yongfeng-nv commented on issue #4931: Tighten split's extent URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-594748097 @merrymercy, I have made your recommended changes. Please review it again. Can you share your use case hitting this issue? @tqchen, the flaky test finally passed. Thank you for the help. Please double check the logic of this PR and share your thoughts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4931: Tighten split's extent
yongfeng-nv commented on issue #4931: Tighten split's extent URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-594306992 I need some help to reproduce the failure locally. I tried the CI twice and both ended with the same failure (e.g. https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-4931/9/pipeline/). But neither I or fellow engineer was able to reproduce the failure on our local machines. Any suggestion? I don't mind adding a few temporary debugging dumping code to my change and the test, but the test is the very last one in the entire CI and takes 2-3 hours to reach. Is there any way to get me quickly to this test in CI? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4931: Tighten split's extent
yongfeng-nv commented on issue #4931: Tighten split's extent URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-592769137 I don't understand the current failure: https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-4931/7/pipeline. How do I handle it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4931: Tighten split's extent
yongfeng-nv commented on issue #4931: Tighten split's extent URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-592591273 > Use const reference when possible. > The logic looks good to me. > cc @tqchen for double check. Thank you for the careful review. I forgot to check references after refactoring. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4931: Tighten split's extent
yongfeng-nv commented on issue #4931: Tighten split's extent URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-591127743 @merrymercy, I have updated this PR description and refactor the code. All tests are clear. Please review it. Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
