Lunderberg commented on PR #12607:
URL: https://github.com/apache/tvm/pull/12607#issuecomment-1227887259
Cool, cool! I wasn't sure if there were other benefits to the macro that I
had been missing, and wanted to be careful about breakage when tromping on a
less familiar part of the codebase.
Regarding inlining, my understanding is that lambdas can always be inlined
by the as-if rule, and their limited scope usually lets the compiler be more
aggressive about inlining than for normal functions. I hadn't ever verified
this from the assembly before, but a couple of quick godbolt comparisons
([function call not marked inline](https://godbolt.org/z/njG1fK6oz), [function
call marked inline](https://godbolt.org/z/f1W6P87zT), [immediately invoked
lambda](https://godbolt.org/z/G7cn1nevK)) confirm that lambdas can be inlined
with the same gcc version/optimization settings as are used on TVM's CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
