[GitHub] [tvm] codeislife99 commented on pull request #7149: Sparse segment sum sqrtn op
codeislife99 commented on pull request #7149: URL: https://github.com/apache/tvm/pull/7149#issuecomment-790927682 This functionality and the discussion has been addressed in #7562 . Closing this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tvm] codeislife99 commented on pull request #7149: Sparse segment sum sqrtn op
codeislife99 commented on pull request #7149: URL: https://github.com/apache/tvm/pull/7149#issuecomment-753730025 @tkonolige @mbrookhart Can I get a re-review on this PR ? I have added the TF Frontend code and some more documentation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tvm] codeislife99 commented on pull request #7149: Sparse segment sum sqrtn op
codeislife99 commented on pull request #7149: URL: https://github.com/apache/tvm/pull/7149#issuecomment-753729768 Context of these PRs: The goal of adding these sparse ops is to enable a customer to run their recommendation model which is currently getting split into multiple subgraphs because of our non-coverage of this op. I had an offline discussion with the main reviewers but I will also try to summarize the conclusions from it and the comments here: 1. New namespace : Further discussion will be had in a separate thread, after the current (this one included) sparse ops PRs are merged, since there are a few already existing sparse ops without the namespace and if a new namespace is necessary all the current + previous sparse ops will be put in it. 2. Documentation : More documentation has been added 3. High level Approach like XLA: Discussion in a separate thread 4. This operation is TF specific. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
