[GitHub] [tvm] jcf94 commented on pull request #7146: [CUDA]batch_matmul tensorcore schedule

2020-12-24 Thread GitBox 


jcf94 commented on pull request #7146:
URL: https://github.com/apache/tvm/pull/7146#issuecomment-750862121


   Thanks! @Laurawly @merrymercy 
   I think it's fine to fix them in a new PR.
   
   @Meteorix If we're not going to finish these here, you can add some TODO 
comments in the code and create a new issue for tracking. Please fix the CI 
problem and we can merge this.
   #7147 is also fine, just need to add some unit tests for these modifications.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tvm] jcf94 commented on pull request #7146: [CUDA]batch_matmul tensorcore schedule

2020-12-21 Thread GitBox 


jcf94 commented on pull request #7146:
URL: https://github.com/apache/tvm/pull/7146#issuecomment-749364296


   @Meteorix, great thanks for your PR! The code looks good to me.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org