[GitHub] [tvm] tqchen commented on pull request #7152: [RUNTIME] Improve error messages for TypedPackedFunc

2021-01-26 Thread GitBox 


tqchen commented on pull request #7152:
URL: https://github.com/apache/tvm/pull/7152#issuecomment-767892174


   @junrushao1994 please take another look and manage the PR. 
   @tkonolige Thanks for keep improving the code through the reviewing process.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #7152: [RUNTIME] Improve error messages for TypedPackedFunc

2021-01-06 Thread GitBox 


tqchen commented on pull request #7152:
URL: https://github.com/apache/tvm/pull/7152#issuecomment-755459243


   Taking a closer look, i think we need to put more thoughts into it to make 
sure that the addition of name is optional, and we can get close to zero 
overhead in building these functions.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org