[GitHub] [tvm] wzh99 commented on pull request #12596: [TOPI][Bugfix] Make semantics of empty `axis` in `squeeze` consistent with Relay

2022-08-25 Thread GitBox 


wzh99 commented on PR #12596:
URL: https://github.com/apache/tvm/pull/12596#issuecomment-1227923546

   @masahi I have pushed the commits, including the new test case and `llvm` 
target. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tvm] wzh99 commented on pull request #12596: [TOPI][Bugfix] Make semantics of empty `axis` in `squeeze` consistent with Relay

2022-08-25 Thread GitBox 


wzh99 commented on PR #12596:
URL: https://github.com/apache/tvm/pull/12596#issuecomment-1227911554

   @masahi Of course. It seems that I should add the test here:
   
https://github.com/apache/tvm/blob/a9f7c32e42a5f09e641dbe83f81cc4a73869af12/tests/python/topi/python/test_topi_transform.py#L943-L948
   I have prepared the test case `verify_squeeze((1, 1, 1, 1), ())` to see 
whether TOPI correctly handles empty axis. However, I have a problem with this 
testing function before pushing the commit: Why is it decorated with 
`@tvm.testing.requires_gpu`, instead of `@tvm.testing.uses_gpu` as the other 
testing functions in this file? In other words, can it run on a CPU-only 
target? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org