[GitHub] incubator-weex issue #732: [jsfm] Sync the source code of weex-js-framework@...

2017-09-25 Thread Hanks10100
Github user Hanks10100 commented on the issue:

https://github.com/apache/incubator-weex/pull/732
  
The error in the CI is caused by `danger-jsfm.js` 
https://travis-ci.org/apache/incubator-weex/jobs/279396420#L1395 , all tests of 
jsfm and sdk are passed.


---


[2/2] incubator-weex git commit: * [jsfm] upgrade weex-js-framework to 0.22.4

2017-09-25 Thread gurisxie
* [jsfm] upgrade weex-js-framework to 0.22.4


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/0faa131c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/0faa131c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/0faa131c

Branch: refs/heads/0.16-dev
Commit: 0faa131c7507b080765407137455678f8b50d806
Parents: 0e9760a
Author: Hanks 
Authored: Mon Sep 25 11:58:13 2017 +0800
Committer: Hanks 
Committed: Mon Sep 25 11:58:13 2017 +0800

--
 pre-build/native-bundle-main.js | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)
--




[GitHub] incubator-weex pull request #738: * [jsfm] upgrade weex-js-framework to 0.22...

2017-09-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/738


---


[1/2] incubator-weex git commit: * [jsfm] upgrade weex-js-framework to 0.22.4

2017-09-25 Thread gurisxie
Repository: incubator-weex
Updated Branches:
  refs/heads/0.16-dev 0e9760ac6 -> 0faa131c7


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/0faa131c/pre-build/native-bundle-main.js
--
diff --git a/pre-build/native-bundle-main.js b/pre-build/native-bundle-main.js
index 70f4b57..d43b6ec 100644
--- a/pre-build/native-bundle-main.js
+++ b/pre-build/native-bundle-main.js
@@ -1,8 +1,8 @@
-(this.nativeLog||function(e){console.log(e)})("START JS FRAMEWORK 0.22.3, 
Build 2017-09-21 19:05."),this.getJSFMVersion=function(){return"0.22.3"};var 
global=this,process={env:{}},setTimeout=global.setTimeout;!function(e,t){"object"==typeof
 exports&&"undefined"!=typeof module?t():"function"==typeof 
define&&define.amd?define(t):t()}(0,function(){"use strict";function 
e(e){Hn.Document=e.Document,Hn.Element=e.Element,Hn.Comment=e.Comment,Hn.sendTasks=e.sendTasks}function
 t(e,t,n,r,o){void 0===n&&(n={}),void 0===r&&(r={}),void 0===o&&(o={});var 
i=new 
Hn.Document(e,n.bundleUrl),a={},s={id:e,data:r,document:i,callbacks:a},u=0;i.addCallback=function(e){return
 u++,a[u]=e,u},i.handleCallback=function(e,t,n){var r=a[e];return n&&delete 
a[e],r(t)},Gn[e]=s;var 
c=Object.assign({Document:Hn.Document,Element:Hn.Element,Comment:Hn.Comment,sendTasks:function(t){return
 Hn.sendTasks(e,t,-1)},options:n,document:i},o),l=[],f=[];for(var p in 
c)l.push(p),f.push(c[p]);return l.push(t),(new(Function.prototy
 pe.bind.apply(Function,[null].concat(l.apply(void 
0,f),Hn.sendTasks(e,[{module:"dom",method:"createFinish",args:[]}],-1),s}function
 n(e){delete Gn[e]}function r(e){return Gn[e].document.body.toJSON()}function 
o(e,t){var n={fireEvent:function(e,t,n,r,o){var 
i=Gn[e],a=i.document,s=a.getRef(t);return 
a.fireEvent(s,n,r,o)},callback:function(e,t,n,r){return 
Gn[e].document.handleCallback(t,n,r)}};if((Gn[e]||{}).document&&Array.isArray(t)){var
 r=[];return t.forEach(function(t){var 
o=n[t.method],i=[].concat(t.args);"function"==typeof 
o&&(i.unshift(e),r.push(o.apply(void 0,i)))}),r}}function i(e){return 
e&&e.__esModule?e.default:e}function a(e,t){return 
t={exports:{}},e(t,t.exports),t.exports}function s(e){console.warn("[JS 
Framework] Vm#$ is deprecated, please use Vm#$vm instead");var 
t=this._ids[e];if(t)return t.vm}function u(e){var t=this._ids[e];if(t)return 
t.el}function c(e){var t=this._ids[e];if(t)return t.vm}function l(e){return 
this._app.differ.then(function(){e()})}function f(e,
 t){console.warn("[JS Framework] Vm#$scrollTo is deprecated, please use 
\"require('@weex-module/dom').scrollTo(el, options)\" instead");var 
n=this.$el(e);if(n){this._app.requireModule("dom").scrollToElement(n.ref,{offset:t})}}function
 p(e,t,n){var 
r=this,o=this.$el(e);if(o&&t&&t.styles){this._app.requireModule("animation").transition(o.ref,t,function(){for(var
 
e=[],i=arguments.length;i--;)e[i]=arguments[i];r._setStyle(o,t.styles),n&&n.apply(void
 0,e)})}}function d(e){var t=this._app.options;return"function"==typeof 
e&&(console.warn("[JS Framework] the callback of Vm#$getConfig(callback) is 
deprecated, this api now can directly RETURN config info."),e(t)),t}function 
h(e,t){console.warn("[JS Framework] Vm#$sendHttp is deprecated, please use 
\"require('@weex-module/stream').sendHttp(params, callback)\" 
instead"),this._app.requireModule("stream").sendHttp(e,t)}function 
v(e){console.warn("[JS Framework] Vm#$openURL is deprecated, please use 
\"require('@weex-module/event').openURL(url)\" i
 nstead"),this._app.requireModule("event").openURL(e)}function 
y(e){console.warn("[JS Framework] Vm#$setTitle is deprecated, please use 
\"require('@weex-module/pageInfo').setTitle(title)\" 
instead"),this._app.requireModule("pageInfo").setTitle(e)}function 
m(e,t){for(var n=[],r=arguments.length-2;r-- 
>0;)n[r]=arguments[r+2];console.warn("[JS Framework] Vm#$call is deprecated, 
please use \"require('@weex-module/moduleName')\" instead");var 
o=this._app.requireModule(e);o&&o[t]&&o[t].apply(o,n)}function _(e){for(var 
t=[],n=arguments.length-1;n-- >0;)t[n]=arguments[n+1];if("function"==typeof 
Object.assign)Object.assign.apply(Object,[e].concat(t));else{var 
r=t.shift();for(var o in r)e[o]=r[o];t.length&&_.apply(void 
0,[e].concat(t))}return e}function 
g(e,t,n,r){Object.defineProperty(e,t,{value:n,enumerable:!!r,writable:!0,configurable:!0})}function
 b(e,t){if(e.length){var n=e.indexOf(t);if(n>-1)return e.splice(n,1)}}function 
w(e,t){return hr.call(e,t)}function x(e,t){return function(n){var 
 r=arguments.length;return 
r?r>1?e.apply(t,arguments):e.call(t,n):e.call(t)}}function E(e){return 
null!==e&&"object"==typeof e}function O(e){return vr.call(e)===yr}function 
S(e){var t=(e+"").charCodeAt(0);return 36===t||95===t}function 
C(){return"object"==typeof nativeSet?nativeSet.create():new Jn}function 
k(e){var t=Object.prototype.toString.call(e);return 
t.substring(8,t.length-1).toLowerCase()}function j(e){return 
e.replace(_r,"").replace(gr,"")}function A(e){return e.

[GitHub] incubator-weex pull request #739: * [ios] try to fix crash problem

2017-09-25 Thread acton393
GitHub user acton393 opened a pull request:

https://github.com/apache/incubator-weex/pull/739

* [ios] try to fix crash problem

1. fix text crash
2. fix remove onclick event crash
3. fix compiler warnings

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/acton393/incubator-weex 0.16-dev

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/739.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #739


commit 8fff8cd813ee3bf269c4bc527261399d1536d8b4
Author: acton393 
Date:   2017-09-25T06:46:40Z

* [ios] try to fix remove gesture crash

commit 3073616241569dda71481150629b1eda58bc74ef
Author: acton393 
Date:   2017-09-25T06:47:15Z

* [ios] fix compiler warnings

commit 9fe39ad707e6c433cb5ce40e8c2126c2d5a1faac
Author: acton393 
Date:   2017-09-25T07:29:08Z

* [ios] try to fix text init crash




---


[GitHub] incubator-weex issue #739: * [ios] try to fix crash problem

2017-09-25 Thread weex-bot
Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/739
  





  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  

  :warning:
  This PR should update related documents as well. 

  




  

  
  Messages

  
  
  :book:
  According to the blame info, we recommended @cxfeng1 , @boboning 
to be the reviewers.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS




---


[GitHub] incubator-weex pull request #737: * [html5] update start command for develop

2017-09-25 Thread erha19
GitHub user erha19 reopened a pull request:

https://github.com/apache/incubator-weex/pull/737

* [html5] update start  command for develop

Update start  command for develop。

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/erha19/incubator-weex dev

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/737.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #737


commit ab9ef1b24f65fd7f8edb858556d103f5e08634eb
Author: erha19 
Date:   2017-09-22T09:03:33Z

* [html5] update start  command for develop




---


[GitHub] incubator-weex pull request #737: * [html5] update start command for develop

2017-09-25 Thread erha19
Github user erha19 closed the pull request at:

https://github.com/apache/incubator-weex/pull/737


---


[GitHub] incubator-weex issue #737: * [html5] update start command for develop

2017-09-25 Thread weex-bot
Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/737
  





  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  




  

  
  Messages

  
  
  :book:
  According to the blame info, we recommended @luics , @Jinjiang to 
be the reviewers.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS




---


[GitHub] incubator-weex pull request #740: * [android] fix the NPE that caused by tra...

2017-09-25 Thread misakuo
GitHub user misakuo opened a pull request:

https://github.com/apache/incubator-weex/pull/740

* [android] fix the NPE that caused by tracing



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/misakuo/incubator-weex 
android-bugfix-tracing-npe

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/740.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #740


commit ae69e1e8d83b5a51bf097432faab35d539048a6b
Author: misakuo 
Date:   2017-09-25T09:17:27Z

+ [android] fix npe caused by tracing




---


incubator-weex git commit: + [android] fix npe caused by tracing

2017-09-25 Thread misakuo
Repository: incubator-weex
Updated Branches:
  refs/heads/0.16-dev 0faa131c7 -> ae69e1e8d


+ [android] fix npe caused by tracing


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/ae69e1e8
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/ae69e1e8
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/ae69e1e8

Branch: refs/heads/0.16-dev
Commit: ae69e1e8d83b5a51bf097432faab35d539048a6b
Parents: 0faa131
Author: misakuo 
Authored: Mon Sep 25 17:17:27 2017 +0800
Committer: misakuo 
Committed: Mon Sep 25 17:17:27 2017 +0800

--
 .../weex/dom/action/AbstractAddElementAction.java   | 12 
 1 file changed, 8 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/ae69e1e8/android/sdk/src/main/java/com/taobao/weex/dom/action/AbstractAddElementAction.java
--
diff --git 
a/android/sdk/src/main/java/com/taobao/weex/dom/action/AbstractAddElementAction.java
 
b/android/sdk/src/main/java/com/taobao/weex/dom/action/AbstractAddElementAction.java
index 3d026ee..9f35263 100644
--- 
a/android/sdk/src/main/java/com/taobao/weex/dom/action/AbstractAddElementAction.java
+++ 
b/android/sdk/src/main/java/com/taobao/weex/dom/action/AbstractAddElementAction.java
@@ -49,9 +49,11 @@ public abstract class AbstractAddElementAction extends 
TraceableAction implement
 }
 long startNanos = System.nanoTime();
 WXComponent component = 
WXComponentFactory.newInstance(context.getInstance(), dom, parent);
-component.mTraceInfo.domThreadStart = dom.mDomThreadTimestamp;
-component.mTraceInfo.rootEventId = mTracingEventId;
-component.mTraceInfo.domQueueTime = mDomQueueTime;
+if (component != null) {
+  component.mTraceInfo.domThreadStart = dom.mDomThreadTimestamp;
+  component.mTraceInfo.rootEventId = mTracingEventId;
+  component.mTraceInfo.domQueueTime = mDomQueueTime;
+}
 
 context.registerComponent(dom.getRef(), component);
 if (component instanceof WXVContainer) {
@@ -65,7 +67,9 @@ public abstract class AbstractAddElementAction extends 
TraceableAction implement
 }
   }
 }
-component.mTraceInfo.domThreadNanos = System.nanoTime() - startNanos;
+if (component != null) {
+  component.mTraceInfo.domThreadNanos = System.nanoTime() - startNanos;
+}
 return component;
   }
 



[GitHub] incubator-weex issue #740: * [android] fix the NPE that caused by tracing

2017-09-25 Thread weex-bot
Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/740
  






  

  
  Messages

  
  
  :book:
  has no jsfm file changed,skip test!

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS




---


[GitHub] incubator-weex pull request #740: * [android] fix the NPE that caused by tra...

2017-09-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/740


---


[GitHub] incubator-weex pull request #737: * [html5] update start command for develop

2017-09-25 Thread erha19
Github user erha19 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/737#discussion_r140725582
  
--- Diff: doc/source/cn/guide/set-up-env.md ---
@@ -28,26 +28,26 @@ brew install node
 
 ```bash
 $ node -v
-v6.3.1
+v6.11.3
 $ npm -v
-3.10.3
+3.10.10
 ```
 
 通常,安装了 Node.js 环境,npm 包管理工具也随之安装
了。因此,直接使用 npm 来安装 weex-toolkit。
 
 > npm 是一个 JavaScript 包管理工具,它可以让开发者轻松å…
±äº«å’Œé‡ç”¨ä»£ç ã€‚Weex 很多依赖来自社区,同样,Weex 
也将很多工具发布到社区方便开发者使用。
 
-**注意: ** weex-toolkit 在 1.0.1 之后才支持初始化 Vue 
项目,使用前请确认版本是否正确。
+**注意: ** 在`weex-toolkit`1.0.8版本后添加
了npm5规范的`npm-shrinkwrap.json`用于锁定包依赖,故
npm版本<5的用户需要通过`npm i npm@latest 
-g`更新一下npm的版本,使用前请确认版本是否正确。
--- End diff --

The `npm i npm@latest -g` command will update your npm package to the 
latest version. If command runs successful, your npm version will be greater 
than 5.0.


---


[GitHub] incubator-weex pull request #737: * [html5] update start command for develop

2017-09-25 Thread gurisxie
Github user gurisxie commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/737#discussion_r140723525
  
--- Diff: doc/source/cn/guide/set-up-env.md ---
@@ -28,26 +28,26 @@ brew install node
 
 ```bash
 $ node -v
-v6.3.1
+v6.11.3
 $ npm -v
-3.10.3
+3.10.10
 ```
 
 通常,安装了 Node.js 环境,npm 包管理工具也随之安装
了。因此,直接使用 npm 来安装 weex-toolkit。
 
 > npm 是一个 JavaScript 包管理工具,它可以让开发者轻松å…
±äº«å’Œé‡ç”¨ä»£ç ã€‚Weex 很多依赖来自社区,同样,Weex 
也将很多工具发布到社区方便开发者使用。
 
-**注意: ** weex-toolkit 在 1.0.1 之后才支持初始化 Vue 
项目,使用前请确认版本是否正确。
+**注意: ** 在`weex-toolkit`1.0.8版本后添加
了npm5规范的`npm-shrinkwrap.json`用于锁定包依赖,故
npm版本<5的用户需要通过`npm i npm@latest 
-g`更新一下npm的版本,使用前请确认版本是否正确。
--- End diff --

how to make sure version is ok?


---


[3/3] incubator-weex git commit: Merge branch 'dev' of https://github.com/erha19/incubator-weex into dev

2017-09-25 Thread gurisxie
Merge branch 'dev' of https://github.com/erha19/incubator-weex into dev


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/db666a2f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/db666a2f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/db666a2f

Branch: refs/heads/dev
Commit: db666a2f04d84b4f1ee46830daeb39e9b882879f
Parents: f3beb7d f8a3a23
Author: gurisxie <279483...@qq.com>
Authored: Mon Sep 25 17:31:19 2017 +0800
Committer: gurisxie <279483...@qq.com>
Committed: Mon Sep 25 17:31:19 2017 +0800

--
 doc/source/cn/guide/set-up-env.md | 64 ++
 doc/source/guide/set-up-env.md| 58 --
 start |  5 ++-
 3 files changed, 68 insertions(+), 59 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/db666a2f/doc/source/guide/set-up-env.md
--
diff --cc doc/source/guide/set-up-env.md
index 1cffbcd,c450233..af52bb3
--- a/doc/source/guide/set-up-env.md
+++ b/doc/source/guide/set-up-env.md
@@@ -71,23 -73,27 +73,27 @@@ You can modify this page in `src/index.

  
  
- 
-   .wrapper {
- flex-direction: column;
- justify-content: center;
-   }
-   .weex {
-font-size: 60px;
-text-align: center;
-color: #1B90F7;
-   }
-   .vue {
-font-size: 60px;
-text-align: center;
-margin-top: 30px;
-color: #41B883;
-   }
+