[GitHub] incubator-weex pull request #1363: [weex-529] [Android] Allow register custo...
GitHub user Rowandjj opened a pull request: https://github.com/apache/incubator-weex/pull/1363 [weex-529] [Android] Allow register custom gesture listeners https://issues.apache.org/jira/browse/WEEX-529 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rowandjj/incubator-weex android-feature-gesture-v2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1363.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1363 commit c735686ab29b44d40bf827a60a1eb72ae42b254d Author: chuyi Date: 2018-07-23T06:20:13Z [WEEX-529] android WXGesture class allow add custom gesture listener ---
[GitHub] incubator-weex pull request #1362: [weex-529] [Android] Allow register custo...
Github user Rowandjj closed the pull request at: https://github.com/apache/incubator-weex/pull/1362 ---
[GitHub] incubator-weex pull request #1362: [weex-529] [Android] Allow register custo...
GitHub user Rowandjj opened a pull request: https://github.com/apache/incubator-weex/pull/1362 [weex-529] [Android] Allow register custom gesture listeners https://issues.apache.org/jira/browse/WEEX-529 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rowandjj/incubator-weex android-feature-gesture Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1362 commit c735686ab29b44d40bf827a60a1eb72ae42b254d Author: chuyi Date: 2018-07-23T06:20:13Z [WEEX-529] android WXGesture class allow add custom gesture listener commit 82bb8965b5f310accc9376c02d32e6cd93889b55 Author: miomin Date: 2018-07-23T07:30:42Z * [android] Update libweexcore.so ---
[GitHub] incubator-weex pull request #1224: [WEEX-416] [Android] Add Pull-Refresh Off...
Github user Rowandjj closed the pull request at: https://github.com/apache/incubator-weex/pull/1224 ---
[GitHub] incubator-weex pull request #1225: [WEEX-418] [android] fix method can not b...
Github user Rowandjj closed the pull request at: https://github.com/apache/incubator-weex/pull/1225 ---
[GitHub] incubator-weex pull request #1225: [WEEX-418] [android] fix method can not b...
GitHub user Rowandjj opened a pull request: https://github.com/apache/incubator-weex/pull/1225 [WEEX-418] [android] fix method can not be override problem the following method is final which is not reasonable. * WXComponent#removeEvent * WXComponent#removeAllEvents You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rowandjj/incubator-weex feature-event Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1225.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1225 commit 55cbf4c43906b0dfb41778edcb5005ad2ca02a22 Author: chuyi Date: 2018-05-30T08:52:19Z [WEEX-418] fix method can not be override problem ---
[GitHub] incubator-weex pull request #1224: [WEEX-416] Add Pull-Refresh Offset Change...
GitHub user Rowandjj opened a pull request: https://github.com/apache/incubator-weex/pull/1224 [WEEX-416] Add Pull-Refresh Offset Changed Listener https://issues.apache.org/jira/projects/WEEX/issues/WEEX-416?filter=reportedbyme Add Pull-Refresh Offset Changed Listener so that user can custom pull-refresh animation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rowandjj/incubator-weex feature-pullrefresh Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1224.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1224 commit 9b93e3b4648fd90900c947a4e728c23d4ca8953e Author: chuyi Date: 2018-05-30T02:03:15Z [WEEX-416] Add Pull-Refresh Offset Changed Listener ---
[GitHub] incubator-weex pull request #1089: [WXTransition] add updateLayout function
GitHub user Rowandjj opened a pull request: https://github.com/apache/incubator-weex/pull/1089 [WXTransition] add updateLayout function 1. add update layout function. 2. fix css transition You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rowandjj/incubator-weex android-feature-bindingx Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1089.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1089 commit 647d12a529f64e3bccee92d32cbecf427ef4e823 Author: Rowandjj Date: 2018-03-27T08:56:55Z [WXTransition] add updateLayout function commit c82634b159232f2a71c767474644633fa4e31946 Author: Rowandjj Date: 2018-03-27T12:10:23Z [WXTransition] fix css transition problem ---
[GitHub] incubator-weex pull request #975: [android] [bugfix] rm "final" for "sForceE...
GitHub user Rowandjj opened a pull request: https://github.com/apache/incubator-weex/pull/975 [android] [bugfix] rm "final" for "sForceEnableDevTool" rm "final" so that we can change sForceEnableDevTool's value You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rowandjj/incubator-weex android-bugfix-chuyi Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/975.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #975 commit 19091fc814404113a21702c0b03c1012b3372f58 Author: Rowandjj Date: 2018-01-11T02:32:42Z [WXEnvironment] rm "final" so that we can change sForceEnableDevTool's value ---
[GitHub] incubator-weex issue #942: * [android] another flag to allow developers to e...
Github user Rowandjj commented on the issue: https://github.com/apache/incubator-weex/pull/942 done ---
[GitHub] incubator-weex pull request #942: * [android] another flag to allow develope...
GitHub user Rowandjj opened a pull request: https://github.com/apache/incubator-weex/pull/942 * [android] another flag to allow developers to enable/disable devtool another flag to allow developers to enable/disable devtool You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rowandjj/incubator-weex dev-chuyi Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/942.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #942 commit e3428b0cc0d593d602581341e5b3153f63b42725 Author: Rowandjj Date: 2017-12-14T09:44:52Z * [android] another flag to allow developers to enable/disable devtool ---
[GitHub] incubator-weex pull request #416: [android] list support drag-drop feature
Github user Rowandjj closed the pull request at: https://github.com/apache/incubator-weex/pull/416 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-weex pull request #416: [android] list support drag-drop feature
GitHub user Rowandjj reopened a pull request: https://github.com/apache/incubator-weex/pull/416 [android] list support drag-drop feature > use RecyclerView's ItemTouchHelper to implement drag-drop feature. feature: 1. support both pan and longPress gesture to trigger drag-drop; 2. support liner/grid layout; 3. support dragStart/dragEnd event; 4. support excluded some cells when dragging; extend attrs: # list: - draggable: whether draggable or not; - drag-trigger-type: which gesture type will trigger drag-drop; # cell: - drag-excluded: whether we should ignore current cell for dragging; # any component: - drag-anchor: the anchor that will trigger drag-drop JIRA: https://issues.apache.org/jira/browse/WEEX-37 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rowandjj/incubator-weex feature-drag-list Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/416.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #416 commit 3e33dca7825e6e1f63f045c555893e64d563b6ec Author: Rowandjj Date: 2017-06-05T02:17:45Z + [android] prepare drag-drop helper commit dde48f58e4b560ac34ae1f87e561b1201c1dd35f Author: Rowandjj Date: 2017-06-05T02:44:21Z * [android] attach drag-drop feature to list commit 284ead35012147f9e9b4d4e0353a7b0c62f41275 Author: Rowandjj Date: 2017-06-05T03:16:51Z * [android] disable drag by default commit ed6efa753cdb1cc2a12ec2b367b57d74fe1b7e68 Author: Rowandjj Date: 2017-06-05T12:49:36Z * [android] fix typo and license header commit 7de245de94cf8b861d6b3b137a191fef16edae66 Author: Rowandjj Date: 2017-06-08T02:55:59Z * [android] catch ui test problem commit f6f295b4b6587a389d23dd6ebce4679136bd96e2 Author: Rowandjj Date: 2017-06-08T07:04:07Z * [android] migrate drag feature into BasicListComponent commit 9fed9bbcc4002a509cce0317b2a75fe0911e2b30 Author: Rowandjj Date: 2017-06-08T08:13:15Z + [android] add ut case commit 90b40e60fa0b01de460d2a5bfd8757498ad0be2d Author: Rowandjj Date: 2017-06-08T08:33:34Z * [android] add missing license header commit 8060293f1efa7521da8a6d218ee27fab797e58ef Author: Rowandjj Date: 2017-06-08T09:45:48Z * [android] rm unused note --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-weex pull request #416: [android] list support drag-drop feature
Github user Rowandjj closed the pull request at: https://github.com/apache/incubator-weex/pull/416 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-weex pull request #416: [android] list support drag-drop feature
GitHub user Rowandjj reopened a pull request: https://github.com/apache/incubator-weex/pull/416 [android] list support drag-drop feature > use RecyclerView's ItemTouchHelper to implement drag-drop feature. feature: 1. support both pan and longPress gesture to trigger drag-drop; 2. support liner/grid layout; 3. support dragStart/dragEnd event; 4. support excluded some cells when dragging; extend attrs: # list: - draggable: whether draggable or not; - drag-trigger-type: which gesture type will trigger drag-drop; # cell: - drag-excluded: whether we should ignore current cell for dragging; # any component: - drag-anchor: the anchor that will trigger drag-drop JIRA: https://issues.apache.org/jira/browse/WEEX-37 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rowandjj/incubator-weex feature-drag-list Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/416.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #416 commit 3e33dca7825e6e1f63f045c555893e64d563b6ec Author: Rowandjj Date: 2017-06-05T02:17:45Z + [android] prepare drag-drop helper commit dde48f58e4b560ac34ae1f87e561b1201c1dd35f Author: Rowandjj Date: 2017-06-05T02:44:21Z * [android] attach drag-drop feature to list commit 284ead35012147f9e9b4d4e0353a7b0c62f41275 Author: Rowandjj Date: 2017-06-05T03:16:51Z * [android] disable drag by default commit ed6efa753cdb1cc2a12ec2b367b57d74fe1b7e68 Author: Rowandjj Date: 2017-06-05T12:49:36Z * [android] fix typo and license header commit 7de245de94cf8b861d6b3b137a191fef16edae66 Author: Rowandjj Date: 2017-06-08T02:55:59Z * [android] catch ui test problem commit f6f295b4b6587a389d23dd6ebce4679136bd96e2 Author: Rowandjj Date: 2017-06-08T07:04:07Z * [android] migrate drag feature into BasicListComponent commit 9fed9bbcc4002a509cce0317b2a75fe0911e2b30 Author: Rowandjj Date: 2017-06-08T08:13:15Z + [android] add ut case commit 90b40e60fa0b01de460d2a5bfd8757498ad0be2d Author: Rowandjj Date: 2017-06-08T08:33:34Z * [android] add missing license header commit 8060293f1efa7521da8a6d218ee27fab797e58ef Author: Rowandjj Date: 2017-06-08T09:45:48Z * [android] rm unused note --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-weex issue #416: [android] list support drag-drop feature
Github user Rowandjj commented on the issue: https://github.com/apache/incubator-weex/pull/416 https://issues.apache.org/jira/browse/WEEX-37 @sospartan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-weex pull request #416: [android] list support drag-drop feature
Github user Rowandjj commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/416#discussion_r120097230 --- Diff: android/sdk/src/main/java/com/taobao/weex/ui/component/list/DragSupportCallback.java --- @@ -0,0 +1,332 @@ +/** + * + * Apache License + *Version 2.0, January 2004 + * http://www.apache.org/licenses/ + * + *TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + * + *1. Definitions. + * + * "License" shall mean the terms and conditions for use, reproduction, + * and distribution as defined by Sections 1 through 9 of this document. + * + * "Licensor" shall mean the copyright owner or entity authorized by + * the copyright owner that is granting the License. + * + * "Legal Entity" shall mean the union of the acting entity and all + * other entities that control, are controlled by, or are under common + * control with that entity. For the purposes of this definition, + * "control" means (i) the power, direct or indirect, to cause the + * direction or management of such entity, whether by contract or + * otherwise, or (ii) ownership of fifty percent (50%) or more of the + * outstanding shares, or (iii) beneficial ownership of such entity. + * + * "You" (or "Your") shall mean an individual or Legal Entity + * exercising permissions granted by this License. + * + * "Source" form shall mean the preferred form for making modifications, + * including but not limited to software source code, documentation + * source, and configuration files. + * + * "Object" form shall mean any form resulting from mechanical + * transformation or translation of a Source form, including but + * not limited to compiled object code, generated documentation, + * and conversions to other media types. + * + * "Work" shall mean the work of authorship, whether in Source or + * Object form, made available under the License, as indicated by a + * copyright notice that is included in or attached to the work + * (an example is provided in the Appendix below). + * + * "Derivative Works" shall mean any work, whether in Source or Object + * form, that is based on (or derived from) the Work and for which the + * editorial revisions, annotations, elaborations, or other modifications + * represent, as a whole, an original work of authorship. For the purposes + * of this License, Derivative Works shall not include works that remain + * separable from, or merely link (or bind by name) to the interfaces of, + * the Work and Derivative Works thereof. + * + * "Contribution" shall mean any work of authorship, including + * the original version of the Work and any modifications or additions + * to that Work or Derivative Works thereof, that is intentionally + * submitted to Licensor for inclusion in the Work by the copyright owner + * or by an individual or Legal Entity authorized to submit on behalf of + * the copyright owner. For the purposes of this definition, "submitted" + * means any form of electronic, verbal, or written communication sent + * to the Licensor or its representatives, including but not limited to + * communication on electronic mailing lists, source code control systems, + * and issue tracking systems that are managed by, or on behalf of, the + * Licensor for the purpose of discussing and improving the Work, but + * excluding communication that is conspicuously marked or otherwise + * designated in writing by the copyright owner as "Not a Contribution." + * + * "Contributor" shall mean Licensor and any individual or Legal Entity + * on behalf of whom a Contribution has been received by Licensor and + * subsequently incorporated within the Work. + * + *2. Grant of Copyright License. Subject to the terms and conditions of + * this License, each Contributor hereby grants to You a perpetual, + * worldwide, non-exclusive, no-charge, royalty-free, irrevocable + * copyright license to reproduce, prepare Derivative Works of, + * publicly display, publicly perform, sublicense, and distribute the + * Work and such Derivative Works in Source or Object form. + * + *3. Grant of Patent License. Subject to the terms and co
[GitHub] incubator-weex pull request #416: [android] list support drag-drop feature
Github user Rowandjj commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/416#discussion_r120097125
--- Diff:
android/sdk/src/main/java/com/taobao/weex/ui/component/list/WXListComponent.java
---
@@ -237,4 +360,68 @@ private void removeFooterOrHeader(WXComponent child) {
getHostView().removeHeaderView(child);
}
}
+
+ @Nullable
+ private WXComponent findComponentByAnchorName(@NonNull WXComponent root,
@NonNull String anchorName) {
+long start = 0;
+if (WXEnvironment.isApkDebugable()) {
+ start = System.currentTimeMillis();
+}
+
+Deque deque = new ArrayDeque<>();
+deque.add(root);
+while (!deque.isEmpty()) {
+ WXComponent curComponent = deque.removeFirst();
+ ImmutableDomObject object = curComponent.getDomObject();
+ if (object != null) {
+String isAnchorSet =
WXUtils.getString(object.getAttrs().get(anchorName), null);
+
+//hit
+if (isAnchorSet != null && isAnchorSet.equals("true")) {
+ if (WXEnvironment.isApkDebugable()) {
+WXLogUtils.d("dragPerf", "findComponentByAnchorName time: " +
(System.currentTimeMillis() - start) + "ms");
+ }
+ return curComponent;
+}
+ }
+ if (curComponent instanceof WXVContainer) {
+WXVContainer container = (WXVContainer) curComponent;
+for (int i = 0, len = container.childCount(); i < len; i++) {
+ WXComponent child = container.getChild(i);
+ deque.add(child);
+}
+ }
+}
+
+if (WXEnvironment.isApkDebugable()) {
+ WXLogUtils.d("dragPerf", "findComponentByAnchorName elapsed time: "
+ (System.currentTimeMillis() - start) + "ms");
+}
+return null;
+
+ }
+
+ private String getTriggerType(@Nullable ImmutableDomObject domObject) {
+String triggerType = DEFAULT_TRIGGER_TYPE;
+if (domObject == null) {
+ return triggerType;
+}
+triggerType =
WXUtils.getString(domObject.getAttrs().get(DRAG_TRIGGER_TYPE),
DEFAULT_TRIGGER_TYPE);
+if (!DragTriggerType.LONG_PRESS.equals(triggerType) &&
!DragTriggerType.PAN.equals(triggerType)) {
+ triggerType = DEFAULT_TRIGGER_TYPE;
+}
+
+if (WXEnvironment.isApkDebugable()) {
+ WXLogUtils.d(TAG, "trigger type is " + triggerType);
+}
+
+return triggerType;
+ }
+
+ private boolean getExcluded(@Nullable ImmutableDomObject domObject) {
--- End diff --
okay
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #416: [android] list support drag-drop feature
Github user Rowandjj commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/416#discussion_r120097094 --- Diff: android/sdk/src/main/java/com/taobao/weex/ui/component/list/WXDragHelper.java --- @@ -0,0 +1,243 @@ +/** + * + * Apache License + *Version 2.0, January 2004 + * http://www.apache.org/licenses/ + * + *TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + * + *1. Definitions. + * + * "License" shall mean the terms and conditions for use, reproduction, + * and distribution as defined by Sections 1 through 9 of this document. + * + * "Licensor" shall mean the copyright owner or entity authorized by + * the copyright owner that is granting the License. + * + * "Legal Entity" shall mean the union of the acting entity and all + * other entities that control, are controlled by, or are under common + * control with that entity. For the purposes of this definition, + * "control" means (i) the power, direct or indirect, to cause the + * direction or management of such entity, whether by contract or + * otherwise, or (ii) ownership of fifty percent (50%) or more of the + * outstanding shares, or (iii) beneficial ownership of such entity. + * + * "You" (or "Your") shall mean an individual or Legal Entity + * exercising permissions granted by this License. + * + * "Source" form shall mean the preferred form for making modifications, + * including but not limited to software source code, documentation + * source, and configuration files. + * + * "Object" form shall mean any form resulting from mechanical + * transformation or translation of a Source form, including but + * not limited to compiled object code, generated documentation, + * and conversions to other media types. + * + * "Work" shall mean the work of authorship, whether in Source or + * Object form, made available under the License, as indicated by a + * copyright notice that is included in or attached to the work + * (an example is provided in the Appendix below). + * + * "Derivative Works" shall mean any work, whether in Source or Object + * form, that is based on (or derived from) the Work and for which the + * editorial revisions, annotations, elaborations, or other modifications + * represent, as a whole, an original work of authorship. For the purposes + * of this License, Derivative Works shall not include works that remain + * separable from, or merely link (or bind by name) to the interfaces of, + * the Work and Derivative Works thereof. + * + * "Contribution" shall mean any work of authorship, including + * the original version of the Work and any modifications or additions + * to that Work or Derivative Works thereof, that is intentionally + * submitted to Licensor for inclusion in the Work by the copyright owner + * or by an individual or Legal Entity authorized to submit on behalf of + * the copyright owner. For the purposes of this definition, "submitted" + * means any form of electronic, verbal, or written communication sent + * to the Licensor or its representatives, including but not limited to + * communication on electronic mailing lists, source code control systems, + * and issue tracking systems that are managed by, or on behalf of, the + * Licensor for the purpose of discussing and improving the Work, but + * excluding communication that is conspicuously marked or otherwise + * designated in writing by the copyright owner as "Not a Contribution." + * + * "Contributor" shall mean Licensor and any individual or Legal Entity + * on behalf of whom a Contribution has been received by Licensor and + * subsequently incorporated within the Work. + * + *2. Grant of Copyright License. Subject to the terms and conditions of + * this License, each Contributor hereby grants to You a perpetual, + * worldwide, non-exclusive, no-charge, royalty-free, irrevocable + * copyright license to reproduce, prepare Derivative Works of, + * publicly display, publicly perform, sublicense, and distribute the + * Work and such Derivative Works in Source or Object form. + * + *3. Grant of Patent License. Subject to the terms and conditions
[GitHub] incubator-weex pull request #416: [android] list support drag-drop feature
Github user Rowandjj commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/416#discussion_r120095801 --- Diff: android/sdk/src/main/java/com/taobao/weex/ui/component/list/DefaultDragHelper.java --- @@ -0,0 +1,355 @@ +/** + * Apache License + * Version 2.0, January 2004 + * http://www.apache.org/licenses/ + * + * TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + * + * 1. Definitions. + * + * "License" shall mean the terms and conditions for use, reproduction, + * and distribution as defined by Sections 1 through 9 of this document. + * + * "Licensor" shall mean the copyright owner or entity authorized by + * the copyright owner that is granting the License. + * + * "Legal Entity" shall mean the union of the acting entity and all + * other entities that control, are controlled by, or are under common + * control with that entity. For the purposes of this definition, + * "control" means (i) the power, direct or indirect, to cause the + * direction or management of such entity, whether by contract or + * otherwise, or (ii) ownership of fifty percent (50%) or more of the + * outstanding shares, or (iii) beneficial ownership of such entity. + * + * "You" (or "Your") shall mean an individual or Legal Entity + * exercising permissions granted by this License. + * + * "Source" form shall mean the preferred form for making modifications, + * including but not limited to software source code, documentation + * source, and configuration files. + * + * "Object" form shall mean any form resulting from mechanical + * transformation or translation of a Source form, including but + * not limited to compiled object code, generated documentation, + * and conversions to other media types. + * + * "Work" shall mean the work of authorship, whether in Source or + * Object form, made available under the License, as indicated by a + * copyright notice that is included in or attached to the work + * (an example is provided in the Appendix below). + * + * "Derivative Works" shall mean any work, whether in Source or Object + * form, that is based on (or derived from) the Work and for which the + * editorial revisions, annotations, elaborations, or other modifications + * represent, as a whole, an original work of authorship. For the purposes + * of this License, Derivative Works shall not include works that remain + * separable from, or merely link (or bind by name) to the interfaces of, + * the Work and Derivative Works thereof. + * + * "Contribution" shall mean any work of authorship, including + * the original version of the Work and any modifications or additions + * to that Work or Derivative Works thereof, that is intentionally + * submitted to Licensor for inclusion in the Work by the copyright owner + * or by an individual or Legal Entity authorized to submit on behalf of + * the copyright owner. For the purposes of this definition, "submitted" + * means any form of electronic, verbal, or written communication sent + * to the Licensor or its representatives, including but not limited to + * communication on electronic mailing lists, source code control systems, + * and issue tracking systems that are managed by, or on behalf of, the + * Licensor for the purpose of discussing and improving the Work, but + * excluding communication that is conspicuously marked or otherwise + * designated in writing by the copyright owner as "Not a Contribution." + * + * "Contributor" shall mean Licensor and any individual or Legal Entity + * on behalf of whom a Contribution has been received by Licensor and + * subsequently incorporated within the Work. + * + * 2. Grant of Copyright License. Subject to the terms and conditions of + * this License, each Contributor hereby grants to You a perpetual, + * worldwide, non-exclusive, no-charge, royalty-free, irrevocable + * copyright license to reproduce, prepare Derivative Works of, + * publicly display, publicly perform, sublicense, and distribute the + * Work and such Derivative Works in Source or Object form. + * + * 3. Grant of Patent License. Subject to the terms and conditions of + * this License, each Contributor hereby grants to You a perpetual, + * worldwide, non-exclusive, no-charge, royalty-free, irrevocable + * (except as stated in this section) patent license to make, have made, + * use, offer to sell, sell, import, and otherwise transfer the Work, + * where such license applies only to those patent claims licensable + * by such Contributor that are necessarily infring
[GitHub] incubator-weex pull request #416: [android] list support drag-drop feature
GitHub user Rowandjj opened a pull request: https://github.com/apache/incubator-weex/pull/416 [android] list support drag-drop feature > use RecyclerView's ItemTouchHelper to implement drag-drop feature. feature: 1. support both pan and longPress gesture to trigger drag-drop; 2. support liner/grid layout; 3. support dragStart/dragEnd event; 4. support excluded some cells when dragging; extend attrs: # list: - draggable: whether draggable or not; - drag-trigger-type: which gesture type will trigger drag-drop; # cell: - drag-excluded: whether we should ignore current cell for dragging; # any component: - drag-anchor: the anchor that will trigger drag-drop You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rowandjj/incubator-weex feature-drag-list Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/416.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #416 commit 3e33dca7825e6e1f63f045c555893e64d563b6ec Author: Rowandjj Date: 2017-06-05T02:17:45Z + [android] prepare drag-drop helper commit dde48f58e4b560ac34ae1f87e561b1201c1dd35f Author: Rowandjj Date: 2017-06-05T02:44:21Z * [android] attach drag-drop feature to list --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-weex pull request #343: + [android] support prerender
Github user Rowandjj commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/343#discussion_r116402924
--- Diff:
android/sdk/src/main/java/com/taobao/weex/dom/action/CreateFinishAction.java ---
@@ -18,15 +18,36 @@
*/
package com.taobao.weex.dom.action;
+import com.taobao.weex.LayoutFinishListener;
import com.taobao.weex.WXSDKInstance;
+import com.taobao.weex.WXSDKManager;
import com.taobao.weex.common.WXRenderStrategy;
+import com.taobao.weex.common.WXThread;
+import com.taobao.weex.dom.DOMActionContext;
import com.taobao.weex.dom.RenderActionContext;
/**
* Created by sospartan on 02/03/2017.
*/
final class CreateFinishAction extends AbstractLayoutFinishAction {
+
+ @Override
+ public void executeDom(DOMActionContext context) {
+super.executeDom(context);
+//add by chuyi
--- End diff --
i want 'save cached instance' when layout finished. so i add
`LayoutFinishListener`, when createFinish action invoked, the listener will
fired too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #343: + [android] support prerender
Github user Rowandjj commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/343#discussion_r116402784
--- Diff:
android/sdk/src/main/java/com/taobao/weex/ui/module/WXTimerModule.java ---
@@ -57,28 +59,32 @@ void setHandler(Handler handler) {
@JSMethod(uiThread = false)
public void setTimeout(@IntRange(from = 1) int funcId, @IntRange(from =
0) int delay) {
-postMessage(WXJSBridgeMsgType.MODULE_TIMEOUT, funcId, delay,
Integer.parseInt(mWXSDKInstance.getInstanceId()));
+if(mWXSDKInstance != null) {
--- End diff --
nope... we want hold timers in preRenderMode
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #343: + [android] support prerender
Github user Rowandjj commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/343#discussion_r116402756
--- Diff:
android/sdk/src/main/java/com/taobao/weex/dom/action/ExecutableAction.java ---
@@ -0,0 +1,30 @@
+package com.taobao.weex.dom.action;
+
+import com.taobao.weex.dom.DOMAction;
+import com.taobao.weex.dom.DOMActionContext;
+import com.taobao.weex.dom.RenderAction;
+import com.taobao.weex.dom.RenderActionContext;
+
+class ExecutableAction implements DOMAction, RenderAction {
--- End diff --
changed to ` ExecutableRenderAction`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #343: + [android] support prerender
Github user Rowandjj commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/343#discussion_r116401393
--- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java ---
@@ -625,6 +635,24 @@ public void reloadImages() {
}
}
+
+ public boolean isPreRenderMode() {
+return this.isPreRenderMode;
+ }
+
+ public void setPreRenderMode(final boolean isPreRenderMode) {
+WXSDKManager.getInstance().getWXRenderManager().postOnUiThread(new
Runnable() {
+ @Override
+ public void run() {
+WXSDKInstance.this.isPreRenderMode = isPreRenderMode;
+ }
+},0);
+ }
+
+ public void replaceContext(@NonNull Context context) {
--- End diff --
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #343: + [android] support prerender
Github user Rowandjj commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/343#discussion_r116401373 --- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java --- @@ -122,7 +123,8 @@ /** * Render start time */ - private long mRenderStartTime; + //this field may accessed outside + public long mRenderStartTime; --- End diff -- ok i'll add setter method --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-weex issue #343: + [android] support prerender
Github user Rowandjj commented on the issue: https://github.com/apache/incubator-weex/pull/343 @sospartan pls review it:) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-weex pull request #343: + [android] support prerender
GitHub user Rowandjj opened a pull request: https://github.com/apache/incubator-weex/pull/343 + [android] support prerender introduction : https://issues.apache.org/jira/browse/WEEX-27?jql=project%20%3D%20WEEX%20AND%20resolution%20%3D%20Unresolved%20AND%20priority%20%3D%20Major%20ORDER%20BY%20key%20DESC You can merge this pull request into a Git repository by running: $ git pull https://github.com/Rowandjj/incubator-weex android-feature-prerender-interface Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/343.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #343 commit 140390719dc73a62a16f377f8c1498fa8f78b367 Author: Rowandjj Date: 2017-05-14T04:36:11Z + [android] init prerender --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
