[GitHub] incubator-weex pull request #1356: [WEEX-495][iOS] Fix class_replaceMethod p...
Github user xuyouyang closed the pull request at: https://github.com/apache/incubator-weex/pull/1356 ---
[GitHub] incubator-weex pull request #1357: [WEEX-524][iOS] Try to fix a crash operat...
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1357 [WEEX-524][iOS] Try to fix a crash operating mutable array in multi-thread Try to fix a crash: Terminating app due to uncaught exception 'NSRangeException', reason: '*** -[__NSArrayM objectAtIndexedSubscript:]: index 0 beyond bounds for empty array' Last Exception Backtrace: 0 CoreFoundation __exceptionPreprocess :228 (in CoreFoundation) 1 _objc_exception_throw :56 2 CoreFoundation _CFThrowFormattedException :112 (in CoreFoundation) 3 -[__NSArrayM objectAtIndexedSubscript:] :192 (in CoreFoundation) 4 -[WXThreadSafeMutableArray objectAtIndex:] WXThreadSafeMutableArray.m:0 5 -[WXBridgeContext topInstance] WXBridgeContext.m:0 6 +[WXSDKEngine topInstance] WXSDKEngine.m:277 You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuyouyang/incubator-weex ios-bugfix-WEEX-524 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1357.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1357 commit 1172a3b62269b80f909ad17a2b07cbfe2300d7dd Author: xuyouyang Date: 2018-07-23T04:06:42Z Try to fix a crash operating mutable array in multi-thread ---
[GitHub] incubator-weex pull request #1352: [WEEX-524][iOS]Try to fix a crash when re...
Github user xuyouyang closed the pull request at: https://github.com/apache/incubator-weex/pull/1352 ---
[GitHub] incubator-weex pull request #1193: [WEEX-394] [iOS] Add license
Github user xuyouyang closed the pull request at: https://github.com/apache/incubator-weex/pull/1193 ---
[GitHub] incubator-weex issue #1234: [iOS] Fix loading component
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1234 @snail-Lin Thank you for your contributionï¼ï¼As the [development process](http://weex.apache.org/development-process.html)shows, we need create a jira issue in [apache](https://issues.apache.org/jira/browse/WEEX), and format your pull request title and commit log in English. :) ---
[GitHub] incubator-weex issue #1221: [android] modify playground app camera runtime p...
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1221 @shawnlinboy Thank you for your contributionï¼ï¼As the [development process shows](http://weex.apache.org/development-process.html), we need create a jira issue in [apache](https://issues.apache.org/jira/browse/WEEX), and format your pull request title and commit log. :) ---
[GitHub] incubator-weex pull request #1193: [WEEX-394] [iOS] Add license
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1193 [WEEX-394] [iOS] Add license Add license for some iOS files. ⢠./incubator-weex-7102479/ios/sdk/WeexSDK/Sources/Layout/WXCoreFlexEnum.h ⢠./incubator-weex-7102479/ios/sdk/WeexSDK/Sources/Layout/WXCoreLayout.cpp ⢠./incubator-weex-7102479/ios/sdk/WeexSDK/Sources/Layout/WXCoreLayout.h ⢠./incubator-weex-7102479/ios/sdk/WeexSDK/Sources/Layout/WXCoreStyle.cpp ⢠./incubator-weex-7102479/ios/sdk/WeexSDK/Sources/Layout/WXCoreStyle.h ⢠./incubator-weex-7102479/ios/sdk/WeexSDK/Sources/Monitor/WXAnalyzerCenter+Transfer.h ⢠./incubator-weex-7102479/ios/sdk/WeexSDK/Sources/Monitor/WXAnalyzerCenter.h ⢠./incubator-weex-7102479/ios/sdk/WeexSDK/Sources/Protocol/WXAnalyzerProtocol.h ⢠./incubator-weex-7102479/ios/sdk/WeexSDK/Sources/Protocol/WXConfigCenterProtocol.h You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuyouyang/incubator-weex master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1193 commit bd208d6f5bbeb23d2f37dd52cc9b4a202ef77220 Author: æ¸ å±¿ <youyang.xyy@...> Date: 2018-05-22T08:53:33Z [WEEX-394] [iOS] Add license ---
[GitHub] incubator-weex pull request #1121: [WEEX-298][iOS]fix WXIndicatorView invoke...
Github user xuyouyang closed the pull request at: https://github.com/apache/incubator-weex/pull/1121 ---
[GitHub] incubator-weex issue #1127: WXImageComponent: set imageview in completion bl...
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1127 @xiayun200825 thank you for your contributions. Can you give us some testcase through 'http://dotwe.org/vue' ? ---
[GitHub] incubator-weex pull request #1123: [WEEX-294][iOS]use NSTimer to implement s...
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1123 [WEEX-294][iOS]use NSTimer to implement setTimeout Use NSTimer to implement setTimeout. testcast:http://dotwe.org/vue/5e897eb8621fbb35cdbe49c41cf7c9dd You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuyouyang/incubator-weex ios-feature-WEEX-294-use-NSTimer-to-implement-setTimeout Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1123.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1123 commit 4ca985c2820b7fc6ae181e62bd83d2420a54346d Author: xuyouyang <youyang.xyy@...> Date: 2018-04-18T15:06:05Z [WEEX-294][IOS]use NSTimer to implement setTimeout commit d27519fef8cbc41d709e1b9857042f15d484ae49 Author: xuyouyang <youyang.xyy@...> Date: 2018-04-18T15:09:01Z [WEEX-294][IOS]use NSTimer to implement setTimeout ---
[GitHub] incubator-weex pull request #1121: [WEEX-298][IOS]fix WXIndicatorView invoke...
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1121 [WEEX-298][IOS]fix WXIndicatorView invoke setNeedsDisplay not on main thread fix WXIndicatorView invoke setNeedsDisplay not on main thread You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuyouyang/incubator-weex ios-feature-WEEX-298-fix-WXIndicatorView-invoke-setNeedsDisplay-not-on-main-thread Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1121 commit dcc3dc453eb706eb70d32fc856e6635d5802ae85 Author: xuyouyang <youyang.xyy@...> Date: 2018-04-20T09:35:59Z [WEEX-298][IOS]fix WXIndicatorView invoke setNeedsDisplay not on main thread ---
[GitHub] incubator-weex pull request #1111: * [iOS] Bind instanceId to jscontext and ...
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/ * [iOS] Bind instanceId to jscontext and post notice when jscontext created Bind instanceId to jscontext and post notice when jscontext created. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuyouyang/incubator-weex ios-feature-add_jscontext_instanceId Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes # commit 25ef91a60e1392b735c4d6eff6bd942c3dc91658 Author: xuyouyang <youyang.xyy@...> Date: 2018-04-12T09:31:28Z * [iOS] bind instanceId to jscontext commit 769a69e28eb79a179c46fb14548b3350265136d5 Author: xuyouyang <youyang.xyy@...> Date: 2018-04-12T09:35:59Z Merge branch 'master' into ios-feature-add_jscontext_instanceId ---
[GitHub] incubator-weex issue #1072: [WEEX-249][iOS]fix WXRuleManager multi-thread cr...
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1072 hi @acton393 if we change fontFamilyDic type to NSMutableDictionaryï¼will it also cause multi-thread problem? For example, other thread operate object in fontFamilyDic. And I have a doubt that why WXThreadSafeDictionary can be a deadlock? It created in different queue and different lock. ---
[GitHub] incubator-weex pull request #1072: [WEEX-249][iOS]fix WXRuleManager multi-th...
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1072 [WEEX-249][iOS]fix WXRuleManager multi-thread crash fontFamilyDic type is WXThreadSafeMutableDictionary in WXUtility.m but the real type is NSMutableDictionary created in WXRuleManager.m. It may cause crash in multi-thread. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuyouyang/incubator-weex fontMultiThreadCrash Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1072.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1072 commit 55aaa8855f4054f9b6bb7f5792a9f0ffc0ec895f Author: xuyouyang <xuyouyang@...> Date: 2018-03-15T05:37:27Z [WEEX-249][iOS]fix WXRuleManager multi-thread crash commit 54c1a6881efeb81c82698e878ec6249d9fd71eca Author: xuyouyang <xuyouyang@...> Date: 2018-03-15T05:39:33Z [WEEX-249][iOS]fix WXRuleManager multi-thread crash ---
[GitHub] incubator-weex issue #1051: [WEEX-241][iOS] add WXVideoComponent "poster" at...
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1051 @acton393 Ha, it's sorry that I am not familiar with Android develop very much.ð ---
[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1051 OK. Thank you very much! @acton393 ---
[GitHub] incubator-weex pull request #1051: + [iOS] add WXVideoComponent "poster" att...
Github user xuyouyang commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/1051#discussion_r173046770 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXVideoComponent.m --- @@ -85,6 +89,13 @@ - (id)init } [self addSubview:_playerViewController.view]; + +_posterImageView = [[UIImageView alloc] init]; --- End diff -- good ideal! I will modify this later. ---
[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1051 NO. The poster attribute specifies an image to be shown while the video is downloading, or until the user hits the play button. If this is not included, the first frame of the video will be used instead. You can see this "https://www.w3schools.com/tags/att_video_poster.asp; It is a attribute in HTML tag ---
[GitHub] incubator-weex pull request #1051: + [iOS] add WXVideoComponent "poster" att...
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1051 + [iOS] add WXVideoComponent "poster" attribute. + [iOS] add WXVideoComponent poster feature and add support "poster" attribute to testcase: http://dotwe.org/vue/4bf373d06d3b8021441a88b7f841ef3b You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuyouyang/incubator-weex ios-feature-videoPoster Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1051.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1051 commit 946bcec8fbbfbb4d3bd1767e3a8d55a759576017 Author: å¾æé³ <xuyouyang@...> Date: 2018-03-07T02:59:44Z + [iOS] add WXVideoComponent "poster" attribute. ---
[GitHub] incubator-weex pull request #1038: *[iOS]fix annotation spell error.
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/1038 *[iOS]fix annotation spell error. *[iOS]fix annotation spell error. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuyouyang/incubator-weex master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1038.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1038 commit 95523c45b7c12e20fdd26c5e8315a4e59abf1b89 Author: å¾æé³ <xuyouyang@...> Date: 2018-02-24T08:49:38Z *[iOS]fix annotation spell error. ---
[GitHub] incubator-weex pull request #930: * [ios] fix WXSDKInstance retain cycle
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/930 * [ios] fix WXSDKInstance retain cycle * [ios] fix WXSDKInstance retain cycle You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuyouyang/incubator-weex master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/930.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #930 commit d6b82a25d1c501e2241daa0974e67432de179b3a Author: å¾æé³ <xuyouy...@corp.netease.com> Date: 2017-12-06T02:27:40Z * [ios] fix WXSDKInstance retain cycle ---
[GitHub] incubator-weex pull request #388: * [ios] fix WXBridgeContext.h annotation
GitHub user xuyouyang opened a pull request: https://github.com/apache/incubator-weex/pull/388 * [ios] fix WXBridgeContext.h annotation You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuyouyang/incubator-weex dev Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/388.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #388 commit 22116303afdf87a52b960b516e3de36620dee16c Author: å¾æé³ <hzxuyouy...@corp.netease.com> Date: 2017-05-24T06:13:28Z * [ios] fix WXBridgeContext.h annotation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
