[GitHub] incubator-weex pull request #1051: + [iOS] add WXVideoComponent "poster" att...

[xuyouyang]

Github user xuyouyang commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1051#discussion_r173046770
  
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXVideoComponent.m ---
@@ -85,6 +89,13 @@ - (id)init
 }
 
 [self addSubview:_playerViewController.view];
+
+_posterImageView = [[UIImageView alloc] init];
--- End diff --

good ideal! I will modify this later.


---

[GitHub] incubator-weex pull request #1051: + [iOS] add WXVideoComponent "poster" att...

[acton393]

Github user acton393 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1051#discussion_r172831893
  
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXVideoComponent.m ---
@@ -85,6 +89,13 @@ - (id)init
 }
 
 [self addSubview:_playerViewController.view];
+
+_posterImageView = [[UIImageView alloc] init];
--- End diff --

How about lazy load when front-end developer specify the poster attributes


---

[GitHub] incubator-weex pull request #1051: + [iOS] add WXVideoComponent "poster" att...

[xuyouyang]

GitHub user xuyouyang opened a pull request:

https://github.com/apache/incubator-weex/pull/1051

+ [iOS] add WXVideoComponent "poster" attribute.

+ [iOS] add WXVideoComponent poster feature and add support "poster" 
attribute to 
testcase: http://dotwe.org/vue/4bf373d06d3b8021441a88b7f841ef3b





You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xuyouyang/incubator-weex 
ios-feature-videoPoster

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1051.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1051


commit 946bcec8fbbfbb4d3bd1767e3a8d55a759576017
Author: 徐有阳 
Date:   2018-03-07T02:59:44Z

+ [iOS] add WXVideoComponent "poster" attribute.




---