[GitHub] incubator-weex pull request #1114: box-shadow size should cover padding and ...

[Yanjiie]

GitHub user Yanjiie opened a pull request:

    https://github.com/apache/incubator-weex/pull/1114

    box-shadow size should cover padding and border

    Hi ~ I found some problem in Android side when i use box-shadow. Look that:
    
    **In H5 side:**
    <img  
src="https://user-images.githubusercontent.com/29728294/38844686-3be92bca-4227-11e8-938e-6396175760bd.png";
 width="350px" />
    
    **In iOS side:**
    <img 
src="https://user-images.githubusercontent.com/29728294/38844783-9bc3e1c0-4227-11e8-8120-15e9849d59ac.jpeg";
 width="350px" />
    
    **In Android side:**
    <img 
src="https://user-images.githubusercontent.com/29728294/38844867-d6980cc2-4227-11e8-8a72-c2add9527b7f.png";
 width="350px" />
    
    Now, you see the bug.
    The box-shadow style should cover box's padding and border when render the 
shadow. But Android side is different from the iOS and H5 side.
    These change fix this Bug.
    
    This is a test case. 
[android-bugfix-boxshadow-testcase](http://dotwe.org/vue/4ab90f1cae7c5313c31ab4316b306a6e)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Yanjiie/incubator-weex 
android-bugfix-boxshadow

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1114
    
----
commit 46cdd0e0265368cd6b4eb13e6954c5e03c207736
Author: Yanjiie <suenyinkit@...>
Date:   2018-04-17T01:37:58Z

    * [android] fix box-shadow size should cover padding and border

commit ee167224ff06e80a85141a305b80550d251a7481
Author: Yanjiie <suenyinkit@...>
Date:   2018-04-17T02:04:12Z

    * [test] add box-shadow test case

----


---