[GitHub] incubator-weex pull request #1135: [WEEX-311] [iOS] use new layoutEngin to r...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/1135


---

[GitHub] incubator-weex pull request #1135: [WEEX-311] [iOS] use new layoutEngin to r...

[acton393]

Github user acton393 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1135#discussion_r184366574
  
--- Diff: ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m ---
@@ -367,6 +400,11 @@ - (void)registerGlobalFunctions
 }];
 
 [_jsBridge registerCallNativeComponent:^void(NSString *instanceId, 
NSString *componentRef, NSString *methodName, NSArray *args, NSDictionary 
*options) {
+   
+#ifdef DEBUG
+NSLog(@"test -> action: callNativeComponent ref:%@",componentRef);
--- End diff --

NSLog 


---

[GitHub] incubator-weex pull request #1135: [WEEX-311] [iOS] use new layoutEngin to r...

[acton393]

Github user acton393 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1135#discussion_r184366659
  
--- Diff: ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m ---
@@ -295,6 +318,9 @@ - (void)registerGlobalFunctions
 }
 
 WXPerformBlockOnComponentThread(^{
+#ifdef DEBUG
+NSLog(@"test -> action :removeEvent ref:%@",ref);
--- End diff --

Same  NSLog


---

[GitHub] incubator-weex pull request #1135: [WEEX-311] [iOS] use new layoutEngin to r...

[acton393]

Github user acton393 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1135#discussion_r184366382
  
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXCellComponent.mm ---
@@ -36,6 +37,10 @@ @implementation WXCellComponent
 
 - (instancetype)initWithRef:(NSString *)ref type:(NSString *)type 
styles:(NSDictionary *)styles attributes:(NSDictionary *)attributes 
events:(NSArray *)events weexInstance:(WXSDKInstance *)weexInstance
 {
+#ifdef DEBUG
+NSLog(@"test -> init Cell: ref:%@, styles:%@",ref,styles);
--- End diff --

pay attention to NSLog  and your log format


---

[GitHub] incubator-weex pull request #1135: [WEEX-311] [iOS] use new layoutEngin to r...

[acton393]

Github user acton393 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1135#discussion_r184366221
  
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXListComponent.mm ---
@@ -163,6 +164,11 @@ - (UIView *)loadView
 return [[WXTableView alloc] init];
 }
 
+//- (void)_insertChildCssNode:(WXComponent *)subcomponent 
atIndex:(NSInteger)index
--- End diff --

if  useless, just delete it 


---

[GitHub] incubator-weex pull request #1135: [WEEX-311] [iOS] use new layoutEngin to r...

[acton393]

Github user acton393 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1135#discussion_r184366095
  
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXRefreshComponent.mm ---
@@ -86,6 +97,9 @@ - (void)refresh
 if (!_refreshEvent || _displayState) {
 return;
 }
+#ifdef DEBUG
+NSLog(@"test -> refreshComponent : refresh ref:%@",self.ref);
--- End diff --

please format  the log, not the `test xxx`, do not using NSLog


---

[GitHub] incubator-weex pull request #1135: [WEEX-311] [iOS] use new layoutEngin to r...

[acton393]

Github user acton393 commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/1135#discussion_r184365906
  
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXRefreshComponent.mm ---
@@ -94,6 +108,9 @@ - (void)pullingdown:(NSDictionary*)param
 if (!_pullingdownEvent) {
 return ;
 }
+#ifdef DEBUG
+NSLog(@"test -> refreshComponent : pullingdown ,ref:%@",self.ref);
--- End diff --

NSLog  is not allowed to print


---

[GitHub] incubator-weex pull request #1135: [WEEX-311] [iOS] use new layoutEngin to r...

[lucky-chen]

GitHub user lucky-chen opened a pull request:

https://github.com/apache/incubator-weex/pull/1135

[WEEX-311] [iOS] use new layoutEngin to replace youga

*isNewFeature* **:**

  * [ ] Update API docs for the component.
  * [x] Update/Add demo to demonstrate new feature.
  * [ ] Update test scripts for the feature.
  * [ ] Add unit tests for the feature.




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lucky-chen/incubator-weex 
ios-feature-flexlayout-rebase-new

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1135


commit a3166ec531a63f4ae3beacc45725713cf728ae51
Author: MrRaindrop 
Date:   2017-10-31T14:15:05Z

* [html5] bugfix:
  - fix waterfall: use headers below cells as footers.
  - fix issue WEEX-97.
  - fix click handler being invoked twice for switch.

* [ios] init

* [iOS] support new flex-layout engine

* [iOS] update layout engin

* [iOS] fix recycleList copy node error

* [iOS] rm useless code




---