(whimsy) branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new c38439cd Unused
c38439cd is described below

commit c38439cd8a76a9260352933c3ea325e324e6e73b
Author: Sebb 
AuthorDate: Sun May 5 22:38:22 2024 +0100

Unused
---
 Gemfile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Gemfile b/Gemfile
index cc7f05ee..0bfa0032 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,6 +1,5 @@
 source 'https://rubygems.org'
 
-root = '..'
 gemspec
 gem 'mime-types'
 gem 'wunderbar'

(whimsy) branch master updated: Unused parameter

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new d1b60950 Unused parameter
d1b60950 is described below

commit d1b6095092ec22fa2efcaa00cac4bb34bde35433
Author: Sebb 
AuthorDate: Wed Mar 20 23:55:24 2024 +

Unused parameter
---
 lib/whimsy/asf/mlist.rb| 3 +--
 www/roster/models/committee.rb | 2 +-
 www/roster/models/ppmc.rb  | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/whimsy/asf/mlist.rb b/lib/whimsy/asf/mlist.rb
index 0a567617..064eac3a 100644
--- a/lib/whimsy/asf/mlist.rb
+++ b/lib/whimsy/asf/mlist.rb
@@ -155,10 +155,9 @@ module ASF
 
 # for a mail domain, extract related lists and their moderators
 # also returns the time when the data was last checked
-# If podling==true, then also check for old-style podling names
 # returns: [{dev@a.o=>[email1, email2]}, mod-time]
 # if mail_domain is nil, matches all lists except infra test lists
-def self.list_moderators(mail_domain, _podling=false)
+def self.list_moderators(mail_domain)
 
   moderators = {}
   list_parse('mod') do |dom, list, subs|
diff --git a/www/roster/models/committee.rb b/www/roster/models/committee.rb
index 69663028..7866779f 100644
--- a/www/roster/models/committee.rb
+++ b/www/roster/models/committee.rb
@@ -21,7 +21,7 @@ class Committee
 # always needed: if not a member, for checking moderator status
 # and if a member, needed for showing list moderators
 # will be dropped later if insufficient karma
-moderators, modtime = ASF::MLIST.list_moderators(pmc.mail_list, true)
+moderators, modtime = ASF::MLIST.list_moderators(pmc.mail_list)
 subscribers = nil # we get the counts only here
 subtime = nil
 pSubs = [] # private@ subscribers
diff --git a/www/roster/models/ppmc.rb b/www/roster/models/ppmc.rb
index 4fb8b0e5..0bf6840f 100644
--- a/www/roster/models/ppmc.rb
+++ b/www/roster/models/ppmc.rb
@@ -18,7 +18,7 @@ class PPMC
 # always needed: if not a member, for checking moderator status
 # and if a member, needed for showing list moderators
 # will be dropped later if insufficient karma
-moderators, modtime = ASF::MLIST.list_moderators(ppmc.mail_list, true)
+moderators, modtime = ASF::MLIST.list_moderators(ppmc.mail_list)
 subscribers = nil # we get the counts only here
 subtime = nil
 pSubs = [] # private@ subscribers

[whimsy] branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new 5ccf8d4  Unused
5ccf8d4 is described below

commit 5ccf8d475c391cef69d8854dd5603b5334f8e528
Author: Sebb 
AuthorDate: Sat Feb 19 12:36:18 2022 +

Unused
---
 www/secretary/workbench/views/actions/incomplete.json.rb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/www/secretary/workbench/views/actions/incomplete.json.rb 
b/www/secretary/workbench/views/actions/incomplete.json.rb
index 84a8675..de62701 100644
--- a/www/secretary/workbench/views/actions/incomplete.json.rb
+++ b/www/secretary/workbench/views/actions/incomplete.json.rb
@@ -15,7 +15,6 @@ _extract_project
 task "email #{message.from}" do
   # build mail from template
   @email = message.from
-  @test2 = [@missing_address]
   missing_items = []
   missing_items << '- missing or incomplete postal address' if 
@missing_address == 'true'
   missing_items << '- missing email address' if @missing_email == 'true'

[whimsy] branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new ba227ab  Unused
ba227ab is described below

commit ba227ab630d231a9494f2d60542a0a4ec87df8a3
Author: Sebb 
AuthorDate: Wed Aug 4 13:00:08 2021 +0100

Unused
---
 www/roster/public_json_common.rb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/www/roster/public_json_common.rb b/www/roster/public_json_common.rb
index 9679cd1..4c0cba1 100644
--- a/www/roster/public_json_common.rb
+++ b/www/roster/public_json_common.rb
@@ -90,7 +90,6 @@ def sendMail(subject, body, to='Notification List 
'
   to to

[whimsy] branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new d31a2bf  Unused
d31a2bf is described below

commit d31a2bf0bcdd693f11ce845a8570193fd5cdaa88
Author: Sebb 
AuthorDate: Sun May 23 14:52:26 2021 +0100

Unused
---
 www/secretary/ldap-check.cgi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/www/secretary/ldap-check.cgi b/www/secretary/ldap-check.cgi
index 755edc2..5f041d5 100755
--- a/www/secretary/ldap-check.cgi
+++ b/www/secretary/ldap-check.cgi
@@ -59,7 +59,6 @@ _html do
 end
 
 projects = ASF::Project.list
-pmcs = ASF::Committee.pmcs
 
 projects.sort_by(&:name).each do |p|
   po=p.ownerids

[whimsy] branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new 916413e  Unused
916413e is described below

commit 916413e97fcd4ccc0de672e753cb1dfe4599171d
Author: Sebb 
AuthorDate: Tue Apr 27 17:17:30 2021 +0100

Unused
---
 www/secretary/icla-lint.cgi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/secretary/icla-lint.cgi b/www/secretary/icla-lint.cgi
index f3450d8..0cd3d86 100755
--- a/www/secretary/icla-lint.cgi
+++ b/www/secretary/icla-lint.cgi
@@ -289,7 +289,7 @@ _html do
   # Check that all LDAP entries appear in iclas.txt
   no_icla = ldap.select {|k| not icla_ids.has_key? k}
   # remove known exceptions
-  %w(testsebb testrubys apldaptest).each {|w| no_icla.delete w}
+  %w(testsebb testrubys testcml testdooh apldaptest).each {|w| no_icla.delete 
w}
   if no_icla.size > 0
 _h2 'LDAP entries not listed in iclas.txt'
 _table_ do
@@ -366,7 +366,7 @@ _html do
 for i in 0...buttons.length
   buttons[i].addEventListener('click') do |event|
 email = event.target.getAttribute('data-email')
-issue = event.target.getAttribute('data-issue')
+# issue = event.target.getAttribute('data-issue')
 name  = event.target.getAttribute('data-name')
 
 destination = "mailto:#{email}?cc=secret...@apache.org;

[whimsy] branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new 47cd4e7  Unused
47cd4e7 is described below

commit 47cd4e7dc8b41cd4afb7ec4b0c2000f8f10ac09b
Author: Sebb 
AuthorDate: Tue Apr 27 17:16:57 2021 +0100

Unused
---
 www/secretary/memapp_check.cgi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/secretary/memapp_check.cgi b/www/secretary/memapp_check.cgi
index c206e65..ece50a9 100755
--- a/www/secretary/memapp_check.cgi
+++ b/www/secretary/memapp_check.cgi
@@ -76,7 +76,7 @@ _table_ do
 _th 'Status'
   end
   nofiles.sort.each do |k,v|
-person, status, tried = v
+person, status, _tried = v
 _tr do
   _td do
 _a k, href: "https://whimsy.apache.org/roster/committer/#{k};, target: 
'_blank'

[whimsy] branch master updated: Unused variables

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new fc371f0  Unused variables
fc371f0 is described below

commit fc371f09f380e2905a8d150a8d4c582f0fab609f
Author: Sebb 
AuthorDate: Fri Jan 1 17:06:54 2021 +

Unused variables
---
 Rakefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Rakefile b/Rakefile
index c069e65..4cfc4f2 100644
--- a/Rakefile
+++ b/Rakefile
@@ -214,10 +214,10 @@ namespace :svn do
 svncmd += files
   end
   puts "#{PREFIX} #{svncmd.join(' ')}"
-  pid = Process.spawn(*svncmd, out: w, err: [:child, :out])
+  _pid = Process.spawn(*svncmd, out: w, err: [:child, :out])
   w.close
 
-  pid, status = Process.wait2
+  _pid, status = Process.wait2
   outerr = r.read
   r.close
 

[whimsy] branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new 259f230  Unused
259f230 is described below

commit 259f230911ca6ff42d5c7e2b4e420c068a70818b
Author: Sebb 
AuthorDate: Tue Dec 29 22:20:42 2020 +

Unused
---
 www/roster/views/iclaSearch.js.rb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/www/roster/views/iclaSearch.js.rb 
b/www/roster/views/iclaSearch.js.rb
index 4c5b703..58715c3 100644
--- a/www/roster/views/iclaSearch.js.rb
+++ b/www/roster/views/iclaSearch.js.rb
@@ -68,7 +68,6 @@ class IclaSearch < Vue
 _p 'loading...'
 
   else
-search = @search.downcase().split(' ')
 list = @list
 
 if list.length == 0

[whimsy] branch master updated: Unused/unnecessary

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new 7282167  Unused/unnecessary
7282167 is described below

commit 72821675e10f817a1ff5dbd1fc8d1e18829739d3
Author: Sebb 
AuthorDate: Tue Nov 24 16:41:09 2020 +

Unused/unnecessary
---
 tools/site-scan.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/site-scan.rb b/tools/site-scan.rb
index 3d02123..0fc32ab 100755
--- a/tools/site-scan.rb
+++ b/tools/site-scan.rb
@@ -64,7 +64,7 @@ def parse(id, site, name)
   $stderr.puts "#{id} #{uri} #{status}"
   # Bail and return if getting the site returns an error code
   if response.respond_to? :code and response.code =~ /^[45]/
-data[:errors] = "cache.get(#{site.to_s}) error code #{response.code}"
+data[:errors] = "cache.get(#{site}) error code #{response.code}"
 return data
   end
   doc = Nokogiri::HTML(response)
@@ -138,7 +138,7 @@ def parse(id, site, name)
 end
 # Note we also check for incubator disclaimer (immaterial of tlp|podling)
 if txt =~ 
SiteStandards::PODLING_CHECKS['disclaimer'][SiteStandards::CHECK_CAPTURE]
-  t, p = getText(txt, node, / is an effort undergoing/)
+  t, _p = getText(txt, node, / is an effort undergoing/)
   data[:disclaimer] = t
 end
   end

[whimsy] branch master updated: Unused variables

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new 27a2874  Unused variables
27a2874 is described below

commit 27a287404c3c2be9cc23dc96ca51803bc6f1c7ca
Author: Sebb 
AuthorDate: Tue Nov 24 16:07:45 2020 +

Unused variables
---
 lib/whimsy/asf/agenda/front.rb   |  5 ++---
 tools/namemap.rb |  4 ++--
 tools/ponypoop.rb| 12 ++--
 tools/site_member_check.rb   |  2 +-
 tools/votes2ini.rb   |  2 +-
 www/board/agenda/spec/actions_spec.rb|  2 +-
 www/board/agenda/spec/vue_server.rb  |  6 +++---
 www/board/agenda/views/committers_report.text.rb |  8 
 www/committers/subscribe.cgi |  2 +-
 www/committers/tm-report.cgi |  2 +-
 www/committers/tools.cgi |  6 +++---
 11 files changed, 25 insertions(+), 26 deletions(-)

diff --git a/lib/whimsy/asf/agenda/front.rb b/lib/whimsy/asf/agenda/front.rb
index 05429d8..6ac6c38 100644
--- a/lib/whimsy/asf/agenda/front.rb
+++ b/lib/whimsy/asf/agenda/front.rb
@@ -14,14 +14,13 @@ class ASF::Board::Agenda
 scan @file, pattern do |attr|
   if attr['title'] == 'Roll Call'
 attr['people'] = {}
-list = nil
 
 absent = attr['text'].scan(/Absent:\n\n.*?\n\n/m).join
 directors = attr['text'].scan(/^ +Directors[ \S]*?:\n\n.*?\n\n/m).join
 officers = attr['text'].scan(/^ +Executive[ \S]*?:\n\n.*?\n\n/m).join
 
 # attempt to identify the people mentioned in the Roll Call
-people = attr['text'].scan(/^ {8}(\w.*)/).flatten.each do |name|
+attr['text'].scan(/^ {8}(\w.*)/).flatten.each do |name|
   next if name == 'none'
   # Remove (extraneous [comments in past board minutes
   name.gsub! /(\s*[\[(]|\s+-).*/, ''
@@ -68,7 +67,7 @@ class ASF::Board::Agenda
 
 if attr['people']
   attr['people'] = Hash[attr['people'].
-sort_by {|id, person| person[:sortName]}]
+sort_by {|_id, person| person[:sortName]}]
 end
   elsif attr['title'] == 'Call to order'
 attr['timestamp'] = timestamp(attr['text'][/\d+:\d+([ap]m)?/])
diff --git a/tools/namemap.rb b/tools/namemap.rb
index a03cbfc..2136a64 100644
--- a/tools/namemap.rb
+++ b/tools/namemap.rb
@@ -121,7 +121,7 @@ module NameMap
   # TODO Depends on file format of exported other system accounts
   # @param f filename to read from
   # @return json data
-  def get_other(f)
+  def get_other(_f)
 return TEST_OTHER
   end
 
@@ -239,7 +239,7 @@ module NameMap
 dups = {}
 histogram = Hash.new{|k,v| v = 0}
 cids, cmails = hash_committers(get_committers(io))
-cids.each do |id, hsh|
+cids.each do |_id, hsh|
   histogram[hsh[MAIL].length] += 1
 end
 cmails.each do |addr, ary|
diff --git a/tools/ponypoop.rb b/tools/ponypoop.rb
index b027d8c..f6286bf 100755
--- a/tools/ponypoop.rb
+++ b/tools/ponypoop.rb
@@ -38,7 +38,7 @@ def analyze_threads(threads)
   if threads['children'].is_a?(Array) then
 max += 1
 threads['children'].each do |thread|
-  m, t = analyze_threads(thread)
+  _m, t = analyze_threads(thread)
   total += t
 end
 p "Hsh: #{threads.class} - #{threads.size} at #{threads['epoch']} 
#{max}/#{total}"
@@ -66,12 +66,12 @@ def analyze_stats(fname, results, subject_regex, errors)
   results.last[:interesting] = results.last[:email]
   results.last[:threads] = jzon['no_threads']
   subject_regex.each do |t, s|
-results.last[t] = jzon['emails'].select{ |email| email['subject'] =~ s 
}.size
+results.last[t] = jzon['emails'].select { |email| email['subject'] =~ 
s }.size
 results.last[:interesting] -= results.last[t] if 
subject_regex.keys.include? t
   end
   # TODO: there's a more rubyish way to combine these loops
-  subject_regex.each do |t, s|
-jzon['emails'].reject!{ |email| email['subject'] =~ s }
+  subject_regex.each do |_t, s|
+jzon['emails'].reject! { |email| email['subject'] =~ s }
   end
   jzon['emails'].each do |email|
 subjects << email['subject']
@@ -168,10 +168,10 @@ def optparse
   options[:subdomain] = s.chomp('@.')
 end
 
-opts.on('-p', '--pull', 'Pull down stats JSON files into -d dir 
(otherwise, default analyzes existing stats JSON in dir)') do |p|
+opts.on('-p', '--pull', 'Pull down stats JSON files into -d dir 
(otherwise, default analyzes existing stats JSON in dir)') do
   options[:pull] = true
 end
-opts.on('-m', '--mbox', 'Pull down mbox files into -d dir') do |p|
+opts.on('-m', '--mbox', 'Pull down mbox files into -d dir') do
   options[:mbox] = true
 end
 
diff --git 

[whimsy] branch master updated: Unused params

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new bd1748f  Unused params
bd1748f is described below

commit bd1748f3eece2f7194b31c26be3b8079465fa067
Author: Sebb 
AuthorDate: Tue Nov 24 15:50:49 2020 +

Unused params
---
 tools/wwwdocs.rb | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/wwwdocs.rb b/tools/wwwdocs.rb
index 9bbdb3e..640fc1d 100755
--- a/tools/wwwdocs.rb
+++ b/tools/wwwdocs.rb
@@ -111,9 +111,9 @@ end
 #   - REMOVES any error scan entries
 #   - Adds array element of auth realm if login required
 def annotate_scan(scan, auth)
-  annotated = scan.reject{ |k, v| v[0] =~ /\A#{ISERR}/ }
+  annotated = scan.reject{ |_k, v| v[0] =~ /\A#{ISERR}/ }
   annotated.each do |path, ary|
-realm = auth.select { |k, v| path.match(/\A#{k}/) }
+realm = auth.select { |k, _v| path.match(/\A#{k}/) }
 if realm.values.first
   ary << AUTHMAP[realm.values.first]
 end
@@ -169,14 +169,14 @@ end
 
 # Scan directory for use of ASF::SVN (private or public)
 # @return { "file" => [['private line', ...], ['public svn', ...], 
'WWW-Authenticate code line' (, 'authrealm')] }
-def scan_dir_svn(dir, regexs, auth = get_auth())
+def scan_dir_svn(dir, regexs)
   links = {}
   auth = get_auth()
   Dir["#{dir}/**/*.{cgi,rb}"].sort.each do |f|
 l = scan_file_svn(f, regexs)
 if (l[0].length + l[1].length) > 0
   fbase = f.sub(dir, '')
-  realm = auth.select { |k, v| fbase.sub('/www', '').match(/\A#{k}/) }
+  realm = auth.select { |k, _v| fbase.sub('/www', '').match(/\A#{k}/) }
   if realm.values.first
 l << AUTHMAP[realm.values.first]
   end

[whimsy] branch master updated: Unused parameters

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new b72fd3e  Unused parameters
b72fd3e is described below

commit b72fd3ed07ddb81c09f36c3ff6d4583230aa2724
Author: Sebb 
AuthorDate: Sun Oct 4 12:53:15 2020 +0100

Unused parameters
---
 www/secretary/workbench/views/actions/icla2.json.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/secretary/workbench/views/actions/icla2.json.rb 
b/www/secretary/workbench/views/actions/icla2.json.rb
index e432584..af690ba 100644
--- a/www/secretary/workbench/views/actions/icla2.json.rb
+++ b/www/secretary/workbench/views/actions/icla2.json.rb
@@ -137,9 +137,9 @@ task "svn commit foundation/officers/iclas.txt" do
 _input value: @iclaline, name: 'iclaline'
   end
 
-  complete do |dir|
+  complete do
 rc = ASF::SVN.update(ASF::SVN.svnpath!('officers', 'iclas.txt'),
-"ICLA (additional) for #{@pubname}", env, _, {diff: true}) do |tmpdir, 
iclas_txt|
+"ICLA (additional) for #{@pubname}", env, _, {diff: true}) do 
|_tmpdir, iclas_txt|
   iclas_txt[/^#{@id}:.*:#{@oldemail}:.*/] = @iclaline
   iclas_txt
 end

[whimsy] branch master updated: Unused variables

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new 249cbc8  Unused variables
249cbc8 is described below

commit 249cbc86f405ffe21ad093b9a3344a61b72932d7
Author: Sebb 
AuthorDate: Sun Oct 4 12:28:15 2020 +0100

Unused variables
---
 www/secretary/workbench/views/actions/memapp.json.rb | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/secretary/workbench/views/actions/memapp.json.rb 
b/www/secretary/workbench/views/actions/memapp.json.rb
index c5e6157..6cb2755 100644
--- a/www/secretary/workbench/views/actions/memapp.json.rb
+++ b/www/secretary/workbench/views/actions/memapp.json.rb
@@ -61,7 +61,7 @@ task "svn commit documents/member_apps/#@filename#{fileext} 
and update members.t
 _textarea @entry, name: 'entry', rows: @entry.split("\n").length
   end
 
-  complete do |dir|
+  complete do
 
 svn_multi('foundation', 'members.txt', 'member_apps', @selected, 
@signature, @filename, fileext, message, @document) do |members_txt|
 
@@ -132,7 +132,7 @@ task "subscribe to memb...@apache.org" do
 _textarea @subreq, name: 'subreq', rows: @subreq.split("\n").length
   end
 
-  complete do |dir|
+  complete do
 # determine file name
 fn = "#{@availid}-members-#{Time.now.strftime '%Y%m%d-%H%M%S-%L'}.json"
 
@@ -163,10 +163,10 @@ task "svn commit memapp-received.text" do
 _input value: @line, name: 'line'
   end
 
-  complete do |dir|
+  complete do
 meeting = file.split('/')[-2]
 path = ASF::SVN.svnpath!('Meetings', meeting,'memapp-received.txt')
-rc = ASF::SVN.update(path, @document, env, _, {diff: true}) do |tmpdir, 
input|
+rc = ASF::SVN.update(path, @document, env, _, {diff: true}) do |_tmpdir, 
input|
   input[/.*\s#{@availid}\s.*/] = @line
   input
 end

[whimsy] branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new ea293d1  Unused
ea293d1 is described below

commit ea293d157912d4e45ddc534eb65eb95a7c1be237
Author: Sebb 
AuthorDate: Tue Sep 22 19:42:43 2020 +0100

Unused
---
 lib/whimsy/asf/committee.rb |  6 +++---
 www/board/agenda/views/sw.js.rb |  4 ++--
 www/members/board-attend.cgi| 10 +-
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/lib/whimsy/asf/committee.rb b/lib/whimsy/asf/committee.rb
index 93613ec..b5415cc 100644
--- a/lib/whimsy/asf/committee.rb
+++ b/lib/whimsy/asf/committee.rb
@@ -62,7 +62,7 @@ module ASF
 
 # mapping of committee names to canonical names (generally from ldap)
 # See also www/roster/committee.cgi
-@@aliases = Hash.new {|hash, name| name.downcase}
+@@aliases = Hash.new { |_hash, name| name.downcase}
 @@aliases.merge! \
   'c++ standard library'   => 'stdcxx',
   'community development'  => 'comdev',
@@ -214,8 +214,8 @@ module ASF
   end
 
   # sort and concatenate committees
-  committees = committees.sort_by {|name, chair| name.downcase}.
-map {|name, chair| "#{name.ljust(23)} #{chair}"}.
+  committees = committees.sort_by { |name, _chair| name.downcase }.
+map { |name, chair| "#{name.ljust(23)} #{chair}" }.
 join("\n")
 
   # replace committee info in the section, and then replace the
diff --git a/www/board/agenda/views/sw.js.rb b/www/board/agenda/views/sw.js.rb
index 369fb70..415881d 100644
--- a/www/board/agenda/views/sw.js.rb
+++ b/www/board/agenda/views/sw.js.rb
@@ -114,7 +114,7 @@ def latest(event)
 end
 
 if match
-  match.clone().text().then do |before|
+  match.clone().text().then do
 fulfill(match)
 
 request = Request.new(match.url, cache: "no-store")
@@ -185,7 +185,7 @@ def bootstrap(event, request)
   # bad response: use cache instead
   replyFromCache(true)
 end
-  }.catch {|failure|
+  }.catch { |_failure|
 # no response: use cache instead
 replyFromCache(true)
   }
diff --git a/www/members/board-attend.cgi b/www/members/board-attend.cgi
index 74ad4e3..92e0cd5 100755
--- a/www/members/board-attend.cgi
+++ b/www/members/board-attend.cgi
@@ -68,7 +68,7 @@ end
 
 # If JSON requested, simply return the data hash
 _json do
-  summaries, errors = summarize_all
+  summaries, _errors = summarize_all
   summaries
 end
 
@@ -87,7 +87,7 @@ _html do
   ) do
 datums = JSON.parse(File.read(File.join(BOARD, 'scripts', 
'board-attend.json')))
 months = Set.new()
-datums.each do |id, data|
+datums.each do |_id, data|
   data.each_key do |m|
 months << m
   end
@@ -121,7 +121,7 @@ _html do
 datums.each do | id, data |
   totp = 0.0
   tota = 0.0
-  data.each do |k,v|
+  data.each do |_k, v|
 totp += v['preapps'] if v.has_key?('preapps')
 tota += v['actions'] if v.has_key?('actions')
   end
@@ -134,10 +134,10 @@ _html do
   end
 end
 _td do
-  _ data.select{|k,v| v['present']}.length
+  _ data.select{ |_k, v| v['present']}.length
 end
 _td do
-  _ data.select{|k,v| !v['present']}.length
+  _ data.reject{ |_k, v| v['present']}.length
 end
 _td do
   _span.text_muted "#{((totp / data.length)*100).round(0)}%"

[whimsy] branch master updated: Unused checks

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new 765f09e  Unused checks
765f09e is described below

commit 765f09e42445c4effbfc33008a51e8c35826cc3d
Author: Sebb 
AuthorDate: Tue Sep 22 18:38:45 2020 +0100

Unused checks
---
 lib/whimsy/asf/documents.rb |  4 ++--
 www/apmail/mods.cgi | 10 --
 www/secretary/workbench/tasks.rb|  2 +-
 www/secretary/workbench/views/forms/icla2.js.rb |  7 ---
 4 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/lib/whimsy/asf/documents.rb b/lib/whimsy/asf/documents.rb
index fce8ae5..b82f5ea 100644
--- a/lib/whimsy/asf/documents.rb
+++ b/lib/whimsy/asf/documents.rb
@@ -155,13 +155,13 @@ module ASF
 # param rooturl the svn url of the directory
 # param fileurl the svn url of the complete file
 # return the file name or nil if the file is not in the directory
-def self.extractfilenamefrom(rooturl,fileurl)
+def self.extractfilenamefrom(rooturl, fileurl)
   return nil unless fileurl
   # does the root match the file url?
   index = fileurl.index(rooturl)
   if (index == 0)
 # root matches, return file name (end of fileurl)
-filename = fileurl[rooturl.length..-1]
+fileurl[rooturl.length..-1]
   end
 end
 # Extract the file name if it is in emeritus directory
diff --git a/www/apmail/mods.cgi b/www/apmail/mods.cgi
index ed13d90..3dadb60 100755
--- a/www/apmail/mods.cgi
+++ b/www/apmail/mods.cgi
@@ -68,8 +68,8 @@ _html do
 
   _h2 "ASF Mailing List moderators"
   emails = []
-  mods.each do |domain, lists|
-lists.each do |list, moderators|
+  mods.each do |_domain, lists|
+lists.each do |_list, moderators|
   emails += moderators.map(&:downcase)
 end
   end
@@ -99,7 +99,6 @@ _html do
 elsif ENV['PATH_INFO'] =~ %r{^/([-.\w]*apache\w*\.\w+)/$}
 
   _h2_ "Mailing Lists - #{$1}"
-  stem = "#{$1}-"
   _ul do
 mods[$1].keys.each do |list|
   _li! { _a list, href: "#{list}/" }
@@ -108,9 +107,8 @@ _html do
 
 elsif ENV['PATH_INFO'] =~ %r{^/([-.\w]*apache\w*\.\w+)/([-\w]+)/$}
 
-  domain, list = $1, $2
-
-  dir = "/home/apmail/lists/#{domain}/#{list}"
+  domain = $1
+  list = $2
 
   if _.post? and @email.to_s.include? '@'
 if %w(sub unsub).include? @op
diff --git a/www/secretary/workbench/tasks.rb b/www/secretary/workbench/tasks.rb
index 05a5010..c190db8 100644
--- a/www/secretary/workbench/tasks.rb
+++ b/www/secretary/workbench/tasks.rb
@@ -125,7 +125,7 @@ class Wunderbar::JsonBuilder
   extras << ['propset', 'svn:mime-type', content_type, outpath]
 end
   else
-name, file, content_type = dest.flatten
+_name, file, content_type = dest.flatten
 outpath = ASF::SVN.svnpath!(docdir,"#{outfilename}#{outfileext}")
 # TODO does it matter that the revision is not known?
 if ASF::SVN.exist?(outpath, nil, env)
diff --git a/www/secretary/workbench/views/forms/icla2.js.rb 
b/www/secretary/workbench/views/forms/icla2.js.rb
index 4677af1..1980ee2 100644
--- a/www/secretary/workbench/views/forms/icla2.js.rb
+++ b/www/secretary/workbench/views/forms/icla2.js.rb
@@ -152,7 +152,8 @@ class ICLA2 < Vue
   # input requirements.
   def updated()
 # ICLA file form
-valid = %w(pubname email).all? do |name|
+# TODO: why not used?
+_valid = %w(pubname email).all? do |name|
   document.querySelector("input[name=#{name}]").validity.valid
 end
 
@@ -176,7 +177,7 @@ class ICLA2 < Vue
   end
 
   # handle ICLA form submission
-  def file(event)
+  def file(_event)
 setTimeout 0 do
   @submitted = true
   @filed = true
@@ -184,7 +185,7 @@ class ICLA2 < Vue
   end
 
   # when tasks complete (or are aborted) reset form
-  def status_update(event)
+  def status_update(_event)
 @submitted = false
 @filed = false
   end

[whimsy] branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new dce6c48  Unused
dce6c48 is described below

commit dce6c48ff3a1dba75e28e96e655f64c40207c1ae
Author: Sebb 
AuthorDate: Tue Jul 7 16:56:47 2020 +0100

Unused
---
 www/roster/views/actions/memstat.json.rb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/www/roster/views/actions/memstat.json.rb 
b/www/roster/views/actions/memstat.json.rb
index 4907e05..8aa6bc1 100644
--- a/www/roster/views/actions/memstat.json.rb
+++ b/www/roster/views/actions/memstat.json.rb
@@ -64,7 +64,6 @@ if @action == 'rescind_emeritus'
   ASF::SVN.svn_('mv', [@emeritusfileurl, emeritus_rescinded_url], _, {env:env, 
msg:message})
 elsif @action == 'request_emeritus'
   # Create mail to secretary requesting emeritus
-  FOUNDATION_URL = ASF::SVN.svnurl('foundation')
   EMERITUS_TEMPLATE_URL = ASF::SVN.svnpath!('foundation', 
'emeritus-request.txt').untaint
   template, err =
 ASF::SVN.svn('cat', EMERITUS_TEMPLATE_URL, {env:env})

[whimsy] branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new 8bb1cc0  Unused
8bb1cc0 is described below

commit 8bb1cc01a9ca27743dcce3973fd35de4eb893d29
Author: Sebb 
AuthorDate: Sun Jun 28 22:54:00 2020 +0100

Unused
---
 lib/spec/lib/svn_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/spec/lib/svn_spec.rb b/lib/spec/lib/svn_spec.rb
index f46df50..2e8ad4a 100644
--- a/lib/spec/lib/svn_spec.rb
+++ b/lib/spec/lib/svn_spec.rb
@@ -309,7 +309,7 @@ describe ASF::SVN do
 it "_svn_build_cmd('help', 'path', {user: 'whimsy', password: 'pass}) 
should include username" do
   cmd, stdin = ASF::SVN._svn_build_cmd('help', 'path', {user: 'whimsy', 
password: 'pass'})
   exp = ["svn", "help", "--non-interactive", ["--username", "whimsy", 
"--no-auth-cache"], "--", "path"]
-  if res = ASF::SVN.passwordStdinOK?
+  if ASF::SVN.passwordStdinOK?
 expect(stdin).to eq('pass')
 expect(cmd-exp).to eq([["--password-from-stdin"]])
   else

[whimsy] branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new 9c64588  Unused
9c64588 is described below

commit 9c64588e558f153ed9fb08c71de277d8ab76140f
Author: Sebb 
AuthorDate: Fri Jun 26 13:28:01 2020 +0100

Unused
---
 www/officers/coi.cgi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/officers/coi.cgi b/www/officers/coi.cgi
index 0e315af..c054519 100755
--- a/www/officers/coi.cgi
+++ b/www/officers/coi.cgi
@@ -56,7 +56,7 @@ PANEL_MESSAGE = USER_IS_REQUIRED_BUT_NOT_AFFIRMED ?
   'Thank you for signing the Conflict of Interest Affirmation'
 
 # Read the template and append the signature block
-def get_affirmed_template(user, password, name, timestamp)
+def get_affirmed_template(name, timestamp)
   signature_block =
   '   I, the undersigned, acknowledge that I have received,
  read and understood the Conflict of Interest policy;
@@ -124,7 +124,7 @@ _html do
   if _.get?
 if USER_IS_REQUIRED_BUT_NOT_AFFIRMED
   _whimsy_panel(PANEL_MESSAGE, style: 'panel-success') do
-affirmed = get_affirmed_template($USER, $PASSWORD, USERNAME,  
current_timestamp)
+affirmed = get_affirmed_template(USERNAME,  current_timestamp)
 affirmed.each_line do |line|
   _p line
 end
@@ -155,7 +155,7 @@ def emit_post(_)
   # The only information in the POST is $USER and $PASSWORD
   current_timestamp = DateTime.now.strftime "%Y-%m-%d %H:%M:%S"
 
-  affirmed = get_affirmed_template($USER, $PASSWORD, USERNAME, 
current_timestamp)
+  affirmed = get_affirmed_template(USERNAME, current_timestamp)
   user_filename = "#{USERID}.txt".untaint
 
   # report on commit

[whimsy] branch master updated: Unused?

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new 71677e1  Unused?
71677e1 is described below

commit 71677e1a8d89bb204288c30861ccc8c3308471bc
Author: Sebb 
AuthorDate: Thu Dec 19 14:39:15 2019 +

Unused?
---
 lib/whimsy/asf/auth.rb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/whimsy/asf/auth.rb b/lib/whimsy/asf/auth.rb
index 5d94706..ea9506d 100644
--- a/lib/whimsy/asf/auth.rb
+++ b/lib/whimsy/asf/auth.rb
@@ -43,6 +43,7 @@ module ASF
 end
 
 # Return an array of the ou=project entries in the authorization file
+# TODO Does not appear to be used
 def projects
   arr = []
   
#incubator={ldap:cn=incubator,ou=project,ou=groups,dc=apache,dc=org;attr=member}

[whimsy] branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new 687d8e1  Unused
687d8e1 is described below

commit 687d8e175989d0b7676c92c8aceb92ea4676d665
Author: Sebb 
AuthorDate: Mon Nov 25 20:10:47 2019 +

Unused
---
 lib/whimsy/asf/svn.rb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/whimsy/asf/svn.rb b/lib/whimsy/asf/svn.rb
index 5c00143..49ecbe9 100644
--- a/lib/whimsy/asf/svn.rb
+++ b/lib/whimsy/asf/svn.rb
@@ -1,5 +1,4 @@
 require 'uri'
-require 'thread'
 require 'open3'
 require 'fileutils'
 require 'tmpdir'

[whimsy] branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new 401950c  Unused
401950c is described below

commit 401950cda7c23c4aaf872957bef9b182ccfda975
Author: Sebb 
AuthorDate: Wed Oct 24 10:46:11 2018 +0100

Unused
---
 www/secretary/workbench/views/actions/pdfize.json.rb | 2 --
 1 file changed, 2 deletions(-)

diff --git a/www/secretary/workbench/views/actions/pdfize.json.rb 
b/www/secretary/workbench/views/actions/pdfize.json.rb
index a38d865..d0d0e90 100644
--- a/www/secretary/workbench/views/actions/pdfize.json.rb
+++ b/www/secretary/workbench/views/actions/pdfize.json.rb
@@ -8,8 +8,6 @@ begin
   source = message.find(@selected).as_pdf
   source.rewind
 
-  output = SafeTempFile.new('output')
-
   name = @selected.sub(/\.\w+$/, '') + '.pdf'
 
   # If output file is empty, then the command failed

[whimsy] branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
 new b709247  Unused
b709247 is described below

commit b709247ed54ce5a4db6f79c4df5460d4554b2fa4
Author: Sebb 
AuthorDate: Wed Dec 27 20:31:50 2017 +

Unused
---
 www/status/passenger.cgi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/www/status/passenger.cgi b/www/status/passenger.cgi
index 6907cd3..e884c4d 100755
--- a/www/status/passenger.cgi
+++ b/www/status/passenger.cgi
@@ -8,7 +8,6 @@ require 'open3'
 require 'wunderbar'
 require 'whimsy/asf'
 
-members = ASF.members
 user = ASF::LDAP.http_auth(ENV['HTTP_AUTHORIZATION'])
 
 unless user

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" '].

[whimsy] branch master updated: Unused

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git

The following commit(s) were added to refs/heads/master by this push:
   new  3464b50   Unused
3464b50 is described below

commit 3464b506afedbe9e81219b3a71fbba02a4c6dfc4
Author: Sebb 
AuthorDate: Wed May 10 23:55:52 2017 +0100

Unused
---
 tools/site-scan.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/site-scan.rb b/tools/site-scan.rb
index e0bcdb1..9a0d6fd 100755
--- a/tools/site-scan.rb
+++ b/tools/site-scan.rb
@@ -27,7 +27,7 @@ def fetch(uri, depth=1)
   $stderr.puts "Redirect #{uri}" if $verbose
   fetch response['location'], depth+1
 else
-  return uri, request, response
+  return uri, response
 end
   end
 end
@@ -37,7 +37,7 @@ def squash(text)
 end
 
 def parse(site, name)
-  uri, request, response = fetch(site)
+  uri, response = fetch(site)
   doc = Nokogiri::HTML(response.body)
 
   # default data

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" '].