[jira] Resolved: (WICKET-788) Javadocs for Wicket 1.3 Not Available On Website
[ https://issues.apache.org/jira/browse/WICKET-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Quenot resolved WICKET-788. - Resolution: Fixed Fixed by Gwyn Javadocs for Wicket 1.3 Not Available On Website Key: WICKET-788 URL: https://issues.apache.org/jira/browse/WICKET-788 Project: Wicket Issue Type: Improvement Components: site Affects Versions: 1.3.0-beta1, 1.3.0-beta2 Reporter: Brandon Harper After perusing the old Wicket website as well as the new one at wicket.apache.org, I can't seem to find the Javadocs for Wicket 1.3 anywhere. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-883) Modification Watcher Task Log
[ https://issues.apache.org/jira/browse/WICKET-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Korbinian Bachl updated WICKET-883: --- Affects Version/s: 1.3.0-beta1 1.3.0-beta2 Modification Watcher Task Log - Key: WICKET-883 URL: https://issues.apache.org/jira/browse/WICKET-883 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3 Environment: General - environement here is Glassfish V2 RC4 Reporter: Korbinian Bachl when deploying wicket in dev-mode you get repeating 13864 [ModificationWatcher Task] ERROR org.apache.wicket.util.resource.UrlResourceStream 's usually per resource missing 1 per second - this is not a real error as wickets resources are not mandatory and should therefore not produce this error and flood the logfiles with it -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-851) WicketTester unusable after subsequent startPage(Page) call
[ https://issues.apache.org/jira/browse/WICKET-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Quenot resolved WICKET-851. - Resolution: Invalid Use startPage(Class) or create your instances of Page within a request cycle (tester.createRequestCycle()), as creating a page involves setting a session attribute unless you're using stateless pages. WicketTester unusable after subsequent startPage(Page) call --- Key: WICKET-851 URL: https://issues.apache.org/jira/browse/WICKET-851 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-beta2 Reporter: Roy van Rijn Assignee: Jean-Baptiste Quenot Priority: Minor Fix For: 1.3.0-beta4 Attachments: wickettestertestfailure.patch When adding two unit-tests to the WicketTesterTest for issue WICKET-848 I ran into the following problem (see patch). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-646) Show proper error message when image not found while testing
[ https://issues.apache.org/jira/browse/WICKET-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Quenot reassigned WICKET-646: --- Assignee: Jean-Baptiste Quenot Show proper error message when image not found while testing Key: WICKET-646 URL: https://issues.apache.org/jira/browse/WICKET-646 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.3.0-beta1 Environment: using the following jars: 12. Jun 15:21 wicket-1.3.0-incubating-SNAPSHOT.jar 12. Jun 15:21 wicket-extensions-1.3.0-incubating-SNAPSHOT.jar 12. Jun 15:21 wicket-spring-1.3.0-incubating-SNAPSHOT.jar 12. Jun 15:21 wicket-spring-annot-1.3.0-incubating-SNAPSHOT.jar jUnit 4.1 Reporter: Sven Schliesing Assignee: Jean-Baptiste Quenot Fix For: 1.3.0-beta4 Attachments: code.txt, stackTrace.txt While testing I came across the following error: junit.framework.AssertionFailedError: expected:WebTestPage but was:DummyHomePage The real error in this is: gfx/offline.gif does not exist. If i change it to a file that exists everything goes fine. If I test it in my Tomcat I get a proper 404: Unable to find package resource [path = default/gfx/offline.gif, style = null, locale = en] see also: http://www.nabble.com/jUnit-testing-and-not-existing-images-tf3907536.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-851) WicketTester unusable after subsequent startPage(Page) call
[ https://issues.apache.org/jira/browse/WICKET-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522504 ] Roy van Rijn commented on WICKET-851: - That sounds more like a workaround (?) Although using startPage(Class) works, IMHO it is not right the framework throws an exception when you call startPage(Page) subsequently. Could I get a second opinion on this? btw. I'm not trying to bug you guys, just trying to make a better framework, don't get me wrong. WicketTester unusable after subsequent startPage(Page) call --- Key: WICKET-851 URL: https://issues.apache.org/jira/browse/WICKET-851 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-beta2 Reporter: Roy van Rijn Assignee: Jean-Baptiste Quenot Priority: Minor Fix For: 1.3.0-beta4 Attachments: wickettestertestfailure.patch When adding two unit-tests to the WicketTesterTest for issue WICKET-848 I ran into the following problem (see patch). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-646) Do not throw an error when image not found while testing
[ https://issues.apache.org/jira/browse/WICKET-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Quenot resolved WICKET-646. - Resolution: Fixed Fixed, thanks for reporting! Do not throw an error when image not found while testing Key: WICKET-646 URL: https://issues.apache.org/jira/browse/WICKET-646 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.3.0-beta1 Environment: using the following jars: 12. Jun 15:21 wicket-1.3.0-incubating-SNAPSHOT.jar 12. Jun 15:21 wicket-extensions-1.3.0-incubating-SNAPSHOT.jar 12. Jun 15:21 wicket-spring-1.3.0-incubating-SNAPSHOT.jar 12. Jun 15:21 wicket-spring-annot-1.3.0-incubating-SNAPSHOT.jar jUnit 4.1 Reporter: Sven Schliesing Assignee: Jean-Baptiste Quenot Fix For: 1.3.0-beta4 Attachments: code.txt, stackTrace.txt While testing I came across the following error: junit.framework.AssertionFailedError: expected:WebTestPage but was:DummyHomePage The real error in this is: gfx/offline.gif does not exist. If i change it to a file that exists everything goes fine. If I test it in my Tomcat I get a proper 404: Unable to find package resource [path = default/gfx/offline.gif, style = null, locale = en] see also: http://www.nabble.com/jUnit-testing-and-not-existing-images-tf3907536.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r569418 - in /wicket/trunk/jdk-1.4/wicket/src: main/java/org/apache/wicket/markup/html/PackageResource.java test/java/org/apache/wicket/markup/html/PackageResourceTest.java
Author: jbq Date: Fri Aug 24 08:26:54 2007 New Revision: 569418 URL: http://svn.apache.org/viewvc?rev=569418view=rev Log: WICKET-646 Do not throw an error when image not found while testing Modified: wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/PackageResource.java wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/PackageResourceTest.java Modified: wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/PackageResource.java URL: http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/PackageResource.java?rev=569418r1=569417r2=569418view=diff == --- wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/PackageResource.java (original) +++ wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/PackageResource.java Fri Aug 24 08:26:54 2007 @@ -106,8 +106,6 @@ private static final long serialVersionUID = 1L; - private boolean probingOnly = false; - /** * Binds the resources that match the provided pattern to the given application object. Will * create any resources if not already in the shared resources of the application object. @@ -485,16 +483,14 @@ if (locale != null) { - // Request to silently ignore unresolvable resources as we are not serving the resource for now - probingOnly = true; - - // Get the resource stream so that the real locale that could be - // resolved is set. - getResourceStream(); + /* +* Get the resource stream so that the real locale that could be resolved is set. +* Silently ignore unresolvable resources as we are not serving the resource for now +*/ + getResourceStream(false); // Invalidate it again so that it won't hold up resources invalidate(); - probingOnly = false; } } @@ -533,6 +529,15 @@ */ public IResourceStream getResourceStream() { + return getResourceStream(true); + } + + /** +* @return Gets the resource for the component. +* @param failOnError throw an AbortException when resource does not exist +*/ + public IResourceStream getResourceStream(boolean failOnError) + { // Locate resource IResourceStream resourceStream = Application.get().getResourceSettings() .getResourceStreamLocator().locate(getScope(), absolutePath, style, locale, null); @@ -540,7 +545,7 @@ // Check that resource was found if (resourceStream == null) { - if (probingOnly) + if (! failOnError) { // Do not abort the request, as we are not yet serving the resource return null; Modified: wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/PackageResourceTest.java URL: http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/PackageResourceTest.java?rev=569418r1=569417r2=569418view=diff == --- wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/PackageResourceTest.java (original) +++ wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/PackageResourceTest.java Fri Aug 24 08:26:54 2007 @@ -16,9 +16,13 @@ */ package org.apache.wicket.markup.html; +import java.util.Locale; + import junit.framework.TestCase; +import org.apache.wicket.AbortException; import org.apache.wicket.Application; +import org.apache.wicket.Resource; import org.apache.wicket.SharedResources; import org.apache.wicket.protocol.http.WebApplication; import org.apache.wicket.util.tester.WicketTester; @@ -85,6 +89,23 @@ assertTrue(guard.accept(PackageResourceTest.class, .Bar)); assertTrue(guard.accept(PackageResourceTest.class, .java)); assertFalse(guard.accept(PackageResourceTest.class, Bar.java)); + } + + public void testInvalidPackageResource() throws Exception + { + final SharedResources sharedResources = Application.get().getSharedResources(); + Resource invalidResource = new PackageResource(PackageResourceTest.class, packaged3.txt, Locale.ENGLISH, null); + assertNotNull(resource packaged3.txt SHOULD be available as a packaged resource even if it doesn't exist, +
svn commit: r569476 - /wicket/trunk/pom.xml
Author: knopp Date: Fri Aug 24 11:43:35 2007 New Revision: 569476 URL: http://svn.apache.org/viewvc?rev=569476view=rev Log: Update jetty version Modified: wicket/trunk/pom.xml Modified: wicket/trunk/pom.xml URL: http://svn.apache.org/viewvc/wicket/trunk/pom.xml?rev=569476r1=569475r2=569476view=diff == --- wicket/trunk/pom.xml (original) +++ wicket/trunk/pom.xml Fri Aug 24 11:43:35 2007 @@ -304,13 +304,13 @@ dependency groupIdorg.mortbay.jetty/groupId artifactIdjetty/artifactId - version6.1.1/version + version6.1.5/version scopeprovided/scope /dependency dependency groupIdorg.mortbay.jetty/groupId artifactIdservlet-api-2.5/artifactId - version6.1.1/version + version6.1.5/version scopeprovided/scope /dependency dependency @@ -322,13 +322,13 @@ dependency groupIdorg.mortbay.jetty/groupId artifactIdjetty-util/artifactId - version6.1.1/version + version6.1.5/version scopeprovided/scope /dependency dependency groupIdorg.mortbay.jetty/groupId artifactIdjetty-management/artifactId - version6.1.1/version + version6.1.5/version scopeprovided/scope /dependency dependency