[jira] Commented: (WICKET-1221) setRequired(true) will force a Checkbox to be checked

2008-01-30 Thread Eelco Hillenius (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564319#action_12564319
 ] 

Eelco Hillenius commented on WICKET-1221:
-

I agree this behavior is weird

> setRequired(true) will force a Checkbox to be checked
> -
>
> Key: WICKET-1221
> URL: https://issues.apache.org/jira/browse/WICKET-1221
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-beta4
>Reporter: Kent Tong
>Assignee: Igor Vaynberg
>Priority: Minor
>
> If you call setRequired(true) on a Checkbox, then if the user clear the 
> checkbox, it will be treated as an error. Suggest overriding checkRequired() 
> in the Checkbox class to always return true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-1221) setRequired(true) will force a Checkbox to be checked

2008-01-30 Thread Igor Vaynberg (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564307#action_12564307
 ] 

Igor Vaynberg commented on WICKET-1221:
---

no, you should - its your issue

> setRequired(true) will force a Checkbox to be checked
> -
>
> Key: WICKET-1221
> URL: https://issues.apache.org/jira/browse/WICKET-1221
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-beta4
>Reporter: Kent Tong
>Assignee: Igor Vaynberg
>Priority: Minor
>
> If you call setRequired(true) on a Checkbox, then if the user clear the 
> checkbox, it will be treated as an error. Suggest overriding checkRequired() 
> in the Checkbox class to always return true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-1221) setRequired(true) will force a Checkbox to be checked

2008-01-30 Thread Kent Tong (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564305#action_12564305
 ] 

Kent Tong commented on WICKET-1221:
---

You will start a vote, right?

> setRequired(true) will force a Checkbox to be checked
> -
>
> Key: WICKET-1221
> URL: https://issues.apache.org/jira/browse/WICKET-1221
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-beta4
>Reporter: Kent Tong
>Assignee: Igor Vaynberg
>Priority: Minor
>
> If you call setRequired(true) on a Checkbox, then if the user clear the 
> checkbox, it will be treated as an error. Suggest overriding checkRequired() 
> in the Checkbox class to always return true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-1221) setRequired(true) will force a Checkbox to be checked

2008-01-30 Thread Igor Vaynberg (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564299#action_12564299
 ] 

Igor Vaynberg commented on WICKET-1221:
---

i think so, i was hoping more core devs would give their opinion, but only 
johan participated.

> setRequired(true) will force a Checkbox to be checked
> -
>
> Key: WICKET-1221
> URL: https://issues.apache.org/jira/browse/WICKET-1221
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-beta4
>Reporter: Kent Tong
>Assignee: Igor Vaynberg
>Priority: Minor
>
> If you call setRequired(true) on a Checkbox, then if the user clear the 
> checkbox, it will be treated as an error. Suggest overriding checkRequired() 
> in the Checkbox class to always return true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (WICKET-1307) autolinked resources have locale appended

2008-01-30 Thread Eelco Hillenius (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eelco Hillenius resolved WICKET-1307.
-

   Resolution: Fixed
Fix Version/s: 1.3.2

> autolinked resources have locale appended
> -
>
> Key: WICKET-1307
> URL: https://issues.apache.org/jira/browse/WICKET-1307
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-final, 1.3.1
>Reporter: Nathan Hamblen
>Priority: Minor
> Fix For: 1.3.2
>
> Attachments: resource.patch
>
>
> For a resource that does not have a locale-specific file, it should be 
> appended to the resource key. This works correctly for the first request to a 
> page with the autolinked resource; you get a file name that matches the one 
> in the sources. But on all following requests a locale (like _en_US) will be 
> inserted into the name. While the resource can be served (because it's been 
> added to the shared resource pool) this name has a significant downside. It 
> can not be resolved in reverse. Therefore, if the server is restarted and a 
> client already knows of that resource location including the _en_US and 
> requests it before requesting the page that auto-link it, a 404 such as this 
> is returned:
> Unable to find package resource [path = 
> ts4/web/wicket/component/FeedbackPanel_en_US.css, style = null, locale = null]
> Futhermore, all future requests will fail, even after the page with the 
> component has rendered, because the bad resource specifier has been added to 
> the pool.
> The reason for this behavior is complicated, but it comes down to this static 
> method:
> PackageResource.get(final Class scope, final String path, final Locale 
> locale, final String style)
> Not only goes it "get" the resource, it adds it to the resource pool. The 
> autolinker, in the course of finding the right resource (with a locale 
> matching actual file names) inadvertently adds the wrong resource by trying 
> to get it as a test. It discovers the right resource and serves it with that 
> name on the first request, but following that it is able to find the resource 
> in the pool with the wrong name and so serves it in that manner.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r616986 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/PackageResource.java

2008-01-30 Thread ehillenius
Author: ehillenius
Date: Wed Jan 30 18:02:38 2008
New Revision: 616986

URL: http://svn.apache.org/viewvc?rev=616986&view=rev
Log:
WICKET-1307

Modified:

wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/PackageResource.java

Modified: 
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/PackageResource.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/PackageResource.java?rev=616986&r1=616985&r2=616986&view=diff
==
--- 
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/PackageResource.java
 (original)
+++ 
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/PackageResource.java
 Wed Jan 30 18:02:38 2008
@@ -408,7 +408,6 @@
if (resource == null)
{
resource = new PackageResource(scope, path, locale, 
style);
-   sharedResources.add(scope, path, locale, style, 
resource);
}
return resource;
}




[jira] Resolved: (WICKET-1314) DateTimeField does not correct the timezone properly

2008-01-30 Thread Eelco Hillenius (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eelco Hillenius resolved WICKET-1314.
-

   Resolution: Fixed
Fix Version/s: 1.3.2

> DateTimeField does not correct the timezone properly
> 
>
> Key: WICKET-1314
> URL: https://issues.apache.org/jira/browse/WICKET-1314
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-datetime
>Affects Versions: 1.3.0-final
>Reporter: Ryan Gravener
> Fix For: 1.3.2
>
> Attachments: dtf.patch
>
>
> The DateTimeField has a DateTextField which uses a styledateconverter with 
> timezone correction set to true which is not needed since the DateTimeField 
> accounts for the TimeZone correction.  Another problem is that the 
> DateTimeField only sets the timezone of the date (from local->client), 
> causing the date to be corrected to the local time.  This should instead 
> cause the local time to reflect that of the clients time.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r616983 - /wicket/trunk/jdk-1.4/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java

2008-01-30 Thread ehillenius
Author: ehillenius
Date: Wed Jan 30 17:55:16 2008
New Revision: 616983

URL: http://svn.apache.org/viewvc?rev=616983&view=rev
Log:
WICKET-1314

Modified:

wicket/trunk/jdk-1.4/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java

Modified: 
wicket/trunk/jdk-1.4/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java?rev=616983&r1=616982&r2=616983&view=diff
==
--- 
wicket/trunk/jdk-1.4/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
 (original)
+++ 
wicket/trunk/jdk-1.4/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
 Wed Jan 30 17:55:16 2008
@@ -23,6 +23,7 @@
 import java.util.TimeZone;
 
 import org.apache.wicket.Session;
+import org.apache.wicket.datetime.StyleDateConverter;
 import org.apache.wicket.datetime.markup.html.form.DateTextField;
 import org.apache.wicket.markup.html.form.DropDownChoice;
 import org.apache.wicket.markup.html.form.FormComponentPanel;
@@ -287,12 +288,6 @@
 
try
{
-   TimeZone zone = getClientTimeZone();
-   if (zone != null)
-   {
-   
date.setZone(DateTimeZone.forTimeZone(zone));
-   }
-
boolean use12HourFormat = use12HourFormat();
if (hours != null)
{
@@ -305,6 +300,13 @@

date.set(DateTimeFieldType.halfdayOfDay(), amOrPm == AM_PM.PM ? 1 : 0);
}
 
+   TimeZone zone = getClientTimeZone();
+   if (zone != null)
+   {
+   
date.setMillis(DateTimeZone.getDefault().getMillisKeepLocal(
+   
DateTimeZone.forTimeZone(zone), date.getMillis()));
+   }
+
// the date will be in the server's timezone
setConvertedInput(date.toDate());
}
@@ -338,7 +340,7 @@
 */
protected DateTextField newDateTextField(String id, PropertyModel 
dateFieldModel)
{
-   return DateTextField.forShortStyle(id, dateFieldModel);
+   return new DateTextField(id, dateFieldModel, new 
StyleDateConverter(false));
}
 
/**




[jira] Commented: (WICKET-1221) setRequired(true) will force a Checkbox to be checked

2008-01-30 Thread Kent Tong (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564266#action_12564266
 ] 

Kent Tong commented on WICKET-1221:
---

Please see the thread at 
http://www.nabble.com/%22required%22-for-Checkbox-ts14662131.html#a14680214

Do you think a vote is needed?

> setRequired(true) will force a Checkbox to be checked
> -
>
> Key: WICKET-1221
> URL: https://issues.apache.org/jira/browse/WICKET-1221
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-beta4
>Reporter: Kent Tong
>Assignee: Igor Vaynberg
>Priority: Minor
>
> If you call setRequired(true) on a Checkbox, then if the user clear the 
> checkbox, it will be treated as an error. Suggest overriding checkRequired() 
> in the Checkbox class to always return true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1314) DateTimeField does not correct the timezone properly

2008-01-30 Thread Ryan Gravener (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan Gravener updated WICKET-1314:
--

Attachment: dtf.patch

Enclosed is a patch.

> DateTimeField does not correct the timezone properly
> 
>
> Key: WICKET-1314
> URL: https://issues.apache.org/jira/browse/WICKET-1314
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-datetime
>Affects Versions: 1.3.0-final
>Reporter: Ryan Gravener
> Attachments: dtf.patch
>
>
> The DateTimeField has a DateTextField which uses a styledateconverter with 
> timezone correction set to true which is not needed since the DateTimeField 
> accounts for the TimeZone correction.  Another problem is that the 
> DateTimeField only sets the timezone of the date (from local->client), 
> causing the date to be corrected to the local time.  This should instead 
> cause the local time to reflect that of the clients time.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (WICKET-1314) DateTimeField does not correct the timezone properly

2008-01-30 Thread Ryan Gravener (JIRA)
DateTimeField does not correct the timezone properly


 Key: WICKET-1314
 URL: https://issues.apache.org/jira/browse/WICKET-1314
 Project: Wicket
  Issue Type: Bug
  Components: wicket-datetime
Affects Versions: 1.3.0-final
Reporter: Ryan Gravener


The DateTimeField has a DateTextField which uses a styledateconverter with 
timezone correction set to true which is not needed since the DateTimeField 
accounts for the TimeZone correction.  Another problem is that the 
DateTimeField only sets the timezone of the date (from local->client), causing 
the date to be corrected to the local time.  This should instead cause the 
local time to reflect that of the clients time.   


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1313) Created Norwegian translation of Application.properties

2008-01-30 Thread Edvin Syse (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edvin Syse updated WICKET-1313:
---

Attachment: Palette.properties

Here's one for the default also, if you want :)

> Created Norwegian translation of Application.properties
> ---
>
> Key: WICKET-1313
> URL: https://issues.apache.org/jira/browse/WICKET-1313
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-final
>Reporter: Edvin Syse
>Assignee: Frank Bille Jensen
>Priority: Trivial
> Fix For: 1.3.1
>
> Attachments: Application_no.properties, Palette.properties, 
> Palette_no.properties, wicket_no.tar.gz
>
>
> Attached is the Norwegian translation, Application_no.properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1313) Created Norwegian translation of Application.properties

2008-01-30 Thread Edvin Syse (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edvin Syse updated WICKET-1313:
---

Attachment: Palette_no.properties

This one is for org.apache.wicket.extensions.markup.html.form.palette.Palette. 
It seems it doesn't have a default Palette.properties file, the component just 
uses default values like this:

protected Component newAvailableHeader(String componentId)
{
return new Label(componentId, getString("palette.available", 
null, "Available"));
}

That's why I missed it :)

> Created Norwegian translation of Application.properties
> ---
>
> Key: WICKET-1313
> URL: https://issues.apache.org/jira/browse/WICKET-1313
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-final
>Reporter: Edvin Syse
>Assignee: Frank Bille Jensen
>Priority: Trivial
> Fix For: 1.3.1
>
> Attachments: Application_no.properties, Palette_no.properties, 
> wicket_no.tar.gz
>
>
> Attached is the Norwegian translation, Application_no.properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-1313) Created Norwegian translation of Application.properties

2008-01-30 Thread Edvin Syse (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564196#action_12564196
 ] 

Edvin Syse commented on WICKET-1313:


Hehe.. No, actually it could be lightbeer, that's allowed. I'll try to call 
some breweries tomorrow and enquire :)





> Created Norwegian translation of Application.properties
> ---
>
> Key: WICKET-1313
> URL: https://issues.apache.org/jira/browse/WICKET-1313
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-final
>Reporter: Edvin Syse
>Assignee: Frank Bille Jensen
>Priority: Trivial
> Fix For: 1.3.1
>
> Attachments: Application_no.properties, wicket_no.tar.gz
>
>
> Attached is the Norwegian translation, Application_no.properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r616920 - /wicket/trunk/jdk-1.5/wicket-auth-roles/src/main/java/org/apache/wicket/authentication/AuthenticatedWebSession.java

2008-01-30 Thread gseitz
Author: gseitz
Date: Wed Jan 30 14:08:59 2008
New Revision: 616920

URL: http://svn.apache.org/viewvc?rev=616920&view=rev
Log:
deprecated constructor AuthenticatedWebSession(Application, Request)
added constructor AuthenticatedWebSession(Request)

Modified:

wicket/trunk/jdk-1.5/wicket-auth-roles/src/main/java/org/apache/wicket/authentication/AuthenticatedWebSession.java

Modified: 
wicket/trunk/jdk-1.5/wicket-auth-roles/src/main/java/org/apache/wicket/authentication/AuthenticatedWebSession.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.5/wicket-auth-roles/src/main/java/org/apache/wicket/authentication/AuthenticatedWebSession.java?rev=616920&r1=616919&r2=616920&view=diff
==
--- 
wicket/trunk/jdk-1.5/wicket-auth-roles/src/main/java/org/apache/wicket/authentication/AuthenticatedWebSession.java
 (original)
+++ 
wicket/trunk/jdk-1.5/wicket-auth-roles/src/main/java/org/apache/wicket/authentication/AuthenticatedWebSession.java
 Wed Jan 30 14:08:59 2008
@@ -25,13 +25,13 @@
 /**
  * Basic authenticated web session. Subclasses must provide a method that 
authenticates the session
  * based on a username and password, and a method implementation that gets the 
Roles
- * 
+ *
  * @author Jonathan Locke
  */
 public abstract class AuthenticatedWebSession extends WebSession
 {
/**
-* 
+*
 */
private static final long serialVersionUID = 1L;
 
@@ -48,21 +48,33 @@
 
/**
 * Construct.
-* 
+*
 * @param application
 *The web application
 * @param request
 *The current request object
-* @param response
+* @deprecated Use [EMAIL PROTECTED] #AuthenticatedWebSession(Request)}
 */
+   @Deprecated
public AuthenticatedWebSession(final AuthenticatedWebApplication 
application, Request request)
{
super(application, request);
}
 
/**
+* Construct.
+*
+* @param request
+*The current request object
+*/
+   public AuthenticatedWebSession(Request request)
+   {
+   super(request);
+   }
+
+   /**
 * Authenticates this session using the given username and password
-* 
+*
 * @param username
 *The username
 * @param password
@@ -86,7 +98,7 @@
 
/**
 * Signs user in by authenticating them with a username and password
-* 
+*
 * @param username
 *The username
 * @param password




svn commit: r616916 - in /wicket/trunk: ./ archetypes/quickstart/ archetypes/quickstart/src/main/resources/archetype-resources/ jdk-1.4/ jdk-1.4/wicket-datetime/ jdk-1.4/wicket-extensions/ jdk-1.4/wic

2008-01-30 Thread frankbille
Author: frankbille
Date: Wed Jan 30 13:55:16 2008
New Revision: 616916

URL: http://svn.apache.org/viewvc?rev=616916&view=rev
Log:
Return to 1.3-SNAPSHOT numbering. See discussion here:
http://mail-archives.apache.org/mod_mbox/wicket-dev/200801.mbox/[EMAIL 
PROTECTED]

Modified:
wicket/trunk/archetypes/quickstart/pom.xml

wicket/trunk/archetypes/quickstart/src/main/resources/archetype-resources/pom.xml
wicket/trunk/jdk-1.4/pom.xml
wicket/trunk/jdk-1.4/wicket-datetime/pom.xml
wicket/trunk/jdk-1.4/wicket-extensions/pom.xml
wicket/trunk/jdk-1.4/wicket-ioc/pom.xml
wicket/trunk/jdk-1.4/wicket-quickstart/pom.xml
wicket/trunk/jdk-1.4/wicket-spring/pom.xml
wicket/trunk/jdk-1.4/wicket-velocity/pom.xml
wicket/trunk/jdk-1.4/wicket/pom.xml
wicket/trunk/jdk-1.5/pom.xml
wicket/trunk/jdk-1.5/wicket-auth-roles/pom.xml
wicket/trunk/jdk-1.5/wicket-examples/pom.xml
wicket/trunk/jdk-1.5/wicket-guice/pom.xml
wicket/trunk/jdk-1.5/wicket-jmx/pom.xml
wicket/trunk/jdk-1.5/wicket-objectssizeof-agent/pom.xml
wicket/trunk/jdk-1.5/wicket-spring-annot/pom.xml
wicket/trunk/pom.xml
wicket/trunk/testing/wicket-threadtest/pom.xml

Modified: wicket/trunk/archetypes/quickstart/pom.xml
URL: 
http://svn.apache.org/viewvc/wicket/trunk/archetypes/quickstart/pom.xml?rev=616916&r1=616915&r2=616916&view=diff
==
--- wicket/trunk/archetypes/quickstart/pom.xml (original)
+++ wicket/trunk/archetypes/quickstart/pom.xml Wed Jan 30 13:55:16 2008
@@ -3,7 +3,7 @@
   
org.apache.wicket
wicket-jdk14
-   1.3.0-SNAPSHOT
+   1.3-SNAPSHOT
../../pom.xml
   
   

Modified: 
wicket/trunk/archetypes/quickstart/src/main/resources/archetype-resources/pom.xml
URL: 
http://svn.apache.org/viewvc/wicket/trunk/archetypes/quickstart/src/main/resources/archetype-resources/pom.xml?rev=616916&r1=616915&r2=616916&view=diff
==
--- 
wicket/trunk/archetypes/quickstart/src/main/resources/archetype-resources/pom.xml
 (original)
+++ 
wicket/trunk/archetypes/quickstart/src/main/resources/archetype-resources/pom.xml
 Wed Jan 30 13:55:16 2008
@@ -124,7 +124,7 @@

 

-   1.3.0-SNAPSHOT
+   1.3-SNAPSHOT
6.1.4

 

Modified: wicket/trunk/jdk-1.4/pom.xml
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/pom.xml?rev=616916&r1=616915&r2=616916&view=diff
==
--- wicket/trunk/jdk-1.4/pom.xml (original)
+++ wicket/trunk/jdk-1.4/pom.xml Wed Jan 30 13:55:16 2008
@@ -23,7 +23,7 @@

org.apache.wicket
wicket-parent
-   1.3.0-SNAPSHOT
+   1.3-SNAPSHOT
../pom.xml

 

Modified: wicket/trunk/jdk-1.4/wicket-datetime/pom.xml
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket-datetime/pom.xml?rev=616916&r1=616915&r2=616916&view=diff
==
--- wicket/trunk/jdk-1.4/wicket-datetime/pom.xml (original)
+++ wicket/trunk/jdk-1.4/wicket-datetime/pom.xml Wed Jan 30 13:55:16 2008
@@ -23,7 +23,7 @@

org.apache.wicket
wicket-jdk14
-   1.3.0-SNAPSHOT
+   1.3-SNAPSHOT
../pom.xml

 

Modified: wicket/trunk/jdk-1.4/wicket-extensions/pom.xml
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket-extensions/pom.xml?rev=616916&r1=616915&r2=616916&view=diff
==
--- wicket/trunk/jdk-1.4/wicket-extensions/pom.xml (original)
+++ wicket/trunk/jdk-1.4/wicket-extensions/pom.xml Wed Jan 30 13:55:16 2008
@@ -23,7 +23,7 @@

org.apache.wicket
wicket-jdk14
-   1.3.0-SNAPSHOT
+   1.3-SNAPSHOT
../pom.xml

 

Modified: wicket/trunk/jdk-1.4/wicket-ioc/pom.xml
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket-ioc/pom.xml?rev=616916&r1=616915&r2=616916&view=diff
==
--- wicket/trunk/jdk-1.4/wicket-ioc/pom.xml (original)
+++ wicket/trunk/jdk-1.4/wicket-ioc/pom.xml Wed Jan 30 13:55:16 2008
@@ -23,7 +23,7 @@

org.apache.wicket
wicket-jdk14
-   1.3.0-SNAPSHOT
+   1.3-SNAPSHOT
../pom.xml

 

Modified: wicket/trunk/jdk-1.4/wicket-quickstart/pom.xml
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket-quickstart/pom.xml?rev=616916&r1=616915&r2=616916&view=diff
==
--- wicket/trunk/jdk-1.4/wicket-quickstart/pom.xml (original)
+++ wicket/

svn commit: r616913 - /wicket/trunk/CHANGELOG-1.3

2008-01-30 Thread frankbille
Author: frankbille
Date: Wed Jan 30 13:45:01 2008
New Revision: 616913

URL: http://svn.apache.org/viewvc?rev=616913&view=rev
Log:
Copy 1.3 changelog to trunk so it is included in all future 1.3.x releases

Added:
wicket/trunk/CHANGELOG-1.3
  - copied unchanged from r616912, 
wicket/releases/wicket-1.3.1/CHANGELOG-1.3



[CONF] Apache Wicket: Releasing (page edited)

2008-01-30 Thread confluence










Page Edited :
WICKET :
Releasing



 
Releasing
has been edited by Frank Bille Jensen
(Jan 30, 2008).
 

 
 (View changes)
 

Content:


Releasing Apache Wicket 1.4.x

TBD...

Releasing Apache Wicket 1.3.x

Building the release


	query dev@ for any open issues, it helps to look at jira first
	create tag, create release branch
	check out release branch
	find . -name "pom.xml" | xargs sed -i -e "s/-SNAPSHOT/-beta4/g"
	add JIRA generated release notes to CHANGELOG-1.3
	commit to release branch
	call release.sh
	test the distribution (examples, rat, etc)
	upload m2-repo and dist directory from target/ to p.a.o
	send vote message
	wait
	upload to mirrors (see below)
	wait 24 hours for mirrors to pick them up
	announce



Uploading to the mirror system

http://apache.org/dev/mirror-step-by-step.html

Uploading to maven repository

I haven't got any really good way to put them in the maven mirrors. The problem is that right now we override the meta xml files, so only the latest version is listed. If we really should do this perfect we would modify meta files like /org/apache/wicket/wicket/maven-metadata.xml and add the version to it (as well as create the hashes again).

But for now this is sufficient:


	cd into the directory you have the artifacts which has been voted on.
	cp -R m2-repo/org/apache/wicket/* /www/people.apache.org/repo/m2-ibiblio-rsync-repository/org/apache/wicket/
	chmod -R g+w * /www/people.apache.org/repo/m2-ibiblio-rsync-repository/org/apache/wicket



Further reading: README under /www/people.apache.org/repo/m2-ibiblio-rsync-repository/

Changed quickstart

http://wicket.apache.org/quickstart.html

Announce


	http://wicket.apache.org
	
		http://wicket.apache.org/getting-wicket.html
	
	
	User/Dev/Announce mailing lists
	Misc. websites like javalobby, serverside, onjava etc.



Releasing Apache Wicket 1.2.x

TBD...











Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences








svn commit: r616901 - in /wicket/releases/wicket-1.3.1: ./ archetypes/quickstart/ archetypes/quickstart/src/main/resources/archetype-resources/ jdk-1.4/ jdk-1.4/wicket-datetime/ jdk-1.4/wicket-extensi

2008-01-30 Thread frankbille
Author: frankbille
Date: Wed Jan 30 12:59:59 2008
New Revision: 616901

URL: http://svn.apache.org/viewvc?rev=616901&view=rev
Log:
Releasing Apache Wicket 1.3.1

Added:
wicket/releases/wicket-1.3.1/CHANGELOG-1.3
wicket/releases/wicket-1.3.1/migrate-13.html
  - copied unchanged from r616892, wicket/trunk/migrate-13.html
Modified:
wicket/releases/wicket-1.3.1/NOTICE
wicket/releases/wicket-1.3.1/README
wicket/releases/wicket-1.3.1/archetypes/quickstart/pom.xml

wicket/releases/wicket-1.3.1/archetypes/quickstart/src/main/resources/archetype-resources/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.4/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.4/wicket-datetime/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.4/wicket-extensions/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.4/wicket-ioc/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.4/wicket-quickstart/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.4/wicket-spring/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.4/wicket-velocity/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.4/wicket/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.5/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.5/wicket-auth-roles/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.5/wicket-examples/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.5/wicket-guice/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.5/wicket-jmx/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.5/wicket-objectssizeof-agent/pom.xml
wicket/releases/wicket-1.3.1/jdk-1.5/wicket-spring-annot/pom.xml
wicket/releases/wicket-1.3.1/pom.xml
wicket/releases/wicket-1.3.1/testing/wicket-threadtest/pom.xml
wicket/releases/wicket-1.3.1/wicket-assembly-all.xml

Added: wicket/releases/wicket-1.3.1/CHANGELOG-1.3
URL: 
http://svn.apache.org/viewvc/wicket/releases/wicket-1.3.1/CHANGELOG-1.3?rev=616901&view=auto
==
--- wicket/releases/wicket-1.3.1/CHANGELOG-1.3 (added)
+++ wicket/releases/wicket-1.3.1/CHANGELOG-1.3 Wed Jan 30 12:59:59 2008
@@ -0,0 +1,40 @@
+This file contains the changes done to the 1.3.x releases sinse 1.3-final.
+
+Release Notes - Wicket - Version 1.3.1
+
+
+** Bug
+* [WICKET-812] - Submit button, multipart content and UploadProgressBar
+* [WICKET-989] - DatePicker: NaN if numerical input cannot be parsed
+* [WICKET-1184] - PageSavingThread keeps running after undeploy
+* [WICKET-1194] - UploadProgressBar incompatible with submit buttons 
onSubmit method (in FireFox at least)
+* [WICKET-1243] - the DatePicker show the same week title in china.  
+* [WICKET-1249] - modal.js conflicts with mootools and possibly other 
javascript frameworks. + patch fix
+* [WICKET-1254] - Binding to a BigDecimal don't honor browser locale
+* [WICKET-1257] - iframe get request done 2x after ajax change in IE
+* [WICKET-1258] - AjaxFormChoiceComponentUpdatingBehavior assumes 
Radio/Choice items are a direct child of the group in the client-side DOM
+* [WICKET-1260] - CheckBox.setRequired() is not picked up in 1.3-final
+* [WICKET-1262] - Page#readResolve is not called
+* [WICKET-1263] - Using nested wicket:enclosure throws exception
+* [WICKET-1264] - assertComponentOnAjaxResponse does not work with 
WicketTester.clickLink
+* [WICKET-1270] - NPE in ListMultipleChoice.updateModel()
+* [WICKET-1271] - Script in RenderHead method of 
AjaxFormChoiceComponentUpdatingBehavior needs fixing
+* [WICKET-1274] - Only properties from first panel-implementation loaded 
when using different implementations of an abstract panel on the same page
+* [WICKET-1275] - FLAG_HAS_BEEN_RENDERED is set when rendering invisible 
components
+* [WICKET-1277] - When no component is focused on AjaxRequestTarget, 
wicket tries to focus element with id 'null'
+* [WICKET-1282] - AjaxFormSubmitBehavior doesn't work well with nested 
forms
+* [WICKET-1290] - PrependingStringBuffer.equals(Object obj) is not 
reflexive
+* [WICKET-1304] - Form processing workflow is broken for 
FormComponentPanels
+
+** Improvement
+* [WICKET-1020] - expose configuration of CompoundValidator, 
NumberValidator
+* [WICKET-1193] - i18n: Translation of resource files in Korean
+* [WICKET-1252] - Default start week day based on locale
+* [WICKET-1272] - Better clustering support for DiskPageStore
+* [WICKET-1283] - Allow to query component markup id without creating one
+* [WICKET-1284] - Report last focused element id on ajax request
+* [WICKET-1293] - Improve SelectOptions: allow customization of created 
SelectOption objects
+* [WICKET-1299] - HybridUrlCodingStrategy should throw a 
PageExpiredException if a RequestListenerInterface is targeted on a 
non-existent page-id/version
+* [WICKET-1309] - Properties files translation (_es)
+* [WICKET-1313] - Created Norwegian translation of Application.properties
+

Modified: wicket/releases/wicket-1.3.1/NOTICE
URL: 
http://sv

[jira] Commented: (WICKET-1313) Created Norwegian translation of Application.properties

2008-01-30 Thread Frank Bille Jensen (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564166#action_12564166
 ] 

Frank Bille Jensen commented on WICKET-1313:


Hehe, you really think it would be a problem legally? If that really is so then 
what about a picture of nice pint of no-name beer?

> Created Norwegian translation of Application.properties
> ---
>
> Key: WICKET-1313
> URL: https://issues.apache.org/jira/browse/WICKET-1313
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-final
>Reporter: Edvin Syse
>Assignee: Frank Bille Jensen
>Priority: Trivial
> Fix For: 1.3.1
>
> Attachments: Application_no.properties, wicket_no.tar.gz
>
>
> Attached is the Norwegian translation, Application_no.properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[CONF] Apache Wicket: Releasing (page edited)

2008-01-30 Thread confluence










Page Edited :
WICKET :
Releasing



 
Releasing
has been edited by Frank Bille Jensen
(Jan 30, 2008).
 

 
 (View changes)
 

Content:


Releasing Apache Wicket 1.4.x

TBD...

Releasing Apache Wicket 1.3.x

Building the release


	query dev@ for any open issues, it helps to look at jira first
	create tag, create release branch
	check out release branch
	find . -name "pom.xml" | xargs sed -i -e "s/-SNAPSHOT/-beta4/g"
	add JIRA generated release notes to CHANGELOG-1.3
	commit to release branch
	call release.sh
	test the distribution (examples, rat, etc)
	upload m2-repo and dist directory from target/ to p.a.o
	send vote message
	wait
	upload to mirrors (see below)
	wait 24 hours for mirrors to pick them up
	announce



Uploading to the mirror system

http://apache.org/dev/mirror-step-by-step.html

Uploading to maven repository

I haven't got any really good way to put them in the maven mirrors. The problem is that right now we override the meta xml files, so only the latest version is listed. If we really should do this perfect we would modify meta files like /org/apache/wicket/wicket/maven-metadata.xml and add the version to it (as well as create the hashes again).

But for now this is sufficient:


	cd into the directory you have the artifacts which has been voted on.
	cp -R m2-repo/org/apache/wicket/* /www/people.apache.org/repo/m2-ibiblio-rsync-repository/org/apache/wicket/
	chmod -R g+w * /www/people.apache.org/repo/m2-ibiblio-rsync-repository/org/apache/wicket



Further reading: README under /www/people.apache.org/repo/m2-ibiblio-rsync-repository/

Announce


	http://wicket.apache.org
	
		http://wicket.apache.org/getting-wicket.html
	
	
	User/Dev/Announce mailing lists
	Misc. websites like javalobby, serverside, onjava etc.



Releasing Apache Wicket 1.2.x

TBD...











Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences








[jira] Commented: (WICKET-1313) Created Norwegian translation of Application.properties

2008-01-30 Thread Edvin Syse (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564163#action_12564163
 ] 

Edvin Syse commented on WICKET-1313:


I'm afraid Norway is so uptight that beer-commercials are illegal, and I think 
it would be hard to get hold of a picture that could be used 
legally. I'll come back to it if we ever get that stick out of our asses :)

-- Edvin




> Created Norwegian translation of Application.properties
> ---
>
> Key: WICKET-1313
> URL: https://issues.apache.org/jira/browse/WICKET-1313
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-final
>Reporter: Edvin Syse
>Assignee: Frank Bille Jensen
>Priority: Trivial
> Fix For: 1.3.1
>
> Attachments: Application_no.properties, wicket_no.tar.gz
>
>
> Attached is the Norwegian translation, Application_no.properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r616892 - in /wicket/trunk: README migrate-13.html wicket-assembly-all.xml

2008-01-30 Thread frankbille
Author: frankbille
Date: Wed Jan 30 12:40:06 2008
New Revision: 616892

URL: http://svn.apache.org/viewvc?rev=616892&view=rev
Log:
Merged migration guide from the 1.3.0 final release branck, so we have it for 
all the 1.3.x releases

Added:
wicket/trunk/migrate-13.html
  - copied unchanged from r607428, 
wicket/releases/wicket-1.3.0/migrate-13.html
Modified:
wicket/trunk/README
wicket/trunk/wicket-assembly-all.xml

Modified: wicket/trunk/README
URL: 
http://svn.apache.org/viewvc/wicket/trunk/README?rev=616892&r1=616891&r2=616892&view=diff
==
--- wicket/trunk/README (original)
+++ wicket/trunk/README Wed Jan 30 12:40:06 2008
@@ -197,7 +197,11 @@
 Migrating from 1.2
 --
 
-There is a migration guide available on our Wiki:
+We have included a migration guide in the distribution called:
+
+migrate-13.html
+
+This file is a copy of the migration guide from available on our Wiki:
 
 http://cwiki.apache.org/WICKET/migrate-13.html
 
@@ -207,7 +211,7 @@
  - Read the online documentation available on our website
(http://wicket.apache.org)
 
- - Read the migration guide (http://cwiki.apache.org/WICKET/migrate-13.html)
+ - Read the migration guide (migrate-13.html)
 
  - Read the mailing archives available on Nabble, GMane and Apache
 

Modified: wicket/trunk/wicket-assembly-all.xml
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-assembly-all.xml?rev=616892&r1=616891&r2=616892&view=diff
==
--- wicket/trunk/wicket-assembly-all.xml (original)
+++ wicket/trunk/wicket-assembly-all.xml Wed Jan 30 12:40:06 2008
@@ -101,6 +101,7 @@
LICENSE
NOTICE
README
+   migrate-13.html
DISCLAIMER
licenses/**





[jira] Updated: (WICKET-1221) setRequired(true) will force a Checkbox to be checked

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1221:
---

Fix Version/s: (was: 1.3.1)

> setRequired(true) will force a Checkbox to be checked
> -
>
> Key: WICKET-1221
> URL: https://issues.apache.org/jira/browse/WICKET-1221
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-beta4
>Reporter: Kent Tong
>Assignee: Igor Vaynberg
>Priority: Minor
>
> If you call setRequired(true) on a Checkbox, then if the user clear the 
> checkbox, it will be treated as an error. Suggest overriding checkRequired() 
> in the Checkbox class to always return true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-569) Add AjaxLink factory method to ModalWindow

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-569:
--

Fix Version/s: (was: 1.3.1)

> Add AjaxLink factory method to ModalWindow
> --
>
> Key: WICKET-569
> URL: https://issues.apache.org/jira/browse/WICKET-569
> Project: Wicket
>  Issue Type: New Feature
>  Components: wicket
>Affects Versions: 1.3.0-beta1
> Environment: java 1.4
>Reporter: Scott Swank
>Assignee: Matej Knopp
>Priority: Trivial
>
>public AjaxLink createAjaxLink(String linkId)
>{
>return new AjaxLink(linkId)
>{
>private static final long serialVersionUID = 0L;
>@Override
>public void onClick(AjaxRequestTarget target)
>{
>ModalWindow.this.show(target);
>}
>};
>}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1279) newConverterLocater created before Spring Injection

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1279:
---

Fix Version/s: (was: 1.3.1)

> newConverterLocater created before Spring Injection
> ---
>
> Key: WICKET-1279
> URL: https://issues.apache.org/jira/browse/WICKET-1279
> Project: Wicket
>  Issue Type: Task
>Affects Versions: 1.3.0-final
> Environment: n/a
>Reporter: Karen Schaper
>Assignee: Eelco Hillenius
>Priority: Minor
>
> When upgrading to wicket 1.3 I had to use a new way of registering 
> converters.  The issue is that the newConverterLocater method is called 
> before any Spring injection takes place.  I couldn't call 
> InjectorHolder.getInjector().inject( this ) in my converter class.
> Eelco asked me to enter this issue and stated in the mail list that:
> "We should probably create
> the converterLocator and possibly the session store lazily instead of
> in Application#internalInit."
> My workaround was to put the  
> addComponentInstantiationListener( new SpringComponentInjector( this ) );
> into the newConverterLocator which at least allows my server to start up. 
> Haven't been able to test further since I have any issues now going on.
> My first JIRA entry.
> Karen

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-980) image and ajax update results in browser caching / tell wicket users that they should use noncaching image

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-980:
--

Fix Version/s: (was: 1.3.1)

> image and ajax update results in browser caching / tell wicket users that 
> they should use noncaching image
> --
>
> Key: WICKET-980
> URL: https://issues.apache.org/jira/browse/WICKET-980
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Reporter: Nino Martinez
>Priority: Minor
>
> image and ajax update results in browser caching / tell wicket users that 
> they should use noncaching image.
> proposed fix:
> Write something about it in the javadocs :
> image and ajax does not work when if the image are being updated as the url 
> does not change the browser will cache it. And the "old" image will be shown. 
> Instead use NonCachingImage.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1250) Automatically restart embedded Jetty on file change event

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1250:
---

Fix Version/s: (was: 1.3.1)

> Automatically restart embedded Jetty on file change event
> -
>
> Key: WICKET-1250
> URL: https://issues.apache.org/jira/browse/WICKET-1250
> Project: Wicket
>  Issue Type: New Feature
>  Components: wicket-quickstart
>Affects Versions: 1.3.0-rc2
> Environment: Any
>Reporter: Martin Grigorov
>Assignee: Igor Vaynberg
>Priority: Trivial
> Attachments: WICKET-1250.patch
>
>
> For those of you who like the cool feature of maven-jetty-plugin to 
> automatically restart the web application on change in the (main) sources I'm 
> attaching a patch for wicket-quickstart archetype that brings this 
> functionality in .../Start.java.
> Since it doesn't affect by any means the Wicket core functionalities it will 
> be good to see this feature included in 1.3.0-final.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-945) WicketTester requiring itself to be serializable

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-945:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> WicketTester requiring itself to be serializable
> 
>
> Key: WICKET-945
> URL: https://issues.apache.org/jira/browse/WICKET-945
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-beta3
>Reporter: Kent Tong
> Fix For: 1.3.2
>
>
> Similar to https://issues.apache.org/jira/browse/WICKET-727, in 
> BaseWicketTester, it creates objects of anonymous classes as pages 
> (DummyPanelPage). By definition, they refer to the tester itself and will try 
> to drag it in when they're serialized.
> public final Panel startPanel(final Class panelClass)
>   {
>   return (Panel)startPage(new ITestPageSource()
>   {
>   private static final long serialVersionUID = 1L;
>   public Page getTestPage()
>   {
>   return new DummyPanelPage(new TestPanelSource()
>   {
>   private static final long 
> serialVersionUID = 1L;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-551) Empty Mounting Path

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-551:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> Empty Mounting Path
> ---
>
> Key: WICKET-551
> URL: https://issues.apache.org/jira/browse/WICKET-551
> Project: Wicket
>  Issue Type: New Feature
>  Components: wicket
>Affects Versions: 1.3.0-beta1
>Reporter: ywtsang
>Assignee: Alastair Maw
> Fix For: 1.3.2
>
>
> is it possible to "mount" with "empty" path?
> e.g.
> mount(new IndexedParamUrlCodingStrategy("/",  my class, null));
> wicket complains it is not legal
> for my problem
> i want the URL to have something like:
> http://mydomain.com/value1/value2/value3/value4
> where I can "use" IndexdParamUrlCodingStrategy to get the value1, 2, 3, 4 and 
> use the values to do some page dispatch
> so it would be nice to have empty mounting path and the relevant detailed 
> discussion is here:
> http://www.nabble.com/mounting-with-%22empty%22-path-tf3702181.html#a10352898

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-431) Modal window can not be closed after session timeout

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-431:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> Modal window can not be closed after session timeout
> 
>
> Key: WICKET-431
> URL: https://issues.apache.org/jira/browse/WICKET-431
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 1.2.5, 1.3.0-beta1
> Environment: tested on Linux FF / Windows FF
>Reporter: francisdb
>Assignee: Matej Knopp
>Priority: Minor
> Fix For: 1.3.2
>
>
> After session timeout, clicking on the close button (X) generates a warning 
> message:
> 'Are you sure you want to  Reloading this page will cause the modal 
> window to disappear'
> --> Maybe something about session timeout might be more meaningful?
> If you click 'Cancel' you are stuck with an unclosable modal window, the 
> previous message won't be shown again.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1104) Modal window sticks to cursor on resize

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1104:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> Modal window sticks to cursor on resize
> ---
>
> Key: WICKET-1104
> URL: https://issues.apache.org/jira/browse/WICKET-1104
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket, wicket-extensions
>Affects Versions: 1.3.0-beta4
> Environment: wicket-1.3.0-SNAPSHOT, IE6 SP2
>Reporter: Russell Morrisey
>Assignee: Matej Knopp
>Priority: Minor
> Fix For: 1.3.2
>
> Attachments: quickstart-modalSticksToCursor.zip
>
>
> When resizing the modal window, if the mouse is moved outside of the 
> boundaries of the browser, the modal window gets "stuck" to the mouse and 
> keeps resizing even when the mouse button is released. See detailed 
> instructions in the attached quickstart's modal window.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-932) BaseWicketTester support for SubmitLink

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-932:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> BaseWicketTester support for SubmitLink
> ---
>
> Key: WICKET-932
> URL: https://issues.apache.org/jira/browse/WICKET-932
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 1.3.0-beta2
> Environment: XP, Tomcat
>Reporter: Simon Comley
>Priority: Minor
> Fix For: 1.3.2
>
> Attachments: JIRA932.zip
>
>
> When the SubmitLink is used instead of the submit for forms, BaseWicketTester 
> does not run through the onSubmit() code of the link.
> I have stepped through the debug of the test that's actually not getting 
> called. All my validators on the text field are getting called as expected 
> and in fact the form works as expected when deployed so I'm thinking that it 
> might be a WicketTester issue or the more likely scenario that I'm doing 
> something wrong?
> Things I've tried:
> - debugging as mentioned, but this just shows me it's not getting called
> - trying to call the link directly but I just get the below exception which 
> I'm not really surpised about 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-625) Wicket doesn't clean up properly when hot-deploying; hangs onto Class references.

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-625:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> Wicket doesn't clean up properly when hot-deploying; hangs onto Class 
> references.
> -
>
> Key: WICKET-625
> URL: https://issues.apache.org/jira/browse/WICKET-625
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket, wicket-extensions, wicket-spring
>Affects Versions: 1.3.0-beta1
>Reporter: Alastair Maw
>Assignee: Alastair Maw
> Fix For: 1.3.2
>
> Attachments: WICKET-625.patch
>
>
> When you undeploy a webapp, ideally it should go away and its 
> WebAppClassLoader should be garbage collected. There are various reasons this 
> won't happen, but they essentially split into two problems:
> 1) The App Server has references to classes in the WebAppClassLoader in its 
> own objects (on Tomcat these are typically commons logging statics in 
> StandardContext in catalina, or some of the jakarta code). There's not much 
> you can do about this, short of getting a better app server.
> 2) You hold references to Class objects loaded by your WebAppClassLoader in 
> static fields in other Classes loaded by your WebAppClassLoader.
> Number 2 can be solved by the use of WeakReferences to the Class objects.
> Note that you also need to be careful about classes that have Class 
> references internally, such as java.lang.reflect.Method and Field. You can 
> also hold these items in a WeakReference, but they have the potential to be 
> garbage collected randomly, unlike the underlying Class objects.
> I have some patches that allow me to start up and shut down a Spring-backed 
> Wicket-based app and have the classloader cope properly. They could probably 
> do with some review.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1161) DiskPageStore should write the sessions index file to disk on destroy (from WicketFilter.destroy())

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1161:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> DiskPageStore should write the sessions index file to disk on destroy (from 
> WicketFilter.destroy())
> ---
>
> Key: WICKET-1161
> URL: https://issues.apache.org/jira/browse/WICKET-1161
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-rc1
>Reporter: Johan Compagner
>Assignee: Matej Knopp
> Fix For: 1.3.2
>
>
> We have to save the sessions index to disk from the DiskPageStore when we get 
> a shutdown/destroy from the servlet container
> (I hope that that that event will be called on a servlet container shutdown 
> and on a undeploy/redeploy of the webapp.)
> Then with a destroy we save it. When we are fired up again we read that file 
> and also delete the file immediantly.
> Then when the page store is created and the file isn't there it can delete 
> all the page stores files that are currently on disk
> because the destroy didn't happen so it was a crash or a hard kill and there 
> won't be any sessions anyway.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-701) Allow wicket filter-mapping to use servlet-name instead of url-pattern

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-701:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> Allow wicket filter-mapping to use servlet-name instead of url-pattern
> --
>
> Key: WICKET-701
> URL: https://issues.apache.org/jira/browse/WICKET-701
> Project: Wicket
>  Issue Type: New Feature
>  Components: wicket
>Affects Versions: 1.3.1
>Reporter: James Renfro
> Fix For: 1.3.2
>
>
> In the web.xml filter-mapping tag it's possible to map filters to either a 
> url-pattern or a servlet-name. Currently Wicket only allows a url-pattern, 
> and in the getFilterPath code an exception is thrown if servlet-name is used 
> instead. 
> I'm guessing the logic was that if you're going to do a filter-mapping to a 
> servlet then you may as well use WicketServlet. And it looks like the code 
> needs a way to grab the underlying url-pattern -- if you implement the 
> WicketServlet instead, wicket seems to force you to have a servlet-mapping to 
> a url-pattern -- so getFilterPath can calculate relative paths, it looks 
> like...  But there are cases in certain frameworks (Sakai -- 
> www.sakaiproject.org -- is one example) where a portal is forwarding control 
> directly to a servlet by name, and the url-pattern doesn't really make any 
> sense. It'd be cleaner (from the point of view of my code at least) if Wicket 
> would accept that in certain cases there is no url-pattern defined. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-847) setResponsePage redirects to wrong url

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-847:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> setResponsePage redirects to wrong url
> --
>
> Key: WICKET-847
> URL: https://issues.apache.org/jira/browse/WICKET-847
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-beta2
>Reporter: Andrew Klochkov
>Assignee: Alastair Maw
> Fix For: 1.3.2
>
> Attachments: wicket-quickstart.tar.gz
>
>
> When I do setResponsePage(MyHomePage.class) IE tries to show me 
> "my.site.com/./" url and gets 404 response. 
> Firefox just shows "my.site.com" without any troubles. I'm using wicket 
> 1.3-beta2 and WicketFilter mapped to /*. 
> It's being reproduced under tomcat only, jetty works fine. My tomcat version 
> is 5.5.17. 
> Quickstart project which reproduces the bug is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-860) GoAndClearFilter doesn't reset filter form fields

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-860:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> GoAndClearFilter doesn't reset filter form fields
> -
>
> Key: WICKET-860
> URL: https://issues.apache.org/jira/browse/WICKET-860
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Reporter: Tauren Mills
>Priority: Minor
> Fix For: 1.3.2
>
>
> This problem is happening in GoAndClearFilter and FilterForm which are in 
> wicket-extensions, but I'm testing the problem with wicket-phonebook which 
> uses these classes.
> When running wicket-phonebook with filters set, clearing the filters makes 
> the list go back to the default, but the filter form controls are not reset 
> to the default.  Thus, to clear the filters and then refilter on different 
> criteria, the user must manually delete the contents of the text fields and 
> change the drop downs to blank.
> Examining the code in GoAndClearFilter shows that originalState is being 
> kept, which is used for refreshing the table.  But I'm unclear on how to 
> reset form filter values. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-622) Component.toString() is unsafe

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-622:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> Component.toString() is unsafe 
> ---
>
> Key: WICKET-622
> URL: https://issues.apache.org/jira/browse/WICKET-622
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.2.2
>Reporter: Nili Adoram
>Assignee: Juergen Donnerstag
> Fix For: 1.3.2
>
>
> I add a component to its container when the page is initialized, BEFORE
> it is rendered and before page model finished to initialize.
> if log4j is configured to enable wicket debug, the container toString()
> is called.
> This method invokes isVisible() of the container.
> I have overridden isVisible(), to query the page model before deciding
> whether the component is actually visible.
> I assumed this method is called when the component is rendered, and by
> that time the model is completely initialized.
> However, since it was called before component rendering, my code failed
> and the page failed to be created.
> To sum up, toString() of Component should be safe.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1152) MetaDataRoleAuthorizationStrategy.unauthorize() doesn't work

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1152:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> MetaDataRoleAuthorizationStrategy.unauthorize() doesn't work
> 
>
> Key: WICKET-1152
> URL: https://issues.apache.org/jira/browse/WICKET-1152
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-auth-roles
>Affects Versions: 1.3.0-rc1
>Reporter: David
>Assignee: Johan Compagner
> Fix For: 1.3.2
>
>
> Try this:
> MetaDataRoleAuthorizationStrategy.unauthorize(this, RENDER, "USER");
> The page will still be rendered for user with USER role.
> The following will work fine to prevent rendering by anybody:
> MetaDataRoleAuthorizationStrategy.authorize(this, RENDER, "");

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1105) Missing javascript header referencies when there are no body or head tags.

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1105:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> Missing javascript header referencies when there are no body or head tags.
> --
>
> Key: WICKET-1105
> URL: https://issues.apache.org/jira/browse/WICKET-1105
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
> Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>Reporter: Michal Capo
>Assignee: Juergen Donnerstag
> Fix For: 1.3.2
>
> Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is 
> one difference in the markup.
> First:
> 
>   
> 
> 
>   
> 
> Second:
> 
>   
> 
> In first one is request executed via ajax. In second one not. In first one 
> rendered page contains reference to 'wicket-ajax.js' file but in the second 
> not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1205:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> Relative path calculations for inline paths in non-bookmarkable pages are 
> incorrect on Tomcat.
> --
>
> Key: WICKET-1205
> URL: https://issues.apache.org/jira/browse/WICKET-1205
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-rc1
> Environment: JBoss 4.2 / Tomcat Embedded
>Reporter: Jeremy Levy
>Assignee: Alastair Maw
> Fix For: 1.3.2
>
> Attachments: CSSIssueQuickStart.tar.gz
>
>
> When linking from a bookmarked page to a non-bookmarked page the relative 
> link to the CSS page breaks. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-194) Enhance CheckBoxSelector to Select CheckBox-es in CheckGroup on Server Side

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-194:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> Enhance CheckBoxSelector to Select CheckBox-es in CheckGroup on Server Side
> ---
>
> Key: WICKET-194
> URL: https://issues.apache.org/jira/browse/WICKET-194
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.2.3
>Reporter: TH Lim
>Priority: Minor
> Fix For: 1.3.2
>
> Attachments: RoundTripCheckGroupSelector.java, 
> RoundTripCheckGroupSelector.java
>
>
> Enhance CheckBoxSelector to select the items e.g. users, product line items, 
> etc. shown in the
> paged list view on the visible page and update the CheckGroup with these 
> "visible" items on the server side.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1130) Injection of Bound Instance Fails with Exception

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1130:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> Injection of Bound Instance Fails with Exception
> 
>
> Key: WICKET-1130
> URL: https://issues.apache.org/jira/browse/WICKET-1130
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-guice
>Affects Versions: 1.3.0-beta4
>Reporter: Daniel Spiewak
>Assignee: Alastair Maw
> Fix For: 1.3.2
>
>
> If I try to inject an explicitly bound instance into a component, injection 
> fails with an exception in the creation of the CGLIB proxy:
> java.lang.IllegalArgumentException: Superclass has no null constructors but 
> no arguments were given
> Stupidly, I forgot to save the whole stack trace and the code is now gone 
> from my codebase (since I needed it to work).  To repeat:
> @Override
> public void configure() {
> bind(EntityManager.class).toInstance(manager);
> }
> Seems wicket-guice is assuming that it needs to create a new instance of 
> everything that's injected, and since EntityManager doesn't have a no-args 
> constructor, such an action fails.  Just an assumption anyway...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-830) FindBugs static alalyser shows many coding issues/errors

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-830:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> FindBugs static alalyser shows many coding issues/errors
> 
>
> Key: WICKET-830
> URL: https://issues.apache.org/jira/browse/WICKET-830
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-beta2
>Reporter: Dariusz Wojtas
>Assignee: Johan Compagner
> Fix For: 1.3.2
>
> Attachments: findbugs-badpractice-oddness-revised.patch.gz, 
> findbugs-badpractice-oddness.patch.gz, 
> findbugs-correctness-comparisonwithself.patch.gz, 
> findbugs-correctness-impossiblecast.patch.gz, 
> findbugs-correctness-possiblenpe-inline.patch.gz, 
> findbugs-correctness-possiblenpe.patch.gz, 
> findbugs-correctness-redundantnullcheck.patch.gz, 
> findbugs-correctness-tostringonarray.patch.gz, findbugs-dodgy.patch.gz, 
> findbugs-doublecheckedlocking.patch.gz, 
> findbugs-vulnerable-mutablestatic-dependent.patch.gz, 
> findbugs-vulnerable-mutablestatic-questionable.patch.gz, 
> findbugs-vulnerable-mutablestatic.patch.gz
>
>
> After I found WICKET-829 by examining examples, I tried to run FindBugs 
> against the wicket - only core jdk-14.
> This showed several easy to fix bugs, nothing really serious.
> I really advice someone to run FindBugs from time to time against the project 
> (if installed in Eclipse, it's enough to right click on the project, then 2-5 
> minutes of analysis and bugs visible in the Bug Tree View).
> There are tons of issues found, smaller or bigger.
> Some of them are false alarms - like in some tests or inner classes where we 
> know something cannot happen.
> But many should be fixed
> Some of the issues found:
> org.apache.wicket.markup.html.form.FormComponent
>has issues in equal (line 653 - different types compared)
> org.apache.wicket.Session.getPage   
>line 684 - compares strings with == instead of equals()
>this may be correct but the 'pageMapName' comes as parameter to a public 
> method, we never know who will use it
> several classes use dead variables (written, never read). Examples:
>   org.apache.wicket.markup.html.form.Button - line 206
>   org.apache.wicket.markup.html.image.resource.LocalizedImageResource - lines 
> 254, 255
> Some fields should be marked final, but are not. example:
>org.apache.wicket.util.lang.Bytes.MAX
> Impossible cast
>org.apache.wicket.util.io.WicketObjectInputStream.get(string, char) - line 
> 535
> Inconsistent synchronization
>   Some methods are marked as 'synchronized' when some others are not - when 
> working on the same resource.
> Inefficient use of keySet iterator instead of entrySet iterator
> This occurs in several places in loops.
> check always returns true:
> org.apache.wicket.markup.repeater.data.DataViewBase.onDetach - line 144

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1003) Modal Window Does Not Close When Using IndicatingAjaxButton

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1003:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> Modal Window Does Not Close When Using IndicatingAjaxButton
> ---
>
> Key: WICKET-1003
> URL: https://issues.apache.org/jira/browse/WICKET-1003
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 1.3.0-beta4
> Environment: Ubuntu, Jetty, Eclipse
>Reporter: Carlo M. Camerino
>Assignee: Matej Knopp
> Fix For: 1.3.2
>
> Attachments: Modal.png, project.tar.gz, quickstart-closeDoesntWork.zip
>
>
> I have  a panel in my modal window. I have a button in my panel that closes 
> the modalwindow.
> If I use an indicatingajaxbutton for that button, the modalwindow does not 
> close properly.
> However if i use an ajaxlink, things go smoothly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-910) Add forXXX family of factories for StringHeaderContributor too

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-910:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> Add forXXX family of factories for StringHeaderContributor too
> --
>
> Key: WICKET-910
> URL: https://issues.apache.org/jira/browse/WICKET-910
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-beta3, 1.3.0-beta4
>Reporter: Carlos Pita
>Priority: Minor
> Fix For: 1.3.2
>
>
> As there is this family for the other contributors: 
> TextTemplateHeaderContributor and HeaderContributor. This way one could avoid 
> writing boilerplate code like:
> JavascriptUtils.SCRIPT_OPEN_TAG + myScript + JavascriptUtils.SCRIPT_CLOSE_TAG;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1082) Check for concurrent access to HashMaps and other data structures

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1082:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> Check for concurrent access to HashMaps and other data structures
> -
>
> Key: WICKET-1082
> URL: https://issues.apache.org/jira/browse/WICKET-1082
> Project: Wicket
>  Issue Type: Task
>Affects Versions: 1.3.0-beta4
>Reporter: Jonathan Locke
> Fix For: 1.3.2
>
>
> We just found and fixed a serious concurrency issue in Localizer.  The 
> HashMap in Localizer is accessed concurrently and under a high enough load, 
> sometimes the HashMap data structure gets corrupted, causing infinite loops 
> on servers.  We need to ensure that other places don't have this problem too. 
>  Any application scope shared data structure (shared resources maybe?) should 
> be checked and made concurrent for 1.3 final, if possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1132) Liferay portlet support

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1132:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> Liferay portlet support
> ---
>
> Key: WICKET-1132
> URL: https://issues.apache.org/jira/browse/WICKET-1132
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-portlet
>Affects Versions: 1.3.0-beta4
> Environment: Liferay 4.3.3 on Tomcat 6
>Reporter: Thijs Vonk
>Assignee: Ate Douma
> Fix For: 1.3.2
>
> Attachments: patch-jira-wicket-1132.patch
>
>
> I created 2 simple Links a AjaxLink and a 'normal' link in a portlet. I 
> deployed this portlet on Liferay. The normal link works fine. But the Ajax 
> links doesn't work. In the generated HTML the url's look like this.
> AJAX link: 
> http://localhost:8080/web/guest/admin?p_p_id=MiniPortlet&p_p_action=1&p_p_col_id=column-1&p_p_col_count=1&;',null,null,
>  function() {return Wicket.$$(this)}.bind(this));return !wcall;" 
> id="id__MiniPortlet__WAR__MiniPortlet1link1">
> Normal link:
>  href="http://localhost:8080/web/guest/admin?p_p_id=MiniPortlet_WAR_MiniPortlet1&p_p_action=1&p_p_state=normal&p_p_mode=view&p_p_col_id=column-1&p_p_col_count=1&_MiniPortlet_WAR_MiniPortlet1__wu=%2Fminiportlet%2F%3Fwicket%3Ainterface%3D%3A0%3Alink2%3A%3AILinkListener%3A%3A";
>  wicket:id="link2">
> At this moment the p_p_id is the part that I'm looking into. As you can see 
> they are different. And for Liferay this part tels it which portlet it should 
> send the request to. The normal link is the correct path to the portlet. as 
> this action actually works.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-406) form fields are reset when a file upload fails

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-406:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> form fields are reset when a file upload fails
> --
>
> Key: WICKET-406
> URL: https://issues.apache.org/jira/browse/WICKET-406
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.2.2, 1.2.3, 1.2.4, 1.2.5
> Environment: Tomcat 5.5.9 , windows 2000 SP2
>Reporter: Jaime De La Jara
>Assignee: Matej Knopp
>Priority: Minor
> Fix For: 1.3.2
>
>
> If a form contains some fields and a file field, when an uploads fails (for 
> example exceeds the maximum size) the form fields are reset. A better 
> behaviour would be to group all failed validations and show all the messages 
> at once. The relevant code is in class wicket.markup.html.form.Form in method 
> onFormSubmitted, where the condition of handleMultipart is first checked and 
> if it has not been completed the method returns, without processing the rest 
> of the fields.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-952) provide the means to generate site with maven-site-plugin

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-952:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> provide the means to generate site with maven-site-plugin
> -
>
> Key: WICKET-952
> URL: https://issues.apache.org/jira/browse/WICKET-952
> Project: Wicket
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.3.0-beta3
>Reporter: Gerolf Seitz
>Assignee: Gerolf Seitz
> Fix For: 1.3.2
>
> Attachments: mvn_site.patch
>
>
> only once:
> # apply patch from WICKET-941 to wicket-common to fix layout issues
> # apply this patch to trunk
> for every release:
> # run "mvn clean site:stage -Psite -DstagingDirectory=" 
> in trunk

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1306) CLONE - Correct javadoc for Fragment

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1306:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> CLONE - Correct javadoc for Fragment
> 
>
> Key: WICKET-1306
> URL: https://issues.apache.org/jira/browse/WICKET-1306
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-final
>Reporter: Craig McIlwee
>Priority: Minor
> Fix For: 1.3.2
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> The Fragment constructors without markupProvider argument have been 
> deprecated but the example in the class javadoc's is still using it.
> CLONE:
> This still not reflected in the javadocs that are linked from the main 
> project page (http://people.apache.org/~tobrien/wicket/apidocs/index.html)
> In addition to the example using the deprecated constructors, the 
> constructors themselves are not marked as deprecated in the documentation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-928) Exception when clicking two times rapidly on the "next" button in a wizard

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-928:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> Exception when clicking two times rapidly on the "next" button in a wizard
> --
>
> Key: WICKET-928
> URL: https://issues.apache.org/jira/browse/WICKET-928
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 1.3.0-beta2, 1.3.0-beta3
>Reporter: Joël Vimenet
>Assignee: Eelco Hillenius
> Fix For: 1.3.2
>
> Attachments: Apache.tar.gz
>
>
> On a tree steps wizard, the first step contains two fields without any 
> validation. The second one contains only one field that must be an integer. 
> The last step will display the data entered in the two first steps.
> When I am on the first step, and I click two times rapidly on the "next" 
> button, it throws an exception.
> Here is the stack trace : 
> --
> WicketMessage: Method onFormSubmitted of interface 
> org.apache.wicket.markup.html.form.IFormSubmitListener targeted at component 
> [MarkupContainer [Component id = form, page = test.www.factory.TestPage, path 
> = 0:wizard:form.Form, isVisible = true, isVersioned = false]] threw an 
> exception
> Root cause:
> java.lang.NullPointerException
> at 
> org.apache.wicket.util.convert.converters.AbstractConverter.parse(AbstractConverter.java:50)
> at 
> org.apache.wicket.util.convert.converters.AbstractNumberConverter.parse(AbstractNumberConverter.java:71)
> at 
> org.apache.wicket.util.convert.converters.IntegerConverter.convertToObject(IntegerConverter.java:44)
> at 
> org.apache.wicket.markup.html.form.FormComponent.convertInput(FormComponent.java:1159)
> at 
> org.apache.wicket.markup.html.form.FormComponent.validate(FormComponent.java:1027)
> at org.apache.wicket.markup.html.form.Form$15.validate(Form.java:1671)
> at 
> org.apache.wicket.markup.html.form.Form$ValidationVisitor.formComponent(Form.java:160)
> at 
> org.apache.wicket.markup.html.form.FormComponent.visitFormComponentsPostOrderHelper(FormComponent.java:403)
> at 
> org.apache.wicket.markup.html.form.FormComponent.visitFormComponentsPostOrderHelper(FormComponent.java:390)
> at 
> org.apache.wicket.markup.html.form.FormComponent.visitFormComponentsPostOrderHelper(FormComponent.java:390)
> at 
> org.apache.wicket.markup.html.form.FormComponent.visitFormComponentsPostOrderHelper(FormComponent.java:390)
> at 
> org.apache.wicket.markup.html.form.FormComponent.visitFormComponentsPostOrder(FormComponent.java:368)
> at 
> org.apache.wicket.markup.html.form.Form.visitFormComponentsPostOrder(Form.java:1004)
> at org.apache.wicket.markup.html.form.Form.validateComponents(Form.java:1667)
> at org.apache.wicket.markup.html.form.Form.validate(Form.java:1658)
> at org.apache.wicket.markup.html.form.Form.process(Form.java:811)
> at org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:783)
> at java.lang.reflect.Method.invoke(Method.java:585)
> at 
> org.apache.wicket.RequestListenerInterface.invoke(RequestListenerInterface.java:186)
> at 
> org.apache.wicket.request.target.component.listener.ListenerInterfaceRequestTarget.processEvents(ListenerInterfaceRequestTarget.java:73)
> at 
> org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:90)
> at 
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1032)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1108)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1177)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:500)
> at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:261)
> at 
> org.apache.wicket.protocol.http.WicketServlet.doPost(WicketServlet.java:144)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:210)
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:174)
> at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
> at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117)
> at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
> at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:151)
> at org.apache.coyot

[jira] Updated: (WICKET-861) NumberFormatException with UrlCompressingWebRequestProcessor in WicketTester

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-861:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> NumberFormatException with UrlCompressingWebRequestProcessor in WicketTester
> 
>
> Key: WICKET-861
> URL: https://issues.apache.org/jira/browse/WICKET-861
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-beta3
> Environment: Wicket 1.3.0 from Trunk
> JDK 6
>Reporter: Rüdiger Schulz
>Priority: Minor
> Fix For: 1.3.2
>
>
> In my Application I use UrlCompressingWebRequestProcessor. Now I have a JUnit 
> test case with WicketTester and that Application like this:
> tester.startPage(new ITestPageSource() {
>   public Page getTestPage() {
>   PageParameters params = new PageParameters();
>   params.add("0", "param");
>   return new MyPage(params);
>   }
> });
> I get an Exception:
> java.lang.NumberFormatException: For input string: "testPage"
>   at 
> java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
>   at java.lang.Integer.parseInt(Integer.java:447)
>   at java.lang.Integer.parseInt(Integer.java:497)
>   at 
> org.apache.wicket.protocol.http.request.urlcompressing.UrlCompressor.getComponentAndInterfaceForUID(UrlCompressor.java:124)
>   at 
> org.apache.wicket.protocol.http.request.urlcompressing.UrlCompressingWebRequestProcessor.resolveListenerInterfaceTarget(UrlCompressingWebRequestProcessor.java:81)
>   at 
> org.apache.wicket.request.AbstractRequestCycleProcessor.resolveRenderedPage(AbstractRequestCycleProcessor.java:440)
>   at 
> org.apache.wicket.protocol.http.WebRequestCycleProcessor.resolve(WebRequestCycleProcessor.java:139)
>   at org.apache.wicket.RequestCycle.step(RequestCycle.java:1091)
>   at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1177)
>   at org.apache.wicket.RequestCycle.request(RequestCycle.java:500)
>   at 
> org.apache.wicket.protocol.http.MockWebApplication.processRequestCycle(MockWebApplication.java:381)
>   at 
> org.apache.wicket.protocol.http.MockWebApplication.processRequestCycle(MockWebApplication.java:368)
>   at 
> org.apache.wicket.util.tester.BaseWicketTester.executeListener(BaseWicketTester.java:239)
>   at 
> org.apache.wicket.util.tester.BaseWicketTester.startPage(BaseWicketTester.java:224)
> I could work around this by using WebRequestCycleProcessor for my 
> testing-application.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-626) profile Wicket for 1.3.0

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-626:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> profile Wicket for 1.3.0
> 
>
> Key: WICKET-626
> URL: https://issues.apache.org/jira/browse/WICKET-626
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Reporter: Eelco Hillenius
>Assignee: Johan Compagner
> Fix For: 1.3.2
>
>
> We should profile Wicket and search for (and fix) new bottlenecks we may have 
> introduced since 1.2. We should give memory consumption a very good look and 
> see if there is still room for optimizing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1268) Form inside VelocityPanel throws WicketRuntimeException: Unable to find the markup for the component.

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1268:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> Form inside VelocityPanel throws WicketRuntimeException: Unable to find the 
> markup for the component.
> -
>
> Key: WICKET-1268
> URL: https://issues.apache.org/jira/browse/WICKET-1268
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-final
> Environment: Win XP / Tomcat 6.0
>Reporter: Markus Sabadello
>Assignee: Eelco Hillenius
> Fix For: 1.3.2
>
> Attachments: simplevelocity.zip
>
>
> I am trying to have a Form inside a VelocityPanel, but I get the following 
> Exception:
> WicketMessage: Unable to find the markup for the component. That may be due 
> to transparent containers or components implementing IComponentResolver: 
> [MarkupContainer [Component id = form, page = 
> simplevelocity.SimpleVelocityPage, path = 3:velocity:form.MyForm, isVisible = 
> true, isVersioned = true]]
> Root cause:
> org.apache.wicket.WicketRuntimeException: Unable to find the markup for the 
> component. That may be due to transparent containers or components 
> implementing IComponentResolver: [MarkupContainer [Component id = form, page 
> = simplevelocity.SimpleVelocityPage, path = 3:velocity:form.MyForm, isVisible 
> = true, isVersioned = true]]
> at org.apache.wicket.MarkupFragmentFinder.find(MarkupFragmentFinder.java:118)
> at org.apache.wicket.Component.locateMarkupStream(Component.java:3584)
> at org.apache.wicket.Component.getMarkupAttributes(Component.java:1359)
> at org.apache.wicket.markup.html.form.Form.getMethod(Form.java:1310)
> at org.apache.wicket.markup.html.form.Form.onComponentTag(Form.java:1457)
> at org.apache.wicket.Component.renderComponent(Component.java:2400)
> at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1354)
> at org.apache.wicket.markup.html.form.Form.onRender(Form.java:1588)
> at org.apache.wicket.Component.render(Component.java:2266)
> at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1240)
> at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1370)
> at 
> org.apache.wicket.velocity.markup.html.VelocityPanel.onComponentTagBody(VelocityPanel.java:228)
> at org.apache.wicket.Component.renderComponent(Component.java:2429)
> at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1354)
> at org.apache.wicket.Component.render(Component.java:2266)
> at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1240)
> at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1370)
> at org.apache.wicket.Page.onRender(Page.java:1442)
> at org.apache.wicket.Component.render(Component.java:2266)
> at org.apache.wicket.Page.renderPage(Page.java:891)
> at 
> org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:231)
> at 
> org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:103)
> at 
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1100)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1169)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1245)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:489)
> at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:354)
> at 
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:194)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:228)
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
> at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
> at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:104)
> at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
> at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:216)
> at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844)
> at 
> org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:634)
> at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:445)
> at java.lang.Thread.run(Thread.java:595)
> I also have a Label inside the VelocityPanel, which works fine.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a commen

[jira] Updated: (WICKET-452) AjaxFormComponentUpdatingBehavior.onError forces dummy override of abstract onUpdate

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-452:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> AjaxFormComponentUpdatingBehavior.onError forces dummy override of abstract 
> onUpdate
> 
>
> Key: WICKET-452
> URL: https://issues.apache.org/jira/browse/WICKET-452
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-beta1, 2.0 branch (discontinued)
>Reporter: Carlos Pita
>Assignee: Matej Knopp
>Priority: Minor
> Fix For: 1.3.2
>
>
> As of wicket 1.3, the onUpdate event of AjaxFormComponentUpdatingBehavior is 
> not called upon validation errors anymore. Instead onError is invoked, both 
> for exceptions thrown during event execution and for form component 
> validation errors.
> protected abstract void onUpdate(AjaxRequestTarget target);
> protected void onError(AjaxRequestTarget target, RuntimeException e) {...}
> So for ajax validaton I would have to override onError instead, but that 
> would be a bit laborious as it's necessary to override the abstract onUpdate 
> too; and there is no need of that exception parameter either (which for 
> validation purposes will always be null).
> Imo it would be better if I don't have to "dummy out" the abstract onUpdate 
> every time just to keep the compiler happy. And maybe if the extra onError 
> parameter is not exposed to the event.
> What do you think about an empty default implementation for onUpdate and an 
> overload for onError that just takes the target?, these changes would be 
> handy for the usual ajax-validation task:
> protected void onUpdate(AjaxRequestTarget target) { }
> protected void onError(AjaxRequestTarget target) { } <-- maybe 
> onValidationError?
> protected void onError(AjaxRequestTarget target, RuntimeException e) {
>   throw e;
>  }
> Notice that for the trunk branch everything said above applies ditto but the 
> situation is even worse because onError has private access.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1038) Setting UnexpectedExceptionDisplay to IExceptionSettings.SHOW_NO_EXCEPTION_PAGE doesn't throw Servlet Exception

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1038:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> Setting UnexpectedExceptionDisplay to 
> IExceptionSettings.SHOW_NO_EXCEPTION_PAGE doesn't throw Servlet Exception
> ---
>
> Key: WICKET-1038
> URL: https://issues.apache.org/jira/browse/WICKET-1038
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-beta3
> Environment: Weblogic 8.1
> Java 1.4
>Reporter: Adam A. Koch
> Fix For: 1.3.2
>
>
> Setting UnexpectedExceptionDisplay to 
> IExceptionSettings.SHOW_NO_EXCEPTION_PAGE doesn't throw Servlet Exception.
> In my application class:
> 
> getExceptionSettings().setUnexpectedExceptionDisplay(IExceptionSettings.SHOW_NO_EXCEPTION_PAGE);
> But when an exception is thrown, for example:
> public Sub1Page() {
> if (true)
> throw new RuntimeException("This is a test");
> }
> I don't get a ServletException, but a page with no text.I would have expected 
> the container (Weblogic in this case) to display something.
> I looked in the code, but I don't see any place where the exception is 
> wrapped in a ServletException.
> I think it's supposed to be handled in 
> AbstractRequestCycleProcessor.respond().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1180) Converters : final vs non final

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1180:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> Converters : final vs non final
> ---
>
> Key: WICKET-1180
> URL: https://issues.apache.org/jira/browse/WICKET-1180
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-rc1
>Reporter: Stephane Bailliez
>Assignee: Eelco Hillenius
>Priority: Minor
> Fix For: 1.3.2
>
>
> I can understand the reason not to put anything extensible but then there is 
> a consistency problem as in the converters:
> all converters are final except: DateConverter, SqlDateConverter, 
> SqlTimeConverter, SqlTimestampConverter
> which then makes you wonder why the rest is actually final, DateConverter is 
> obviously not final to support inherirtance by the sql* converter, so if we 
> wanted to restrict it, the base class should have been abstract and the other 
> final, but it really does not protect  any significant api changes from the 
> client as the code is not so complex that it deserves to do so
> For instance I wanted to subclass ZeroPaddingConverter to work around the 
> null support and I realize it's final, so I  basically end up copying the 
> whole code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-777) See what needs to be done in abstractpageableview

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-777:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> See what needs to be done in abstractpageableview
> -
>
> Key: WICKET-777
> URL: https://issues.apache.org/jira/browse/WICKET-777
> Project: Wicket
>  Issue Type: Sub-task
>Reporter: Igor Vaynberg
> Fix For: 1.3.2
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1195) Let the user choose the default sorting of OrderByLink

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1195:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> Let the user choose the default sorting of OrderByLink
> --
>
> Key: WICKET-1195
> URL: https://issues.apache.org/jira/browse/WICKET-1195
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-rc1
>Reporter: Thomas Jaeckle
>Priority: Minor
> Fix For: 1.3.2
>
>
> currently sort() in OrderByLink looks like that:
> public final OrderByLink sort()
> {
>if (isVersioned())
>{
>   // version the old state
>   Change change = new SortStateChange();
>   addStateChange(change);
>}
>ISortState state = stateLocator.getSortState();
>int oldDir = state.getPropertySortOrder(property);
>int newDir = ISortState.ASCENDING;
>if (oldDir == ISortState.ASCENDING)
>{
>  newDir = ISortState.DESCENDING;
>}
>state.setPropertySortOrder(property, newDir);
>return this;
> }
> So by default the sorting is always ISortState.ASCENDING when you click on a 
> OrderByLink that had an ISortState.NONE state before.
> I would like to set the default sorting by myself (in the case I have, I want 
> DESCENDING as default sorting).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1228) for input components, provide focus + select input value in ajax

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1228:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> for input components, provide focus + select input value in ajax
> 
>
> Key: WICKET-1228
> URL: https://issues.apache.org/jira/browse/WICKET-1228
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-rc2
>Reporter: Peter Ertl
>Assignee: Johan Compagner
> Fix For: 1.3.2
>
> Attachments: FocusAndSelectInputComponent.patch
>
>
> It's quite common that you need to set focus on a input component (text 
> field, text area) and select the current input value.
> therefore it would be nice if you could add my patch
> AjaxRequestTarget#focusInputComponent(Component)
> it will call
>   #component.focus()
> plus 
>   
>   #component.select()
> in javascript.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1124) Inner form validators not skipped when inner form disabled

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1124:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> Inner form validators not skipped when inner form disabled
> --
>
> Key: WICKET-1124
> URL: https://issues.apache.org/jira/browse/WICKET-1124
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-beta4
>Reporter: Gwyn Evans
>Assignee: Matej Knopp
>Priority: Minor
> Fix For: 1.3.2
>
> Attachments: WICKET-1124.patch
>
>
> The specific issue I've just run across is where I have a outer form and, 
> depending upon a checkbox, might have an inner form being enabled or not.  
> (It's an inner form, rather than just a part of the main form as it's off as 
> a component with it's own panel.)
> Anyway, the inner form has password/confirmPassword fields and an 
> EqualInputValidator, but if the form is displayed but then disabled again 
> (via Ajax, if significant,) when the form's finally submitted I get a 
> warning, saying "IFormValidator in form '...' depends on a component that has 
> been removed from the page or is no longer visible. Offending component id 
> `password`."
> As Igor commented, "looks like we need to update form processing code to skip 
> inner disabled forms".
> /Gwyn

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-310) AutoCompleteTextField does not invoke post call handlers

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-310:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> AutoCompleteTextField does not invoke post call handlers
> 
>
> Key: WICKET-310
> URL: https://issues.apache.org/jira/browse/WICKET-310
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 1.2.3, 1.2.5
>Reporter: paolo di tommaso
>Assignee: Janne Hietamäki
>Priority: Minor
> Fix For: 1.3.2
>
>
> The AutoCompleteTextField does not invoke the registered post call handlers 
> after the ajax request has been completed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-399) Make RestartResponseAtInterceptPageException with a SignIn-type page work correctly from AjaxFallbackLink

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-399:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> Make RestartResponseAtInterceptPageException with a SignIn-type page work 
> correctly from AjaxFallbackLink
> -
>
> Key: WICKET-399
> URL: https://issues.apache.org/jira/browse/WICKET-399
> Project: Wicket
>  Issue Type: Wish
>  Components: wicket
>Affects Versions: 1.2.5
>Reporter: Nick Johnson
>Priority: Minor
> Fix For: 1.3.2
>
> Attachments: 
> 20070104-wicket-1.x-RestartResponseAtOriginalDestination, 
> 20070104-wicket-1.x-RestartResponseAtOriginalDestination.txt, 
> RestartResponseAtOriginalDestination.java
>
>
> If you throw a new RestartResponseAtInterceptPageException from inside 
> onClick in an AjaxFallbackLink, Wicket does the right thing in redirecting 
> you to a SignIn page, but upon completing the sign-in, the 
> continueToOriginalDestination() call continues to the Ajax response (which 
> isn't particularly surprising).
> It might be nice to have magic added to make this work seamlessly and restart 
> the onClick() somehow.  It would be adequate to make the AjaxFallBackLink 
> behave as though fallback had happened in this situation.
> A fairly simple workaround is to check in the Panel/Page to see if sign-in 
> has happened already and use a normal Link in the case that it hasn't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1094) Values over-escaped by FormTester

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1094:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> Values over-escaped by FormTester
> -
>
> Key: WICKET-1094
> URL: https://issues.apache.org/jira/browse/WICKET-1094
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 1.3.0-beta4
>Reporter: David Shepherdson
> Fix For: 1.3.2
>
>
> FormTester's constructor contains code that visits all components on the form 
> and calls setFormComponentValue(formComponent, formComponent.getValue()) (or 
> variations thereof), to store the component's value in the servlet request 
> parameters. However, by default, FormComponent's getValue() method uses 
> Strings.escapeMarkup(...) to encode any special characters, such as angle 
> brackets. This is fine in a 'real' environment, where a Web browser will be 
> responsible for displaying the escaped characters with their proper values, 
> and so the proper value will be the one that comes through when the form is 
> submitted; however, in the Wicket test environment, there isn't anything to 
> do that extra level of 'un-escaping', meaning there's a danger of the form 
> components being given escaped values when the form is submitted.
> For example, we have a form that contains a text area, whose value contains a 
> URI enclosed in angle brackets, like so:
> < http://test.com/ >
> When we submit the form with a Web browser, the value set on the model is 
> exactly that string -- '< http://test.com/ >'. However, when we test our page 
> with FormTester, the FormTester constructor calls getValue() on the 
> component, which by default returns the escaped form:
> < http://test.com/ >
> When the form is submitted, this is the value set on the model, and so 
> comparisons to the original string fail.
> (Extra spaces inserted into the strings above to make them display properly 
> in JIRA.)
> However, if FormTester were to call setEscapeModelStrings(false) on the form 
> component before calling getValue() (and then restore the original escaping 
> setting afterwards), then the value that ends up being provided to the 
> component at the end would be the correct (unescaped) value, matching the 
> behaviour when using the page in a browser.
> We have worked around this issue by overriding FormTester with a class that 
> performs a second traversal of the form component hierarchy after calling the 
> FormTester constructor, replacing the incorrectly escaped values with the 
> proper ones (changes marked with '// O-P'):
> public OurFormTester(String path, Form workingForm, BaseWicketTester 
> wicketTester, boolean fillBlankString) {
> super(path, workingForm, wicketTester, fillBlankString);
> fixFormParameterValues(workingForm, fillBlankString);
> }
> 
> protected void fixFormParameterValues(Form workingForm, final boolean 
> fillBlankString) {
> workingForm.visitFormComponents(new FormComponent.AbstractVisitor()
> {
> public void onFormComponent(final FormComponent formComponent)
> {
> // do nothing for invisible component
> if (!formComponent.isVisibleInHierarchy())
> {
> return;
> }
> // O-P Preserve old escaping value, then turn escaping off
> // so that values aren't escaped unnecessarily.
> boolean oldEscaping = formComponent.getEscapeModelStrings();
> formComponent.setEscapeModelStrings(false);
> 
> // if component is text field and do not have exist value, 
> fill
> // blank String if required
> if (formComponent instanceof AbstractTextComponent)
> {
> if (Strings.isEmpty(formComponent.getValue()))
> {
> if (fillBlankString)
> {
> setFormComponentValue(formComponent, "");
> }
> }
> else
> {
> setFormComponentValue(formComponent, 
> formComponent.getValue());
> }
> }
> else if ( (formComponent instanceof DropDownChoice) ||
> (formComponent instanceof RadioChoice) ||
> (formComponent instanceof CheckBox))
> {
> setFormComponentValue(formComponent, 
> formComponent.getValue());
> }
> else if (formComponent instanceof ListMultipleChoice)
> {
> final String[] modelValues = 
> 

[jira] Updated: (WICKET-1166) add sanity check on form submit for request method

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1166:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> add sanity check on form submit for request method
> --
>
> Key: WICKET-1166
> URL: https://issues.apache.org/jira/browse/WICKET-1166
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-rc1
> Environment: Safari 3
>Reporter: Nathan Hamblen
>Assignee: Igor Vaynberg
>Priority: Minor
> Fix For: 1.3.2
>
> Attachments: submit-method.patch
>
>
> When refreshing a frameset that includes an already POST submitted Wicket 
> form in a frame, using the redirect to render strategy, Safari erroneously 
> requests the form's original target by GET, rather than the location that was 
> eventually redirected to. Therefore none of the form values are available in 
> the request object and NPEs will occur trying to access them in places like 
> AbstractConverter.java:55.
> Because Form allows for a particular request method to be specified, I think 
> it should also confirm that the expected method was used instead of waiting 
> for an NPE in validation. The outcome is the same, but the cause of the error 
> (the client) would be more evident in server logs, etc. Patch to come...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-543) need javadocs embedded in the Wicket 1.3 zip file

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-543:
--

Fix Version/s: (was: 1.3.1)
   1.3.2

> need javadocs embedded in the Wicket 1.3 zip file
> -
>
> Key: WICKET-543
> URL: https://issues.apache.org/jira/browse/WICKET-543
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket, wicket-auth-roles, wicket-datetime, 
> wicket-examples, wicket-extensions, wicket-jmx, wicket-spring
>Affects Versions: 1.3.0-beta1
>Reporter: Sean Sullivan
>Assignee: Martijn Dashorst
>Priority: Minor
> Fix For: 1.3.2
>
>
> I downloaded apache-wicket-1.3.0-incubating-beta1.zip from 
> http://people.apache.org/dist/incubator/wicket/apache-wicket-1.3.0-incubating-beta1/dist/
>  
>  
> I unzipped the file and noticed that the zip does not contain any javadocs.   
>  Please embed the javadocs inside the zip file :-) (fyi, the Wicket 
> 1.2.6. zip file has the javadocs embedded)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1165) Nullpointer serialization second level cache

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen updated WICKET-1165:
---

Fix Version/s: (was: 1.3.1)
   1.3.2

> Nullpointer serialization second level cache
> 
>
> Key: WICKET-1165
> URL: https://issues.apache.org/jira/browse/WICKET-1165
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-rc1
>Reporter: Eelco Hillenius
>Assignee: Matej Knopp
> Fix For: 1.3.2
>
>
> A few times a week, we get this exception:
> 2007-11-19 07:29:52,914 ERROR org.apache.wicket.util.lang.Objects - Error 
> serializing object class ts4.web.wicket.page.workspace.NavigationPage 
> [object=[Page class = ts4.web.wicket.page.workspace.NavigationPage, id = 4, 
> version = 0]]
>java.lang.NullPointerException
>at java.util.LinkedList.writeObject(LinkedList.java:755)
>at sun.reflect.GeneratedMethodAccessor92.invoke(Unknown Source)
>at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>at java.lang.reflect.Method.invoke(Method.java:585)
>at 
> java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:917)
>at 
> java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1339)
>at 
> java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1290)
>at 
> java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1079)
>at 
> java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1375)
>at 
> java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1347)
>at 
> java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1290)
>at 
> java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1079)
>at 
> java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1375)
>at 
> java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1347)
>at 
> java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1290)
>at 
> java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1079)
>at 
> java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1375)
>at 
> java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1347)
>at 
> java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1290)
>at 
> java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1079)
>at 
> java.io.ObjectOutputStream.writeArray(ObjectOutputStream.java:1251)
>at 
> java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1075)
>at 
> java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1375)
>at 
> java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1347)
>at 
> java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1290)
>at 
> java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1079)
>at 
> java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1375)
>at 
> java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1347)
>at 
> java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1290)
>at 
> java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1079)
>at 
> java.io.ObjectOutputStream.writeArray(ObjectOutputStream.java:1251)
>at 
> java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1075)
>at 
> java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1375)
>at 
> java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1347)
>at 
> java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1290)
>at 
> java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1079)
>at 
> java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1375)
>at 
> java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1347)
>at 
> java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1290)
>at 
> java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1079)
>at 
> java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1375)
>at 
> java.io.ObjectOutputStream.writeSerialData(

svn commit: r616879 - /wicket/releases/wicket-1.3.1/

2008-01-30 Thread frankbille
Author: frankbille
Date: Wed Jan 30 12:01:10 2008
New Revision: 616879

URL: http://svn.apache.org/viewvc?rev=616879&view=rev
Log:
Releasing Apache Wicket 1.3.1

Added:
wicket/releases/wicket-1.3.1/
  - copied from r616877, wicket/tags/wicket-1.3.1/



svn commit: r616875 - /wicket/tags/wicket-1.3.1/

2008-01-30 Thread frankbille
Author: frankbille
Date: Wed Jan 30 11:59:30 2008
New Revision: 616875

URL: http://svn.apache.org/viewvc?rev=616875&view=rev
Log:
Releasing Apache Wicket 1.3.1

Added:
wicket/tags/wicket-1.3.1/
  - copied from r616874, wicket/trunk/



[jira] Resolved: (WICKET-1313) Created Norwegian translation of Application.properties

2008-01-30 Thread Frank Bille Jensen (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Bille Jensen resolved WICKET-1313.


   Resolution: Fixed
Fix Version/s: 1.3.1

Committed. 

I didn't commit all the translations to the tests (for wicket core), because I 
didn't have the time to analyze the impact (though the tests did run)

If you have further time, you can also translate the pub examples, showing of 
some Norwegian beer :-) It won't make it into 1.3.1 though (releasing as we 
speak)

> Created Norwegian translation of Application.properties
> ---
>
> Key: WICKET-1313
> URL: https://issues.apache.org/jira/browse/WICKET-1313
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-final
>Reporter: Edvin Syse
>Assignee: Frank Bille Jensen
>Priority: Trivial
> Fix For: 1.3.1
>
> Attachments: Application_no.properties, wicket_no.tar.gz
>
>
> Attached is the Norwegian translation, Application_no.properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r616851 - in /wicket/trunk: jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/ jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/ jdk-1.

2008-01-30 Thread frankbille
Author: frankbille
Date: Wed Jan 30 11:34:46 2008
New Revision: 616851

URL: http://svn.apache.org/viewvc?rev=616851&view=rev
Log:
WICKET-1313: Norwegian translations

Added:

wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel_no.properties
   (with props)

wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/Wizard_no.properties
   (with props)

wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/Application_no.properties
   (with props)

wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_no.properties
   (with props)

wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/FormPage_no.properties
   (with props)

wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/compref/DropDownChoicePage_no.properties
   (with props)

wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/compref/LabelPage_no.properties
   (with props)

wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/compref/TextFieldPage_no.properties
   (with props)

wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput_no.properties
   (with props)

wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/library/BookDetails_no.properties
   (with props)

wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/library/EditBook_no.properties
   (with props)

wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/library/Home_no.properties
   (with props)

wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/library/SignIn_no.properties
   (with props)

wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/upload/MultiUploadPage_no.properties
   (with props)

wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/upload/UploadPage_no.properties
   (with props)

wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/velocity/VelocityTemplateApplication_no.properties
   (with props)

wicket/trunk/jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/wizard/NewUserWizard_no.properties
   (with props)

wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/apps/app1/Home_no.properties
   (with props)

Added: 
wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel_no.properties
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel_no.properties?rev=616851&view=auto
==
--- 
wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel_no.properties
 (added)
+++ 
wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel_no.properties
 Wed Jan 30 11:34:46 2008
@@ -0,0 +1,16 @@
+#  Licensed to the Apache Software Foundation (ASF) under one or more
+#  contributor license agreements.  See the NOTICE file distributed with
+#  this work for additional information regarding copyright ownership.
+#  The ASF licenses this file to You under the Apache License, Version 2.0
+#  (the "License"); you may not use this file except in compliance with
+#  the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+rating.simple=KÃ¥ret {0,number,#.#}
+rating.complete=KÃ¥ret {0,number,#.#} fra {1,number,#} stemmer

Propchange: 
wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel_no.properties
--
svn:mime-type = text/plain

Added: 
wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/Wizard_no.properties
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/Wizard_no.properties?rev=616851&view=auto
==
--- 
wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/Wizard_no.properties
 (added)
+++ 
wicket/trunk/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/Wizard_no.properties
 Wed Jan 30 11:34:46

svn commit: r616823 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/validation/IErrorMessageSource.java

2008-01-30 Thread ivaynberg
Author: ivaynberg
Date: Wed Jan 30 10:08:40 2008
New Revision: 616823

URL: http://svn.apache.org/viewvc?rev=616823&view=rev
Log:
added 2.0 fixme

Modified:

wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/validation/IErrorMessageSource.java

Modified: 
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/validation/IErrorMessageSource.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/validation/IErrorMessageSource.java?rev=616823&r1=616822&r2=616823&view=diff
==
--- 
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/validation/IErrorMessageSource.java
 (original)
+++ 
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/validation/IErrorMessageSource.java
 Wed Jan 30 10:08:40 2008
@@ -54,5 +54,6 @@
 * 
 * @return the given String with the variables substituted
 */
+   // FIXME 2.0 this doesnt need to be in this interface, its just a 
straight var substitution
String substitute(String string, Map vars) throws IllegalStateException;
 }




[jira] Commented: (WICKET-1313) Created Norwegian translation of Application.properties

2008-01-30 Thread Frank Bille Jensen (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564086#action_12564086
 ] 

Frank Bille Jensen commented on WICKET-1313:


Thanks you. I will make sure to commit these before building 1.3.1 tonight

> Created Norwegian translation of Application.properties
> ---
>
> Key: WICKET-1313
> URL: https://issues.apache.org/jira/browse/WICKET-1313
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-final
>Reporter: Edvin Syse
>Assignee: Frank Bille Jensen
>Priority: Trivial
> Attachments: Application_no.properties, wicket_no.tar.gz
>
>
> Attached is the Norwegian translation, Application_no.properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1313) Created Norwegian translation of Application.properties

2008-01-30 Thread Edvin Syse (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edvin Syse updated WICKET-1313:
---

Attachment: wicket_no.tar.gz

Here are translation of the following files, in the following directory 
structure in the tar file:

./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput_no.properties
./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/wizard/NewUserWizard_no.properties
./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/ajax/builtin/FormPage_no.properties
./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/library/EditBook_no.properties
./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/library/BookDetails_no.properties
./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/library/Home_no.properties
./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/library/SignIn_no.properties
./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/compref/LabelPage_no.properties
./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/compref/TextFieldPage_no.properties
./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/compref/DropDownChoicePage_no.properties
./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/velocity/VelocityTemplateApplication_no.properties
./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/upload/MultiUploadPage_no.properties
./jdk-1.5/wicket-examples/src/main/java/org/apache/wicket/examples/upload/UploadPage_no.properties
./jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_no.properties
./jdk-1.4/wicket/src/main/java/org/apache/wicket/Application_no.properties
./jdk-1.4/wicket/src/test/java/org/apache/wicket/resource/DummyPage_no.properties
./jdk-1.4/wicket/src/test/java/org/apache/wicket/resource/DummyApplication_no.properties
./jdk-1.4/wicket/src/test/java/org/apache/wicket/resource/DummyResources_no.properties
./jdk-1.4/wicket/src/test/java/org/apache/wicket/resource/DummySubClassPage_no.properties
./jdk-1.4/wicket/src/test/java/org/apache/wicket/resource/DummyComponent_no.properties
./jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/panel/FragmentTestPanel_no.properties
./jdk-1.4/wicket/src/test/java/org/apache/wicket/LocalizerTest$MyMockPage_no.properties
./jdk-1.4/wicket/src/test/java/org/apache/wicket/properties/TestPanel_no.properties
./jdk-1.4/wicket/src/test/java/org/apache/wicket/properties/MyApplication_no.properties
./jdk-1.4/wicket/src/test/java/org/apache/wicket/properties/TestForm_no.properties
./jdk-1.4/wicket/src/test/java/org/apache/wicket/properties/MyTesterApplication_no.properties
./jdk-1.4/wicket/src/test/java/org/apache/wicket/properties/TestPage_no.properties
./jdk-1.4/wicket/src/test/java/org/apache/wicket/model/StringResourceModelTest_no.properties
./jdk-1.4/wicket/src/test/java/org/apache/wicket/model/ResourceModelTest$TestPage_no.properties
./jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/Wizard_no.properties
./jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel_no.properties
./testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/apps/app1/Home_no.properties

Please let me know if there are more files I can translate :)

-- Edvin

> Created Norwegian translation of Application.properties
> ---
>
> Key: WICKET-1313
> URL: https://issues.apache.org/jira/browse/WICKET-1313
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-final
>Reporter: Edvin Syse
>Assignee: Frank Bille Jensen
>Priority: Trivial
> Attachments: Application_no.properties, wicket_no.tar.gz
>
>
> Attached is the Norwegian translation, Application_no.properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-1313) Created Norwegian translation of Application.properties

2008-01-30 Thread Edvin Syse (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563930#action_12563930
 ] 

Edvin Syse commented on WICKET-1313:


No problem. OK, I'll do the rest tonight and attach to this issue. Maybe 
you should have a Wiki-page to list all the propertyfiles to make it 
easier for the translators to keep up?

-- Edvin



> Created Norwegian translation of Application.properties
> ---
>
> Key: WICKET-1313
> URL: https://issues.apache.org/jira/browse/WICKET-1313
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-final
>Reporter: Edvin Syse
>Assignee: Frank Bille Jensen
>Priority: Trivial
> Attachments: Application_no.properties
>
>
> Attached is the Norwegian translation, Application_no.properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-1313) Created Norwegian translation of Application.properties

2008-01-30 Thread Frank Bille Jensen (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563925#action_12563925
 ] 

Frank Bille Jensen commented on WICKET-1313:


Thank you for taking time to do this. I will commit it tonight.

If you have time there are also other resources that is translateable. I can't 
remember them all:

- Pub examples in wicket-examples
- Wizard in wicket-extensions
- Some other things in wicket-extensions

> Created Norwegian translation of Application.properties
> ---
>
> Key: WICKET-1313
> URL: https://issues.apache.org/jira/browse/WICKET-1313
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.0-final
>Reporter: Edvin Syse
>Assignee: Frank Bille Jensen
>Priority: Trivial
> Attachments: Application_no.properties
>
>
> Attached is the Norwegian translation, Application_no.properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.