[jira] Commented: (WICKET-911) refactor feedback to allow users to easily add custom levels
[
https://issues.apache.org/jira/browse/WICKET-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12577837#action_12577837
]
Will Hoover commented on WICKET-911:
I disagree... Wicket currently makes it convenient to generically define the
message levels for underlying components that use them. For example, in a
FeedbackPanel I can check the message level stored in the FeedbackMessage and
determine how I need to format the message for display:
protected final String getFeedbackResourcePrefix() {
java.util.IteratorFeedbackMessage it =
Session.get().getFeedbackMessages().iterator();
FeedbackMessage fbm;
int level = -1;
while (it.hasNext()) {
fbm = it.next();
if (fbm.isFatal() || fbm.isError()) {
return label.error;
} else if (fbm.isWarning()) {
level = FeedbackMessage.WARNING;
} else if (level FeedbackMessage.WARNING fbm.isInfo()) {
level = FeedbackMessage.INFO;
}
}
switch (level) {
case FeedbackMessage.WARNING:
return label.warning;
case FeedbackMessage.INFO:
return label.info;
default:
return label.success;
}
}
However, I do see an advantage to removing the bloat... Why not remove all of
the error(message), info(message), etc. and replace them with one method
message(message, level) or component.addFeedbackMessage(message, level)?
Then any message level is accommodated for and the message levels themselves
can be removed from the FeedbackMessage class. The level will become just a
placeholder.
refactor feedback to allow users to easily add custom levels
Key: WICKET-911
URL: https://issues.apache.org/jira/browse/WICKET-911
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.0-final
Reporter: Igor Vaynberg
Fix For: 1.4-M1
we have preset levels of fatal/error/warn/info, but users keep asking for
more, such as sucess, see WICKET-907. we should probably refactor feedback to
have
component.addfeedback(feedbackmessage) instead of having ten methods for
prebuild levels. as far as i can see wicket doesnt need to know if the
message is error or success so there is no point in having a more complicated
system.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[CONF] Apache Wicket: Community meetups (page edited)
Page Edited : WICKET : Community meetups Community meetups has been edited by Juan G. Arias (Mar 12, 2008). (View changes) Content: Bookmarkable link If you're thinking about organizing a local meetup, don't hesitate to add your initiative to this list Pictures of past Wicket meetings can be found here: http://flickr.com/photos/tags/wicketmeeting/ There are already efforts to organize meetups in the following countries: United Kingdom Belgium The Netherlands Denmark Sweden Brazil Argentina United States Austria Canada United Kingdom Location: London Regular meetups: The first Wednesday of every month To register, go here: http://jweekend.co.uk/dev/LWUGReg Belgium Last meetup: JavaPolis'07 (dec 12th-14th) Martijn Dashorst will give a Wicket presentation at the conference. We are interested in a Birds of a Feather (BoF) meeting, and interest can be registered here. When you want to attend, you need to be registered at the conference too. The presentation and BoF will be in English. Name Interested Will come BoF? Martijn Dashorst x x x Per Ejeklint x x yeah Xavier Hanin x x x Francis De Brabandere x ? x The Netherlands The Netherlands meeting has its own page due to the interest for the meeting: Wicket Community meetups Amsterdam. Location: Amsterdam Last meetup: Friday November 30 Next meetup: Apache Con EU'08 Denmark Location: Copenhagen Next meetup: TBD. Speakers/ areas of interest? Write what you want to hear about here.. Then people can add themselves as speakers content speaker? Wicket-Spring-JPA-Hibernate (only if theres interest in it) Nino Testing Wicket experiences Nino Creating behaviors (only if theres interest in it) Nino Selling wicket (to your company) Discussion Name Interested Will come Language Comments Cant Come Dates Frank Bille x ? Danish,English Nino Martinez x ? Danish,English 29.nov - 06 dec Jan Mikkelsen x ? Danish,English Flemming Boller x ? Danish,English Guðmundur Bjarni x ? Danish,English,Icelandic Henrik Eiriksson x ? Danish,English,Icelandic Sweden Location: Stockholm Next meetup: 3rd April Web page: http://wicket.jalbum.net Please also join the google group (at the web page) to receive invitations to the meetups. Brazil Location: Rio de Janeiro Next meetup: to be scheduled Register here or send an e-mail to Alexandre Bairos (alexandre.bairos at gmail.com) and let us know you are interested. Name Interested Will come Language Comments Alexandre Bairos x x Portuguese,English,P Bruno Borges x x Portuguese,English,P Argentina Location: Buenos Aires Next meetup: to be scheduled Register here or send an e-mail to (fernando.wermus at gmail.com) and let us know you are interested. Name Interested Will come Language Comments Fernando Wermus x x Portuguese,English,Spanish,P Juan G. Arias x x English,Spanish,P United States Wicket Users Group - Twin Cities Location: Minneapolis, MN Next meetup: to be scheduled (see group website) http://groups.google.com/group/wicket-user-group-twincities Location: Seattle Next meetup: to be scheduled Send an e-mail to Eelco Hillenius (eelco.hillenius at gmail.com) if you'd like to see this happen Name Interested Comments Eelco Hillenius x Jonathan Locke x Eric Crampton x Jose Collas x Location: San Francisco Next meetup: to be scheduled Send an email to Orion Letizi ([EMAIL PROTECTED]) and let us know if you are interested Name Interested Will come Dec. 6 Dec. 14 Comments Orion Letizi x x x x Nick Johnson x x x x Al Maw x Can only make it if between 28th Nov and 12th Dec Julian Sinai x Sehyo Chang x David Pollak x x Enrique Rodriguez x x David Sean Taylor Sean Sullivan x x December 2 through December 6 Austria Location: Linz or Hagenberg Next meetup: to be scheduled Send an e-mail to Gerolf Seitz (gerolf.seitz at gmail.com) if you're interested in a "get together" and/or register below Name Interested Will come Comments Gerolf Seitz x x Canada Location: Ottawa Next meetup: to be scheduled Send an e-mail to Jay Lawrence (jay.a2 at infonium.ca) and let us know you are interested Name Interested Will come Comments Jay Lawrence x x Location: Toronto Next meetup: to be scheduled Send an e-mail to Mike O'Cleirigh (mike at rivulet.ca) if you're interested and/or register below Name Interested Will Come Comments Mike O'Cleirigh x x Powered by
[CONF] Apache Wicket: Wicket 1.3.2 (page created)
Page Created : WICKET : Wicket 1.3.2 Wicket 1.3.2 has been created by Frank Bille Jensen (Mar 12, 2008). Content: The Apache Wicket team is proud to announce the availability of the second maintenance release: Apache Wicket 1.3.2. A lot of bugs have been squashed and several improvements implemented. In this announcement: Apache Wicket This release Migrating from 1.2 Downloading the release Validating the release Reporting bugs The distribution Release Notes - Wicket - Version 1.3.2 Eager people click here to download the distribution, others can read further: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2 We thank you for your patience and support. The Wicket Team Apache Wicket Apache Wicket is a component oriented Java web application framework. With proper mark-up/logic separation, a POJO data model, and a refreshing lack of XML, Apache Wicket makes developing web-apps simple and enjoyable again. Swap the boilerplate, complex debugging and brittle code for powerful, reusable components written with plain Java and HTML. You can find out more about Apache Wicket on our website: http://wicket.apache.org This release This release is the second maintenance release for the Wicket 1.3 product. Development for a new version of Wicket will commence soon. This release fixes several bugs and adds some minor improvements. You can find out about the changes at the bottom of this announcement. Migrating from 1.2 If you are coming from Wicket 1.2, you really want to read our migration guide, found on the wiki: http://cwiki.apache.org/WICKET/migrate-13.html Downloading the release You can download the release from the official Apache mirror system, and you can find it through the following link: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2/ For the Maven and Ivy fans out there: update your pom's to the following, and everything will be downloaded automatically: dependency groupIdorg.apache.wicket/groupId artifactIdwicket/artifactId version1.3.2/version /dependency Substitute the artifact ID with the projects of your liking to get the other projects. Please note that we don't prescribe a Logging implementation for SLF4J. You need to specify yourself which one you prefer. Read more about SLF4J here: http://slf4j.org Validating the release The release has been signed by Frank Bille, your release manager for today. The public key can be found in the KEYS file in the download area. Download the KEYS file only from the Apache website. http://www.apache.org/dist/wicket/1.3.2/KEYS Instructions on how to validate the release can be found here: http://www.apache.org/dev/release-signing.html#check-integrity Reporting bugs In case you do encounter a bug, we would appreciate a report in our JIRA: http://issues.apache.org/jira/browse/WICKET The distribution In the distribution you will find a README. The README contains instructions on how to build from source yourself. You also find a CHANEGELOG-1.3 which contains a list of all things that have been fixed, added and/or removed since Wicket 1.3.0. Release Notes - Wicket - Version 1.3.2 Bug WICKET-1038 - Setting UnexpectedExceptionDisplay to IExceptionSettings.SHOW_NO_EXCEPTION_PAGE doesn't throw Servlet Exception WICKET-1239 - java.lang.IllegalAccessError when changing AjaxEditableLabel WICKET-1278 - Uncaught checked exceptions in page constructor WICKET-1294 - PrependingStringBuffer.hashCode() doesn't meet its contract WICKET-1305 - AbstractTextComponent requires itself to be rendered before conversion happens WICKET-1307 - autolinked resources have locale appended WICKET-1308 - TextArea trims content when saved WICKET-1314 - DateTimeField does not correct the timezone properly WICKET-1319 - StringResourceModel incorrectly escapes ' characters in choice formats WICKET-1321 - Javadoc error in QueryStringUrlCodingStrategy WICKET-1323 - AbstractPageableView has transient cachedItemCount, but doesn't set it to -1 on deserialization. WICKET-1330 - ComponentTag#setNamespace() only modifies the opening tag WICKET-1340 - Bogus LocalizedImageResource#isStateless() WICKET-1342 - Inline documentation WICKET-1353 - Typo in palette.html WICKET-1356 - When no request target is found for url we should let other filters/servers process the url instead of trying to serve the resource WICKET-1361 - Localizer doesn't honor style when caching property lookups WICKET-1364 - BaseWicketTester.isVisible() doesn't check Component.isRenderAllowed() WICKET-1365 - Having instance variables referencing pages causes memory leaks, StackOverflowErrors and ClassCastExceptions WICKET-1370 - MarkupCache can "leak" memory WICKET-1377 - AbstractCalendar use the wrong resources path WICKET-1383 - MiniMap IndexOutOfBoundsException when empty WICKET-1387 - Cookie Path of persistent
[CONF] Apache Wicket: Wicket 1.3.2 (page created)
Page Created : WICKET : Wicket 1.3.2 Wicket 1.3.2 has been created by Frank Bille Jensen (Mar 12, 2008). Content: The Apache Wicket team is proud to announce the availability of the second maintenance release: Apache Wicket 1.3.2. A lot of bugs have been squashed and several improvements implemented. In this announcement: Apache Wicket This release Migrating from 1.2 Downloading the release Validating the release Reporting bugs The distribution Release Notes - Wicket - Version 1.3.2 Eager people click here to download the distribution, others can read further: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2 We thank you for your patience and support. The Wicket Team Apache Wicket Apache Wicket is a component oriented Java web application framework. With proper mark-up/logic separation, a POJO data model, and a refreshing lack of XML, Apache Wicket makes developing web-apps simple and enjoyable again. Swap the boilerplate, complex debugging and brittle code for powerful, reusable components written with plain Java and HTML. You can find out more about Apache Wicket on our website: http://wicket.apache.org This release This release is the second maintenance release for the Wicket 1.3 product. Development for a new version of Wicket will commence soon. This release fixes several bugs and adds some minor improvements. You can find out about the changes at the bottom of this announcement. Migrating from 1.2 If you are coming from Wicket 1.2, you really want to read our migration guide, found on the wiki: http://cwiki.apache.org/WICKET/migrate-13.html Downloading the release You can download the release from the official Apache mirror system, and you can find it through the following link: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2/ For the Maven and Ivy fans out there: update your pom's to the following, and everything will be downloaded automatically: dependency groupIdorg.apache.wicket/groupId artifactIdwicket/artifactId version1.3.2/version /dependency Substitute the artifact ID with the projects of your liking to get the other projects. Please note that we don't prescribe a Logging implementation for SLF4J. You need to specify yourself which one you prefer. Read more about SLF4J here: http://slf4j.org Validating the release The release has been signed by Frank Bille, your release manager for today. The public key can be found in the KEYS file in the download area. Download the KEYS file only from the Apache website. http://www.apache.org/dist/wicket/1.3.2/KEYS Instructions on how to validate the release can be found here: http://www.apache.org/dev/release-signing.html#check-integrity Reporting bugs In case you do encounter a bug, we would appreciate a report in our JIRA: http://issues.apache.org/jira/browse/WICKET The distribution In the distribution you will find a README. The README contains instructions on how to build from source yourself. You also find a CHANEGELOG-1.3 which contains a list of all things that have been fixed, added and/or removed since Wicket 1.3.0. Release Notes - Wicket - Version 1.3.2 Bug WICKET-1038 - Setting UnexpectedExceptionDisplay to IExceptionSettings.SHOW_NO_EXCEPTION_PAGE doesn't throw Servlet Exception WICKET-1239 - java.lang.IllegalAccessError when changing AjaxEditableLabel WICKET-1278 - Uncaught checked exceptions in page constructor WICKET-1294 - PrependingStringBuffer.hashCode() doesn't meet its contract WICKET-1305 - AbstractTextComponent requires itself to be rendered before conversion happens WICKET-1307 - autolinked resources have locale appended WICKET-1308 - TextArea trims content when saved WICKET-1314 - DateTimeField does not correct the timezone properly WICKET-1319 - StringResourceModel incorrectly escapes ' characters in choice formats WICKET-1321 - Javadoc error in QueryStringUrlCodingStrategy WICKET-1323 - AbstractPageableView has transient cachedItemCount, but doesn't set it to -1 on deserialization. WICKET-1330 - ComponentTag#setNamespace() only modifies the opening tag WICKET-1340 - Bogus LocalizedImageResource#isStateless() WICKET-1342 - Inline documentation WICKET-1353 - Typo in palette.html WICKET-1356 - When no request target is found for url we should let other filters/servers process the url instead of trying to serve the resource WICKET-1361 - Localizer doesn't honor style when caching property lookups WICKET-1364 - BaseWicketTester.isVisible() doesn't check Component.isRenderAllowed() WICKET-1365 - Having instance variables referencing pages causes memory leaks, StackOverflowErrors and ClassCastExceptions WICKET-1370 - MarkupCache can "leak" memory WICKET-1377 - AbstractCalendar use the wrong resources path WICKET-1383 - MiniMap IndexOutOfBoundsException when empty WICKET-1387 - Cookie Path of persistent
[jira] Created: (WICKET-1415) BundleStringResourceLoader throws NPE if component is null
BundleStringResourceLoader throws NPE if component is null -- Key: WICKET-1415 URL: https://issues.apache.org/jira/browse/WICKET-1415 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.1 Reporter: Tony Vegas When an AjaxServerAndClientTimeFilter calls its method getStatusString, no component is set as attached object. Thus, when calling loadStringResource(final Component component, final String key) in BundleStringResourceLoader, a NullPointerException is thrown. The error occured after we added a BundleStringResourceLoader to our applicationsettings (webApplication.getResourceSettings().addStringResourceLoader(blah)) Stacktrace: java.lang.NullPointerException at org.apache.wicket.resource.loader.BundleStringResourceLoader.loadStringResource(BundleStringResourceLoader.java:94) at org.apache.wicket.Localizer.getString(Localizer.java:221) at org.apache.wicket.Localizer.getString(Localizer.java:131) at org.apache.wicket.markup.html.AjaxServerAndClientTimeFilter.getStatusString(AjaxServerAndClientTimeFilter.java:97) at org.apache.wicket.markup.html.AjaxServerAndClientTimeFilter.filter(AjaxServerAndClientTimeFilter.java:62) at org.apache.wicket.Response.filter(Response.java:104) at org.apache.wicket.protocol.http.BufferedWebResponse.filter(BufferedWebResponse.java:123) at org.apache.wicket.RequestCycle.detach(RequestCycle.java:1104) at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1334) at org.apache.wicket.RequestCycle.request(RequestCycle.java:493) at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:354) at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:194) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at com.planetj.servlet.filter.compression.CompressingFilter.doFilter(CompressingFilter.java:222) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:360) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:712) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139) at org.mortbay.jetty.Server.handle(Server.java:313) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:506) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:830) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:514) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:381) at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:396) at org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1416) WIcket Filter ignoring query parameters on redirect
WIcket Filter ignoring query parameters on redirect --- Key: WICKET-1416 URL: https://issues.apache.org/jira/browse/WICKET-1416 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.1 Reporter: Andrew Berman If you do a get on http://yoursite/yourapp?id=3 for the first time, Wicket will redirect to the home page and ignore the query params. The issue is on line 255 of WicketFilter where it builds the URL. It neglects to take into account the query params. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1416) WIcket Filter ignoring query parameters on redirect
[ https://issues.apache.org/jira/browse/WICKET-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg reassigned WICKET-1416: - Assignee: Alastair Maw (was: Matej Knopp) WIcket Filter ignoring query parameters on redirect --- Key: WICKET-1416 URL: https://issues.apache.org/jira/browse/WICKET-1416 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.1 Reporter: Andrew Berman Assignee: Alastair Maw If you do a get on http://yoursite/yourapp?id=3 for the first time, Wicket will redirect to the home page and ignore the query params. The issue is on line 255 of WicketFilter where it builds the URL. It neglects to take into account the query params. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1418) org.apache.wicket.MarkupContainer swallows AbortException
org.apache.wicket.MarkupContainer swallows AbortException - Key: WICKET-1418 URL: https://issues.apache.org/jira/browse/WICKET-1418 Project: Wicket Issue Type: Bug Components: wicket Reporter: Peter Ertl Attachments: bugtest.zip MarkupContainer#onBeforeRenderChildren() will catch exceptions of type org.apache.wicket.AbortException and remap them to a WicketRuntimeException. This is obviously wrong. For example when throwing a RestartResponseException the exception will be remapped to WicketRuntimeException and the response will not be restarted but the error page will be shown. I attached a useful to demonstrate this bug. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1419) GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from working correctly
GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from
working correctly
--
Key: WICKET-1419
URL: https://issues.apache.org/jira/browse/WICKET-1419
Project: Wicket
Issue Type: Bug
Affects Versions: 1.3.1
Reporter: Ryan Dearing
Priority: Critical
Attachments: gridview-bug.tgz
the method findNext() in GridView.java has this code:
if (cells != null cells.hasNext())
{
next = (Item)cells.next();
}
but it should be:
if (cells != null cells.hasNext())
{
next = (Item)cells.next();
return;
}
I have attached a quickstart project that will recreate the bug. When you hit
the toggle buggy link, the panel should maintain its state and you should see
the text toggle from false to true. As you can see, it works correctly in
the 1st column of panels, but the second column does not work.
There is also a class called MyGridView in the attachment that fixes the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1419) GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from working correctly
[
https://issues.apache.org/jira/browse/WICKET-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Dearing updated WICKET-1419:
-
Attachment: gridview-bug.tgz
quickstart project attached
GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from
working correctly
--
Key: WICKET-1419
URL: https://issues.apache.org/jira/browse/WICKET-1419
Project: Wicket
Issue Type: Bug
Affects Versions: 1.3.1
Reporter: Ryan Dearing
Priority: Critical
Attachments: gridview-bug.tgz
the method findNext() in GridView.java has this code:
if (cells != null cells.hasNext())
{
next = (Item)cells.next();
}
but it should be:
if (cells != null cells.hasNext())
{
next = (Item)cells.next();
return;
}
I have attached a quickstart project that will recreate the bug. When you hit
the toggle buggy link, the panel should maintain its state and you should
see the text toggle from false to true. As you can see, it works
correctly in the 1st column of panels, but the second column does not work.
There is also a class called MyGridView in the attachment that fixes the
issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1419) GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from working correctly
[
https://issues.apache.org/jira/browse/WICKET-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Dearing updated WICKET-1419:
-
Attachment: MyGridView.java
fixed version of GridView... a one liner, the best kind.
GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from
working correctly
--
Key: WICKET-1419
URL: https://issues.apache.org/jira/browse/WICKET-1419
Project: Wicket
Issue Type: Bug
Affects Versions: 1.3.1
Reporter: Ryan Dearing
Priority: Critical
Attachments: gridview-bug.tgz, MyGridView.java
the method findNext() in GridView.java has this code:
if (cells != null cells.hasNext())
{
next = (Item)cells.next();
}
but it should be:
if (cells != null cells.hasNext())
{
next = (Item)cells.next();
return;
}
I have attached a quickstart project that will recreate the bug. When you hit
the toggle buggy link, the panel should maintain its state and you should
see the text toggle from false to true. As you can see, it works
correctly in the 1st column of panels, but the second column does not work.
There is also a class called MyGridView in the attachment that fixes the
issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1419) GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from working correctly
[
https://issues.apache.org/jira/browse/WICKET-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-1419.
---
Resolution: Fixed
Fix Version/s: 1.3.2
Assignee: Igor Vaynberg
GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from
working correctly
--
Key: WICKET-1419
URL: https://issues.apache.org/jira/browse/WICKET-1419
Project: Wicket
Issue Type: Bug
Affects Versions: 1.3.1
Reporter: Ryan Dearing
Assignee: Igor Vaynberg
Priority: Critical
Fix For: 1.3.2
Attachments: gridview-bug.tgz, MyGridView.java
the method findNext() in GridView.java has this code:
if (cells != null cells.hasNext())
{
next = (Item)cells.next();
}
but it should be:
if (cells != null cells.hasNext())
{
next = (Item)cells.next();
return;
}
I have attached a quickstart project that will recreate the bug. When you hit
the toggle buggy link, the panel should maintain its state and you should
see the text toggle from false to true. As you can see, it works
correctly in the 1st column of panels, but the second column does not work.
There is also a class called MyGridView in the attachment that fixes the
issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1418) org.apache.wicket.MarkupContainer swallows AbortException
[ https://issues.apache.org/jira/browse/WICKET-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg updated WICKET-1418: -- Attachment: wicket-patch proposed general solution org.apache.wicket.MarkupContainer swallows AbortException - Key: WICKET-1418 URL: https://issues.apache.org/jira/browse/WICKET-1418 Project: Wicket Issue Type: Bug Components: wicket Reporter: Peter Ertl Assignee: Igor Vaynberg Attachments: bugtest.zip, wicket-patch MarkupContainer#onBeforeRenderChildren() will catch exceptions of type org.apache.wicket.AbortException and remap them to a WicketRuntimeException. This is obviously wrong. For example when throwing a RestartResponseException the exception will be remapped to WicketRuntimeException and the response will not be restarted but the error page will be shown. I attached a useful to demonstrate this bug. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1420) Allow to change charset in StringRequestTarget
Allow to change charset in StringRequestTarget -- Key: WICKET-1420 URL: https://issues.apache.org/jira/browse/WICKET-1420 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.3.1 Reporter: Carlos Pita It's impossible to access the created StringBufferResourceStream charset without overriding the entire respond method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
