svn commit: r650767 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket: markup/html/form/ListMultipleChoice.java util/string/StringList.java util/string/Strings.java util/upload/FileUploadBase.
Author: frankbille
Date: Wed Apr 23 00:11:32 2008
New Revision: 650767
URL: http://svn.apache.org/viewvc?rev=650767&view=rev
Log:
More generics
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/StringList.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/Strings.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/upload/FileUploadBase.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/upload/ParameterParser.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java?rev=650767&r1=650766&r2=650767&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
Wed Apr 23 00:11:32 2008
@@ -18,7 +18,6 @@
import java.util.ArrayList;
import java.util.Collection;
-import java.util.Iterator;
import java.util.List;
import java.util.StringTokenizer;
@@ -196,23 +195,13 @@
@Override
public final String getModelValue()
{
- // Get the list of selected values
- Object modelObject = getModelObject();
- if (modelObject != null && !(modelObject instanceof Collection))
- {
- throw new WicketRuntimeException(
- "Model object for a ListMultipleChoice must be
a Collection (found " +
- modelObject.getClass() + ")");
- }
- final Collection selectedValues = (Collection)modelObject;
+ final Collection selectedValues = getModelObject();
final AppendingStringBuffer buffer = new
AppendingStringBuffer();
if (selectedValues != null)
{
final List< ? extends T> choices = getChoices();
- for (final Iterator iterator =
selectedValues.iterator(); iterator.hasNext();)
+ for (T object : selectedValues)
{
- final T object = iterator.next();
-
int index = choices.indexOf(object);
buffer.append(getChoiceRenderer().getIdValue(object, index));
buffer.append(VALUE_SEPARATOR);
@@ -271,7 +260,7 @@
else
{
// TODO 1.3: check if its safe to return
Collections.EMPTY_LIST here
- return new ArrayList();
+ return new ArrayList();
}
}
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/StringList.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/StringList.java?rev=650767&r1=650766&r2=650767&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/StringList.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/StringList.java
Wed Apr 23 00:11:32 2008
@@ -56,7 +56,7 @@
private static final long serialVersionUID = 1L;
// The underlying list of strings
- private final List strings;
+ private final List strings;
// The total length of all strings in the list
private int totalLength;
@@ -124,15 +124,15 @@
*The collection to add as strings
* @return The list
*/
- public static StringList valueOf(final Collection collection)
+ public static StringList valueOf(final Collection< ? > collection)
{
if (collection != null)
{
final StringList strings = new
StringList(collection.size());
- for (final Iterator iterator = collection.iterator();
iterator.hasNext();)
+ for (Object object : collection)
{
-
strings.add(StringValue.valueOf(iterator.next()));
+ strings.add(StringValue.valueOf(object));
}
return strings;
@@ -209,7 +209,7 @@
*/
public StringList()
{
- this.strings = new ArrayList();
+ strings = new ArrayList();
}
/**
@@ -220,7 +220,7 @@
*/
public StringList(final int size)
{
- this.strings = new ArrayList(size);
+
[jira] Created: (WICKET-1560) MarkupFragmentFinder fails on transparent resolvers within Repeaters
MarkupFragmentFinder fails on transparent resolvers within Repeaters
Key: WICKET-1560
URL: https://issues.apache.org/jira/browse/WICKET-1560
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.3
Environment: Any
Reporter: Jan Kriesten
Priority: Critical
Fix For: 1.3.4
I extended the AjaxDataTable to be able to add Rows to certain states of the
rows. However, MarkupFragmentFinder fails to resolve the code under this
condition since it compares with the wrong components in this case:
Markup:
[cell]
'row' is the transparent resolver in this case to maintain the hierarchy needed
by the DataTable. MarkupFragmentFinder fails in the case of adding a cell to an
AjaxRequestTarget.
Fix:
Everything works as expected, when MarkupFragmentFinder checks for the parent
being an AbstractRepeater and in the case compares the parent.id with the
supplied id (code provided by Gerolf):
if (elem instanceof ComponentTag)
{
ComponentTag tag = (ComponentTag)elem;
String id = tag.getId();
if ((id != null) && id.equals(component.getId()))
{
// Ok, found it
return markupStream;
}
else
{
Component parent = component.getParent();
if (parent instanceof AbstractRepeater && id != null &&
id.equals(parent.getId()))
{
return markupStream;
}
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1560) MarkupFragmentFinder fails on transparent resolvers within Repeaters
[
https://issues.apache.org/jira/browse/WICKET-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591580#action_12591580
]
Jan Kriesten commented on WICKET-1560:
--
Just realized:
Maybe it doesn't has to do anything with transparent resolvers at all but only
with nested repeaters and adding cells from the innermost.
> MarkupFragmentFinder fails on transparent resolvers within Repeaters
>
>
> Key: WICKET-1560
> URL: https://issues.apache.org/jira/browse/WICKET-1560
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.3
> Environment: Any
>Reporter: Jan Kriesten
>Priority: Critical
> Fix For: 1.3.4
>
>
> I extended the AjaxDataTable to be able to add Rows to certain states of the
> rows. However, MarkupFragmentFinder fails to resolve the code under this
> condition since it compares with the wrong components in this case:
> Markup:
>
>wicket:id="cell">[cell]
>
>
> 'row' is the transparent resolver in this case to maintain the hierarchy
> needed by the DataTable. MarkupFragmentFinder fails in the case of adding a
> cell to an AjaxRequestTarget.
> Fix:
> Everything works as expected, when MarkupFragmentFinder checks for the parent
> being an AbstractRepeater and in the case compares the parent.id with the
> supplied id (code provided by Gerolf):
> if (elem instanceof ComponentTag)
> {
> ComponentTag tag = (ComponentTag)elem;
> String id = tag.getId();
> if ((id != null) && id.equals(component.getId()))
> {
> // Ok, found it
> return markupStream;
> }
> else
> {
> Component parent = component.getParent();
> if (parent instanceof AbstractRepeater && id != null &&
> id.equals(parent.getId()))
> {
> return markupStream;
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1561) Quickstart Build Failure: "No mojo descriptors found in plugin"
[ https://issues.apache.org/jira/browse/WICKET-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Carman updated WICKET-1561: - Attachment: archetype-patch.patch > Quickstart Build Failure: "No mojo descriptors found in plugin" > --- > > Key: WICKET-1561 > URL: https://issues.apache.org/jira/browse/WICKET-1561 > Project: Wicket > Issue Type: Bug > Components: wicket-quickstart >Affects Versions: 1.4-M1 > Environment: Maven version: 2.0.8 > Java version: 1.5.0_14 > OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows" >Reporter: James Carman > Attachments: archetype-patch.patch > > > The artifact type should be changed to "maven-archetype" to fix this issue > (patch attached). See: > http://jira.codehaus.org/browse/MPLUGIN-102 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1561) Quickstart Build Failure: "No mojo descriptors found in plugin"
Quickstart Build Failure: "No mojo descriptors found in plugin" --- Key: WICKET-1561 URL: https://issues.apache.org/jira/browse/WICKET-1561 Project: Wicket Issue Type: Bug Components: wicket-quickstart Affects Versions: 1.4-M1 Environment: Maven version: 2.0.8 Java version: 1.5.0_14 OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows" Reporter: James Carman Attachments: archetype-patch.patch The artifact type should be changed to "maven-archetype" to fix this issue (patch attached). See: http://jira.codehaus.org/browse/MPLUGIN-102 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1561) Quickstart Build Failure: "No mojo descriptors found in plugin"
[ https://issues.apache.org/jira/browse/WICKET-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Carman updated WICKET-1561: - Description: The artifact type should be changed to "maven-archetype" to fix this issue (patch attached). See: http://jira.codehaus.org/browse/MPLUGIN-102 Here's my build output: [INFO] Scanning for projects... [INFO] [INFO] Building Wicket Quickstart Archetype [INFO]task-segment: [install] [INFO] [INFO] [plugin:descriptor] [INFO] Using 2 extractors. [INFO] Applying extractor for language: java [INFO] Extractor for language: java found 0 mojo descriptors. [INFO] Applying extractor for language: bsh [INFO] Extractor for language: bsh found 0 mojo descriptors. [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Error extracting plugin descriptor: 'No mojo descriptors found in plugin. ' [INFO] [INFO] For more information, run Maven with the -e switch [INFO] [INFO] Total time: 2 seconds [INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008 [INFO] Final Memory: 9M/18M [INFO] was: The artifact type should be changed to "maven-archetype" to fix this issue (patch attached). See: http://jira.codehaus.org/browse/MPLUGIN-102 > Quickstart Build Failure: "No mojo descriptors found in plugin" > --- > > Key: WICKET-1561 > URL: https://issues.apache.org/jira/browse/WICKET-1561 > Project: Wicket > Issue Type: Bug > Components: wicket-quickstart >Affects Versions: 1.4-M1 > Environment: Maven version: 2.0.8 > Java version: 1.5.0_14 > OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows" >Reporter: James Carman > Attachments: archetype-patch.patch > > > The artifact type should be changed to "maven-archetype" to fix this issue > (patch attached). See: > http://jira.codehaus.org/browse/MPLUGIN-102 > Here's my build output: > [INFO] Scanning for projects... > [INFO] > > [INFO] Building Wicket Quickstart Archetype > [INFO]task-segment: [install] > [INFO] > > [INFO] [plugin:descriptor] > [INFO] Using 2 extractors. > [INFO] Applying extractor for language: java > [INFO] Extractor for language: java found 0 mojo descriptors. > [INFO] Applying extractor for language: bsh > [INFO] Extractor for language: bsh found 0 mojo descriptors. > [INFO] > > [ERROR] BUILD ERROR > [INFO] > > [INFO] Error extracting plugin descriptor: 'No mojo descriptors found in > plugin. > ' > [INFO] > > [INFO] For more information, run Maven with the -e switch > [INFO] > > [INFO] Total time: 2 seconds > [INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008 > [INFO] Final Memory: 9M/18M > [INFO] > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1561) Quickstart Build Failure: "No mojo descriptors found in plugin"
[
https://issues.apache.org/jira/browse/WICKET-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Carman updated WICKET-1561:
-
Description:
The artifact type should be changed to "maven-archetype" to fix this issue
(patch attached). See:
http://jira.codehaus.org/browse/MPLUGIN-102
Here's my build output:
{panel}
[INFO] Scanning for projects...
[INFO]
[INFO] Building Wicket Quickstart Archetype
[INFO]task-segment: [install]
[INFO]
[INFO] [plugin:descriptor]
[INFO] Using 2 extractors.
[INFO] Applying extractor for language: java
[INFO] Extractor for language: java found 0 mojo descriptors.
[INFO] Applying extractor for language: bsh
[INFO] Extractor for language: bsh found 0 mojo descriptors.
[INFO]
[ERROR] BUILD ERROR
[INFO]
[INFO] Error extracting plugin descriptor: 'No mojo descriptors found in plugin.
'
[INFO]
[INFO] For more information, run Maven with the -e switch
[INFO]
[INFO] Total time: 2 seconds
[INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008
[INFO] Final Memory: 9M/18M
[INFO]
{panel}
was:
The artifact type should be changed to "maven-archetype" to fix this issue
(patch attached). See:
http://jira.codehaus.org/browse/MPLUGIN-102
Here's my build output:
[INFO] Scanning for projects...
[INFO]
[INFO] Building Wicket Quickstart Archetype
[INFO]task-segment: [install]
[INFO]
[INFO] [plugin:descriptor]
[INFO] Using 2 extractors.
[INFO] Applying extractor for language: java
[INFO] Extractor for language: java found 0 mojo descriptors.
[INFO] Applying extractor for language: bsh
[INFO] Extractor for language: bsh found 0 mojo descriptors.
[INFO]
[ERROR] BUILD ERROR
[INFO]
[INFO] Error extracting plugin descriptor: 'No mojo descriptors found in plugin.
'
[INFO]
[INFO] For more information, run Maven with the -e switch
[INFO]
[INFO] Total time: 2 seconds
[INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008
[INFO] Final Memory: 9M/18M
[INFO]
> Quickstart Build Failure: "No mojo descriptors found in plugin"
> ---
>
> Key: WICKET-1561
> URL: https://issues.apache.org/jira/browse/WICKET-1561
> Project: Wicket
> Issue Type: Bug
> Components: wicket-quickstart
>Affects Versions: 1.4-M1
> Environment: Maven version: 2.0.8
> Java version: 1.5.0_14
> OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows"
>Reporter: James Carman
> Attachments: archetype-patch.patch
>
>
> The artifact type should be changed to "maven-archetype" to fix this issue
> (patch attached). See:
> http://jira.codehaus.org/browse/MPLUGIN-102
> Here's my build output:
> {panel}
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Building Wicket Quickstart Archetype
> [INFO]task-segment: [install]
> [INFO]
>
> [INFO] [plugin:descriptor]
> [INFO] Using 2 extractors.
> [INFO] Applying extractor for language: java
> [INFO] Extractor for language: java found 0 mojo descriptors.
> [INFO] Applying extractor for language: bsh
> [INFO] Extractor for language: bsh found 0 mojo descriptors.
> [INFO]
>
> [ERROR] BUILD ERROR
> [INFO]
>
> [INFO] Error extracting plugin descriptor: 'No mojo descriptors found in
> plugin.
> '
> [INFO]
>
> [INFO] For more information, run Maven with the -e switch
> [INFO]
>
> [INFO] Total time: 2 seconds
> [INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008
> [INFO] Final Memory: 9M/18M
> [INFO]
> --
[jira] Updated: (WICKET-1561) Quickstart Build Failure: "No mojo descriptors found in plugin"
[
https://issues.apache.org/jira/browse/WICKET-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Carman updated WICKET-1561:
-
Description:
The artifact type should be changed to "maven-archetype" to fix this issue
(patch attached). See:
http://jira.codehaus.org/browse/MPLUGIN-102
Here's my build output:
{noformat}
[INFO] Scanning for projects...
[INFO]
[INFO] Building Wicket Quickstart Archetype
[INFO]task-segment: [install]
[INFO]
[INFO] [plugin:descriptor]
[INFO] Using 2 extractors.
[INFO] Applying extractor for language: java
[INFO] Extractor for language: java found 0 mojo descriptors.
[INFO] Applying extractor for language: bsh
[INFO] Extractor for language: bsh found 0 mojo descriptors.
[INFO]
[ERROR] BUILD ERROR
[INFO]
[INFO] Error extracting plugin descriptor: 'No mojo descriptors found in plugin.
'
[INFO]
[INFO] For more information, run Maven with the -e switch
[INFO]
[INFO] Total time: 2 seconds
[INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008
[INFO] Final Memory: 9M/18M
[INFO]
{noformat}
was:
The artifact type should be changed to "maven-archetype" to fix this issue
(patch attached). See:
http://jira.codehaus.org/browse/MPLUGIN-102
Here's my build output:
{panel}
[INFO] Scanning for projects...
[INFO]
[INFO] Building Wicket Quickstart Archetype
[INFO]task-segment: [install]
[INFO]
[INFO] [plugin:descriptor]
[INFO] Using 2 extractors.
[INFO] Applying extractor for language: java
[INFO] Extractor for language: java found 0 mojo descriptors.
[INFO] Applying extractor for language: bsh
[INFO] Extractor for language: bsh found 0 mojo descriptors.
[INFO]
[ERROR] BUILD ERROR
[INFO]
[INFO] Error extracting plugin descriptor: 'No mojo descriptors found in plugin.
'
[INFO]
[INFO] For more information, run Maven with the -e switch
[INFO]
[INFO] Total time: 2 seconds
[INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008
[INFO] Final Memory: 9M/18M
[INFO]
{panel}
> Quickstart Build Failure: "No mojo descriptors found in plugin"
> ---
>
> Key: WICKET-1561
> URL: https://issues.apache.org/jira/browse/WICKET-1561
> Project: Wicket
> Issue Type: Bug
> Components: wicket-quickstart
>Affects Versions: 1.4-M1
> Environment: Maven version: 2.0.8
> Java version: 1.5.0_14
> OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows"
>Reporter: James Carman
> Attachments: archetype-patch.patch
>
>
> The artifact type should be changed to "maven-archetype" to fix this issue
> (patch attached). See:
> http://jira.codehaus.org/browse/MPLUGIN-102
> Here's my build output:
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Building Wicket Quickstart Archetype
> [INFO]task-segment: [install]
> [INFO]
>
> [INFO] [plugin:descriptor]
> [INFO] Using 2 extractors.
> [INFO] Applying extractor for language: java
> [INFO] Extractor for language: java found 0 mojo descriptors.
> [INFO] Applying extractor for language: bsh
> [INFO] Extractor for language: bsh found 0 mojo descriptors.
> [INFO]
>
> [ERROR] BUILD ERROR
> [INFO]
>
> [INFO] Error extracting plugin descriptor: 'No mojo descriptors found in
> plugin.
> '
> [INFO]
>
> [INFO] For more information, run Maven with the -e switch
> [INFO]
>
> [INFO] Total time: 2 seconds
> [INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008
> [INFO] Final Memory: 9M/18M
> [INFO]
> --
[jira] Updated: (WICKET-1561) Quickstart Build Failure: "No mojo descriptors found in plugin"
[
https://issues.apache.org/jira/browse/WICKET-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Carman updated WICKET-1561:
-
Description:
The artifact type should be changed to "maven-archetype" to fix this issue
(patch attached). See:
http://jira.codehaus.org/browse/MPLUGIN-102
Here's my build output:
[INFO] Scanning for projects...
[INFO]
[INFO] Building Wicket Quickstart Archetype
[INFO]task-segment: [install]
[INFO]
[INFO] [plugin:descriptor]
[INFO] Using 2 extractors.
[INFO] Applying extractor for language: java
[INFO] Extractor for language: java found 0 mojo descriptors.
[INFO] Applying extractor for language: bsh
[INFO] Extractor for language: bsh found 0 mojo descriptors.
[INFO]
[ERROR] BUILD ERROR
[INFO]
[INFO] Error extracting plugin descriptor: 'No mojo descriptors found in plugin.
'
[INFO]
[INFO] For more information, run Maven with the -e switch
[INFO]
[INFO] Total time: 2 seconds
[INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008
[INFO] Final Memory: 9M/18M
[INFO]
was:
The artifact type should be changed to "maven-archetype" to fix this issue
(patch attached). See:
http://jira.codehaus.org/browse/MPLUGIN-102
Here's my build output:
{noformat}
[INFO] Scanning for projects...
[INFO]
[INFO] Building Wicket Quickstart Archetype
[INFO]task-segment: [install]
[INFO]
[INFO] [plugin:descriptor]
[INFO] Using 2 extractors.
[INFO] Applying extractor for language: java
[INFO] Extractor for language: java found 0 mojo descriptors.
[INFO] Applying extractor for language: bsh
[INFO] Extractor for language: bsh found 0 mojo descriptors.
[INFO]
[ERROR] BUILD ERROR
[INFO]
[INFO] Error extracting plugin descriptor: 'No mojo descriptors found in plugin.
'
[INFO]
[INFO] For more information, run Maven with the -e switch
[INFO]
[INFO] Total time: 2 seconds
[INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008
[INFO] Final Memory: 9M/18M
[INFO]
{noformat}
> Quickstart Build Failure: "No mojo descriptors found in plugin"
> ---
>
> Key: WICKET-1561
> URL: https://issues.apache.org/jira/browse/WICKET-1561
> Project: Wicket
> Issue Type: Bug
> Components: wicket-quickstart
>Affects Versions: 1.4-M1
> Environment: Maven version: 2.0.8
> Java version: 1.5.0_14
> OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows"
>Reporter: James Carman
> Attachments: archetype-patch.patch
>
>
> The artifact type should be changed to "maven-archetype" to fix this issue
> (patch attached). See:
> http://jira.codehaus.org/browse/MPLUGIN-102
> Here's my build output:
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Building Wicket Quickstart Archetype
> [INFO]task-segment: [install]
> [INFO]
>
> [INFO] [plugin:descriptor]
> [INFO] Using 2 extractors.
> [INFO] Applying extractor for language: java
> [INFO] Extractor for language: java found 0 mojo descriptors.
> [INFO] Applying extractor for language: bsh
> [INFO] Extractor for language: bsh found 0 mojo descriptors.
> [INFO]
>
> [ERROR] BUILD ERROR
> [INFO]
>
> [INFO] Error extracting plugin descriptor: 'No mojo descriptors found in
> plugin.
> '
> [INFO]
>
> [INFO] For more information, run Maven with the -e switch
> [INFO]
>
> [INFO] Total time: 2 seconds
> [INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008
> [INFO] Final Memory: 9M/18M
> [INFO]
> -
[jira] Commented: (WICKET-1561) Quickstart Build Failure: "No mojo descriptors found in plugin"
[ https://issues.apache.org/jira/browse/WICKET-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591623#action_12591623 ] Gerolf Seitz commented on WICKET-1561: -- well, i can't even do "mvn install" for the archetype: [INFO] Scanning for projects... [INFO] [INFO] Building Wicket Quickstart Archetype [INFO]task-segment: [install] [INFO] [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Cannot find lifecycle mapping for packaging: 'maven-archetype'. Component descriptor cannot be found in the component repository: org.apache.maven.lifecycle.mapping.LifecycleMappingmaven-archetype. [INFO] [INFO] For more information, run Maven with the -e switch [INFO] [INFO] Total time: < 1 second [INFO] Finished at: Wed Apr 23 14:15:45 CEST 2008 [INFO] Final Memory: 1M/4M [INFO] do i have to update some maven plugins for this to work (or clean my local repo)? when it is set to "maven-plugin", it does work. > Quickstart Build Failure: "No mojo descriptors found in plugin" > --- > > Key: WICKET-1561 > URL: https://issues.apache.org/jira/browse/WICKET-1561 > Project: Wicket > Issue Type: Bug > Components: wicket-quickstart >Affects Versions: 1.4-M1 > Environment: Maven version: 2.0.8 > Java version: 1.5.0_14 > OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows" >Reporter: James Carman > Attachments: archetype-patch.patch > > > The artifact type should be changed to "maven-archetype" to fix this issue > (patch attached). See: > http://jira.codehaus.org/browse/MPLUGIN-102 > Here's my build output: > [INFO] Scanning for projects... > [INFO] > > [INFO] Building Wicket Quickstart Archetype > [INFO]task-segment: [install] > [INFO] > > [INFO] [plugin:descriptor] > [INFO] Using 2 extractors. > [INFO] Applying extractor for language: java > [INFO] Extractor for language: java found 0 mojo descriptors. > [INFO] Applying extractor for language: bsh > [INFO] Extractor for language: bsh found 0 mojo descriptors. > [INFO] > > [ERROR] BUILD ERROR > [INFO] > > [INFO] Error extracting plugin descriptor: 'No mojo descriptors found in > plugin. > ' > [INFO] > > [INFO] For more information, run Maven with the -e switch > [INFO] > > [INFO] Total time: 2 seconds > [INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008 > [INFO] Final Memory: 9M/18M > [INFO] > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1561) Quickstart Build Failure: "No mojo descriptors found in plugin"
[ https://issues.apache.org/jira/browse/WICKET-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591632#action_12591632 ] James Carman commented on WICKET-1561: -- Well, the other way to fix this is to "lock down" the maven-plugin-plugin version. Do you have that locked down somewhere or are you building from a clean "trunk"? I just checked out the trunk and tried a clean build and it failed (with the error message as I described). > Quickstart Build Failure: "No mojo descriptors found in plugin" > --- > > Key: WICKET-1561 > URL: https://issues.apache.org/jira/browse/WICKET-1561 > Project: Wicket > Issue Type: Bug > Components: wicket-quickstart >Affects Versions: 1.4-M1 > Environment: Maven version: 2.0.8 > Java version: 1.5.0_14 > OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows" >Reporter: James Carman > Attachments: archetype-patch.patch > > > The artifact type should be changed to "maven-archetype" to fix this issue > (patch attached). See: > http://jira.codehaus.org/browse/MPLUGIN-102 > Here's my build output: > [INFO] Scanning for projects... > [INFO] > > [INFO] Building Wicket Quickstart Archetype > [INFO]task-segment: [install] > [INFO] > > [INFO] [plugin:descriptor] > [INFO] Using 2 extractors. > [INFO] Applying extractor for language: java > [INFO] Extractor for language: java found 0 mojo descriptors. > [INFO] Applying extractor for language: bsh > [INFO] Extractor for language: bsh found 0 mojo descriptors. > [INFO] > > [ERROR] BUILD ERROR > [INFO] > > [INFO] Error extracting plugin descriptor: 'No mojo descriptors found in > plugin. > ' > [INFO] > > [INFO] For more information, run Maven with the -e switch > [INFO] > > [INFO] Total time: 2 seconds > [INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008 > [INFO] Final Memory: 9M/18M > [INFO] > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1561) Quickstart Build Failure: "No mojo descriptors found in plugin"
[ https://issues.apache.org/jira/browse/WICKET-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591644#action_12591644 ] Gerolf Seitz commented on WICKET-1561: -- i don't see it in our parent pom.xml which version should we lock down? > Quickstart Build Failure: "No mojo descriptors found in plugin" > --- > > Key: WICKET-1561 > URL: https://issues.apache.org/jira/browse/WICKET-1561 > Project: Wicket > Issue Type: Bug > Components: wicket-quickstart >Affects Versions: 1.4-M1 > Environment: Maven version: 2.0.8 > Java version: 1.5.0_14 > OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows" >Reporter: James Carman > Attachments: archetype-patch.patch > > > The artifact type should be changed to "maven-archetype" to fix this issue > (patch attached). See: > http://jira.codehaus.org/browse/MPLUGIN-102 > Here's my build output: > [INFO] Scanning for projects... > [INFO] > > [INFO] Building Wicket Quickstart Archetype > [INFO]task-segment: [install] > [INFO] > > [INFO] [plugin:descriptor] > [INFO] Using 2 extractors. > [INFO] Applying extractor for language: java > [INFO] Extractor for language: java found 0 mojo descriptors. > [INFO] Applying extractor for language: bsh > [INFO] Extractor for language: bsh found 0 mojo descriptors. > [INFO] > > [ERROR] BUILD ERROR > [INFO] > > [INFO] Error extracting plugin descriptor: 'No mojo descriptors found in > plugin. > ' > [INFO] > > [INFO] For more information, run Maven with the -e switch > [INFO] > > [INFO] Total time: 2 seconds > [INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008 > [INFO] Final Memory: 9M/18M > [INFO] > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1562) Autocomplete should display the selection list even if the input field is empty
Autocomplete should display the selection list even if the input field is empty --- Key: WICKET-1562 URL: https://issues.apache.org/jira/browse/WICKET-1562 Project: Wicket Issue Type: Wish Components: wicket-extensions Reporter: Gabriel Erzse If you use autocomplete on a text field, when the input field is empty, the selection list is never displayed. However one could send a non-empty list of values when the input field is empty. For example one could send the complete list with all possible values. Later, as the user starts typing in the field, the list would get narrowed down. So it would be nice if the selection list is displayed even if the input field is empty. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1562) Autocomplete should display the selection list even if the input field is empty
[ https://issues.apache.org/jira/browse/WICKET-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg reassigned WICKET-1562: - Assignee: Gerolf Seitz > Autocomplete should display the selection list even if the input field is > empty > --- > > Key: WICKET-1562 > URL: https://issues.apache.org/jira/browse/WICKET-1562 > Project: Wicket > Issue Type: Wish > Components: wicket-extensions >Reporter: Gabriel Erzse >Assignee: Gerolf Seitz > > If you use autocomplete on a text field, when the input field is empty, the > selection list is never displayed. However one could send a non-empty list of > values when the input field is empty. For example one could send the complete > list with all possible values. Later, as the user starts typing in the field, > the list would get narrowed down. > So it would be nice if the selection list is displayed even if the input > field is empty. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1561) Quickstart Build Failure: "No mojo descriptors found in plugin"
[ https://issues.apache.org/jira/browse/WICKET-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591702#action_12591702 ] James Carman commented on WICKET-1561: -- In the maven bug report, I showed how locking it down to 2.3 made it work. But, the way you're supposed to do it going forward it to use maven-archetype. What version of Maven are you using? > Quickstart Build Failure: "No mojo descriptors found in plugin" > --- > > Key: WICKET-1561 > URL: https://issues.apache.org/jira/browse/WICKET-1561 > Project: Wicket > Issue Type: Bug > Components: wicket-quickstart >Affects Versions: 1.4-M1 > Environment: Maven version: 2.0.8 > Java version: 1.5.0_14 > OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows" >Reporter: James Carman > Attachments: archetype-patch.patch > > > The artifact type should be changed to "maven-archetype" to fix this issue > (patch attached). See: > http://jira.codehaus.org/browse/MPLUGIN-102 > Here's my build output: > [INFO] Scanning for projects... > [INFO] > > [INFO] Building Wicket Quickstart Archetype > [INFO]task-segment: [install] > [INFO] > > [INFO] [plugin:descriptor] > [INFO] Using 2 extractors. > [INFO] Applying extractor for language: java > [INFO] Extractor for language: java found 0 mojo descriptors. > [INFO] Applying extractor for language: bsh > [INFO] Extractor for language: bsh found 0 mojo descriptors. > [INFO] > > [ERROR] BUILD ERROR > [INFO] > > [INFO] Error extracting plugin descriptor: 'No mojo descriptors found in > plugin. > ' > [INFO] > > [INFO] For more information, run Maven with the -e switch > [INFO] > > [INFO] Total time: 2 seconds > [INFO] Finished at: Wed Apr 23 07:51:19 EDT 2008 > [INFO] Final Memory: 9M/18M > [INFO] > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r650977 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/tree/BaseTree.java
Author: knopp
Date: Wed Apr 23 11:18:47 2008
New Revision: 650977
URL: http://svn.apache.org/viewvc?rev=650977&view=rev
Log:
added getItemClass
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/tree/BaseTree.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/tree/BaseTree.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/tree/BaseTree.java?rev=650977&r1=650976&r2=650977&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/tree/BaseTree.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/tree/BaseTree.java
Wed Apr 23 11:18:47 2008
@@ -118,20 +118,33 @@
public void onComponentTag(Component component,
ComponentTag tag)
{
Object node = component.getModelObject();
- if (getTreeState().isNodeSelected(node))
+ String klass = getItemClass(node);
+ if (!Strings.isEmpty(klass))
{
CharSequence oldClass =
tag.getString("class");
if (Strings.isEmpty(oldClass))
{
- tag.put("class",
getSelectedClass());
+ tag.put("class", klass);
}
else
{
- tag.put("class", oldClass + " "
+ getSelectedClass());
+ tag.put("class", oldClass + " "
+ klass);
}
}
}
});
+ }
+
+ protected String getItemClass(Object node)
+ {
+ if (getTreeState().isNodeSelected(node))
+ {
+ return getSelectedClass();
+ }
+ else
+ {
+ return null;
+ }
}
/**
[jira] Created: (WICKET-1563) renderOnLoadJavascript being called multiple times
renderOnLoadJavascript being called multiple times -- Key: WICKET-1563 URL: https://issues.apache.org/jira/browse/WICKET-1563 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.3 Reporter: Carlos Pita There are at least of couple of common scenarios where this happens: - you add the component that is a header contributor to an ajax target: renderHead is called as part of target.respond() and latter by page.detach() - you add the component that is a header contributor more than once to an ajax target. Normally you can't control this, because the component in question is added by another component indirectly, by adding some of its ancestors. renderHead is called multiple times as part of target.respond() and latter yet another time by page.detach() I think there must be a check to avoid repetitions of these nature, maybe by means of an id, the same as renderJavascript() does. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1563) renderOnLoadJavascript being called multiple times
[ https://issues.apache.org/jira/browse/WICKET-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg reassigned WICKET-1563: - Assignee: Matej Knopp > renderOnLoadJavascript being called multiple times > -- > > Key: WICKET-1563 > URL: https://issues.apache.org/jira/browse/WICKET-1563 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3.3 >Reporter: Carlos Pita >Assignee: Matej Knopp > > There are at least of couple of common scenarios where this happens: > - you add the component that is a header contributor to an ajax target: > renderHead is called as part of target.respond() and latter by page.detach() > - you add the component that is a header contributor more than once to an > ajax target. Normally you can't control this, because the component in > question is added by another component indirectly, by adding some of its > ancestors. renderHead is called multiple times as part of target.respond() > and latter yet another time by page.detach() > I think there must be a check to avoid repetitions of these nature, maybe by > means of an id, the same as renderJavascript() does. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
