[jira] Created: (WICKET-1589) gzipping of pages (html responses) - not only resources
gzipping of pages (html responses) - not only resources - Key: WICKET-1589 URL: https://issues.apache.org/jira/browse/WICKET-1589 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.3.3 Reporter: Stefan Simik Priority: Minor It would be very good improvement, if it is possible to gzip output of wicket pages (html). Gzipping of resources in wicket is great, but it would be better to add gzipping all pages (i.e. html output) too. But to implement this functionality, it is needed to change som e API. One possibility, how to implement this, is to use custom BufferedResponse. Johan looked at it and we need to change a bit of code/api for this to work out. The problem is that we sometimes have a byte[] that we send to the output through an outputstream and sometimes we do it through the writer. All depends on the redirect strategy. Thread on wicket nabble: http://www.nabble.com/Gzipping-of-pages-%28HTML-output%2C-not-only-resources%29-to16849900.html#a16849900 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1589) gzipping of pages (html responses) - not only resources
[ https://issues.apache.org/jira/browse/WICKET-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johan Compagner updated WICKET-1589: Fix Version/s: 1.4-M3 Assignee: Johan Compagner will see if i can improve that for 1.4 else it will skip to 1.5 gzipping of pages (html responses) - not only resources - Key: WICKET-1589 URL: https://issues.apache.org/jira/browse/WICKET-1589 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.3.3 Reporter: Stefan Simik Assignee: Johan Compagner Priority: Minor Fix For: 1.4-M3 It would be very good improvement, if it is possible to gzip output of wicket pages (html). Gzipping of resources in wicket is great, but it would be better to add gzipping all pages (i.e. html output) too. But to implement this functionality, it is needed to change som e API. One possibility, how to implement this, is to use custom BufferedResponse. Johan looked at it and we need to change a bit of code/api for this to work out. The problem is that we sometimes have a byte[] that we send to the output through an outputstream and sometimes we do it through the writer. All depends on the redirect strategy. Thread on wicket nabble: http://www.nabble.com/Gzipping-of-pages-%28HTML-output%2C-not-only-resources%29-to16849900.html#a16849900 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1590) AjaxEditableChoiceLabel ignores ChoiceRenderer in newLabel(...)
AjaxEditableChoiceLabel ignores ChoiceRenderer in newLabel(...) --- Key: WICKET-1590 URL: https://issues.apache.org/jira/browse/WICKET-1590 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.4-M1, 1.3.3 Reporter: Alexander Keul Priority: Minor Fix For: 1.4-M1, 1.3.3 AjaxEditableChoiceLabel doesn't take any ChoiceRenderer passed in the constructor into account when creating the Label. I believe it defaults to the toString() of the modelObject, which isn't exactly optimal. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1590) AjaxEditableChoiceLabel ignores ChoiceRenderer in newLabel(...)
[ https://issues.apache.org/jira/browse/WICKET-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Keul updated WICKET-1590: --- Attachment: patch-1.3.x.txt patch.txt Patch.txt should work on the 1.4 version of wicket, however I don't use it yet and as such haven't tested it. Patch-1.3.x.txt is more or less the same as I'm doing as a workaround, so it should be functional. AjaxEditableChoiceLabel ignores ChoiceRenderer in newLabel(...) --- Key: WICKET-1590 URL: https://issues.apache.org/jira/browse/WICKET-1590 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.3.3, 1.4-M1 Reporter: Alexander Keul Priority: Minor Fix For: 1.3.3, 1.4-M1 Attachments: patch-1.3.x.txt, patch.txt AjaxEditableChoiceLabel doesn't take any ChoiceRenderer passed in the constructor into account when creating the Label. I believe it defaults to the toString() of the modelObject, which isn't exactly optimal. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1591) let BrowserInfoPage be customizable / extendable
let BrowserInfoPage be customizable / extendable Key: WICKET-1591 URL: https://issues.apache.org/jira/browse/WICKET-1591 Project: Wicket Issue Type: Improvement Components: wicket Reporter: Peter Ertl When using IRequestCycleSettings.setGatherExtendedBrowserInfo(true) wicket will display a intermediate page with the following text: If you see this, it means that both javascript and meta-refresh are not support by your browser configuration. Please click a wicket:id=link href=#this link/a to continue to the original destination. Especially when the browser starts up java (slw!) this screen will be visible for a few seconds. It would be nice if you could customize this screen as it is very irritating to non-english speakers. Maybe something like IRequestCycleSettings.setGatherExtendedBrowserInfoPage(MyBrowserInfoPage.class) would be good public class MyBrowserInfoPage extends BrowserInfoPage Also wicket users could extend the browser test by more checks. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1591) let BrowserInfoPage be customizable / extendable
[ https://issues.apache.org/jira/browse/WICKET-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johan Compagner updated WICKET-1591: Affects Version/s: 1.3.3 Fix Version/s: 1.5-M1 Assignee: Eelco Hillenius the browser starts up java? i dont think we test for java in our stuff. But i also have already subclasses this and do it in my own page that just says loading.. let BrowserInfoPage be customizable / extendable Key: WICKET-1591 URL: https://issues.apache.org/jira/browse/WICKET-1591 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.3.3 Reporter: Peter Ertl Assignee: Eelco Hillenius Fix For: 1.5-M1 When using IRequestCycleSettings.setGatherExtendedBrowserInfo(true) wicket will display a intermediate page with the following text: If you see this, it means that both javascript and meta-refresh are not support by your browser configuration. Please click a wicket:id=link href=#this link/a to continue to the original destination. Especially when the browser starts up java (slw!) this screen will be visible for a few seconds. It would be nice if you could customize this screen as it is very irritating to non-english speakers. Maybe something like IRequestCycleSettings.setGatherExtendedBrowserInfoPage(MyBrowserInfoPage.class) would be good public class MyBrowserInfoPage extends BrowserInfoPage Also wicket users could extend the browser test by more checks. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1591) let BrowserInfoPage be customizable / extendable
[ https://issues.apache.org/jira/browse/WICKET-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12594567#action_12594567 ] Peter Ertl commented on WICKET-1591: Ah, damn, you are right... I have a browser capabilities page that loads up an test-applet. However, this page is preceded by the BrowserInfoPage from wicket to gather the client properties. As long as the applet is not initialized the user will see the BrowserInfoPage. So no, there's no java check in wicket :-) How do you integrate your own loading page into wicket? I have seen that in WebRequestCycle.newClientInfo(), line 262 in current trunk, there's a throw new RestartResponseException(new BrowserInfoPage(url)) So what I suggest is making the invoked page a configurable parameter, for example through: IRequestCycleSettings.setGatherExtendedBrowserInfoPage(MyBrowserInfoPage.class) let BrowserInfoPage be customizable / extendable Key: WICKET-1591 URL: https://issues.apache.org/jira/browse/WICKET-1591 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.3.3 Reporter: Peter Ertl Assignee: Eelco Hillenius Fix For: 1.5-M1 When using IRequestCycleSettings.setGatherExtendedBrowserInfo(true) wicket will display a intermediate page with the following text: If you see this, it means that both javascript and meta-refresh are not support by your browser configuration. Please click a wicket:id=link href=#this link/a to continue to the original destination. Especially when the browser starts up java (slw!) this screen will be visible for a few seconds. It would be nice if you could customize this screen as it is very irritating to non-english speakers. Maybe something like IRequestCycleSettings.setGatherExtendedBrowserInfoPage(MyBrowserInfoPage.class) would be good public class MyBrowserInfoPage extends BrowserInfoPage Also wicket users could extend the browser test by more checks. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build Wicket Stuff::Wicket Stuff Parent #2 failed (could not get project sources)
Build Wicket Stuff::Wicket Stuff Parent #2 failed (could not get project sources) Agent: Default agent Build results: http://wicketstuff.org/teamcity/viewLog.html?buildId=96buildTypeId=bt6 Changes included (1 change) Change 3860 by donohoe (1 file): include src/tst/resources in build see more information about changed files: http://wicketstuff.org/teamcity/viewLog.html?tab=buildChangesDivbuildId=96buildTypeId=bt6 Configure email notifications: http://wicketstuff.org/teamcity/profile.html?init=1#notifications
Build Wicket Stuff::Wicket Stuff Parent #3 successful
Build Wicket Stuff::Wicket Stuff Parent #3 successful Build results: http://wicketstuff.org/teamcity/viewLog.html?buildId=97buildTypeId=bt6 Configure email notifications: http://wicketstuff.org/teamcity/profile.html?init=1#notifications
[jira] Created: (WICKET-1593) Inability to refresh a webmarkup container containg a datatable with as column an ajaxeditablelabel
Inability to refresh a webmarkup container containg a datatable with as column an ajaxeditablelabel --- Key: WICKET-1593 URL: https://issues.apache.org/jira/browse/WICKET-1593 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.3 Environment: Same behaviour on windows XP macosx 10.5 Reporter: Eric Gulatee Getting a dreaded IllegalStateException when trying to add to webmarkupcontainer. java.lang.IllegalStateException: No Page found for component [MarkupContainer [Component id = cell, page = No Page, path = 1:cells:5:cell.QuantityLabel]] Attached is the html + page + component to recreate the issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1593) Inability to refresh a webmarkup container containg a datatable with as column an ajaxeditablelabel
[ https://issues.apache.org/jira/browse/WICKET-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Gulatee updated WICKET-1593: - Attachment: TestAjaxDataTable.java Inability to refresh a webmarkup container containg a datatable with as column an ajaxeditablelabel --- Key: WICKET-1593 URL: https://issues.apache.org/jira/browse/WICKET-1593 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.3 Environment: Same behaviour on windows XP macosx 10.5 Reporter: Eric Gulatee Attachments: TestAjaxDataTable.html, TestAjaxDataTable.java Getting a dreaded IllegalStateException when trying to add to webmarkupcontainer. java.lang.IllegalStateException: No Page found for component [MarkupContainer [Component id = cell, page = No Page, path = 1:cells:5:cell.QuantityLabel]] Attached is the html + page + component to recreate the issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1593) llegalStateException when refreshing a WebMarkupContainer containing a AjaxFallbackDefaultDataTable with one of the columns is a AjaxEditableLabel which refreshes the mar
[ https://issues.apache.org/jira/browse/WICKET-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Gulatee updated WICKET-1593: - Description: llegalStateException when refreshing a WebMarkupContainer containing a AjaxFallbackDefaultDataTable where one of the columns is a AjaxEditableLabel which refreshes the markup container on submit java.lang.IllegalStateException: No Page found for component [MarkupContainer [Component id = cell, page = No Page, path = 1:cells:5:cell.QuantityLabel]] Attached is the html + page + component to recreate the issue. was: Getting a dreaded IllegalStateException when trying to add to webmarkupcontainer. java.lang.IllegalStateException: No Page found for component [MarkupContainer [Component id = cell, page = No Page, path = 1:cells:5:cell.QuantityLabel]] Attached is the html + page + component to recreate the issue. Summary: llegalStateException when refreshing a WebMarkupContainer containing a AjaxFallbackDefaultDataTable with one of the columns is a AjaxEditableLabel which refreshes the markup container on submit (was: Inability to refresh a webmarkup container containg a datatable with as column an ajaxeditablelabel) llegalStateException when refreshing a WebMarkupContainer containing a AjaxFallbackDefaultDataTable with one of the columns is a AjaxEditableLabel which refreshes the markup container on submit - Key: WICKET-1593 URL: https://issues.apache.org/jira/browse/WICKET-1593 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.3 Environment: Same behaviour on windows XP macosx 10.5 Reporter: Eric Gulatee Attachments: TestAjaxDataTable.html, TestAjaxDataTable.java llegalStateException when refreshing a WebMarkupContainer containing a AjaxFallbackDefaultDataTable where one of the columns is a AjaxEditableLabel which refreshes the markup container on submit java.lang.IllegalStateException: No Page found for component [MarkupContainer [Component id = cell, page = No Page, path = 1:cells:5:cell.QuantityLabel]] Attached is the html + page + component to recreate the issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1593) llegalStateException when refreshing a WebMarkupContainer containing a AjaxFallbackDefaultDataTable with one of the columns is a AjaxEditableLabel which refreshes the mar
[ https://issues.apache.org/jira/browse/WICKET-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Gulatee updated WICKET-1593: - Description: llegalStateException when refreshing a WebMarkupContainer containing a AjaxFallbackDefaultDataTable where one of the columns is a AjaxEditableLabel which refreshes the markup container on submit Attached is the html + page + component to recreate the issue. Stack Trace as follows: java.lang.IllegalStateException: No Page found for component [MarkupContainer [Component id = cell, page = No Page, path = 1:cells:5:cell.QuantityLabel]] at org.apache.wicket.Component.getPage(Component.java:1658) at org.apache.wicket.ajax.AjaxRequestTarget.respondComponent(AjaxRequestTarget.java:689) at org.apache.wicket.ajax.AjaxRequestTarget.respondComponents(AjaxRequestTarget.java:605) at org.apache.wicket.ajax.AjaxRequestTarget.respond(AjaxRequestTarget.java:520) at org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:104) at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1172) at org.apache.wicket.RequestCycle.step(RequestCycle.java:1243) at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1331) at org.apache.wicket.RequestCycle.request(RequestCycle.java:493) at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:363) at org.apache.wicket.protocol.http.WicketServlet.doGet(WicketServlet.java:124) at javax.servlet.http.HttpServlet.service(HttpServlet.java:690) was: llegalStateException when refreshing a WebMarkupContainer containing a AjaxFallbackDefaultDataTable where one of the columns is a AjaxEditableLabel which refreshes the markup container on submit java.lang.IllegalStateException: No Page found for component [MarkupContainer [Component id = cell, page = No Page, path = 1:cells:5:cell.QuantityLabel]] Attached is the html + page + component to recreate the issue. Edit the telehpone column to procedure the stack trace llegalStateException when refreshing a WebMarkupContainer containing a AjaxFallbackDefaultDataTable with one of the columns is a AjaxEditableLabel which refreshes the markup container on submit - Key: WICKET-1593 URL: https://issues.apache.org/jira/browse/WICKET-1593 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.3 Environment: Same behaviour on windows XP macosx 10.5 Reporter: Eric Gulatee Attachments: TestAjaxDataTable.html, TestAjaxDataTable.java llegalStateException when refreshing a WebMarkupContainer containing a AjaxFallbackDefaultDataTable where one of the columns is a AjaxEditableLabel which refreshes the markup container on submit Attached is the html + page + component to recreate the issue. Stack Trace as follows: java.lang.IllegalStateException: No Page found for component [MarkupContainer [Component id = cell, page = No Page, path = 1:cells:5:cell.QuantityLabel]] at org.apache.wicket.Component.getPage(Component.java:1658) at org.apache.wicket.ajax.AjaxRequestTarget.respondComponent(AjaxRequestTarget.java:689) at org.apache.wicket.ajax.AjaxRequestTarget.respondComponents(AjaxRequestTarget.java:605) at org.apache.wicket.ajax.AjaxRequestTarget.respond(AjaxRequestTarget.java:520) at org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:104) at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1172) at org.apache.wicket.RequestCycle.step(RequestCycle.java:1243) at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1331) at org.apache.wicket.RequestCycle.request(RequestCycle.java:493) at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:363) at org.apache.wicket.protocol.http.WicketServlet.doGet(WicketServlet.java:124) at javax.servlet.http.HttpServlet.service(HttpServlet.java:690) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1591) let BrowserInfoPage be customizable / extendable
[
https://issues.apache.org/jira/browse/WICKET-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12594584#action_12594584
]
Johan Compagner commented on WICKET-1591:
-
protected ClientInfo newClientInfo()
{
// We will always do a redirect here. The
servoy browser info has to make one.
WebClientInfo webClientInfo = new
WebClientInfo(this);
ClientProperties cp =
webClientInfo.getProperties();
if (cp.isBrowserInternetExplorer() ||
cp.isBrowserMozilla() || cp.isBrowserKonqueror() || cp.isBrowserOpera() ||
cp.isBrowserSafari())
{
Page page = getResponsePage();
if (page != null)
{
throw new
RestartResponseAtInterceptPageException(new
ServoyBrowserInfoPage(urlFor(page).toString().replaceAll(../, )));
}
else
{
throw new
RestartResponseAtInterceptPageException(new
ServoyBrowserInfoPage(getRequest().getRelativePathPrefixToContextRoot() +
getRequest().getURL()));
}
}
return webClientInfo;
}
let BrowserInfoPage be customizable / extendable
Key: WICKET-1591
URL: https://issues.apache.org/jira/browse/WICKET-1591
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.3
Reporter: Peter Ertl
Assignee: Eelco Hillenius
Fix For: 1.5-M1
When using
IRequestCycleSettings.setGatherExtendedBrowserInfo(true)
wicket will display a intermediate page with the following text:
If you see this, it means that both javascript and meta-refresh are not
support by your browser configuration.
Please click a wicket:id=link href=#this link/a to continue to the
original destination.
Especially when the browser starts up java (slw!) this screen will be
visible for a few seconds. It would be nice if you could customize this
screen as it is very irritating to non-english speakers.
Maybe something like
IRequestCycleSettings.setGatherExtendedBrowserInfoPage(MyBrowserInfoPage.class)
would be good
public class MyBrowserInfoPage extends BrowserInfoPage
Also wicket users could extend the browser test by more checks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
[ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Sauyet updated WICKET-1205: - Attachment: OldUrlFilter.java A possible work-around for those who need the index.jsp URL but not the file. Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat. -- Key: WICKET-1205 URL: https://issues.apache.org/jira/browse/WICKET-1205 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-rc1 Environment: JBoss 4.2 / Tomcat Embedded Reporter: Jeremy Levy Assignee: Alastair Maw Fix For: 1.3.4 Attachments: CSSIssueQuickStart.tar.gz, OldUrlFilter.java, WICKET-1205.zip When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-1205) Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat.
[ https://issues.apache.org/jira/browse/WICKET-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12594590#action_12594590 ] scott_sauyet edited comment on WICKET-1205 at 5/6/08 7:09 AM: -- One possible work-around for those like me who need the URL that includes index.jsp but not the actual file, is to add a servlet filter which simply redirects to the main application. A more involved version of the attached OldUrlFilter.java allows old bookmarks to easily map to newer version. There is more discussion of this at http://tinyurl.com/3gcbsa was (Author: scott_sauyet): A possible work-around for those who need the index.jsp URL but not the file. Relative path calculations for inline paths in non-bookmarkable pages are incorrect on Tomcat. -- Key: WICKET-1205 URL: https://issues.apache.org/jira/browse/WICKET-1205 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-rc1 Environment: JBoss 4.2 / Tomcat Embedded Reporter: Jeremy Levy Assignee: Alastair Maw Fix For: 1.3.4 Attachments: CSSIssueQuickStart.tar.gz, OldUrlFilter.java, WICKET-1205.zip When linking from a bookmarked page to a non-bookmarked page the relative link to the CSS page breaks. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r653783 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/documentvalidation: HtmlDocumentParser.java HtmlDocumentValidator.java Tag.java
Author: gseitz
Date: Tue May 6 07:13:32 2008
New Revision: 653783
URL: http://svn.apache.org/viewvc?rev=653783view=rev
Log:
generics
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/documentvalidation/HtmlDocumentParser.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/documentvalidation/HtmlDocumentValidator.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/documentvalidation/Tag.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/documentvalidation/HtmlDocumentParser.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/documentvalidation/HtmlDocumentParser.java?rev=653783r1=653782r2=653783view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/documentvalidation/HtmlDocumentParser.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/documentvalidation/HtmlDocumentParser.java
Tue May 6 07:13:32 2008
@@ -55,7 +55,7 @@
/** constant for unknown token. */
public static final int UNKNOWN = -1;
- private Map attributes;
+ private MapString, String attributes;
/** Extracted content */
private String comment;
@@ -88,7 +88,7 @@
*
* @return The attributes
*/
- public Map getAttributes()
+ public MapString, String getAttributes()
{
return attributes;
}
@@ -154,9 +154,9 @@
*The string
* @return The map of attributes
*/
- private Map extractAttributes(String attributeString)
+ private MapString, String extractAttributes(String attributeString)
{
- Map m = new HashMap();
+ MapString, String m = new HashMapString, String();
attributeString = Strings.replaceAll(attributeString.trim(),
\t, ).toString();
attributeString = Strings.replaceAll(attributeString, = ,
=).toString();
String[] attributeElements = attributeString.split( );
@@ -223,7 +223,7 @@
{
// No attributes
tag = part.substring(1,
part.indexOf(/)).toLowerCase();
- attributes = new HashMap();
+ attributes = new HashMapString, String();
}
else
{
@@ -242,7 +242,7 @@
{
// No attributes
tag = part.substring(1,
part.indexOf('')).toLowerCase();
- attributes = new HashMap();
+ attributes = new HashMapString, String();
}
else
{
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/documentvalidation/HtmlDocumentValidator.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/documentvalidation/HtmlDocumentValidator.java?rev=653783r1=653782r2=653783view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/documentvalidation/HtmlDocumentValidator.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/documentvalidation/HtmlDocumentValidator.java
Tue May 6 07:13:32 2008
@@ -39,7 +39,7 @@
{
private static final Logger log =
LoggerFactory.getLogger(HtmlDocumentValidator.class);
- private final List elements = new ArrayList();
+ private final ListDocumentElement elements = new
ArrayListDocumentElement();
private boolean skipComments = true;
@@ -75,9 +75,9 @@
public boolean isDocumentValid(final String document)
{
HtmlDocumentParser parser = new HtmlDocumentParser(document);
- Iterator expectedElements = elements.iterator();
- ArrayListStack iteratorStack = new ArrayListStack();
- ArrayListStack tagNameStack = new ArrayListStack();
+ IteratorDocumentElement expectedElements =
elements.iterator();
+ ArrayListStackIteratorDocumentElement iteratorStack = new
ArrayListStackIteratorDocumentElement();
+ ArrayListStackString tagNameStack = new
ArrayListStackString();
boolean end = false;
boolean valid = true;
@@ -108,7 +108,7 @@
else
{
expectedElements =
saveOpenTagState(iteratorStack, expectedElements,
-
Build Wicket Stuff::Wicket Stuff Picnik #7 successful (tests passed: 1)
Build Wicket Stuff::Wicket Stuff Picnik #7 successful (tests passed: 1) Build results: http://wicketstuff.org/teamcity/viewLog.html?buildId=103buildTypeId=bt9 Changes included (1 change) Change 3862 by mindhaq (2 files): Merge from branch; increased version for trunk see more information about changed files: http://wicketstuff.org/teamcity/viewLog.html?tab=buildChangesDivbuildId=103buildTypeId=bt9 Configure email notifications: http://wicketstuff.org/teamcity/profile.html?init=1#notifications
svn commit: r653874 - in /wicket/trunk: wicket-examples/src/main/java/org/apache/wicket/examples/forminput/ wicket/src/main/java/org/apache/wicket/util/convert/
Author: gseitz
Date: Tue May 6 11:30:24 2008
New Revision: 653874
URL: http://svn.apache.org/viewvc?rev=653874view=rev
Log:
generics
Modified:
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInputApplication.java
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInputModel.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/convert/ConversionException.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/convert/MaskConverter.java
Modified:
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java?rev=653874r1=653873r2=653874view=diff
==
---
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java
(original)
+++
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java
Tue May 6 11:30:24 2008
@@ -78,7 +78,7 @@
add(new LocaleDropDownChoice(localeSelect));
// Link to return to default locale
- add(new Link(defaultLocaleLink)
+ add(new LinkVoid(defaultLocaleLink)
{
@Override
public void onClick()
@@ -102,54 +102,54 @@
add(new CheckBox(booleanProperty));
add(new Multiply(multiply));
// display the multiply result
- Label multiplyLabel = new Label(multiplyLabel, new
PropertyModel(getModel(),
- multiply));
+ LabelInteger multiplyLabel = new
LabelInteger(multiplyLabel,
+ new PropertyModelInteger(getModel(),
multiply));
// just for fun, add a border so that our result will
be displayed
// as '[ x ]'
multiplyLabel.setComponentBorder(new
BeforeAndAfterBorder());
add(multiplyLabel);
- RadioChoice rc = new RadioChoice(numberRadioChoice,
NUMBERS).setSuffix();
- rc.setLabel(new Model(number));
+ RadioChoiceString rc = new
RadioChoiceString(numberRadioChoice, NUMBERS).setSuffix();
+ rc.setLabel(new ModelString(number));
rc.setRequired(true);
add(rc);
- RadioGroup group = new RadioGroup(numbersGroup);
+ RadioGroupString group = new
RadioGroupString(numbersGroup);
add(group);
- ListView persons = new ListView(numbers, NUMBERS)
+ ListViewString persons = new
ListViewString(numbers, NUMBERS)
{
@Override
- protected void populateItem(ListItem item)
+ protected void populateItem(ListItemString
item)
{
- item.add(new Radio(radio,
item.getModel()));
- item.add(new Label(number,
item.getModelObjectAsString()));
+ item.add(new RadioString(radio,
item.getModel()));
+ item.add(new LabelString(number,
item.getModelObjectAsString()));
};
}.setReuseItems(true);
group.add(persons);
- CheckGroup checks = new CheckGroup(numbersCheckGroup);
+ CheckGroupString checks = new
CheckGroupString(numbersCheckGroup);
add(checks);
- ListView checksList = new ListView(numbers, NUMBERS)
+ ListViewString checksList = new
ListViewString(numbers, NUMBERS)
{
@Override
- protected void populateItem(ListItem item)
+ protected void populateItem(ListItemString
item)
{
- item.add(new Check(check,
item.getModel()));
- item.add(new Label(number,
item.getModelObjectAsString()));
+ item.add(new CheckString(check,
item.getModel()));
+ item.add(new LabelString(number,
item.getModelObjectAsString()));
};
svn commit: r653890 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file: Folder.java IResourceFinder.java Path.java WebApplicationPath.java
Author: gseitz
Date: Tue May 6 12:37:56 2008
New Revision: 653890
URL: http://svn.apache.org/viewvc?rev=653890view=rev
Log:
generics
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/Folder.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/IResourceFinder.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/Path.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/WebApplicationPath.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/Folder.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/Folder.java?rev=653890r1=653889r2=653890view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/Folder.java
(original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/Folder.java
Tue May 6 12:37:56 2008
@@ -172,14 +172,14 @@
*/
public File[] getNestedFiles(final FileFilter filter)
{
- final List files = new ArrayList();
+ final ListFile files = new ArrayListFile();
files.addAll(Arrays.asList(getFiles(filter)));
final Folder[] folders = getFolders();
for (int i = 0; i folders.length; i++)
{
files.addAll(Arrays.asList(folders[i].getNestedFiles(filter)));
}
- return (File[])files.toArray(new File[files.size()]);
+ return files.toArray(new File[files.size()]);
}
/**
@@ -269,6 +269,7 @@
*
* @return True if the folder was successfully removed
*/
+ @Override
public boolean remove()
{
return remove(this);
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/IResourceFinder.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/IResourceFinder.java?rev=653890r1=653889r2=653890view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/IResourceFinder.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/IResourceFinder.java
Tue May 6 12:37:56 2008
@@ -34,5 +34,5 @@
*The filename with possible path
* @return The resource stream
*/
- IResourceStream find(final Class clazz, final String pathname);
+ IResourceStream find(final Class ? clazz, final String pathname);
}
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/Path.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/Path.java?rev=653890r1=653889r2=653890view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/Path.java
(original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/Path.java Tue
May 6 12:37:56 2008
@@ -32,7 +32,7 @@
public final class Path implements IResourcePath
{
/** The list of folders in the path */
- private final List folders = new ArrayList();
+ private final ListFolder folders = new ArrayListFolder();
/**
* Constructor
@@ -97,11 +97,11 @@
*
* @see org.apache.wicket.util.file.IResourceFinder#find(Class, String)
*/
- public IResourceStream find(final Class clazz, final String pathname)
+ public IResourceStream find(final Class ? clazz, final String
pathname)
{
for (int i = 0; i folders.size(); i++)
{
- Folder folder = (Folder)folders.get(i);
+ Folder folder = folders.get(i);
final File file = new File(folder, pathname);
if (file.exists())
@@ -116,7 +116,7 @@
/**
* @return Returns the folders.
*/
- public List getFolders()
+ public ListFolder getFolders()
{
return folders;
}
@@ -132,6 +132,7 @@
/**
* @see java.lang.Object#toString()
*/
+ @Override
public String toString()
{
return [folders = + StringList.valueOf(folders) + ];
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/WebApplicationPath.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/WebApplicationPath.java?rev=653890r1=653889r2=653890view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/file/WebApplicationPath.java
(original)
+++
svn commit: r653902 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket/util: license/ listener/ parse/metapattern/ parse/metapattern/parsers/ resource/ resource/locator/
Author: gseitz
Date: Tue May 6 13:14:50 2008
New Revision: 653902
URL: http://svn.apache.org/viewvc?rev=653902view=rev
Log:
generics
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/license/ApacheLicenseHeaderTestCase.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/listener/ListenerSet.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/parse/metapattern/MetaPattern.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/parse/metapattern/OptionalMetaPattern.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/parse/metapattern/parsers/ListParser.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/PackageResourceStream.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/XSLTResourceStream.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/locator/ExtensionResourceNameIterator.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/locator/IResourceStreamLocator.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/locator/LocaleResourceNameIterator.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/locator/OsgiResourceStreamLocator.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/locator/ResourceNameIterator.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/locator/ResourceStreamLocator.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/locator/StyleAndVariationResourceNameIterator.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/license/ApacheLicenseHeaderTestCase.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/license/ApacheLicenseHeaderTestCase.java?rev=653902r1=653901r2=653902view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/license/ApacheLicenseHeaderTestCase.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/license/ApacheLicenseHeaderTestCase.java
Tue May 6 13:14:50 2008
@@ -20,9 +20,9 @@
import java.io.FileFilter;
import java.util.ArrayList;
import java.util.HashMap;
-import java.util.Iterator;
import java.util.List;
import java.util.Map;
+import java.util.Map.Entry;
import junit.framework.TestCase;
@@ -94,15 +94,15 @@
{
String relativePathname =
pathname.getAbsolutePath();
relativePathname =
Strings.replaceAll(relativePathname,
- baseDirectory.getAbsolutePath()
+ System.getProperty(file.separator), )
- .toString();
+ baseDirectory.getAbsolutePath() +
System.getProperty(file.separator), )
+ .toString();
for (int i = 0; i ignoreFiles.length; i++)
{
String ignorePath = ignoreFiles[i];
// Will convert '/'s to '\\'s on Windows
ignorePath =
Strings.replaceAll(ignorePath, /,
-
System.getProperty(file.separator)).toString();
+
System.getProperty(file.separator)).toString();
File ignoreFile = new
File(baseDirectory, ignorePath);
// Directory ignore
@@ -143,8 +143,8 @@
{
String relativePathname =
pathname.getAbsolutePath();
relativePathname =
Strings.replaceAll(relativePathname,
- baseDirectory.getAbsolutePath()
+ System.getProperty(file.separator), )
- .toString();
+ baseDirectory.getAbsolutePath() +
System.getProperty(file.separator), )
+ .toString();
if (relativePathname.equals(target) == false)
{
boolean found = false;
@@ -193,6 +193,7 @@
*
* @see junit.framework.TestCase#setUp()
*/
+ @Override
public final void setUp()
{
// setup the base directory for when running inside maven
(building a release
@@ -217,56 +218,50 @@
new CssLicenseHeaderHandler(cssIgnore), new
HtmlLicenseHeaderHandler(htmlIgnore),
new
VelocityLicenseHeaderHandler(velocityIgnore) };
- final Map/*
svn commit: r653947 - in /wicket/trunk/wicket-extensions/src: main/java/org/apache/wicket/extensions/wizard/ main/java/org/apache/wicket/extensions/wizard/dynamic/ test/java/org/apache/wicket/extensio
Author: gseitz
Date: Tue May 6 15:53:26 2008
New Revision: 653947
URL: http://svn.apache.org/viewvc?rev=653947view=rev
Log:
generics
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/AbstractWizardModel.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardModel.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardStep.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/StaticContentStep.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/Wizard.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardButton.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardButtonBar.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardModel.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardStep.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/dynamic/DynamicWizardModel.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/dynamic/DynamicWizardStep.java
wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabelPage.java
wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableTest.java
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/AbstractWizardModel.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/AbstractWizardModel.java?rev=653947r1=653946r2=653947view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/AbstractWizardModel.java
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/AbstractWizardModel.java
Tue May 6 15:53:26 2008
@@ -17,7 +17,6 @@
package org.apache.wicket.extensions.wizard;
import java.util.ArrayList;
-import java.util.Iterator;
import java.util.List;
/**
@@ -43,7 +42,8 @@
private boolean lastVisible = false;
/** Listeners for [EMAIL PROTECTED] IWizardModelListener model events}.
*/
- private final List wizardModelListeners = new ArrayList(1);
+ private final ListIWizardModelListener wizardModelListeners = new
ArrayListIWizardModelListener(
+ 1);
/**
* Construct.
@@ -149,9 +149,8 @@
*/
protected final void fireActiveStepChanged(IWizardStep step)
{
- for (Iterator i = wizardModelListeners.iterator(); i.hasNext();)
+ for (IWizardModelListener listener : wizardModelListeners)
{
- IWizardModelListener listener =
(IWizardModelListener)i.next();
listener.onActiveStepChanged(step);
}
}
@@ -161,9 +160,8 @@
*/
protected final void fireWizardCancelled()
{
- for (Iterator i = wizardModelListeners.iterator(); i.hasNext();)
+ for (IWizardModelListener listener : wizardModelListeners)
{
- IWizardModelListener listener =
(IWizardModelListener)i.next();
listener.onCancel();
}
}
@@ -173,9 +171,8 @@
*/
protected final void fireWizardFinished()
{
- for (Iterator i = wizardModelListeners.iterator(); i.hasNext();)
+ for (IWizardModelListener listener : wizardModelListeners)
{
- IWizardModelListener listener =
(IWizardModelListener)i.next();
listener.onFinish();
}
}
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardModel.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardModel.java?rev=653947r1=653946r2=653947view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardModel.java
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardModel.java
Tue May 6 15:53:26 2008
@@ -172,5 +172,5 @@
*
* @return an iterator over all the steps of the model or null if the
wizard model is not static
*/
- Iterator stepIterator();
+ IteratorIWizardStep stepIterator();
}
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardStep.java
[jira] Updated: (WICKET-1507) MarkupCache style/variation/locale support broken
[ https://issues.apache.org/jira/browse/WICKET-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Thomerson updated WICKET-1507: - Attachment: WICKET-1507-testcase.patch I tried writing a test case that would reproduce this so that I could work on a fix. I could not reproduce with this test case, which I think covers the described situation. I am testing on TRUNK, which is currently 1.4-SNAPSHOT, and the issue was reported with 1.3.2, so it might have been fixed between now and then. Attached patch is the test case I wrote. MarkupCache style/variation/locale support broken - Key: WICKET-1507 URL: https://issues.apache.org/jira/browse/WICKET-1507 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.2 Reporter: Meetesh Karia Priority: Critical Attachments: WICKET-1507-testcase.patch We're running into a problem with the change made for this issue: WICKET-1370 Basically, if you have a situation like this where the Login page extends DefaultPage and uses wicket:extend: Login.html DefaultPage.html DefaultPage_style1.html DefaultPage_style2.html The markup for DefaultPage will always be based on the first style the site is hit with. This is because the location string (Login.html) hasn't changed with the style change. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
