[jira] Updated: (WICKET-1658) WicketTester#clickLink doesn't update lastRenderedPage

2008-05-25 Thread Marat Radchenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marat Radchenko updated WICKET-1658:


Attachment: wicket-1658.tar.gz

Please find attached testcase.

> WicketTester#clickLink doesn't update lastRenderedPage
> --
>
> Key: WICKET-1658
> URL: https://issues.apache.org/jira/browse/WICKET-1658
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-M1
>Reporter: Marat Radchenko
>Assignee: Frank Bille Jensen
> Attachments: wicket-1658.tar.gz
>
>
> If clickLink is used on a link that calls setResponsePage then that page 
> doesn't appear in WicketTester's lastRenderedPage.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r660094 - in /wicket/trunk: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/ wicket/src/main/java/org/apache/wicket/ wicket/src/main/java/org/apache/wicket/ma

2008-05-25 Thread ivaynberg
Author: ivaynberg
Date: Sun May 25 20:18:23 2008
New Revision: 660094

URL: http://svn.apache.org/viewvc?rev=660094&view=rev
Log:
generics cleanup

Modified:

wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabel.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/Request.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractTextComponent.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Check.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/link/IPageLink.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/list/ListView.java

Modified: 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabel.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabel.java?rev=660094&r1=660093&r2=660094&view=diff
==
--- 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabel.java
 (original)
+++ 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabel.java
 Sun May 25 20:18:23 2008
@@ -226,7 +226,7 @@
 * @param labelModel
 * @return this for chaining
 */
-   public final AjaxEditableLabel setLabel(final IModel labelModel)
+   public final AjaxEditableLabel setLabel(final IModel 
labelModel)
{
getEditor().setLabel(labelModel);
return this;

Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Request.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Request.java?rev=660094&r1=660093&r2=660094&view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Request.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Request.java Sun May 25 
20:18:23 2008
@@ -36,7 +36,7 @@
 public abstract class Request
 {
/** Any Page decoded for this request */
-   private Page< ? > page;
+   private Page page;
 
/** the type safe request parameters object for this request. */
private RequestParameters requestParameters;
@@ -69,7 +69,7 @@
/**
 * @return Any Page for this request
 */
-   public Page< ? > getPage()
+   public Page getPage()
{
return page;
}
@@ -201,7 +201,7 @@
 * @param page
 *The Page for this request
 */
-   public void setPage(final Page page)
+   public void setPage(final Page page)
{
this.page = page;
}

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractTextComponent.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractTextComponent.java?rev=660094&r1=660093&r2=660094&view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractTextComponent.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/AbstractTextComponent.java
 Sun May 25 20:18:23 2008
@@ -77,7 +77,7 @@
/**
 * @see org.apache.wicket.Component#Component(String, IModel)
 */
-   public AbstractTextComponent(final String id, final IModel model)
+   public AbstractTextComponent(final String id, final IModel model)
{
super(id, model);
setConvertEmptyInputStringToNull(true);

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Check.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Check.java?rev=660094&r1=660093&r2=660094&view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Check.java 
(original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Check.java 
Sun May 25 20:18:23 2008
@@ -100,7 +100,8 @@
checkComponentTag(tag, "input");
checkComponentTagAttribute(tag, "type", "checkbox");
 
-   CheckGroup group = findParent(CheckGroup.class);
+ 

svn commit: r660092 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/ComponentSourceEntry.java

2008-05-25 Thread ivaynberg
Author: ivaynberg
Date: Sun May 25 19:46:29 2008
New Revision: 660092

URL: http://svn.apache.org/viewvc?rev=660092&view=rev
Log:
warnings fixes

Modified:

wicket/trunk/wicket/src/main/java/org/apache/wicket/ComponentSourceEntry.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/ComponentSourceEntry.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/ComponentSourceEntry.java?rev=660092&r1=660091&r2=660092&view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/ComponentSourceEntry.java 
(original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/ComponentSourceEntry.java 
Sun May 25 19:46:29 2008
@@ -201,7 +201,7 @@
 * @param parent
 * @param info
 * @param component
-* @return
+* @return component if it is a markup container, null 
otherwise
 */
private static MarkupContainer applyComponentInfo(MarkupContainer 
parent, String info,
Component component)
@@ -271,7 +271,7 @@
 *component itself) during reconstruction
 * @param parent
 * @param info
-* @return
+* @return length of component info
 */
private static int parseComponentInfo(MarkupContainer parent, String 
info,
Component component)




[jira] Resolved: (WICKET-1615) Complete and commit the completed form.

2008-05-25 Thread Martijn Dashorst (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martijn Dashorst resolved WICKET-1615.
--

Resolution: Fixed

> Complete and commit the completed form.
> ---
>
> Key: WICKET-1615
> URL: https://issues.apache.org/jira/browse/WICKET-1615
> Project: Wicket
>  Issue Type: Sub-task
>Reporter: Martijn Dashorst
>Assignee: Martijn Dashorst
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (WICKET-1616) Post a message to [EMAIL PROTECTED] prefixed [IP CLEARANCE] asking for clearance to be checked

2008-05-25 Thread Martijn Dashorst (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martijn Dashorst resolved WICKET-1616.
--

Resolution: Fixed

> Post a message to [EMAIL PROTECTED] prefixed [IP CLEARANCE] asking for 
> clearance to be checked
> --
>
> Key: WICKET-1616
> URL: https://issues.apache.org/jira/browse/WICKET-1616
> Project: Wicket
>  Issue Type: Sub-task
>Reporter: Martijn Dashorst
>Assignee: Martijn Dashorst
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r660041 - in /wicket/trunk: testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/apps/app1/ wicket-examples/src/main/java/org/apache/wicket/examples/forminput/ wicket-exten

2008-05-25 Thread ivaynberg
Author: ivaynberg
Date: Sun May 25 14:22:37 2008
New Revision: 660041

URL: http://svn.apache.org/viewvc?rev=660041&view=rev
Log:
iconverterlocator cleanup

Modified:

wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/apps/app1/Home.java

wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java

wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableChoiceLabel.java

wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabel.java

wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/IColumn.java
wicket/trunk/wicket-quickstart/jetty-quickstart.launch
wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/IConverterLocator.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/util/convert/ConverterLocator.java

Modified: 
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/apps/app1/Home.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/apps/app1/Home.java?rev=660041&r1=660040&r2=660041&view=diff
==
--- 
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/apps/app1/Home.java
 (original)
+++ 
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/apps/app1/Home.java
 Sun May 25 14:22:37 2008
@@ -174,9 +174,9 @@
private static final long serialVersionUID = 1L;
 
@Override
-   public IConverter getConverter(Class 
clazz)
+   public  IConverter getConverter(Class 
clazz)
{
-   return new IConverter()
+   return (IConverter)new 
IConverter()
{
private static final long 
serialVersionUID = 1L;
 
@@ -213,9 +213,10 @@
private static final long serialVersionUID = 1L;
 
@Override
-   public IConverter 
getConverter(Class clazz)
+   public  IConverter getConverter(Class 
clazz)
{
-   return new 
MaskConverter("(###) ###-", UsPhoneNumber.class);
+   return (IConverter)new 
MaskConverter("(###) ###-",
+   UsPhoneNumber.class);
}
});
 

Modified: 
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java?rev=660041&r1=660040&r2=660041&view=diff
==
--- 
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java
 (original)
+++ 
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/forminput/FormInput.java
 Sun May 25 14:22:37 2008
@@ -144,39 +144,57 @@
// TextField using a custom converter.
add(new TextField("urlProperty", URL.class)
{
+   @SuppressWarnings("unchecked")
@Override
-   public IConverter getConverter(final 
Class type)
+   public  IConverter getConverter(final 
Class type)
{
-   return new IConverter()
+   if (URL.class.isAssignableFrom(type))
{
-   public URL 
convertToObject(String value, Locale locale)
+   return (IConverter)new 
IConverter()
{
-   try
+   public URL 
convertToObject(String value, Locale locale)
{
-   return new 
URL(value.toString());
+   try
+

svn commit: r660036 - in /wicket/common/incoming: kitten-captcha/src/ src/

2008-05-25 Thread dashorst
Author: dashorst
Date: Sun May 25 14:14:39 2008
New Revision: 660036

URL: http://svn.apache.org/viewvc?rev=660036&view=rev
Log:
prutser

Added:
wicket/common/incoming/kitten-captcha/src/
  - copied from r660035, wicket/common/incoming/src/
Removed:
wicket/common/incoming/src/



svn commit: r660035 - in /wicket/common/incoming: kitten-captcha/pom.xml pom.xml

2008-05-25 Thread dashorst
Author: dashorst
Date: Sun May 25 14:14:17 2008
New Revision: 660035

URL: http://svn.apache.org/viewvc?rev=660035&view=rev
Log:
prutser

Added:
wicket/common/incoming/kitten-captcha/pom.xml
  - copied unchanged from r660034, wicket/common/incoming/pom.xml
Removed:
wicket/common/incoming/pom.xml



svn commit: r660034 - /wicket/common/incoming/kitten-captcha/

2008-05-25 Thread dashorst
Author: dashorst
Date: Sun May 25 14:13:29 2008
New Revision: 660034

URL: http://svn.apache.org/viewvc?rev=660034&view=rev
Log:
prutser

Added:
wicket/common/incoming/kitten-captcha/



[jira] Commented: (WICKET-1658) WicketTester#clickLink doesn't update lastRenderedPage

2008-05-25 Thread Frank Bille Jensen (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599718#action_12599718
 ] 

Frank Bille Jensen commented on WICKET-1658:


I can't reproduce with latest trunk. Do you have a unit test that can show 
this? I have pushed two unit tests where I tried to reproduce this behavior. 
(see http://svn.apache.org/viewvc?view=rev&revision=660029)

> WicketTester#clickLink doesn't update lastRenderedPage
> --
>
> Key: WICKET-1658
> URL: https://issues.apache.org/jira/browse/WICKET-1658
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-M1
>Reporter: Marat Radchenko
>Assignee: Frank Bille Jensen
>
> If clickLink is used on a link that calls setResponsePage then that page 
> doesn't appear in WicketTester's lastRenderedPage.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r660029 - in /wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester: WicketTesterTest.java apps_6/ apps_6/LinkPage.html apps_6/LinkPage.java apps_6/ResultPage.html apps_6/ResultP

2008-05-25 Thread frankbille
Author: frankbille
Date: Sun May 25 13:37:49 2008
New Revision: 660029

URL: http://svn.apache.org/viewvc?rev=660029&view=rev
Log:
Added some unit tests to see if I could reproduce WICKET-1658. But I haven't 
been able to so far, but I might as well push the unit tests.

Added:
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/apps_6/

wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/apps_6/LinkPage.html
   (with props)

wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/apps_6/LinkPage.java
   (with props)

wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/apps_6/ResultPage.html
   (with props)

wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/apps_6/ResultPage.java
   (with props)
Modified:

wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java

Modified: 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java?rev=660029&r1=660028&r2=660029&view=diff
==
--- 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java
 (original)
+++ 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/WicketTesterTest.java
 Sun May 25 13:37:49 2008
@@ -41,6 +41,8 @@
 import org.apache.wicket.util.tester.apps_1.MyMockApplication;
 import org.apache.wicket.util.tester.apps_1.SuccessPage;
 import org.apache.wicket.util.tester.apps_1.ViewBook;
+import org.apache.wicket.util.tester.apps_6.LinkPage;
+import org.apache.wicket.util.tester.apps_6.ResultPage;
 
 /**
  * 
@@ -161,6 +163,34 @@
/**
 * @throws Exception
 */
+   public void testClickLink_setResponsePageClass() throws Exception
+   {
+   tester.startPage(LinkPage.class);
+   tester.assertRenderedPage(LinkPage.class);
+
+   // Set the response page class in the link callback
+   tester.clickLink("linkWithSetResponsePageClass");
+   tester.assertRenderedPage(ResultPage.class);
+   tester.assertLabel("label", "No Parameter");
+   }
+
+   /**
+* @throws Exception
+*/
+   public void testClickLink_setResponsePage() throws Exception
+   {
+   tester.startPage(LinkPage.class);
+   tester.assertRenderedPage(LinkPage.class);
+
+   // Set the response page instance in the link callback
+   tester.clickLink("linkWithSetResponsePage");
+   tester.assertRenderedPage(ResultPage.class);
+   tester.assertLabel("label", "A special label");
+   }
+
+   /**
+* @throws Exception
+*/
public void testPageConstructor() throws Exception
{
Book mockBook = new Book("xxId", "xxName");

Added: 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/apps_6/LinkPage.html
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/apps_6/LinkPage.html?rev=660029&view=auto
==
--- 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/apps_6/LinkPage.html
 (added)
+++ 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/apps_6/LinkPage.html
 Sun May 25 13:37:49 2008
@@ -0,0 +1,12 @@
+
+http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
+http://www.w3.org/1999/xhtml";>
+
+
+Click Link Test Page
+
+
+Standard Link which calls 
setResponsePage with page class
+Standard Link which calls 
setResponsePage with page instance
+
+
\ No newline at end of file

Propchange: 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/apps_6/LinkPage.html
--
svn:mime-type = text/plain

Added: 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/apps_6/LinkPage.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/apps_6/LinkPage.java?rev=660029&view=auto
==
--- 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/apps_6/LinkPage.java
 (added)
+++ 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/apps_6/LinkPage.java
 Sun May 25 13:37:49 2008
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *

[jira] Resolved: (WICKET-1635) Stripping javascript comments and whitespace breaks application when using prototype library

2008-05-25 Thread Igor Vaynberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1635.
---

   Resolution: Fixed
Fix Version/s: 1.4-M2
   1.3.4

> Stripping javascript comments and whitespace breaks application when using 
> prototype library

> --
>
> Key: WICKET-1635
> URL: https://issues.apache.org/jira/browse/WICKET-1635
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.3
>Reporter: Carlos Pita
>Assignee: Matej Knopp
>Priority: Blocker
> Fix For: 1.3.4, 1.4-M2
>
>
> Just to remember about https://issues.apache.org/jira/browse/WICKET-987. I 
> don't seem to be able to reopen it but I added a comment that justifies 
> reconsideration of that issue. Please close this once 987 is open again.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-1635) Stripping javascript comments and whitespace breaks application when using prototype library

2008-05-25 Thread Carlos Pita (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599697#action_12599697
 ] 

Carlos Pita commented on WICKET-1635:
-

Yes, it is. You have already answered it before you noticed about this 
"reminder" issue.

> Stripping javascript comments and whitespace breaks application when using 
> prototype library

> --
>
> Key: WICKET-1635
> URL: https://issues.apache.org/jira/browse/WICKET-1635
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.3
>Reporter: Carlos Pita
>Assignee: Matej Knopp
>Priority: Blocker
>
> Just to remember about https://issues.apache.org/jira/browse/WICKET-987. I 
> don't seem to be able to reopen it but I added a comment that justifies 
> reconsideration of that issue. Please close this once 987 is open again.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-1635) Stripping javascript comments and whitespace breaks application when using prototype library

2008-05-25 Thread Matej Knopp (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599691#action_12599691
 ] 

Matej Knopp commented on WICKET-1635:
-

if it is this one:

Line 4025 of prototype 1.6.0.2 gets truncated from

  document.write("

[jira] Commented: (WICKET-1625) ajax update brakes Form in ModalWindow

2008-05-25 Thread Matej Knopp (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599692#action_12599692
 ] 

Matej Knopp commented on WICKET-1625:
-

Improve javadoc maybe? Dunno, i'll think of hidden form inside modal window, 
that might work too.

> ajax update brakes Form in ModalWindow
> --
>
> Key: WICKET-1625
> URL: https://issues.apache.org/jira/browse/WICKET-1625
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket, wicket-extensions
>Affects Versions: 1.3.3
> Environment: tested in IE7, FF2 and FF3
>Reporter: david r.
>Assignee: Matej Knopp
>Priority: Critical
> Attachments: wicket-quickstart-form-modal-bug.zip
>
>
> When a Form contained by a ModalWindow is updated via AJAX (for example to 
> perform field validation), the AJAX response is correct (the full correct 
> form is in the response) but the final HTML code (after the Ajax update) is 
> erroneous.
> A consequence is that a second attempt to submit the same Form via AJAX 
> generates a JavaScript error: wicket-ajax.js, line 456, "element has no 
> properties". 
> In other words, "element" is NULL at this point.
> A possible reason for this:
> By looking at the HTML with Firebug, one can see that before the first AJAX 
> call,  the page looks like ... id="bar">... and after the request 
> (i.e. after the AJAX update of the Form) the code is 
> .. : the "form" tags disappeared 
> from the HTML code...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-1635) Stripping javascript comments and whitespace breaks application when using prototype library

2008-05-25 Thread Matej Knopp (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599690#action_12599690
 ] 

Matej Knopp commented on WICKET-1635:
-

What comment? I don't see any comment, can you post it here?

> Stripping javascript comments and whitespace breaks application when using 
> prototype library

> --
>
> Key: WICKET-1635
> URL: https://issues.apache.org/jira/browse/WICKET-1635
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.3
>Reporter: Carlos Pita
>Assignee: Matej Knopp
>Priority: Blocker
>
> Just to remember about https://issues.apache.org/jira/browse/WICKET-987. I 
> don't seem to be able to reopen it but I added a comment that justifies 
> reconsideration of that issue. Please close this once 987 is open again.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.