[jira] Created: (WICKET-1752) There is a problem using wicket standard DateTimeField, when on same page there is InMethod DataGrid control
There is a problem using wicket standard DateTimeField, when on same page there is InMethod DataGrid control Key: WICKET-1752 URL: https://issues.apache.org/jira/browse/WICKET-1752 Project: Wicket Issue Type: Bug Components: wicket-datetime, wicket-extensions Affects Versions: 1.3.4, 1.3.3, 1.3.2 Environment: Windows XP, Java 5.0, Tomcat 5.5, Firefox 2.13 Reporter: Emil Genov When on same wicket page we use both DateTimeField and InMethod DataGrid control, pressing of drop-down calendar button does not work. It do not show drop-down calendar. Source files to reproduce it attached -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1752) There is a problem using wicket standard DateTimeField, when on same page there is InMethod DataGrid control
[ https://issues.apache.org/jira/browse/WICKET-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emil Genov updated WICKET-1752: --- Attachment: TableTestPage.java There is a problem using wicket standard DateTimeField, when on same page there is InMethod DataGrid control Key: WICKET-1752 URL: https://issues.apache.org/jira/browse/WICKET-1752 Project: Wicket Issue Type: Bug Components: wicket-datetime, wicket-extensions Affects Versions: 1.3.2, 1.3.3, 1.3.4 Environment: Windows XP, Java 5.0, Tomcat 5.5, Firefox 2.13 Reporter: Emil Genov Attachments: TableTestPage.html, TableTestPage.java When on same wicket page we use both DateTimeField and InMethod DataGrid control, pressing of drop-down calendar button does not work. It do not show drop-down calendar. Source files to reproduce it attached -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1752) There is a problem using wicket standard DateTimeField, when on same page there is InMethod DataGrid control
[ https://issues.apache.org/jira/browse/WICKET-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emil Genov updated WICKET-1752: --- Attachment: TableTestPage.html There is a problem using wicket standard DateTimeField, when on same page there is InMethod DataGrid control Key: WICKET-1752 URL: https://issues.apache.org/jira/browse/WICKET-1752 Project: Wicket Issue Type: Bug Components: wicket-datetime, wicket-extensions Affects Versions: 1.3.2, 1.3.3, 1.3.4 Environment: Windows XP, Java 5.0, Tomcat 5.5, Firefox 2.13 Reporter: Emil Genov Attachments: TableTestPage.html, TableTestPage.java When on same wicket page we use both DateTimeField and InMethod DataGrid control, pressing of drop-down calendar button does not work. It do not show drop-down calendar. Source files to reproduce it attached -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1737) wicketTester does not find HTML mark-up if custom location is used.
[ https://issues.apache.org/jira/browse/WICKET-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12614270#action_12614270 ] Karsten Efker commented on WICKET-1737: --- Yes! May be this was a refresh problem - now it works! Thank you very, very much for the fix and best regrads from Germany. wicketTester does not find HTML mark-up if custom location is used. --- Key: WICKET-1737 URL: https://issues.apache.org/jira/browse/WICKET-1737 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.4 Reporter: Karsten Efker Assignee: Timo Rantalaiho Priority: Minor Attachments: sample1737-1.3-SNAPSHOT.zip, sample1737.zip If a custom HTML mark-up location is used as described in the ApacheWicket Wiki the wicketTester does not find mark-up to render pages. refer to: http://cwiki.apache.org/WICKET/control-where-html-files-are-loaded-from.html#ControlwhereHTMLfilesareloadedfrom-InWicket1.3 Nevertheless running the application with ApacheTomcat 6.0.16 everything renders fine. Remark: wicketTester has been instanciated using custom test application extended from the application used, overriding newSession for different purpose. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1737) wicketTester does not find HTML mark-up if custom location is used.
[ https://issues.apache.org/jira/browse/WICKET-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12614284#action_12614284 ] Karsten Efker commented on WICKET-1737: --- I just added your fix to your live project and now everything works fine with JUnit. Thank you, once again for your support. wicketTester does not find HTML mark-up if custom location is used. --- Key: WICKET-1737 URL: https://issues.apache.org/jira/browse/WICKET-1737 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.4 Reporter: Karsten Efker Assignee: Timo Rantalaiho Priority: Minor Attachments: sample1737-1.3-SNAPSHOT.zip, sample1737.zip If a custom HTML mark-up location is used as described in the ApacheWicket Wiki the wicketTester does not find mark-up to render pages. refer to: http://cwiki.apache.org/WICKET/control-where-html-files-are-loaded-from.html#ControlwhereHTMLfilesareloadedfrom-InWicket1.3 Nevertheless running the application with ApacheTomcat 6.0.16 everything renders fine. Remark: wicketTester has been instanciated using custom test application extended from the application used, overriding newSession for different purpose. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-1737) wicketTester does not find HTML mark-up if custom location is used.
[ https://issues.apache.org/jira/browse/WICKET-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karsten Efker closed WICKET-1737. - Resolution: Fixed Fix Version/s: 1.3.5 wicketTester does not find HTML mark-up if custom location is used. --- Key: WICKET-1737 URL: https://issues.apache.org/jira/browse/WICKET-1737 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.4 Reporter: Karsten Efker Assignee: Timo Rantalaiho Priority: Minor Fix For: 1.3.5 Attachments: sample1737-1.3-SNAPSHOT.zip, sample1737.zip If a custom HTML mark-up location is used as described in the ApacheWicket Wiki the wicketTester does not find mark-up to render pages. refer to: http://cwiki.apache.org/WICKET/control-where-html-files-are-loaded-from.html#ControlwhereHTMLfilesareloadedfrom-InWicket1.3 Nevertheless running the application with ApacheTomcat 6.0.16 everything renders fine. Remark: wicketTester has been instanciated using custom test application extended from the application used, overriding newSession for different purpose. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r677632 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket/model: ./ util/
Author: ivaynberg
Date: Thu Jul 17 09:31:56 2008
New Revision: 677632
URL: http://svn.apache.org/viewvc?rev=677632view=rev
Log:
model cleanup
Added:
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/util/
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/util/AbstractCollectionModel.java
- copied, changed from r677623,
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/CollectionModelBase.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/util/CollectionModel.java
- copied, changed from r677623,
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/CollectionModel.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/util/ListModel.java
- copied, changed from r677623,
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/ListModel.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/util/MapModel.java
- copied, changed from r677623,
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/MapModel.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/util/SetModel.java
- copied, changed from r677623,
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/SetModel.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/util/WildcardCollectionModel.java
- copied, changed from r677623,
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/WildcardCollectionModel.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/util/WildcardListModel.java
- copied, changed from r677623,
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/WildcardListModel.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/util/WildcardSetModel.java
- copied, changed from r677623,
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/WildcardSetModel.java
Removed:
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/CollectionModel.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/CollectionModelBase.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/ListModel.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/MapModel.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/SetModel.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/WildcardCollectionModel.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/WildcardListModel.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/WildcardSetModel.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/model/Model.java
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/model/Model.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/model/Model.java?rev=677632r1=677631r2=677632view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/model/Model.java
(original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/model/Model.java Thu
Jul 17 09:31:56 2008
@@ -25,14 +25,18 @@
import org.apache.wicket.Component;
import org.apache.wicket.WicketRuntimeException;
+import org.apache.wicket.model.util.MapModel;
+import org.apache.wicket.model.util.WildcardCollectionModel;
+import org.apache.wicket.model.util.WildcardListModel;
+import org.apache.wicket.model.util.WildcardSetModel;
import org.apache.wicket.util.lang.Objects;
/**
- * codeModel/code is the basic implementation of an codeIModel/code.
It just wraps a
- * simple model object. The model object must be serializable, as it is stored
in the session. If
- * you have large objects to store, consider using
- * [EMAIL PROTECTED] org.apache.wicket.model.LoadableDetachableModel} instead
of this class.
+ * codeModel/code is the basic implementation of an codeIModel/code.
It just wraps a simple
+ * model object. The model object must be serializable, as it is stored in the
session. If you have
+ * large objects to store, consider using [EMAIL PROTECTED]
org.apache.wicket.model.LoadableDetachableModel}
+ * instead of this class.
*
* @author Chris Turner
* @author Eelco Hillenius
@@ -66,25 +70,29 @@
}
/**
+* @param K
+*type of key inside map
+* @param V
+*type of value inside map
* @param map
*The Map, which may or may not be Serializable
* @deprecated see [EMAIL PROTECTED] Model#of(Map)}
* @return A Model object wrapping the Map
*/
- @SuppressWarnings(unchecked)
@Deprecated
-public static K, V IModelMapK, V valueOf(final MapK, V map)
+ public static K, V IModelMapK, V valueOf(final MapK, V map)
{
-return of(map);
+ return of(map);
}
/**
+* @param C
+*type of object inside list
* @param list
*
[jira] Assigned: (WICKET-1749) Want to add SignInPanel_ja.html
[ https://issues.apache.org/jira/browse/WICKET-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg reassigned WICKET-1749: - Assignee: Martijn Dashorst Want to add SignInPanel_ja.html --- Key: WICKET-1749 URL: https://issues.apache.org/jira/browse/WICKET-1749 Project: Wicket Issue Type: Improvement Components: wicket-auth-roles Affects Versions: 1.3.4 Environment: platform independent. Reporter: Ryo Ichinose Assignee: Martijn Dashorst Priority: Minor Attachments: SignInPanel_ja.html Original Estimate: 24h Remaining Estimate: 24h There are several localized version of SignInPanel.html in current wicket-auth-roles package, but SignInPanel_ja.html (japanese version of SignInPanel.html) is not introduced yet... I want developers of wicket-auth-roles to add SignInPanel_ja.html, which might make japanese users have more fun with the package. I can provide SignInPanel_ja.html if necessary (e.g. there are no japanese speakers among developers). Thanks. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r677653 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http: WicketFilter.java WicketServlet.java
Author: ivaynberg
Date: Thu Jul 17 10:54:58 2008
New Revision: 677653
URL: http://svn.apache.org/viewvc?rev=677653view=rev
Log:
WICKET-1753
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/WicketServlet.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java?rev=677653r1=677652r2=677653view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
Thu Jul 17 10:54:58 2008
@@ -21,7 +21,9 @@
import java.io.UnsupportedEncodingException;
import java.text.ParseException;
import java.util.ArrayList;
+import java.util.HashSet;
import java.util.Properties;
+import java.util.Set;
import javax.servlet.Filter;
import javax.servlet.FilterChain;
@@ -57,6 +59,13 @@
/**
* Filter for initiating handling of Wicket requests.
*
+ * @see WicketServlet for documentation
+ *
+ * @author Jonathan Locke
+ * @author Timur Mehrvarz
+ * @author Juergen Donnerstag
+ * @author Igor Vaynberg (ivaynberg)
+ * @author Al Maw
* @author jcompagner
*/
public class WicketFilter implements Filter
@@ -74,6 +83,13 @@
/** Log. */
private static final Logger log =
LoggerFactory.getLogger(WicketFilter.class);
+
+ /**
+* Name of parameter used to express a comma separated list of paths
that should be ignored
+*/
+ public static final String IGNORE_PATHS_PARAM = ignorePaths;
+
+
/**
* The servlet path holder when the WicketSerlvet is used. So that the
filter path will be
* computed with the first request. Note: This variable is by purpose
package protected. See
@@ -133,6 +149,9 @@
*/
private boolean portletOnlyFilter;
+ /** set of paths that should be ignored by the wicket filter */
+ private final SetString ignorePaths = new HashSetString();
+
/**
* Servlet cleanup.
*/
@@ -177,7 +196,21 @@
return;
}
- String relativePath = getRelativePath(httpServletRequest);
+ final String relativePath = getRelativePath(httpServletRequest);
+
+ if (ignorePaths.size() 0 relativePath.length() 0)
+ {
+ for (String path : ignorePaths)
+ {
+ if (relativePath.startsWith(path))
+ {
+ log.debug(Ignoring request {},
httpServletRequest.getRequestURL());
+ chain.doFilter(request, response);
+ return;
+ }
+ }
+ }
+
if (isWicketRequest(relativePath))
{
@@ -489,6 +522,8 @@
*/
public void init(FilterConfig filterConfig) throws ServletException
{
+ initIgnorePaths(filterConfig);
+
this.filterConfig = filterConfig;
String filterMapping =
filterConfig.getInitParameter(WicketFilter.FILTER_MAPPING_PARAM);
@@ -591,6 +626,28 @@
}
}
+ /**
+* initializes the ignore paths parameter
+*
+* @param filterConfig
+*/
+ private void initIgnorePaths(FilterConfig filterConfig)
+ {
+ String paths =
filterConfig.getInitParameter(IGNORE_PATHS_PARAM);
+ if (!Strings.isEmpty(paths))
+ {
+ String[] parts = paths.split(,);
+ for (String path : parts)
+ {
+ if (path.startsWith(/))
+ {
+ path = path.substring(1);
+ }
+ ignorePaths.add(path);
+ }
+ }
+ }
+
protected boolean isPortletContextAvailable(FilterConfig config) throws
ServletException
{
boolean detectPortletContext = false;
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/WicketServlet.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/WicketServlet.java?rev=677653r1=677652r2=677653view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/WicketServlet.java
(original)
+++
[jira] Assigned: (WICKET-1752) There is a problem using wicket standard DateTimeField, when on same page there is InMethod DataGrid control
[ https://issues.apache.org/jira/browse/WICKET-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg reassigned WICKET-1752: - Assignee: Matej Knopp There is a problem using wicket standard DateTimeField, when on same page there is InMethod DataGrid control Key: WICKET-1752 URL: https://issues.apache.org/jira/browse/WICKET-1752 Project: Wicket Issue Type: Bug Components: wicket-datetime, wicket-extensions Affects Versions: 1.3.2, 1.3.3, 1.3.4 Environment: Windows XP, Java 5.0, Tomcat 5.5, Firefox 2.13 Reporter: Emil Genov Assignee: Matej Knopp Attachments: TableTestPage.html, TableTestPage.java When on same wicket page we use both DateTimeField and InMethod DataGrid control, pressing of drop-down calendar button does not work. It do not show drop-down calendar. Source files to reproduce it attached -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1737) wicketTester does not find HTML mark-up if custom location is used.
[ https://issues.apache.org/jira/browse/WICKET-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Rantalaiho updated WICKET-1737: Affects Version/s: 1.4-M3 Fix Version/s: 1.4-M4 You're welcome, and thanks to your for reporting and testing. I now applied this to trunk (1.4) as well. wicketTester does not find HTML mark-up if custom location is used. --- Key: WICKET-1737 URL: https://issues.apache.org/jira/browse/WICKET-1737 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.4, 1.4-M3 Reporter: Karsten Efker Assignee: Timo Rantalaiho Priority: Minor Fix For: 1.3.5, 1.4-M4 Attachments: sample1737-1.3-SNAPSHOT.zip, sample1737.zip If a custom HTML mark-up location is used as described in the ApacheWicket Wiki the wicketTester does not find mark-up to render pages. refer to: http://cwiki.apache.org/WICKET/control-where-html-files-are-loaded-from.html#ControlwhereHTMLfilesareloadedfrom-InWicket1.3 Nevertheless running the application with ApacheTomcat 6.0.16 everything renders fine. Remark: wicketTester has been instanciated using custom test application extended from the application used, overriding newSession for different purpose. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r677812 - /wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/MockWebApplicationTest.java
Author: thrantal
Date: Thu Jul 17 20:38:42 2008
New Revision: 677812
URL: http://svn.apache.org/viewvc?rev=677812view=rev
Log:
Fixed missing @Overrides, redundant thises and raw types
- no functional changes
Modified:
wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/MockWebApplicationTest.java
Modified:
wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/MockWebApplicationTest.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/MockWebApplicationTest.java?rev=677812r1=677811r2=677812view=diff
==
---
wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/MockWebApplicationTest.java
(original)
+++
wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/MockWebApplicationTest.java
Thu Jul 17 20:38:42 2008
@@ -67,14 +67,16 @@
super(name);
}
- protected void setUp() throws Exception
+ @Override
+protected void setUp() throws Exception
{
super.setUp();
application = new WicketTester();
application.startPage(MockPage.class);
}
- protected void tearDown() throws Exception
+ @Override
+protected void tearDown() throws Exception
{
application.destroy();
}
@@ -86,7 +88,7 @@
{
// Validate the document
String document =
application.getServletResponse().getDocument();
- DiffUtil.validatePage(document, this.getClass(),
MockPage_expectedResult.html, true);
+ DiffUtil.validatePage(document, getClass(),
MockPage_expectedResult.html, true);
// Inspect the page model
MockPage p = (MockPage)application.getLastRenderedPage();
@@ -102,12 +104,12 @@
session.info(Message);
session.info(Not rendered);
FeedbackMessages feedbackMessages =
session.getFeedbackMessages();
- Iterator iterator = feedbackMessages.iterator();
- FeedbackMessage message = (FeedbackMessage)iterator.next();
+ IteratorFeedbackMessage iterator =
feedbackMessages.iterator();
+ FeedbackMessage message = iterator.next();
message.markRendered();
feedbackMessages.clear(RENDERED_MESSAGES);
assertEquals(1, feedbackMessages.size());
- message = (FeedbackMessage)iterator.next();
+ message = iterator.next();
message.markRendered();
feedbackMessages.clear(RENDERED_MESSAGES);
assertEquals(0, feedbackMessages.size());
@@ -124,7 +126,7 @@
// Now request that we click the link
application.setupRequestAndResponse();
MockPage p = (MockPage)application.getLastRenderedPage();
- Link link = (Link)p.get(actionLink);
+ Link? link = (Link?)p.get(actionLink);
application.getServletRequest().setRequestToComponent(link);
application.processRequestCycle();
@@ -139,7 +141,7 @@
*/
// Validate the document
String document =
application.getServletResponse().getDocument();
- DiffUtil.validatePage(document, this.getClass(),
MockPage_expectedResult2.html, true);
+ DiffUtil.validatePage(document, getClass(),
MockPage_expectedResult2.html, true);
// Inspect the page model
p = (MockPage)application.getLastRenderedPage();
svn commit: r677813 - /wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/MockWebApplicationTest.java
Author: thrantal
Date: Thu Jul 17 20:40:15 2008
New Revision: 677813
URL: http://svn.apache.org/viewvc?rev=677813view=rev
Log:
Fixed indentation to use tab as elsewhere
- no functional changes
Modified:
wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/MockWebApplicationTest.java
Modified:
wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/MockWebApplicationTest.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/MockWebApplicationTest.java?rev=677813r1=677812r2=677813view=diff
==
---
wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/MockWebApplicationTest.java
(original)
+++
wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/MockWebApplicationTest.java
Thu Jul 17 20:40:15 2008
@@ -36,7 +36,7 @@
/**
* Simple application that demonstrates the mock http application code (and
checks that it is
* working)
- *
+ *
* @author Chris Turner
*/
public class MockWebApplicationTest extends TestCase
@@ -58,9 +58,8 @@
/**
* Create the test.
-*
-* @param name
-*The test name
+*
+* @param name The test name
*/
public MockWebApplicationTest(String name)
{
@@ -68,7 +67,7 @@
}
@Override
-protected void setUp() throws Exception
+ protected void setUp() throws Exception
{
super.setUp();
application = new WicketTester();
@@ -76,7 +75,7 @@
}
@Override
-protected void tearDown() throws Exception
+ protected void tearDown() throws Exception
{
application.destroy();
}
@@ -91,7 +90,7 @@
DiffUtil.validatePage(document, getClass(),
MockPage_expectedResult.html, true);
// Inspect the page model
- MockPage p = (MockPage)application.getLastRenderedPage();
+ MockPage p = (MockPage) application.getLastRenderedPage();
Assert.assertEquals(Link should have been clicked 0 times, 0,
p.getLinkClickCount());
}
@@ -125,8 +124,8 @@
// Now request that we click the link
application.setupRequestAndResponse();
- MockPage p = (MockPage)application.getLastRenderedPage();
- Link? link = (Link?)p.get(actionLink);
+ MockPage p = (MockPage) application.getLastRenderedPage();
+ Link? link = (Link?) p.get(actionLink);
application.getServletRequest().setRequestToComponent(link);
application.processRequestCycle();
@@ -144,13 +143,13 @@
DiffUtil.validatePage(document, getClass(),
MockPage_expectedResult2.html, true);
// Inspect the page model
- p = (MockPage)application.getLastRenderedPage();
+ p = (MockPage) application.getLastRenderedPage();
Assert.assertEquals(Link should have been clicked 1 time, 1,
p.getLinkClickCount());
}
public void testProvidesDefaultResourceFinderIfNotSetByApplication()
{
-
Assert.assertNotNull(Application.get().getResourceSettings().getResourceFinder());
+
Assert.assertNotNull(Application.get().getResourceSettings().getResourceFinder());
}
public void testHonorsResourceFinderSettingsSetByApplication()
@@ -163,14 +162,15 @@
}
@Override
-public String toString()
+ public String toString()
{
return customResourceFinder;
}
};
- WebApplication wicketApplication = new DummyWebApplication() {
+ WebApplication wicketApplication = new DummyWebApplication()
+ {
@Override
-protected void init()
+ protected void init()
{
IResourceSettings resourceSettings =
getResourceSettings();
resourceSettings.setResourceFinder(customResourceFinder);
[jira] Assigned: (WICKET-1528) ModalWindow / Mousepointer with Opera
[ https://issues.apache.org/jira/browse/WICKET-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg reassigned WICKET-1528: - Assignee: Matej Knopp ModalWindow / Mousepointer with Opera - Key: WICKET-1528 URL: https://issues.apache.org/jira/browse/WICKET-1528 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.3 Environment: Opera 9.2x Reporter: Jan Kriesten Assignee: Matej Knopp With Opera there's always a right arrow over ModalWindow instead of the default. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r677818 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java
Author: ivaynberg
Date: Thu Jul 17 21:30:42 2008
New Revision: 677818
URL: http://svn.apache.org/viewvc?rev=677818view=rev
Log:
WICKET-1535
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java?rev=677818r1=677817r2=677818view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java
Thu Jul 17 21:30:42 2008
@@ -192,7 +192,7 @@
else
{
// or generate an onclick JS
handler directly
- tag.put(onclick,
window.location.href=' + url + ';);
+ tag.put(onclick,
window.location.href=' + url + ';return false;);
}
}
}
[jira] Resolved: (WICKET-1535) ExternalLink JavaScript not working in FF 3
[ https://issues.apache.org/jira/browse/WICKET-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-1535. --- Resolution: Fixed Fix Version/s: 1.3.5 Assignee: Igor Vaynberg there is nothing wrong with adding return false; ExternalLink JavaScript not working in FF 3 --- Key: WICKET-1535 URL: https://issues.apache.org/jira/browse/WICKET-1535 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.3 Environment: WinXP; Firefox 3.0 Beta 5 Reporter: Gwyn Evans Assignee: Igor Vaynberg Priority: Minor Fix For: 1.3.5, 1.4-M4 If the link target isn't a proper anchor, the code generates a JS on-click handler, i.e. tag.put(onclick, window.location.href=' + url + ';); which generates code such as onclick='window.location.href=http://news.bbc.co.uk;;' The problem is that when this is used with a button /in a form/, while this works with IE FF2, it appears that FF3 needs a 'return false;' at the end of the JS before it works, otherwise it just treats the button as a 'submit' action. So, is there any down-side to changing the above line in \org\apache\wicket\markup\html\link\ExternalLink.java to be tag.put(onclick, window.location.href=' + url + '; return false;); ? /Gwyn -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
