[jira] Resolved: (WICKET-399) Make RestartResponseAtInterceptPageException with a SignIn-type page work correctly from AjaxFallbackLink
[ https://issues.apache.org/jira/browse/WICKET-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-399. -- Resolution: Won't Fix Assignee: Igor Vaynberg the restartresponseatinterceptpage works exactly as it should. we might be able to improve this somewhat in the upcoming 1.5. > Make RestartResponseAtInterceptPageException with a SignIn-type page work > correctly from AjaxFallbackLink > - > > Key: WICKET-399 > URL: https://issues.apache.org/jira/browse/WICKET-399 > Project: Wicket > Issue Type: Wish > Components: wicket >Affects Versions: 1.2.5 >Reporter: Nick Johnson >Assignee: Igor Vaynberg >Priority: Minor > Fix For: 1.3.5 > > Attachments: > 20070104-wicket-1.x-RestartResponseAtOriginalDestination, > 20070104-wicket-1.x-RestartResponseAtOriginalDestination.txt, > RestartResponseAtOriginalDestination.java > > > If you throw a new RestartResponseAtInterceptPageException from inside > onClick in an AjaxFallbackLink, Wicket does the right thing in redirecting > you to a SignIn page, but upon completing the sign-in, the > continueToOriginalDestination() call continues to the Ajax response (which > isn't particularly surprising). > It might be nice to have magic added to make this work seamlessly and restart > the onClick() somehow. It would be adequate to make the AjaxFallBackLink > behave as though fallback had happened in this situation. > A fairly simple workaround is to check in the Panel/Page to see if sign-in > has happened already and use a normal Link in the case that it hasn't. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1376) Using AbstractAjaxTimerBehavior and mounting that page gives exception
[ https://issues.apache.org/jira/browse/WICKET-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-1376. --- Resolution: Fixed Fix Version/s: 1.4-M4 Assignee: Igor Vaynberg (was: Johan Compagner) ajax request target now supports repainting of the page - if the page is the same > Using AbstractAjaxTimerBehavior and mounting that page gives exception > -- > > Key: WICKET-1376 > URL: https://issues.apache.org/jira/browse/WICKET-1376 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3.1 >Reporter: Oliver Krohne >Assignee: Igor Vaynberg > Fix For: 1.3.5, 1.4-M4 > > > AbstractAjaxTimerBehavior renders a table every 3 seconds. > A DataView is used to populate the table. > I have tried mountBookmarkablePage(), QueryStringUrlCodingStrategy and > MixedParamUrlCodingStrategy. > Root cause: > java.lang.IllegalStateException: URL fragment has unmatched key/value pair: > amp > at > org.apache.wicket.request.target.coding.AbstractRequestTargetUrlCodingStrategy.decodeParameters(AbstractRequestTargetUrlCodingStrategy.java:174) > at > org.apache.wicket.request.target.coding.BookmarkablePageRequestTargetUrlCodingStrategy.decode(BookmarkablePageRequestTargetUrlCodingStrategy.java:76) > at > org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.targetForRequest(WebRequestCodingStrategy.java:475) > at > org.apache.wicket.protocol.http.WebRequestCycleProcessor.resolve(WebRequestCycleProcessor.java:175) > at org.apache.wicket.RequestCycle.step(RequestCycle.java:1224) > at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1316) > at org.apache.wicket.RequestCycle.request(RequestCycle.java:493) > at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:354) > at > org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:194) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:230) > at > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175) > at > org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) > at > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:104) > at > org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) > at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:261) > at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:844) > at > org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:581) > at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447) > at java.lang.Thread.run(Thread.java:613) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r699571 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Author: ivaynberg
Date: Fri Sep 26 23:43:36 2008
New Revision: 699571
URL: http://svn.apache.org/viewvc?rev=699571&view=rev
Log:
WICKET-1376
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?rev=699571&r1=699570&r2=699571&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Fri Sep 26 23:43:36 2008
@@ -370,7 +370,10 @@
}
else if (component instanceof Page)
{
- throw new IllegalArgumentException("component cannot be
a page");
+ if (component != page)
+ {
+ throw new IllegalArgumentException("component
cannot be a page");
+ }
}
else if (component instanceof AbstractRepeater)
{
@@ -522,6 +525,17 @@
*/
public final void respond(final RequestCycle requestCycle)
{
+ final WebResponse response =
(WebResponse)requestCycle.getResponse();
+
+ if (markupIdToComponent.values().contains(page))
+ {
+ // the page itself has been added to the request
target, we simply issue a redirect back
+ // to the page
+ final String url = requestCycle.urlFor(page).toString();
+ response.redirect(url);
+ return;
+ }
+
for (ITargetRespondListener listener : respondListeners)
{
listener.onTargetRespond(this);
@@ -533,7 +547,6 @@
final String encoding =
app.getRequestCycleSettings().getResponseRequestEncoding();
// Set content type based on markup type for page
- final WebResponse response =
(WebResponse)requestCycle.getResponse();
response.setCharacterEncoding(encoding);
response.setContentType("text/xml; charset=" + encoding);
@@ -732,7 +745,7 @@
RequestCycle.get().setResponse(encodingBodyResponse);
// Initialize temporary variables
- final Page page = (Page)component.findParent(Page.class);
+ final Page page = component.findParent(Page.class);
if (page == null)
{
// dont throw an exception but just ignore this
component, somehow
svn commit: r699570 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Author: ivaynberg
Date: Fri Sep 26 23:42:37 2008
New Revision: 699570
URL: http://svn.apache.org/viewvc?rev=699570&view=rev
Log:
WICKET-1376
Modified:
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Modified:
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?rev=699570&r1=699569&r2=699570&view=diff
==
---
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
(original)
+++
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Fri Sep 26 23:42:37 2008
@@ -367,7 +367,10 @@
}
else if (component instanceof Page)
{
- throw new IllegalArgumentException("component cannot be
a page");
+ if (component != page)
+ {
+ throw new IllegalArgumentException("component
cannot be a page");
+ }
}
else if (component instanceof AbstractRepeater)
{
@@ -522,6 +525,17 @@
*/
public final void respond(final RequestCycle requestCycle)
{
+ final WebResponse response =
(WebResponse)requestCycle.getResponse();
+
+ if (markupIdToComponent.values().contains(page))
+ {
+ // the page itself has been added to the request
target, we simply issue a redirect back
+ // to the page
+ final String url = requestCycle.urlFor(page).toString();
+ response.redirect(url);
+ return;
+ }
+
Iterator it = respondListeners.iterator();
while (it.hasNext())
{
@@ -535,7 +549,6 @@
final String encoding =
app.getRequestCycleSettings().getResponseRequestEncoding();
// Set content type based on markup type for page
- final WebResponse response =
(WebResponse)requestCycle.getResponse();
response.setCharacterEncoding(encoding);
response.setContentType("text/xml; charset=" + encoding);
[jira] Resolved: (WICKET-1449) './' appended to URL causes HTTP 404 in Internet Explorer (using root context)
[
https://issues.apache.org/jira/browse/WICKET-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-1449.
---
Resolution: Cannot Reproduce
Assignee: Igor Vaynberg (was: Alastair Maw)
tried with latest wicket-1.3.x and could not reproduce it, must already be fixed
> './' appended to URL causes HTTP 404 in Internet Explorer (using root context)
> --
>
> Key: WICKET-1449
> URL: https://issues.apache.org/jira/browse/WICKET-1449
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.2
> Environment: Wicket 1.3.2
> JBoss 4.0/Jetty 6.1.7
> JDK 1.6.0_03
>Reporter: Will Hoover
>Assignee: Igor Vaynberg
> Fix For: 1.3.5
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> SYNOPSIS:
> 1) Web application is using the root context ("/")
> 1) form.add(new Button("mybutton"));
> 2) Button is clicked on any WebPage that is NOT MOUNTED
> ISSUE:
> WebRequestCodingStrategy.encode appends './' to the URL. The page is
> redirected to "http://www.mysite.com/./"; It works fine in Firefox and Opera,
> but in IE an HTTP 404 ('.' page is not found) is rendered.
> Mounting the home page to something like '/home' solved the problem ('./' is
> not appended, but this causes a redirect every time a use hits the page).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-625) Wicket doesn't clean up properly when hot-deploying; hangs onto Class references.
[ https://issues.apache.org/jira/browse/WICKET-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-625. -- Resolution: Fixed marking this as resolved. i believe we have removed all class references... > Wicket doesn't clean up properly when hot-deploying; hangs onto Class > references. > - > > Key: WICKET-625 > URL: https://issues.apache.org/jira/browse/WICKET-625 > Project: Wicket > Issue Type: Bug > Components: wicket, wicket-extensions, wicket-spring >Affects Versions: 1.3.0-beta1 >Reporter: Alastair Maw >Assignee: Alastair Maw > Fix For: 1.3.5 > > Attachments: WICKET-625.patch > > > When you undeploy a webapp, ideally it should go away and its > WebAppClassLoader should be garbage collected. There are various reasons this > won't happen, but they essentially split into two problems: > 1) The App Server has references to classes in the WebAppClassLoader in its > own objects (on Tomcat these are typically commons logging statics in > StandardContext in catalina, or some of the jakarta code). There's not much > you can do about this, short of getting a better app server. > 2) You hold references to Class objects loaded by your WebAppClassLoader in > static fields in other Classes loaded by your WebAppClassLoader. > Number 2 can be solved by the use of WeakReferences to the Class objects. > Note that you also need to be careful about classes that have Class > references internally, such as java.lang.reflect.Method and Field. You can > also hold these items in a WeakReference, but they have the potential to be > garbage collected randomly, unlike the underlying Class objects. > I have some patches that allow me to start up and shut down a Spring-backed > Wicket-based app and have the classloader cope properly. They could probably > do with some review. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1478) AbortWithWebErrorCodeException in onBeforeRender causes WicketRuntimeException
[ https://issues.apache.org/jira/browse/WICKET-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg reassigned WICKET-1478: - Assignee: Johan Compagner (was: Ate Douma) where are we with this johan? > AbortWithWebErrorCodeException in onBeforeRender causes WicketRuntimeException > -- > > Key: WICKET-1478 > URL: https://issues.apache.org/jira/browse/WICKET-1478 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3.2 >Reporter: Michael Sparer >Assignee: Johan Compagner >Priority: Minor > Fix For: 1.3.5 > > Attachments: quickstart404.jar > > > Using custom error pages as described on > http://cwiki.apache.org/WICKET/error-pages-and-feedback-messages.html, a > wicket RTE gets thrown "There is no application attached to current thread > [threadname]" when a AbortWithWebErrorCodeException is thrown in the > onBeforeRender method of a WebPage. Note that this _only_ happens when using > a custom error page defined in web.xml. > See attached quickstart for the complete stacktrace (and my usecase) > See also the mailinglist entry on > http://www.nabble.com/Throw-AbortWithWebErrorCodeException-in-onBeforeRender-to16446341.html#a16473849 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1664) WebPage ERROR message
[ https://issues.apache.org/jira/browse/WICKET-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-1664. --- Resolution: Cannot Reproduce Assignee: Igor Vaynberg (was: Juergen Donnerstag) could not reproduce with latest branch and trunk. must already be fixed. > WebPage ERROR message > -- > > Key: WICKET-1664 > URL: https://issues.apache.org/jira/browse/WICKET-1664 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3.4 > Environment: Any >Reporter: Jan Kriesten >Assignee: Igor Vaynberg > Fix For: 1.3.5 > > Attachments: issue-quickstart.zip > > > With latest trunk, the following message occurs in the logs: > 09:41:50.297 ERROR [org.apache.wicket.markup.html.WebPage] - > ^ > 09:41:50.314 ERROR [org.apache.wicket.markup.html.WebPage] - You > probably forgot to add a or tag to your markup since no > Header Container was found but components where found which want to write to > the section. > This happens, when using TransparentResolver with the html-Tag. > A quickstart is attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-847) setResponsePage redirects to wrong url
[ https://issues.apache.org/jira/browse/WICKET-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-847. -- Resolution: Cannot Reproduce Assignee: Igor Vaynberg (was: Alastair Maw) started the quickstart, clicked the link, everything seems to work in ff and ie > setResponsePage redirects to wrong url > -- > > Key: WICKET-847 > URL: https://issues.apache.org/jira/browse/WICKET-847 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3.0-beta2 >Reporter: Andrew Klochkov >Assignee: Igor Vaynberg > Fix For: 1.3.5 > > Attachments: wicket-quickstart.tar.gz > > > When I do setResponsePage(MyHomePage.class) IE tries to show me > "my.site.com/./" url and gets 404 response. > Firefox just shows "my.site.com" without any troubles. I'm using wicket > 1.3-beta2 and WicketFilter mapped to /*. > It's being reproduced under tomcat only, jetty works fine. My tomcat version > is 5.5.17. > Quickstart project which reproduces the bug is attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1720) Add clearLocalizerCache to Application JMX bean
[ https://issues.apache.org/jira/browse/WICKET-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-1720. --- Resolution: Fixed Fix Version/s: 1.4-M4 1.3.5 Assignee: Igor Vaynberg > Add clearLocalizerCache to Application JMX bean > --- > > Key: WICKET-1720 > URL: https://issues.apache.org/jira/browse/WICKET-1720 > Project: Wicket > Issue Type: New Feature > Components: wicket-jmx >Affects Versions: 1.3.4, 1.4-M2 >Reporter: Tom Desmet >Assignee: Igor Vaynberg >Priority: Minor > Fix For: 1.3.5, 1.4-M4 > > > Hi, > Would it be possible to add clearLocalizerCache to the Application JMX bean? > Details are in the post below... > http://www.nabble.com/add-ClearLocalizerCache-to-Application-JMX-td18151368.html > Thank you very much! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r699560 - in /wicket/trunk/wicket-jmx/src/main/java/org/apache/wicket/jmx: Application.java ApplicationMBean.java
Author: ivaynberg
Date: Fri Sep 26 22:29:10 2008
New Revision: 699560
URL: http://svn.apache.org/viewvc?rev=699560&view=rev
Log:
WICKET-1720
Modified:
wicket/trunk/wicket-jmx/src/main/java/org/apache/wicket/jmx/Application.java
wicket/trunk/wicket-jmx/src/main/java/org/apache/wicket/jmx/ApplicationMBean.java
Modified:
wicket/trunk/wicket-jmx/src/main/java/org/apache/wicket/jmx/Application.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-jmx/src/main/java/org/apache/wicket/jmx/Application.java?rev=699560&r1=699559&r2=699560&view=diff
==
---
wicket/trunk/wicket-jmx/src/main/java/org/apache/wicket/jmx/Application.java
(original)
+++
wicket/trunk/wicket-jmx/src/main/java/org/apache/wicket/jmx/Application.java
Fri Sep 26 22:29:10 2008
@@ -48,11 +48,11 @@
// do this so that we don't have to cast all the time
if (application instanceof WebApplication)
{
- this.webApplication = (WebApplication)application;
+ webApplication = (WebApplication)application;
}
else
{
- this.webApplication = null;
+ webApplication = null;
}
}
@@ -138,4 +138,12 @@
{
return application.getFrameworkSettings().getVersion();
}
+
+ /**
+* @see org.apache.wicket.jmx.ApplicationMBean#clearLocalizerCache()
+*/
+ public void clearLocalizerCache() throws IOException
+ {
+ application.getResourceSettings().getLocalizer().clearCache();
+ }
}
Modified:
wicket/trunk/wicket-jmx/src/main/java/org/apache/wicket/jmx/ApplicationMBean.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-jmx/src/main/java/org/apache/wicket/jmx/ApplicationMBean.java?rev=699560&r1=699559&r2=699560&view=diff
==
---
wicket/trunk/wicket-jmx/src/main/java/org/apache/wicket/jmx/ApplicationMBean.java
(original)
+++
wicket/trunk/wicket-jmx/src/main/java/org/apache/wicket/jmx/ApplicationMBean.java
Fri Sep 26 22:29:10 2008
@@ -91,4 +91,11 @@
* @throws IOException
*/
String getWicketVersion() throws IOException;
+
+ /**
+* Clears the localizer cache.
+*
+* @throws IOException
+*/
+ void clearLocalizerCache() throws IOException;
}
svn commit: r699559 - in /wicket/branches/wicket-1.3.x/jdk-1.5/wicket-jmx/src/main/java/org/apache/wicket/jmx: Application.java ApplicationMBean.java
Author: ivaynberg
Date: Fri Sep 26 22:29:02 2008
New Revision: 699559
URL: http://svn.apache.org/viewvc?rev=699559&view=rev
Log:
WICKET-1720
Modified:
wicket/branches/wicket-1.3.x/jdk-1.5/wicket-jmx/src/main/java/org/apache/wicket/jmx/Application.java
wicket/branches/wicket-1.3.x/jdk-1.5/wicket-jmx/src/main/java/org/apache/wicket/jmx/ApplicationMBean.java
Modified:
wicket/branches/wicket-1.3.x/jdk-1.5/wicket-jmx/src/main/java/org/apache/wicket/jmx/Application.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.5/wicket-jmx/src/main/java/org/apache/wicket/jmx/Application.java?rev=699559&r1=699558&r2=699559&view=diff
==
---
wicket/branches/wicket-1.3.x/jdk-1.5/wicket-jmx/src/main/java/org/apache/wicket/jmx/Application.java
(original)
+++
wicket/branches/wicket-1.3.x/jdk-1.5/wicket-jmx/src/main/java/org/apache/wicket/jmx/Application.java
Fri Sep 26 22:29:02 2008
@@ -48,11 +48,11 @@
// do this so that we don't have to cast all the time
if (application instanceof WebApplication)
{
- this.webApplication = (WebApplication)application;
+ webApplication = (WebApplication)application;
}
else
{
- this.webApplication = null;
+ webApplication = null;
}
}
@@ -138,4 +138,12 @@
{
return application.getFrameworkSettings().getVersion();
}
+
+ /**
+* @see org.apache.wicket.jmx.ApplicationMBean#clearLocalizerCache()
+*/
+ public void clearLocalizerCache() throws IOException
+ {
+ application.getResourceSettings().getLocalizer().clearCache();
+ }
}
Modified:
wicket/branches/wicket-1.3.x/jdk-1.5/wicket-jmx/src/main/java/org/apache/wicket/jmx/ApplicationMBean.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.5/wicket-jmx/src/main/java/org/apache/wicket/jmx/ApplicationMBean.java?rev=699559&r1=699558&r2=699559&view=diff
==
---
wicket/branches/wicket-1.3.x/jdk-1.5/wicket-jmx/src/main/java/org/apache/wicket/jmx/ApplicationMBean.java
(original)
+++
wicket/branches/wicket-1.3.x/jdk-1.5/wicket-jmx/src/main/java/org/apache/wicket/jmx/ApplicationMBean.java
Fri Sep 26 22:29:02 2008
@@ -91,4 +91,11 @@
* @throws IOException
*/
String getWicketVersion() throws IOException;
+
+ /**
+* Clears the localizer cache.
+*
+* @throws IOException
+*/
+ void clearLocalizerCache() throws IOException;
}
[jira] Resolved: (WICKET-1754) form action URLs in non-Wicket forms not rewritten
[ https://issues.apache.org/jira/browse/WICKET-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-1754. --- Resolution: Fixed Fix Version/s: 1.4-M4 Assignee: Igor Vaynberg fixing in 1.4 only, dont want to take the chance of breaking anyhting in production deployed apps > form action URLs in non-Wicket forms not rewritten > -- > > Key: WICKET-1754 > URL: https://issues.apache.org/jira/browse/WICKET-1754 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3.4 >Reporter: Brad Fritz >Assignee: Igor Vaynberg >Priority: Minor > Fix For: 1.4-M4 > > > Wicket's RelativePathPrefixHandler rewrites "href", "src", and "background" > URLs in non-Wicket markup but does not rewrite "action" URLs in forms. > There are workarounds but it would be cleaner if Wicket handled this case > by default. > Discussion at: > http://www.nabble.com/RelativePathPrefixHandler-and-form-"action"-attributes-tt18537680.html > http://www.nabble.com/RelativePathPrefixHandler-and-form-"action"-attributes-tt18536692.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r699558 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/RelativePathPrefixHandler.java
Author: ivaynberg
Date: Fri Sep 26 22:19:45 2008
New Revision: 699558
URL: http://svn.apache.org/viewvc?rev=699558&view=rev
Log:
WICKET-1754
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/RelativePathPrefixHandler.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/RelativePathPrefixHandler.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/RelativePathPrefixHandler.java?rev=699558&r1=699557&r2=699558&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/RelativePathPrefixHandler.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/RelativePathPrefixHandler.java
Fri Sep 26 22:19:45 2008
@@ -68,7 +68,8 @@
public static final String WICKET_RELATIVE_PATH_PREFIX_CONTAINER_ID =
"_relative_path_prefix_";
/** List of attribute names considered */
- private static final String attributeNames[] = new String[] { "href",
"src", "background" };
+ private static final String attributeNames[] = new String[] { "href",
"src", "background",
+ "action" };
/**
* Behavior that adds a prefix to src, href and background attributes
to make them
[jira] Resolved: (WICKET-1765) Extending from org.apache.wicket.Page causes StackOverflowError
[
https://issues.apache.org/jira/browse/WICKET-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-1765.
---
Resolution: Fixed
Fix Version/s: 1.4-M4
1.3.5
Assignee: Igor Vaynberg
> Extending from org.apache.wicket.Page causes StackOverflowError
> ---
>
> Key: WICKET-1765
> URL: https://issues.apache.org/jira/browse/WICKET-1765
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.4
> Environment: Windows XP, Eclipse Ganymede, Wicket 1.3.4, Embedded
> Jetty
>Reporter: Daniel Freitas
>Assignee: Igor Vaynberg
>Priority: Minor
> Fix For: 1.3.5, 1.4-M4
>
>
> Extending directly from Page, instead of WebPage, causes a StackOverflowError
> due to a recursive loop.
> The problem could be tracked down to the following code:
> Example code:
> public class ClockPage extends Page{ // Extends page directly
> }
> //---Page extends MarkupContainer
> public class MarkupContainer ...
> public String getMarkupType()
> {
> return getPage().getMarkupType();
> }
> ...
> }
> //-getPpage() is inherited from Component:
> public abstract class Component ... {
> ...
> public final Page getPage()
> {
> // Search for nearest Page
> final Page page = findPage();
> // If no Page was found
> if (page == null)
> {
> // Give up with a nice exception
> throw new IllegalStateException("No Page found for component " +
> this);
> }
> return page;
> }
> ...
> }
> When extending directly from page, getPage() (inherited from Component)
> returns an instance to the ClockPage in the example above, which then calls
> getMarkupType() on itself which will call getPage() again and on an on until
> a stack overflow occur.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r699557 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Page.java
Author: ivaynberg
Date: Fri Sep 26 22:14:15 2008
New Revision: 699557
URL: http://svn.apache.org/viewvc?rev=699557&view=rev
Log:
WICKET-1765
Modified:
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Page.java
Modified:
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Page.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Page.java?rev=699557&r1=699556&r2=699557&view=diff
==
---
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Page.java
(original)
+++
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Page.java
Fri Sep 26 22:14:15 2008
@@ -1578,4 +1578,11 @@
{
}
+
+ public String getMarkupType()
+ {
+ throw new UnsupportedOperationException(
+ "Page does not support markup. This error can happen if
you have extended Page directly, instead extend WebPage");
+ }
+
}
svn commit: r699556 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java
Author: ivaynberg
Date: Fri Sep 26 22:13:26 2008
New Revision: 699556
URL: http://svn.apache.org/viewvc?rev=699556&view=rev
Log:
WICKET-1765
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java?rev=699556&r1=699555&r2=699556&view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java Fri Sep 26
22:13:26 2008
@@ -727,7 +727,7 @@
}
/**
-* Determine the "statelessness" of the page while not changing the
cached value.
+* Determine the "statelessness" of the page while not changing the
cached value.
*
* @return boolean value
*/
@@ -738,7 +738,7 @@
stateless = old;
return res;
}
-
+
/**
* Gets whether the page is stateless. Components on stateless page
must not render any
* statefull urls, and components on statefull page must not render any
stateless urls.
@@ -1613,4 +1613,12 @@
public void onPageAttached()
{
}
+
+ @Override
+ public String getMarkupType()
+ {
+ throw new UnsupportedOperationException(
+ "Page does not support markup. This error can happen if
you have extended Page directly, instead extend WebPage");
+ }
+
}
[jira] Resolved: (WICKET-1786) Adding SVG support detection to ClientProperties
[ https://issues.apache.org/jira/browse/WICKET-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-1786. --- Resolution: Fixed Fix Version/s: 1.4-M4 1.3.5 Assignee: Igor Vaynberg > Adding SVG support detection to ClientProperties > > > Key: WICKET-1786 > URL: https://issues.apache.org/jira/browse/WICKET-1786 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.3.4 > Environment: Tested with Ubuntu 8.04 / Firefox 2.0.0.15 and XPsp2 / > IE7 (without plugins) >Reporter: Federico Fanton >Assignee: Igor Vaynberg >Priority: Minor > Fix For: 1.3.5, 1.4-M4 > > Attachments: detect_svg.patch > > > I'd like to extend BrowserInfoForm to detect if the browser supports SVGs > (javascript method here > http://thomas.tanrei.ca/modern-script-based-svg-detection/ ), but it looks > like it cannot be easily extended.. So I wrote a patch against Wicket 1.3.4 > (hope it's not too messy ^^; ) > Thanks! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r699553 - in /wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket: markup/html/pages/BrowserInfoForm.html markup/html/pages/BrowserInfoForm.java markup/html/pages/d
Author: ivaynberg
Date: Fri Sep 26 21:36:04 2008
New Revision: 699553
URL: http://svn.apache.org/viewvc?rev=699553&view=rev
Log:
WICKET-1786
Added:
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/pages/detectSVG.js
(with props)
Modified:
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.html
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.java
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/ClientProperties.java
Modified:
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.html
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.html?rev=699553&r1=699552&r2=699553&view=diff
==
---
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.html
(original)
+++
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.html
Fri Sep 26 21:36:04 2008
@@ -42,6 +42,18 @@
document.postback.utcDSTOffset.value = (new Date(new
Date().getFullYear(), 6, 1, 0, 0, 0, 0).getTimezoneOffset() / -60);
document.postback.browserWidth.value = window.innerWidth ||
document.body.offsetWidth;
document.postback.browserHeight.value = window.innerHeight ||
document.body.offsetHeight;
+
+ // SVG detection
+ var svginfo = detectSVG();
+ if(svginfo.support){
+ var svgstate = null;
+ if(svginfo.support=="Builtin")
+ svgstate=svginfo.builtin + ',' +
svginfo.builtinVersion;
+ else
+ svgstate=svginfo.plugin + ',' +
svginfo.pluginVersion + ',' + svginfo.IID;
+ document.postback.SVGsupport.value = svgstate;
+ }
+
document.postback.submit();
}
@@ -63,6 +75,7 @@
+
Modified:
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.java?rev=699553&r1=699552&r2=699553&view=diff
==
---
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.java
(original)
+++
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.java
Fri Sep 26 21:36:04 2008
@@ -17,6 +17,9 @@
package org.apache.wicket.markup.html.pages;
import org.apache.wicket.IClusterable;
+import org.apache.wicket.ResourceReference;
+import org.apache.wicket.markup.html.IHeaderContributor;
+import org.apache.wicket.markup.html.IHeaderResponse;
import org.apache.wicket.markup.html.form.Form;
import org.apache.wicket.markup.html.form.TextField;
import org.apache.wicket.markup.html.panel.Panel;
@@ -32,7 +35,7 @@
/**
* Form for posting JavaScript properties.
*/
-public class BrowserInfoForm extends Panel
+public class BrowserInfoForm extends Panel implements IHeaderContributor
{
/** log. */
private static final Logger log =
LoggerFactory.getLogger(BrowserInfoForm.class);
@@ -99,6 +102,7 @@
form.add(new TextField("utcDSTOffset"));
form.add(new TextField("browserWidth"));
form.add(new TextField("browserHeight"));
+ form.add(new TextField("SVGsupport"));
add(form);
}
@@ -122,6 +126,10 @@
}
+ public void renderHead(IHeaderResponse response) {
+ response.renderJavascriptReference(new
ResourceReference(this.getClass(), "detectSVG.js"));
+ }
+
/**
* Holds properties of the client.
*/
@@ -144,6 +152,7 @@
private String utcDSTOffset;
private String browserWidth;
private String browserHeight;
+ private String SVGsupport;
/**
* Gets browserHeight.
@@ -310,6 +319,7 @@
properties.setScreenColorDepth(getInt(screenColorDepth));
properties.setUtcOffset(utcOffset);
properties.setUtcDSTOffset(utcDSTOffset);
+ properties.setSVGsupport(SVGsupport);
}
/**
@@ -500,5 +510,24 @@
}
svn commit: r699552 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket: markup/html/pages/BrowserInfoForm.html markup/html/pages/BrowserInfoForm.java markup/html/pages/detectSVG.js protocol/htt
Author: ivaynberg
Date: Fri Sep 26 21:34:45 2008
New Revision: 699552
URL: http://svn.apache.org/viewvc?rev=699552&view=rev
Log:
WICKET-1786
Added:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/pages/detectSVG.js
(with props)
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.html
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/ClientProperties.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.html
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.html?rev=699552&r1=699551&r2=699552&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.html
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.html
Fri Sep 26 21:34:45 2008
@@ -42,6 +42,18 @@
document.postback.utcDSTOffset.value = (new Date(new
Date().getFullYear(), 6, 1, 0, 0, 0, 0).getTimezoneOffset() / -60);
document.postback.browserWidth.value = window.innerWidth ||
document.body.offsetWidth;
document.postback.browserHeight.value = window.innerHeight ||
document.body.offsetHeight;
+
+ // SVG detection
+ var svginfo = detectSVG();
+ if(svginfo.support){
+ var svgstate = null;
+ if(svginfo.support=="Builtin")
+ svgstate=svginfo.builtin + ',' +
svginfo.builtinVersion;
+ else
+ svgstate=svginfo.plugin + ',' +
svginfo.pluginVersion + ',' + svginfo.IID;
+ document.postback.SVGsupport.value = svgstate;
+ }
+
document.postback.submit();
}
@@ -63,6 +75,7 @@
+
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.java?rev=699552&r1=699551&r2=699552&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoForm.java
Fri Sep 26 21:34:45 2008
@@ -17,6 +17,9 @@
package org.apache.wicket.markup.html.pages;
import org.apache.wicket.IClusterable;
+import org.apache.wicket.ResourceReference;
+import org.apache.wicket.markup.html.IHeaderContributor;
+import org.apache.wicket.markup.html.IHeaderResponse;
import org.apache.wicket.markup.html.form.Form;
import org.apache.wicket.markup.html.form.TextField;
import org.apache.wicket.markup.html.panel.Panel;
@@ -32,7 +35,7 @@
/**
* Form for posting JavaScript properties.
*/
-public class BrowserInfoForm extends Panel
+public class BrowserInfoForm extends Panel implements IHeaderContributor
{
/** log. */
private static final Logger log =
LoggerFactory.getLogger(BrowserInfoForm.class);
@@ -101,6 +104,7 @@
form.add(new TextField("utcDSTOffset"));
form.add(new TextField("browserWidth"));
form.add(new TextField("browserHeight"));
+ form.add(new TextField("SVGsupport"));
add(form);
}
@@ -124,6 +128,11 @@
}
+ public void renderHead(IHeaderResponse response)
+ {
+ response.renderJavascriptReference(new
ResourceReference(this.getClass(), "detectSVG.js"));
+ }
+
/**
* Holds properties of the client.
*/
@@ -146,6 +155,7 @@
private String utcDSTOffset;
private String browserWidth;
private String browserHeight;
+ private String SVGsupport;
/**
* Gets browserHeight.
@@ -312,6 +322,7 @@
properties.setScreenColorDepth(getInt(screenColorDepth));
properties.setUtcOffset(utcOffset);
properties.setUtcDSTOffset(utcDSTOffset);
+ properties.setSVGsupport(SVGsupport);
}
/**
@@ -502,5 +513,26 @@
}
return intValue;
}
+
+ /**
+* Sets SVGsupport
+*
+* @param SVGsupport
+*SVGsupport
+*/
+ public void setSVGsupport(String gsupp
[jira] Resolved: (WICKET-1791) Allow override of WebPage.getApplication()
[ https://issues.apache.org/jira/browse/WICKET-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-1791. --- Resolution: Won't Fix Assignee: Igor Vaynberg i dont think we are going to do this. removing final from that method is not a good idea as it opens a can of warms, even though i will acknowledge that covariance is nice. these kinds of methods (getrequest(), getapp(), getsession(), etc) will most likely go away in wicket 1.5 anyways... > Allow override of WebPage.getApplication() > -- > > Key: WICKET-1791 > URL: https://issues.apache.org/jira/browse/WICKET-1791 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4-M3 >Reporter: John Patterson >Assignee: Igor Vaynberg > > We can override Application.get() to return our subclass but not the > WebPage.getApplication() convenience method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1799) wicket-extensions has unused reference to commons-collections.jar
[ https://issues.apache.org/jira/browse/WICKET-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-1799. --- Resolution: Fixed Fix Version/s: 1.3.5 Assignee: Igor Vaynberg seems like this was already removed from 1.4 > wicket-extensions has unused reference to commons-collections.jar > - > > Key: WICKET-1799 > URL: https://issues.apache.org/jira/browse/WICKET-1799 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Reporter: Peter Ertl >Assignee: Igor Vaynberg > Fix For: 1.3.5 > > Attachments: wicket-1799-wicket-1.3.patch, > wicket-1799-wicket-1.4.patch > > > It seems that wicket-extensions (both 1.3 and 1.4) holds an unused reference > to common-collections.jar in it's pom.xml. > > commons-collections > commons-collections > > I removed that reference and could still compile everything without any > error. Could someone double-check that and remove it if it's really not > needed. this would save us from another 570 kb :-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r699551 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/pom.xml
Author: ivaynberg Date: Fri Sep 26 21:18:06 2008 New Revision: 699551 URL: http://svn.apache.org/viewvc?rev=699551&view=rev Log: WICKET-1799 Modified: wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/pom.xml Modified: wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/pom.xml URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/pom.xml?rev=699551&r1=699550&r2=699551&view=diff == --- wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/pom.xml (original) +++ wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/pom.xml Fri Sep 26 21:18:06 2008 @@ -44,9 +44,5 @@ tests test - - commons-collections - commons-collections -
[jira] Resolved: (WICKET-1816) Wicket 1.3.4 violates servlet standard, Glassfish spews warnings
[ https://issues.apache.org/jira/browse/WICKET-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-1816. --- Resolution: Fixed Fix Version/s: 1.4-M4 1.3.5 Assignee: Igor Vaynberg johan said he committed something that shouldve fixed this on the list, please reopen if its still broken > Wicket 1.3.4 violates servlet standard, Glassfish spews warnings > > > Key: WICKET-1816 > URL: https://issues.apache.org/jira/browse/WICKET-1816 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3.4 >Reporter: Gili >Assignee: Igor Vaynberg > Fix For: 1.3.5, 1.4-M4 > > > WicketFilter.java line 194 invokes getLastModified() which invokes > "request.getParameterMap()" on line 962. Later on in that same request, > WicketFilter.java line 222 invokes doGet() which invokes > response.setCharacterEncoding() on line 376. > This is just one case where this problem occurs but I believe others might > exist. Whenever Wicket violates the standard Glassfish spews out this warning: > PWC4011: Unable to set request character encoding to UTF-8 from context > , because request parameters have already been read, or > ServletRequest.getReader() has already been called > ... you literally end up with tens of these warnings per request, and > supposedly, the wrong behavior :) Glassfish's FAQ discusses this in more > detail: > http://wiki.glassfish.java.net/Wiki.jsp?page=FaqWebAppUnableToSetRequestCharEncoding -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1836) RequestUtils.toAbsolutePath() should handle dot paths in the url
[ https://issues.apache.org/jira/browse/WICKET-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-1836. --- Resolution: Fixed Fix Version/s: 1.4-M4 Assignee: Igor Vaynberg i wasnt able to reproduce it, but i think i fixed it. feel free to open if its still broken > RequestUtils.toAbsolutePath() should handle dot paths in the url > > > Key: WICKET-1836 > URL: https://issues.apache.org/jira/browse/WICKET-1836 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4-M3 > Environment: linux jetty >Reporter: francisdb >Assignee: Igor Vaynberg >Priority: Minor > Fix For: 1.4-M4 > > > String path = > RequestUtils.toAbsolutePath(RequestCycle.get().urlFor(HomePage.class, new > PageParameters()).toString()); > if HomePage is mounted to / the url will be http://host/./ and should instead > be http://host/ > only double dots are translated, single dots should be removed > Some other remarks: > the implementation is using StringBuffer, that could be changed to > StringBuilder. > toAbsolutepath should accept CharSequence instead of String (that will remove > the need for the .toString() in the above sample -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r699550 - in /wicket/trunk/wicket/src: main/java/org/apache/wicket/protocol/http/RequestUtils.java test/java/org/apache/wicket/protocol/http/RequestUtilsTest.java
Author: ivaynberg
Date: Fri Sep 26 20:52:26 2008
New Revision: 699550
URL: http://svn.apache.org/viewvc?rev=699550&view=rev
Log:
WICKET-1846
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/RequestUtils.java
wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/RequestUtilsTest.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/RequestUtils.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/RequestUtils.java?rev=699550&r1=699549&r2=699550&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/RequestUtils.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/RequestUtils.java
Fri Sep 26 20:52:26 2008
@@ -184,8 +184,7 @@
*path, relative to requestPath
* @return absolute path for given url
*/
- public final static String toAbsolutePath(final String requestPath,
- final String relativePagePath)
+ public final static String toAbsolutePath(final String requestPath,
String relativePagePath)
{
final StringBuffer result;
if (requestPath.endsWith("/"))
@@ -198,6 +197,11 @@
result = new StringBuffer(requestPath.substring(0,
requestPath.lastIndexOf('/') + 1));
}
+ if (relativePagePath.startsWith("./"))
+ {
+ relativePagePath = relativePagePath.substring(2);
+ }
+
if (relativePagePath.startsWith("../"))
{
StringBuffer tempRelative = new
StringBuffer(relativePagePath);
Modified:
wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/RequestUtilsTest.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/RequestUtilsTest.java?rev=699550&r1=699549&r2=699550&view=diff
==
---
wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/RequestUtilsTest.java
(original)
+++
wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/RequestUtilsTest.java
Fri Sep 26 20:52:26 2008
@@ -83,5 +83,11 @@
"http://aif.ru/blah/zzz";);
assertEquals(RequestUtils.toAbsolutePath("http://aif.ru/blah/test";, "zzz"),
"http://aif.ru/blah/zzz";);
+
assertEquals(RequestUtils.toAbsolutePath("http://aif.ru/blah/test";, "./zzz"),
+ "http://aif.ru/blah/zzz";);
+
assertEquals(RequestUtils.toAbsolutePath("http://aif.ru/blah/test";, "./"),
+ "http://aif.ru/blah/";);
+ assertEquals(RequestUtils.toAbsolutePath("http://aif.ru/";,
"./"), "http://aif.ru/";);
+
}
}
[jira] Resolved: (WICKET-1842) MultiLineLabel content not inside container when used with element
[
https://issues.apache.org/jira/browse/WICKET-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-1842.
---
Resolution: Cannot Reproduce
Assignee: Igor Vaynberg
when i try it i get proper output:
asfdasd
> MultiLineLabel content not inside container when used with element
> --
>
> Key: WICKET-1842
> URL: https://issues.apache.org/jira/browse/WICKET-1842
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.4
>Reporter: Peter Parson
>Assignee: Igor Vaynberg
>Priority: Minor
>
> When applying a MultiLineLabel to a HTML paragraph element, the rendered
> content of the label is not within the paragraph element, but appended
> thereafter.
> Example:
> HTML:
> [some text]
> Java:
> add (new MultiLineLabel("testMultiLine","asdfasdfasdf"));
> rendered HTML source:
> asdfasdfasdf
> Simple workaround is: using a div instead - works as expected.
> Also, I realized that MultiLineLabel renders tags (i.e. not XHTML
> compliant).
> Don't know whether this is intended behavior, though.
> Cheers,
> Peter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1844) Wizard button implementations should not be final
[ https://issues.apache.org/jira/browse/WICKET-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg updated WICKET-1844: -- Priority: Minor (was: Major) > Wizard button implementations should not be final > - > > Key: WICKET-1844 > URL: https://issues.apache.org/jira/browse/WICKET-1844 > Project: Wicket > Issue Type: Improvement > Components: wicket-extensions >Affects Versions: 1.3.4 >Reporter: Matthias Keller >Priority: Minor > > I dont know why the wizard buttons are final but this makes it hard to add > custom behaviour to them. For example, we need to hide a button if it's not > enabled. We had to re-create all buttons by ourselves to do that instead of > just overriding the isVisible() method of a button. > Affects: > org/apache/wicket/extensions/wizard/CancelButton > org/apache/wicket/extensions/wizard/FinishButton > org/apache/wicket/extensions/wizard/LastButton > org/apache/wicket/extensions/wizard/NextButton > org/apache/wicket/extensions/wizard/PreviousButton > Suggestion: remove 'final' from class declaration -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1849) TreeTable fails to render last column header in IE when sum of column width is 100%
[ https://issues.apache.org/jira/browse/WICKET-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg reassigned WICKET-1849: - Assignee: Matej Knopp > TreeTable fails to render last column header in IE when sum of column width > is 100% > --- > > Key: WICKET-1849 > URL: https://issues.apache.org/jira/browse/WICKET-1849 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.3.4 >Reporter: Emond Papegaaij >Assignee: Matej Knopp >Priority: Minor > > When the total column width is exactly 100%, the last column header is not > displayed in IE7 (and probably also in 6). Reducing the size of one of the > columns by 1% fixes the problem. This probably is a rendering error by IE, > but perhaps the component can check this? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1846) Dutch text message for NumberValidator incorrect
[
https://issues.apache.org/jira/browse/WICKET-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-1846.
---
Resolution: Fixed
Fix Version/s: 1.4-M4
1.3.5
Assignee: Igor Vaynberg
> Dutch text message for NumberValidator incorrect
>
>
> Key: WICKET-1846
> URL: https://issues.apache.org/jira/browse/WICKET-1846
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.4
>Reporter: Emond Papegaaij
>Assignee: Igor Vaynberg
>Priority: Minor
> Fix For: 1.3.5, 1.4-M4
>
>
> These must be changed from
> NumberValidator.minimum='${input}' moet groter zijn dan ${minimum}.
> NumberValidator.maximum='${input}' moet kleiner zijn dan ${maximum}.
> to
> NumberValidator.minimum='${input}' mag niet kleiner zijn dan ${minimum}.
> NumberValidator.maximum='${input}' mag niet groter zijn dan ${maximum}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r699548 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/Application_nl.properties
Author: ivaynberg
Date: Fri Sep 26 20:06:49 2008
New Revision: 699548
URL: http://svn.apache.org/viewvc?rev=699548&view=rev
Log:
WICKET-1846
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/Application_nl.properties
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/Application_nl.properties
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Application_nl.properties?rev=699548&r1=699547&r2=699548&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/Application_nl.properties
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/Application_nl.properties
Fri Sep 26 20:06:49 2008
@@ -25,8 +25,8 @@
IConverter.date='${input}' in veld '${label}' moet een datum zijn.
RangeValidator=${input} moet tussen ${minimum} en ${maximum} liggen.
-MinimumValidator='${input}' moet groter zijn dan ${minimum}.
-MaximumValidator='${input}' moet kleiner zijn dan ${maximum}.
+MinimumValidator='${input}' mag niet kleiner zijn dan ${minimum}.
+MaximumValidator='${input}' mag niet groter zijn dan ${maximum}.
NumberValidator.positive='${input}' moet positief zijn.
NumberValidator.negative='${input}' moet negatief zijn.
svn commit: r699547 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Application_nl.properties
Author: ivaynberg
Date: Fri Sep 26 20:06:43 2008
New Revision: 699547
URL: http://svn.apache.org/viewvc?rev=699547&view=rev
Log:
WICKET-1846
Modified:
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Application_nl.properties
Modified:
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Application_nl.properties
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Application_nl.properties?rev=699547&r1=699546&r2=699547&view=diff
==
---
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Application_nl.properties
(original)
+++
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Application_nl.properties
Fri Sep 26 20:06:43 2008
@@ -25,8 +25,8 @@
IConverter.date='${input}' in veld '${label}' moet een datum zijn.
NumberValidator.range=${input} moet tussen ${minimum} en ${maximum} liggen.
-NumberValidator.minimum='${input}' moet groter zijn dan ${minimum}.
-NumberValidator.maximum='${input}' moet kleiner zijn dan ${maximum}.
+NumberValidator.minimum='${input}' mag niet kleiner zijn dan ${minimum}.
+NumberValidator.maximum='${input}' mag niet groter zijn dan ${maximum}.
NumberValidator.positive='${input}' moet positief zijn.
NumberValidator.negative='${input}' moet negatief zijn.
[jira] Updated: (WICKET-1850) UrlValidator disallow http://user:passw...@host:port/path urls
[ https://issues.apache.org/jira/browse/WICKET-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg updated WICKET-1850: -- Priority: Trivial (was: Major) Issue Type: Improvement (was: Bug) this can wait for a patch > UrlValidator disallow http://user:[EMAIL PROTECTED]:port/path urls > -- > > Key: WICKET-1850 > URL: https://issues.apache.org/jira/browse/WICKET-1850 > Project: Wicket > Issue Type: Improvement >Affects Versions: 1.3.1 >Reporter: Alexey Efimov >Priority: Trivial > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1853) Wicket should allow non-formcomponents to plug into form's FormComponent#updateModel event
Wicket should allow non-formcomponents to plug into form's FormComponent#updateModel event -- Key: WICKET-1853 URL: https://issues.apache.org/jira/browse/WICKET-1853 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4-M3 Reporter: Igor Vaynberg Assignee: Igor Vaynberg It would be nice if any component can listen to form's event that signals form components to update their models. currently this feature is only available to formcomponents (and formcomponentpanel) but it is often useful for generic containers as well. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1853) Wicket should allow non-formcomponents to plug into form's FormComponent#updateModel event
[ https://issues.apache.org/jira/browse/WICKET-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-1853. --- Resolution: Fixed Fix Version/s: 1.4-M4 see IFormModelUpdateListener > Wicket should allow non-formcomponents to plug into form's > FormComponent#updateModel event > -- > > Key: WICKET-1853 > URL: https://issues.apache.org/jira/browse/WICKET-1853 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4-M3 >Reporter: Igor Vaynberg >Assignee: Igor Vaynberg > Fix For: 1.4-M4 > > > It would be nice if any component can listen to form's event that signals > form components to update their models. currently this feature is only > available to formcomponents (and formcomponentpanel) but it is often useful > for generic containers as well. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r699544 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form: Form.java FormComponent.java IFormModelUpdateListener.java
Author: ivaynberg
Date: Fri Sep 26 19:30:43 2008
New Revision: 699544
URL: http://svn.apache.org/viewvc?rev=699544&view=rev
Log:
WIKCET-1853
Added:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/IFormModelUpdateListener.java
(with props)
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java?rev=699544&r1=699543&r2=699544&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
Fri Sep 26 19:30:43 2008
@@ -185,6 +185,52 @@
public abstract void validate(FormComponent formComponent);
}
+
+ /**
+* Visitor used to update component models
+*
+* @author Igor Vaynberg (ivaynberg)
+*/
+ private static class FormModelUpdateVisitor implements
Component.IVisitor
+ {
+ private final Form formFilter;
+
+ /**
+* Constructor
+*
+* @param formFilter
+*/
+ public FormModelUpdateVisitor(Form formFilter)
+ {
+ this.formFilter = formFilter;
+ }
+
+ /** [EMAIL PROTECTED] */
+ public Object component(Component component)
+ {
+ if (component instanceof IFormModelUpdateListener)
+ {
+ final Form form = Form.findForm(component);
+ if (form != null)
+ {
+ if (this.formFilter == null ||
this.formFilter == form)
+ {
+ if (form.isEnabled() &&
form.isEnableAllowed())
+ {
+ if
(component.isEnabled() && component.isEnableAllowed() &&
+
component.isVisibleInHierarchy())
+ {
+
((IFormModelUpdateListener)component).updateModel();
+ }
+ }
+ }
+ }
+ }
+ return Component.IVisitor.CONTINUE_TRAVERSAL;
+ }
+ }
+
+
/**
*
*/
@@ -1871,19 +1917,22 @@
*/
private void internalUpdateFormComponentModels()
{
- visitFormComponentsPostOrder(new ValidationVisitor()
+ FormComponent.visitComponentsPostOrder(this, new
FormModelUpdateVisitor(this));
+
+ MarkupContainer border = findParent(Border.class);
+ if (border != null)
{
- @Override
- public void validate(FormComponent formComponent)
+ Iterator iter = border.iterator();
+ Component.IVisitor visitor = new
FormModelUpdateVisitor(null);
+ while (iter.hasNext())
{
- Form form = formComponent.getForm();
- if (form == Form.this)
+ Component child = iter.next();
+ if (child instanceof IFormModelUpdateListener)
{
- // Potentially update the model
- formComponent.updateModel();
+ visitor.component(child);
}
}
- });
+ }
}
/**
@@ -2110,5 +2159,36 @@
setDefaultModelObject(object);
}
+ /**
+* @param component
+* @return The parent form for component
+*/
+ public static Form findForm(Component component)
+ {
+ class FindFormVisitor implements Component.IVisitor>
+ {
+ Form form = null;
+
+ public Object component(Form component)
+ {
+ form = component;
+ return Component.IVisitor.STOP_TRA
[CONF] Apache Wicket: Companies that provide services (page edited)
Page Edited : WICKET : Companies that provide services Companies that provide services has been edited by Jonathan Locke (Sep 26, 2008). (View changes) Content: List of companies that provide commercial services for Wicket. Wicket Support Services Jonathan Locke originated Wicket and provides consulting services. Zenika is a leading French training company, offering Wicket courses in Paris in partnership with jWeekend. Wicket Support is a company that provides training, consultations and commercial support for Wicket. Wicket Training provides training classes, on-site training, and consulting for Wicket (US-Based). Jaywayis a premier Java consulting group that via its Malaysian subsidiary provides services for Wicket development, especially running Wicket in OSGi environments. Jayway DKis a premier Java consulting group located in Denmark provides services for Wicket development, course etc. Skillsmatteris a leading provider of training, mentoring and project based skills transfer. Amongst other things, they provide Wicket courses. Anyware Technologies is a french company that provides many training courses, including Wicket. jWeekend provides weekday and weekend, expert training in Java, OO & Wicket (co-developed and co-presented by Al Maw). London & Brighton. Doculibre Inc. is a Canadian company that provides Wicket support and development. sign of renitence GmbH & Co. KG is a german company that provides services for Wicket development and training courses. Xavier Hanin is a french independent consultant who provides services for Wicket development and training. Curalia is Java consulting company that provides services for Wicket development. The Macau Productivity and Technology Transfer Center is a non-profit organization that is including Wicket in its extensive training programs. Reaktor Innovations is a Finnish company that provides Wicket development and training. Ralf Ebert is a German independent consultant who provides services for Wicket development. JointEffort is a small Dutch company that provides training, consultations and services for Wicket development. Leverage IT is a small South African IT Consulting and Development company that specializes in the use of Java Open Source Technologies, Platforms and Frameworks, including Wicket. XENTUM is a Polish company that provides Wicket development and support. automação.info is a Brazilian company that provides Wicket development. Genuco Systems is a company with offices in Hong Kong and Canada that provide leading edge Wicket development solutions as well as financial services. Powered by Atlassian Confluence (Version: 2.2.9 Build:#527 Sep 07, 2006) - Bug/feature request Unsubscribe or edit your notifications preferences
svn commit: r699473 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/UrlUtils.java
Author: ivaynberg
Date: Fri Sep 26 13:03:50 2008
New Revision: 699473
URL: http://svn.apache.org/viewvc?rev=699473&view=rev
Log:
missing class
Added:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/UrlUtils.java
(with props)
Added:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/UrlUtils.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/UrlUtils.java?rev=699473&view=auto
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/UrlUtils.java
(added)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/UrlUtils.java
Fri Sep 26 13:03:50 2008
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket.util.string;
+
+import org.apache.wicket.Request;
+
+/**
+ * Various url utilities
+ *
+ * @author igor.vaynberg
+ */
+public class UrlUtils
+{
+ /**
+* Constructor
+*/
+ private UrlUtils()
+ {
+
+ }
+
+ /**
+* Checks if the url is relative or absolute
+*
+* @param url
+* @return true if url is relative, false
otherwise
+*/
+ public static boolean isRelative(String url)
+ {
+ if ((url != null) && (url.startsWith("/") == false) &&
(url.indexOf("://") < 0) &&
+ !(url.startsWith("#")))
+ {
+ return true;
+ }
+ else
+ {
+ return false;
+ }
+ }
+
+ /**
+* Rewrites a relative url to be context relative, leaves absolute urls
same.
+*
+* @param url
+* @param request
+* @return rewritten url
+*/
+ public static String rewriteToContextRelative(String url, Request
request)
+ {
+ if (isRelative(url))
+ {
+ final String prefix =
request.getRelativePathPrefixToContextRoot();
+ return prefix + url;
+ }
+ else
+ {
+ return url;
+ }
+ }
+}
Propchange:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/UrlUtils.java
--
svn:mime-type = text/plain
[CONF] Apache Wicket: Community meetups (page edited)
Page Edited : WICKET : Community meetups Community meetups has been edited by Rand Huso (Sep 26, 2008). (View changes) Content: Bookmarkable link If you're thinking about organizing a local meetup, don't hesitate to add your initiative to this list! Pictures of past Wicket meetings can be found here: http://flickr.com/photos/tags/wicketmeeting/ There are already efforts to organize meetups in the following countries: United Kingdom Belgium The Netherlands Denmark Sweden Brazil Argentina United States Austria Canada United Kingdom Location: London Regular meetups: The first Wednesday of every other month To register, go here: http://jweekend.co.uk/dev/LWUGReg Belgium Last meetup: JavaPolis'07 (dec 12th-14th) Martijn Dashorst will give a Wicket presentation at the conference. We are interested in a Birds of a Feather (BoF) meeting, and interest can be registered here. When you want to attend, you need to be registered at the conference too. The presentation and BoF will be in English. Name Interested Will come! BoF? Martijn Dashorst x x x Per Ejeklint x x yeah! Xavier Hanin x x x Francis De Brabandere x ? x The Netherlands The excitement in the Netherlands keeps growing check it out: Wicket Community meetups - Amsterdam. Denmark Location: Copenhagen Last meetup: 23 april 16 hrs Next meetup: 15 october 16 hrs @ Jakob Dannefærds Vej 6B, 3. TV 1973 Frederiksberg C Speakers/ areas of interest? Write what you want to hear about here.. Then people can add themselves as speakers content speaker? Wicket Iolite (only if theres interest in it) Nino Creating behaviors (only if theres interest in it) Nino Selling wicket (to your company, and customers) Discussion Go here to sign up: http://wugdk.eventbrite.com/ Sweden Location: Stockholm Next meetup: TBD (no meetups during the summer) Web page: http://wicket.jalbum.net Please also join the google group (at the web page) to receive invitations to the meetups. Location: Malmø / øredev Next meetup: 19-21nov one of the days.. Speakers/ areas of interest? Write what you want to hear about here.. Then people can add themselves as speakers content speaker? Wicket-Spring-JPA-Hibernate Nino TDD/BDD & Wicket! Nino Wicket Performance Discusssion Nino starts it with some tips Creating behaviors/integrating _javascript_ Nino Selling wicket (to your company, and customers) Discussion "something about integrating with some google goodness" Martjin Dashorst Name Interested Will come Language Comments Nino Martinez x Danish,English Brazil Location: Rio de Janeiro Next meetup: to be scheduled Register here or send an e-mail to Alexandre Bairos (alexandre.bairos at gmail.com) and let us know you are interested. Name Interested Will come Language Comments Alexandre Bairos x x Portuguese,English,P Bruno Borges x x Portuguese,English,P João Antonio x x Portuguese,English,P Argentina Location: Buenos Aires Next meetup: to be scheduled Register here or send an e-mail to (fernando.wermus at gmail.com) and let us know you are interested. Name Interested Will come Language Comments Fernando Wermus x x Portuguese,English,Spanish,P Juan G. Arias x x English,Spanish,P Eduardo Constantin x x Portuguese,English,Spanish,P United States Wicket Users Group - Twin Cities Location: Minneapolis, MN Next meetup: to be scheduled (see group website) http://groups.google.com/group/wicket-user-group-twincities Location: Seattle Next meetup: to be scheduled Send an e-mail to Eelco Hillenius (eelco.hillenius at gmail.com) if you'd like to see this happen Name Interested Comments Eelco Hillenius x Jonathan Locke x Eric Crampton x Jose Collas x Mitch Gitman x Rand Huso x Location: San Francisco Next meetup: to be scheduled Send an email to Orion Letizi ([EMAIL PROTECTED]) and let us know if you are interested Name Interested Will come Dec. 6 Dec. 14 Comments Orion Letizi x x x x Nick Johnson x x x x Al Maw x Can only make it if between 28th Nov and 12th Dec Julian Sinai x Sehyo Chang x David Pollak x x Enrique Rodriguez x x David Sean Taylor Sean Sullivan x x December 2 through December 6 Niels van Kampenhout x Austria Location: Linz or Hagenberg Next meetup: to be scheduled Send an e-mail to Gerolf Seitz (gerolf.seitz at gmail.com) if you're interested in a "get together" and/or register below Name Interested Will come Comments Gerolf
[jira] Resolved: (WICKET-1852) Allow option to not process an inner nested form when outer form is submitted.
[ https://issues.apache.org/jira/browse/WICKET-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-1852. --- Resolution: Invalid Assignee: Igor Vaynberg see IFormVisitorParticipant > Allow option to not process an inner nested form when outer form is submitted. > -- > > Key: WICKET-1852 > URL: https://issues.apache.org/jira/browse/WICKET-1852 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4-M3 >Reporter: Patrick Angeles >Assignee: Igor Vaynberg > > Especially useful for forms inside a table. > Sample markup: > > > > > > > > > UPDATE > > > > > >ADD > > > > > > Possibly, add a boolean processIfNested() method to Form, which can be > overridden to return 'false'. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1852) Allow option to not process an inner nested form when outer form is submitted.
Allow option to not process an inner nested form when outer form is submitted. -- Key: WICKET-1852 URL: https://issues.apache.org/jira/browse/WICKET-1852 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4-M3 Reporter: Patrick Angeles Especially useful for forms inside a table. Sample markup: UPDATE ADD Possibly, add a boolean processIfNested() method to Form, which can be overridden to return 'false'. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r699402 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket: behavior/ markup/html/image/ markup/html/link/ markup/parser/filter/ protocol/http/request/ request/ request/target/basic
Author: ivaynberg
Date: Fri Sep 26 09:36:55 2008
New Revision: 699402
URL: http://svn.apache.org/viewvc?rev=699402&view=rev
Log:
consolidate context-relative path prfixing instead of doing it all over the
place
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/behavior/HeaderContributor.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/image/ContextPathGenerator.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/RelativePathPrefixHandler.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/request/CryptedUrlWebRequestCodingStrategy.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/IRequestCodingStrategy.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/basic/RedirectRequestTarget.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/behavior/HeaderContributor.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/behavior/HeaderContributor.java?rev=699402&r1=699401&r2=699402&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/behavior/HeaderContributor.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/behavior/HeaderContributor.java
Fri Sep 26 09:36:55 2008
@@ -52,7 +52,7 @@
*The path
* @return the new header contributor instance
*/
- public static final HeaderContributor forCss(final Class< ? > scope,
final String path)
+ public static final HeaderContributor forCss(final Class scope,
final String path)
{
return new HeaderContributor(new IHeaderContributor()
{
@@ -78,7 +78,7 @@
*The media type for this CSS ("print", "screen", etc.)
* @return the new header contributor instance
*/
- public static final HeaderContributor forCss(final Class< ? > scope,
final String path,
+ public static final HeaderContributor forCss(final Class scope,
final String path,
final String media)
{
return new HeaderContributor(new IHeaderContributor()
@@ -203,7 +203,7 @@
*The path
* @return the new header contributor instance
*/
- public static final HeaderContributor forJavaScript(final Class< ? >
scope, final String path)
+ public static final HeaderContributor forJavaScript(final Class
scope, final String path)
{
return new HeaderContributor(new IHeaderContributor()
{
@@ -276,7 +276,10 @@
}
else
{
- return
RequestCycle.get().getRequest().getRelativePathPrefixToContextRoot() + location;
+ return RequestCycle.get()
+ .getProcessor()
+ .getRequestCodingStrategy()
+ .rewriteStaticRelativeUrl(location);
}
}
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/image/ContextPathGenerator.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/image/ContextPathGenerator.java?rev=699402&r1=699401&r2=699402&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/image/ContextPathGenerator.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/image/ContextPathGenerator.java
Fri Sep 26 09:36:55 2008
@@ -21,7 +21,6 @@
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.model.IModel;
import org.apache.wicket.model.Model;
-import org.apache.wicket.util.string.Strings;
/**
* A behavior that converts the provider url fragment to a context-relative
url. For example if the
@@ -62,24 +61,15 @@
@Override
public void onComponentTag(Component component, ComponentTag tag)
{
- // get the path
+ // get path
final String path = contextRelativePath.getObject();
- // generate prefix that will make path context relative
- final String prefix =
component.getRequest().getRelativePathPrefixToContextRoot();
+ final String rewritten = component.getRequestCycle()
+ .getProcessor()
+ .getRequestCodingStrategy()
+ .rewriteStaticRelativeUrl(path);
- final String contextRelativePath;
- if (!Strings.isEmpty(prefix))
- {
-
[jira] Commented: (WICKET-1130) Injection of Bound Instance Fails with Exception
[
https://issues.apache.org/jira/browse/WICKET-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634909#action_12634909
]
Igor Vaynberg commented on WICKET-1130:
---
unfortunately this is a limitation of java/cglb. easiest thing to do is to add
a package-private noarg constructor to the class. was this the underlying
reason for your previous troubles?
i cant say that i agree with your patch either, there may be other reasons why
IllegalArgumentException is thrown from e.create() no?
> Injection of Bound Instance Fails with Exception
>
>
> Key: WICKET-1130
> URL: https://issues.apache.org/jira/browse/WICKET-1130
> Project: Wicket
> Issue Type: Bug
> Components: wicket-guice
>Affects Versions: 1.3.0-beta4
>Reporter: Daniel Spiewak
>Assignee: Alastair Maw
> Fix For: 1.5-M1
>
>
> If I try to inject an explicitly bound instance into a component, injection
> fails with an exception in the creation of the CGLIB proxy:
> java.lang.IllegalArgumentException: Superclass has no null constructors but
> no arguments were given
> Stupidly, I forgot to save the whole stack trace and the code is now gone
> from my codebase (since I needed it to work). To repeat:
> @Override
> public void configure() {
> bind(EntityManager.class).toInstance(manager);
> }
> Seems wicket-guice is assuming that it needs to create a new instance of
> everything that's injected, and since EntityManager doesn't have a no-args
> constructor, such an action fails. Just an assumption anyway...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1130) Injection of Bound Instance Fails with Exception
[
https://issues.apache.org/jira/browse/WICKET-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634880#action_12634880
]
Tuomas Karkkainen commented on WICKET-1130:
---
injecting concrete classes without zero argument constructor into wicket
components fails, even if the injection is properly configured.
I have this:
public ConcreteClass(String a, String b) { ... }
bind(ConcreteClass.class).toInstance(new ConcreteClass("a","b"));
if I have
@Inject
private ConcreteClass concreteClass
in a wicket component it will not be injected but cglib will complain. If I
have it instead in a secondary dependency guice will inject it fine, which is
confusing. e.g.
public class ConcreteClassHolder {
@Inject
private ConcreteClass concreteClass;
public getConcreteClass(){...}
}
public class SomethingPanel extends Panel{
@Inject
private ConcreteClassHolder concreteClassHolder;
}
Instead of confusingly failing, with a "Superclass has no null constructors but
no arguments were given", I would prefer wicket to atleast check for this
condition in LazyInitProxyFactory:
public static Object createProxy(final Class type, final IProxyTargetLocator
locator) {
...
return e.create();
}
with maybe:
try {
return e.create();
} catch (final IllegalArgumentException iae) {
throw new RuntimeException("Cannot proxy concrete class with no
zero args constructor here, use an interface or see JIRA issue WICKET-1130.");
}
> Injection of Bound Instance Fails with Exception
>
>
> Key: WICKET-1130
> URL: https://issues.apache.org/jira/browse/WICKET-1130
> Project: Wicket
> Issue Type: Bug
> Components: wicket-guice
>Affects Versions: 1.3.0-beta4
>Reporter: Daniel Spiewak
>Assignee: Alastair Maw
> Fix For: 1.5-M1
>
>
> If I try to inject an explicitly bound instance into a component, injection
> fails with an exception in the creation of the CGLIB proxy:
> java.lang.IllegalArgumentException: Superclass has no null constructors but
> no arguments were given
> Stupidly, I forgot to save the whole stack trace and the code is now gone
> from my codebase (since I needed it to work). To repeat:
> @Override
> public void configure() {
> bind(EntityManager.class).toInstance(manager);
> }
> Seems wicket-guice is assuming that it needs to create a new instance of
> everything that's injected, and since EntityManager doesn't have a no-args
> constructor, such an action fails. Just an assumption anyway...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[CONF] Apache Wicket: Community meetups (page edited)
Page Edited : WICKET : Community meetups Community meetups has been edited by Mitch Gitman (Sep 26, 2008). (View changes) Content: Bookmarkable link If you're thinking about organizing a local meetup, don't hesitate to add your initiative to this list! Pictures of past Wicket meetings can be found here: http://flickr.com/photos/tags/wicketmeeting/ There are already efforts to organize meetups in the following countries: United Kingdom Belgium The Netherlands Denmark Sweden Brazil Argentina United States Austria Canada United Kingdom Location: London Regular meetups: The first Wednesday of every other month To register, go here: http://jweekend.co.uk/dev/LWUGReg Belgium Last meetup: JavaPolis'07 (dec 12th-14th) Martijn Dashorst will give a Wicket presentation at the conference. We are interested in a Birds of a Feather (BoF) meeting, and interest can be registered here. When you want to attend, you need to be registered at the conference too. The presentation and BoF will be in English. Name Interested Will come! BoF? Martijn Dashorst x x x Per Ejeklint x x yeah! Xavier Hanin x x x Francis De Brabandere x ? x The Netherlands The excitement in the Netherlands keeps growing check it out: Wicket Community meetups - Amsterdam. Denmark Location: Copenhagen Last meetup: 23 april 16 hrs Next meetup: 15 october 16 hrs @ Jakob Dannefærds Vej 6B, 3. TV 1973 Frederiksberg C Speakers/ areas of interest? Write what you want to hear about here.. Then people can add themselves as speakers content speaker? Wicket Iolite (only if theres interest in it) Nino Creating behaviors (only if theres interest in it) Nino Selling wicket (to your company, and customers) Discussion Go here to sign up: http://wugdk.eventbrite.com/ Sweden Location: Stockholm Next meetup: TBD (no meetups during the summer) Web page: http://wicket.jalbum.net Please also join the google group (at the web page) to receive invitations to the meetups. Location: Malmø / øredev Next meetup: 19-21nov one of the days.. Speakers/ areas of interest? Write what you want to hear about here.. Then people can add themselves as speakers content speaker? Wicket-Spring-JPA-Hibernate Nino TDD/BDD & Wicket! Nino Wicket Performance Discusssion Nino starts it with some tips Creating behaviors/integrating _javascript_ Nino Selling wicket (to your company, and customers) Discussion "something about integrating with some google goodness" Martjin Dashorst Name Interested Will come Language Comments Nino Martinez x Danish,English Brazil Location: Rio de Janeiro Next meetup: to be scheduled Register here or send an e-mail to Alexandre Bairos (alexandre.bairos at gmail.com) and let us know you are interested. Name Interested Will come Language Comments Alexandre Bairos x x Portuguese,English,P Bruno Borges x x Portuguese,English,P João Antonio x x Portuguese,English,P Argentina Location: Buenos Aires Next meetup: to be scheduled Register here or send an e-mail to (fernando.wermus at gmail.com) and let us know you are interested. Name Interested Will come Language Comments Fernando Wermus x x Portuguese,English,Spanish,P Juan G. Arias x x English,Spanish,P Eduardo Constantin x x Portuguese,English,Spanish,P United States Wicket Users Group - Twin Cities Location: Minneapolis, MN Next meetup: to be scheduled (see group website) http://groups.google.com/group/wicket-user-group-twincities Location: Seattle Next meetup: to be scheduled Send an e-mail to Eelco Hillenius (eelco.hillenius at gmail.com) if you'd like to see this happen Name Interested Comments Eelco Hillenius x Jonathan Locke x Eric Crampton x Jose Collas x Mitch Gitman x Location: San Francisco Next meetup: to be scheduled Send an email to Orion Letizi ([EMAIL PROTECTED]) and let us know if you are interested Name Interested Will come Dec. 6 Dec. 14 Comments Orion Letizi x x x x Nick Johnson x x x x Al Maw x Can only make it if between 28th Nov and 12th Dec Julian Sinai x Sehyo Chang x David Pollak x x Enrique Rodriguez x x David Sean Taylor Sean Sullivan x x December 2 through December 6 Niels van Kampenhout x Austria Location: Linz or Hagenberg Next meetup: to be scheduled Send an e-mail to Gerolf Seitz (gerolf.seitz at gmail.com) if you're interested in a "get together" and/or register below Name Interested Will come Comments Gerolf Seitz x x
[jira] Commented: (WICKET-1620) Portlet 2.0 support
[ https://issues.apache.org/jira/browse/WICKET-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634875#action_12634875 ] Antony Stubbs commented on WICKET-1620: --- I see. Are you able to provide that patch as well? Our company will also be working with Wicket and 2.0 portlets and have resource to help improve the project. I.e. I want to help out, and would like to follow the same direction as you. > Portlet 2.0 support > --- > > Key: WICKET-1620 > URL: https://issues.apache.org/jira/browse/WICKET-1620 > Project: Wicket > Issue Type: Improvement > Components: wicket >Reporter: Thijs Vonk >Assignee: Ate Douma > Attachments: portlet2-0.patch, portlet2-0.patch > > > Upgrade wicket to fully support portlet 2.0 (jsr 286; > http://jcp.org/en/jsr/detail?id=286). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1620) Portlet 2.0 support
[ https://issues.apache.org/jira/browse/WICKET-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634869#action_12634869 ] Thijs Vonk commented on WICKET-1620: Yes this is the latest version of this patch. A Wicket-1.3 version of this patch is what we are working with in our product. At the moment I'm not doing any enhancements to this patch, because right now it is doing what we want and I don't have/get time to add any new features. > Portlet 2.0 support > --- > > Key: WICKET-1620 > URL: https://issues.apache.org/jira/browse/WICKET-1620 > Project: Wicket > Issue Type: Improvement > Components: wicket >Reporter: Thijs Vonk >Assignee: Ate Douma > Attachments: portlet2-0.patch, portlet2-0.patch > > > Upgrade wicket to fully support portlet 2.0 (jsr 286; > http://jcp.org/en/jsr/detail?id=286). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1620) Portlet 2.0 support
[ https://issues.apache.org/jira/browse/WICKET-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634848#action_12634848 ] Antony Stubbs commented on WICKET-1620: --- So just to clarify - although this patch is from May, does it represent the current state of the nation for wicket 286 support? Are you working on this at all anymore? > Portlet 2.0 support > --- > > Key: WICKET-1620 > URL: https://issues.apache.org/jira/browse/WICKET-1620 > Project: Wicket > Issue Type: Improvement > Components: wicket >Reporter: Thijs Vonk >Assignee: Ate Douma > Attachments: portlet2-0.patch, portlet2-0.patch > > > Upgrade wicket to fully support portlet 2.0 (jsr 286; > http://jcp.org/en/jsr/detail?id=286). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1620) Portlet 2.0 support
[ https://issues.apache.org/jira/browse/WICKET-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634846#action_12634846 ] Thijs Vonk commented on WICKET-1620: Yes portlet support was introduced in 1.3 This patch is against revision 657619 of wicket-1.4 trunk version, but because this patch is from May, I'm not sure it will patch cleanly on current truck. We are still on 1.3 so I haven't updated 1.4 for a long time > Portlet 2.0 support > --- > > Key: WICKET-1620 > URL: https://issues.apache.org/jira/browse/WICKET-1620 > Project: Wicket > Issue Type: Improvement > Components: wicket >Reporter: Thijs Vonk >Assignee: Ate Douma > Attachments: portlet2-0.patch, portlet2-0.patch > > > Upgrade wicket to fully support portlet 2.0 (jsr 286; > http://jcp.org/en/jsr/detail?id=286). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1620) Portlet 2.0 support
[ https://issues.apache.org/jira/browse/WICKET-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634843#action_12634843 ] Antony Stubbs commented on WICKET-1620: --- Cool, thanks for the info. Isn't Ate's portlet 1.0 support already in Wicket trunk? Also, what version of wicket is this patch generated against? > Portlet 2.0 support > --- > > Key: WICKET-1620 > URL: https://issues.apache.org/jira/browse/WICKET-1620 > Project: Wicket > Issue Type: Improvement > Components: wicket >Reporter: Thijs Vonk >Assignee: Ate Douma > Attachments: portlet2-0.patch, portlet2-0.patch > > > Upgrade wicket to fully support portlet 2.0 (jsr 286; > http://jcp.org/en/jsr/detail?id=286). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1620) Portlet 2.0 support
[ https://issues.apache.org/jira/browse/WICKET-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634840#action_12634840 ] Thijs Vonk commented on WICKET-1620: Well, it's basically Ate's portlet 1 specs implementation with the addition of resourceserving, setting cookies and the like. So almost al you can do in a normal wicket application should work in a portlet as well, so: ajax, forms, serving files, etc should all work. Within the portlet specifications obviously. I haven't tested yet but probably public renderparameters will work as well. A colleague was testing this just last week, however I haven't heard any results yet. But IPC through event handling is not build in yet. And I have no idea when I have time to really dive into this. And there is probably some other things missing as well. Also this patch replaces the portlet 1 implementation, so it's not backwards compatible and there are some discussions if we should have both versions implemented. > Portlet 2.0 support > --- > > Key: WICKET-1620 > URL: https://issues.apache.org/jira/browse/WICKET-1620 > Project: Wicket > Issue Type: Improvement > Components: wicket >Reporter: Thijs Vonk >Assignee: Ate Douma > Attachments: portlet2-0.patch, portlet2-0.patch > > > Upgrade wicket to fully support portlet 2.0 (jsr 286; > http://jcp.org/en/jsr/detail?id=286). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1620) Portlet 2.0 support
[ https://issues.apache.org/jira/browse/WICKET-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634826#action_12634826 ] Antony Stubbs commented on WICKET-1620: --- Hi Thijs, what sort of percentage complete would you say the 286 support is at? > Portlet 2.0 support > --- > > Key: WICKET-1620 > URL: https://issues.apache.org/jira/browse/WICKET-1620 > Project: Wicket > Issue Type: Improvement > Components: wicket >Reporter: Thijs Vonk >Assignee: Ate Douma > Attachments: portlet2-0.patch, portlet2-0.patch > > > Upgrade wicket to fully support portlet 2.0 (jsr 286; > http://jcp.org/en/jsr/detail?id=286). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[CONF] Apache Wicket: Form validation messages (page edited)
Page Edited :
WICKET :
Form validation messages
Form validation messages
has been edited by Matthias Keller
(Sep 26, 2008).
(View changes)
Content:
Some knowledge of wicket property-resource loading is required to understand this article.
As of wicket-1.1 post rc2 there is an easier way to provide validation messages for form components.
In wicket-1.1-rc2 and before the validation messages were provided through resource keys defined as form-id.form-component-id.validator-class-name. This approach entailed a lot of repetitive resource messages. For example, the following form:
Form form=new Form("myform");
form.add(new RequiredTextField("firstname").add(LengthValidator.max(15));
form.add(new RequiredTextField("lastname").add(LengthValidator.max(15));
would have required the following resource keys:
[page-class-name].properties
myform.firstname.RequiredValidator=Field 'customer first name' is required
myform.firstname.LengthValidator=Field 'customer first name' must be between ${min} and ${max} characters
myform.lastname.RequiredValidator=Field 'customer last name' is required
myform.lastname.LengthValidator=Field 'customer last name' must be between ${min} and ${max} characters
Wicket-1.1 post rc2 provides a much simplified approach by introducing the ${label} variable in the validation context which represents the user-centric name of the form component and allows factoring out validator-specific messages into one place.
_IMPORTANT: This only works correctly, when getResourceSettings().getUseDefaultOnMissingResource is true !
The ${label} variable can be provided by one of two ways:
It can either be set directly on the form component instance by calling setLabel(IModel model) method, or by including a resource key of the form form-id.relative_path_to_form-component-id.
IMPORTANT: If your form component is a child of another component (e.g. Border) and isn't being directly added to the form component itself, then you need to use the relative path to the component.
The example above can now be rewritten as following:
Specify the general validator messages:
[webapplication-subclass-name].properties
RequiredValidator=Field '${label}' is required
LengthValidator=Field '${label}' must be between ${min} and ${max} characters
Specify the user-centric form component labels:
[page-class-name].properties
myform.firstname=customer first name
myform.lastname=customer last name
IMPORTANT:
or specify labels directly in java code:
FormComponent firstname=new RequiredTextField("firstname").add(LengthValidator.max(15));
firstname.setLabel(new Model("customer first name"));
form.add(firstname);
FormComponent lastname=new RequiredTextField("lastname").add(LengthValidator.max(15));
lastname.setLabel(new Model("customer last name"));
form.add(lastname);
This approach makes it much simpler to maintain error messages in forms.
Since 1.2 the following features have been added:
Let's say you have the following component hierarchy:
APage
->BForm id="b"
-->XPanel id="x"
>RequiredTextField id="foo"
-->YPanel id="y"
>RequiredTextField id="foo"
XPanel knows nothing about its containing form or page, nevertheless XPanel's validation keys was required to be prefixed with the form's id
XPanel.properties:
b.foo.RequiredValidator = Foo is required.
That introduced an unwanted dependency of XPanel on its parental form (i.e. id="b").
Furthermore there was no way to override the foo messages separately for XPanel and YPanel:
APage.properties:
b.foo.RequiredValidator = Foo is required in x ??
b.foo.RequiredValidator = Foo is required in y ??
That has been changed. The search order has been changed like that:
APage.properties:
b.x.foo.RequiredValidator = Foo is extremely required.
XPanel.properties:
foo.RequiredValidator = Foo is required.
YPanel's validation text could stay unaltered:
YPanel.properties:
foo.RequiredValidator = Foo is required.
Changes in Wicket 1.3
Wether a field is required is now determined by testing the isRequired() method of FormComponent, therefore 'RequiredValidator' in the above examples has to be replaced by 'Required'.
Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request
Unsubscribe or edit your notifications preferences
[jira] Commented: (WICKET-1851) Default lookup keys don't work when UseDefaultOnMissingResource is false
[
https://issues.apache.org/jira/browse/WICKET-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634780#action_12634780
]
Matthias Keller commented on WICKET-1851:
-
The same but even more disturbing applies, if the
ThrowExceptionOnMissingResource setting is true
Then the exception from the first statement is propagated, leading to a
'Unexpected RuntimeException' instead of that the second getString() is tried
first.
There should probably be a further getString() method which doesn't adhere to
the global settings to allow the second statement to execute at all.
> Default lookup keys don't work when UseDefaultOnMissingResource is false
>
>
> Key: WICKET-1851
> URL: https://issues.apache.org/jira/browse/WICKET-1851
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.4
>Reporter: Matthias Keller
>
> When in Application the following is set:
> getResourceSettings().setThrowExceptionOnMissingResource(false);
> getResourceSettings().setUseDefaultOnMissingResource(false);
> then a noisy but very visible message is displayed for every missing
> resource. Unfortunately, calls to getLocalizer().getString() then return
> this warning message instead of the often used default "" for which it is
> being checked afterwards. This leads to the effect that this warning message
> is considered a valid value.
> Example:
> org.apache.wicket.markup.html.form.AbstractSingleSelectChoice ->
> getDefaultChoice(final Object selected)
> There's this code:
> String option = getLocalizer().getString(getId() + ".null", this, "");
> if (Strings.isEmpty(option)) {
> option = getLocalizer().getString("null", this, CHOOSE_ONE);
> }
> With the above settings, the 'null' property is NEVER found, as the first
> call already returns the message "[Warning: String resource for
> 'form.field.null' not found]", which is not empty.
> The expected behaviour though would be to also try to lookup the 'null' value.
> This seems to apply to other classes as well as I for example never got the
> global Required property to work as each form.field.Required property
> returns the error message
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1851) Default lookup keys don't work when UseDefaultOnMissingResource is false
Default lookup keys don't work when UseDefaultOnMissingResource is false
Key: WICKET-1851
URL: https://issues.apache.org/jira/browse/WICKET-1851
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.4
Reporter: Matthias Keller
When in Application the following is set:
getResourceSettings().setThrowExceptionOnMissingResource(false);
getResourceSettings().setUseDefaultOnMissingResource(false);
then a noisy but very visible message is displayed for every missing resource.
Unfortunately, calls to getLocalizer().getString() then return this warning
message instead of the often used default "" for which it is being checked
afterwards. This leads to the effect that this warning message is considered a
valid value.
Example:
org.apache.wicket.markup.html.form.AbstractSingleSelectChoice ->
getDefaultChoice(final Object selected)
There's this code:
String option = getLocalizer().getString(getId() + ".null", this, "");
if (Strings.isEmpty(option)) {
option = getLocalizer().getString("null", this, CHOOSE_ONE);
}
With the above settings, the 'null' property is NEVER found, as the first call
already returns the message "[Warning: String resource for 'form.field.null'
not found]", which is not empty.
The expected behaviour though would be to also try to lookup the 'null' value.
This seems to apply to other classes as well as I for example never got the
global Required property to work as each form.field.Required property
returns the error message
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1850) UrlValidator disallow http://user:passw...@host:port/path urls
UrlValidator disallow http://user:[EMAIL PROTECTED]:port/path urls -- Key: WICKET-1850 URL: https://issues.apache.org/jira/browse/WICKET-1850 Project: Wicket Issue Type: Bug Affects Versions: 1.3.1 Reporter: Alexey Efimov -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1746) gecko: ajax javascript reference rendering problem
[
https://issues.apache.org/jira/browse/WICKET-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634772#action_12634772
]
Erik van Oosten commented on WICKET-1746:
-
As a workaround, add the following behavior to your page (javascript based on
wicket 1.3.4):
private static class WicketAjaxRelativePathFixBehaviour extends AbstractBehavior
{
private static final long serialVersionUID = 1L;
@Override
public void renderHead(IHeaderResponse response)
{
String script = "if (Wicket && Wicket.Ajax &&
Wicket.Ajax.Request) {"+
"Wicket.Ajax.Request.prototype.doGet =
function() {" +
" if (this.precondition()) {" +
" this.transport =
Wicket.Ajax.getTransport();" +
" var url = this.createUrl();" +
" this.log(\"GET\", url);" +
"
Wicket.Ajax.invokePreCallHandlers();" +
" var t = this.transport;" +
" if (t != null) {" +
" t.open(\"GET\", url,
this.async);" +
" t.onreadystatechange =
this.stateChangeCallback.bind(this);" +
" /*set a special flag to
allow server distinguish between ajax and non-ajax requests*/" +
"
t.setRequestHeader(\"Wicket-Ajax\", \"true\");" +
"
t.setRequestHeader(\"Wicket-FocusedElementId\", Wicket.Focus.lastFocusId ||
\"\");" +
"
t.setRequestHeader(\"Accept\", \"text/xml\");" +
" t.send(null);" +
" return true;" +
" } else {" +
" this.failure();" +
" return false;" +
" }" +
" } else {" +
" Wicket.Log.info(\"Ajax GET
stopped because of precondition check, url:\" + this.url);" +
" this.done();" +
" return true;" +
" }" +
"}}";
response.renderOnDomReadyJavascript(script);
}
}
> gecko: ajax javascript reference rendering problem
> --
>
> Key: WICKET-1746
> URL: https://issues.apache.org/jira/browse/WICKET-1746
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4-M2
>Reporter: Jan Loose
>Assignee: Matej Knopp
> Fix For: 1.3.5, 1.4-M4
>
>
> Hi,
> i tried render the javascript as:
> public void renderHead(IHeaderResponse response) {
> response.renderJavascriptReference(contextPath + "js/test.js");
> }
> The test.js is in webapp/js/test.js (out of classpath). All works greatly in
> Opera but in FF (gecko) is there a problem in wicket-ajax.js (the code is
> form trunk version):
> 836: if (Wicket.Browser.isGecko()) {
> 837: var href = document.location.href;
> 838: var lastIndexOf = href.lastIndexOf('/');
> 839: if (lastIndexOf > 0)
> 840: {
> 841: url = href.substring(0,lastIndexOf+1) + url;
> 842:}
> 843:}
> Why is there this fix/workaround? This works only for relative path but for
> absolute is this code broken.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
