date:20081106

Author: ivaynberg
Date: Thu Nov  6 00:06:58 2008
New Revision: 711789

URL: http://svn.apache.org/viewvc?rev=711789view=rev
Log:
WICKET-1898

Modified:

wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/WebRequestCycleProcessor.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/WebRequestCycleProcessor.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/WebRequestCycleProcessor.java?rev=711789r1=711788r2=711789view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/WebRequestCycleProcessor.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/WebRequestCycleProcessor.java
 Thu Nov  6 00:06:58 2008
@@ -34,6 +34,7 @@
 import org.apache.wicket.request.IRequestCodingStrategy;
 import org.apache.wicket.request.RequestParameters;
 import org.apache.wicket.request.target.basic.EmptyAjaxRequestTarget;
+import 
org.apache.wicket.request.target.component.BookmarkablePageRequestTarget;
 import org.apache.wicket.util.string.Strings;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -101,8 +102,7 @@
AccessStackPageMap 
accessStackPageMap = (AccessStackPageMap)pageMap;
if 
(accessStackPageMap.getAccessStack().size()  0)
{
-   final Access access = 
(Access)accessStackPageMap.getAccessStack()
-   .peek();
+   final Access access = 
accessStackPageMap.getAccessStack().peek();
 
final int pageId = 
Integer.parseInt(Strings.firstPathComponent(

requestParameters.getComponentPath(), Component.PATH_SEPARATOR));
@@ -201,12 +201,27 @@
if 
(Application.get().getSecuritySettings().getEnforceMounts() 
requestCodingStrategy.pathForTarget(target) != 
null)
{
-   String msg = Direct access not allowed for 
mounted targets;
-   // the target was mounted, but we got here via 
another path
-   // : deny the request
-   log.error(msg +  [request= + 
requestCycle.getRequest() + ,target= + target +
-   ,session= + Session.get() + ]);
-   throw new 
AbortWithWebErrorCodeException(HttpServletResponse.SC_FORBIDDEN, msg);
+
+   // we make an excepion if the homepage itself 
was mounted, see WICKET-1898
+   boolean homepage = false;
+   if (target instanceof 
BookmarkablePageRequestTarget)
+   {
+   final BookmarkablePageRequestTarget bt 
= (BookmarkablePageRequestTarget)target;
+   if 
(bt.getPageClass().equals(Application.get().getHomePage()))
+   {
+   homepage = true;
+   }
+   }
+
+   if (!homepage)
+   {
+   String msg = Direct access not allowed 
for mounted targets;
+   // the target was mounted, but we got 
here via another path
+   // : deny the request
+   log.error(msg +  [request= + 
requestCycle.getRequest() + ,target= + target +
+   ,session= + Session.get() + 
]);
+   throw new 
AbortWithWebErrorCodeException(HttpServletResponse.SC_FORBIDDEN, msg);
+   }
}
}
 
@@ -225,6 +240,7 @@
/**
 * @see 
org.apache.wicket.request.AbstractRequestCycleProcessor#newRequestCodingStrategy()
 */
+   @Override
protected IRequestCodingStrategy newRequestCodingStrategy()
{
return new WebRequestCodingStrategy();

[jira] Resolved: (WICKET-1898) WebRequestCycleProcessor.resolveHomePageTarget for empty path with enforceMounts=true provokes 403 - Direct access not allowed for mounted targets


 [ 
https://issues.apache.org/jira/browse/WICKET-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1898.
---

   Resolution: Fixed
Fix Version/s: 1.4-RC2
 Assignee: Igor Vaynberg

i added a check that excludes a bookmarkablepagerequesttarget if it points to 
the same page class as the homepage.

 WebRequestCycleProcessor.resolveHomePageTarget for empty path with 
 enforceMounts=true provokes 403 - Direct access not allowed for mounted 
 targets
 

 Key: WICKET-1898
 URL: https://issues.apache.org/jira/browse/WICKET-1898
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.4-M3
 Environment: Wicket 1.4-m3
Reporter: Oliver Matz
Assignee: Igor Vaynberg
 Fix For: 1.4-RC2


 Scenario: WebApplication.getHomePage() returns a page that is also mounted to 
 a non-empty path by WebApplication.mountBookmarkablePage(). Besides, we have 
 getSecuritySettings().setEnforceMounts(true).  Upon a request for the 
 servlet's root URL (i.e., with requestParameters.getPath()==), the method
 WebRequestCycleProcessor.resolve will throw a 
 AbortWithWebErrorCodeException(403) with error message Direct access not 
 allowed for mounted targets.
 This is because WebRequestCycleProcessor.resolveHomePageTarget correctly 
 returns a non-null target, so that the else-branch starting in line 190 of 
 file WebRequestCycleProcessor.java is reached.  
 The comment says a target was found, but not by looking up a mount, which 
 is misleading, because the szenario should desirably work even though 
 property enforceMounts has been set to true.
 The only (terrible) workaound I have found is to override 
 WebRequestCycleProcessor.resolveHomePageTarget() to return null and establish 
 a home-page-like thing by overriding 
 WebRequestCodingStrategy.urlCodingStrategyForPath() for the empty path.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

svn commit: r711792 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/Strings.java

Author: ivaynberg
Date: Thu Nov  6 00:17:13 2008
New Revision: 711792

URL: http://svn.apache.org/viewvc?rev=711792view=rev
Log:
WICKET-1871

Modified:

wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/Strings.java

Modified: 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/Strings.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/Strings.java?rev=711792r1=711791r2=711792view=diff
==
--- 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/Strings.java
 (original)
+++ 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/Strings.java
 Thu Nov  6 00:17:13 2008
@@ -903,6 +903,14 @@
{
ixEnd = path.length();
}
+
+   if (ixEnd  ixSemiColon)
+   {
+   // ? is before ; - no jsessionid in the url
+   return url.toString();
+   }
+
+
path.delete(ixSemiColon, ixEnd);
}
return path.toString();

svn commit: r711793 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/Strings.java

Author: ivaynberg
Date: Thu Nov  6 00:17:54 2008
New Revision: 711793

URL: http://svn.apache.org/viewvc?rev=711793view=rev
Log:
WICKET-1871

Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/Strings.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/Strings.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/Strings.java?rev=711793r1=711792r2=711793view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/Strings.java 
(original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/Strings.java 
Thu Nov  6 00:17:54 2008
@@ -890,7 +890,7 @@
{
int ixEnd = path.indexOf(?);
 
-   if (ixEnd  ixSemiColon)
+   if (ixEnd = ixSemiColon)
{
// ? is before ; - no jsessionid in the url
return url.toString();

svn commit: r711794 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/Strings.java

Author: ivaynberg
Date: Thu Nov  6 00:18:22 2008
New Revision: 711794

URL: http://svn.apache.org/viewvc?rev=711794view=rev
Log:
WICKET-1871

Modified:

wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/Strings.java

Modified: 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/Strings.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/Strings.java?rev=711794r1=711793r2=711794view=diff
==
--- 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/Strings.java
 (original)
+++ 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/string/Strings.java
 Thu Nov  6 00:18:22 2008
@@ -899,17 +899,18 @@
if (ixSemiColon != -1)
{
int ixEnd = path.indexOf(?);
-   if (ixEnd == -1)
-   {
-   ixEnd = path.length();
-   }
 
-   if (ixEnd  ixSemiColon)
+
+   if (ixEnd = ixSemiColon)
{
// ? is before ; - no jsessionid in the url
return url.toString();
}
 
+   if (ixEnd == -1)
+   {
+   ixEnd = path.length();
+   }
 
path.delete(ixSemiColon, ixEnd);
}

[jira] Resolved: (WICKET-1871) org.apache.wicket.util.string.Strings#stripJSessionId StringIndexOutOfBoundsException


 [ 
https://issues.apache.org/jira/browse/WICKET-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1871.
---

   Resolution: Fixed
Fix Version/s: 1.4-RC2
   1.3.6
 Assignee: Igor Vaynberg

 org.apache.wicket.util.string.Strings#stripJSessionId 
 StringIndexOutOfBoundsException
 -

 Key: WICKET-1871
 URL: https://issues.apache.org/jira/browse/WICKET-1871
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.4
 Environment: windows XP, jetty
Reporter: ywtsang
Assignee: Igor Vaynberg
 Fix For: 1.3.6, 1.4-RC2


 input:
 http://abc.com/xx/yy.html?code=a%E2%8C%A9=enamp;section=DDDamp;d=173amp;
 passing the about input to method
 org.apache.wicket.util.string.Strings#stripJSessionId
 will introduce StringIndexOutOfBoundsException
 because ? appears before ;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

svn commit: r711791 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/Strings.java

Author: ivaynberg
Date: Thu Nov  6 00:16:34 2008
New Revision: 711791

URL: http://svn.apache.org/viewvc?rev=711791view=rev
Log:
WICKET-1871

Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/Strings.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/Strings.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/Strings.java?rev=711791r1=711790r2=711791view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/Strings.java 
(original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/Strings.java 
Thu Nov  6 00:16:34 2008
@@ -889,6 +889,13 @@
if (ixSemiColon != -1)
{
int ixEnd = path.indexOf(?);
+
+   if (ixEnd  ixSemiColon)
+   {
+   // ? is before ; - no jsessionid in the url
+   return url.toString();
+   }
+
if (ixEnd == -1)
{
ixEnd = path.length();

[jira] Created: (WICKET-1915) wicket:message broken in repeaters

2008-11-06 Thread JIRA

wicket:message broken in repeaters
--

 Key: WICKET-1915
 URL: https://issues.apache.org/jira/browse/WICKET-1915
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.5
 Environment: Wicket 1.3.5, tomcat 5.5, but should have the same 
behavior with any container
Reporter: Piller Sébastien
Priority: Minor


The behavior described here: 
http://cwiki.apache.org/WICKET/wickets-xhtml-tags.html (use wicket:message as 
attribute) sometimes doesn't work, depending on the hierarchy and the tag where 
it applies.

I've reproduced it using a repeater and applying wicket:message it to a td 
tag.

Instead of correctly modifying the attribute, it throws the usual 
MarkupException WicketMessage: Unable to find component with id 'label' in 
[MarkupContainer

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1915) wicket:message broken in repeaters

2008-11-06 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/WICKET-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Piller Sébastien updated WICKET-1915:
-

Attachment: WicketMessage.zip

QuickStart eclipse project that shows the problem

 wicket:message broken in repeaters
 --

 Key: WICKET-1915
 URL: https://issues.apache.org/jira/browse/WICKET-1915
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.5
 Environment: Wicket 1.3.5, tomcat 5.5, but should have the same 
 behavior with any container
Reporter: Piller Sébastien
Priority: Minor
 Attachments: WicketMessage.zip


 The behavior described here: 
 http://cwiki.apache.org/WICKET/wickets-xhtml-tags.html (use wicket:message as 
 attribute) sometimes doesn't work, depending on the hierarchy and the tag 
 where it applies.
 I've reproduced it using a repeater and applying wicket:message it to a td 
 tag.
 Instead of correctly modifying the attribute, it throws the usual 
 MarkupException WicketMessage: Unable to find component with id 'label' in 
 [MarkupContainer

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1915) wicket:message sometimes broken

2008-11-06 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/WICKET-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Piller Sébastien updated WICKET-1915:
-

Summary: wicket:message sometimes broken  (was: wicket:message broken in 
repeaters)

 wicket:message sometimes broken
 ---

 Key: WICKET-1915
 URL: https://issues.apache.org/jira/browse/WICKET-1915
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.5
 Environment: Wicket 1.3.5, tomcat 5.5, but should have the same 
 behavior with any container
Reporter: Piller Sébastien
Priority: Minor
 Attachments: WicketMessage.zip


 The behavior described here: 
 http://cwiki.apache.org/WICKET/wickets-xhtml-tags.html (use wicket:message as 
 attribute) sometimes doesn't work, depending on the hierarchy and the tag 
 where it applies.
 I've reproduced it using a repeater and applying wicket:message it to a td 
 tag.
 Instead of correctly modifying the attribute, it throws the usual 
 MarkupException WicketMessage: Unable to find component with id 'label' in 
 [MarkupContainer

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-1911) setRequestTarget(ResourceStreamRequestTarget) doesn't work with AJAX

2008-11-06 Thread Adriano dos Santos Fernandes (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12645450#action_12645450
 ] 

Adriano dos Santos Fernandes commented on WICKET-1911:
--

Igor, if this is not supported use case, I think at least an exception should 
be thrown at appropriate place.

 setRequestTarget(ResourceStreamRequestTarget) doesn't work with AJAX
 

 Key: WICKET-1911
 URL: https://issues.apache.org/jira/browse/WICKET-1911
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.4-M3
 Environment: Win32 / Tomcat or Jetty
Reporter: Adriano dos Santos Fernandes
Assignee: Igor Vaynberg
 Attachments: ajax-resource-redirect.zip


 In test case attached, you see:
 RequestCycle.get().setRequestTarget(new ResourceStreamRequestTarget(
 new MyWebResource().getResourceStream()));
 doesn't work when clicking the AJAX link. The content is displayed inside the 
 AJAX Debug Window instead of redirect the page.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (WICKET-1918) Automatically Load JavaScript files based on name matching

2008-11-06 Thread Christopher J Lyth (JIRA)

Automatically Load JavaScript files based on name matching
--

 Key: WICKET-1918
 URL: https://issues.apache.org/jira/browse/WICKET-1918
 Project: Wicket
  Issue Type: New Feature
  Components: wicket
Reporter: Christopher J Lyth
Priority: Minor


This is similar to WICKET-1917. I would like to add a feature to add JS files 
based on name matching. I dont think this needs the same skinning feature as 
the CSS component but it might.

 I imagine someone might preform different dynamic HTML sort of effects based 
on which skin is selected.

BasePage.java
BasePage.properties
BasePage.html

(from WICKET-1917)
BasePage.css 
BasePage_chrome.css

BasePage.js
BasePage_chrome.js

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1917) Automatically Load CSS files based on name matching

2008-11-06 Thread Christopher J Lyth (JIRA)

[
https://issues.apache.org/jira/browse/WICKET-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Christopher J Lyth updated WICKET-1917:
---

Description:
I often find myself adding CSS files to wicket with the same name as my pages
(i.e. BasePage.css). I then have to add the reference through an html link or a
header contributer. I would like to load these automatically in a similar manor
as the properties files.

I feel this should be expanded to include the ability to skin the application
in the following manor.

BasePage.css
BasePage_chrome.css
BasePage_metal.css

I would also recommend setting this in a similar manor to other patterns in
wicket. It would use the closest name match by default (i.e. BasePage.css). I
imagine this could also be set by system property (wicket.skin) or
programatically.

was:
I often find myself adding CSS files to wicket with the same name as my pages
(i.e. BasePage.css). I then have to add the reference through an html link or a
header contributer. I would like to load these automatically in a similar manor
as the properties files.

I feel this should be expanded to include the ability to skin the application
in the following manor.

BasePage.css
BasePage_chrome.css
BasePage_metal.css

Automatically Load CSS files based on name matching
---

Key: WICKET-1917
URL: https://issues.apache.org/jira/browse/WICKET-1917
Project: Wicket
Issue Type: New Feature
Components: wicket
Reporter: Christopher J Lyth
Priority: Minor

I often find myself adding CSS files to wicket with the same name as my pages
(i.e. BasePage.css). I then have to add the reference through an html link or
a header contributer. I would like to load these automatically in a similar
manor as the properties files.
I feel this should be expanded to include the ability to skin the application
in the following manor.
BasePage.css
BasePage_chrome.css
BasePage_metal.css
I would also recommend setting this in a similar manor to other patterns in
wicket. It would use the closest name match by default (i.e. BasePage.css). I
imagine this could also be set by system property (wicket.skin) or
programatically.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (WICKET-1919) MarkupContainer.setEnabled() doesn't enable/disable child components

MarkupContainer.setEnabled() doesn't enable/disable child components


 Key: WICKET-1919
 URL: https://issues.apache.org/jira/browse/WICKET-1919
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.4-M3, 1.3.3
Reporter: Sergey Derugo
 Fix For: 1.4-RC2


# Create any components that is derived from MarkupContainer, for example, 
create Panel. 
# Put some components to the Panel, for example, TextInput, Label etc.
# Call panel.setEnabled(false) 

Result: all controls on panel are still disabled.

Notes: after some investigation I found that MarkupContainer doesn't override 
setEnabled and therefore it cannot enable/disable components stored in the 
container. 

Workaround: manually disable all components that are displayed on the panel, 
for example:
public void setEnabledForChildren(boolean enabled) {
setEnabledRecursive(this, enabled);
}

private void setEnabledRecursive(MarkupContainer container, boolean 
enabled) {
Iterator? extends Component iterator = container.iterator();
while (iterator.hasNext()) {
Component component = iterator.next();
component.setEnabled(enabled);

if (component instanceof MarkupContainer) {
setEnabledRecursive((MarkupContainer) component, enabled);
}
}
}

I think that MarkupContainer must be responsible for disabling/enabling child 
components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1919) MarkupContainer.setEnabled() doesn't enable/disable child components


 [ 
https://issues.apache.org/jira/browse/WICKET-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Derugo updated WICKET-1919:
--

Description: 
1. Create any components that is derived from MarkupContainer, for example, 
create Panel. 
2. Put some components to the Panel, for example, TextInput, Label etc.
3. Call panel.setEnabled(false) 

Result: all controls on panel are still disabled.

Notes: after some investigation I found that MarkupContainer doesn't override 
setEnabled and therefore it cannot enable/disable components stored in the 
container. 

Workaround: manually disable all components that are displayed on the panel, 
for example:
public void setEnabledForChildren(boolean enabled) {
setEnabledRecursive(this, enabled);
}

private void setEnabledRecursive(MarkupContainer container, boolean 
enabled) {
Iterator? extends Component iterator = container.iterator();
while (iterator.hasNext()) {
Component component = iterator.next();
component.setEnabled(enabled);

if (component instanceof MarkupContainer) {
setEnabledRecursive((MarkupContainer) component, enabled);
}
}
}

I think that MarkupContainer must be responsible for disabling/enabling child 
components.

  was:
# Create any components that is derived from MarkupContainer, for example, 
create Panel. 
# Put some components to the Panel, for example, TextInput, Label etc.
# Call panel.setEnabled(false) 

Result: all controls on panel are still disabled.

Notes: after some investigation I found that MarkupContainer doesn't override 
setEnabled and therefore it cannot enable/disable components stored in the 
container. 

Workaround: manually disable all components that are displayed on the panel, 
for example:
public void setEnabledForChildren(boolean enabled) {
setEnabledRecursive(this, enabled);
}

private void setEnabledRecursive(MarkupContainer container, boolean 
enabled) {
Iterator? extends Component iterator = container.iterator();
while (iterator.hasNext()) {
Component component = iterator.next();
component.setEnabled(enabled);

if (component instanceof MarkupContainer) {
setEnabledRecursive((MarkupContainer) component, enabled);
}
}
}

I think that MarkupContainer must be responsible for disabling/enabling child 
components.


 MarkupContainer.setEnabled() doesn't enable/disable child components
 

 Key: WICKET-1919
 URL: https://issues.apache.org/jira/browse/WICKET-1919
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3, 1.4-M3
Reporter: Sergey Derugo
 Fix For: 1.4-RC2


 1. Create any components that is derived from MarkupContainer, for example, 
 create Panel. 
 2. Put some components to the Panel, for example, TextInput, Label etc.
 3. Call panel.setEnabled(false) 
 Result: all controls on panel are still disabled.
 Notes: after some investigation I found that MarkupContainer doesn't override 
 setEnabled and therefore it cannot enable/disable components stored in the 
 container. 
 Workaround: manually disable all components that are displayed on the panel, 
 for example:
 public void setEnabledForChildren(boolean enabled) {
 setEnabledRecursive(this, enabled);
 }
 private void setEnabledRecursive(MarkupContainer container, boolean 
 enabled) {
 Iterator? extends Component iterator = container.iterator();
 while (iterator.hasNext()) {
 Component component = iterator.next();
 component.setEnabled(enabled);
 if (component instanceof MarkupContainer) {
 setEnabledRecursive((MarkupContainer) component, enabled);
 }
 }
 }
 I think that MarkupContainer must be responsible for disabling/enabling child 
 components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1919) MarkupContainer.setEnabled() doesn't enable/disable child components


 [ 
https://issues.apache.org/jira/browse/WICKET-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Derugo updated WICKET-1919:
--

Description: 
1. Create any components that is derived from MarkupContainer, for example, 
create Panel. 
2. Put some components to the Panel, for example, TextInput, Label etc.
3. Call panel.setEnabled(false) 

Result: all controls on panel are still enabled.

Notes: after some investigation I found that MarkupContainer doesn't override 
setEnabled and therefore it cannot enable/disable components stored in the 
container. 

Workaround: manually disable all components that are displayed on the panel, 
for example:
public void setEnabledForChildren(boolean enabled) {
setEnabledRecursive(this, enabled);
}

private void setEnabledRecursive(MarkupContainer container, boolean 
enabled) {
Iterator? extends Component iterator = container.iterator();
while (iterator.hasNext()) {
Component component = iterator.next();
component.setEnabled(enabled);

if (component instanceof MarkupContainer) {
setEnabledRecursive((MarkupContainer) component, enabled);
}
}
}

I think that MarkupContainer must be responsible for disabling/enabling child 
components.

  was:
1. Create any components that is derived from MarkupContainer, for example, 
create Panel. 
2. Put some components to the Panel, for example, TextInput, Label etc.
3. Call panel.setEnabled(false) 

Result: all controls on panel are still disabled.

Notes: after some investigation I found that MarkupContainer doesn't override 
setEnabled and therefore it cannot enable/disable components stored in the 
container. 

Workaround: manually disable all components that are displayed on the panel, 
for example:
public void setEnabledForChildren(boolean enabled) {
setEnabledRecursive(this, enabled);
}

private void setEnabledRecursive(MarkupContainer container, boolean 
enabled) {
Iterator? extends Component iterator = container.iterator();
while (iterator.hasNext()) {
Component component = iterator.next();
component.setEnabled(enabled);

if (component instanceof MarkupContainer) {
setEnabledRecursive((MarkupContainer) component, enabled);
}
}
}

I think that MarkupContainer must be responsible for disabling/enabling child 
components.


 MarkupContainer.setEnabled() doesn't enable/disable child components
 

 Key: WICKET-1919
 URL: https://issues.apache.org/jira/browse/WICKET-1919
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3, 1.4-M3
Reporter: Sergey Derugo
 Fix For: 1.4-RC2


 1. Create any components that is derived from MarkupContainer, for example, 
 create Panel. 
 2. Put some components to the Panel, for example, TextInput, Label etc.
 3. Call panel.setEnabled(false) 
 Result: all controls on panel are still enabled.
 Notes: after some investigation I found that MarkupContainer doesn't override 
 setEnabled and therefore it cannot enable/disable components stored in the 
 container. 
 Workaround: manually disable all components that are displayed on the panel, 
 for example:
 public void setEnabledForChildren(boolean enabled) {
 setEnabledRecursive(this, enabled);
 }
 private void setEnabledRecursive(MarkupContainer container, boolean 
 enabled) {
 Iterator? extends Component iterator = container.iterator();
 while (iterator.hasNext()) {
 Component component = iterator.next();
 component.setEnabled(enabled);
 if (component instanceof MarkupContainer) {
 setEnabledRecursive((MarkupContainer) component, enabled);
 }
 }
 }
 I think that MarkupContainer must be responsible for disabling/enabling child 
 components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1919) MarkupContainer.setEnabled() doesn't enable/disable child components


 [ 
https://issues.apache.org/jira/browse/WICKET-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Derugo updated WICKET-1919:
--

Attachment: PanelTestPage.html

 MarkupContainer.setEnabled() doesn't enable/disable child components
 

 Key: WICKET-1919
 URL: https://issues.apache.org/jira/browse/WICKET-1919
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3, 1.4-M3
Reporter: Sergey Derugo
 Fix For: 1.4-RC2

 Attachments: MyPanel.html, MyPanel.java, PanelTestPage.html


 1. Create any components that is derived from MarkupContainer, for example, 
 create Panel. 
 2. Put some components to the Panel, for example, TextInput, Label etc.
 3. Call panel.setEnabled(false) 
 Result: all controls on panel are still enabled.
 Notes: after some investigation I found that MarkupContainer doesn't override 
 setEnabled and therefore it cannot enable/disable components stored in the 
 container. 
 Workaround: manually disable all components that are displayed on the panel, 
 for example:
 public void setEnabledForChildren(boolean enabled) {
 setEnabledRecursive(this, enabled);
 }
 private void setEnabledRecursive(MarkupContainer container, boolean 
 enabled) {
 Iterator? extends Component iterator = container.iterator();
 while (iterator.hasNext()) {
 Component component = iterator.next();
 component.setEnabled(enabled);
 if (component instanceof MarkupContainer) {
 setEnabledRecursive((MarkupContainer) component, enabled);
 }
 }
 }
 I think that MarkupContainer must be responsible for disabling/enabling child 
 components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1919) MarkupContainer.setEnabled() doesn't enable/disable child components


 [ 
https://issues.apache.org/jira/browse/WICKET-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Derugo updated WICKET-1919:
--

Attachment: MyPanel.java

 MarkupContainer.setEnabled() doesn't enable/disable child components
 

 Key: WICKET-1919
 URL: https://issues.apache.org/jira/browse/WICKET-1919
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3, 1.4-M3
Reporter: Sergey Derugo
 Fix For: 1.4-RC2

 Attachments: MyPanel.html, MyPanel.java, PanelTestPage.html


 1. Create any components that is derived from MarkupContainer, for example, 
 create Panel. 
 2. Put some components to the Panel, for example, TextInput, Label etc.
 3. Call panel.setEnabled(false) 
 Result: all controls on panel are still enabled.
 Notes: after some investigation I found that MarkupContainer doesn't override 
 setEnabled and therefore it cannot enable/disable components stored in the 
 container. 
 Workaround: manually disable all components that are displayed on the panel, 
 for example:
 public void setEnabledForChildren(boolean enabled) {
 setEnabledRecursive(this, enabled);
 }
 private void setEnabledRecursive(MarkupContainer container, boolean 
 enabled) {
 Iterator? extends Component iterator = container.iterator();
 while (iterator.hasNext()) {
 Component component = iterator.next();
 component.setEnabled(enabled);
 if (component instanceof MarkupContainer) {
 setEnabledRecursive((MarkupContainer) component, enabled);
 }
 }
 }
 I think that MarkupContainer must be responsible for disabling/enabling child 
 components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1919) MarkupContainer.setEnabled() doesn't enable/disable child components


 [ 
https://issues.apache.org/jira/browse/WICKET-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Derugo updated WICKET-1919:
--

Attachment: MyPanel.html

 MarkupContainer.setEnabled() doesn't enable/disable child components
 

 Key: WICKET-1919
 URL: https://issues.apache.org/jira/browse/WICKET-1919
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3, 1.4-M3
Reporter: Sergey Derugo
 Fix For: 1.4-RC2

 Attachments: MyPanel.html, MyPanel.java, PanelTestPage.html


 1. Create any components that is derived from MarkupContainer, for example, 
 create Panel. 
 2. Put some components to the Panel, for example, TextInput, Label etc.
 3. Call panel.setEnabled(false) 
 Result: all controls on panel are still enabled.
 Notes: after some investigation I found that MarkupContainer doesn't override 
 setEnabled and therefore it cannot enable/disable components stored in the 
 container. 
 Workaround: manually disable all components that are displayed on the panel, 
 for example:
 public void setEnabledForChildren(boolean enabled) {
 setEnabledRecursive(this, enabled);
 }
 private void setEnabledRecursive(MarkupContainer container, boolean 
 enabled) {
 Iterator? extends Component iterator = container.iterator();
 while (iterator.hasNext()) {
 Component component = iterator.next();
 component.setEnabled(enabled);
 if (component instanceof MarkupContainer) {
 setEnabledRecursive((MarkupContainer) component, enabled);
 }
 }
 }
 I think that MarkupContainer must be responsible for disabling/enabling child 
 components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1919) MarkupContainer.setEnabled() doesn't enable/disable child components


 [ 
https://issues.apache.org/jira/browse/WICKET-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Derugo updated WICKET-1919:
--

Attachment: (was: MyPanel.html)

 MarkupContainer.setEnabled() doesn't enable/disable child components
 

 Key: WICKET-1919
 URL: https://issues.apache.org/jira/browse/WICKET-1919
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3, 1.4-M3
Reporter: Sergey Derugo
 Fix For: 1.4-RC2

 Attachments: src.zip


 1. Create any components that is derived from MarkupContainer, for example, 
 create Panel. 
 2. Put some components to the Panel, for example, TextInput, Label etc.
 3. Call panel.setEnabled(false) 
 Result: all controls on panel are still enabled.
 Notes: after some investigation I found that MarkupContainer doesn't override 
 setEnabled and therefore it cannot enable/disable components stored in the 
 container. 
 Workaround: manually disable all components that are displayed on the panel, 
 for example:
 public void setEnabledForChildren(boolean enabled) {
 setEnabledRecursive(this, enabled);
 }
 private void setEnabledRecursive(MarkupContainer container, boolean 
 enabled) {
 Iterator? extends Component iterator = container.iterator();
 while (iterator.hasNext()) {
 Component component = iterator.next();
 component.setEnabled(enabled);
 if (component instanceof MarkupContainer) {
 setEnabledRecursive((MarkupContainer) component, enabled);
 }
 }
 }
 I think that MarkupContainer must be responsible for disabling/enabling child 
 components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Issue Comment Edited: (WICKET-1919) MarkupContainer.setEnabled() doesn't enable/disable child components


[ 
https://issues.apache.org/jira/browse/WICKET-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12645487#action_12645487
 ] 

xsergey edited comment on WICKET-1919 at 11/6/08 7:02 AM:


In the attachment(src.zip) you can find simple test case

  was (Author: xsergey):
In the attachment [^src.zip] you can find simple test case
  
 MarkupContainer.setEnabled() doesn't enable/disable child components
 

 Key: WICKET-1919
 URL: https://issues.apache.org/jira/browse/WICKET-1919
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3, 1.4-M3
Reporter: Sergey Derugo
 Fix For: 1.4-RC2

 Attachments: src.zip


 1. Create any components that is derived from MarkupContainer, for example, 
 create Panel. 
 2. Put some components to the Panel, for example, TextInput, Label etc.
 3. Call panel.setEnabled(false) 
 Result: all controls on panel are still enabled.
 Notes: after some investigation I found that MarkupContainer doesn't override 
 setEnabled and therefore it cannot enable/disable components stored in the 
 container. 
 Workaround: manually disable all components that are displayed on the panel, 
 for example:
 public void setEnabledForChildren(boolean enabled) {
 setEnabledRecursive(this, enabled);
 }
 private void setEnabledRecursive(MarkupContainer container, boolean 
 enabled) {
 Iterator? extends Component iterator = container.iterator();
 while (iterator.hasNext()) {
 Component component = iterator.next();
 component.setEnabled(enabled);
 if (component instanceof MarkupContainer) {
 setEnabledRecursive((MarkupContainer) component, enabled);
 }
 }
 }
 I think that MarkupContainer must be responsible for disabling/enabling child 
 components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-1919) MarkupContainer.setEnabled() doesn't enable/disable child components


[ 
https://issues.apache.org/jira/browse/WICKET-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12645487#action_12645487
 ] 

Sergey Derugo commented on WICKET-1919:
---

In the attachment [^src.zip] you can find simple test case

 MarkupContainer.setEnabled() doesn't enable/disable child components
 

 Key: WICKET-1919
 URL: https://issues.apache.org/jira/browse/WICKET-1919
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3, 1.4-M3
Reporter: Sergey Derugo
 Fix For: 1.4-RC2

 Attachments: src.zip


 1. Create any components that is derived from MarkupContainer, for example, 
 create Panel. 
 2. Put some components to the Panel, for example, TextInput, Label etc.
 3. Call panel.setEnabled(false) 
 Result: all controls on panel are still enabled.
 Notes: after some investigation I found that MarkupContainer doesn't override 
 setEnabled and therefore it cannot enable/disable components stored in the 
 container. 
 Workaround: manually disable all components that are displayed on the panel, 
 for example:
 public void setEnabledForChildren(boolean enabled) {
 setEnabledRecursive(this, enabled);
 }
 private void setEnabledRecursive(MarkupContainer container, boolean 
 enabled) {
 Iterator? extends Component iterator = container.iterator();
 while (iterator.hasNext()) {
 Component component = iterator.next();
 component.setEnabled(enabled);
 if (component instanceof MarkupContainer) {
 setEnabledRecursive((MarkupContainer) component, enabled);
 }
 }
 }
 I think that MarkupContainer must be responsible for disabling/enabling child 
 components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-1911) setRequestTarget(ResourceStreamRequestTarget) doesn't work with AJAX


[ 
https://issues.apache.org/jira/browse/WICKET-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12645490#action_12645490
 ] 

Igor Vaynberg commented on WICKET-1911:
---

problem with throwing an exception is that it is hard to tell if we need one. 
people write their own request targets that do work with ajax, so how do we 
know? a possible solution is to have a tagging interface for ajax targets, but 
that gets kinda messy imho.

 setRequestTarget(ResourceStreamRequestTarget) doesn't work with AJAX
 

 Key: WICKET-1911
 URL: https://issues.apache.org/jira/browse/WICKET-1911
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.4-M3
 Environment: Win32 / Tomcat or Jetty
Reporter: Adriano dos Santos Fernandes
Assignee: Igor Vaynberg
 Attachments: ajax-resource-redirect.zip


 In test case attached, you see:
 RequestCycle.get().setRequestTarget(new ResourceStreamRequestTarget(
 new MyWebResource().getResourceStream()));
 doesn't work when clicking the AJAX link. The content is displayed inside the 
 AJAX Debug Window instead of redirect the page.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1919) MarkupContainer.setEnabled() doesn't enable/disable child components


 [ 
https://issues.apache.org/jira/browse/WICKET-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Derugo updated WICKET-1919:
--

Attachment: src.zip

 MarkupContainer.setEnabled() doesn't enable/disable child components
 

 Key: WICKET-1919
 URL: https://issues.apache.org/jira/browse/WICKET-1919
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3, 1.4-M3
Reporter: Sergey Derugo
 Fix For: 1.4-RC2

 Attachments: src.zip


 1. Create any components that is derived from MarkupContainer, for example, 
 create Panel. 
 2. Put some components to the Panel, for example, TextInput, Label etc.
 3. Call panel.setEnabled(false) 
 Result: all controls on panel are still enabled.
 Notes: after some investigation I found that MarkupContainer doesn't override 
 setEnabled and therefore it cannot enable/disable components stored in the 
 container. 
 Workaround: manually disable all components that are displayed on the panel, 
 for example:
 public void setEnabledForChildren(boolean enabled) {
 setEnabledRecursive(this, enabled);
 }
 private void setEnabledRecursive(MarkupContainer container, boolean 
 enabled) {
 Iterator? extends Component iterator = container.iterator();
 while (iterator.hasNext()) {
 Component component = iterator.next();
 component.setEnabled(enabled);
 if (component instanceof MarkupContainer) {
 setEnabledRecursive((MarkupContainer) component, enabled);
 }
 }
 }
 I think that MarkupContainer must be responsible for disabling/enabling child 
 components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1919) MarkupContainer.setEnabled() doesn't enable/disable child components


 [ 
https://issues.apache.org/jira/browse/WICKET-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Derugo updated WICKET-1919:
--

Attachment: (was: PanelTestPage.html)

 MarkupContainer.setEnabled() doesn't enable/disable child components
 

 Key: WICKET-1919
 URL: https://issues.apache.org/jira/browse/WICKET-1919
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3, 1.4-M3
Reporter: Sergey Derugo
 Fix For: 1.4-RC2

 Attachments: src.zip


 1. Create any components that is derived from MarkupContainer, for example, 
 create Panel. 
 2. Put some components to the Panel, for example, TextInput, Label etc.
 3. Call panel.setEnabled(false) 
 Result: all controls on panel are still enabled.
 Notes: after some investigation I found that MarkupContainer doesn't override 
 setEnabled and therefore it cannot enable/disable components stored in the 
 container. 
 Workaround: manually disable all components that are displayed on the panel, 
 for example:
 public void setEnabledForChildren(boolean enabled) {
 setEnabledRecursive(this, enabled);
 }
 private void setEnabledRecursive(MarkupContainer container, boolean 
 enabled) {
 Iterator? extends Component iterator = container.iterator();
 while (iterator.hasNext()) {
 Component component = iterator.next();
 component.setEnabled(enabled);
 if (component instanceof MarkupContainer) {
 setEnabledRecursive((MarkupContainer) component, enabled);
 }
 }
 }
 I think that MarkupContainer must be responsible for disabling/enabling child 
 components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (WICKET-1919) MarkupContainer.setEnabled() doesn't enable/disable child components


 [ 
https://issues.apache.org/jira/browse/WICKET-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg reassigned WICKET-1919:
-

Assignee: Igor Vaynberg

 MarkupContainer.setEnabled() doesn't enable/disable child components
 

 Key: WICKET-1919
 URL: https://issues.apache.org/jira/browse/WICKET-1919
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3, 1.4-M3
Reporter: Sergey Derugo
Assignee: Igor Vaynberg
 Fix For: 1.4-RC2

 Attachments: src.zip


 1. Create any components that is derived from MarkupContainer, for example, 
 create Panel. 
 2. Put some components to the Panel, for example, TextInput, Label etc.
 3. Call panel.setEnabled(false) 
 Result: all controls on panel are still enabled.
 Notes: after some investigation I found that MarkupContainer doesn't override 
 setEnabled and therefore it cannot enable/disable components stored in the 
 container. 
 Workaround: manually disable all components that are displayed on the panel, 
 for example:
 public void setEnabledForChildren(boolean enabled) {
 setEnabledRecursive(this, enabled);
 }
 private void setEnabledRecursive(MarkupContainer container, boolean 
 enabled) {
 Iterator? extends Component iterator = container.iterator();
 while (iterator.hasNext()) {
 Component component = iterator.next();
 component.setEnabled(enabled);
 if (component instanceof MarkupContainer) {
 setEnabledRecursive((MarkupContainer) component, enabled);
 }
 }
 }
 I think that MarkupContainer must be responsible for disabling/enabling child 
 components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

svn commit: r711923 - in /wicket/trunk: wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/ wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/ wicket-e

Author: ivaynberg
Date: Thu Nov  6 09:43:03 2008
New Revision: 711923

URL: http://svn.apache.org/viewvc?rev=711923view=rev
Log:
WICKET-1919

Modified:

wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateField.java

wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DatePicker.java

wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java

wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabel.java

wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/Palette.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/AjaxEventBehavior.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/markup/html/form/AjaxFallbackButton.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/markup/html/navigation/paging/AjaxPagingNavigationBehavior.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Radio.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/link/AbstractLink.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/navigation/paging/PagingNavigation.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/navigation/paging/PagingNavigator.java

Modified: 
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateField.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateField.java?rev=711923r1=711922r2=711923view=diff
==
--- 
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateField.java
 (original)
+++ 
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateField.java
 Thu Nov  6 09:43:03 2008
@@ -174,7 +174,9 @@
protected void onBeforeRender()
{
dateField.setRequired(isRequired());
-   dateField.setEnabled(isEnabled()  isEnableAllowed());
+
+   // obsolete with WICKET-1919
+   // dateField.setEnabled(isEnabledInHierarchy());
 
Date d = (Date)getDefaultModelObject();
if (d != null)

Modified: 
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DatePicker.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DatePicker.java?rev=711923r1=711922r2=711923view=diff
==
--- 
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DatePicker.java
 (original)
+++ 
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DatePicker.java
 Thu Nov  6 09:43:03 2008
@@ -66,7 +66,8 @@
  * The CalendarNavigator can be configured by overriding [EMAIL PROTECTED] 
#configure(Map)} and setting the
  * property or by returning codetrue/code for [EMAIL PROTECTED] 
#enableMonthYearSelection()}.
  * 
- * @see a 
href=http://developer.yahoo.com/yui/calendar/;http://developer.yahoo.com/yui/calendar//a
+ * @see a
+ *  
href=http://developer.yahoo.com/yui/calendar/;http://developer.yahoo.com/yui/calendar//a
  * 
  * @author eelcohillenius
  */
@@ -611,7 +612,8 @@
 * selection of month and year.
 * 
 * @return codetrue/code if select boxes should be rendered to 
allow month and year
-* selection.br/ codefalse/code to render just plain text.
+* selection.br/
+* codefalse/code to render just plain text.
 */
protected boolean enableMonthYearSelection()
{
@@ -621,9 +623,8 @@
/**
 * Indicates whether the calendar should be hidden after a date was 
selected.
 * 
-* @return codetrue/code (default) if the calendar should be hidden 
after the date
-* selection br/ codefalse/code if the calendar should 
remain visible after the
-* date selection.
+* @return codetrue/code (default) if the calendar should be hidden 
after the date selection br/
+* codefalse/code if the calendar should remain visible 
after the date selection.
 */
protected boolean hideOnSelect()
{
@@ -644,9 +645,11 @@
/**
 * Override this method to further customize the YUI Calendar with

[jira] Commented: (WICKET-1911) setRequestTarget(ResourceStreamRequestTarget) doesn't work with AJAX

2008-11-06 Thread Adriano dos Santos Fernandes (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12645524#action_12645524
 ] 

Adriano dos Santos Fernandes commented on WICKET-1911:
--

But talking about ResourceStreamRequestTarget, can't it just reject ajax 
request inside its respond method? How would it may be used for another type of 
ajax request that works?

 setRequestTarget(ResourceStreamRequestTarget) doesn't work with AJAX
 

 Key: WICKET-1911
 URL: https://issues.apache.org/jira/browse/WICKET-1911
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.4-M3
 Environment: Win32 / Tomcat or Jetty
Reporter: Adriano dos Santos Fernandes
Assignee: Igor Vaynberg
 Attachments: ajax-resource-redirect.zip


 In test case attached, you see:
 RequestCycle.get().setRequestTarget(new ResourceStreamRequestTarget(
 new MyWebResource().getResourceStream()));
 doesn't work when clicking the AJAX link. The content is displayed inside the 
 AJAX Debug Window instead of redirect the page.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-1911) setRequestTarget(ResourceStreamRequestTarget) doesn't work with AJAX


[ 
https://issues.apache.org/jira/browse/WICKET-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12645527#action_12645527
 ] 

Igor Vaynberg commented on WICKET-1911:
---

it can be subclassed, and the subclass would prepend some javascript that knows 
how to process the streamed data.

 setRequestTarget(ResourceStreamRequestTarget) doesn't work with AJAX
 

 Key: WICKET-1911
 URL: https://issues.apache.org/jira/browse/WICKET-1911
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.4-M3
 Environment: Win32 / Tomcat or Jetty
Reporter: Adriano dos Santos Fernandes
Assignee: Igor Vaynberg
 Attachments: ajax-resource-redirect.zip


 In test case attached, you see:
 RequestCycle.get().setRequestTarget(new ResourceStreamRequestTarget(
 new MyWebResource().getResourceStream()));
 doesn't work when clicking the AJAX link. The content is displayed inside the 
 AJAX Debug Window instead of redirect the page.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

svn commit: r711946 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java

Author: ivaynberg
Date: Thu Nov  6 11:08:18 2008
New Revision: 711946

URL: http://svn.apache.org/viewvc?rev=711946view=rev
Log:
unroll WICKET-1910 because it breaks wicket tester, more notes in the jira issue

Modified:

wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java?rev=711946r1=711945r2=711946view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java
 Thu Nov  6 11:08:18 2008
@@ -61,12 +61,6 @@
private int previousUrlDepth;
 
/**
-* Marks this request as an ajax request. This is a cache used by and 
initialized in
-* [EMAIL PROTECTED] #isAjax()}
-*/
-   private Boolean ajax;
-
-   /**
 * Protected constructor.
 * 
 * @param httpServletRequest
@@ -419,25 +413,20 @@
@Override
public boolean isAjax()
{
-   if (ajax == null)
+   String ajaxHeader = httpServletRequest.getHeader(Wicket-Ajax);
+   if (Strings.isEmpty(ajaxHeader) == false)
{
-   ajax = false;
-
-   String ajaxHeader = 
httpServletRequest.getHeader(Wicket-Ajax);
-   if (Strings.isEmpty(ajaxHeader) == false)
+   try
{
-   try
-   {
-   ajax = Strings.isTrue(ajaxHeader);
-   }
-   catch (StringValueConversionException e)
-   {
-   // We are not interested in this 
exception but we log it anyway
-   log.debug(Couldn't convert the 
Wicket-Ajax header:  + ajaxHeader);
-   }
+   return Strings.isTrue(ajaxHeader);
+   }
+   catch (StringValueConversionException e)
+   {
+   // We are not interested in this exception but 
we log it anyway
+   log.debug(Couldn't convert the Wicket-Ajax 
header:  + ajaxHeader);
}
}
-   return ajax;
+   return false;
}
 
/**

[jira] Reopened: (WICKET-1910) ServletWebRequest.isAjax Should be cached


 [ 
https://issues.apache.org/jira/browse/WICKET-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg reopened WICKET-1910:
---


breaks wicket tester

 ServletWebRequest.isAjax Should be cached
 -

 Key: WICKET-1910
 URL: https://issues.apache.org/jira/browse/WICKET-1910
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 1.4-M3
 Environment: Any
Reporter: Martin Makundi
Assignee: Igor Vaynberg
Priority: Minor
 Fix For: 1.4-RC2

 Attachments: profile.png

   Original Estimate: 1h
  Remaining Estimate: 1h

 I was profiling my Wicket application and noticed that Jetty's
 getHeader method was hit quite often.
 It turns out the ServletWebRequest.isAjax method is hit quite often by
 each of the page elements (I am generating a large HTML report page).
 Since the Servlet container may not have optimal design for processing
 the getHeader method, I wonder if the ServletWebRequest.isAjax -method
 could/should be cached within wicket.
 I made the following modification to the ServletWebRequest.isAjax
 method, and measured a notable increase in performance:
  public boolean isAjax() {
if (ajax == null) {
  ajax = false;
  String ajaxHeader = httpServletRequest.getHeader(Wicket-Ajax);
  if (Strings.isEmpty(ajaxHeader) == false)
  {
try
{
  ajax = Strings.isTrue(ajaxHeader);
}
catch (StringValueConversionException e)
{
  // We are not interested in this exception but we log it anyway
  log.debug(Couldn't convert the Wicket-Ajax header:  + ajaxHeader);
}
  }
}
return ajax;
  }
 However, my question remains: is this a valid optimization or does it
 break the Wicket framework? Should it somehow be incorporated in the
 next releases?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-1910) ServletWebRequest.isAjax Should be cached


[ 
https://issues.apache.org/jira/browse/WICKET-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12645543#action_12645543
 ] 

Igor Vaynberg commented on WICKET-1910:
---

meantime it is trivial to create your own subclass of servletwebrequst that 
does the caching, the code is already there in subversion commits history.

 ServletWebRequest.isAjax Should be cached
 -

 Key: WICKET-1910
 URL: https://issues.apache.org/jira/browse/WICKET-1910
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 1.4-M3
 Environment: Any
Reporter: Martin Makundi
Assignee: Igor Vaynberg
Priority: Minor
 Fix For: 1.5-M1

 Attachments: profile.png


 I was profiling my Wicket application and noticed that Jetty's
 getHeader method was hit quite often.
 It turns out the ServletWebRequest.isAjax method is hit quite often by
 each of the page elements (I am generating a large HTML report page).
 Since the Servlet container may not have optimal design for processing
 the getHeader method, I wonder if the ServletWebRequest.isAjax -method
 could/should be cached within wicket.
 I made the following modification to the ServletWebRequest.isAjax
 method, and measured a notable increase in performance:
  public boolean isAjax() {
if (ajax == null) {
  ajax = false;
  String ajaxHeader = httpServletRequest.getHeader(Wicket-Ajax);
  if (Strings.isEmpty(ajaxHeader) == false)
  {
try
{
  ajax = Strings.isTrue(ajaxHeader);
}
catch (StringValueConversionException e)
{
  // We are not interested in this exception but we log it anyway
  log.debug(Couldn't convert the Wicket-Ajax header:  + ajaxHeader);
}
  }
}
return ajax;
  }
 However, my question remains: is this a valid optimization or does it
 break the Wicket framework? Should it somehow be incorporated in the
 next releases?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-1919) MarkupContainer.setEnabled() doesn't enable/disable child components


 [ 
https://issues.apache.org/jira/browse/WICKET-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1919.
---

Resolution: Fixed

only fixing this in 1.4

in 1.3 it will alter existing functionality in production systems.

 MarkupContainer.setEnabled() doesn't enable/disable child components
 

 Key: WICKET-1919
 URL: https://issues.apache.org/jira/browse/WICKET-1919
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.3, 1.4-M3
Reporter: Sergey Derugo
Assignee: Igor Vaynberg
 Fix For: 1.4-RC2

 Attachments: src.zip


 1. Create any components that is derived from MarkupContainer, for example, 
 create Panel. 
 2. Put some components to the Panel, for example, TextInput, Label etc.
 3. Call panel.setEnabled(false) 
 Result: all controls on panel are still enabled.
 Notes: after some investigation I found that MarkupContainer doesn't override 
 setEnabled and therefore it cannot enable/disable components stored in the 
 container. 
 Workaround: manually disable all components that are displayed on the panel, 
 for example:
 public void setEnabledForChildren(boolean enabled) {
 setEnabledRecursive(this, enabled);
 }
 private void setEnabledRecursive(MarkupContainer container, boolean 
 enabled) {
 Iterator? extends Component iterator = container.iterator();
 while (iterator.hasNext()) {
 Component component = iterator.next();
 component.setEnabled(enabled);
 if (component instanceof MarkupContainer) {
 setEnabledRecursive((MarkupContainer) component, enabled);
 }
 }
 }
 I think that MarkupContainer must be responsible for disabling/enabling child 
 components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-1916) setResponsePage(Application#getHomePage()) mounted as / (default) vs. ajax requests


[ 
https://issues.apache.org/jira/browse/WICKET-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12645548#action_12645548
 ] 

Igor Vaynberg commented on WICKET-1916:
---

try compiling it now or provide a quickstart

 setResponsePage(Application#getHomePage()) mounted as / (default) vs. ajax 
 requests
 ---

 Key: WICKET-1916
 URL: https://issues.apache.org/jira/browse/WICKET-1916
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.4-M3
Reporter: Jan Loose

 Hi,
 I'm using a week old version of wicket 1.4-SNAPSHOT and there is one ugly bug 
 ... in ajax request cannot be send redirect to homepage ... 
 setResponsePage(Application#getHomePage()) because there is return onlu one 
 byte as the response a in Ajax Debug Console I see this: 
 ---
 INFO: Using XMLHttpRequest transport
 INFO: 
 INFO: Initiating Ajax POST request on 
 ?wicket:interface=:3:loginSwitchPanel:loginPanel:form:submit::IActivePageBehaviorListener:0:wicket:ignoreIfNotActive=truerandom=0.03614674718119204
 INFO: Invoking pre-call handler(s)...
 INFO: Received ajax response (1 characters)
 INFO: 
  
 ERROR: Error while parsing response: Could not find root ajax-response 
 element
 INFO: Invoking post-call handler(s)...
 INFO: Invoking failure handler(s)...
 ---
 If I mount the homepage to for example /home then is all ok.
 I can try to compile last trunk version of wicket 1.4-SNAPSHOT but there is 7 
 failed tests:
 Failed tests:
   
 testAjaxHeaderContribution(org.apache.wicket.ajax.AjaxHeaderContributionTest)
   
 testDoubleAjaxHeaderContribution(org.apache.wicket.ajax.AjaxHeaderContributionTest)
   
 testBufferedExceptionErrorPage(org.apache.wicket.protocol.http.WebResponseExceptionsTest)
   
 testExceptionErrorPage(org.apache.wicket.protocol.http.WebResponseExceptionsTest)
   testExpirePage(org.apache.wicket.protocol.http.WebResponseExceptionsTest)
   
 testInternalErrorPage(org.apache.wicket.protocol.http.WebResponseExceptionsTest)
   testDomReadyOrder(org.apache.wicket.ajax.DomReadyOrderTest)
 Tests run: 722, Failures: 7, Errors: 0, Skipped: 0
 ---
 Thx for help!
 H.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1918) Automatically Load JavaScript files based on name matching


 [ 
https://issues.apache.org/jira/browse/WICKET-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg updated WICKET-1918:
--

Fix Version/s: 1.5-M1

 Automatically Load JavaScript files based on name matching
 --

 Key: WICKET-1918
 URL: https://issues.apache.org/jira/browse/WICKET-1918
 Project: Wicket
  Issue Type: New Feature
  Components: wicket
Reporter: Christopher J Lyth
Priority: Minor
 Fix For: 1.5-M1


 This is similar to WICKET-1917. I would like to add a feature to add JS files 
 based on name matching. I dont think this needs the same skinning feature as 
 the CSS component but it might.
  I imagine someone might preform different dynamic HTML sort of effects based 
 on which skin is selected.
 BasePage.java
 BasePage.properties
 BasePage.html
 (from WICKET-1917)
 BasePage.css 
 BasePage_chrome.css
 BasePage.js
 BasePage_chrome.js

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1917) Automatically Load CSS files based on name matching


 [ 
https://issues.apache.org/jira/browse/WICKET-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg updated WICKET-1917:
--

Fix Version/s: 1.5-M1

 Automatically Load CSS files based on name matching
 ---

 Key: WICKET-1917
 URL: https://issues.apache.org/jira/browse/WICKET-1917
 Project: Wicket
  Issue Type: New Feature
  Components: wicket
Reporter: Christopher J Lyth
Priority: Minor
 Fix For: 1.5-M1


 I often find myself adding CSS files to wicket with the same name as my pages 
 (i.e. BasePage.css). I then have to add the reference through an html link or 
 a header contributer. I would like to load these automatically in a similar 
 manor as the properties files. 
 I feel this should be expanded to include the ability to skin the application 
 in the following manor.
 BasePage.css
 BasePage_chrome.css
 BasePage_metal.css
 I would also recommend setting this in a similar manor to other patterns in 
 wicket. It would use the closest name match by default (i.e. BasePage.css). I 
 imagine this could also be set by system property (wicket.skin) or 
 programatically. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1906) AutocompleteTextField throws javascript error Object Required

2008-11-06 Thread Peter Ertl (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Ertl updated WICKET-1906:
---

Attachment: wicket-1906.patch

Ok, Igor, I really was bored so here's the patch ... :-)

I double-checked in Firefox and everything seems alright.

 AutocompleteTextField throws javascript error Object Required
 -

 Key: WICKET-1906
 URL: https://issues.apache.org/jira/browse/WICKET-1906
 Project: Wicket
  Issue Type: Bug
  Components: wicket-extensions
Affects Versions: 1.3.4
 Environment: IE6
Reporter: Shailesh
Priority: Minor
 Attachments: screenshot-1.jpg, wicket-1906.patch

   Original Estimate: 24h
  Remaining Estimate: 24h

 In wicket-autocomplete.js function doUpdateChoices(resp) has the check BR
 Line 304:  if(element.firstChild  
 element.firstChild.childNodes) BR
 BR
 However in function render() we are not having any checks BR
 Line 389: var node=menu.firstChild.childNodes[0]; BR
 BR
 which is causing Object required error on Line 389.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (WICKET-1915) wicket:message sometimes broken


 [ 
https://issues.apache.org/jira/browse/WICKET-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg reassigned WICKET-1915:
-

Assignee: Igor Vaynberg

 wicket:message sometimes broken
 ---

 Key: WICKET-1915
 URL: https://issues.apache.org/jira/browse/WICKET-1915
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.5
 Environment: Wicket 1.3.5, tomcat 5.5, but should have the same 
 behavior with any container
Reporter: Piller Sébastien
Assignee: Igor Vaynberg
Priority: Minor
 Attachments: WicketMessage.zip


 The behavior described here: 
 http://cwiki.apache.org/WICKET/wickets-xhtml-tags.html (use wicket:message as 
 attribute) sometimes doesn't work, depending on the hierarchy and the tag 
 where it applies.
 I've reproduced it using a repeater and applying wicket:message it to a td 
 tag.
 Instead of correctly modifying the attribute, it throws the usual 
 MarkupException WicketMessage: Unable to find component with id 'label' in 
 [MarkupContainer

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

svn commit: r712075 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketMessageTagHandler.java

Author: ivaynberg
Date: Thu Nov  6 22:41:31 2008
New Revision: 712075

URL: http://svn.apache.org/viewvc?rev=712075view=rev
Log:
WICKET-1915

Modified:

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketMessageTagHandler.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketMessageTagHandler.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketMessageTagHandler.java?rev=712075r1=712074r2=712075view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketMessageTagHandler.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketMessageTagHandler.java
 Thu Nov  6 22:41:31 2008
@@ -180,7 +180,7 @@
}
else
{
-   wc = new 
WebMarkupContainer(WICKET_MESSAGE_CONTAINER_ID +
+   wc = new 
TransparentContainer(WICKET_MESSAGE_CONTAINER_ID +
container.getPage().getAutoIndex());
}
 
@@ -189,4 +189,20 @@
}
return false;
}
+
+   private static class TransparentContainer extends WebMarkupContainer
+   {
+   private static final long serialVersionUID = 1L;
+
+   public TransparentContainer(String id)
+   {
+   super(id);
+   }
+
+   @Override
+   public boolean isTransparentResolver()
+   {
+   return true;
+   }
+   }
 }

[jira] Issue Comment Edited: (WICKET-1916) setResponsePage(Application#getHomePage()) mounted as / (default) vs. ajax requests


[ 
https://issues.apache.org/jira/browse/WICKET-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12645704#action_12645704
 ] 

ivaynberg edited comment on WICKET-1916 at 11/6/08 11:16 PM:
-

Martijn, this has to do with changes you made for WICKET-847

  was (Author: ivaynberg):
this has to do with changes you made for WICKET-847
  
 setResponsePage(Application#getHomePage()) mounted as / (default) vs. ajax 
 requests
 ---

 Key: WICKET-1916
 URL: https://issues.apache.org/jira/browse/WICKET-1916
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.4-M3
Reporter: Jan Loose
Assignee: Martijn Dashorst

 Hi,
 I'm using a week old version of wicket 1.4-SNAPSHOT and there is one ugly bug 
 ... in ajax request cannot be send redirect to homepage ... 
 setResponsePage(Application#getHomePage()) because there is return onlu one 
 byte as the response a in Ajax Debug Console I see this: 
 ---
 INFO: Using XMLHttpRequest transport
 INFO: 
 INFO: Initiating Ajax POST request on 
 ?wicket:interface=:3:loginSwitchPanel:loginPanel:form:submit::IActivePageBehaviorListener:0:wicket:ignoreIfNotActive=truerandom=0.03614674718119204
 INFO: Invoking pre-call handler(s)...
 INFO: Received ajax response (1 characters)
 INFO: 
  
 ERROR: Error while parsing response: Could not find root ajax-response 
 element
 INFO: Invoking post-call handler(s)...
 INFO: Invoking failure handler(s)...
 ---
 If I mount the homepage to for example /home then is all ok.
 I can try to compile last trunk version of wicket 1.4-SNAPSHOT but there is 7 
 failed tests:
 Failed tests:
   
 testAjaxHeaderContribution(org.apache.wicket.ajax.AjaxHeaderContributionTest)
   
 testDoubleAjaxHeaderContribution(org.apache.wicket.ajax.AjaxHeaderContributionTest)
   
 testBufferedExceptionErrorPage(org.apache.wicket.protocol.http.WebResponseExceptionsTest)
   
 testExceptionErrorPage(org.apache.wicket.protocol.http.WebResponseExceptionsTest)
   testExpirePage(org.apache.wicket.protocol.http.WebResponseExceptionsTest)
   
 testInternalErrorPage(org.apache.wicket.protocol.http.WebResponseExceptionsTest)
   testDomReadyOrder(org.apache.wicket.ajax.DomReadyOrderTest)
 Tests run: 722, Failures: 7, Errors: 0, Skipped: 0
 ---
 Thx for help!
 H.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Reopened: (WICKET-847) setResponsePage redirects to wrong url


 [ 
https://issues.apache.org/jira/browse/WICKET-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg reopened WICKET-847:
--


 setResponsePage redirects to wrong url
 --

 Key: WICKET-847
 URL: https://issues.apache.org/jira/browse/WICKET-847
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.0-beta2
Reporter: Andrew Klochkov
Assignee: Martijn Dashorst
 Fix For: 1.3.5, 1.4-M3

 Attachments: wicket-quickstart.tar.gz


 When I do setResponsePage(MyHomePage.class) IE tries to show me 
 my.site.com/./ url and gets 404 response. 
 Firefox just shows my.site.com without any troubles. I'm using wicket 
 1.3-beta2 and WicketFilter mapped to /*. 
 It's being reproduced under tomcat only, jetty works fine. My tomcat version 
 is 5.5.17. 
 Quickstart project which reproduces the bug is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-847) setResponsePage redirects to wrong url


 [ 
https://issues.apache.org/jira/browse/WICKET-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-847.
--

Resolution: Fixed

just noticed matijn did commit the code mentioned in the comments, albeit 
silently. that is why it worked when i tried it.

 setResponsePage redirects to wrong url
 --

 Key: WICKET-847
 URL: https://issues.apache.org/jira/browse/WICKET-847
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.0-beta2
Reporter: Andrew Klochkov
Assignee: Martijn Dashorst
 Fix For: 1.4-M3, 1.3.5

 Attachments: wicket-quickstart.tar.gz


 When I do setResponsePage(MyHomePage.class) IE tries to show me 
 my.site.com/./ url and gets 404 response. 
 Firefox just shows my.site.com without any troubles. I'm using wicket 
 1.3-beta2 and WicketFilter mapped to /*. 
 It's being reproduced under tomcat only, jetty works fine. My tomcat version 
 is 5.5.17. 
 Quickstart project which reproduces the bug is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (WICKET-1916) setResponsePage(Application#getHomePage()) mounted as / (default) vs. ajax requests


 [ 
https://issues.apache.org/jira/browse/WICKET-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg reassigned WICKET-1916:
-

Assignee: Martijn Dashorst

this has to do with changes you made for WICKET-847

 setResponsePage(Application#getHomePage()) mounted as / (default) vs. ajax 
 requests
 ---

 Key: WICKET-1916
 URL: https://issues.apache.org/jira/browse/WICKET-1916
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.4-M3
Reporter: Jan Loose
Assignee: Martijn Dashorst

 Hi,
 I'm using a week old version of wicket 1.4-SNAPSHOT and there is one ugly bug 
 ... in ajax request cannot be send redirect to homepage ... 
 setResponsePage(Application#getHomePage()) because there is return onlu one 
 byte as the response a in Ajax Debug Console I see this: 
 ---
 INFO: Using XMLHttpRequest transport
 INFO: 
 INFO: Initiating Ajax POST request on 
 ?wicket:interface=:3:loginSwitchPanel:loginPanel:form:submit::IActivePageBehaviorListener:0:wicket:ignoreIfNotActive=truerandom=0.03614674718119204
 INFO: Invoking pre-call handler(s)...
 INFO: Received ajax response (1 characters)
 INFO: 
  
 ERROR: Error while parsing response: Could not find root ajax-response 
 element
 INFO: Invoking post-call handler(s)...
 INFO: Invoking failure handler(s)...
 ---
 If I mount the homepage to for example /home then is all ok.
 I can try to compile last trunk version of wicket 1.4-SNAPSHOT but there is 7 
 failed tests:
 Failed tests:
   
 testAjaxHeaderContribution(org.apache.wicket.ajax.AjaxHeaderContributionTest)
   
 testDoubleAjaxHeaderContribution(org.apache.wicket.ajax.AjaxHeaderContributionTest)
   
 testBufferedExceptionErrorPage(org.apache.wicket.protocol.http.WebResponseExceptionsTest)
   
 testExceptionErrorPage(org.apache.wicket.protocol.http.WebResponseExceptionsTest)
   testExpirePage(org.apache.wicket.protocol.http.WebResponseExceptionsTest)
   
 testInternalErrorPage(org.apache.wicket.protocol.http.WebResponseExceptionsTest)
   testDomReadyOrder(org.apache.wicket.ajax.DomReadyOrderTest)
 Tests run: 722, Failures: 7, Errors: 0, Skipped: 0
 ---
 Thx for help!
 H.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-847) setResponsePage redirects to wrong url


 [ 
https://issues.apache.org/jira/browse/WICKET-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg updated WICKET-847:
-

Fix Version/s: 1.4-M3
 Assignee: Martijn Dashorst  (was: Igor Vaynberg)

 setResponsePage redirects to wrong url
 --

 Key: WICKET-847
 URL: https://issues.apache.org/jira/browse/WICKET-847
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.0-beta2
Reporter: Andrew Klochkov
Assignee: Martijn Dashorst
 Fix For: 1.3.5, 1.4-M3

 Attachments: wicket-quickstart.tar.gz


 When I do setResponsePage(MyHomePage.class) IE tries to show me 
 my.site.com/./ url and gets 404 response. 
 Firefox just shows my.site.com without any troubles. I'm using wicket 
 1.3-beta2 and WicketFilter mapped to /*. 
 It's being reproduced under tomcat only, jetty works fine. My tomcat version 
 is 5.5.17. 
 Quickstart project which reproduces the bug is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

svn commit: r712079 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js

Author: ivaynberg
Date: Thu Nov  6 23:21:42 2008
New Revision: 712079

URL: http://svn.apache.org/viewvc?rev=712079view=rev
Log:
WICKET-1906

Modified:

wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js

Modified: 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js?rev=712079r1=712078r2=712079view=diff
==
--- 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
 (original)
+++ 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
 Thu Nov  6 23:21:42 2008
@@ -348,12 +348,12 @@
showAutoComplete();
};
 
-   var node=element.firstChild.childNodes[0];
-   for(var i=0;ielementCount;i++){
+   var parentNode = element.firstChild;
+   for(var i = 0;i  elementCount; i++) {
+   var node = parentNode.childNodes[i];
node.onclick = clickFunc;
node.onmouseover = mouseOverFunc;
-   node = node.nextSibling;
-   }
+   }
 } else {
 elementCount=0;
 }

[jira] Resolved: (WICKET-1906) AutocompleteTextField throws javascript error Object Required


 [ 
https://issues.apache.org/jira/browse/WICKET-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1906.
---

   Resolution: Fixed
Fix Version/s: 1.4-RC2
   1.3.6
 Assignee: Igor Vaynberg

peter, awesome, thanks!

 AutocompleteTextField throws javascript error Object Required
 -

 Key: WICKET-1906
 URL: https://issues.apache.org/jira/browse/WICKET-1906
 Project: Wicket
  Issue Type: Bug
  Components: wicket-extensions
Affects Versions: 1.3.4
 Environment: IE6
Reporter: Shailesh
Assignee: Igor Vaynberg
Priority: Minor
 Fix For: 1.3.6, 1.4-RC2

 Attachments: screenshot-1.jpg, wicket-1906.patch

   Original Estimate: 24h
  Remaining Estimate: 24h

 In wicket-autocomplete.js function doUpdateChoices(resp) has the check BR
 Line 304:  if(element.firstChild  
 element.firstChild.childNodes) BR
 BR
 However in function render() we are not having any checks BR
 Line 389: var node=menu.firstChild.childNodes[0]; BR
 BR
 which is causing Object required error on Line 389.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

svn commit: r712078 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js