date:20081126

[jira] Commented: (WICKET-1653) Invalid argument in wicket-ajax.js (line 606) causes not loading ajax lazy load panel in IE

2008-11-26 Thread Marat Radchenko (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651272#action_12651272
 ] 

Marat Radchenko commented on WICKET-1653:
-

Closed to early. Nobody confirmed bug is fixed on 1.4 branch?

> Invalid argument in wicket-ajax.js (line 606) causes not loading ajax lazy 
> load panel in IE
> ---
>
> Key: WICKET-1653
> URL: https://issues.apache.org/jira/browse/WICKET-1653
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.3
> Environment: IE6.0.2900.2180 on xp
>Reporter: Per Newgro
>Assignee: Matej Knopp
>Priority: Critical
>
> see description at 
> http://www.nabble.com/javascript-error-in-internet-explorer-td16732896.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Issue Comment Edited: (WICKET-1653) Invalid argument in wicket-ajax.js (line 606) causes not loading ajax lazy load panel in IE

2008-11-26 Thread Marat Radchenko (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651272#action_12651272
 ] 

slonopotamus edited comment on WICKET-1653 at 11/26/08 11:32 PM:


Closed to early. Nobody confirmed bug is fixed on 1.4 branch.

  was (Author: slonopotamus):
Closed to early. Nobody confirmed bug is fixed on 1.4 branch?
  
> Invalid argument in wicket-ajax.js (line 606) causes not loading ajax lazy 
> load panel in IE
> ---
>
> Key: WICKET-1653
> URL: https://issues.apache.org/jira/browse/WICKET-1653
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.3
> Environment: IE6.0.2900.2180 on xp
>Reporter: Per Newgro
>Assignee: Matej Knopp
>Priority: Critical
>
> see description at 
> http://www.nabble.com/javascript-error-in-internet-explorer-td16732896.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-1921) Add an extension of AutoCompleteTextField which includes default css

2008-11-26 Thread Timo Rantalaiho (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timo Rantalaiho resolved WICKET-1921.
-

   Resolution: Fixed
Fix Version/s: 1.4-RC2
   1.3.6

Thankyou Anthony! I added Apache License Header and inlined the protected 
getCss-method, so that people will not do stuff in there that you shouldn't do 
before the object construction is finished (that's the danger of calling 
overridable methods from constructors).

> Add an extension of AutoCompleteTextField which includes default css
> 
>
> Key: WICKET-1921
> URL: https://issues.apache.org/jira/browse/WICKET-1921
> Project: Wicket
>  Issue Type: Improvement
>Affects Versions: 1.4-M3
>Reporter: Antony Stubbs
>Assignee: Timo Rantalaiho
> Fix For: 1.3.6, 1.4-RC2
>
> Attachments: defaultcss.patch, wicket.rar
>
>
> The component doesn't seem to work very well without some basic CSS. Adding 
> this will help people get started with it / demonstrate the css.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

svn commit: r721094 - in /wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete: AutoCompleteTextField.java DefaultCssAutocomp

2008-11-26 Thread thrantal

Author: thrantal
Date: Wed Nov 26 22:33:02 2008
New Revision: 721094

URL: http://svn.apache.org/viewvc?rev=721094&view=rev
Log:
WICKET-1921 : Added an example of how to style AutoCompleteTextField, courtesy 
of Anthony Stubbs. Thanks!

Added:

wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.css

wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.java
Modified:

wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteTextField.java

Modified: 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteTextField.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteTextField.java?rev=721094&r1=721093&r2=721094&view=diff
==
--- 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteTextField.java
 (original)
+++ 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteTextField.java
 Wed Nov 26 22:33:02 2008
@@ -24,8 +24,14 @@
 
 
 /**
- * An implementation of a textfield with the autoassist ajax behavior
+ * An implementation of a textfield with the autoassist ajax behavior [EMAIL 
PROTECTED] AutoCompleteBehavior}.
  * 
+ * FIXME javadoc - constructors need proper descriptions
+ * 
+ * Note that you must add your own CSS to make the suggestion display properly,
+ * see [EMAIL PROTECTED] DefaultCssAutocompleteTextField} for an example.
+ * 
+ * @see DefaultCssAutocompleteTextField
  * @see AutoCompleteBehavior
  * @see IAutoCompleteRenderer
  * 

Added: 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.css
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.css?rev=721094&view=auto
==
--- 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.css
 (added)
+++ 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.css
 Wed Nov 26 22:33:02 2008
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+div.wicket-aa {
+font-family: "Lucida Grande","Lucida Sans Unicode",Tahoma,Verdana;
+font-size: 12px;
+background-color: white;
+border-color: #cc;
+border-width: 1px;
+border-style: solid;
+padding: 2px;
+margin: 1px 0 0 0;
+text-align:left;
+}
+ 
+div.wicket-aa ul {
+list-style:none;
+padding: 2px;
+margin:0;
+}
+
+div.wicket-aa ul li.selected {
+background-color: #00;
+padding: 2px;
+margin:0;
+}
\ No newline at end of file

Added: 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.java?rev=721094&view=auto
==
--- 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutoc

svn commit: r721088 - in /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete: AutoCompleteTextField.java DefaultCssAutocompleteTextField.css Defaul

2008-11-26 Thread thrantal

Author: thrantal
Date: Wed Nov 26 22:17:17 2008
New Revision: 721088

URL: http://svn.apache.org/viewvc?rev=721088&view=rev
Log:
WICKET-1921 : Added an example of how to style AutoCompleteTextField, courtesy 
of Anthony Stubbs. Thanks!

Added:

wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.css

wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.java
Modified:

wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteTextField.java

Modified: 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteTextField.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteTextField.java?rev=721088&r1=721087&r2=721088&view=diff
==
--- 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteTextField.java
 (original)
+++ 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteTextField.java
 Wed Nov 26 22:17:17 2008
@@ -24,8 +24,14 @@
 
 
 /**
- * An implementation of a textfield with the autoassist ajax behavior
+ * An implementation of a textfield with the autoassist ajax behavior [EMAIL 
PROTECTED] AutoCompleteBehavior}.
  * 
+ * FIXME javadoc - constructors need proper descriptions
+ * 
+ * Note that you must add your own CSS to make the suggestion display properly,
+ * see [EMAIL PROTECTED] DefaultCssAutocompleteTextField} for an example.
+ * 
+ * @see DefaultCssAutocompleteTextField
  * @see AutoCompleteBehavior
  * @see IAutoCompleteRenderer
  * 

Added: 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.css
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.css?rev=721088&view=auto
==
--- 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.css
 (added)
+++ 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.css
 Wed Nov 26 22:17:17 2008
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+div.wicket-aa {
+font-family: "Lucida Grande","Lucida Sans Unicode",Tahoma,Verdana;
+font-size: 12px;
+background-color: white;
+border-color: #cc;
+border-width: 1px;
+border-style: solid;
+padding: 2px;
+margin: 1px 0 0 0;
+text-align:left;
+}
+ 
+div.wicket-aa ul {
+list-style:none;
+padding: 2px;
+margin:0;
+}
+
+div.wicket-aa ul li.selected {
+background-color: #00;
+padding: 2px;
+margin:0;
+}
\ No newline at end of file

Added: 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.java?rev=721088&view=auto
==
--- 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.java
 (added)
+++ 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutocompleteTextField.java
 Wed Nov 26 22:17:17 2008
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See

[jira] Created: (WICKET-1961) Bad javadoc for Request.getRelativePathPrefix* methods

2008-11-26 Thread Adrian Sandor (JIRA)

Bad javadoc for Request.getRelativePathPrefix* methods
--

 Key: WICKET-1961
 URL: https://issues.apache.org/jira/browse/WICKET-1961
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.4-RC1, 1.4-M3
Reporter: Adrian Sandor
Priority: Minor


In org.apache.wicket.Request, both getRelativePathPrefixToContextRoot and 
getRelativePathPrefixToWicketHandler use the exact same example in the javadoc 
comments. At least one of them must be wrong.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-1784) Enhance IDataProvider to support applications using the Transfer Object J2EE pattern

2008-11-26 Thread R. Goodwin (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651177#action_12651177
 ] 

R. Goodwin commented on WICKET-1784:


For better load balancing our web apps run in a separate cluster to our core 
services cluster. So lookups are often across boxes. There's also a legacy 
rationale behind this, where grouping web apps to a select range of boxes 
reduces the administration of  those boxes in the load-balanced pool. 
Admittedly, highly coupled services are grouped on the same boxes to reduce 
expensive lookups and they're all running in the same data centre, but don't 
think that should influence the debate.

Currently, Wicket-Lucene integration using standard Wicket components is just 
plain wrong.
I'm not willing to re-write data provision classes AND re-write paging 
mechanism.
And fortunately .. ha ha ... I don't have to ... because we're not using it in 
production.
T'was just a wee experiment to test the cloudy waters.

Actually, I'm -(-1) for a Wicket improvement that doesn't force anyone to have 
to abandon their preferred data access strategy.

> Enhance IDataProvider to support applications using the Transfer Object J2EE 
> pattern
> 
>
> Key: WICKET-1784
> URL: https://issues.apache.org/jira/browse/WICKET-1784
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.3, 1.4-M3
> Environment: Wicket 1.3.3 and 1.4-M3
>Reporter: R. Goodwin
>Assignee: Igor Vaynberg
> Attachments: wicket-paging-experiment.zip
>
>
> In some environments searches are performed in 'single call' fashion, using a 
> transfer object.
> E.g. two queries performed by the data services tier before returning 
> combined results to the UI tier:
> i. Query for paged search results
> ii. Query for a 'count' value representing total possible results
> The contract between DataView and IDataProvider does not support a 'single 
> call' environment as the give/take relationship between these classes is 
> biased towards DataView.
> DataView expects IDataProvider to provide it's size before providing 
> IDataProvider with its offset and count.
> * DataView may have good reasons for needing size before it can provide 
> offset/count.
> * But IDataProvider has equally good reasons for needing offset/count before 
> it can provide size.
> The circular dependency:
> 1. DataView calls IDataProvider.size()
> 2. IDataProvider cannot return size as it cannot start a query until it 
> receives offset/count from DataView
> 3. These it does not receive until DataView calls IDataProvider.iterator() 
> later on
> Others who experienced this problem (with CODE examples):
> * http://www.nabble.com/IDataProvider-and-Hibernate-Search-td15546101.html
> * http://www.mail-archive.com/[EMAIL PROTECTED]/msg14266.html
> ---
> The suggested solution of caching the combined search results and count value 
> does not work if the search cannot begin until offset and count are 
> available. And writing a custom DataView is not feasible either time wise as 
> I understand that it cannot be done without needing to write a number of 
> other classes too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-1784) Enhance IDataProvider to support applications using the Transfer Object J2EE pattern

2008-11-26 Thread Bruno Borges (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651145#action_12651145
 ] 

Bruno Borges commented on WICKET-1784:
--

I think the purpose of Transfer Object Pattern , where it says it wants to 
reduce remote calls between tiers over the network is related to tiers like 
client / server architectures.

This means that:

i)   A Swing client requests a query on a table for a remote EJB
ii)  The EJB executes two calls on the database
ii.a) select count(*)
ii.b) select * ... limit x offset y / rownum between z and k // whatever DB 
paging technique is being used.
iii) Put all this information into one single Transfer Object
iv) Send the object back to the client application over the network

So, if your Web Application is running on the same server with your services 
(EJBs, Spring Services, whatever), this means that you are not going to 
transport data over the network between those tiers (Web and Model). And there 
will be an "implicit" Transfer Object to the real client (web browser).

Following this logic: -1 for this improvement.

> Enhance IDataProvider to support applications using the Transfer Object J2EE 
> pattern
> 
>
> Key: WICKET-1784
> URL: https://issues.apache.org/jira/browse/WICKET-1784
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.3, 1.4-M3
> Environment: Wicket 1.3.3 and 1.4-M3
>Reporter: R. Goodwin
>Assignee: Igor Vaynberg
> Attachments: wicket-paging-experiment.zip
>
>
> In some environments searches are performed in 'single call' fashion, using a 
> transfer object.
> E.g. two queries performed by the data services tier before returning 
> combined results to the UI tier:
> i. Query for paged search results
> ii. Query for a 'count' value representing total possible results
> The contract between DataView and IDataProvider does not support a 'single 
> call' environment as the give/take relationship between these classes is 
> biased towards DataView.
> DataView expects IDataProvider to provide it's size before providing 
> IDataProvider with its offset and count.
> * DataView may have good reasons for needing size before it can provide 
> offset/count.
> * But IDataProvider has equally good reasons for needing offset/count before 
> it can provide size.
> The circular dependency:
> 1. DataView calls IDataProvider.size()
> 2. IDataProvider cannot return size as it cannot start a query until it 
> receives offset/count from DataView
> 3. These it does not receive until DataView calls IDataProvider.iterator() 
> later on
> Others who experienced this problem (with CODE examples):
> * http://www.nabble.com/IDataProvider-and-Hibernate-Search-td15546101.html
> * http://www.mail-archive.com/[EMAIL PROTECTED]/msg14266.html
> ---
> The suggested solution of caching the combined search results and count value 
> does not work if the search cannot begin until offset and count are 
> available. And writing a custom DataView is not feasible either time wise as 
> I understand that it cannot be done without needing to write a number of 
> other classes too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-1784) Enhance IDataProvider to support applications using the Transfer Object J2EE pattern

2008-11-26 Thread R. Goodwin (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651130#action_12651130
 ] 

R. Goodwin commented on WICKET-1784:


Stefan,

I raised this issue on Nabble in a more specific Wicket-Lucene kind of way in 
August without getting much interest.

http://www.nabble.com/Paging-query-relating-to-IDataProvider-and-Lucene-search-td19083164.html

But this related post is getting much more traffic:

http://www.nabble.com/Is-there-any-other-way--DataProviders-must-hit-the-Db-twice-for-(possible)-large-datasets-td20701684.html

> Enhance IDataProvider to support applications using the Transfer Object J2EE 
> pattern
> 
>
> Key: WICKET-1784
> URL: https://issues.apache.org/jira/browse/WICKET-1784
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.3, 1.4-M3
> Environment: Wicket 1.3.3 and 1.4-M3
>Reporter: R. Goodwin
>Assignee: Igor Vaynberg
> Attachments: wicket-paging-experiment.zip
>
>
> In some environments searches are performed in 'single call' fashion, using a 
> transfer object.
> E.g. two queries performed by the data services tier before returning 
> combined results to the UI tier:
> i. Query for paged search results
> ii. Query for a 'count' value representing total possible results
> The contract between DataView and IDataProvider does not support a 'single 
> call' environment as the give/take relationship between these classes is 
> biased towards DataView.
> DataView expects IDataProvider to provide it's size before providing 
> IDataProvider with its offset and count.
> * DataView may have good reasons for needing size before it can provide 
> offset/count.
> * But IDataProvider has equally good reasons for needing offset/count before 
> it can provide size.
> The circular dependency:
> 1. DataView calls IDataProvider.size()
> 2. IDataProvider cannot return size as it cannot start a query until it 
> receives offset/count from DataView
> 3. These it does not receive until DataView calls IDataProvider.iterator() 
> later on
> Others who experienced this problem (with CODE examples):
> * http://www.nabble.com/IDataProvider-and-Hibernate-Search-td15546101.html
> * http://www.mail-archive.com/[EMAIL PROTECTED]/msg14266.html
> ---
> The suggested solution of caching the combined search results and count value 
> does not work if the search cannot begin until offset and count are 
> available. And writing a custom DataView is not feasible either time wise as 
> I understand that it cannot be done without needing to write a number of 
> other classes too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[CONF] Apache Wicket: Wicket Session Size (page edited)

2008-11-26 Thread confluence











Page Edited :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been edited by jWeekend
(Nov 26, 2008).
 

 
 (View changes)
 

Content:
Let's start with some bullet points we can flesh out. When we have enough information we can organise it to create a cohesive and valuable document.

Introduction


Stateful Web Applications


Server Side State vs Client  Side State


Versioning


Back Button


Page Maps


Why Does It Matter?


Identifying The Problem


Map Size


Testing


Profiling


Detachable Models


Stateful vs Stateless


Beware ...


Non-static inner classes

Non-static inner classes can access the state of the enclosing object. To do this, the byte code of the inner-class contains a reference to the outer-class instance. So, when the inner-class instace is serialised, the outer-class instance will be serialised too!

Keeping a reference to the previous page

If a page keeps a reference to a previous page (for example to implement a "back to last step" button), this will cause the "previous page" to be serialised again when the page holding the reference is serialised. 


... alternative to this approach include ...


Other Gotchas ...











Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[jira] Updated: (WICKET-1897) StatelessForm submitted to the wrong page

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg updated WICKET-1897:
--

Fix Version/s: 1.4-RC2

> StatelessForm submitted to the wrong page
> -
>
> Key: WICKET-1897
> URL: https://issues.apache.org/jira/browse/WICKET-1897
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 1.4-M3
>Reporter: Adrian Sandor
>Assignee: Johan Compagner
> Fix For: 1.4-RC2
>
> Attachments: wickettest.zip
>
>
> I made a small application to reproduce the problem. You can download it from 
> http://aditsu.net/wickettest.zip , I'll try to attach it too.
> Dependencies: jetty 6, wicket 1.4-m3, slf4j, log4j
> Steps to reproduce:
> 1. Run the test.Start class
> 2. Open http://localhost:8080 in a browser
> 3. Open http://localhost:8080/page2 in a new tab
> 4. Go to the first tab and click submit
> Result:
> WicketRuntimeException: unable to find component with path form on stateless 
> page [Page class = test.Page2, id = 0, version = 0]
> It looks like the 2 pages are created with the same id in 2 different 
> pagemaps, but when I submit the form, it goes to the second pagemap and finds 
> the second page (with no form on it).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (WICKET-1897) StatelessForm submitted to the wrong page

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg reassigned WICKET-1897:
-

Assignee: Johan Compagner

> StatelessForm submitted to the wrong page
> -
>
> Key: WICKET-1897
> URL: https://issues.apache.org/jira/browse/WICKET-1897
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 1.4-M3
>Reporter: Adrian Sandor
>Assignee: Johan Compagner
> Fix For: 1.4-RC2
>
> Attachments: wickettest.zip
>
>
> I made a small application to reproduce the problem. You can download it from 
> http://aditsu.net/wickettest.zip , I'll try to attach it too.
> Dependencies: jetty 6, wicket 1.4-m3, slf4j, log4j
> Steps to reproduce:
> 1. Run the test.Start class
> 2. Open http://localhost:8080 in a browser
> 3. Open http://localhost:8080/page2 in a new tab
> 4. Go to the first tab and click submit
> Result:
> WicketRuntimeException: unable to find component with path form on stateless 
> page [Page class = test.Page2, id = 0, version = 0]
> It looks like the 2 pages are created with the same id in 2 different 
> pagemaps, but when I submit the form, it goes to the second pagemap and finds 
> the second page (with no form on it).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-1866) MarkupContainer already follows the contract of Iterable; it should implement it.

2008-11-26 Thread Igor Vaynberg (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651114#action_12651114
 ] 

Igor Vaynberg commented on WICKET-1866:
---

there is a problem with generics here

currently markupcontainer has public Iterator iterator() 
but if we make it implement iterable we have to change it to 
Iterator ... not sure which one is right.

> MarkupContainer already follows the contract of Iterable; it should implement 
> it.
> -
>
> Key: WICKET-1866
> URL: https://issues.apache.org/jira/browse/WICKET-1866
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-M3
>Reporter: Maarten Billemont
>
> To support the enhanced for syntax and several other features of the 
> language; MarkupContainers should implement the Iterable interface whose 
> contract it already follows.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-1907) Ajax self updating label causes browser problems

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1907.
---

Resolution: Incomplete

waiting for quickstart

> Ajax self updating label causes browser problems
> 
>
> Key: WICKET-1907
> URL: https://issues.apache.org/jira/browse/WICKET-1907
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.4, 1.3.5
> Environment: Firefox 3, Internet Explorer 7
>Reporter: Melvin Frohike
>
> Updating a label via Ajax causes Form elements on the same page to loose 
> their focus in Firefox. The cursor in Textareas jumps to the end and looses 
> selections.
> In Internet Explorer, the entire page scrolls down, to the form element that 
> the user sets the focus too, manually.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-1920) Settings mounts as case insensitive causes 404 errors if case is included when mounting pages.

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1920.
---

   Resolution: Fixed
Fix Version/s: 1.4-RC2
 Assignee: Igor Vaynberg

> Settings mounts as case insensitive causes 404 errors if case is included 
> when mounting pages.
> --
>
> Key: WICKET-1920
> URL: https://issues.apache.org/jira/browse/WICKET-1920
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
> Environment: Windows XP, Java 1.6, Wicket 1.4-SNAPSHOT revision 712226
>Reporter: Matthew R Hanlon
>Assignee: Igor Vaynberg
>Priority: Minor
> Fix For: 1.4-RC2
>
> Attachments: MountsBugTestCase.tar.bz2
>
>
> Settings mounts as case insensitive causes 404 errors if case is included 
> when mounting pages.
> Example:
> public class MyApplication extends WebApplication {
>...
>@Override
>protected IRequestCycleProcessor newRequestCycleProcessor() {
>   return new WebRequestCycleProcessor() {
>  @Override
>  protected IRequestCodingStrategy newRequestCodingStrategy() {
> WebRequestCodingStrategy.Settings strategySettings = new 
> WebRequestCodingStrategy.Settings();
> strategySettings.setMountsCaseSensitive(false);
> return new WebRequestCodingStrategy(strategySettings);
>  }
>   };
>}
>...
>@Override
>public void init() {
>...
>mountBookmarkablePage("/mypage1", MyPage1.class);  // works
>mountBookmarkablePage("/myPage2", MyPage2.class);  // causes 404
>...
>}
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

svn commit: r720949 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket: protocol/http/request/ request/target/coding/ util/string/

2008-11-26 Thread ivaynberg

Author: ivaynberg
Date: Wed Nov 26 11:13:44 2008
New Revision: 720949

URL: http://svn.apache.org/viewvc?rev=720949&view=rev
Log:
WICKET-1920

Modified:

wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/coding/AbstractRequestTargetUrlCodingStrategy.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/coding/HybridUrlCodingStrategy.java

wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/coding/IRequestTargetUrlCodingStrategy.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/Strings.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java?rev=720949&r1=720948&r2=720949&view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java
 Wed Nov 26 11:13:44 2008
@@ -1083,7 +1083,7 @@
if (path.startsWith(key))
{
IRequestTargetUrlCodingStrategy 
strategy = entry.getValue();
-   if (strategy.matches(path))
+   if (strategy.matches(path, 
caseSensitiveMounts))
{
return strategy;
}

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/coding/AbstractRequestTargetUrlCodingStrategy.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/coding/AbstractRequestTargetUrlCodingStrategy.java?rev=720949&r1=720948&r2=720949&view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/coding/AbstractRequestTargetUrlCodingStrategy.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/coding/AbstractRequestTargetUrlCodingStrategy.java
 Wed Nov 26 11:13:44 2008
@@ -251,11 +251,14 @@
 * not /mount/pointXXX.
 * 
 * @param path
+* @param caseSensitive
+*whether the strategy should treat path 
argument with case sensitivity
+*or not
 * @return true if matches, false otherwise
 */
-   public boolean matches(String path)
+   public boolean matches(String path, boolean caseSensitive)
{
-   if (path.startsWith(mountPath))
+   if (Strings.startsWith(path, mountPath, caseSensitive))
{
/*
 * We need to match /mount/point or 
/mount/point/with/extra/path, but not

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/coding/HybridUrlCodingStrategy.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/coding/HybridUrlCodingStrategy.java?rev=720949&r1=720948&r2=720949&view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/coding/HybridUrlCodingStrategy.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/target/coding/HybridUrlCodingStrategy.java
 Wed Nov 26 11:13:44 2008
@@ -75,12 +75,12 @@
boolean redirectOnBookmarkableRequest)
{
super(mountPath);
-   
+
if (mountPath.endsWith("/"))
{
throw new IllegalArgumentException("mountPath can not 
end with a '/': " + mountPath);
}
-   
+
pageClassRef = new WeakReference(pageClass);
this.redirectOnBookmarkableRequest = 
redirectOnBookmarkableRequest;
}
@@ -280,7 +280,7 @@
{
ListenerInterfaceRequestTarget target = 
(ListenerInterfaceRequestTarget)requestTarget;
Page page = target.getPage();
-   return 
(Integer)page.getMetaData(ORIGINAL_TRAILING_SLASHES_COUNT_METADATA_KEY);
+   return 
page.getMetaData(ORIGINAL_TRAILING_SLASHES_COUNT_METADATA_KEY);
}
return null;
}
@@ -361,7 +361,7 @@
 */
public static PageParameters getInitialPagePageParameters(Page page)
{
-   return 
(PageParameters)page.getMetaData(PAGE_P

svn commit: r720942 - in /wicket/trunk/wicket/src: main/java/org/apache/wicket/protocol/http/MockHttpServletRequest.java test/java/org/apache/wicket/util/tester/FormTesterTest.java test/java/org/apach

2008-11-26 Thread ivaynberg

Author: ivaynberg
Date: Wed Nov 26 10:51:13 2008
New Revision: 720942

URL: http://svn.apache.org/viewvc?rev=720942&view=rev
Log:
WICKET-1931

Modified:

wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/MockHttpServletRequest.java

wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/FormTesterTest.java

wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/MockFormFileUploadPage.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/MockHttpServletRequest.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/MockHttpServletRequest.java?rev=720942&r1=720941&r2=720942&view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/MockHttpServletRequest.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/MockHttpServletRequest.java
 Wed Nov 26 10:51:13 2008
@@ -487,33 +487,19 @@
 */
public ServletInputStream getInputStream() throws IOException
{
-   if (uploadedFiles != null && uploadedFiles.size() > 0)
-   {
-   byte[] request = buildRequest();
+   byte[] request = buildRequest();
 
-   // Ok lets make an input stream to return
-   final ByteArrayInputStream bais = new 
ByteArrayInputStream(request);
+   // Ok lets make an input stream to return
+   final ByteArrayInputStream bais = new 
ByteArrayInputStream(request);
 
-   return new ServletInputStream()
-   {
-   @Override
-   public int read()
-   {
-   return bais.read();
-   }
-   };
-   }
-   else
+   return new ServletInputStream()
{
-   return new ServletInputStream()
+   @Override
+   public int read()
{
-   @Override
-   public int read()
-   {
-   return -1;
-   }
-   };
-   }
+   return bais.read();
+   }
+   };
}
 
/**

Modified: 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/FormTesterTest.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/FormTesterTest.java?rev=720942&r1=720941&r2=720942&view=diff
==
--- 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/FormTesterTest.java
 (original)
+++ 
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/tester/FormTesterTest.java
 Wed Nov 26 10:51:13 2008
@@ -18,6 +18,7 @@
 
 import java.util.Locale;
 
+import org.apache.wicket.PageParameters;
 import org.apache.wicket.Session;
 import org.apache.wicket.WicketTestCase;
 import org.apache.wicket.markup.html.form.upload.FileUpload;
@@ -123,7 +124,7 @@
 
FormTester formTester = tester.newFormTester("form");
formTester.setFile("file", new File(getBasedir() +
-   
"src/test/java/org/apache/wicket/util/tester/bg.jpg"), "image/jpeg");
+   "src/test/java/org/apache/wicket/util/tester/bg.jpg"), 
"image/jpeg");
formTester.setValue("text", "Mock value");
formTester.submit();
 
@@ -136,7 +137,7 @@
assertNotNull(fileUpload);
 
assertTrue("uploaded content does not have the right size, 
expected 428, got " +
-   fileUpload.getBytes().length, 
fileUpload.getBytes().length == 428);
+   fileUpload.getBytes().length, 
fileUpload.getBytes().length == 428);
assertEquals("bg.jpg", fileUpload.getClientFileName());
assertEquals("image/jpeg", fileUpload.getContentType());
}
@@ -159,4 +160,24 @@
tester.assertErrorMessages(new String[] { "Field 'file' is 
required." });
}
 
+   /**
+* Test that formTester deal with Multipart form correctly when no 
actual upload
+*/
+   public void testSubmitMultipartForm()
+   {
+   tester.startPage(MockFormFileUploadPage.class, new 
PageParameters("required=false"));
+   MockFormFileUploadPage page = 
(MockFormFileUploadPage)tester.getLastRenderedPage();
+   MockDomainObjectFileUpload domainObject = 
page.getDomainObject();
+
+   Session.get().setLocale(Locale.US);
+

[jira] Resolved: (WICKET-1931) FormTester doesn't correctly submit a form when a FileUploadField was not set (which is not required)

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1931.
---

   Resolution: Fixed
Fix Version/s: 1.4-RC2
 Assignee: Igor Vaynberg

> FormTester doesn't correctly submit a form when a FileUploadField was not set 
> (which is not required)
> -
>
> Key: WICKET-1931
> URL: https://issues.apache.org/jira/browse/WICKET-1931
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-M3
> Environment: Windows XP PL SP 2, Java 1.6.0_10
>Reporter: Artur Wronski
>Assignee: Igor Vaynberg
> Fix For: 1.4-RC2
>
> Attachments: wicket-1931.patch
>
>
> FormTester doesn't correctly submit a form when  a FileUploadField was not 
> set.
> This file is not required.
> So it is impossible to create a real test because I am forced to always set a 
> File to check to whole form.
> There was discussion about this problem here: 
> http://www.nabble.com/FormTester-and-FileUploadField-td18566869.html
> I will be very grateful if you can fix it :)
> Artur

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (WICKET-1912) StatelessForm problems with query string

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg reassigned WICKET-1912:
-

Assignee: Johan Compagner

> StatelessForm problems with query string
> 
>
> Key: WICKET-1912
> URL: https://issues.apache.org/jira/browse/WICKET-1912
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 1.4-M3
>Reporter: Adrian Sandor
>Assignee: Johan Compagner
> Attachments: wickettest-1912.zip
>
>
> I made a small application to reproduce the problem, please see the 
> attachment.
> Dependencies: jetty 6, wicket 1.4-m3, slf4j, log4j
> First problem:
> Steps to reproduce:
> 1. Run the test.Start class
> 2. Open http://localhost:8080 in a browser
> 3. Type something in the text field, then click submit several times
> Result:
> The query string is growing every time
> Second problem:
> Steps to reproduce:
> 1,2: Same as above
> 3. Don't type anything in the text field, then click submit several times
> Result:
> Besides the query string growing every time, semicolons appear in the input 
> field and grow exponentially (2*n+1 each time)
> Third problem:
> Steps to reproduce:
> 1,2: Same as above
> 3. Don't type anything in the text field, then click submit once
> 4. Type something in the text field, then click submit several times
> Result:
> A semicolon is prepended to the text, then the text is doubled every time, 
> with a semicolon added in the middle

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1938) Use XMLUnit for framework tests

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg updated WICKET-1938:
--

Fix Version/s: 1.5-M1

> Use XMLUnit for framework tests
> ---
>
> Key: WICKET-1938
> URL: https://issues.apache.org/jira/browse/WICKET-1938
> Project: Wicket
>  Issue Type: Improvement
>Reporter: Geoff Reedy
> Fix For: 1.5-M1
>
>
> Currently the framework tests are comparing xml/html documents as strings. 
> This causes spurious test failures when executed on a 1.6 JDK. For example:
> Running org.apache.wicket.ajax.AjaxRequestTargetTest
> 2c2
> <

svn commit: r720938 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java

2008-11-26 Thread ivaynberg

Author: ivaynberg
Date: Wed Nov 26 10:42:04 2008
New Revision: 720938

URL: http://svn.apache.org/viewvc?rev=720938&view=rev
Log:
WICKET-1955

Modified:

wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java

Modified: 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java?rev=720938&r1=720937&r2=720938&view=diff
==
--- 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java
 (original)
+++ 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java
 Wed Nov 26 10:42:04 2008
@@ -17,6 +17,7 @@
 package org.apache.wicket.markup.resolver;
 
 import org.apache.wicket.MarkupContainer;
+import org.apache.wicket.Page;
 import org.apache.wicket.WicketRuntimeException;
 import org.apache.wicket.markup.ComponentTag;
 import org.apache.wicket.markup.MarkupException;
@@ -27,6 +28,7 @@
 import org.apache.wicket.markup.html.internal.HtmlHeaderContainer;
 import org.apache.wicket.markup.parser.filter.HtmlHeaderSectionHandler;
 import org.apache.wicket.markup.parser.filter.WicketTagIdentifier;
+import org.apache.wicket.util.resource.IResourceStream;
 
 /**
  * This is a tag resolver which handles  and 
tags. It must be
@@ -145,8 +147,14 @@
}
else
{
+   final Page page = container.getPage();
+   final String pageClassName = (page != null) ? 
page.getClass().getName() : "unknown";
+   final IResourceStream stream = 
markupStream.getResource();
+   final String streamName = (stream != null) ? 
stream.toString() : "unknown";
+
throw new MarkupException(
-   "Mis-placed . 
 must be outside of , , and 
");
+   "Mis-placed . 
 must be outside of , , and 
. Error occured while rendering page: " +
+   pageClassName + " using markup 
stream: " + streamName);
}
 
// Yes, we handled the tag

[jira] Commented: (WICKET-1956) on submitting form ModelObject of TextField is NULL after setEnabled(true)

2008-11-26 Thread Igor Vaynberg (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651100#action_12651100
 ] 

Igor Vaynberg commented on WICKET-1956:
---

we need a quickstart that demonstrates this.

> on submitting form ModelObject of TextField is NULL after setEnabled(true)
> --
>
> Key: WICKET-1956
> URL: https://issues.apache.org/jira/browse/WICKET-1956
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 1.3.5
> Environment: Java 6 R10, Jetty Server, WinXP sp3, FF3
>Reporter: Henner Storch
>
> This Ajax event handler ist attached to an AbstractAutocompleteTextField via 
> AjaxFormComponentUpdateBehaviour("onchange"):
> @Override
> protected void onUpdate(AjaxRequestTarget target)
> {
> ChildObj co = (ChildObj)AutoCompleteTextField.findChoice();
> if(null != co )
> {
> ((Obj)Form.getModelObject()).setChildObject(co);
> ((Obj)Form.getModelObject()).setPrice(co.getPrice());
> if(co.isBoolAttribute())
> {
> ((Obj)Form.getModelObject()).setAmount(new Float(1));
> TextInput.setEnabled(false);
> target.addComponent(TextInput);
> }
> else
> {
> ((Obj)Form.getModelObject()).setAmount(new Float(1));
> obj.setAmount(new Float(1));
> TextInput.setModelObject(new Float(1));
> TextInput.setEnabled(true);
> target.addComponent(TextInput);
> }
> }
> } 
> If the Form containing the AbstractAutocompleteTextField and the TextField 
> after the else-block has been executed the ModelObject of TextField is NULL 
> no matter what Value is filled in. All other fields ModelObjects of the form 
> are filled correctly. 
> Form submitting does not fail when else-block was not executed.
> ModelObject of the form is a CompoundPropertyModel of "Obj".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-1955) Error about misplaced very uninformative and incorrect

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1955.
---

   Resolution: Fixed
Fix Version/s: 1.4-RC2
   1.3.6
 Assignee: Igor Vaynberg

> Error about misplaced  very uninformative and incorrect
> 
>
> Key: WICKET-1955
> URL: https://issues.apache.org/jira/browse/WICKET-1955
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-RC1
>Reporter: Sebastiaan van Erk
>Assignee: Igor Vaynberg
>Priority: Minor
> Fix For: 1.3.6, 1.4-RC2
>
>
> I got the exception below when I misplaced a  tag. There are two 
> things wrong with it:
> 1) It does not tell me in which file I made the mistake.
> 2) I had put the  in a  and not in a 
>  or .
> WicketMessage: Mis-placed .  must be outside of 
>  and 
> Root cause:
> org.apache.wicket.markup.MarkupException: Mis-placed . 
>  must be outside of  and 
> at 
> org.apache.wicket.markup.resolver.HtmlHeaderResolver.resolve(HtmlHeaderResolver.java:150)
> at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1414)
> at 
> org.apache.wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:1569)
> at 
> org.apache.wicket.MarkupContainer.onComponentTagBody(MarkupContainer.java:1493)
> at org.apache.wicket.Component.renderComponent(Component.java:2564)
> at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1504)
> at org.apache.wicket.Component.render(Component.java:2400)
> at org.apache.wicket.MarkupContainer.autoAdd(MarkupContainer.java:232)
> at 
> org.apache.wicket.markup.resolver.MarkupInheritanceResolver.resolve(MarkupInheritanceResolver.java:66)
> at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1414)
> at 
> org.apache.wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:1569)
> at 
> org.apache.wicket.MarkupContainer.onComponentTagBody(MarkupContainer.java:1493)
> at org.apache.wicket.Component.renderComponent(Component.java:2564)
> at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1504)
> at org.apache.wicket.Component.render(Component.java:2400)
> at org.apache.wicket.MarkupContainer.autoAdd(MarkupContainer.java:232)
> at 
> org.apache.wicket.markup.resolver.MarkupInheritanceResolver.resolve(MarkupInheritanceResolver.java:73)
> at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1414)
> at 
> org.apache.wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:1569)
> at 
> org.apache.wicket.MarkupContainer.onComponentTagBody(MarkupContainer.java:1493)
> at 
> org.apache.wicket.markup.html.internal.HtmlHeaderContainer.onComponentTagBody(HtmlHeaderContainer.java:135)
> at org.apache.wicket.Component.renderComponent(Component.java:2564)
> at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1504)
> at org.apache.wicket.Component.render(Component.java:2400)
> at org.apache.wicket.MarkupContainer.autoAdd(MarkupContainer.java:232)
> at 
> org.apache.wicket.markup.resolver.HtmlHeaderResolver.resolve(HtmlHeaderResolver.java:78)
> at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1414)
> at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1520)
> at org.apache.wicket.Page.onRender(Page.java:1501)
> at org.apache.wicket.Component.render(Component.java:2400)
> at org.apache.wicket.Page.renderPage(Page.java:905)
> at 
> org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:249)
> at 
> org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:104)
> at 
> org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1179)
> at org.apache.wicket.RequestCycle.step(RequestCycle.java:1250)
> at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1351)
> at org.apache.wicket.RequestCycle.request(RequestCycle.java:497)
> at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:444)
> at 
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:282)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
> at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
> at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
> at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
> at org.apache.cat

svn commit: r720939 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java

2008-11-26 Thread ivaynberg

Author: ivaynberg
Date: Wed Nov 26 10:42:34 2008
New Revision: 720939

URL: http://svn.apache.org/viewvc?rev=720939&view=rev
Log:
WICKET-1955

Modified:

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java?rev=720939&r1=720938&r2=720939&view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java
 Wed Nov 26 10:42:34 2008
@@ -17,6 +17,7 @@
 package org.apache.wicket.markup.resolver;
 
 import org.apache.wicket.MarkupContainer;
+import org.apache.wicket.Page;
 import org.apache.wicket.WicketRuntimeException;
 import org.apache.wicket.markup.ComponentTag;
 import org.apache.wicket.markup.MarkupException;
@@ -27,6 +28,7 @@
 import org.apache.wicket.markup.html.internal.HtmlHeaderContainer;
 import org.apache.wicket.markup.parser.filter.HtmlHeaderSectionHandler;
 import org.apache.wicket.markup.parser.filter.WicketTagIdentifier;
+import org.apache.wicket.util.resource.IResourceStream;
 
 /**
  * This is a tag resolver which handles  and 
tags. It must be
@@ -147,8 +149,15 @@
}
else
{
+   final Page page = container.getPage();
+   final String pageClassName = (page != null) ? 
page.getClass().getName() : "unknown";
+   final IResourceStream stream = 
markupStream.getResource();
+   final String streamName = (stream != null) ? 
stream.toString() : "unknown";
+
throw new MarkupException(
-   "Mis-placed . 
 must be outside of , , and 
");
+   "Mis-placed . 
 must be outside of , , and 
. Error occured while rendering page: " +
+   pageClassName + " using markup 
stream: " + streamName);
+
}
 
// Yes, we handled the tag

svn commit: r720936 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java

2008-11-26 Thread ivaynberg

Author: ivaynberg
Date: Wed Nov 26 10:34:19 2008
New Revision: 720936

URL: http://svn.apache.org/viewvc?rev=720936&view=rev
Log:
WICKET-1955

Modified:

wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java

Modified: 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java?rev=720936&r1=720935&r2=720936&view=diff
==
--- 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java
 (original)
+++ 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java
 Wed Nov 26 10:34:19 2008
@@ -66,7 +66,7 @@
 * @return true, if componentId was handle by the resolver. False, 
otherwise
 */
public boolean resolve(final MarkupContainer container, final 
MarkupStream markupStream,
-   final ComponentTag tag)
+   final ComponentTag tag)
{
// Only  component tags have the id == "_header"
if (tag.getId().equals(HtmlHeaderSectionHandler.HEADER_ID))
@@ -74,7 +74,7 @@
// Create a special header component which will gather 
additional
// input the  from 'contributors'.
final WebMarkupContainer header = new 
HtmlHeaderContainer(
-   HtmlHeaderSectionHandler.HEADER_ID + 
container.getPage().getAutoIndex());
+   HtmlHeaderSectionHandler.HEADER_ID + 
container.getPage().getAutoIndex());
container.autoAdd(header, markupStream);
 
// Yes, we handled the tag
@@ -90,14 +90,14 @@
// Create a special header component which will 
gather
// additional input the  from 
'contributors'.
final MarkupContainer header = new 
HtmlHeaderContainer(
-   
HtmlHeaderSectionHandler.HEADER_ID + container.getPage().getAutoIndex());
+   HtmlHeaderSectionHandler.HEADER_ID + 
container.getPage().getAutoIndex());
 
// It is . Because they do not 
provide any
// additional functionality they are merely a 
means of surrounding relevant
// markup. Thus we simply create a 
WebMarkupContainer to handle
// the tag.
final WebMarkupContainer header2 = new 
WebMarkupContainer(
-   
HtmlHeaderSectionHandler.HEADER_ID)
+   HtmlHeaderSectionHandler.HEADER_ID)
{
private static final long 
serialVersionUID = 1L;
 
@@ -120,7 +120,7 @@
// relevant markup. Thus we simply create a 
WebMarkupContainer to handle
// the tag.
final WebMarkupContainer header = new 
WebMarkupContainer(
-   
HtmlHeaderSectionHandler.HEADER_ID)
+   HtmlHeaderSectionHandler.HEADER_ID)
{
private static final long 
serialVersionUID = 1L;
 
@@ -138,15 +138,15 @@
catch (IllegalArgumentException ex)
{
throw new WicketRuntimeException("If 
the root exception says something like "
-   + "\"A child with id 
'_header' already exists\" "
-   + "then you most likely 
forgot to override autoAdd() "
-   + "in your bordered 
page component.", ex);
+   + "\"A child with id '_header' 
already exists\" "
+   + "then you most likely forgot 
to override autoAdd() "
+   + "in your bordered page 
component.", ex);
}
}
else
{
throw new MarkupException(
-   "Mis-placed . 
 must be outside of  and ");
+   "Mis-placed . 
 must be outside of , , and 
");

svn commit: r720935 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java

2008-11-26 Thread ivaynberg

Author: ivaynberg
Date: Wed Nov 26 10:32:54 2008
New Revision: 720935

URL: http://svn.apache.org/viewvc?rev=720935&view=rev
Log:
WICKET-1955

Modified:

wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java?rev=720935&r1=720934&r2=720935&view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/HtmlHeaderResolver.java
 Wed Nov 26 10:32:54 2008
@@ -148,7 +148,7 @@
else
{
throw new MarkupException(
-   "Mis-placed . 
 must be outside of  and ");
+   "Mis-placed . 
 must be outside of , , and 
");
}
 
// Yes, we handled the tag

[jira] Closed: (WICKET-1653) Invalid argument in wicket-ajax.js (line 606) causes not loading ajax lazy load panel in IE

2008-11-26 Thread Matej Knopp (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matej Knopp closed WICKET-1653.
---

Resolution: Fixed

> Invalid argument in wicket-ajax.js (line 606) causes not loading ajax lazy 
> load panel in IE
> ---
>
> Key: WICKET-1653
> URL: https://issues.apache.org/jira/browse/WICKET-1653
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.3
> Environment: IE6.0.2900.2180 on xp
>Reporter: Per Newgro
>Assignee: Matej Knopp
>Priority: Critical
>
> see description at 
> http://www.nabble.com/javascript-error-in-internet-explorer-td16732896.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (WICKET-1921) Add an extension of AutoCompleteTextField which includes default css

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg reassigned WICKET-1921:
-

Assignee: Timo Rantalaiho

> Add an extension of AutoCompleteTextField which includes default css
> 
>
> Key: WICKET-1921
> URL: https://issues.apache.org/jira/browse/WICKET-1921
> Project: Wicket
>  Issue Type: Improvement
>Affects Versions: 1.4-M3
>Reporter: Antony Stubbs
>Assignee: Timo Rantalaiho
> Attachments: defaultcss.patch, wicket.rar
>
>
> The component doesn't seem to work very well without some basic CSS. Adding 
> this will help people get started with it / demonstrate the css.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1936) Client-Side Image Map

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg updated WICKET-1936:
--

Fix Version/s: 1.5-M1

> Client-Side Image Map
> -
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.5, 1.4-RC1
>Reporter: James Carman
> Fix For: 1.5-M1
>
> Attachments: ClientSideImageMap.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any 
> Image component.  Also, it only works with Link objects (and thus not 
> AjaxLinks or ExternalLinks).  The new client-side image map implementation 
> attaches itself to any existing image and supports any AbstractLink object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1945) make wicket's configuration type an enum

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg updated WICKET-1945:
--

Fix Version/s: 1.5-M1

> make wicket's configuration type an enum
> 
>
> Key: WICKET-1945
> URL: https://issues.apache.org/jira/browse/WICKET-1945
> Project: Wicket
>  Issue Type: Improvement
>  Components: site
>Reporter: Peter Ertl
> Fix For: 1.5-M1
>
>
> I would suggest that (starting with wicket 1.5.x) the wicket configuration 
> type should be converted to an enum.
> current:
>   String org.apache.wicket.Application.getConfigurationType()
> future:
> ConfigurationType org.apache.wicket.Application.getConfigurationType()
> 
>   package org.apache.wicket;
>   public enum ConfigurationType
>   {
> DEVELOPMENT, DEPLOYMENT
>   }
> enum have a lot of benefits, e.g. cover all cases in a case block or having 
> no upper- or lower-case inconsistencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-1948) rc1 generics - RatingPanel

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1948.
---

   Resolution: Fixed
Fix Version/s: 1.4-RC2
 Assignee: Igor Vaynberg

> rc1 generics - RatingPanel
> --
>
> Key: WICKET-1948
> URL: https://issues.apache.org/jira/browse/WICKET-1948
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 1.4-RC1
>Reporter: Adrian Sandor
>Assignee: Igor Vaynberg
> Fix For: 1.4-RC2
>
>
> RatingPanel now requires an IModel for the rating, but I was using 
> IModel. How can I show "rated 3.6 from 7 votes" now? Can it use 
> IModel instead?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

svn commit: r720932 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel.java

2008-11-26 Thread ivaynberg

Author: ivaynberg
Date: Wed Nov 26 10:26:11 2008
New Revision: 720932

URL: http://svn.apache.org/viewvc?rev=720932&view=rev
Log:
WICKET-1948

Modified:

wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel.java

Modified: 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel.java?rev=720932&r1=720931&r2=720932&view=diff
==
--- 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel.java
 (original)
+++ 
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel.java
 Wed Nov 26 10:26:11 2008
@@ -142,9 +142,8 @@
// add the star image, which is either active 
(highlighted) or
// inactive (no star)
link.add(new WebMarkupContainer("star").add(new 
SimpleAttributeModifier("src",
-   (onIsStarActive(iteration)
-   ? 
getActiveStarUrl(iteration)
-   : 
getInactiveStarUrl(iteration);
+   (onIsStarActive(iteration) ? 
getActiveStarUrl(iteration)
+   : getInactiveStarUrl(iteration);
item.add(link);
}
}
@@ -156,13 +155,13 @@
 * Star image for no selected star
 */
public static final ResourceReference STAR0 = new 
ResourceReference(RatingPanel.class,
-   "star0.gif");
+   "star0.gif");
 
/**
 * Star image for selected star
 */
public static final ResourceReference STAR1 = new 
ResourceReference(RatingPanel.class,
-   "star1.gif");
+   "star1.gif");
 
/**
 * The number of stars that need to be shown, should result in an 
Integer object.
@@ -172,12 +171,12 @@
/**
 * The number of votes that have been cast, should result in an Integer 
object.
 */
-   private IModel nrOfVotes;
+   private final IModel nrOfVotes;
 
/**
 * The flag on whether the current user has voted already.
 */
-   private IModel hasVoted;
+   private final IModel hasVoted;
 
/**
 * Handle to the rating label to set the visibility.
@@ -204,7 +203,7 @@
 * @param rating
 *the model to get the rating
 */
-   public RatingPanel(String id, IModel rating)
+   public RatingPanel(String id, IModel rating)
{
this(id, rating, new Model(5), null, new 
Model(Boolean.FALSE), true);
}
@@ -236,10 +235,11 @@
 * @param addDefaultCssStyle
 *should this component render its own default CSS style?
 */
-   public RatingPanel(String id, IModel rating, int nrOfStars, 
boolean addDefaultCssStyle)
+   public RatingPanel(String id, IModel rating, int 
nrOfStars,
+   boolean addDefaultCssStyle)
{
this(id, rating, new Model(nrOfStars), null, new 
Model(Boolean.FALSE),
-   addDefaultCssStyle);
+   addDefaultCssStyle);
}
 
/**
@@ -258,11 +258,11 @@
 * @param addDefaultCssStyle
 *should this component render its own default CSS style?
 */
-   public RatingPanel(String id, IModel rating, int nrOfStars, 
IModel nrOfVotes,
-   boolean addDefaultCssStyle)
+   public RatingPanel(String id, IModel rating, int 
nrOfStars,
+   IModel nrOfVotes, boolean addDefaultCssStyle)
{
-   this(id, rating, new Model(nrOfStars), nrOfVotes, new 
Model(Boolean.FALSE),
-   addDefaultCssStyle);
+   this(id, rating, new Model(nrOfStars), nrOfVotes,
+   new Model(Boolean.FALSE), addDefaultCssStyle);
}
 
/**
@@ -283,8 +283,8 @@
 * @param addDefaultCssStyle
 *should this component render its own default CSS style?
 */
-   public RatingPanel(String id, IModel rating, IModel 
nrOfStars, IModel nrOfVotes,
-   IModel hasVoted, boolean addDefaultCssStyle)
+   public RatingPanel(String id, IModel rating, 
IModel nrOfStars,
+   IModel nrOfVotes, IModel hasVoted, boolean 
addDefaultCssStyle)
{
super(id, rating);
 
@@ -347,7 +347,8 @@
 *the model containing the number of votes (may be null)
 * @return the label component showing the message.
 */
-   protected Component newRatingLabel(String id, IModel

[jira] Assigned: (WICKET-1949) rc1 generics - BaseTree

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg reassigned WICKET-1949:
-

Assignee: Matej Knopp

> rc1 generics - BaseTree
> ---
>
> Key: WICKET-1949
> URL: https://issues.apache.org/jira/browse/WICKET-1949
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-RC1
>Reporter: Adrian Sandor
>Assignee: Matej Knopp
>
> The second BaseTree constructor requires IModel; I was using a 
> Model with a DefaultTreeModel object, but I can't do that anymore (TreeModel 
> is not necessarily Serializable). Why not just require IModel TreeModel> ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[CONF] Apache Wicket: Wicket Session Size (page edited)

2008-11-26 Thread confluence











Page Edited :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been edited by jWeekend
(Nov 26, 2008).
 

 
 (View changes)
 

Content:
Let's start with some bullet points we can flesh out. When we have enough information we can organise it to create a cohesive and valuable document.

Introduction


Stateful Web Applications


Server Side State vs Client  Side State


Versioning


Back Button


Page Maps


Why Does It Matter?


Identifying The Problem


Map Size


Testing


Profiling


Detachable Models


Stateful vs Stateless


Beware ...



Non-static inner classes

Non-static inner classes can access the state of the enclosing object. To do this, the byte code of the inner-class contains a reference to the outer-class instance. So, when the inner-class instace is serialised, the outer-class instance will be serialised too!

Other Gotchas ...











Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[jira] Assigned: (WICKET-1947) rc1 generics - LabelTree

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg reassigned WICKET-1947:
-

Assignee: Matej Knopp

> rc1 generics - LabelTree
> 
>
> Key: WICKET-1947
> URL: https://issues.apache.org/jira/browse/WICKET-1947
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-RC1
>Reporter: Adrian Sandor
>Assignee: Matej Knopp
>
> LabelTree.getNodeTextModel requires IModel and returns 
> IModel. I was overriding it and returning a Model, but I 
> can't do that anymore. Why not just return IModel ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-1957) Odd number of page parameters - should not throw IllegalStateException

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1957.
---

Resolution: Won't Fix
  Assignee: Igor Vaynberg

the problem here is that these strategies expect param-name/param-value pairs. 
so if you enter for example /a/b/c what is c? do we create a parameter called 
"c" with a "null" value? or do we create a parameter with "null" name and value 
"c"? these strategie are made to work with parameter PAIRS. if you want 
something that just lets you access an arbitrary string of parameters use 
IndexedParamUrlCodingStrategy

> Odd number of page parameters - should not throw IllegalStateException
> --
>
> Key: WICKET-1957
> URL: https://issues.apache.org/jira/browse/WICKET-1957
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 1.4-RC1
>Reporter: Stefan Simik
>Assignee: Igor Vaynberg
> Attachments: 
> ExtendedBookmarkablePageRequestTargetUrlCodingStrategy.java
>
>
> The default URL strategy in wicket throws IllegalStateException, when there 
> is odd number of parameters ?
> See AbstractRequestTargetUrlCodingStrategy: line 169 in RC1
> We have a problem with this way handling, because our users rewrite URLs 
> manually
> (we cannot prevent users from doing this).
> Our pages are stateless and they don't use any parameters - BUT there are 
> throwing exceptions
> and showing InternalErrorPage-s. It is presented like a serious problem like 
> DB, or like service failed
> but there is no problem actually - only parameters, that are not used.
> I think, that page parameters should not result in INTERNAL ERROR,
> because there are many cases, where this is not relevant.
> There should be an alternative way - some custom handling or ignoring 
> parameters in such a situation.
> The same problem is with MixedParamUrlCodingStrategy:
> (See MixedParamUrlCodingStrategy: line 181)  in RC1
> 
> Adding additional parameter results in exception a internal-error page.
> IMHO, additional parameters should be ignored and not result in error.
> I would suggest add the latest odd parameter to page parameters, but with 
> empty value "".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[CONF] Apache Wicket: Wicket Session Size (page edited)

2008-11-26 Thread confluence











Page Edited :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been edited by jWeekend
(Nov 26, 2008).
 

 
 (View changes)
 

Content:
Let's start with some bullet points we can flesh out. When we have enough information we can organise it to create a cohesive and valuable document.

Introduction


Stateful Web Applications


Server Side State vs Client  Side State


Versioning


Back Button


Page Maps


Why Does It Matter?


Identifying The Problem


Map Size


Testing


Profiling


Detachable Models


Stateful vs Stateless


Gotchas


Non-static inner classes

Non-static inner classes can access the state of the enclosing object. To do this, the byte code of the inner-class contains a reference to the outer-class instance. So, when the inner-class instace is serialised, the outer-class instance will be serialised too!











Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[jira] Resolved: (WICKET-1951) MixedParamUrlCodingStrategy should not throw exception, if there is more parameters, than expected

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1951.
---

Resolution: Won't Fix
  Assignee: Igor Vaynberg

the method decodeParameters(String urlFragment, Map urlParameters) which throws 
this error is protected, feel free to override it to work without throwing the 
exception.

> MixedParamUrlCodingStrategy should not throw exception, if there is more 
> parameters, than expected
> --
>
> Key: WICKET-1951
> URL: https://issues.apache.org/jira/browse/WICKET-1951
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-RC1
>Reporter: Stefan Simik
>Assignee: Igor Vaynberg
>
> MixedParamUrlCodingStrategy should not throw exception, if there is more 
> parameters, than expected.
> The problem is in MixedParamUrlCodingStrategy.java, line: 181
> Example: 
> We have url, that displays info domain yahoo.com :
> "http://server/domain/yahoo.com";,or about google.com:  
> "http://server/domain/google.com";
> Page is mounted using MixedParamUrlCodingStrategy:
> mount(new MixedParamUrlCodingStrategy("domain", DomainInfoPage.class, new 
> String[]{ DomainInfoPage.PARAMETER_DOMAIN_NAME }));
> When user types URL, that has more parameters, then we specified in mount  
> for example "http://server/domain/google.com/asdf";   --->>> GETS AN ERROR  !!!
> But there is no reason for such an error, because only first parameter is 
> required, additional can be ignored - without any errors.
> Use case is, that our users often rewrite URL directly and such typo results 
> in error, and we have no possibility to handle this
> and show the page - all the needed information is in URL, so there is no 
> reason to throw exception, when there is more information.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-1946) Please make RequestLogger.log(RequestData, SessionData) protected

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1946.
---

   Resolution: Fixed
Fix Version/s: (was: 1.3.6)
 Assignee: Igor Vaynberg

> Please make RequestLogger.log(RequestData, SessionData) protected
> -
>
> Key: WICKET-1946
> URL: https://issues.apache.org/jira/browse/WICKET-1946
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.3.6, 1.4-RC2
>Reporter: Jeremy Thomerson
>Assignee: Igor Vaynberg
>Priority: Trivial
> Fix For: 1.4-RC2
>
> Attachments: 1946-requestlogger.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Could we please make the method above protected (rather than private).  This 
> makes it very simple to do something like this:
>  
> @Override
> protected IRequestLogger newRequestLogger() {
> return new RequestLogger() {
> @Override
> protected void log(RequestData rd, SessionData sd) {
> // do my custom logging HERE
> }
> };
> }
>  
> ALSO - it would be real nice if at the same time you extract that creation of 
> the AppendingStringBuffer to a method, so that the log method now looks like:
>  
> protected void log(RequestData rd, SessionData sd)
> {
> if (log.isInfoEnabled())
> {
> log.info(createStringBuffer(rd, sd, true);
> }
> }
> protected final void createStringBuffer(RequestData rd, SessionData sd, 
> boolean includeRuntimeInfo) 
> {
> ... all of the stuff that was taken out of log that creates the ASB
> if (includeRuntimeInfo)
> {
> Runtime runtime = Runtime.getRuntime();
> long max = runtime.maxMemory() / 100;
> long total = runtime.totalMemory() / 100;
> long used = total - runtime.freeMemory() / 100;
> asb.append(",maxmem=");
> asb.append(max);
> asb.append("M,total=");
> asb.append(total);
> asb.append("M,used=");
> asb.append(used);
> asb.append("M");
> }
> return asb;
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1937) Enclosure with fallback section

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg updated WICKET-1937:
--

Fix Version/s: 1.5-M1

> Enclosure with fallback section
> ---
>
> Key: WICKET-1937
> URL: https://issues.apache.org/jira/browse/WICKET-1937
> Project: Wicket
>  Issue Type: Wish
>  Components: wicket
>Reporter: Peter Parson
>Priority: Minor
> Fix For: 1.5-M1
>
>
> Enclosures would be even more useful, if a "fallback section" could be 
> defined which is displayed only when the enclosure is not displayed.
> This way, an explanatory message like "No items in this list" or similar 
> could be displayed quite easily.
> e.g.
> 
> 
> 
> 
> 
> Sorry - nothing to display here. 
> 
> 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

svn commit: r720928 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/RequestLogger.java

2008-11-26 Thread ivaynberg

Author: ivaynberg
Date: Wed Nov 26 10:12:17 2008
New Revision: 720928

URL: http://svn.apache.org/viewvc?rev=720928&view=rev
Log:
WICKET-1946

Modified:

wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/RequestLogger.java

Modified: 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/RequestLogger.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/RequestLogger.java?rev=720928&r1=720927&r2=720928&view=diff
==
--- 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/RequestLogger.java
 (original)
+++ 
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/RequestLogger.java
 Wed Nov 26 10:12:17 2008
@@ -274,40 +274,49 @@
 * @param rd
 * @param sd
 */
-   private void log(RequestData rd, SessionData sd)
+   protected void log(RequestData rd, SessionData sd)
{
if (log.isInfoEnabled())
{
-   AppendingStringBuffer asb = new 
AppendingStringBuffer(150);
-   asb.append("time=");
-   asb.append(rd.getTimeTaken());
-   asb.append(",event=");
-   asb.append(rd.getEventTarget());
-   asb.append(",response=");
-   asb.append(rd.getResponseTarget());
-   if (rd.getSessionInfo() != null && 
!rd.getSessionInfo().equals(""))
-   {
-   asb.append(",sessioninfo=");
-   asb.append(rd.getSessionInfo());
-   }
-   else
-   {
-   asb.append(",sessionid=");
-   asb.append(rd.getSessionId());
-   }
-   asb.append(",sessionsize=");
-   asb.append(rd.getSessionSize());
-   if (sd != null)
-   {
-   asb.append(",sessionstart=");
-   asb.append(sd.getStartDate());
-   asb.append(",requests=");
-   asb.append(sd.getNumberOfRequests());
-   asb.append(",totaltime=");
-   asb.append(sd.getTotalTimeTaken());
-   }
-   asb.append(",activerequests=");
-   asb.append(rd.getActiveRequest());
+   log.info(createLogString(rd, sd, true).toString());
+   }
+   }
+
+   protected final AppendingStringBuffer createLogString(RequestData rd, 
SessionData sd,
+   boolean includeRuntimeInfo)
+   {
+   AppendingStringBuffer asb = new AppendingStringBuffer(150);
+   asb.append("time=");
+   asb.append(rd.getTimeTaken());
+   asb.append(",event=");
+   asb.append(rd.getEventTarget());
+   asb.append(",response=");
+   asb.append(rd.getResponseTarget());
+   if (rd.getSessionInfo() != null && 
!rd.getSessionInfo().equals(""))
+   {
+   asb.append(",sessioninfo=");
+   asb.append(rd.getSessionInfo());
+   }
+   else
+   {
+   asb.append(",sessionid=");
+   asb.append(rd.getSessionId());
+   }
+   asb.append(",sessionsize=");
+   asb.append(rd.getSessionSize());
+   if (sd != null)
+   {
+   asb.append(",sessionstart=");
+   asb.append(sd.getStartDate());
+   asb.append(",requests=");
+   asb.append(sd.getNumberOfRequests());
+   asb.append(",totaltime=");
+   asb.append(sd.getTotalTimeTaken());
+   }
+   asb.append(",activerequests=");
+   asb.append(rd.getActiveRequest());
+   if (includeRuntimeInfo)
+   {
Runtime runtime = Runtime.getRuntime();
long max = runtime.maxMemory() / 100;
long total = runtime.totalMemory() / 100;
@@ -319,8 +328,8 @@
asb.append("M,used=");
asb.append(used);
asb.append("M");
-   log.info(asb.toString());
}
+   return asb;
}
 
private Object getSessionInfo(Session session)

[jira] Assigned: (WICKET-1922) AbstractTree - setting root to null causes NullPointerException

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg reassigned WICKET-1922:
-

Assignee: Matej Knopp

> AbstractTree - setting root to null causes NullPointerException
> ---
>
> Key: WICKET-1922
> URL: https://issues.apache.org/jira/browse/WICKET-1922
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.5
> Environment: JDK 1.6.0_01
>Reporter: Vlastimil
>Assignee: Matej Knopp
>
> I have TreeTable with some nodes, perform some filtering of them and update 
> tree model. If result of filtering is nothing (empty Tree) I set 
> setRoot(null) on the tree model. This send treeStructureChanged event to all 
> listeners (to my TreeTable) with parameter TreeModelEvent which is 
> constructed with null TreePath parameter. This cause NullPointerException in 
> AbstractTree (implements TreeModelListener).
> I propose this fix:
> org.apache.wicket.markup.html.tree.AbstractTree
> /**
>* @see 
> javax.swing.event.TreeModelListener#treeStructureChanged(javax.swing.event.TreeModelEvent)
>*/
>   public final void treeStructureChanged(TreeModelEvent e)
>   {
>   // empty root
>   if(e.getTreePath() == null) {
>   invalidateAll();
>   } 
>   else {
>   // get the parent node of changed nodes
>   TreeNode node = 
> (TreeNode)e.getTreePath().getLastPathComponent();
>   // has the tree root changed?
>   if (e.getTreePath().getPathCount() == 1 && 
> node.equals(rootItem.getModelObject()))
>   {
>   invalidateAll();
>   }
>   else
>   {
>   invalidateNodeWithChildren(node);
>   }
>   }
>   }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-1954) Component.isVisibilityAllowed() not consulted before calling onBeforeRender()

2008-11-26 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-1954.
---

Resolution: Fixed
  Assignee: Igor Vaynberg

> Component.isVisibilityAllowed() not consulted before calling onBeforeRender()
> -
>
> Key: WICKET-1954
> URL: https://issues.apache.org/jira/browse/WICKET-1954
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.5
>Reporter: Nikita Tovstoles
>Assignee: Igor Vaynberg
>
> I have a component whose parent does this:
> class Parent extends Panel
> private Component child;
> onBeforeRender()
> {
> child.setVisibilityAllowed(false);
> super.onBeforeRender();
> }
> I would expect child's onBeforeRender() to not be executed but it is, because 
> Component.internalBeforeRender calls isVisible() rather than 
> determineVisibility().
> Shouldn't the following line in Component.internalBeforeRender():
> if ((isVisible() || callOnBeforeRenderIfNotVisible()) && 
> !getFlag(FLAG_RENDERING) &&
> !getFlag(FLAG_PREPARED_FOR_RENDER))
> be this:
> if ((determineVisibility() || 
> callOnBeforeRenderIfNotVisible()) && !getFlag(FLAG_RENDERING) &&
> !getFlag(FLAG_PREPARED_FOR_RENDER))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

svn commit: r720926 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Component.java

2008-11-26 Thread ivaynberg

Author: ivaynberg
Date: Wed Nov 26 10:05:50 2008
New Revision: 720926

URL: http://svn.apache.org/viewvc?rev=720926&view=rev
Log:
WICKET-1954

Modified:

wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Component.java

Modified: 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Component.java
URL: 
http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Component.java?rev=720926&r1=720925&r2=720926&view=diff
==
--- 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Component.java
 (original)
+++ 
wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/Component.java
 Wed Nov 26 10:05:50 2008
@@ -456,7 +456,8 @@
 * 
 * 
 * 
-* User u = (User)getModelObject(); u.setName("got you 
there!");
+* User u = (User)getModelObject();
+* u.setName("got you there!");
 * 
 * 
 * 
@@ -478,11 +479,12 @@
 * The 'normal' use is for controlling whether a component is 
rendered without having any
 * effect on the rest of the processing. If a strategy lets this method 
return 'false', then the
 * target component and its children will not be rendered, in the same 
fashion as if that
-* component had visibility property 'false'. The other use is 
when a component should
-* block the rendering of the whole page. So instead of 'hiding' a 
component, what we generally
-* want to achieve here is that we force the user to 
logon/give-credentials for a higher level
-* of authorization. For this functionality, the strategy 
implementation should throw a
-* [EMAIL PROTECTED] AuthorizationException}, which will then be 
handled further by the framework.
+* component had visibility property 'false'.
+* The other use is when a component should block the rendering of 
the whole page. So
+* instead of 'hiding' a component, what we generally want to achieve 
here is that we force the
+* user to logon/give-credentials for a higher level of authorization. 
For this functionality,
+* the strategy implementation should throw a [EMAIL PROTECTED] 
AuthorizationException}, which will then be
+* handled further by the framework.
 * 
 * 
 */
@@ -685,10 +687,10 @@
 * What's stored here depends on what attributes are set on component. 
Data can contains
 * combination of following attributes:
 * 
-* Model (indicated by [EMAIL PROTECTED] #FLAG_MODEL_SET}) 
MetaDataEntry (optionally
-* [EMAIL PROTECTED] MetaDataEntry}[] if more metadata entries are 
present) * [EMAIL PROTECTED] IBehavior}(s)
-* added to component. The behaviors are not stored in separate array, 
they are part of the
-* [EMAIL PROTECTED] #data} array
+* Model (indicated by [EMAIL PROTECTED] #FLAG_MODEL_SET})
+* MetaDataEntry (optionally [EMAIL PROTECTED] MetaDataEntry}[] if 
more metadata entries are present) *
+* [EMAIL PROTECTED] IBehavior}(s) added to component. The 
behaviors are not stored in separate array,
+* they are part of the [EMAIL PROTECTED] #data} array
 * 
 * If there is only one attribute set (i.e. model or MetaDataEntry([]) 
or one behavior), the
 * #data object points directly to value of that attribute. Otherwise 
the data is of type
@@ -994,8 +996,8 @@
 
private final void internalBeforeRender()
{
-   if ((isVisible() || callOnBeforeRenderIfNotVisible()) && 
!getFlag(FLAG_RENDERING) &&
-   !getFlag(FLAG_PREPARED_FOR_RENDER))
+   if ((determineVisibility() || callOnBeforeRenderIfNotVisible()) 
&&
+   !getFlag(FLAG_RENDERING) && 
!getFlag(FLAG_PREPARED_FOR_RENDER))
{
setFlag(FLAG_BEFORE_RENDERING_SUPER_CALL_VERIFIED, 
false);
 
@@ -2575,7 +2577,8 @@
/**
 * Replaces this component with another. The replacing component must 
have the same component id
 * as this component. This method serves as a shortcut to 
-* this.getParent().replace(replacement) and provides a better 
context for errors.
+* this.getParent().replace(replacement)
+* and provides a better context for errors.
 * 
 * @since 1.2.1
 * 
@@ -3667,7 +3670,7 @@
/**
 * Called just before a component is rendered.
 * 
-* *NOTE* If you override this, you *must* call super.onBeforeRender() 
within your
+* NOTE* If you override this, you *must* call super.onBeforeRender() 
within your
 * implementation.
 * 
 * Because this method is responsible for cascading [EMAIL PROTECTED] 
#onBeforeRender()} call to its

svn commit: r720927 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java

2008-11-26 Thread ivaynberg

Author: ivaynberg
Date: Wed Nov 26 10:06:14 2008
New Revision: 720927

URL: http://svn.apache.org/viewvc?rev=720927&view=rev
Log:
WICKET-1954

Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java

Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
URL: 
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java?rev=720927&r1=720926&r2=720927&view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java 
(original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java Wed Nov 
26 10:06:14 2008
@@ -1028,8 +1028,8 @@
 
private final void internalBeforeRender()
{
-   if ((isVisible() || callOnBeforeRenderIfNotVisible()) && 
!getFlag(FLAG_RENDERING) &&
-   !getFlag(FLAG_PREPARED_FOR_RENDER))
+   if ((determineVisibility() || callOnBeforeRenderIfNotVisible()) 
&&
+   !getFlag(FLAG_RENDERING) && 
!getFlag(FLAG_PREPARED_FOR_RENDER))
{
setFlag(FLAG_BEFORE_RENDERING_SUPER_CALL_VERIFIED, 
false);

[jira] Commented: (WICKET-1960) AutoCompleteTextField - gives a type mismatch error on IE - version wicket-1.4-rc1

2008-11-26 Thread Jeremy Thomerson (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651046#action_12651046
 ] 

Jeremy Thomerson commented on WICKET-1960:
--

I'm pretty sure this was already fixed.  I just ran into the same yesterday.  
Upgraded from rc1 to snapshot and it's working.  Just commenting on it so that 
whoever goes to fix it doesn't spin their wheels trying to reproduce if it's 
already workin.

> AutoCompleteTextField - gives a type mismatch error on IE - version 
> wicket-1.4-rc1
> --
>
> Key: WICKET-1960
> URL: https://issues.apache.org/jira/browse/WICKET-1960
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 1.4-RC1
>Reporter: Dipu C Seminlal
> Fix For: 1.4-RC1
>
> Attachments: wicket-autocomplete-patch.txt
>
>
> wicket-autocomplete.js
> function function showAutoComplete()
> line 291 container.style.zIndex=(!isNaN(Number(index))?Number(index)+1:index);
> looks like IE doesn't like big i in zIndex, IE seem to be be happy with 
> zindex 
> not sure if that's the correct way to resolve the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Issue Comment Edited: (WICKET-1960) AutoCompleteTextField - gives a type mismatch error on IE - version wicket-1.4-rc1

2008-11-26 Thread Jeremy Thomerson (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651046#action_12651046
 ] 

jthomerson edited comment on WICKET-1960 at 11/26/08 8:31 AM:


I'm pretty sure this was already fixed.  I just ran into the same yesterday.  
Upgraded from rc1 to snapshot and it's working.  Just commenting on it so that 
whoever goes to fix it doesn't spin their wheels trying to reproduce if it's 
already working.

  was (Author: jthomerson):
I'm pretty sure this was already fixed.  I just ran into the same 
yesterday.  Upgraded from rc1 to snapshot and it's working.  Just commenting on 
it so that whoever goes to fix it doesn't spin their wheels trying to reproduce 
if it's already workin.
  
> AutoCompleteTextField - gives a type mismatch error on IE - version 
> wicket-1.4-rc1
> --
>
> Key: WICKET-1960
> URL: https://issues.apache.org/jira/browse/WICKET-1960
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 1.4-RC1
>Reporter: Dipu C Seminlal
> Fix For: 1.4-RC1
>
> Attachments: wicket-autocomplete-patch.txt
>
>
> wicket-autocomplete.js
> function function showAutoComplete()
> line 291 container.style.zIndex=(!isNaN(Number(index))?Number(index)+1:index);
> looks like IE doesn't like big i in zIndex, IE seem to be be happy with 
> zindex 
> not sure if that's the correct way to resolve the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[CONF] Apache Wicket: Wicket Session Size (page edited)

2008-11-26 Thread confluence











Page Edited :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been edited by jWeekend
(Nov 26, 2008).
 

 
 (View changes)
 

Content:
Let's start with some bullet points we can flesh out. When we have enough information we can organise it to create a cohesive and valuable document.

Introduction


Stateful Web Applications


Server Side State vs Client  Side State


Versioning


Back Button


Page Maps


Why Does It Matter?


Identifying The Problem


Map Size


Testing


Profiling



Detachable Models


Stateful vs Stateless


Gotchas


	Use of non-static inner classes: non-static inner classes can access the state of the enclosing object. To do this, the byte code of the inner-class contains a reference to the outer-class instance. So, when the inner-class instace is serialised, the outer-class instance will be serialised too!













Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[CONF] Apache Wicket: Wicket Session Size (page edited)

2008-11-26 Thread confluence











Page Edited :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been edited by jWeekend
(Nov 26, 2008).
 

 
 (View changes)
 

Content:
Let's start with some bullet points we can flesh out. When we have enough information we can organise it to create a cohesive and valuable document.

Introduction?


Stateful Web Applications


Server Side State vs Client  Side State


Versioning


Back Button


Page Maps


Why Does It Matter?


Identifying The Problem


Map Size


Testing


Profiling



Detachable Models


Stateful vs Stateless


Gotchas


	Use of non-static inner classes: non-static inner classes can access the state of the enclosing object. To do this, the byte code of the inner-class contains a reference to the outer-class instance. So, when the inner-class instace is serialised, the outer-class instance will be serialised too!













Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[CONF] Apache Wicket: Wicket Session Size (page edited)

2008-11-26 Thread confluence











Page Edited :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been edited by jWeekend
(Nov 26, 2008).
 

 
 (View changes)
 

Content:
Let's start with some bullet points we can flesh out. When we have enough information we can organise it to create a cohesive and valuable document.

What Is It?


Stateful Web Applications



Server Side State vs Client  Side State



Versioning



Back Button



Page Maps


Why Does It Matter?


Detachable Models


Stateful vs Stateless


Gotchas


	Use of non-static inner classes: non-static inner classes can access the state of the enclosing object. To do this, the byte code of the inner-class contains a reference to the outer-class instance. So, when the inner-class instace is serialised, the outer-class instance will be serialised too!













Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[CONF] Apache Wicket: Wicket Session Size (page edited)

2008-11-26 Thread confluence











Page Edited :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been edited by jWeekend
(Nov 26, 2008).
 

 
 (View changes)
 

Content:
Let's start with some bullet points we can flesh out. When we have enough information we can organise it to create a cohesive and valuable document.

What Is It?


Page Maps


Why Does It Matter?


Detachable Models


Stateful vs Stateless


Gotchas


	Use of non-static inner classes: non-static inner classes can access the state of the enclosing object. To do this, the byte code of the inner-class contains a reference to the outer-class instance. So, when the inner-class instace is serialised, the outer-class instance will be serialised too!













Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[CONF] Apache Wicket: Wicket Session Size (page edited)

2008-11-26 Thread confluence











Page Edited :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been edited by jWeekend
(Nov 26, 2008).
 

 
 (View changes)
 

Content:
Let's start with some bullet points we can flesh out. When we have enough information we can organise it to create a cohesive and valuable document.

What Is It?
Why Does It Matter?
Detachable Models
Stateful vs Stateless


Gotchas


	Use of non-static inner classes: non-static inner classes can access the state of the enclosing object. To do this, the byte code of the inner-class contains a reference to the outer-class instance. So, when the inner-class instace is serialised, the outer-class instance will be serialised too!













Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[CONF] Apache Wicket: Wicket Session Size (page edited)

2008-11-26 Thread confluence











Page Edited :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been edited by jWeekend
(Nov 26, 2008).
 

 
 (View changes)
 

Content:
Let's start with some bullet points we can flesh out. When we have enough information we can organise it to create a cohesive and valuable document.











Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[CONF] Apache Wicket: Wicket Session Size (page edited)

2008-11-26 Thread confluence











Page Edited :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been edited by jWeekend
(Nov 26, 2008).
 

 
 (View changes)
 

Content:
Let's start with some bullet points we can flesh out. When we have enough information we can organise it to create a cohesive and valuable document.

What Is It?
Why Does It Matter?
Detachable Models
Stateful vs Stateless


Gotchas


	Use of non-static inner classes: non-static inner classes can access the state of the enclosing object. To do this, the byte code of the inner-class contains a refrence to the outer-class instance. So, when the inner-class instace is serialised, you the outer-class instance will be serialised too!













Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[CONF] Apache Wicket: Wicket Session Size (page edited)

2008-11-26 Thread confluence











Page Edited :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been edited by jWeekend
(Nov 26, 2008).
 

 
 (View changes)
 

Content:
Let's start with some bullet points we can flesh out. When we have enough information we can organise it to create a cohesive and valuable document.

What Is It?
Why Does It Matter?
Detachable Models
Stateful vs Stateless


Gotchas:


	Use of non-static inner classes: non-static inner classes can access the state of the enclosing object. To do this, the byte code of the inner-class contains a refrence to the outer-class instance. So, when the inner-class instace is serialised, you the outer-class instance will be serialised too!













Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[CONF] Apache Wicket: Wicket Session Size (page edited)

2008-11-26 Thread confluence











Page Edited :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been edited by jWeekend
(Nov 26, 2008).
 

 
 (View changes)
 

Content:
Let's start with some bullet points we can flesh out. When we have enough information we can organise it to create a cohesive and valuable document.

What Is It?
Why Does It Matter?
Stateful vs Stateless

Gotchas:


	Use of non-static inner classes: non-static inner classes can access the state of the enclosing object. To do this, the byte code of the inner-class contains a refrence to the outer-class instance. So, when the inner-class instace is serialised, you the outer-class instance will be serialised too!













Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[CONF] Apache Wicket: Wicket Session Size (page edited)

2008-11-26 Thread confluence











Page Edited :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been edited by jWeekend
(Nov 26, 2008).
 

 
 (View changes)
 

Content:
Let's start with some bullet points we can flesh out. When we have enough information we can organise it to create a cohesive and valuable document.

Gotchas:


	Use of non-static inner classes: non-static inner classes can access the state of the enclosing object. To do this, the byte code of the inner-class contains a refrence to the outer-class instance. So, when the inner-class instace is serialised, you the outer-class instance will be serialised too!













Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[CONF] Apache Wicket: Wicket Session Size (page edited)

2008-11-26 Thread confluence











Page Edited :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been edited by jWeekend
(Nov 26, 2008).
 

 
 (View changes)
 

Content:
Let's start with some bullet points we can flesh out and then organise the information into a cohesive and valuable document.











Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[CONF] Apache Wicket: Wicket Session Size (comment added)

2008-11-26 Thread confluence











Comment Added :
WICKET :
Re: Wicket Session Size




Wicket Session Size
commented on by jWeekend
(Nov 26, 2008).


Comment:

	Use of non-static inner classes: non-static inner classes can access the state of the enclosing object. To do this, the byte code of the inner-class contains a refrence to the outer-class. So, when the inner-class instace is serialised, you the outer-class instance will be serialised too!













Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[jira] Created: (WICKET-1960) AutoCompleteTextField - gives a type mismatch error on IE - version wicket-1.4-rc1

2008-11-26 Thread Dipu C Seminlal (JIRA)

AutoCompleteTextField - gives a type mismatch error on IE - version 
wicket-1.4-rc1
--

 Key: WICKET-1960
 URL: https://issues.apache.org/jira/browse/WICKET-1960
 Project: Wicket
  Issue Type: Bug
  Components: wicket-extensions
Affects Versions: 1.4-RC1
Reporter: Dipu C Seminlal
 Fix For: 1.4-RC1


wicket-autocomplete.js
function function showAutoComplete()
line 291 container.style.zIndex=(!isNaN(Number(index))?Number(index)+1:index);

looks like IE doesn't like big i in zIndex, IE seem to be be happy with zindex 

not sure if that's the correct way to resolve the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[CONF] Apache Wicket: Wicket Session Size (page created)

2008-11-26 Thread confluence











Page Created :
WICKET :
Wicket Session Size



 
Wicket Session Size
has been created by jWeekend
(Nov 26, 2008).
 

Content:












Powered by
Atlassian Confluence
(Version: 2.2.9 Build:#527 Sep 07, 2006)
-
Bug/feature request

Unsubscribe or edit your notifications preferences

[jira] Updated: (WICKET-1960) AutoCompleteTextField - gives a type mismatch error on IE - version wicket-1.4-rc1

2008-11-26 Thread Dipu C Seminlal (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dipu C Seminlal updated WICKET-1960:


Attachment: wicket-autocomplete-patch.txt

patch with the mentioned fix 

> AutoCompleteTextField - gives a type mismatch error on IE - version 
> wicket-1.4-rc1
> --
>
> Key: WICKET-1960
> URL: https://issues.apache.org/jira/browse/WICKET-1960
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 1.4-RC1
>Reporter: Dipu C Seminlal
> Fix For: 1.4-RC1
>
> Attachments: wicket-autocomplete-patch.txt
>
>
> wicket-autocomplete.js
> function function showAutoComplete()
> line 291 container.style.zIndex=(!isNaN(Number(index))?Number(index)+1:index);
> looks like IE doesn't like big i in zIndex, IE seem to be be happy with 
> zindex 
> not sure if that's the correct way to resolve the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-599) Add Development Mode dashboard widget when deployed in development mode

2008-11-26 Thread James Perry (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650995#action_12650995
 ] 

James Perry commented on WICKET-599:


I suggest that this dashboard's "look & feel" should be congruent with its 
counterpart - Ajax debug dashboard - so it doesn't aesthetically clash. 

> Add Development Mode dashboard widget when deployed in development mode
> ---
>
> Key: WICKET-599
> URL: https://issues.apache.org/jira/browse/WICKET-599
> Project: Wicket
>  Issue Type: New Feature
>  Components: wicket
>Affects Versions: 1.3.0-beta1
>Reporter: Martijn Dashorst
> Fix For: 1.5-M1
>
> Attachments: screenshot-1.jpg
>
>
> It is considered bad practise to deploy your wicket application in 
> development mode in a production environment. Because several features 
> beneficial to development will make an application behave less than optimal 
> when confronted with lots of users and requests.
> The idea is to extend the Wicket Ajax Debug link and make it a full fledged 
> panel that is *always* visible when working in development mode. There will 
> not be a setting to turn this off. If someone wants to have the development 
> features available in a production environment, these can be enabled using 
> the settings object.
> Another idea, thanks to Korbinian Bachl is to add the Inspector Bug to this 
> widget, to enable introspection of the components on the page.
> The widget should be movable (so it does not obscure other markup elements), 
> and it should have a hide link to enable screen shots whilst still in 
> development mode (very useful when writing articles and books).
> A screen shot for this feature can be seen attached to this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1957) Odd number of page parameters - should not throw IllegalStateException

2008-11-26 Thread Stefan Simik (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Simik updated WICKET-1957:
-

Attachment: ExtendedBookmarkablePageRequestTargetUrlCodingStrategy.java

Simple patch for this issue, that we temporarily used, until the problem will 
be fixed in wicket.
Demonstrates my suggested solution,.


> Odd number of page parameters - should not throw IllegalStateException
> --
>
> Key: WICKET-1957
> URL: https://issues.apache.org/jira/browse/WICKET-1957
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 1.4-RC1
>Reporter: Stefan Simik
> Attachments: 
> ExtendedBookmarkablePageRequestTargetUrlCodingStrategy.java
>
>
> The default URL strategy in wicket throws IllegalStateException, when there 
> is odd number of parameters ?
> See AbstractRequestTargetUrlCodingStrategy: line 169 in RC1
> We have a problem with this way handling, because our users rewrite URLs 
> manually
> (we cannot prevent users from doing this).
> Our pages are stateless and they don't use any parameters - BUT there are 
> throwing exceptions
> and showing InternalErrorPage-s. It is presented like a serious problem like 
> DB, or like service failed
> but there is no problem actually - only parameters, that are not used.
> I think, that page parameters should not result in INTERNAL ERROR,
> because there are many cases, where this is not relevant.
> There should be an alternative way - some custom handling or ignoring 
> parameters in such a situation.
> The same problem is with MixedParamUrlCodingStrategy:
> (See MixedParamUrlCodingStrategy: line 181)  in RC1
> 
> Adding additional parameter results in exception a internal-error page.
> IMHO, additional parameters should be ignored and not result in error.
> I would suggest add the latest odd parameter to page parameters, but with 
> empty value "".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1931) FormTester doesn't correctly submit a form when a FileUploadField was not set (which is not required)

2008-11-26 Thread Marco Rico-Gomez (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marco Rico-Gomez updated WICKET-1931:
-

Attachment: wicket-1931.patch

I had the same problem and noticed that the class MockHttpServletRequest 
doesn't handle multipart form requests correct  if no files are available 
(uploadedFiles == null || uploadedFiles.size() == 0). 
I created a patch which adds a new test case in FormTesterTest and a possible 
bugfix in 
MockHttpServletRequest.

> FormTester doesn't correctly submit a form when a FileUploadField was not set 
> (which is not required)
> -
>
> Key: WICKET-1931
> URL: https://issues.apache.org/jira/browse/WICKET-1931
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-M3
> Environment: Windows XP PL SP 2, Java 1.6.0_10
>Reporter: Artur Wronski
> Attachments: wicket-1931.patch
>
>
> FormTester doesn't correctly submit a form when  a FileUploadField was not 
> set.
> This file is not required.
> So it is impossible to create a real test because I am forced to always set a 
> File to check to whole form.
> There was discussion about this problem here: 
> http://www.nabble.com/FormTester-and-FileUploadField-td18566869.html
> I will be very grateful if you can fix it :)
> Artur

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-1957) Odd number of page parameters - should not throw IllegalStateException

2008-11-26 Thread Vjacheslav Kanivetc (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650892#action_12650892
 ] 

Vjacheslav Kanivetc commented on WICKET-1957:
-

Yes, this is a very annoying behavior in 1.3 series of wicket as well, 
especially when we wish to allow people to modify url, for example, for 
username and password-protected rss with some extra parameters, the way like 
BookmarkablePageRequestTargetUrlCodingStrategy encodes the input, user is 
unable to enter for example /username/password/somemask, he needs to enter 
pairs of key-value.

Much better would be to simply pass resulting PageParameters to the handler 
that is going to accept the input

> Odd number of page parameters - should not throw IllegalStateException
> --
>
> Key: WICKET-1957
> URL: https://issues.apache.org/jira/browse/WICKET-1957
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 1.4-RC1
>Reporter: Stefan Simik
>
> The default URL strategy in wicket throws IllegalStateException, when there 
> is odd number of parameters ?
> See AbstractRequestTargetUrlCodingStrategy: line 169 in RC1
> We have a problem with this way handling, because our users rewrite URLs 
> manually
> (we cannot prevent users from doing this).
> Our pages are stateless and they don't use any parameters - BUT there are 
> throwing exceptions
> and showing InternalErrorPage-s. It is presented like a serious problem like 
> DB, or like service failed
> but there is no problem actually - only parameters, that are not used.
> I think, that page parameters should not result in INTERNAL ERROR,
> because there are many cases, where this is not relevant.
> There should be an alternative way - some custom handling or ignoring 
> parameters in such a situation.
> The same problem is with MixedParamUrlCodingStrategy:
> (See MixedParamUrlCodingStrategy: line 181)  in RC1
> 
> Adding additional parameter results in exception a internal-error page.
> IMHO, additional parameters should be ignored and not result in error.
> I would suggest add the latest odd parameter to page parameters, but with 
> empty value "".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

66 matches

Mail list logo