[jira] Created: (WICKET-2000) AjaxRequestTarget escapes ] to ]^
AjaxRequestTarget escapes ] to ]^ - Key: WICKET-2000 URL: https://issues.apache.org/jira/browse/WICKET-2000 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-RC1 Reporter: Jan Kriesten Fix For: 1.4-RC2 Current 1.4 trunk 'messes' with escaping ']' to ']^' on AjaxRequestTarget.appendJavascript which leeds to non-functional Javascript when using array indices on variables. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1431) Make the Source Code pages for examples stateless
[ https://issues.apache.org/jira/browse/WICKET-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juergen Donnerstag resolved WICKET-1431. Resolution: Fixed Fix Version/s: (was: 1.5-M1) 1.4-RC2 Assignee: Juergen Donnerstag applied. Thanks > Make the Source Code pages for examples stateless > - > > Key: WICKET-1431 > URL: https://issues.apache.org/jira/browse/WICKET-1431 > Project: Wicket > Issue Type: Improvement > Components: wicket-examples >Affects Versions: 1.3.2 >Reporter: Ned Collyer >Assignee: Juergen Donnerstag >Priority: Minor > Fix For: 1.4-RC2 > > Attachments: wicket-examples.diff > > > Page expiry is very frustrating, especially when you tab back to the source > code to see how something is achieved. > Can we make the code pages either static or stateless, so we can bookmark > them, send them to colleagues, or come back 30mins later and click a link > without it saying "page expired"? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r730851 - in /wicket/trunk/wicket-examples/src: main/java/org/apache/wicket/examples/ main/java/org/apache/wicket/examples/helloworld/ main/java/org/apache/wicket/examples/source/ test/jav
Author: jdonnerstag
Date: Fri Jan 2 14:20:21 2009
New Revision: 730851
URL: http://svn.apache.org/viewvc?rev=730851&view=rev
Log:
applied wicket-1431: Make the Source Code pages for examples stateless
Added:
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleRequestCycle.java
Modified:
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleApplication.java
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleHeader.java
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/helloworld/HelloWorldApplication.java
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/source/SourcesPage.html
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/source/SourcesPage.java
wicket/trunk/wicket-examples/src/test/java/org/apache/wicket/filtertest/Application.java
wicket/trunk/wicket-examples/src/test/java/org/apache/wicket/filtertest/HelloWorld.java
Modified:
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleApplication.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleApplication.java?rev=730851&r1=730850&r2=730851&view=diff
==
---
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleApplication.java
(original)
+++
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleApplication.java
Fri Jan 2 14:20:21 2009
@@ -18,14 +18,18 @@
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
+import org.apache.wicket.Request;
+import org.apache.wicket.RequestCycle;
+import org.apache.wicket.Response;
import org.apache.wicket.protocol.http.WebApplication;
+import org.apache.wicket.protocol.http.WebRequest;
import org.apache.wicket.settings.ISecuritySettings;
import org.apache.wicket.util.crypt.ClassCryptFactory;
import org.apache.wicket.util.crypt.NoCrypt;
/**
- * Wicket Application class for hello world example.
+ * Wicket Example Application class.
*
* @author Jonathan Locke
*/
@@ -46,6 +50,7 @@
/**
* @see org.apache.wicket.protocol.http.WebApplication#init()
*/
+ @Override
protected void init()
{
// WARNING: DO NOT do this on a real world application unless
@@ -57,6 +62,17 @@
// and we want them to be able to run the examples out of the
// box.
getSecuritySettings().setCryptFactory(
- new ClassCryptFactory(NoCrypt.class,
ISecuritySettings.DEFAULT_ENCRYPTION_KEY));
+ new ClassCryptFactory(NoCrypt.class,
ISecuritySettings.DEFAULT_ENCRYPTION_KEY));
+ }
+
+ /**
+*
+* @see
org.apache.wicket.protocol.http.WebApplication#newRequestCycle(org.apache.wicket.Request,
+* org.apache.wicket.Response)
+*/
+ @Override
+ public final RequestCycle newRequestCycle(Request request, Response
response)
+ {
+ return new WicketExampleRequestCycle(this, (WebRequest)request,
response);
}
}
Modified:
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleHeader.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleHeader.java?rev=730851&r1=730850&r2=730851&view=diff
==
---
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleHeader.java
(original)
+++
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/WicketExampleHeader.java
Fri Jan 2 14:20:21 2009
@@ -16,7 +16,6 @@
*/
package org.apache.wicket.examples;
-import org.apache.wicket.Page;
import org.apache.wicket.PageMap;
import org.apache.wicket.RequestContext;
import org.apache.wicket.examples.debug.InspectorBug;
@@ -24,7 +23,7 @@
import org.apache.wicket.markup.html.WebMarkupContainer;
import org.apache.wicket.markup.html.WebPage;
import org.apache.wicket.markup.html.basic.Label;
-import org.apache.wicket.markup.html.link.Link;
+import org.apache.wicket.markup.html.link.BookmarkablePageLink;
import org.apache.wicket.markup.html.link.PopupSettings;
import org.apache.wicket.markup.html.panel.Panel;
@@ -62,15 +61,8 @@
add(hideInPortlet);
hideInPortlet.add(new InspectorBug("inspector", page));
add(new Label("exampleTitle", exampleTitle));
- Link link = new Link("sources")
- {
- @SuppressWarnings("unchecked")
- @Override
- public void onClick()
- {
- s
[jira] Resolved: (WICKET-1513) "input" tag with type="image" results in null pointer exception in AutoLinkResolver
[ https://issues.apache.org/jira/browse/WICKET-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-1513. --- Resolution: Fixed Fix Version/s: 1.4-RC2 Assignee: Juergen Donnerstag patch applied, marking resolved... > "input" tag with type="image" results in null pointer exception in > AutoLinkResolver > --- > > Key: WICKET-1513 > URL: https://issues.apache.org/jira/browse/WICKET-1513 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.3.2, 1.3.3 >Reporter: Mikael Hansen >Assignee: Juergen Donnerstag > Fix For: 1.4-RC2 > > Attachments: 1513.patch > > > Something like: > > should reproduce the error (this is valid XHTML). > or: > > or: > > java.lang.NullPointerException > at > org.apache.wicket.markup.resolver.AutoLinkResolver$PathInfo.(AutoLinkResolver.java:249) > at > org.apache.wicket.markup.resolver.AutoLinkResolver.resolveAutomaticLink(AutoLinkResolver.java:808) > at > org.apache.wicket.markup.resolver.AutoLinkResolver.resolve(AutoLinkResolver.java:742) > at > org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1324) > at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1427) > at org.apache.wicket.Page.onRender(Page.java:1460) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1449) './' appended to URL causes HTTP 404 in Internet Explorer (using root context)
[
https://issues.apache.org/jira/browse/WICKET-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660296#action_12660296
]
Vjacheslav Kanivetc commented on WICKET-1449:
-
See issue https://issues.apache.org/jira/browse/WICKET-1998 which is a continue
of duplicate of this issue, the patch that worked for 1.4.x series was
mistakenly not included to 1.3.x source tree, so needs to be fixed once again.
> './' appended to URL causes HTTP 404 in Internet Explorer (using root context)
> --
>
> Key: WICKET-1449
> URL: https://issues.apache.org/jira/browse/WICKET-1449
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.2
> Environment: Wicket 1.3.2
> JBoss 4.0/Jetty 6.1.7
> JDK 1.6.0_03
>Reporter: Will Hoover
>Assignee: Igor Vaynberg
> Fix For: 1.3.5
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> SYNOPSIS:
> 1) Web application is using the root context ("/")
> 1) form.add(new Button("mybutton"));
> 2) Button is clicked on any WebPage that is NOT MOUNTED
> ISSUE:
> WebRequestCodingStrategy.encode appends './' to the URL. The page is
> redirected to "http://www.mysite.com/./"; It works fine in Firefox and Opera,
> but in IE an HTTP 404 ('.' page is not found) is rendered.
> Mounting the home page to something like '/home' solved the problem ('./' is
> not appended, but this causes a redirect every time a use hits the page).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1490) Small iprovement to the Start.java generated by the maven archtype
[
https://issues.apache.org/jira/browse/WICKET-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juergen Donnerstag resolved WICKET-1490.
Resolution: Fixed
Fix Version/s: 1.4-RC2
Assignee: Juergen Donnerstag
thanks
> Small iprovement to the Start.java generated by the maven archtype
> --
>
> Key: WICKET-1490
> URL: https://issues.apache.org/jira/browse/WICKET-1490
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-quickstart
>Affects Versions: 1.3.3
>Reporter: Brill Pappin
>Assignee: Juergen Donnerstag
>Priority: Minor
> Fix For: 1.4-RC2
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The maven archtype generates a very useful class called Start.java in
> src/test/java.
> It uses a loop to receive input to know when it should shut down.
> On line Start.java:36
> while (System.in.available() == 0) {
> Thread.sleep(5000);
> }
> should be replaced with:
> System.in.read();
> System.out.println("Stopping embedded Jetty server...");
> essentially instead of going into the sleep loop, we're using the blocking
> aspect of the input stream to know when we should allow the thread to exit.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r730695 - /wicket/trunk/archetypes/quickstart/src/main/resources/archetype-resources/src/test/java/Start.java
Author: jdonnerstag
Date: Fri Jan 2 03:08:05 2009
New Revision: 730695
URL: http://svn.apache.org/viewvc?rev=730695&view=rev
Log:
applied wicket-1490: Small iprovement to the Start.java generated by the maven
archtype
Modified:
wicket/trunk/archetypes/quickstart/src/main/resources/archetype-resources/src/test/java/Start.java
Modified:
wicket/trunk/archetypes/quickstart/src/main/resources/archetype-resources/src/test/java/Start.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/archetypes/quickstart/src/main/resources/archetype-resources/src/test/java/Start.java?rev=730695&r1=730694&r2=730695&view=diff
==
---
wicket/trunk/archetypes/quickstart/src/main/resources/archetype-resources/src/test/java/Start.java
(original)
+++
wicket/trunk/archetypes/quickstart/src/main/resources/archetype-resources/src/test/java/Start.java
Fri Jan 2 03:08:05 2009
@@ -10,6 +10,7 @@
public static void main(String[] args) throws Exception {
Server server = new Server();
SocketConnector connector = new SocketConnector();
+
// Set some timeout options to make debugging easier.
connector.setMaxIdleTime(1000 * 60 * 60);
connector.setSoLingerTime(-1);
@@ -20,7 +21,6 @@
bb.setServer(server);
bb.setContextPath("/");
bb.setWar("src/main/webapp");
-
// START JMX SERVER
// MBeanServer mBeanServer =
ManagementFactory.getPlatformMBeanServer();
@@ -33,9 +33,11 @@
try {
System.out.println(">>> STARTING EMBEDDED JETTY SERVER,
PRESS ANY KEY TO STOP");
server.start();
- while (System.in.available() == 0) {
- Thread.sleep(5000);
- }
+ System.in.read();
+ System.out.println(">>> STOPPING EMBEDDED JETTY
SERVER");
+// while (System.in.available() == 0) {
+ // Thread.sleep(5000);
+ // }
server.stop();
server.join();
} catch (Exception e) {
svn commit: r730691 - /wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/compref/CheckGroupPage.java
Author: jdonnerstag
Date: Fri Jan 2 02:41:18 2009
New Revision: 730691
URL: http://svn.apache.org/viewvc?rev=730691&view=rev
Log:
fixed wicket-1621: Misleading example works despite error
Modified:
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/compref/CheckGroupPage.java
Modified:
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/compref/CheckGroupPage.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/compref/CheckGroupPage.java?rev=730691&r1=730690&r2=730691&view=diff
==
---
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/compref/CheckGroupPage.java
(original)
+++
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/compref/CheckGroupPage.java
Fri Jan 2 02:41:18 2009
@@ -42,7 +42,6 @@
*/
public CheckGroupPage()
{
-
final CheckGroup group = new
CheckGroup("group", new ArrayList());
Form form = new Form("form")
{
@@ -59,7 +58,9 @@
ListView persons = new ListView("persons",
ComponentReferenceApplication.getPersons())
{
-
+ /**
+* @see
org.apache.wicket.markup.html.list.ListView#populateItem(org.apache.wicket.markup.html.list.ListItem)
+*/
@Override
protected void populateItem(ListItem item)
{
@@ -72,11 +73,15 @@
};
+ persons.setReuseItems(true);
group.add(persons);
add(new FeedbackPanel("feedback"));
}
+ /**
+* @see org.apache.wicket.examples.WicketExamplePage#explain()
+*/
@Override
protected void explain()
{
@@ -98,6 +103,7 @@
+ " item.add(new
Label(\"name\", new PropertyModel(item.getModel(), \"name\")));"
+ " item.add(new
Label(\"lastName\", new PropertyModel(item.getModel(), \"lastName\")));"
+ "};"
+ +
"persons.setReuseItems(true);"
+ "group.add(persons);";
add(new ExplainPanel(html, code));
}
[jira] Resolved: (WICKET-1621) Misleading example works despite error
[ https://issues.apache.org/jira/browse/WICKET-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juergen Donnerstag resolved WICKET-1621. Resolution: Fixed Fix Version/s: 1.4-RC2 Assignee: Juergen Donnerstag (was: Martijn Dashorst) thanks > Misleading example works despite error > -- > > Key: WICKET-1621 > URL: https://issues.apache.org/jira/browse/WICKET-1621 > Project: Wicket > Issue Type: Bug > Components: wicket-examples > Environment: not applicable >Reporter: Frank Silbermann >Assignee: Juergen Donnerstag >Priority: Minor > Fix For: 1.4-RC2 > > Attachments: screenshot-1.jpg > > > The resolution to Wicket-1601 is that anytime a ListView is used in a Form > and contains form components one should call #setReuseItems(true). The > JavaDoc for ListView indeed says this. > However, most people learn Wicket primarily by looking at the examples, and > the RadioGroup component example creates a ListView that contains form > components, but does not do this. (When I followed the example it worked > until I put two such RadioGroups on the same page.) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1584) FragmentColumn
[ https://issues.apache.org/jira/browse/WICKET-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juergen Donnerstag resolved WICKET-1584. Resolution: Invalid Fix Version/s: 1.4-RC2 Assignee: Juergen Donnerstag Thanks for contributing James. But becase the only line with content seems to be cellItem.add(createFragment(componentId, rowModel));. IMO not enough of a reason to for class to be added to core-extensions. This is a good example of what should go in the Wiki. Which is open for everybody to contribute and improve. > FragmentColumn > -- > > Key: WICKET-1584 > URL: https://issues.apache.org/jira/browse/WICKET-1584 > Project: Wicket > Issue Type: New Feature > Components: wicket-extensions >Affects Versions: 1.4-M1 >Reporter: James Carman >Assignee: Juergen Donnerstag >Priority: Minor > Fix For: 1.4-RC2 > > Attachments: WICKET-1584.patch > > > An abstract column superclass which allows subclasses to provide a Fragment > which displays the contents of the cell. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1449) './' appended to URL causes HTTP 404 in Internet Explorer (using root context)
[
https://issues.apache.org/jira/browse/WICKET-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660270#action_12660270
]
Igor Vaynberg commented on WICKET-1449:
---
sounds like a tomcat bug if it worked fine with lighttpd, or at least lighttpd
is smarter then tomcat at url handling...
> './' appended to URL causes HTTP 404 in Internet Explorer (using root context)
> --
>
> Key: WICKET-1449
> URL: https://issues.apache.org/jira/browse/WICKET-1449
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.2
> Environment: Wicket 1.3.2
> JBoss 4.0/Jetty 6.1.7
> JDK 1.6.0_03
>Reporter: Will Hoover
>Assignee: Igor Vaynberg
> Fix For: 1.3.5
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> SYNOPSIS:
> 1) Web application is using the root context ("/")
> 1) form.add(new Button("mybutton"));
> 2) Button is clicked on any WebPage that is NOT MOUNTED
> ISSUE:
> WebRequestCodingStrategy.encode appends './' to the URL. The page is
> redirected to "http://www.mysite.com/./"; It works fine in Firefox and Opera,
> but in IE an HTTP 404 ('.' page is not found) is rendered.
> Mounting the home page to something like '/home' solved the problem ('./' is
> not appended, but this causes a redirect every time a use hits the page).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
