[jira] Created: (WICKET-2291) Session.invalidateNow() makes RequestLogger to recreate invalidated session
Session.invalidateNow() makes RequestLogger to recreate invalidated session --- Key: WICKET-2291 URL: https://issues.apache.org/jira/browse/WICKET-2291 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.6 Reporter: Taneli Korri Priority: Minor When RequestLogger is enabled and a session is invalidated with Session.invalidateNow(), the execution order goes the wrong way. The session is removed from RequestLogger.liveSessions before the request is logged, which leads to RequestLogger recreating the invalidated session and adding it back to the RequestLogger.liveSessions. This leads to RequestLogger.getLiveSessions() returning bogus sessions, when using Session.invalidate() the problem doesn't exist. More info: http://www.nabble.com/RequestLogger-and-session-invalidation-to23742528.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[CONF] Apache Wicket: Tomcat clustering (page edited)
Page Edited :
WICKET :
Tomcat clustering
Tomcat clustering
has been edited by Ankur Gupta
(May 28, 2009).
(View changes)
Content:
Created By : Ankur Gupta
Setting Up Tomcat to Test Wicket Clustering
NOTE: This is only one of the many ways to set up clustering. This approach turns the entire Tomcat into a clustered one. It is also possible to set up multiple virtual hosts, with one host holding non-clustered applications and one having the clustered apps. See the descriptions in the Tomcat conf/web.xml for more details. The description below is how to set up the SIMPLEST, but not the BEST!
Get Tomcat
Get a copy of Tomcat. I would recommend 5.0.30 as this is the version that I have tested all of the config files on. You could also try 5.5.x, but the config may be different. The Tomcat clustering implementation is almost identical between the two versions, so if you get it working on one then you should also be able to get it working on the other.
IMPORTANT: The current releases of Tomcat have a clustering bug that causes Wicket to fail. There is a fix for this in the Tomcat CVS but this has not made it into the current production builds. Your options are therefore:
Build a tomcat from CVS HEAD
Download the tomcat src and patch the DeltaRequest.java file so that the execute(DeltaSession) method ends with:
reset();
session.endAccess();
as opposed to just:
session.endAccess();
Download a modified catalina-cluster.jar from my website (http://www.templemore.co.uk/catalina-cluster.jar). This contains the patch plus some useful debug output so that you can see what is going on!
Install Tomcat
Install tomcat either via the installer, or unpack into a particular directory.
DELETE the folowing unecessary stuff (for faster startup and to stop error messages):
conf/Catalina/localhost/balancer.xml
webapps/balancer''
webapps/jsp-examples''
webapps/servlets-examples''
webapps/tomcat-docs''
webapps/webdav''
Configure Tomcat
Edit the conf/server.xml file so that it contains the following content (minimum required for a clustered Tomcat server). This creates a basic clustered server using synchronous replication of session attributes (e.g. request does not complete until any session attribute changes have synchronised to all servers). This is not the most performant solution, but it is the best for testing and debugging.
NOTE: All of the settings surrounded by # characters need to be changed for EACH SERVER IN THE CLUSTER (remove the # characters!). Each server should have a different value. Settings in surrounded by @ characters may need to be changed, but they must be identicalon every server (remove the @ characters!).
Server port="#11005#" shutdown="SHUTDOWN" debug="0"
!-- Global JNDI resources --
GlobalNamingResources
!--
Editable user database that can also be used by
UserDatabaseRealm to authenticate users
--
Resource name="UserDatabase" auth="Container"
type="org.apache.catalina.UserDatabase"
description="User database that can be updated and saved"
/Resource
ResourceParams name="UserDatabase"
parameter
namefactory/name
valueorg.apache.catalina.users.MemoryUserDatabaseFactory/value
/parameter
parameter
namepathname/name
valueconf/tomcat-users.xml/value
/parameter
/ResourceParams
/GlobalNamingResources
!-- The Tomcat Service --
Service name="Catalina"
!-- HTTP/1.1 Connector on port 11080 --
Connector port="#11080#"
maxThreads="150" minSpareThreads="25" maxSpareThreads="75"
enableLookups="false" redirectPort="#11443#" acceptCount="100"
debug="0" connectionTimeout="2"
{panel}
disableUploadTimeout="true" /
{panel}
!-- Define a Coyote/JK2 AJP 1.3 Connector on port 11009 --
Connector port="#11009#"
enableLookups="false" redirectPort="#11443#" debug="0"
protocol="AJP/1.3" /
!-- Define the top level container in our container hierarchy --
Engine name="Catalina" defaultHost="localhost" debug="0" jvmRoute="#serverA#"
!-- Global logger unless overridden at lower levels --
Logger className="org.apache.catalina.logger.FileLogger"
{panel}
prefix="catalina_log." suffix=".txt"
timestamp="true"/
{panel}
!-- Real used for security purposes --
Realm className="org.apache.catalina.realm.UserDatabaseRealm"
debug="0" resourceName="UserDatabase"/
{panel}
!-- Define a clustered host for the Web Tools application --
{panel}
Host name="localhost" debug="0" appBase="webapps"
unpackWARs="true" autoDeploy="true"
xmlValidation="false" xmlNamespaceAware="false"
!-- Define the cluster configuration --
Cluster className="org.apache.catalina.cluster.tcp.SimpleTcpCluster"
[CONF] Apache Wicket: Tomcat clustering (page edited)
Page Edited :
WICKET :
Tomcat clustering
Tomcat clustering
has been edited by Ankur Gupta
(May 28, 2009).
(View changes)
Content:
Setting Up Tomcat to Test Wicket Clustering
NOTE: This is only one of the many ways to set up clustering. This approach turns the entire Tomcat into a clustered one. It is also possible to set up multiple virtual hosts, with one host holding non-clustered applications and one having the clustered apps. See the descriptions in the Tomcat conf/web.xml for more details. The description below is how to set up the SIMPLEST, but not the BEST!
Get Tomcat
Get a copy of Tomcat. I would recommend 5.0.30 as this is the version that I have tested all of the config files on. You could also try 5.5.x, but the config may be different. The Tomcat clustering implementation is almost identical between the two versions, so if you get it working on one then you should also be able to get it working on the other.
IMPORTANT: The current releases of Tomcat have a clustering bug that causes Wicket to fail. There is a fix for this in the Tomcat CVS but this has not made it into the current production builds. Your options are therefore:
Build a tomcat from CVS HEAD
Download the tomcat src and patch the DeltaRequest.java file so that the execute(DeltaSession) method ends with:
reset();
session.endAccess();
as opposed to just:
session.endAccess();
Download a modified catalina-cluster.jar from my website (http://www.templemore.co.uk/catalina-cluster.jar). This contains the patch plus some useful debug output so that you can see what is going on!
Install Tomcat
Install tomcat either via the installer, or unpack into a particular directory.
DELETE the folowing unecessary stuff (for faster startup and to stop error messages):
conf/Catalina/localhost/balancer.xml
webapps/balancer''
webapps/jsp-examples''
webapps/servlets-examples''
webapps/tomcat-docs''
webapps/webdav''
Configure Tomcat
Edit the conf/server.xml file so that it contains the following content (minimum required for a clustered Tomcat server). This creates a basic clustered server using synchronous replication of session attributes (e.g. request does not complete until any session attribute changes have synchronised to all servers). This is not the most performant solution, but it is the best for testing and debugging.
NOTE: All of the settings surrounded by # characters need to be changed for EACH SERVER IN THE CLUSTER (remove the # characters!). Each server should have a different value. Settings in surrounded by @ characters may need to be changed, but they must be identicalon every server (remove the @ characters!).
Server port="#11005#" shutdown="SHUTDOWN" debug="0"
!-- Global JNDI resources --
GlobalNamingResources
!--
Editable user database that can also be used by
UserDatabaseRealm to authenticate users
--
Resource name="UserDatabase" auth="Container"
type="org.apache.catalina.UserDatabase"
description="User database that can be updated and saved"
/Resource
ResourceParams name="UserDatabase"
parameter
namefactory/name
valueorg.apache.catalina.users.MemoryUserDatabaseFactory/value
/parameter
parameter
namepathname/name
valueconf/tomcat-users.xml/value
/parameter
/ResourceParams
/GlobalNamingResources
!-- The Tomcat Service --
Service name="Catalina"
!-- HTTP/1.1 Connector on port 11080 --
Connector port="#11080#"
maxThreads="150" minSpareThreads="25" maxSpareThreads="75"
enableLookups="false" redirectPort="#11443#" acceptCount="100"
debug="0" connectionTimeout="2"
{panel}
disableUploadTimeout="true" /
{panel}
!-- Define a Coyote/JK2 AJP 1.3 Connector on port 11009 --
Connector port="#11009#"
enableLookups="false" redirectPort="#11443#" debug="0"
protocol="AJP/1.3" /
!-- Define the top level container in our container hierarchy --
Engine name="Catalina" defaultHost="localhost" debug="0" jvmRoute="#serverA#"
!-- Global logger unless overridden at lower levels --
Logger className="org.apache.catalina.logger.FileLogger"
{panel}
prefix="catalina_log." suffix=".txt"
timestamp="true"/
{panel}
!-- Real used for security purposes --
Realm className="org.apache.catalina.realm.UserDatabaseRealm"
debug="0" resourceName="UserDatabase"/
{panel}
!-- Define a clustered host for the Web Tools application --
{panel}
Host name="localhost" debug="0" appBase="webapps"
unpackWARs="true" autoDeploy="true"
xmlValidation="false" xmlNamespaceAware="false"
!-- Define the cluster configuration --
Cluster className="org.apache.catalina.cluster.tcp.SimpleTcpCluster"
name="wicket-examples"
[jira] Created: (WICKET-2292) TabbedPanel uses too much generics (revert Wicket-2135)
TabbedPanel uses too much generics (revert Wicket-2135) --- Key: WICKET-2292 URL: https://issues.apache.org/jira/browse/WICKET-2292 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-RC3 Reporter: Erik van Oosten Fix For: 1.4-RC5 Please revert Wicket-2135. By declaring the list of tabs as List? extends ITab you are saying that the list contains elements with some super type that is a subtype of ITab. Having this type there is no way of knowing which exact supertype that is, just that it is a subclass of ITab. The result is that you can only add null to the list. Of course this is non-sense; TabbedPanel uses ITab and not some unknown subclass thereof. To demonstrate: right now you can not do: ITab tab = ...; tabbedPanel.getTabs().add(tab); To properly solve Wicket-2135, the user should cast his/her list to ListITab or just create a list of that type in the first place. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2292) TabbedPanel uses too much generics (revert WICKET-2135)
[ https://issues.apache.org/jira/browse/WICKET-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2292: Description: Please revert WICKET-2135. By declaring the list of tabs as List? extends ITab you are saying that the list contains elements with some super type that is a subtype of ITab. Having this type there is no way of knowing which exact supertype that is, just that it is a subclass of ITab. The result is that you can only add null to the list. Of course this is non-sense; TabbedPanel uses ITab and not some unknown subclass thereof. To demonstrate: right now you can not do: ITab tab = ...; tabbedPanel.getTabs().add(tab); To properly solve WICKET-2135, the user should cast his/her list to ListITab or just create a list of that type in the first place. was: Please revert Wicket-2135. By declaring the list of tabs as List? extends ITab you are saying that the list contains elements with some super type that is a subtype of ITab. Having this type there is no way of knowing which exact supertype that is, just that it is a subclass of ITab. The result is that you can only add null to the list. Of course this is non-sense; TabbedPanel uses ITab and not some unknown subclass thereof. To demonstrate: right now you can not do: ITab tab = ...; tabbedPanel.getTabs().add(tab); To properly solve Wicket-2135, the user should cast his/her list to ListITab or just create a list of that type in the first place. Summary: TabbedPanel uses too much generics (revert WICKET-2135) (was: TabbedPanel uses too much generics (revert Wicket-2135)) TabbedPanel uses too much generics (revert WICKET-2135) --- Key: WICKET-2292 URL: https://issues.apache.org/jira/browse/WICKET-2292 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-RC3 Reporter: Erik van Oosten Fix For: 1.4-RC5 Please revert WICKET-2135. By declaring the list of tabs as List? extends ITab you are saying that the list contains elements with some super type that is a subtype of ITab. Having this type there is no way of knowing which exact supertype that is, just that it is a subclass of ITab. The result is that you can only add null to the list. Of course this is non-sense; TabbedPanel uses ITab and not some unknown subclass thereof. To demonstrate: right now you can not do: ITab tab = ...; tabbedPanel.getTabs().add(tab); To properly solve WICKET-2135, the user should cast his/her list to ListITab or just create a list of that type in the first place. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2292) TabbedPanel uses too much generics (revert WICKET-2153)
[ https://issues.apache.org/jira/browse/WICKET-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erik van Oosten updated WICKET-2292: Description: Please revert WICKET-2153. By declaring the list of tabs as List? extends ITab you are saying that the list contains elements with some super type that is a subtype of ITab. Having this type there is no way of knowing which exact supertype that is, just that it is a subclass of ITab. The result is that you can only add null to the list. Of course this is non-sense; TabbedPanel uses ITab and not some unknown subclass thereof. To demonstrate: right now you can not do: ITab tab = ...; tabbedPanel.getTabs().add(tab); To properly solve WICKET-2153, the user should cast his/her list to ListITab or just create a list of that type in the first place. was: Please revert WICKET-2135. By declaring the list of tabs as List? extends ITab you are saying that the list contains elements with some super type that is a subtype of ITab. Having this type there is no way of knowing which exact supertype that is, just that it is a subclass of ITab. The result is that you can only add null to the list. Of course this is non-sense; TabbedPanel uses ITab and not some unknown subclass thereof. To demonstrate: right now you can not do: ITab tab = ...; tabbedPanel.getTabs().add(tab); To properly solve WICKET-2135, the user should cast his/her list to ListITab or just create a list of that type in the first place. Summary: TabbedPanel uses too much generics (revert WICKET-2153) (was: TabbedPanel uses too much generics (revert WICKET-2135)) TabbedPanel uses too much generics (revert WICKET-2153) --- Key: WICKET-2292 URL: https://issues.apache.org/jira/browse/WICKET-2292 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-RC3 Reporter: Erik van Oosten Fix For: 1.4-RC5 Please revert WICKET-2153. By declaring the list of tabs as List? extends ITab you are saying that the list contains elements with some super type that is a subtype of ITab. Having this type there is no way of knowing which exact supertype that is, just that it is a subclass of ITab. The result is that you can only add null to the list. Of course this is non-sense; TabbedPanel uses ITab and not some unknown subclass thereof. To demonstrate: right now you can not do: ITab tab = ...; tabbedPanel.getTabs().add(tab); To properly solve WICKET-2153, the user should cast his/her list to ListITab or just create a list of that type in the first place. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2293) Form loadPersistentFormComponentValues condition fix
Form loadPersistentFormComponentValues condition fix Key: WICKET-2293 URL: https://issues.apache.org/jira/browse/WICKET-2293 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4-RC4 Reporter: Jan Sýkora upon loading form persistent data each component is checked (Form.java:818) 1. if it is visible in hierarchy 2. if it wants have value persisted in my opinion the condition should be checked in reverse order - eg. first 2 then 1 reasons: a. check 2 is much faster and as FLAG_PERSISTENT is not set by default b. in case parent component is not visible, the isVisibleInHierarchy on component won't be unnecessarily called -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r779627 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
Author: ivaynberg
Date: Thu May 28 15:40:11 2009
New Revision: 779627
URL: http://svn.apache.org/viewvc?rev=779627view=rev
Log:
WICKET-2286
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java?rev=779627r1=779626r2=779627view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
Thu May 28 15:40:11 2009
@@ -84,18 +84,19 @@
}
/**
-* @see org.apache.wicket.Component#isVisible()
+* @see org.apache.wicket.Component#callOnBeforeRenderIfNotVisible()
*/
@Override
- public boolean isVisible()
+ protected boolean callOnBeforeRenderIfNotVisible()
{
- return table.getPageCount() 1;
+ return true;
}
/** {...@inheritdoc} */
@Override
protected void onBeforeRender()
{
+ setVisible(table.getPageCount() 1);
super.onBeforeRender();
}
}
[jira] Updated: (WICKET-2280) Remove IComponentBorder in favor of IBehavior
[
https://issues.apache.org/jira/browse/WICKET-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg updated WICKET-2280:
--
Fix Version/s: 1.5-M1
Remove IComponentBorder in favor of IBehavior
-
Key: WICKET-2280
URL: https://issues.apache.org/jira/browse/WICKET-2280
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4-RC4
Reporter: Juergen Donnerstag
Fix For: 1.5-M1
Attachments: wicket-jdo-2280-IComponentBorder.patch
Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
before/after
and then remove it in 1.5 and maybe remote also **
public *final* Component setComponentBorder(*final* IComponentBorder border)
in component or make it
*
public
* *final* Component setComponentBorder(*final* IBehavior border)
to make it more clear to people that a border can be set by using a behavior
(else who knows..)
- Hide quoted text -
On Sat, May 16, 2009 at 12:21, Juergen Donnerstag
juergen.donners...@gmail.com wrote:
Hi,
question: looking at that code
// Call implementation to render component
final IComponentBorder border =
getComponentBorder();
if (border != null)
{
border.renderBefore(this);
}
notifyBehaviorsComponentBeforeRender();
onRender(markupStream);
notifyBehaviorsComponentRendered();
if (border != null)
{
border.renderAfter(this);
}
IComponentBorder could be implemented via a behavior as well. Is there
any reason why IComponentBorder needs this special treatment and why
it is not implemented as a behavior?
-Juergen
-
Yeah i think we can depricate IComponentBorder in 1.4 and point to IBehavior
before/after
i like the ComponentBorder stuff, because you can set it without
influencing any beahavior or component stuff.. just render some content
before and after a component..
i use it in debugging environment
mm:)
--
Wait for some and give everybody a chance to comment
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2256) CLOSE button on the pop-up calendar
[ https://issues.apache.org/jira/browse/WICKET-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg updated WICKET-2256: -- Attachment: screenshot-1.jpg CLOSE button on the pop-up calendar --- Key: WICKET-2256 URL: https://issues.apache.org/jira/browse/WICKET-2256 Project: Wicket Issue Type: New Feature Components: wicket-datetime Environment: n/a Reporter: Phillip Rhodes Assignee: Igor Vaynberg Attachments: screenshot-1.jpg There should be a CLOSE button on the pop-up calendar to allow the user to close it without being required to select a date. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2256) CLOSE button on the pop-up calendar
[ https://issues.apache.org/jira/browse/WICKET-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2256. --- Resolution: Invalid Assignee: Igor Vaynberg last time i checked we had a close button for a long time. CLOSE button on the pop-up calendar --- Key: WICKET-2256 URL: https://issues.apache.org/jira/browse/WICKET-2256 Project: Wicket Issue Type: New Feature Components: wicket-datetime Environment: n/a Reporter: Phillip Rhodes Assignee: Igor Vaynberg Attachments: screenshot-1.jpg There should be a CLOSE button on the pop-up calendar to allow the user to close it without being required to select a date. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2123) org.apache.wicket.util.convert.converters.SqlTimestampConverter only renders the time part of the timestamp
[ https://issues.apache.org/jira/browse/WICKET-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2123. --- Resolution: Fixed Fix Version/s: 1.4-RC5 Assignee: Igor Vaynberg org.apache.wicket.util.convert.converters.SqlTimestampConverter only renders the time part of the timestamp --- Key: WICKET-2123 URL: https://issues.apache.org/jira/browse/WICKET-2123 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-RC2 Reporter: Dylan Schell Assignee: Igor Vaynberg Priority: Minor Fix For: 1.4-RC5 convertToObject calls DateFormat.getTimeInstance(dateFormat, locale) I would have expected it to call DateFormat.getDateTimeInstance(dateFormat, locale) if this is changed, I assume that the mirroring call in convertToObject also needs to be adjusted. the result is that currently only the time part of a timestamp is displayed when a default property model -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r779635 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tabs/TabbedPanel.java
Author: ivaynberg
Date: Thu May 28 15:56:22 2009
New Revision: 779635
URL: http://svn.apache.org/viewvc?rev=779635view=rev
Log:
FIXING WICKET-2292 BY REVERTING WICKET-2153
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tabs/TabbedPanel.java
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tabs/TabbedPanel.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tabs/TabbedPanel.java?rev=779635r1=779634r2=779635view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tabs/TabbedPanel.java
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tabs/TabbedPanel.java
Thu May 28 15:56:22 2009
@@ -76,7 +76,7 @@
/** id used for child panels */
public static final String TAB_PANEL_ID = panel;
- private final List? extends ITab tabs;
+ private final ListITab tabs;
private transient Boolean[] tabsVisibilityCache;
@@ -88,7 +88,7 @@
* @param tabs
*list of ITab objects used to represent tabs
*/
- public TabbedPanel(String id, List? extends ITab tabs)
+ public TabbedPanel(String id, ListITab tabs)
{
super(id, new ModelInteger(new Integer(-1)));
@@ -238,7 +238,7 @@
/**
* @return list of tabs that can be used by the user to
add/remove/reorder tabs in the panel
*/
- public final List? extends ITab getTabs()
+ public final ListITab getTabs()
{
return tabs;
}
[jira] Resolved: (WICKET-2292) TabbedPanel uses too much generics (revert WICKET-2153)
[ https://issues.apache.org/jira/browse/WICKET-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2292. --- Resolution: Fixed Assignee: Igor Vaynberg TabbedPanel uses too much generics (revert WICKET-2153) --- Key: WICKET-2292 URL: https://issues.apache.org/jira/browse/WICKET-2292 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-RC3 Reporter: Erik van Oosten Assignee: Igor Vaynberg Fix For: 1.4-RC5 Please revert WICKET-2153. By declaring the list of tabs as List? extends ITab you are saying that the list contains elements with some super type that is a subtype of ITab. Having this type there is no way of knowing which exact supertype that is, just that it is a subclass of ITab. The result is that you can only add null to the list. Of course this is non-sense; TabbedPanel uses ITab and not some unknown subclass thereof. To demonstrate: right now you can not do: ITab tab = ...; tabbedPanel.getTabs().add(tab); To properly solve WICKET-2153, the user should cast his/her list to ListITab or just create a list of that type in the first place. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2153) TabbedPanel accepts only ITab(s)
[
https://issues.apache.org/jira/browse/WICKET-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12714024#action_12714024
]
Igor Vaynberg commented on WICKET-2153:
---
for a solution see WICKET-2202
TabbedPanel accepts only ITab(s)
Key: WICKET-2153
URL: https://issues.apache.org/jira/browse/WICKET-2153
Project: Wicket
Issue Type: Improvement
Components: wicket-extensions
Affects Versions: 1.4-RC2
Reporter: SoulSpirit
Priority: Minor
Fix For: 1.4-RC3
TabbedPanel manages a List of ITab(s).
This prevents instantiation of TabbedPanel(s) made of any custom ITab
implementation.
Every reference to ListITab should be converted to List? extends ITab.
Alternatively, TabbedPanel should be declared as:
public class TabbedPanelT extends ITab extends Panel{}
depending on the preferred strategy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r779638 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
Author: ivaynberg
Date: Thu May 28 15:59:59 2009
New Revision: 779638
URL: http://svn.apache.org/viewvc?rev=779638view=rev
Log:
WICKET-2293 improve Form#loadPersistentFormComponetValues
Issue: WICKET-2293
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java?rev=779638r1=779637r2=779638view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java
Thu May 28 15:59:59 2009
@@ -816,7 +816,7 @@
// once the user submits the Form containing
that FormComponent.
// Note: if that is true, values may remain
persisted longer
// than really necessary
- if (formComponent.isVisibleInHierarchy()
formComponent.isPersistent())
+ if (formComponent.isPersistent()
formComponent.isVisibleInHierarchy())
{
// The persister
final IValuePersister persister =
getValuePersister();
[jira] Resolved: (WICKET-2293) Form loadPersistentFormComponentValues condition fix
[ https://issues.apache.org/jira/browse/WICKET-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2293. --- Resolution: Fixed Fix Version/s: 1.4-RC5 Assignee: Igor Vaynberg Form loadPersistentFormComponentValues condition fix Key: WICKET-2293 URL: https://issues.apache.org/jira/browse/WICKET-2293 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4-RC4 Reporter: Jan Sýkora Assignee: Igor Vaynberg Fix For: 1.4-RC5 upon loading form persistent data each component is checked (Form.java:818) 1. if it is visible in hierarchy 2. if it wants have value persisted in my opinion the condition should be checked in reverse order - eg. first 2 then 1 reasons: a. check 2 is much faster and as FLAG_PERSISTENT is not set by default b. in case parent component is not visible, the isVisibleInHierarchy on component won't be unnecessarily called -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2279) Losing focus on Autocomplete field if DropDownChoice is updated using Ajax.
[ https://issues.apache.org/jira/browse/WICKET-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg updated WICKET-2279: -- Priority: Minor (was: Critical) Losing focus on Autocomplete field if DropDownChoice is updated using Ajax. --- Key: WICKET-2279 URL: https://issues.apache.org/jira/browse/WICKET-2279 Project: Wicket Issue Type: Bug Components: wicket, wicket-extensions Affects Versions: 1.4-RC2, 1.4-RC4 Environment: Error exposed in IE 6, 7, 8. Works in Firefox, Chrome. Reporter: Aslak Knutsen Priority: Minor Attachments: AutoCompleteFocusIssuePage.html, AutoCompleteFocusIssuePage.java It seems that if a DropDownChoice is updated with ajax, the next AutoComplete field will lose focus when triggered if the updated DropDownChoice have had focus inbetween beeing updated and AutoComplete is triggered. But only if focus on the DropDownChoice is gained/lost using KEY_TAB. More description in the attached example.. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
