[jira] Created: (WICKET-2403) org.apache.wicket.markup.html.tree.WicketTreeModel should have a constructor taking a TreeModel
org.apache.wicket.markup.html.tree.WicketTreeModel should have a constructor
taking a TreeModel
---
Key: WICKET-2403
URL: https://issues.apache.org/jira/browse/WICKET-2403
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4-RC6
Reporter: Florent Legendre
org.apache.wicket.markup.html.tree.WicketTreeModel has no constructor yet. It
forces the user to do the job a constructor should typically take care of
consisting of:
code
private static IModel getModelForTreeModel(final TreeModel treeModel){
final WicketTreeModel wicketTreeModel = new WicketTreeModel();
wicketTreeModel.setObject(treeModel);
return wicketTreeModel;
}
/code
Nice if such a constructor could make it in 1.4 final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2404) Quickstart for 1.4 uses 1.3 dtd in HomePage.html
Quickstart for 1.4 uses 1.3 dtd in HomePage.html Key: WICKET-2404 URL: https://issues.apache.org/jira/browse/WICKET-2404 Project: Wicket Issue Type: Bug Components: wicket-quickstart Affects Versions: 1.4.0 Reporter: Erik van Oosten Priority: Trivial The generated HomePage.html contains the following header: html xmlns:wicket=http://wicket.apache.org/dtds.data/wicket-xhtml1.3-strict.dtd; That should be: html xmlns:wicket=http://wicket.apache.org/dtds.data/wicket-xhtml1.4-strict.dtd; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2376) In some cases, org.apache.wicket.extensions.markup.html.repeater.data.table.NavigatorToolbar is not displayed even when there are multiple pages in the DataTable it is
[
https://issues.apache.org/jira/browse/WICKET-2376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12737302#action_12737302
]
Kelsey Francis commented on WICKET-2376:
This is related to WICKET-2175. I'm experiencing this bug too.
The problem appears to be that callOnBeforeRenderIfNotVisible() in
NavigationToolbar never gets called, because NavigationToolbar is contained
within a DataTable.ToolbarContainer, which is itself contained in a
DataTable.ToolbarsContainer.
ToolbarsContainer's isVisible() returns false, since it doesn't currently
contain any visible toolbars, and since callOnBeforeRenderIfNotVisible() is not
overridden in either ToolbarsContainer and ToolbarContainer, onBeforeRender()
in those components is never called, and thus onBeforeRender() is never called
in NavigationToolbar, so it remains hidden.
So, once NavigationToolbar is hidden, it never can become visible again.
In some cases,
org.apache.wicket.extensions.markup.html.repeater.data.table.NavigatorToolbar
is not displayed even when there are multiple pages in the DataTable it is
attached to
---
Key: WICKET-2376
URL: https://issues.apache.org/jira/browse/WICKET-2376
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-RC7
Environment: Windows Vista, JDK 6 Update 14
Reporter: Vikash Madhow
The following can recreate the problem:
1. Create a DataTable with a NavigationToolbar and a page length less than
what the data provider will return, i.e., the data table will have more than
one page initially.
2. Add two buttons to the page; the first one, when submitted, will change
the criteria of the data provider to return less rows than what can be
displayed in one page of the DataTable and reload the page, i.e., after
pressing the button, the page will be reloaded with the datatable having only
one page and, therefore, the NavigationToolbar will not be visible anymore.
3. The second button will change the criteria of the data provider back to
what it was originally, i.e., it will have more rows than can be displayed in
one page of the DataTable, and reload the page. At that point, the
NavigationToolbar should be shown again, but it isn't.
I've found that the bug is due to the fact that the onBeforeRender() method
of NavigationToolbar which have the following line for determining visibility
of the toolbar:
setVisible(table.getPageCount() 1);
is not called when the 2nd button is pressed in the above scenario.
I've been able to work-around this problem by subclassing NavigationToolbar
and overidding isVisible() method (which is called many times however, and
might cause some performance problems) and added the above line of code as
such:
@Override
public boolean isVisible()
{
return getTable().getPageCount() 1;
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2376) In some cases, org.apache.wicket.extensions.markup.html.repeater.data.table.NavigatorToolbar is not displayed even when there are multiple pages in the DataTable it is at
[
https://issues.apache.org/jira/browse/WICKET-2376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kelsey Francis updated WICKET-2376:
---
Comment: was deleted
(was: This is related to WICKET-2175. I'm experiencing this bug too.
The problem appears to be that callOnBeforeRenderIfNotVisible() in
NavigationToolbar never gets called, because NavigationToolbar is contained
within a DataTable.ToolbarContainer, which is itself contained in a
DataTable.ToolbarsContainer.
ToolbarsContainer's isVisible() returns false, since it doesn't currently
contain any visible toolbars, and since callOnBeforeRenderIfNotVisible() is not
overridden in either ToolbarsContainer and ToolbarContainer, onBeforeRender()
in those components is never called, and thus onBeforeRender() is never called
in NavigationToolbar, so it remains hidden.
So, once NavigationToolbar is hidden, it never can become visible again.)
In some cases,
org.apache.wicket.extensions.markup.html.repeater.data.table.NavigatorToolbar
is not displayed even when there are multiple pages in the DataTable it is
attached to
---
Key: WICKET-2376
URL: https://issues.apache.org/jira/browse/WICKET-2376
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-RC7
Environment: Windows Vista, JDK 6 Update 14
Reporter: Vikash Madhow
The following can recreate the problem:
1. Create a DataTable with a NavigationToolbar and a page length less than
what the data provider will return, i.e., the data table will have more than
one page initially.
2. Add two buttons to the page; the first one, when submitted, will change
the criteria of the data provider to return less rows than what can be
displayed in one page of the DataTable and reload the page, i.e., after
pressing the button, the page will be reloaded with the datatable having only
one page and, therefore, the NavigationToolbar will not be visible anymore.
3. The second button will change the criteria of the data provider back to
what it was originally, i.e., it will have more rows than can be displayed in
one page of the DataTable, and reload the page. At that point, the
NavigationToolbar should be shown again, but it isn't.
I've found that the bug is due to the fact that the onBeforeRender() method
of NavigationToolbar which have the following line for determining visibility
of the toolbar:
setVisible(table.getPageCount() 1);
is not called when the 2nd button is pressed in the above scenario.
I've been able to work-around this problem by subclassing NavigationToolbar
and overidding isVisible() method (which is called many times however, and
might cause some performance problems) and added the above line of code as
such:
@Override
public boolean isVisible()
{
return getTable().getPageCount() 1;
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2376) In some cases, org.apache.wicket.extensions.markup.html.repeater.data.table.NavigatorToolbar is not displayed even when there are multiple pages in the DataTable it is
[
https://issues.apache.org/jira/browse/WICKET-2376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12737305#action_12737305
]
Kelsey Francis commented on WICKET-2376:
This is related to WICKET-2175. I'm experiencing this bug too.
The problem appears to be that callOnBeforeRenderIfNotVisible() in
NavigationToolbar never gets called, because NavigationToolbar is contained
within a DataTable.ToolbarContainer, which is itself contained in a
DataTable.ToolbarsContainer.
ToolbarsContainer's isVisible() returns false, since it doesn't currently
contain any visible toolbars, and since callOnBeforeRenderIfNotVisible() is not
overridden in either ToolbarsContainer and ToolbarContainer, onBeforeRender()
in those components is never called, and thus onBeforeRender() is never called
in NavigationToolbar, so it remains hidden.
So, once NavigationToolbar is hidden, it never can become visible again.
In some cases,
org.apache.wicket.extensions.markup.html.repeater.data.table.NavigatorToolbar
is not displayed even when there are multiple pages in the DataTable it is
attached to
---
Key: WICKET-2376
URL: https://issues.apache.org/jira/browse/WICKET-2376
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-RC7
Environment: Windows Vista, JDK 6 Update 14
Reporter: Vikash Madhow
The following can recreate the problem:
1. Create a DataTable with a NavigationToolbar and a page length less than
what the data provider will return, i.e., the data table will have more than
one page initially.
2. Add two buttons to the page; the first one, when submitted, will change
the criteria of the data provider to return less rows than what can be
displayed in one page of the DataTable and reload the page, i.e., after
pressing the button, the page will be reloaded with the datatable having only
one page and, therefore, the NavigationToolbar will not be visible anymore.
3. The second button will change the criteria of the data provider back to
what it was originally, i.e., it will have more rows than can be displayed in
one page of the DataTable, and reload the page. At that point, the
NavigationToolbar should be shown again, but it isn't.
I've found that the bug is due to the fact that the onBeforeRender() method
of NavigationToolbar which have the following line for determining visibility
of the toolbar:
setVisible(table.getPageCount() 1);
is not called when the 2nd button is pressed in the above scenario.
I've been able to work-around this problem by subclassing NavigationToolbar
and overidding isVisible() method (which is called many times however, and
might cause some performance problems) and added the above line of code as
such:
@Override
public boolean isVisible()
{
return getTable().getPageCount() 1;
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2405) componentID.PatternValidator settings in properties file cannot be picked up
componentID.PatternValidator settings in properties file cannot be picked up
Key: WICKET-2405
URL: https://issues.apache.org/jira/browse/WICKET-2405
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-RC7
Environment: jaunty, 1.4-rc7. JDK 1.6.0_13-b03
Reporter: jason wang
Code:
final RequiredTextFieldString mobile = new
RequiredTextFieldString(mobile);
mobile.setLabel(new ModelString(mobile)).add(new
PatternValidator(^[1-9]([0-9]{8,14})));
Properties file:
mobile.PatternValidator = Please input a valid international phone number.
Results:
always output input does not match pattern '^[1-9]([0-9]{8,14})'.
WIth the same code, build with 1.4 rc1, worked fine, build with rc7, problem
occurred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2405) componentID.PatternValidator settings in properties file cannot be picked up
[
https://issues.apache.org/jira/browse/WICKET-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-2405.
---
Resolution: Won't Fix
Assignee: Igor Vaynberg
1.4 rc7 is not the latest version. retest with 1.4.0 and reopen if still broken.
componentID.PatternValidator settings in properties file cannot be picked up
Key: WICKET-2405
URL: https://issues.apache.org/jira/browse/WICKET-2405
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-RC7
Environment: jaunty, 1.4-rc7. JDK 1.6.0_13-b03
Reporter: jason wang
Assignee: Igor Vaynberg
Code:
final RequiredTextFieldString mobile = new
RequiredTextFieldString(mobile);
mobile.setLabel(new ModelString(mobile)).add(new
PatternValidator(^[1-9]([0-9]{8,14})));
Properties file:
mobile.PatternValidator = Please input a valid international phone number.
Results:
always output input does not match pattern '^[1-9]([0-9]{8,14})'.
WIth the same code, build with 1.4 rc1, worked fine, build with rc7, problem
occurred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
