[jira] Created: (WICKET-2609) EnumChoiceRenderer misbehaves with anonymous enum classes
EnumChoiceRenderer misbehaves with anonymous enum classes - Key: WICKET-2609 URL: https://issues.apache.org/jira/browse/WICKET-2609 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.4 Reporter: Marat Radchenko Please find attached testcase reproducing the problem. Proper fix is to do return object.getDeclaringClass().getSimpleName() + . + object.name() instead of return object.getClass().getSimpleName() + . + object.name() in EnumChoiceRenderer.resourceKey -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2609) EnumChoiceRenderer misbehaves with anonymous enum classes
[ https://issues.apache.org/jira/browse/WICKET-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-2609: Attachment: EnumChoiceRendererTest.java EnumChoiceRenderer misbehaves with anonymous enum classes - Key: WICKET-2609 URL: https://issues.apache.org/jira/browse/WICKET-2609 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.4 Reporter: Marat Radchenko Attachments: EnumChoiceRendererTest.java Please find attached testcase reproducing the problem. Proper fix is to do return object.getDeclaringClass().getSimpleName() + . + object.name() instead of return object.getClass().getSimpleName() + . + object.name() in EnumChoiceRenderer.resourceKey -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2609) EnumChoiceRenderer misbehaves with anonymous enum classes
[ https://issues.apache.org/jira/browse/WICKET-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg updated WICKET-2609: -- Fix Version/s: 1.5-M1 we cannot change this in 1.4.x because it alters existing behavior EnumChoiceRenderer misbehaves with anonymous enum classes - Key: WICKET-2609 URL: https://issues.apache.org/jira/browse/WICKET-2609 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.4 Reporter: Marat Radchenko Fix For: 1.5-M1 Attachments: EnumChoiceRendererTest.java Please find attached testcase reproducing the problem. Proper fix is to do return object.getDeclaringClass().getSimpleName() + . + object.name() instead of return object.getClass().getSimpleName() + . + object.name() in EnumChoiceRenderer.resourceKey -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2609) EnumChoiceRenderer misbehaves with anonymous enum classes
[ https://issues.apache.org/jira/browse/WICKET-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789393#action_12789393 ] Marat Radchenko commented on WICKET-2609: - I doubt current behavior makes sense since it produces resource keys without classname at all - enum constants from different classes get same resource keys. Additionally, every bugfix alters behavior :) But, your word is last here. Let it be 1.5, it just means i won't use it in 1.4 EnumChoiceRenderer misbehaves with anonymous enum classes - Key: WICKET-2609 URL: https://issues.apache.org/jira/browse/WICKET-2609 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.4 Reporter: Marat Radchenko Fix For: 1.5-M1 Attachments: EnumChoiceRendererTest.java Please find attached testcase reproducing the problem. Proper fix is to do return object.getDeclaringClass().getSimpleName() + . + object.name() instead of return object.getClass().getSimpleName() + . + object.name() in EnumChoiceRenderer.resourceKey -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2609) EnumChoiceRenderer misbehaves with anonymous enum classes
[ https://issues.apache.org/jira/browse/WICKET-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg updated WICKET-2609: -- Fix Version/s: 1.4.5 Assignee: Igor Vaynberg EnumChoiceRenderer misbehaves with anonymous enum classes - Key: WICKET-2609 URL: https://issues.apache.org/jira/browse/WICKET-2609 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.4 Reporter: Marat Radchenko Assignee: Igor Vaynberg Fix For: 1.4.5, 1.5-M1 Attachments: EnumChoiceRendererTest.java Please find attached testcase reproducing the problem. Proper fix is to do return object.getDeclaringClass().getSimpleName() + . + object.name() instead of return object.getClass().getSimpleName() + . + object.name() in EnumChoiceRenderer.resourceKey -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r889711 - in /wicket/branches/wicket-1.4.x/wicket/src: main/java/org/apache/wicket/markup/html/form/EnumChoiceRenderer.java test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererT
Author: ivaynberg
Date: Fri Dec 11 17:22:46 2009
New Revision: 889711
URL: http://svn.apache.org/viewvc?rev=889711view=rev
Log:
WICKET-2609 EnumChoiceRenderer fix
Issue: WICKET-2609
Added:
wicket/branches/wicket-1.4.x/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java
(with props)
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/EnumChoiceRenderer.java
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/EnumChoiceRenderer.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/EnumChoiceRenderer.java?rev=889711r1=889710r2=889711view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/EnumChoiceRenderer.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/EnumChoiceRenderer.java
Fri Dec 11 17:22:46 2009
@@ -94,7 +94,7 @@
*/
protected String resourceKey(T object)
{
- return object.getClass().getSimpleName() + . + object.name();
+ return object.getDeclaringClass().getSimpleName() + . +
object.name();
}
/**
Added:
wicket/branches/wicket-1.4.x/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java?rev=889711view=auto
==
---
wicket/branches/wicket-1.4.x/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java
(added)
+++
wicket/branches/wicket-1.4.x/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java
Fri Dec 11 17:22:46 2009
@@ -0,0 +1,35 @@
+package org.apache.wicket.markup.html.form;
+
+import junit.framework.Assert;
+import junit.framework.TestCase;
+
+/**
+ * Tests {...@link EnumChoiceRenderer}
+ *
+ * @author igor.vaynberg
+ */
+public class EnumChoiceRendererTest extends TestCase
+{
+
+ /**
+*
+*/
+ public void testResourceKeyGenerationForAnonymousEnums()
+ {
+ final EnumChoiceRendererTestEnum renderer = new
EnumChoiceRendererTestEnum();
+ Assert.assertEquals(TestEnum.ANONYMOUS,
renderer.resourceKey(TestEnum.ANONYMOUS));
+ }
+
+ /**
+* Enum for testing
+*
+* @author igor.vaynberg
+*/
+ public enum TestEnum {
+ /** an anonymous enum value */
+ ANONYMOUS {
+ // anonymous enum value
+ }
+ }
+
+}
Propchange:
wicket/branches/wicket-1.4.x/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java
--
svn:mime-type = text/plain
svn commit: r889713 - in /wicket/trunk/wicket/src: main/java/org/apache/wicket/markup/html/form/EnumChoiceRenderer.java test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java
Author: ivaynberg
Date: Fri Dec 11 17:23:20 2009
New Revision: 889713
URL: http://svn.apache.org/viewvc?rev=889713view=rev
Log:
WICKET-2609 EnumChoiceRenderer fix
Issue: WICKET-2609
Added:
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java
(with props)
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/EnumChoiceRenderer.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/EnumChoiceRenderer.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/EnumChoiceRenderer.java?rev=889713r1=889712r2=889713view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/EnumChoiceRenderer.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/EnumChoiceRenderer.java
Fri Dec 11 17:23:20 2009
@@ -94,7 +94,7 @@
*/
protected String resourceKey(T object)
{
- return object.getClass().getSimpleName() + . + object.name();
+ return object.getDeclaringClass().getSimpleName() + . +
object.name();
}
/**
Added:
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java?rev=889713view=auto
==
---
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java
(added)
+++
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java
Fri Dec 11 17:23:20 2009
@@ -0,0 +1,35 @@
+package org.apache.wicket.markup.html.form;
+
+import junit.framework.Assert;
+import junit.framework.TestCase;
+
+/**
+ * Tests {...@link EnumChoiceRenderer}
+ *
+ * @author igor.vaynberg
+ */
+public class EnumChoiceRendererTest extends TestCase
+{
+
+ /**
+*
+*/
+ public void testResourceKeyGenerationForAnonymousEnums()
+ {
+ final EnumChoiceRendererTestEnum renderer = new
EnumChoiceRendererTestEnum();
+ Assert.assertEquals(TestEnum.ANONYMOUS,
renderer.resourceKey(TestEnum.ANONYMOUS));
+ }
+
+ /**
+* Enum for testing
+*
+* @author igor.vaynberg
+*/
+ public enum TestEnum {
+ /** an anonymous enum value */
+ ANONYMOUS {
+ // anonymous enum value
+ }
+ }
+
+}
Propchange:
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java
--
svn:mime-type = text/plain
[jira] Resolved: (WICKET-2609) EnumChoiceRenderer misbehaves with anonymous enum classes
[ https://issues.apache.org/jira/browse/WICKET-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2609. --- Resolution: Fixed EnumChoiceRenderer misbehaves with anonymous enum classes - Key: WICKET-2609 URL: https://issues.apache.org/jira/browse/WICKET-2609 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.4 Reporter: Marat Radchenko Assignee: Igor Vaynberg Fix For: 1.4.5, 1.5-M1 Attachments: EnumChoiceRendererTest.java Please find attached testcase reproducing the problem. Proper fix is to do return object.getDeclaringClass().getSimpleName() + . + object.name() instead of return object.getClass().getSimpleName() + . + object.name() in EnumChoiceRenderer.resourceKey -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r889718 - /wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java
Author: ivaynberg Date: Fri Dec 11 17:33:01 2009 New Revision: 889718 URL: http://svn.apache.org/viewvc?rev=889718view=rev Log: license header Modified: wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java Modified: wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java?rev=889718r1=889717r2=889718view=diff == --- wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java (original) +++ wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java Fri Dec 11 17:33:01 2009 @@ -1,3 +1,19 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the License); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ package org.apache.wicket.markup.html.form; import junit.framework.Assert;
svn commit: r889720 - /wicket/branches/wicket-1.4.x/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java
Author: ivaynberg Date: Fri Dec 11 17:33:34 2009 New Revision: 889720 URL: http://svn.apache.org/viewvc?rev=889720view=rev Log: license header Modified: wicket/branches/wicket-1.4.x/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java Modified: wicket/branches/wicket-1.4.x/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java?rev=889720r1=889719r2=889720view=diff == --- wicket/branches/wicket-1.4.x/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java (original) +++ wicket/branches/wicket-1.4.x/wicket/src/test/java/org/apache/wicket/markup/html/form/EnumChoiceRendererTest.java Fri Dec 11 17:33:34 2009 @@ -1,3 +1,19 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the License); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ package org.apache.wicket.markup.html.form; import junit.framework.Assert;
svn commit: r889739 - /wicket/releases/wicket-1.4.4/
Author: ivaynberg Date: Fri Dec 11 18:17:21 2009 New Revision: 889739 URL: http://svn.apache.org/viewvc?rev=889739view=rev Log: release tag Added: wicket/releases/wicket-1.4.4/ (props changed) - copied from r889737, wicket/branches/wicket-1.4.4/ Propchange: wicket/releases/wicket-1.4.4/ -- --- subclipse:tags (added) +++ subclipse:tags Fri Dec 11 18:17:21 2009 @@ -0,0 +1,5 @@ +550610,wicket-1.3.0-beta2,/wicket/tags/wicket-1.3.0-beta2,tag +567792,wicket-1.3.0-beta3,/wicket/tags/wicket-1.3.0-beta3,tag +582590,wicket-1.3.0-beta4,/wicket/tags/wicket-1.3.0-beta4,tag +591745,wicket-1.3.0-rc1,/wicket/tags/wicket-1.3.0-rc1,tag +601799,wicket-1.3.0-rc2,/wicket/tags/wicket-1.3.0-rc2,tag Propchange: wicket/releases/wicket-1.4.4/ -- --- svn:ignore (added) +++ svn:ignore Fri Dec 11 18:17:21 2009 @@ -0,0 +1,4 @@ +target +.metadata +.project +velocity.log Propchange: wicket/releases/wicket-1.4.4/ -- --- svn:mergeinfo (added) +++ svn:mergeinfo Fri Dec 11 18:17:21 2009 @@ -0,0 +1,2 @@ +/wicket/sandbox/jthomerson/experimental/wicket-devutils:760296-760351,760353-760355 +/wicket/trunk/wicket-devutils:760352
[jira] Created: (WICKET-2610) OddEvenListItem should append css attribute instead of replacing/adding it
OddEvenListItem should append css attribute instead of replacing/adding it -- Key: WICKET-2610 URL: https://issues.apache.org/jira/browse/WICKET-2610 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.4 Reporter: Martin Simons Priority: Minor Fix For: 1.4.5 Title says it all: Right now OddEvenListItem simply adds the class attribute without checking whether another one already exists, essentially overwriting any style definition the designer might have added. Instead, the odd/even classes should be appended as in AttributeAppender behavior. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
