[jira] Commented: (WICKET-2655) WicketTester javadocs are referring in many places to a component's path but it's not documented anywhere
[ https://issues.apache.org/jira/browse/WICKET-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795084#action_12795084 ] Juergen Donnerstag commented on WICKET-2655: 1) with Wicket each Component has an ID and that ID must be unique within its scope. 2) You can add Component into a Container 3) Via its path you can get(path) / access to a component any time without keeping its reference. The concept is similar to Java packages except that ":" is the separator 4) see getPageRelativePath, getRelativePath I'll add a few @see to WicketTester's javadoc > WicketTester javadocs are referring in many places to a component's path but > it's not documented anywhere > - > > Key: WICKET-2655 > URL: https://issues.apache.org/jira/browse/WICKET-2655 > Project: Wicket > Issue Type: Bug >Affects Versions: 1.4.5 >Reporter: Roberto Fasciolo > > In many places in the WicketTester javadoc there are references to a path > parameter explained in the following way: > path - path to Component > But it's not explained anywhere what a path is, what does it contains, which > separator is used there, what's the root of it and so on. > Practically, it's impossible understanding how to use WicketTester from its > javadoc because of that. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2655) WicketTester javadocs are referring in many places to a component's path but it's not documented anywhere
WicketTester javadocs are referring in many places to a component's path but it's not documented anywhere - Key: WICKET-2655 URL: https://issues.apache.org/jira/browse/WICKET-2655 Project: Wicket Issue Type: Bug Affects Versions: 1.4.5 Reporter: Roberto Fasciolo In many places in the WicketTester javadoc there are references to a path parameter explained in the following way: path - path to Component But it's not explained anywhere what a path is, what does it contains, which separator is used there, what's the root of it and so on. Practically, it's impossible understanding how to use WicketTester from its javadoc because of that. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2654) Make GoAndClearFilter optionally accept ISortStateLocator and reset it when Clear button is clicked
Make GoAndClearFilter optionally accept ISortStateLocator and reset it when Clear button is clicked --- Key: WICKET-2654 URL: https://issues.apache.org/jira/browse/WICKET-2654 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.4.5 Reporter: Marat Radchenko Priority: Minor Please, make GoAndClearFilter optionally accept ISortStateLocator and reset it when Clear button is clicked (the same way it currently handles sort state, via cloning original model) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2653) Make GoAndClearFilter.defaultClearModel and GoFilter.defaultGoModel internationalizable
Make GoAndClearFilter.defaultClearModel and GoFilter.defaultGoModel internationalizable --- Key: WICKET-2653 URL: https://issues.apache.org/jira/browse/WICKET-2653 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.4.5 Reporter: Marat Radchenko Priority: Trivial Please, change GoAndClearFilter.defaultClearModel and GoFilter.defaultGoModel to ResourceModel with default string (same way as it is done in NoRecordsToolbar.DEFAULT_MESSAGE_MODEL). That'll allow translating button labels without the need to pass custom models. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2652) LiveSessionsPage (devutils) leaks memory
LiveSessionsPage (devutils) leaks memory Key: WICKET-2652 URL: https://issues.apache.org/jira/browse/WICKET-2652 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Steps to reproduce: 1. Open LiveSessionsPage 2. Click "Enable request recording" 3. Click "Disable request recording" 4. Refresh page several times and observe session growth. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2651) NPE on InspectorPage (devutils)
NPE on InspectorPage (devutils) --- Key: WICKET-2651 URL: https://issues.apache.org/jira/browse/WICKET-2651 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Steps to reproduce: 1. Open InspectorPage 2. Press and hold F5. Expected: page happily reloads Actual: page reloads, but sometimes NPE happens. Stacktrace: SEVERE: Error attaching this container for rendering: [MarkupContainer [Component id = pagemap]] org.apache.wicket.WicketRuntimeException: Error attaching this container for rendering: [MarkupContainer [Component id = pagemap]] at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1739) at org.apache.wicket.Component.onBeforeRender(Component.java:3855) at org.apache.wicket.devutils.DevUtilsPanel.onBeforeRender(DevUtilsPanel.java:43) at org.apache.wicket.Component.internalBeforeRender(Component.java:1061) at org.apache.wicket.Component.beforeRender(Component.java:1095) at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1727) at org.apache.wicket.Component.onBeforeRender(Component.java:3855) at org.apache.wicket.Component.internalBeforeRender(Component.java:1061) at org.apache.wicket.Component.beforeRender(Component.java:1095) at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1727) at org.apache.wicket.Component.onBeforeRender(Component.java:3855) at org.apache.wicket.markup.repeater.AbstractRepeater.onBeforeRender(AbstractRepeater.java:151) at org.apache.wicket.Component.internalBeforeRender(Component.java:1061) at org.apache.wicket.Component.beforeRender(Component.java:1095) at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1727) at org.apache.wicket.Component.onBeforeRender(Component.java:3855) at org.apache.wicket.devutils.DevUtilsPanel.onBeforeRender(DevUtilsPanel.java:43) at org.apache.wicket.Component.internalBeforeRender(Component.java:1061) at org.apache.wicket.Component.beforeRender(Component.java:1095) at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1727) at org.apache.wicket.Component.onBeforeRender(Component.java:3855) at org.apache.wicket.Page.onBeforeRender(Page.java:1501) at org.apache.wicket.devutils.DevUtilsPage.onBeforeRender(DevUtilsPage.java:71) at org.apache.wicket.Component.internalBeforeRender(Component.java:1061) at org.apache.wicket.Component.beforeRender(Component.java:1095) at org.apache.wicket.Component.prepareForRender(Component.java:2225) at org.apache.wicket.Component.prepareForRender(Component.java:2262) at org.apache.wicket.Page.renderPage(Page.java:893) at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:261) at org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105) at ru.kctsoft.taro.web.TransactionalRequestCycleProcessor.respond(TransactionalRequestCycleProcessor.java:22) at sun.reflect.GeneratedMethodAccessor17.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:307) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:182) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:149) at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:106) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) at $Proxy42.respond(Unknown Source) at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1258) at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329) at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428) at org.apache.wicket.RequestCycle.request(RequestCycle.java:545) at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:479) at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:312) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157) at org.springframework.orm.hibernate3.support.OpenSessionInViewFilter.doFilterInternal(Open
[jira] Commented: (WICKET-2650) Consistently create body for short tags.
[ https://issues.apache.org/jira/browse/WICKET-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795039#action_12795039 ] Juergen Donnerstag commented on WICKET-2650: It is not that simple. 1) Obviously open/close tags are perfectly valid. 2) We check the tag and if it is open than we render the body - whatever that body is and which ever way the user wants to do it. How shall Wicket know upfornt that you'll be rendering the body yourself? Without a better reason I'm not in favor to switch to "always render the body and than based on the text generate determine what to do...". Some Components require a body text and thus accept open/close tags which the Component itself manually changes via subclassing onComponentTagBody. If you want ALL your wicket tags to have a body, simply create a filter and add it to your application. You may copy and modify OpenCloseTagExpander for that purpose I can imagine there are specific use cases (like /) currently not automatically covered by Wicket and I'm more than open to adjust any of the existing filters or add a new one. But I'm -1 on changing all to open-body-close. May be you can provide a filter implementation which implements these use cases and I'm more than happy to take a look. BTW, via the filter you can implement both: automatically change open-close to open-body-close, throw an exception or log a warning. > Consistently create body for short tags. > > > Key: WICKET-2650 > URL: https://issues.apache.org/jira/browse/WICKET-2650 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.0 >Reporter: Maarten Billemont > > When the Wicket HTML contains a tag such as and the > component bound to that tag uses replaceComponentTagBody to write a string to > the tag's body, currently nothing happens. > Either a text node should be added to the component tag and the body written > to it; > Or a warning/exception should occur if for some reason it is preferred to not > let this method succeed when the component tag has no body yet. > I don't see the use of the latter, so I recommend the former be implemented. > For now it's just confusing and dangerous. If I give my HTML to a web > designed and he changes a few empty HTML tags to short tags, I'll never be > warned, but my output WILL be broken. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2650) Consistently create body for short tags.
[ https://issues.apache.org/jira/browse/WICKET-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795036#action_12795036 ] Maarten Billemont commented on WICKET-2650: --- I believe the short tag is already expanded for certain components/tags, such as div/span? Either way; this should be consistent across all of the tag handling and be taken out where it exists currently. > Consistently create body for short tags. > > > Key: WICKET-2650 > URL: https://issues.apache.org/jira/browse/WICKET-2650 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.0 >Reporter: Maarten Billemont > > When the Wicket HTML contains a tag such as and the > component bound to that tag uses replaceComponentTagBody to write a string to > the tag's body, currently nothing happens. > Either a text node should be added to the component tag and the body written > to it; > Or a warning/exception should occur if for some reason it is preferred to not > let this method succeed when the component tag has no body yet. > I don't see the use of the latter, so I recommend the former be implemented. > For now it's just confusing and dangerous. If I give my HTML to a web > designed and he changes a few empty HTML tags to short tags, I'll never be > warned, but my output WILL be broken. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2648) DatePicker javascript uses 4 symbols for year although pattern contains just yy
[ https://issues.apache.org/jira/browse/WICKET-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-2648: Component/s: (was: wicket) wicket-extensions > DatePicker javascript uses 4 symbols for year although pattern contains just > yy > --- > > Key: WICKET-2648 > URL: https://issues.apache.org/jira/browse/WICKET-2648 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.4.5 >Reporter: Marat Radchenko > > Steps to reproduce: > 1. Create TextField > 2. Add DatePicker with yy for year (en_US locale, SHORT format, for example). > 3. Set some date to textfield > 4. Open page (year is correctly shown with two digits) > 5. Click datepicker icon > Expected: year is still 2-digit > Actual: year becomes 4-digit -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2649) Make SignInPage stateless
Make SignInPage stateless - Key: WICKET-2649 URL: https://issues.apache.org/jira/browse/WICKET-2649 Project: Wicket Issue Type: Improvement Components: wicket-auth-roles Affects Versions: 1.4.5 Reporter: Marat Radchenko By changing SignInPanel.SignInForm to inherit from StatelessForm instead of Form, whole SignInPage can become stateless and save ~4kb per instance in session. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2650) Consistently create body for short tags.
Consistently create body for short tags. Key: WICKET-2650 URL: https://issues.apache.org/jira/browse/WICKET-2650 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.0 Reporter: Maarten Billemont When the Wicket HTML contains a tag such as and the component bound to that tag uses replaceComponentTagBody to write a string to the tag's body, currently nothing happens. Either a text node should be added to the component tag and the body written to it; Or a warning/exception should occur if for some reason it is preferred to not let this method succeed when the component tag has no body yet. I don't see the use of the latter, so I recommend the former be implemented. For now it's just confusing and dangerous. If I give my HTML to a web designed and he changes a few empty HTML tags to short tags, I'll never be warned, but my output WILL be broken. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2648) DatePicker javascript uses 4 symbols for year although pattern contains just yy
DatePicker javascript uses 4 symbols for year although pattern contains just yy --- Key: WICKET-2648 URL: https://issues.apache.org/jira/browse/WICKET-2648 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Steps to reproduce: 1. Create TextField 2. Add DatePicker with yy for year (en_US locale, SHORT format, for example). 3. Set some date to textfield 4. Open page (year is correctly shown with two digits) 5. Click datepicker icon Expected: year is still 2-digit Actual: year becomes 4-digit -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
