[jira] Created: (WICKET-2816) Refactor / rework pageability
Refactor / rework pageability - Key: WICKET-2816 URL: https://issues.apache.org/jira/browse/WICKET-2816 Project: Wicket Issue Type: Improvement Components: wicket, wicket-extensions Affects Versions: 1.4.7, 1.5-M1 Environment: All Reporter: Daniel Toffetti I need to add a NavigatorLabel to a GridView, now NavigatorLabel has constructors accepting DataTable, DataView and PageableListView but not a GridView. Instead of creating a new constructor accepting a GridView, I think it would be far better to merge IPageable and the private NavigatorLabel.PageableComponent into a single public interface and making all pageable components implement this interface. I understand this approach breaks APIs and will need one major version, maybe two allowing for deprecations in between. A less breaking alternative (but not as good in my opinion) is to change the constructor accepting a DataView to make it accept an AbstractPageableView, which is a common ancestor of both DataView and GridView and defines the methods needed to satisfy NavigatorLabel.PageableComponent. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hielke Hoeve reopened WICKET-2168: -- it seems the fix is wrong. Looking at the uploaded patch I am wondering what I have been thinking :) Obviously script script= .. is wrong. It should be script type= .. TableTree.html is not XHTML valid - Key: WICKET-2168 URL: https://issues.apache.org/jira/browse/WICKET-2168 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.3.5, 1.3.6 Reporter: Hielke Hoeve Assignee: Juergen Donnerstag Priority: Trivial Fix For: 1.3.7, 1.4-RC3 Attachments: TreeTable.html.patch Original Estimate: 0.08h Remaining Estimate: 0.08h TableTree.html is not valid XHTML 1.0 Strict markup. This due to a missing type attribute. This is required and must be specified for element type script. I have attached a patch for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12852761#action_12852761 ] Hielke Hoeve edited comment on WICKET-2168 at 4/2/10 9:16 AM: -- it seems the fix is wrong. Looking at the uploaded patch I am wondering what I have been thinking :) I am also wondering why the patch did solve the htmlvalidators error message while the html is obviously wrong... Obviously script script= .. is wrong. It should be script type= .. was (Author: hielkehoeve): it seems the fix is wrong. Looking at the uploaded patch I am wondering what I have been thinking :) Obviously script script= .. is wrong. It should be script type= .. TableTree.html is not XHTML valid - Key: WICKET-2168 URL: https://issues.apache.org/jira/browse/WICKET-2168 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.3.5, 1.3.6, 1.4.7 Reporter: Hielke Hoeve Assignee: Juergen Donnerstag Priority: Trivial Fix For: 1.3.7, 1.4-RC3 Attachments: TreeTable.html.patch Original Estimate: 0.08h Remaining Estimate: 0.08h TableTree.html is not valid XHTML 1.0 Strict markup. This due to a missing type attribute. This is required and must be specified for element type script. I have attached a patch for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12852761#action_12852761 ] Hielke Hoeve edited comment on WICKET-2168 at 4/2/10 9:16 AM: -- it seems the fix is wrong. Looking at the uploaded patch I am wondering what I have been thinking :) I am also wondering why the patch did solve the htmlvalidators error message while the html is obviously wrong... script script= .. is wrong. It should be script type= .. (see 2nd patch). was (Author: hielkehoeve): it seems the fix is wrong. Looking at the uploaded patch I am wondering what I have been thinking :) I am also wondering why the patch did solve the htmlvalidators error message while the html is obviously wrong... Obviously script script= .. is wrong. It should be script type= .. TableTree.html is not XHTML valid - Key: WICKET-2168 URL: https://issues.apache.org/jira/browse/WICKET-2168 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.3.5, 1.3.6, 1.4.7 Reporter: Hielke Hoeve Assignee: Juergen Donnerstag Priority: Trivial Fix For: 1.3.7, 1.4-RC3 Attachments: TreeTable.html.patch Original Estimate: 0.08h Remaining Estimate: 0.08h TableTree.html is not valid XHTML 1.0 Strict markup. This due to a missing type attribute. This is required and must be specified for element type script. I have attached a patch for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hielke Hoeve updated WICKET-2168: - Affects Version/s: 1.4.7 TableTree.html is not XHTML valid - Key: WICKET-2168 URL: https://issues.apache.org/jira/browse/WICKET-2168 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.3.5, 1.3.6, 1.4.7 Reporter: Hielke Hoeve Assignee: Juergen Donnerstag Priority: Trivial Fix For: 1.3.7, 1.4-RC3 Attachments: TreeTable.html.patch Original Estimate: 0.08h Remaining Estimate: 0.08h TableTree.html is not valid XHTML 1.0 Strict markup. This due to a missing type attribute. This is required and must be specified for element type script. I have attached a patch for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hielke Hoeve updated WICKET-2168: - Attachment: TreeTable.html.2.patch second patch which changes the script script= .. to script type= ... TableTree.html is not XHTML valid - Key: WICKET-2168 URL: https://issues.apache.org/jira/browse/WICKET-2168 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.3.5, 1.3.6, 1.4.7 Reporter: Hielke Hoeve Assignee: Juergen Donnerstag Priority: Trivial Fix For: 1.3.7, 1.4-RC3 Attachments: TreeTable.html.2.patch, TreeTable.html.patch Original Estimate: 0.08h Remaining Estimate: 0.08h TableTree.html is not valid XHTML 1.0 Strict markup. This due to a missing type attribute. This is required and must be specified for element type script. I have attached a patch for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12852761#action_12852761 ] Hielke Hoeve edited comment on WICKET-2168 at 4/2/10 9:26 AM: -- it seems the fix is wrong. Looking at the uploaded patch I am wondering what I have been thinking :) I am also wondering why the patch did solve the htmlvalidators error message while the html is obviously wrong... script script= .. is wrong. It should be script type= .. (see 2nd patch). (this problem exists on the trunk, 1.4.x and 1.4.7 branch) was (Author: hielkehoeve): it seems the fix is wrong. Looking at the uploaded patch I am wondering what I have been thinking :) I am also wondering why the patch did solve the htmlvalidators error message while the html is obviously wrong... script script= .. is wrong. It should be script type= .. (see 2nd patch). TableTree.html is not XHTML valid - Key: WICKET-2168 URL: https://issues.apache.org/jira/browse/WICKET-2168 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.3.5, 1.3.6, 1.4.7 Reporter: Hielke Hoeve Assignee: Juergen Donnerstag Priority: Trivial Fix For: 1.3.7, 1.4-RC3 Attachments: TreeTable.html.2.patch, TreeTable.html.patch Original Estimate: 0.08h Remaining Estimate: 0.08h TableTree.html is not valid XHTML 1.0 Strict markup. This due to a missing type attribute. This is required and must be specified for element type script. I have attached a patch for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2705) Feedback messages get cleaned up in AJAX request, thus never rendered and never visible to user
[ https://issues.apache.org/jira/browse/WICKET-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12852786#action_12852786 ] Jan Winkler commented on WICKET-2705: - My patch indeed breaks things -- touching semantics of cleanupFeedbackmessages() is not a good idea as feedback messages also serve to signal FormComponent's validity. WIth my patch, FormComponents that failed to verify during an ajax request, are treated not valid until the error message is actually displayed to the user. This results in displaying error messages on submitting correctly filled in Form. The problem I originally reported is exactly what Martijn said: a normal form submission and an ajax event that are fired at the same time, where the ajax request is canceled with an EmptyAjaxRequestTarget (because normal page processing is already in progress). When the RC.detach() is processed, it clears all feedback messages. Cancelling an ajax request because normal page processing is in progress seems like an intentional no-op, and it should be. Cleaning feedback messages is not a no-op though. Feedback messages get cleaned up in AJAX request, thus never rendered and never visible to user --- Key: WICKET-2705 URL: https://issues.apache.org/jira/browse/WICKET-2705 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.6 Environment: Sun Glassfish Enterpriser Server 2.1 Reporter: Jan Winkler Attachments: feedbackbug.patch, feedbackbug.tgz, patch.txt Consider a page containing a form and an AJAXy component (as in an AJAX link or a panel with AjaxSelfUpdatingTimerBehavior). The form contains code, that makes its processing take relatively long time, even when validation fails (let's say we forgot to fill in a requred field). The form gets submitted, and while it's processing, the AJAX component triggers a request (AJAX link gets clicked, or AjaxSelfUpdatingTimerBehavior kicks in). While the AJAX request gets served, cleanupFeedbackMessages() is called, wiping all feedback messages found by WebSession.MESSAGES_FOR_COMPONENTS filter. WebSession.MESSAGES_FOR_COMPONENTS implementation (or its usage in cleanupFeedbackMessages()) is a little bit fishy, as it accept()s messages, that haven't been rendered. Will add testcase. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2817) ChoiceGroup's Constructor should take IModel? extends CollectionT
ChoiceGroup's Constructor should take IModel? extends CollectionT - Key: WICKET-2817 URL: https://issues.apache.org/jira/browse/WICKET-2817 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.7 Reporter: James Carman Fix For: 1.5-M1 This is very similar to ListMultipleChoice's constructor situation. Changing the constructor signature won't break any existing code, but it will make it easier to use (for times when you have a set-based property). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2817) ChoiceGroup's Constructor Should Accept IModel? extends CollectionT
[ https://issues.apache.org/jira/browse/WICKET-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Carman updated WICKET-2817: - Priority: Minor (was: Major) Summary: ChoiceGroup's Constructor Should Accept IModel? extends CollectionT (was: ChoiceGroup's Constructor should take IModel? extends CollectionT) ChoiceGroup's Constructor Should Accept IModel? extends CollectionT --- Key: WICKET-2817 URL: https://issues.apache.org/jira/browse/WICKET-2817 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.7 Reporter: James Carman Priority: Minor Fix For: 1.5-M1 This is very similar to ListMultipleChoice's constructor situation. Changing the constructor signature won't break any existing code, but it will make it easier to use (for times when you have a set-based property). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r930306 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java
Author: ivaynberg
Date: Fri Apr 2 16:05:26 2010
New Revision: 930306
URL: http://svn.apache.org/viewvc?rev=930306view=rev
Log:
WICKET-2817 make CheckGroup constructor more flexible
Issue: WICKET-2817
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java?rev=930306r1=930305r2=930306view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java
Fri Apr 2 16:05:26 2010
@@ -90,9 +90,10 @@ public class CheckGroupT extends FormC
* @param model
* @see WebMarkupContainer#WebMarkupContainer(String, IModel)
*/
- public CheckGroup(String id, IModelCollectionT model)
+ @SuppressWarnings(unchecked)
+ public CheckGroup(String id, IModel? extends CollectionT model)
{
- super(id, model);
+ super(id, (IModelCollectionT)model);
setRenderBodyOnly(true);
}
svn commit: r930314 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java
Author: ivaynberg
Date: Fri Apr 2 16:24:29 2010
New Revision: 930314
URL: http://svn.apache.org/viewvc?rev=930314view=rev
Log:
WICKET-2817 make CheckGroup constructor more flexible
Issue: WICKET-2817
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java?rev=930314r1=930313r2=930314view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckGroup.java
Fri Apr 2 16:24:29 2010
@@ -90,9 +90,10 @@ public class CheckGroupT extends FormC
* @param model
* @see WebMarkupContainer#WebMarkupContainer(String, IModel)
*/
- public CheckGroup(String id, IModelCollectionT model)
+ @SuppressWarnings(unchecked)
+ public CheckGroup(String id, IModel? extends CollectionT model)
{
- super(id, model);
+ super(id, (IModelCollectionT)model);
setRenderBodyOnly(true);
}
[jira] Resolved: (WICKET-2817) ChoiceGroup's Constructor Should Accept IModel? extends CollectionT
[ https://issues.apache.org/jira/browse/WICKET-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2817. --- Resolution: Fixed Fix Version/s: 1.4.8 Assignee: Igor Vaynberg ChoiceGroup's Constructor Should Accept IModel? extends CollectionT --- Key: WICKET-2817 URL: https://issues.apache.org/jira/browse/WICKET-2817 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.7 Reporter: James Carman Assignee: Igor Vaynberg Priority: Minor Fix For: 1.4.8, 1.5-M1 Attachments: WICKET-2817.patch This is very similar to ListMultipleChoice's constructor situation. Changing the constructor signature won't break any existing code, but it will make it easier to use (for times when you have a set-based property). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2817) ChoiceGroup's Constructor Should Accept IModel? extends CollectionT
[ https://issues.apache.org/jira/browse/WICKET-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12852860#action_12852860 ] James Carman commented on WICKET-2817: -- Thanks again! ChoiceGroup's Constructor Should Accept IModel? extends CollectionT --- Key: WICKET-2817 URL: https://issues.apache.org/jira/browse/WICKET-2817 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.7 Reporter: James Carman Assignee: Igor Vaynberg Priority: Minor Fix For: 1.4.8, 1.5-M1 Attachments: WICKET-2817.patch This is very similar to ListMultipleChoice's constructor situation. Changing the constructor signature won't break any existing code, but it will make it easier to use (for times when you have a set-based property). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2818) Wicket site's Component reference links to comp ref 1.3 instead of 1.4
Wicket site's Component reference links to comp ref 1.3 instead of 1.4 -- Key: WICKET-2818 URL: https://issues.apache.org/jira/browse/WICKET-2818 Project: Wicket Issue Type: Improvement Components: site Reporter: Joseph Pachod Priority: Minor On http://wicket.apache.org/, the link for Components, in the left menu bar, leads to http://wicketstuff.org/wicket13/compref/, whereas we are on wicket 1.4 and http://wicketstuff.org/wicket14/compref/ also exists. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2819) When unable to create a page, throw a specific exception instead of WicketRuntimeException
When unable to create a page, throw a specific exception instead of WicketRuntimeException -- Key: WICKET-2819 URL: https://issues.apache.org/jira/browse/WICKET-2819 Project: Wicket Issue Type: Improvement Reporter: Joseph Pachod Priority: Minor currently, when the DefaultPageFactory doesn't succeed in creating a given page, it throws a WicketRuntimeException with some message like Unable to create page from class org.demo.TestPage. Class does neither have a constructor with PageParameter nor a default constructor. Could it be possible to have a specific exception being thrown (extending WicketRuntimeException for sure) ? Thus, it would allow us to deal cleanly with this type of exception (and providing a better error message to our users). thanks in advance joseph -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r930387 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
Author: ivaynberg
Date: Fri Apr 2 21:09:06 2010
New Revision: 930387
URL: http://svn.apache.org/viewvc?rev=930387view=rev
Log:
javadoc tweak
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java?rev=930387r1=930386r2=930387view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
(original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java Fri Apr
2 21:09:06 2010
@@ -861,7 +861,7 @@ public abstract class Component implemen
* hierarchy up until the Page. That is, all parents must be have been
added to their parents as
* well. Add this point in time {...@link #getMarkup() getMarkup} is
guaranteed to be available.
* p
-* This method is guaranteed to only be called once
+* This method is guaranteed to called only once
* /p
* p
* If you don't like constructors to initialize your component, this is
the method to use.
svn commit: r930388 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
Author: ivaynberg
Date: Fri Apr 2 21:11:08 2010
New Revision: 930388
URL: http://svn.apache.org/viewvc?rev=930388view=rev
Log:
made some methods final
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java?rev=930388r1=930387r2=930388view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
(original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java Fri Apr
2 21:11:08 2010
@@ -876,7 +876,7 @@ public abstract class Component implemen
*
* @return {...@code true} if component has been initialized
*/
- boolean isInitialized()
+ final boolean isInitialized()
{
return getFlag(FLAG_INITIALIZED);
}
@@ -884,7 +884,7 @@ public abstract class Component implemen
/**
* Used to call {...@link #onInitialize()}
*/
- void initialize()
+ final void initialize()
{
if (!getFlag(FLAG_INITIALIZED))
{
svn commit: r930390 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Session.java
Author: ivaynberg
Date: Fri Apr 2 21:16:08 2010
New Revision: 930390
URL: http://svn.apache.org/viewvc?rev=930390view=rev
Log:
WICKET-2796 Improve error reporting on locked page maps
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Session.java
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Session.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Session.java?rev=930390r1=930389r2=930390view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Session.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Session.java
Fri Apr 2 21:16:08 2010
@@ -758,22 +758,9 @@ public abstract class Session implements
// if it is still not the right
thread..
// This either points to long
running code (a report
// page?) or a deadlock or such
- try
- {
- StackTraceElement[]
stackTrace = t.getStackTrace();
- asb.append(\n\tBegin
of stack trace of + t);
- for (StackTraceElement
stackTraceElement : stackTrace)
- {
-
asb.append(\n\t);
-
asb.append(stackTraceElement);
- }
- asb.append(\n\tEnd of
stack trace of + t);
- }
- catch (Exception e)
- {
- // ignore
- }
- throw new
WicketRuntimeException(asb.toString());
+ WicketRuntimeException ex = new
WicketRuntimeException(asb.toString());
+
ex.setStackTrace(t.getStackTrace());
+ throw ex;
}
}
[jira] Resolved: (WICKET-2796) Error reporting on locked page maps, revisited
[
https://issues.apache.org/jira/browse/WICKET-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg resolved WICKET-2796.
---
Resolution: Fixed
Fix Version/s: 1.4.8
Assignee: Igor Vaynberg
Error reporting on locked page maps, revisited
--
Key: WICKET-2796
URL: https://issues.apache.org/jira/browse/WICKET-2796
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4.6
Reporter: Vincent
Assignee: Igor Vaynberg
Priority: Minor
Fix For: 1.4.8
Attachments: SessionTest.java
I'm creating this issue as suggested by Igor in the comments of the following
issue: WICKET-433.
The change done for WICKET-433 results in a quite large error message that
has the potential to flood log files when running under heavy load. The error
message includes a full stack of the thread that is currently locking the
page map. Usually, an exception is raised that includes a message and a cause
so the catcher can decide to log the complete stack or not. In this case, I'd
suggest the same: create an exception, set the stack trace of the thread
locking the page map on it, and throw a WicketRuntimeException with a message
and a cause. Something like:
{code}
StackTraceElement[] stackTrace = t.getStackTrace();
WicketRuntimeException cause = new WicketRuntimeException(Thread is locking
page map.);
cause.setStackTrace(stackTrace);
throw new WicketRuntimeException(After + timeout + the Pagemap +
pageMapName + is
still locked by: + t +
, giving up trying to
get the page for path: + path,
cause);
{code}
This issue was raised by one of the administrators on my project that was
trying to break the application by doing a manual load and stress test (read:
disabling javascript and submitting requests like a maniac). Since our
application integrates with a web service that can take up quite some time,
up to 5 seconds, a queue starts to build up because Wicket allows only one
request per user to be executed because the page map is locked. While this is
a great design decision in my opinion (low impact for other users), after a
minute threads that are still waiting will start to abort. As quite a queue
had been built up at this point and each waiting thread throws an exception
with a quite verbose message (the blocking thread's stack), quite some lines
will be written to the log at this time - probably on error level.
Johan comments:
{quote}
how can a malicious user lock pages/pagemaps so create those kind of errors?
These errors are more or less programming/web application errors that you
need to fix
{quote}
Of course, you are right. This is a serious error that should never occur in
a properly tuned production environment. In production, the webservice should
respond much quicker and is viable for client-side caching, which we will
address in future iterations.
Our administrator's concern is that IF a user manages to build up a queue
long enough to trigger this error (whatever the cause), he will face a 'log
storm' that makes him effectively blind. This is the reason that stack traces
on error level are not allowed in our production environment. Of course, this
will only be a serious problem under very very heavy load.
Well enough with the theoretical mumbo-jumbo, do you like the idea? Shall I
cook up a proof of concept? And if successful, build a patch for this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2796) Improve error reporting on locked page maps
[
https://issues.apache.org/jira/browse/WICKET-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Vaynberg updated WICKET-2796:
--
Summary: Improve error reporting on locked page maps (was: Error reporting
on locked page maps, revisited)
Improve error reporting on locked page maps
---
Key: WICKET-2796
URL: https://issues.apache.org/jira/browse/WICKET-2796
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4.6
Reporter: Vincent
Assignee: Igor Vaynberg
Priority: Minor
Fix For: 1.4.8
Attachments: SessionTest.java
I'm creating this issue as suggested by Igor in the comments of the following
issue: WICKET-433.
The change done for WICKET-433 results in a quite large error message that
has the potential to flood log files when running under heavy load. The error
message includes a full stack of the thread that is currently locking the
page map. Usually, an exception is raised that includes a message and a cause
so the catcher can decide to log the complete stack or not. In this case, I'd
suggest the same: create an exception, set the stack trace of the thread
locking the page map on it, and throw a WicketRuntimeException with a message
and a cause. Something like:
{code}
StackTraceElement[] stackTrace = t.getStackTrace();
WicketRuntimeException cause = new WicketRuntimeException(Thread is locking
page map.);
cause.setStackTrace(stackTrace);
throw new WicketRuntimeException(After + timeout + the Pagemap +
pageMapName + is
still locked by: + t +
, giving up trying to
get the page for path: + path,
cause);
{code}
This issue was raised by one of the administrators on my project that was
trying to break the application by doing a manual load and stress test (read:
disabling javascript and submitting requests like a maniac). Since our
application integrates with a web service that can take up quite some time,
up to 5 seconds, a queue starts to build up because Wicket allows only one
request per user to be executed because the page map is locked. While this is
a great design decision in my opinion (low impact for other users), after a
minute threads that are still waiting will start to abort. As quite a queue
had been built up at this point and each waiting thread throws an exception
with a quite verbose message (the blocking thread's stack), quite some lines
will be written to the log at this time - probably on error level.
Johan comments:
{quote}
how can a malicious user lock pages/pagemaps so create those kind of errors?
These errors are more or less programming/web application errors that you
need to fix
{quote}
Of course, you are right. This is a serious error that should never occur in
a properly tuned production environment. In production, the webservice should
respond much quicker and is viable for client-side caching, which we will
address in future iterations.
Our administrator's concern is that IF a user manages to build up a queue
long enough to trigger this error (whatever the cause), he will face a 'log
storm' that makes him effectively blind. This is the reason that stack traces
on error level are not allowed in our production environment. Of course, this
will only be a serious problem under very very heavy load.
Well enough with the theoretical mumbo-jumbo, do you like the idea? Shall I
cook up a proof of concept? And if successful, build a patch for this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2821) More IModel? extends Collection Fixes
[ https://issues.apache.org/jira/browse/WICKET-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Carman updated WICKET-2821: - Priority: Minor (was: Major) Summary: More IModel? extends Collection Fixes (was: More IModel? extends Collection? extends T Fixes) More IModel? extends Collection Fixes - Key: WICKET-2821 URL: https://issues.apache.org/jira/browse/WICKET-2821 Project: Wicket Issue Type: Improvement Components: wicket, wicket-extensions Affects Versions: 1.4.7 Reporter: James Carman Priority: Minor Fix For: 1.5-M1 I searched the code for all occurrences of IModelCollection and replaced all that I thought could be replaced with IModel? extends Collection. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2820) change the Checkbox's onSelectionChanged to have a Boolean as the new selection
change the Checkbox's onSelectionChanged to have a Boolean as the new selection --- Key: WICKET-2820 URL: https://issues.apache.org/jira/browse/WICKET-2820 Project: Wicket Issue Type: Improvement Reporter: Joseph Pachod Attachments: checkBoxOnSelectionChangedBoolean.txt The checkbox is defined as class CheckBox extends FormComponentBoolean However, onSelectionChanged works with an object. It could easily changed to a Boolean, making it clearer. I'll attach a (very simple) patch for it. Hopefully it wasn't already planned for wicket 1.5 (I didn't find any issue with that, but then there are so many issues...). On a side note, the Javadoc for onSelectionChanged should also be corrected. It currently speaks of dropdown list. thanks in advance joseph -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2821) More IModel? extends Collection? extends T Fixes
More IModel? extends Collection? extends T Fixes Key: WICKET-2821 URL: https://issues.apache.org/jira/browse/WICKET-2821 Project: Wicket Issue Type: Improvement Components: wicket, wicket-extensions Affects Versions: 1.4.7 Reporter: James Carman Fix For: 1.5-M1 I searched the code for all occurrences of IModelCollection and replaced all that I thought could be replaced with IModel? extends Collection. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2820) change the Checkbox's onSelectionChanged to have a Boolean as the new selection
[ https://issues.apache.org/jira/browse/WICKET-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Pachod updated WICKET-2820: -- Attachment: checkBoxOnSelectionChangedBoolean.txt a (very simple) patch for resolving the issue change the Checkbox's onSelectionChanged to have a Boolean as the new selection --- Key: WICKET-2820 URL: https://issues.apache.org/jira/browse/WICKET-2820 Project: Wicket Issue Type: Improvement Reporter: Joseph Pachod Attachments: checkBoxOnSelectionChangedBoolean.txt The checkbox is defined as class CheckBox extends FormComponentBoolean However, onSelectionChanged works with an object. It could easily changed to a Boolean, making it clearer. I'll attach a (very simple) patch for it. Hopefully it wasn't already planned for wicket 1.5 (I didn't find any issue with that, but then there are so many issues...). On a side note, the Javadoc for onSelectionChanged should also be corrected. It currently speaks of dropdown list. thanks in advance joseph -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-2818) Wicket site's Component reference links to comp ref 1.3 instead of 1.4
[ https://issues.apache.org/jira/browse/WICKET-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg reassigned WICKET-2818: - Assignee: Gerolf Seitz Wicket site's Component reference links to comp ref 1.3 instead of 1.4 -- Key: WICKET-2818 URL: https://issues.apache.org/jira/browse/WICKET-2818 Project: Wicket Issue Type: Improvement Components: site Reporter: Joseph Pachod Assignee: Gerolf Seitz Priority: Minor On http://wicket.apache.org/, the link for Components, in the left menu bar, leads to http://wicketstuff.org/wicket13/compref/, whereas we are on wicket 1.4 and http://wicketstuff.org/wicket14/compref/ also exists. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2821) More IModel? extends Collection Fixes
[ https://issues.apache.org/jira/browse/WICKET-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Carman updated WICKET-2821: - Attachment: WICKET-2821.patch More IModel? extends Collection Fixes - Key: WICKET-2821 URL: https://issues.apache.org/jira/browse/WICKET-2821 Project: Wicket Issue Type: Improvement Components: wicket, wicket-extensions Affects Versions: 1.4.7 Reporter: James Carman Priority: Minor Fix For: 1.5-M1 Attachments: WICKET-2821.patch I searched the code for all occurrences of IModelCollection and replaced all that I thought could be replaced with IModel? extends Collection. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2819) When unable to create a page, throw a specific exception instead of WicketRuntimeException
[ https://issues.apache.org/jira/browse/WICKET-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12852955#action_12852955 ] Igor Vaynberg commented on WICKET-2819: --- Thus, it would allow us to deal cleanly with this type of exception this exception is a development-time error, how would you deal with it cleanly? (and providing a better error message to our users). once again, this is development time - who are your users you are refering to? also the exception has all the information one may need to fix the problem... When unable to create a page, throw a specific exception instead of WicketRuntimeException -- Key: WICKET-2819 URL: https://issues.apache.org/jira/browse/WICKET-2819 Project: Wicket Issue Type: Improvement Reporter: Joseph Pachod Priority: Minor currently, when the DefaultPageFactory doesn't succeed in creating a given page, it throws a WicketRuntimeException with some message like Unable to create page from class org.demo.TestPage. Class does neither have a constructor with PageParameter nor a default constructor. Could it be possible to have a specific exception being thrown (extending WicketRuntimeException for sure) ? Thus, it would allow us to deal cleanly with this type of exception (and providing a better error message to our users). thanks in advance joseph -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r930393 - in /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form: CheckBoxMultipleChoice.java upload/MultiFileUploadField.java
Author: ivaynberg
Date: Fri Apr 2 21:29:36 2010
New Revision: 930393
URL: http://svn.apache.org/viewvc?rev=930393view=rev
Log:
WICKET-2821
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java?rev=930393r1=930392r2=930393view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java
Fri Apr 2 21:29:36 2010
@@ -16,9 +16,6 @@
*/
package org.apache.wicket.markup.html.form;
-import java.util.Collection;
-import java.util.List;
-
import org.apache.wicket.Page;
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.markup.MarkupStream;
@@ -28,6 +25,9 @@ import org.apache.wicket.util.string.App
import org.apache.wicket.util.string.Strings;
import org.apache.wicket.version.undo.Change;
+import java.util.Collection;
+import java.util.List;
+
/**
* A choice subclass that shows choices via checkboxes.
@@ -196,7 +196,7 @@ public class CheckBoxMultipleChoiceT e
* @see org.apache.wicket.Component#Component(String,
org.apache.wicket.model.IModel)
* @see AbstractChoice#AbstractChoice(String,
org.apache.wicket.model.IModel, java.util.List)
*/
- public CheckBoxMultipleChoice(final String id, IModelCollectionT
model,
+ public CheckBoxMultipleChoice(final String id, IModel? extends
CollectionT model,
final List? extends T choices)
{
super(id, model, choices);
@@ -217,7 +217,7 @@ public class CheckBoxMultipleChoiceT e
* @see AbstractChoice#AbstractChoice(String,
org.apache.wicket.model.IModel,
*
java.util.List,org.apache.wicket.markup.html.form.IChoiceRenderer)
*/
- public CheckBoxMultipleChoice(final String id, IModelCollectionT
model,
+ public CheckBoxMultipleChoice(final String id, IModel? extends
CollectionT model,
final List? extends T choices, final IChoiceRenderer? super
T renderer)
{
super(id, model, choices, renderer);
@@ -251,7 +251,7 @@ public class CheckBoxMultipleChoiceT e
* org.apache.wicket.model.IModel,org.apache.wicket.model.IModel)
* @see org.apache.wicket.Component#Component(String,
org.apache.wicket.model.IModel)
*/
- public CheckBoxMultipleChoice(String id, IModelCollectionT model,
+ public CheckBoxMultipleChoice(String id, IModel? extends
CollectionT model,
IModel? extends List? extends T choices)
{
super(id, model, choices);
@@ -292,7 +292,7 @@ public class CheckBoxMultipleChoiceT e
* @see AbstractChoice#AbstractChoice(String,
org.apache.wicket.model.IModel,
*
org.apache.wicket.model.IModel,org.apache.wicket.markup.html.form.IChoiceRenderer)
*/
- public CheckBoxMultipleChoice(String id, IModelCollectionT model,
+ public CheckBoxMultipleChoice(String id, IModel? extends
CollectionT model,
IModel? extends List? extends T choices, IChoiceRenderer?
super T renderer)
{
super(id, model, choices, renderer);
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java?rev=930393r1=930392r2=930393view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java
Fri Apr 2 21:29:36 2010
@@ -42,6 +42,13 @@ import org.apache.wicket.util.convert.Co
import org.apache.wicket.util.string.Strings;
import org.apache.wicket.util.upload.FileItem;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.Map;
+import java.util.Map.Entry;
+
/**
* Form component that allows the user to select multiple files to upload via
a single lt;input
@@ -132,7 +139,7 @@ public class MultiFileUploadField extend
* @param id
* @param model
svn commit: r930394 - in /wicket/trunk: wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/ wicket/src/main/java/org/apache/wicket/ wicket/src/main/java/org/apache/wi
Author: ivaynberg
Date: Fri Apr 2 21:30:38 2010
New Revision: 930394
URL: http://svn.apache.org/viewvc?rev=930394view=rev
Log:
WICKET-2821
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField.java
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java?rev=930394r1=930393r2=930394view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java
Fri Apr 2 21:30:38 2010
@@ -16,9 +16,6 @@
*/
package org.apache.wicket.extensions.markup.html.form.select;
-import java.util.Collection;
-import java.util.Iterator;
-
import org.apache.wicket.WicketRuntimeException;
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.markup.MarkupStream;
@@ -27,6 +24,9 @@ import org.apache.wicket.markup.repeater
import org.apache.wicket.model.IModel;
import org.apache.wicket.model.util.WildcardCollectionModel;
+import java.util.Collection;
+import java.util.Iterator;
+
/**
* Component that makes it easy to produce a list of SelectOption components
@@ -55,7 +55,7 @@ public class SelectOptionsT extends Re
* @param model
* @param renderer
*/
- public SelectOptions(String id, IModelCollection? extends T model,
+ public SelectOptions(String id, IModel? extends Collection? extends
T model,
IOptionRendererT renderer)
{
super(id, model);
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java?rev=930394r1=930393r2=930394view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
(original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java Fri Apr
2 21:30:38 2010
@@ -884,7 +884,7 @@ public abstract class Component implemen
/**
* Used to call {...@link #onInitialize()}
*/
- final void initialize()
+ void initialize()
{
if (!getFlag(FLAG_INITIALIZED))
{
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java?rev=930394r1=930393r2=930394view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBoxMultipleChoice.java
Fri Apr 2 21:30:38 2010
@@ -16,9 +16,6 @@
*/
package org.apache.wicket.markup.html.form;
-import java.util.Collection;
-import java.util.List;
-
import org.apache.wicket.Page;
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.markup.MarkupStream;
@@ -27,6 +24,9 @@ import org.apache.wicket.util.convert.IC
import org.apache.wicket.util.string.AppendingStringBuffer;
import org.apache.wicket.util.string.Strings;
+import java.util.Collection;
+import java.util.List;
+
/**
* A choice subclass that shows choices via checkboxes.
@@ -126,7 +126,7 @@ public class CheckBoxMultipleChoiceT e
* @see org.apache.wicket.Component#Component(String,
org.apache.wicket.model.IModel)
* @see AbstractChoice#AbstractChoice(String,
org.apache.wicket.model.IModel, java.util.List)
*/
- public CheckBoxMultipleChoice(final String id, IModelCollectionT
model,
+ public CheckBoxMultipleChoice(final String id, IModel? extends
CollectionT model,
final List? extends T choices)
{
super(id, model, choices);
@@ -147,7 +147,7 @@ public class CheckBoxMultipleChoiceT e
* @see AbstractChoice#AbstractChoice(String,
org.apache.wicket.model.IModel,
*
java.util.List,org.apache.wicket.markup.html.form.IChoiceRenderer)
*/
- public CheckBoxMultipleChoice(final String id, IModelCollectionT
model,
+ public CheckBoxMultipleChoice(final
[jira] Resolved: (WICKET-2821) More IModel? extends Collection Fixes
[ https://issues.apache.org/jira/browse/WICKET-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2821. --- Resolution: Fixed Fix Version/s: 1.4.8 Assignee: Igor Vaynberg More IModel? extends Collection Fixes - Key: WICKET-2821 URL: https://issues.apache.org/jira/browse/WICKET-2821 Project: Wicket Issue Type: Improvement Components: wicket, wicket-extensions Affects Versions: 1.4.7 Reporter: James Carman Assignee: Igor Vaynberg Priority: Minor Fix For: 1.4.8, 1.5-M1 Attachments: WICKET-2821.patch I searched the code for all occurrences of IModelCollection and replaced all that I thought could be replaced with IModel? extends Collection. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2819) When unable to create a page, throw a specific exception instead of WicketRuntimeException
[ https://issues.apache.org/jira/browse/WICKET-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12852962#action_12852962 ] Joseph Pachod commented on WICKET-2819: --- The issue pops up in production when some users use their browsers to bookmark pages which aren't bookmarkable. For us, it's mostly about the Registration successful page, but can happen for some others as well. Later, when the user try to access the page, an exception is thrown. What happens next is application specific. In our case, we catch all exceptions in a specific request cycle and we can then attach specific behavior to some exception class or fall back to the default error page. In the case of a non bookmarkable page that someone tries to access, this is not an unknown error, we know what occurred and for which reason. Thus we would like to provide a more meaningful message, like for example The page you requested isn't directly accessible. Please use the navigation to get back there. But maybe I'm missing something... As a side note, is it better to speak first on the mailing list of such requests or going directly at jira is fine enough ? When unable to create a page, throw a specific exception instead of WicketRuntimeException -- Key: WICKET-2819 URL: https://issues.apache.org/jira/browse/WICKET-2819 Project: Wicket Issue Type: Improvement Reporter: Joseph Pachod Priority: Minor currently, when the DefaultPageFactory doesn't succeed in creating a given page, it throws a WicketRuntimeException with some message like Unable to create page from class org.demo.TestPage. Class does neither have a constructor with PageParameter nor a default constructor. Could it be possible to have a specific exception being thrown (extending WicketRuntimeException for sure) ? Thus, it would allow us to deal cleanly with this type of exception (and providing a better error message to our users). thanks in advance joseph -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r930396 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java
Author: ivaynberg
Date: Fri Apr 2 21:41:00 2010
New Revision: 930396
URL: http://svn.apache.org/viewvc?rev=930396view=rev
Log:
WICKET-2820 change the Checkbox's onSelectionChanged to have a Boolean as the
new selection
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java?rev=930396r1=930395r2=930396view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/CheckBox.java
Fri Apr 2 21:41:00 2010
@@ -77,7 +77,7 @@ public class CheckBox extends FormCompon
{
convertInput();
updateModel();
- onSelectionChanged(getDefaultModelObject());
+ onSelectionChanged(getModelObject());
}
/**
@@ -91,7 +91,7 @@ public class CheckBox extends FormCompon
*The newly selected object of the backing model NOTE this
is the same as you would
*get by calling getModelObject() if the new selection were
current
*/
- protected void onSelectionChanged(Object newSelection)
+ protected void onSelectionChanged(Boolean newSelection)
{
}
[jira] Resolved: (WICKET-2820) change the Checkbox's onSelectionChanged to have a Boolean as the new selection
[ https://issues.apache.org/jira/browse/WICKET-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2820. --- Resolution: Fixed Fix Version/s: 1.5-M1 Assignee: Igor Vaynberg change the Checkbox's onSelectionChanged to have a Boolean as the new selection --- Key: WICKET-2820 URL: https://issues.apache.org/jira/browse/WICKET-2820 Project: Wicket Issue Type: Improvement Reporter: Joseph Pachod Assignee: Igor Vaynberg Fix For: 1.5-M1 Attachments: checkBoxOnSelectionChangedBoolean.txt The checkbox is defined as class CheckBox extends FormComponentBoolean However, onSelectionChanged works with an object. It could easily changed to a Boolean, making it clearer. I'll attach a (very simple) patch for it. Hopefully it wasn't already planned for wicket 1.5 (I didn't find any issue with that, but then there are so many issues...). On a side note, the Javadoc for onSelectionChanged should also be corrected. It currently speaks of dropdown list. thanks in advance joseph -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2820) change the Checkbox's onSelectionChanged to have a Boolean as the new selection
[ https://issues.apache.org/jira/browse/WICKET-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12852966#action_12852966 ] Joseph Pachod commented on WICKET-2820: --- Just a side note, the javadoc for the onSelectionChanged could be improved. Currently it contains this sentence : * Called when a option is selected of a dropdown list that wants to be notified of this event. whereas it's the CheckBox class. This line could be safely removed (starting from 1.4.x). change the Checkbox's onSelectionChanged to have a Boolean as the new selection --- Key: WICKET-2820 URL: https://issues.apache.org/jira/browse/WICKET-2820 Project: Wicket Issue Type: Improvement Reporter: Joseph Pachod Assignee: Igor Vaynberg Fix For: 1.5-M1 Attachments: checkBoxOnSelectionChangedBoolean.txt The checkbox is defined as class CheckBox extends FormComponentBoolean However, onSelectionChanged works with an object. It could easily changed to a Boolean, making it clearer. I'll attach a (very simple) patch for it. Hopefully it wasn't already planned for wicket 1.5 (I didn't find any issue with that, but then there are so many issues...). On a side note, the Javadoc for onSelectionChanged should also be corrected. It currently speaks of dropdown list. thanks in advance joseph -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2819) When unable to create a page, throw a specific exception instead of WicketRuntimeException
[ https://issues.apache.org/jira/browse/WICKET-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12852973#action_12852973 ] Igor Vaynberg commented on WICKET-2819: --- if the users bookmark a non-bookmarkable url they should get a page-expired exception... When unable to create a page, throw a specific exception instead of WicketRuntimeException -- Key: WICKET-2819 URL: https://issues.apache.org/jira/browse/WICKET-2819 Project: Wicket Issue Type: Improvement Reporter: Joseph Pachod Priority: Minor currently, when the DefaultPageFactory doesn't succeed in creating a given page, it throws a WicketRuntimeException with some message like Unable to create page from class org.demo.TestPage. Class does neither have a constructor with PageParameter nor a default constructor. Could it be possible to have a specific exception being thrown (extending WicketRuntimeException for sure) ? Thus, it would allow us to deal cleanly with this type of exception (and providing a better error message to our users). thanks in advance joseph -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2818) Wicket site's Component reference links to comp ref 1.3 instead of 1.4
[ https://issues.apache.org/jira/browse/WICKET-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerolf Seitz resolved WICKET-2818. -- Resolution: Fixed I changed the link on the left side and two more links to wicketstuff.org/wicket13 and ../wicket13/compref to the respective wicket14 links. along with that, i uploaded the aggregated javadocs for the 1.4.7 and 1.3.7 releases Wicket site's Component reference links to comp ref 1.3 instead of 1.4 -- Key: WICKET-2818 URL: https://issues.apache.org/jira/browse/WICKET-2818 Project: Wicket Issue Type: Improvement Components: site Reporter: Joseph Pachod Assignee: Gerolf Seitz Priority: Minor On http://wicket.apache.org/, the link for Components, in the left menu bar, leads to http://wicketstuff.org/wicket13/compref/, whereas we are on wicket 1.4 and http://wicketstuff.org/wicket14/compref/ also exists. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r930426 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/TreeTable.html
Author: ivaynberg Date: Fri Apr 2 23:12:17 2010 New Revision: 930426 URL: http://svn.apache.org/viewvc?rev=930426view=rev Log: Issue: WICKET-2168 Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/TreeTable.html Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/TreeTable.html URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/TreeTable.html?rev=930426r1=930425r2=930426view=diff == --- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/TreeTable.html (original) +++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/TreeTable.html Fri Apr 2 23:12:17 2010 @@ -45,7 +45,7 @@ /div -script script=text/javascript wicket:id=attachJavascript +script type=text/javascript wicket:id=attachJavascript /* Will be replaced on runtime; Wicket.TreeTable.attachUpdate(treeTable); */ /script
svn commit: r930427 - /wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/TreeTable.html
Author: ivaynberg Date: Fri Apr 2 23:12:32 2010 New Revision: 930427 URL: http://svn.apache.org/viewvc?rev=930427view=rev Log: Issue: WICKET-2168 Modified: wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/TreeTable.html Modified: wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/TreeTable.html URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/TreeTable.html?rev=930427r1=930426r2=930427view=diff == --- wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/TreeTable.html (original) +++ wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/TreeTable.html Fri Apr 2 23:12:32 2010 @@ -45,7 +45,7 @@ /div -script script=text/javascript wicket:id=attachJavascript +script type=text/javascript wicket:id=attachJavascript /* Will be replaced on runtime; Wicket.TreeTable.attachUpdate(treeTable); */ /script
[jira] Resolved: (WICKET-2168) TableTree.html is not XHTML valid
[ https://issues.apache.org/jira/browse/WICKET-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2168. --- Resolution: Fixed Fix Version/s: (was: 1.4-RC3) 1.4.7 Assignee: Igor Vaynberg (was: Juergen Donnerstag) TableTree.html is not XHTML valid - Key: WICKET-2168 URL: https://issues.apache.org/jira/browse/WICKET-2168 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.3.5, 1.3.6, 1.4.7 Reporter: Hielke Hoeve Assignee: Igor Vaynberg Priority: Trivial Fix For: 1.4.7, 1.3.7 Attachments: TreeTable.html.2.patch, TreeTable.html.patch Original Estimate: 0.08h Remaining Estimate: 0.08h TableTree.html is not valid XHTML 1.0 Strict markup. This due to a missing type attribute. This is required and must be specified for element type script. I have attached a patch for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r930429 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/IndicatingAjaxButton.java
Author: ivaynberg
Date: Fri Apr 2 23:15:17 2010
New Revision: 930429
URL: http://svn.apache.org/viewvc?rev=930429view=rev
Log:
Issue: WICKET-2813
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/IndicatingAjaxButton.java
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/IndicatingAjaxButton.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/IndicatingAjaxButton.java?rev=930429r1=930428r2=930429view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/IndicatingAjaxButton.java
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/IndicatingAjaxButton.java
Fri Apr 2 23:15:17 2010
@@ -19,6 +19,7 @@ package org.apache.wicket.extensions.aja
import org.apache.wicket.ajax.IAjaxIndicatorAware;
import org.apache.wicket.ajax.markup.html.form.AjaxButton;
import org.apache.wicket.markup.html.form.Form;
+import org.apache.wicket.model.IModel;
/**
* A variant of the {...@link AjaxButton} that displays a busy indicator while
the ajax request is in
@@ -43,18 +44,42 @@ public abstract class IndicatingAjaxButt
*/
public IndicatingAjaxButton(String id)
{
- this(id, null);
+ this(id, null, null);
}
/**
* Constructor
*
* @param id
+* @param model
+*model used to set codevalue/code markup attribute
+*/
+ public IndicatingAjaxButton(String id, IModelString model)
+ {
+ this(id, model, null);
+ }
+
+ /**
+*
+* Constructor
+*
+* @param id
* @param form
*/
public IndicatingAjaxButton(String id, Form? form)
{
- super(id, form);
+ this(id, null, form);
+ }
+
+ /**
+* Constructor
+*
+* @param id
+* @param form
+*/
+ public IndicatingAjaxButton(String id, IModelString model, Form?
form)
+ {
+ super(id, model, form);
add(indicatorAppender);
}
[jira] Resolved: (WICKET-2813) IndicatingAjaxButton should have construtors that take a IModel for the button text as does AjaxButton.
[ https://issues.apache.org/jira/browse/WICKET-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2813. --- Resolution: Fixed Assignee: Igor Vaynberg IndicatingAjaxButton should have construtors that take a IModel for the button text as does AjaxButton. --- Key: WICKET-2813 URL: https://issues.apache.org/jira/browse/WICKET-2813 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.4.7 Reporter: Martin H. Assignee: Igor Vaynberg Priority: Minor Attachments: IndicatingAjaxButton.diff IndicatingAjaxButton is missing the constructors that take an IModel for the button text that AjaxButton supports. public IndicatingAjaxButton(String id, IModelString model) public IndicatingAjaxButton(String id, IModelString model, Form? form) I think IndicatingAjaxButton should offer the same API as AjaxButton. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2813) IndicatingAjaxButton should have construtors that take a IModel for the button text as does AjaxButton.
[ https://issues.apache.org/jira/browse/WICKET-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg updated WICKET-2813: -- Fix Version/s: 1.5-M1 1.4.8 IndicatingAjaxButton should have construtors that take a IModel for the button text as does AjaxButton. --- Key: WICKET-2813 URL: https://issues.apache.org/jira/browse/WICKET-2813 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.4.7 Reporter: Martin H. Assignee: Igor Vaynberg Priority: Minor Fix For: 1.4.8, 1.5-M1 Attachments: IndicatingAjaxButton.diff IndicatingAjaxButton is missing the constructors that take an IModel for the button text that AjaxButton supports. public IndicatingAjaxButton(String id, IModelString model) public IndicatingAjaxButton(String id, IModelString model, Form? form) I think IndicatingAjaxButton should offer the same API as AjaxButton. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r930431 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
Author: ivaynberg
Date: Fri Apr 2 23:19:34 2010
New Revision: 930431
URL: http://svn.apache.org/viewvc?rev=930431view=rev
Log:
ListMultipleChoice: updateModel method looses the value submitted from the
select control
Issue: WICKET-2811
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java?rev=930431r1=930430r2=930431view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
Fri Apr 2 23:19:34 2010
@@ -16,6 +16,11 @@
*/
package org.apache.wicket.markup.html.form;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.StringTokenizer;
+
import org.apache.wicket.WicketRuntimeException;
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.model.IModel;
@@ -26,11 +31,6 @@ import org.apache.wicket.util.string.Str
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.List;
-import java.util.StringTokenizer;
-
/**
* A multiple choice list component.
@@ -122,7 +122,8 @@ public class ListMultipleChoiceT exten
/**
* @see
org.apache.wicket.markup.html.form.AbstractChoice#AbstractChoice(String,
IModel, List)
*/
- public ListMultipleChoice(final String id, IModel? extends
CollectionT object, final List? extends T choices)
+ public ListMultipleChoice(final String id, IModel? extends
CollectionT object,
+ final List? extends T choices)
{
super(id, (IModelCollectionT)object, choices);
}
@@ -340,7 +341,7 @@ public class ListMultipleChoiceT exten
}
else
{
- selectedValues = getConvertedInput();
+ selectedValues = new ArrayListT(getConvertedInput());
setDefaultModelObject(selectedValues);
}
}
svn commit: r930432 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
Author: ivaynberg
Date: Fri Apr 2 23:20:20 2010
New Revision: 930432
URL: http://svn.apache.org/viewvc?rev=930432view=rev
Log:
ListMultipleChoice: updateModel method looses the value submitted from the
select control
Issue: WICKET-2811
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java?rev=930432r1=930431r2=930432view=diff
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/ListMultipleChoice.java
Fri Apr 2 23:20:20 2010
@@ -16,6 +16,11 @@
*/
package org.apache.wicket.markup.html.form;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.StringTokenizer;
+
import org.apache.wicket.WicketRuntimeException;
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.model.IModel;
@@ -26,11 +31,6 @@ import org.apache.wicket.util.string.Str
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.List;
-import java.util.StringTokenizer;
-
/**
* A multiple choice list component.
@@ -122,7 +122,8 @@ public class ListMultipleChoiceT exten
/**
* @see
org.apache.wicket.markup.html.form.AbstractChoice#AbstractChoice(String,
IModel, List)
*/
- public ListMultipleChoice(final String id, IModel? extends
CollectionT object, final List? extends T choices)
+ public ListMultipleChoice(final String id, IModel? extends
CollectionT object,
+ final List? extends T choices)
{
super(id, (IModelCollectionT)object, choices);
}
@@ -340,7 +341,7 @@ public class ListMultipleChoiceT exten
}
else
{
- selectedValues = getConvertedInput();
+ selectedValues = new ArrayListT(getConvertedInput());
setDefaultModelObject(selectedValues);
}
}
svn commit: r930433 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_hu.properties
Author: ivaynberg
Date: Fri Apr 2 23:28:28 2010
New Revision: 930433
URL: http://svn.apache.org/viewvc?rev=930433view=rev
Log:
Hungarian translation for Multiupload
Issue: WICKET-2798
Added:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_hu.properties
(with props)
Added:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_hu.properties
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_hu.properties?rev=930433view=auto
==
---
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_hu.properties
(added)
+++
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_hu.properties
Fri Apr 2 23:28:28 2010
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the License); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an AS IS BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+org.apache.wicket.mfu.caption.unlimited=Fel\u00f6ltend\u0151
\u00c1llom\u00e1nyok:
+org.apache.wicket.mfu.caption.limited=Felt\u00f6ltend\u0151
\u00e1llom\u00e1nyok (maximum ${max}):
+org.apache.wicket.mfu.delete=T\u00f6r\u00f6l
Propchange:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_hu.properties
--
svn:mime-type = text/plain
svn commit: r930434 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_hu.properties
Author: ivaynberg
Date: Fri Apr 2 23:29:16 2010
New Revision: 930434
URL: http://svn.apache.org/viewvc?rev=930434view=rev
Log:
Hungarian translation for Multiupload
Issue: WICKET-2798
Added:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_hu.properties
(with props)
Added:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_hu.properties
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_hu.properties?rev=930434view=auto
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_hu.properties
(added)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_hu.properties
Fri Apr 2 23:29:16 2010
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the License); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an AS IS BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+org.apache.wicket.mfu.caption.unlimited=Fel\u00f6ltend\u0151
\u00c1llom\u00e1nyok:
+org.apache.wicket.mfu.caption.limited=Felt\u00f6ltend\u0151
\u00e1llom\u00e1nyok (maximum ${max}):
+org.apache.wicket.mfu.delete=T\u00f6r\u00f6l
Propchange:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadField_hu.properties
--
svn:mime-type = text/plain
svn commit: r930446 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket: Component.java Page.java RequestListenerInterface.java
Author: ivaynberg
Date: Sat Apr 3 00:31:30 2010
New Revision: 930446
URL: http://svn.apache.org/viewvc?rev=930446view=rev
Log:
some tweaks
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/RequestListenerInterface.java
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java?rev=930446r1=930445r2=930446view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
(original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java Sat Apr
3 00:31:30 2010
@@ -4316,19 +4316,8 @@ public abstract class Component implemen
/** TODO WICKET-NG javadoc */
- public boolean canCallListenerInterface()
+ public final boolean canCallListenerInterface()
{
- if (!isEnabledInHierarchy() || !determineVisibility())
- {
- return false;
- }
- else if (getParent() != null)
- {
- return getParent().canCallListenerInterface();
- }
- else
- {
- return false;
- }
+ return isEnabledInHierarchy() isVisibleInHierarchy();
}
}
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java?rev=930446r1=930445r2=930446view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java Sat Apr 3
00:31:30 2010
@@ -1227,15 +1227,6 @@ public abstract class Page extends Marku
return renderCount;
}
- /**
-* @see org.apache.wicket.Component#canCallListenerInterface()
-*/
- @Override
- public boolean canCallListenerInterface()
- {
- return true;
- }
-
/** TODO WICKET-NG javadoc */
public final void setWasCreatedBookmarkable(boolean
wasCreatedBookmarkable)
{
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/RequestListenerInterface.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/RequestListenerInterface.java?rev=930446r1=930445r2=930446view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/RequestListenerInterface.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/RequestListenerInterface.java
Sat Apr 3 00:31:30 2010
@@ -247,7 +247,7 @@ public class RequestListenerInterface
{
// just return so that we have a silent fail and just
re-render the
// page
- log.info(component not enabled or visible; ignoring
call. Component: + component);
+ log.warn(component not enabled or visible; ignoring
call. Component: + component);
return;
}
